Commit Graph

2966 Commits

Author SHA1 Message Date
Christoph Wurst 6a3321cefe
Merge pull request #25101 from nextcloud/fix/noid/ldap-known-groups
LDAP: make actually use of batch read known groups
2021-01-29 10:57:31 +01:00
Roeland Jago Douma e29f903dc4
Merge pull request #25360 from nextcloud/fix/update-autoloaders
Update all composer autoloader files
2021-01-28 20:38:22 +01:00
Arthur Schiwon 90d82b03ef
fix parameter provided as string not array
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-28 15:15:55 +01:00
Christoph Wurst 299f37c5d9
Update all composer autoloader files
The format changed between 2.0.8 and 2.0.9.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-28 14:24:34 +01:00
Nextcloud bot b2f183a26c
[tx-robot] updated from transifex 2021-01-26 02:21:31 +00:00
Nextcloud bot 48854f26a6
[tx-robot] updated from transifex 2021-01-24 02:19:46 +00:00
blizzz 939433363e
Merge pull request #25128 from nextcloud/ldapprovider-get-property
extend ILDAPProvider to allow reading arbitrairy ldap attributes for users
2021-01-22 14:31:19 +01:00
Arthur Schiwon ef0a3a92f4
silence log message
- this appears too often (in some configurations) when qualifying group
members which do not meet the criteria

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-21 17:25:44 +01:00
Robin Appelman fdc8635afb
extend ILDAPProvider to allow reading arbitrairy ldap attributes for users
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-19 16:33:58 +01:00
Nextcloud bot 91864aeb40
[tx-robot] updated from transifex 2021-01-19 02:20:43 +00:00
blizzz f9ab7575e7
Merge pull request #25036 from nextcloud/fix/noid/limitied-allowed-items-db-in_2
respect DB restrictions on number of arguments in statements and queries
2021-01-14 11:36:42 +01:00
Arthur Schiwon 21ca5d4514
silence psalm false positive
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-13 11:54:29 +01:00
Arthur Schiwon 02b703193a
really use known groups
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-12 20:52:52 +01:00
Christoph Wurst c1d4f8161b
Migrate internal classes to the OCP db col types
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 14:09:13 +01:00
Arthur Schiwon 45e3261ad5
respect DB limits limit per statement and query
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-11 13:43:34 +01:00
Christoph Wurst 8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +01:00
Roeland Jago Douma dc89447f13
Revert "(LDAP) respect DB limits of arguments in an IN statement" 2021-01-08 10:44:32 +01:00
Arthur Schiwon 6eca8d6ae1
respect DB limits of arguments in a IN list
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-07 20:16:40 +01:00
Nextcloud bot 364b29b1e9
[tx-robot] updated from transifex 2021-01-05 02:21:26 +00:00
Christoph Wurst 9ce3ea3368
Update license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-30 14:07:05 +01:00
Roeland Jago Douma adc4f1a811
Merge pull request #22916 from J0WI/unifiy-links-to-php.net
Unify links to php.net
2020-12-22 09:53:31 +01:00
Nextcloud bot de7c54c6ba
[tx-robot] updated from transifex 2020-12-18 02:20:09 +00:00
Christoph Wurst d89a75be0b
Update all license headers for Nextcloud 21
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +01:00
blizzz f68cab4e39
Merge pull request #24402 from nextcloud/fix/24252/ldap-ingroup-memberid
LDAP: fix inGroup for memberUid type of group memberships
2020-12-15 22:33:41 +01:00
Nextcloud bot 78ca1819f6
[tx-robot] updated from transifex 2020-12-14 02:19:26 +00:00
Nextcloud bot 6f83546358
[tx-robot] updated from transifex 2020-12-09 02:19:47 +00:00
Roeland Jago Douma 54ef1a73af
Cancel 1 LDAP test for php8
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +01:00
Nextcloud bot e41e2fe003
[tx-robot] updated from transifex 2020-12-06 02:19:28 +00:00
Morris Jobke 32f6bdf067
Merge pull request #24396 from nextcloud/dont-use-system-composer
dont use system composer for autoload checker
2020-12-02 16:15:55 +01:00
Nextcloud bot 7ceb98f63b
[tx-robot] updated from transifex 2020-12-01 02:19:46 +00:00
Morris Jobke 344eacb8d8
Merge pull request #24406 from nextcloud/enhancement/ldap-install-php-to-repair-step
Migrate LDAP's install.php to a repair step
2020-11-30 11:22:35 +01:00
Nextcloud bot 099b7590a9
[tx-robot] updated from transifex 2020-11-28 02:18:24 +00:00
Arthur Schiwon af6b0ecec0
php-cs happyness
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-27 19:34:35 +01:00
Arthur Schiwon e9e61b9537
add unit tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-27 19:24:12 +01:00
Arthur Schiwon 270912848f
check number of members after potential resolving of rdns
- the type check is not necessary anymore for the return type of
  _groupMembers()

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-27 18:44:27 +01:00
Arthur Schiwon 1f40ecca86
use faster and less hungry foreach
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-27 18:38:08 +01:00
Christoph Wurst 334f3943ab
Migrate LDAP's install.php to a repair step
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-27 15:13:01 +01:00
Christoph Wurst a8437f1b18
Remove the obsolete update.php of user_ldap
This was necessary long time ago for backwards compat with older
instances that were upgraded. Since this script has been run many times
with all the previous major versions, it's finally time to remove this.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-27 12:18:06 +01:00
Tobias Perschon 594370e2f2 moved the array_reduce to fix large search case
also added some additional comments and renamed some vars to make it intuitive whats in them

Signed-off-by: Tobias Perschon <tobias@perschon.at>
2020-11-27 11:12:14 +01:00
Arthur Schiwon 57bfe0d1f9
flatten result array as expected by following code
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-26 23:36:04 +01:00
Robin Appelman 7956cef622
rebuild autoloader scripts with 2.0.7
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-26 15:49:03 +01:00
Nextcloud bot 81bf307845
[tx-robot] updated from transifex 2020-11-25 02:18:53 +00:00
Nextcloud bot 285570f546
[tx-robot] updated from transifex 2020-11-20 02:20:07 +00:00
Nextcloud bot 769f59ec65
[tx-robot] updated from transifex 2020-11-15 02:19:01 +00:00
Nextcloud bot 2d7d82f525
[tx-robot] updated from transifex 2020-11-12 02:19:24 +00:00
Joas Schilling 8027dcbc6f
Don't leave cursors open when tests fail
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-09 12:28:17 +01:00
Morris Jobke 46002a46a6
Merge pull request #23933 from nextcloud/bugfix/noid/user-ldap-ocdb
Use query builder instead of OC_DB in user_ldap
2020-11-09 10:07:25 +01:00
Joas Schilling 3f370f3732
Test requires the DB
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-09 08:40:00 +01:00
Nextcloud bot 2b2af705f7
[tx-robot] updated from transifex 2020-11-08 02:18:22 +00:00
Arthur Schiwon c96a9a9001
fix insert values
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-06 13:30:19 +01:00
Arthur Schiwon 4104416e81
only delete specified config
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-06 13:01:37 +01:00
Joas Schilling 8547934e20
Correctly place the array type 2020-11-06 12:09:58 +01:00
Joas Schilling c5b6e4bc09
Use query builder to interact with member management
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 11:28:53 +01:00
Joas Schilling 5fba0e562f
Use query builder instead of OC_DB in user_ldap
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 11:25:28 +01:00
Nextcloud bot a6719390e2
[tx-robot] updated from transifex 2020-11-03 02:19:16 +00:00
Arthur Schiwon 3a51160221
fix potentially passing null to events where IUser is expected
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-30 16:30:01 +01:00
Arthur Schiwon fd44087530
adds unit test for updategroups background job
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-30 16:30:00 +01:00
Morris Jobke 0053ec82ac
Document the backend registered events of LDAP
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-29 09:18:46 +01:00
Arthur Schiwon fd1fd5afa4
user share manager to determine share ownership
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-26 16:05:28 +01:00
Arthur Schiwon 951887e922
fixes determining whether former user is a share owner
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-26 16:05:28 +01:00
Arthur Schiwon 2e455f632a
split instantiation from business logic in OfflineUser
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-26 16:05:28 +01:00
Arthur Schiwon 002c56de17
add test for active shares flag
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-26 16:05:23 +01:00
Arthur Schiwon 86e5e7d927
LDAP simplify User_Proxy and Group_Proxy signatures
- make User_Proxy and Group_Proxy easy to instantiate
- simplify dependent code
- move commands to info.xml
- make UpdateGroups job class non-static

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-23 12:25:31 +02:00
Arthur Schiwon 2ee26b691c
tame psalm. why does it ignore '@property'?
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-19 13:44:32 +02:00
Arthur Schiwon d741c5ab30
when nesting is not enabled, the group filter can be applied right away
- helps performance, but skipping unnecessary entries
- reduces reoccuring info-level log output against groups that do not
  qualify ("no or empty name")

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-19 13:44:32 +02:00
Nextcloud bot 8ae4ff6648
[tx-robot] updated from transifex 2020-10-12 02:18:06 +00:00
Nextcloud bot 4295fe67b7
[tx-robot] updated from transifex 2020-10-10 02:18:44 +00:00
Christoph Wurst d9015a8c94
Format code to a single space around binary operators
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +02:00
Roeland Jago Douma fe30bfd232
Update autloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-24 14:59:41 +02:00
Nextcloud bot d77d52d257
[tx-robot] updated from transifex 2020-09-21 02:17:24 +00:00
Joas Schilling 48761481eb
Bump versions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-18 09:16:45 +02:00
J0WI 68ce17e59b Unify links to php.net
Update all links to https://www.php.net/

Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-09-17 17:40:04 +02:00
Nextcloud bot 869f3f5895
[tx-robot] updated from transifex 2020-09-15 10:48:26 +00:00
Arthur Schiwon b95e63b8da
announce added user and group backend later as there might be interdeps
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-11 00:14:06 +02:00
Arthur Schiwon 263f5bd1d9
switch to typed event for LDAPs user added to group case
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-10 12:57:10 +02:00
Christoph Wurst 1f7f93a695
Update license headers for Nextcloud 20 (again)
There are still lots of outdated headers, so time for another round of
updates.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-09-07 14:37:44 +02:00
Arthur Schiwon aa2d754d5c
add repair step to clean up DB off lastFeatureRefresh entries in user prefs
- also removes related app setting "updateAttributesInterval"

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-04 12:59:57 +02:00
Arthur Schiwon 699871dcb0
these code bits were part of old logic that was already refactored out
- only references were in unit tests

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-04 12:56:43 +02:00
Nextcloud bot f6ad09ad58
[tx-robot] updated from transifex 2020-08-27 02:16:40 +00:00
Christoph Wurst 2a054e6c04
Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
Nextcloud bot bcbe1e1c9d
[tx-robot] updated from transifex 2020-08-22 02:16:27 +00:00
Morris Jobke fedf9c69d9
Use matching parameter names form interfaces and implementations
Found by Psalm 3.14.1

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 18:16:35 +02:00
Morris Jobke d7f66c36ac
Fix "misplaced variables" warning of Psalm in PHPDoc statements
Ref #21787

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-17 17:46:57 +02:00
blizzz 6e8e34fef9
Merge pull request #22221 from nextcloud/fix/19097/ldap-depracted-event
provide event class and typed event to LDAP loaded event; also fixing a logged deprecation message
2020-08-14 16:07:12 +02:00
Nextcloud bot 9bd58553db
[tx-robot] updated from transifex 2020-08-14 02:31:59 +00:00
Nextcloud bot 3a39f2ae91
[tx-robot] updated from transifex 2020-08-13 02:16:38 +00:00
Arthur Schiwon 44cad1756c
provide event class to LDAP loaded event to fix deprecation message
* and also dispatch the typed event as current approach to it

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-12 15:38:47 +02:00
Morris Jobke 55e79b8a6a
Merge pull request #22199 from nextcloud/techdebt/noid/PHPUnit_Framework_MockObject_MockObject
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to …
2020-08-12 13:55:36 +02:00
Morris Jobke 234b510652
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-12 13:55:19 +02:00
Arthur Schiwon 5257efc5f2
remove logging message carrying no valuable information
the exception caught is not an error, but due to valid configuration and
code flow is expecting this. For an admin it is confusing, and it carries
no information worth for debugging.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-12 09:10:23 +02:00
Arthur Schiwon 7eb6d8df0a
do not flip available state to unavailable, allow empty results
- the detection relies that the first, requested result is not empty
- it might be empty though – groups without members
- protect switching from available to unavailable
  - switching the other way around was also not envisaged either

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-11 19:03:27 +02:00
Arthur Schiwon 7ea262dba0
LDAP: shortcut in reading nested group members when IN_CHAIN is available
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-11 18:22:11 +02:00
Morris Jobke 548576ec10
Merge pull request #22176 from nextcloud/debt/noid/table-render-too-many-arguments
Remove unexpected argument
2020-08-11 09:44:28 +02:00
Daniel Kesselberg 7b68f0f326
Remove unexpected argument
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-10 22:36:30 +02:00
Arthur Schiwon 7c07f0c7f3
use break not continue in switch to avoid warning
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-10 17:34:11 +02:00
blizzz 579c7073f3
Merge pull request #16737 from tofuSCHNITZEL/feature-zimbraldap
new Group-Member association attribute (zimbraMailForwardingAddress)
2020-08-07 22:20:50 +00:00
Tobias Perschon 551d904bb0
added "zimbraMailForwardingAddress" as a Group-Member association attribute to enable the use of Zimbra Distribution Lists as groups in nextcloud when connecting to a zimbra LDAP
Signed-off-by: Tobias Perschon <tobias@perschon.at>

fix cs:check

Signed-off-by: Tobias Perschon <tobias@perschon.at>

Update apps/user_ldap/lib/Group_LDAP.php

Co-authored-by: blizzz <blizzz@arthur-schiwon.de>
Signed-off-by: Tobias Perschon <tobias@perschon.at>
2020-08-07 23:30:44 +02:00
Morris Jobke 54726d5934
Merge pull request #21738 from nextcloud/techdebt/14552/migrate-OC_Group-post_removeFromGroup
Migrate OC_Group post_removeFromGroup hook to actual event object
2020-08-07 17:46:00 +02:00
Nextcloud bot cb1d9cfaf0
[tx-robot] updated from transifex 2020-08-06 02:17:11 +00:00
Morris Jobke 21095beb67
Merge pull request #22043 from nextcloud/fix/21892/reset-internal-cookie-state
reset the cookie internally in new API when abandoning paged results op
2020-07-31 10:14:11 +02:00