Commit Graph

55208 Commits

Author SHA1 Message Date
Morris Jobke d7f66c36ac
Fix "misplaced variables" warning of Psalm in PHPDoc statements
Ref #21787

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-17 17:46:57 +02:00
Morris Jobke 00cb8e6c54
Merge pull request #22253 from nextcloud/debt/noid/docblocks
Fix some MissingDocblockType or InvalidDocblock warnings.
2020-08-17 17:45:11 +02:00
Morris Jobke e47cfc9a54
Properly add new methods to interface and document in PHPDoc for getRootMounts()
Introduced in #22063 and was just forgotten.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-17 17:13:46 +02:00
Morris Jobke f406f5dc73
Fix TagService DI name
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-17 16:55:16 +02:00
Christoph Wurst 07fcf14324
Migrate files to the PSR container
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-17 09:45:11 +02:00
dependabot-preview[bot] f6daf17fa7
Merge pull request #22262 from nextcloud/dependabot/npm_and_yarn/sinon-9.0.3 2020-08-17 06:24:34 +00:00
Roeland Jago Douma ad0c44420a
Merge pull request #22261 from nextcloud/dependabot/npm_and_yarn/jsdom-16.4.0
Bump jsdom from 16.3.0 to 16.4.0
2020-08-17 06:43:10 +02:00
Roeland Jago Douma 253bd84620
Merge pull request #22260 from nextcloud/dependabot/npm_and_yarn/lodash-4.17.20
Bump lodash from 4.17.19 to 4.17.20
2020-08-17 06:42:27 +02:00
dependabot-preview[bot] 1328fd7cf0 Bump lodash from 4.17.19 to 4.17.20
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.20.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.19...4.17.20)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-08-17 03:30:20 +00:00
Nextcloud bot bfef24b6df
[tx-robot] updated from transifex 2020-08-17 02:16:39 +00:00
Nextcloud bot 29b7e5885e
[tx-robot] updated from transifex 2020-08-16 02:16:28 +00:00
dependabot-preview[bot] 0accd6592f
Bump sinon from 9.0.2 to 9.0.3
Bumps [sinon](https://github.com/sinonjs/sinon) from 9.0.2 to 9.0.3.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sinonjs/sinon/compare/v9.0.2...v9.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-15 02:38:21 +00:00
dependabot-preview[bot] da6dbb18c0
Bump jsdom from 16.3.0 to 16.4.0
Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.3.0 to 16.4.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md)
- [Commits](https://github.com/jsdom/jsdom/compare/16.3.0...16.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-15 02:37:38 +00:00
Nextcloud bot 31eccc842d
[tx-robot] updated from transifex 2020-08-15 02:17:13 +00:00
Daniel Kesselberg 3e7b815da4
Fix more MissingDocblockType or InvalidDocblock warnings.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-14 20:19:23 +02:00
Morris Jobke fb4e989882
Merge pull request #22257 from nextcloud/debt/noid/add-parameter-to-set
Update documentation for QueryBuilder::set
2020-08-14 20:15:16 +02:00
Daniel Kesselberg 10ac844448
Update documentation for QueryBuilder::set
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-14 19:55:01 +02:00
Georg Ehrke 5b26487f14
Expose status via Collaborators API
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-14 17:04:52 +02:00
blizzz 6e8e34fef9
Merge pull request #22221 from nextcloud/fix/19097/ldap-depracted-event
provide event class and typed event to LDAP loaded event; also fixing a logged deprecation message
2020-08-14 16:07:12 +02:00
Morris Jobke 7d550e3679
Merge pull request #18969 from nextcloud/enh/apps/use-sidebar
Migrate app management settings to proper sidebar standards
2020-08-14 15:44:04 +02:00
Daniel Kesselberg 6f8147b18f
Fix some MissingDocblockType or InvalidDocblock warnings.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-14 15:10:48 +02:00
John Molakvoæ (skjnldsv) 8e7c95effb
Use appsidebar for apps
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-14 11:44:16 +02:00
John Molakvoæ (skjnldsv) 228a96508a
Use appsidebar for apps
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-14 09:56:00 +02:00
Morris Jobke b13aa660c9
Merge pull request #22243 from nextcloud/fix/20490/no_session_duplicate_warnings
Silence duplicate session warnings
2020-08-14 09:22:24 +02:00
dependabot-preview[bot] bc19168719
Merge pull request #22198 from nextcloud/dependabot/npm_and_yarn/vue-router-3.4.3 2020-08-14 06:02:44 +00:00
Julius Härtl 00e62171d2
Test for locking state in key generation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-14 07:58:41 +02:00
Julius Härtl 36cfdd320b
Harden key generation
There might be cases where multiple requests trigger the key generation
at the same time and the instance ends up with a non-fitting
public/private key pair. Therefore the whole key generation should be
locked. Other than that this makes sure that user key generation return
values are properly validated.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-14 07:58:40 +02:00
dependabot-preview[bot] 4e2c4c4ac6 Bump vue-router from 3.3.4 to 3.4.3
Bumps [vue-router](https://github.com/vuejs/vue-router) from 3.3.4 to 3.4.3.
- [Release notes](https://github.com/vuejs/vue-router/releases)
- [Changelog](https://github.com/vuejs/vue-router/blob/dev/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-router/compare/v3.3.4...v3.4.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-08-14 05:31:29 +00:00
Roeland Jago Douma f1dd87dc50
Merge pull request #22200 from cweiske/duplicated-sql-where-line
Remove duplicated SQL addWhere line
2020-08-14 05:43:42 +02:00
Roeland Jago Douma 8daaf33e3d
Silence duplicate session warnings
Fixes #20490

Basically restroring the old behavior.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-14 05:23:11 +02:00
Nextcloud bot 9bd58553db
[tx-robot] updated from transifex 2020-08-14 02:31:59 +00:00
Gary Kim 5559570faf
Merge pull request #22242 from nextcloud/techdebt/noid/remove-deprecated-methods
Remove deprecated and unused method calls
2020-08-14 10:10:53 +08:00
Morris Jobke 75c659cfbc
Merge pull request #20451 from exussum12/AllowPreviewWhenGeneratorHasBeenRemoved
Always try and show pre rendered preview
2020-08-13 23:49:56 +02:00
Morris Jobke 8e249569af
Fix existing test and add a specific one for the new case
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 23:24:21 +02:00
Scott Dutton b12a390220
Always try and show pre rendered preview
Currently if the following situation happens

Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets a 404 error when preview exists
(Mime checked before preview)

This happens more often with documents, or video as the commands are not
native PHP, they require a binary on the server.

After the fix the following would happen

Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets preview which has been generated
(Mime checked after preview)

This would also allow offline generation (for example a docker image
containing the extra binaries), allowing a reduction in attack surface
of the instance serving the preview data.

Signed-off-by: Scott Dutton <scott@exussum.co.uk>
2020-08-13 22:50:38 +02:00
Morris Jobke 16d83ab30a
Remove getLastJob from IJobList
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 21:50:06 +02:00
Morris Jobke afd52c6b12
Remove setCustomJs of the files_external FrontendDefinitionTrait
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 21:49:50 +02:00
Morris Jobke e9f5c7f649
Merge pull request #22128 from nextcloud/bugfix/noid/cleanup-chunks-on-failure
Delete chunks if the move on an upload failed
2020-08-13 20:47:08 +02:00
Georg Ehrke ee23906c3c
Allow writing empty content to new file
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-13 15:41:26 +02:00
Julius Härtl 6722246aca
Return proper status when file didn't exist before
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-13 15:26:42 +02:00
Julius Härtl 52eff4ae7c
Use user mount with matching shared storage only
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-13 15:10:05 +02:00
Morris Jobke ed46115593
Merge pull request #22235 from nextcloud/fix/22217/fix-naming-of-app-config-option
Fix name of app config option to properly reflect what it does
2020-08-13 14:49:01 +02:00
Morris Jobke 93ba8faabc
Fix name of app config option to properly reflect what it does
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 13:34:31 +02:00
Morris Jobke 89f92e3c22
Merge pull request #22229 from nextcloud/bugfix/noid/dashboard-outdated-bundles
Bump outdated dashboard bundles
2020-08-13 10:58:54 +02:00
Morris Jobke 0b856329eb
Merge pull request #22202 from nextcloud/enh/noid/cleanup-servercontainer
Use autowiring where possible in server container
2020-08-13 10:55:48 +02:00
Julius Härtl ac95e069c4
Bump outdated dashboard bundles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-13 10:10:40 +02:00
Roeland Jago Douma 34cd49827c
Merge pull request #21788 from nextcloud/debt/noid/unused-method
Remove unused method uploadFile
2020-08-13 09:40:38 +02:00
Morris Jobke 3c56922444
Merge pull request #22205 from nextcloud/activity-settings-cleanup
merge file activity settings into a single 'favorite changed' item
2020-08-13 08:15:06 +02:00
Daniel Kesselberg ba3a855ad8
Remove unused method uploadFile
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-13 08:02:28 +02:00
Morris Jobke df4bcd616f
Add @deprecated labels for server DI containter aliases
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 07:43:37 +02:00