067945ff10
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-08-21 04:21:23 +00:00
d58e71f0e6
Fix psalm warnings
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 21:12:15 +02:00
bb8be58386
Fix psalm warnings
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 18:30:48 +02:00
8381af626f
Accept psalm warning for now
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 16:46:00 +02:00
69bbbc32a1
Extend psalm baseline to ignore errors for now
...
One is a false positive - see https://github.com/vimeo/psalm/pull/4032
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 14:20:56 +02:00
70d1d1997a
new weather status used in dashboard
...
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2020-08-20 00:21:08 +02:00
d8bdb439a4
Merge pull request #22289 from nextcloud/techdebt/noid/fix-encryption-stream-invalid-scalar-arguments
...
Cast float to int to avoid invalid scalar argument warning
2020-08-19 22:08:15 +02:00
c449d54204
Merge pull request #22304 from nextcloud/techdebt/noid/matching-param-names
...
Use matching parameter names form interfaces and implementations
2020-08-19 19:34:02 +02:00
4c6eb96471
Merge pull request #22280 from nextcloud/bugfix/noid/429-on-brute-force-maximum
...
Send "429 Too Many Requests" in case of brute force protection
2020-08-19 18:21:01 +02:00
fedf9c69d9
Use matching parameter names form interfaces and implementations
...
Found by Psalm 3.14.1
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 18:16:35 +02:00
60be722ee8
Merge pull request #22288 from nextcloud/techdebt/noid/fix-oc_image-invalid-scalar-arguments
...
Cast float/char to int to avoid invalid scalar argument warning
2020-08-19 17:55:56 +02:00
e93bf71369
Fix the return type of OC_Template->fetchPage() to be string only
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 16:48:06 +02:00
5ced155032
Merge pull request #22285 from nextcloud/techdebt/noid/move-to-typed-event-in-list.php
...
Use dispatchTyped instead of dispatch on the new event dispatcher
2020-08-18 21:29:48 +02:00
a5853d7ecc
Use dispatchTyped instead of dispatch on the new event dispatcher
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 20:27:46 +02:00
560ccf5d83
Cast float to int to avoid invalid scalar argument warning
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 16:56:36 +02:00
27e7332a9c
Cast float/char to int to avoid invalid scalar argument warning
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 16:51:59 +02:00
4c4f4685dc
Update psalm baseline due to fixes in #22236
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 16:49:36 +02:00
42bb6cd7d7
Check only the baseline.xml and exclude the psalm.xml from the file check
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 13:01:10 +02:00
c6b251ca0c
Add patches for stubs
...
* https://github.com/JetBrains/phpstorm-stubs/pull/893
* https://github.com/JetBrains/phpstorm-stubs/pull/894
* https://github.com/JetBrains/phpstorm-stubs/pull/895
* https://github.com/JetBrains/phpstorm-stubs/pull/896
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 13:01:10 +02:00
b70792aa6a
Add stubs for gd, intl, IntlChar, ldap, redis_cluster and xsl
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 13:01:10 +02:00
4efca69f8d
Add psalm baseline
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 12:59:17 +02:00
8b3b5ae5be
Add stubs for phpseclib
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-18 08:58:19 +02:00
7257793fc4
Hello psalm
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-18 08:58:19 +02:00
79fc7e78b7
Merge pull request #21138 from nextcloud/fix/noid/search-in-group-displayname-email
...
Search also the email and displayname in user mangement for groups
2020-08-05 16:09:00 +02:00
907d3542dc
Add integration tests for search in groups
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-05 14:14:06 +02:00
8d5f5e8f8c
Fix integration test fail
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-03 13:43:15 +02:00
8e1d334258
Bump jsdoc from 3.6.4 to 3.6.5 in /build
...
Bumps [jsdoc](https://github.com/jsdoc/jsdoc ) from 3.6.4 to 3.6.5.
- [Release notes](https://github.com/jsdoc/jsdoc/releases )
- [Changelog](https://github.com/jsdoc/jsdoc/blob/3.6.5/CHANGES.md )
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.4...3.6.5 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-25 01:15:12 +00:00
94ae095051
Bump lodash from 4.17.14 to 4.17.19 in /build
...
Bumps [lodash](https://github.com/lodash/lodash ) from 4.17.14 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.14...4.17.19 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-07-16 07:23:29 +00:00
aed5eb55af
Merge pull request #21843 from nextcloud/debt/noid/less-verbose-translation-checker
...
Make translation-checker.php less verbose
2020-07-15 19:37:51 +02:00
8dd48f3dc8
Fix integration test due to new dashboard app
...
See #21346
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-15 14:07:59 +02:00
5ffe9fc7db
Make translation-checker.php less verbose.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-07-15 11:29:12 +02:00
e0fbf4d033
Add more integration tests for resharing permissions
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-07-09 11:14:44 +02:00
3333c885c0
Merge pull request #21264 from stweil/master
...
build: Fix some typos (most of them found by codespell)
2020-07-05 22:52:28 +02:00
dc175d4ecc
Fix typo in variable name and make check more accurate
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-01 10:48:38 +02:00
e2100856ad
Add another test for exact matching of a user in group restriction
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-17 12:06:50 +02:00
cdcd61d4c8
Use empty for the OCP @since checker
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-09 08:49:24 +02:00
72f853424b
build: Fix two typos in function names
...
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2020-06-06 15:57:08 +02:00
e8af52001e
build: Fix some typos (most of them found by codespell)
...
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2020-06-06 13:03:00 +02:00
b192c04dc2
Add integration tests for video verification
...
Enabling the "send password by Talk" property of shares require that
Talk is installed and enabled, so the Drone step that runs them has to
first clone the Talk repository.
When the integration tests are run on a local development instance,
however, it is not guaranteed that Talk is installed. Due to this the
"@Talk" tag was added, which ensures that any feature or scenario marked
with it will first check if Talk is installed and, if not, skip the
scenario (instead of failing).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:50:30 +02:00
a2f80d4f4c
Add integration tests for creating and updating a mail share
...
In most cases, when a mail share is created or updated an e-mail is sent
to the sharee, which is done by connecting to the SMTP server set in the
configuration. If the server can not be contacted then the creation or
update of the mail share fails.
To make possible to test mail shares without using a real SMTP server a
fake one has been added. The original script, which is MIT licensed, was
based on inetd, so it was slightly modified to run on its own.
In order to use it from the integration tests the "Given dummy mail
server is listening" step has to be called in the scenarios in which the
mail server is needed.
For now that is the only available step; things like checking the sent
mails, while possible (as the script can log the mails to certain file),
have not been added yet.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:50:29 +02:00
7817f8578b
Generalize integration test steps to download last share
...
Note that the "last link share can be downloaded" step was kept as it
tests the "url" property specific of link shares.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:46:12 +02:00
6e49d3bb94
Remove unused variables
...
The step names were adjusted accordingly.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:46:12 +02:00
bd0a1b6e7d
Merge pull request #20586 from nextcloud/techdebt/noid/make-image-optimization.sh-better-readable
...
Improve build/image-optimization.sh
2020-05-21 09:48:55 +02:00
108faf25c0
Update public link share permission code
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-15 08:18:03 +02:00
c84a82bc0c
Bump node-sass from 4.14.0 to 4.14.1 in /build
...
Bumps [node-sass](https://github.com/sass/node-sass ) from 4.14.0 to 4.14.1.
- [Release notes](https://github.com/sass/node-sass/releases )
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sass/node-sass/compare/v4.14.0...v4.14.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-10 01:16:27 +00:00
d9e5925201
Merge pull request #20655 from nextcloud/dependabot/npm_and_yarn/build/node-sass-4.14.0
...
Bump node-sass from 4.13.0 to 4.14.0 in /build
2020-04-29 16:15:04 +02:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
b836bcf040
Bump node-sass from 4.13.0 to 4.14.0 in /build
...
Bumps [node-sass](https://github.com/sass/node-sass ) from 4.13.0 to 4.14.0.
- [Release notes](https://github.com/sass/node-sass/releases )
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sass/node-sass/compare/v4.13.0...v4.14.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-29 08:27:58 +00:00
1738e17e20
Merge pull request #19793 from nextcloud/bugfix/noid/link-to-federated-reshare
...
Fix resharing of federated shares that were created out of links
2020-04-27 11:05:34 +02:00
7a9469f282
Adjust integration tests to new permissions
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-23 16:22:48 +02:00
Nextcloud-PR-Bot
Morris Jobke
Julien Veyssier
Daniel Kesselberg
Joas Schilling
dependabot-preview[bot]
dependabot[bot]
Daniel Calviño Sánchez
Christoph Wurst
Stefan Weil
Roeland Jago Douma
Roeland Jago Douma
Julius Härtl