1f9d728538
Ignore invalid paths in the JS file list ( #25368 )
2016-07-06 11:55:02 +02:00
d623763aac
Add "goto" links for files in non-default file lists
2016-07-05 22:22:55 +02:00
5b4cea4b36
Merge pull request #275 from nextcloud/master-sync-upstream
...
[Master] Sync upstream
2016-07-01 18:31:51 +02:00
76c73d5ec3
Match on 405
2016-07-01 15:19:21 +02:00
4ac9eaab03
Match for /../
2016-07-01 15:01:48 +02:00
5b65591d84
Do not allow directory traversal using "../"
...
We should not allow directory traversals using "../" here.
To test access the following URL once with and then without this patch:
http://localhost/server/index.php/apps/files/?dir=../../This+Should+Not+Be+Here
2016-07-01 13:36:05 +02:00
179a355b2c
Merge remote-tracking branch 'upstream/master' into master-sync-upstream
2016-07-01 11:36:35 +02:00
4acb06923d
Filelist change dir auto-prepend slash
...
Prepend a slash to directories in case it was missing since many places
assume that it's there.
2016-07-01 11:10:37 +02:00
5cfbb9624f
Prevent infinite loop in search auto-nextpage
...
When loading the next page of search results, make sure that the loop
can end if there are no more elements in case the total doesn't match.
Also added a check to avoid recomputing the search results whenever the
setFilter() is called with the same value. This happens when navigating
away to another folder, the search field gets cleared automatically and
it calls FileList.setFilter('').
2016-06-30 11:10:48 +02:00
6670d37658
Merge remote-tracking branch 'upstream/master' into master-sync-upstream
2016-06-27 18:23:00 +02:00
b4cf297758
Prerender file list pages to include search results
...
When filtering the file list, if a result is on an unrendered page,
make sure to call _nextPage() to prerender the pages in order to
display all matching results.
2016-06-24 13:55:14 +02:00
203a07e7f3
change folder icon when dragging over a directory
2016-06-15 01:03:59 +02:00
937d21ed29
properly fix folder upload to use delegatedEvent
2016-06-14 11:51:03 +02:00
76c0bc29fe
Merge pull request #20150 from pellaeon/pr-droppable-hover-visual-cue
...
Add visual cue when moving draggable item over droppable item,
2016-05-30 16:03:36 +02:00
83aa28ed1d
My fix for #24272 , #23613 , File not found when single file in a folder ( #24800 )
...
* Fixed group share searching for members of
multiple group. Issue #11808 .
* Fixed group share searching, continued.
Avoid searching for empty group list in getItemSharedWithUser().
Broke tests in previous commit, #12030 .
* Simler check for group count.
* Fix for https://github.com/owncloud/core/issues/24783 , described there
* Now it's #24272 , 24783 was a duplicate. Previous change was also not very good. Now we don't create ZIP with a single file inside.
2016-05-24 14:09:05 +02:00
72ac5dd8a1
Make entire file tr droppable,
...
so that .canDrop will highlight the entire row when drag hover
2016-05-21 12:54:29 +08:00
2a7d3dd831
dont update search onResize
...
this.updateSearch() sets the current file list instance and clears the box. This is unnecessary and makes the search box unsuable on some mobile devices where a keyboard fade-in causes a onResize trigger, which would then clear and blur the box.
2016-05-17 22:57:07 +02:00
88da2966b4
Merge pull request #22341 from owncloud/pellaeon-pr-breadcrumb-filelist-overlap-drop
...
Handle case when breadcrumb and filelist item overlap and both receive a drop
2016-05-13 17:12:36 +02:00
fdeafef6a0
Auto-add fileid in URL for currently displayed folder
2016-05-06 16:46:59 +02:00
df2a9d1733
OCA.Files.App is not available on public page
2016-04-21 14:23:18 +02:00
1ab27ddd4a
Merge pull request #24081 from owncloud/migrate-deprecated-jquery-v1-functions
...
migrate deprecated jQuery 1.x functions
2016-04-20 20:38:38 +02:00
6c5696d3a8
filter hidden files on the web interface
...
add checkbox to toggle show/hide hidden files
persist show hidden setting
fix settings menu layout
test ApiController::showHiddenFiles
don't show hidden files by default
Store config in Backbone model and inject it into FileList
Filter files only temporarily when rending the file list
Fix file rename validation
2016-04-19 16:08:56 +02:00
05d203a989
replace $.parseJSON() by JSON.parse()
2016-04-19 15:06:42 +02:00
37530f27f0
migrate jQuery.fn.unload()
2016-04-19 12:05:09 +02:00
63a385d2b8
Merge pull request #23933 from owncloud/remember-file-sorting
...
remember file sort order
2016-04-15 14:06:21 +02:00
576f7244e6
fix default value, update js/php tests
2016-04-13 14:25:23 +02:00
a4683bcfa9
persist file sorting changes
2016-04-13 11:28:42 +02:00
3f492dd826
load file sorting mode from the db
2016-04-13 11:28:42 +02:00
4d02233faa
restore selection after re-rendering file rows
2016-04-13 11:20:26 +02:00
bba28590b7
Remove xxx from ownCloud we dont want to see that 🙈
2016-04-07 12:18:44 +02:00
a8a98d42cb
improve emptycontent styles
2016-03-31 15:31:04 +02:00
50655cbf7f
sidebar click modification
2016-03-24 11:57:40 +01:00
48430d4481
Handle case when breadcrumb and filelist item overlap
...
and both receive a drop.
Build breadcrumb over and out callback in filelist.js and
pass them as options to utilize local selectors of filelist
Re-enable td elements after drop to bread crumb
Fix# drop handler still being called after enable,
it seems that waiting for a short time before re-enabling solves the
problem
* Add explanations for setTimeout re-enable td.filename drop handler
2016-03-17 10:20:57 +01:00
692f312513
apps/files: Fix typos in comments (found and fixed by codespell)
...
This contribution is AGPL and MIT licensed.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2016-03-09 15:14:05 +01:00
dbdf2173ac
Return false on 401 in file list + trash file list
...
This gives a chance to the global ajax error handler to do its work if
the session expired.
2016-03-03 09:09:30 +01:00
92cff0984d
Make file actions use icon CSS classes
...
This makes theming of file actions possible
2016-02-25 22:49:52 +01:00
7af7d18cfa
Merge pull request #16783 from owncloud/handle-redirects-global
...
Adding global error handler for ajax calls which run into redirection…
2016-02-17 14:49:04 +01:00
d565290d16
Close file detail sidebar when selecting/unselecting files
...
Interacting with the checkboxes, also "Select all" will automatically
close the sidebar now.
2016-02-15 14:58:44 +01:00
b8b77709c0
Add handler for global ajax errors
2016-02-15 12:48:47 +01:00
ae367c7e97
Fix elementToFile to also return path when defined
...
Fixes issue when opening the share dialog for a file inside the favorite
list, and the file is from a subfolder
2016-02-08 22:33:39 +01:00
a49aff2db7
Only check selection for delete permissions, not parent folder
2016-01-15 16:52:51 +00:00
ace66057f2
Fixed issue #21452
...
removed whitespace
removed whitespace
Changed it based on PVince81's suggestion
2016-01-13 14:47:00 +01:00
86735c6b5a
Updating a file should not update the summary
2016-01-09 22:07:34 +01:00
7693c6d84a
Merge pull request #21254 from owncloud/files-uploadcanceliconfix
...
Correctly render uploadtext indicator only on folders
2015-12-28 10:21:38 +01:00
ca14277fca
Make a modifiable copy of the webdav properties in JS file list
...
Plugins can extend _getWebdavProperties to add custom properties.
These should not be added to the original properties list, so now the
FileList makes a copy of the array.
2015-12-22 11:17:24 +01:00
7ecb9696ba
Use showBusyState for upload into folder
...
This makes sure that the original icon will be restored properly in case
it's not the default folder icon
2015-12-18 18:09:54 +01:00
d27826bac0
Correctly render uploadtext indicator only on folders
2015-12-18 18:09:46 +01:00
4d9e12b8bc
Fix mount type root detection
...
Since Webdav doesn't contain that information, we need to rely on the
parent folder's mount type to find out whether a child item is a
shared/external root or not.
Fixed the mount type detection logic and added unit test.
Also added a fix that ignores detection if no parent folder exists (ex:
shared file list, favorites, etc)
2015-12-14 10:44:47 +01:00
d3383adb71
Fix issue when renaming creates a separate entry
2015-11-22 16:05:51 +01:00
dc8ce87a26
Query tags/favorite through Webdav in file list
2015-11-22 16:05:50 +01:00
fa2be0750c
Make files app use Webdav for most operations
2015-11-22 16:05:50 +01:00
3c01386a50
Merge pull request #20156 from owncloud/files-filter-triger-once
...
dont trigger the scroll event of every single item we filter in the file list
2015-10-30 12:52:04 +01:00
860e31a333
dont trigger the scroll event of every single item we filter in the file list
2015-10-29 16:30:56 +01:00
9c9158e6b7
Fix icon update to be more consistent
...
Makes the details bar show the same icon as in the list.
2015-10-29 12:59:51 +01:00
e36c85178f
Do not display details bar after rename
2015-10-21 13:43:39 +02:00
204b3ca189
Do not register sidebar panels when no sidebar
2015-10-15 16:30:50 +02:00
d8f0afaf9f
Merge pull request #19634 from owncloud/notif-showtemporary
...
showTemporary instead of show for notifications
2015-10-14 12:50:55 +02:00
b090ed7666
Merge pull request #19747 from owncloud/files-delete-hidenotif
...
Hide notification on delete
2015-10-14 12:49:22 +02:00
cdc1386885
Hide notification on delete
...
In case a permanent notification "storage full" was displayed, it will
be hidden after deleting a file.
Directly after that a getstoragestats.php call is made that will decide
whether to reshow the notification based on the new free space.
2015-10-13 17:24:52 +02:00
ecb10db039
Remove controls for file lists that don't need it
...
Remove controls from sharing overview and favorite file lists which
don't display paths.
2015-10-13 11:36:24 +02:00
5bf43ec60a
showTemporary instead of show for notifications
2015-10-08 10:52:39 +02:00
c17d60165a
Fix tooltip placement on rename error
2015-10-05 17:44:25 +02:00
f135128664
Fix filelist size issues, breadcrumb, multiselect
...
- calculate multiselect header width to exclude scrollbar
- call FileList._onResize() when sidebar is toggled ("appresized"), this
also updates the breadcrumb width
- moved global getScrollBarWidth() to OC.Util namespace
2015-10-02 18:03:48 +02:00
1d8c10cf63
Merge pull request #19468 from owncloud/fix-36-vs-32-previews
...
Change small thumbnails to 32 px
2015-09-30 15:47:34 +02:00
750f19340f
Merge pull request #19310 from owncloud/hide-sort-indicator
...
hide sort indicator when in multiselect mode, ref #19056
2015-09-30 11:07:45 +02:00
1051a3c6f5
Change small thumbnails to 32 px
...
* fixes #16913
* fixes issues in IE8 where the thumbnail is too big
2015-09-30 10:49:48 +02:00
733673b39d
Merge pull request #19365 from owncloud/files-detailsbar-interaction
...
Fix sidebar interaction
2015-09-29 14:44:28 +02:00
d52361b09b
Disable sorting when multiselect is enabled in file list
2015-09-29 13:24:33 +02:00
cc8efaa037
Show conflict dialog before upload when possible
...
When uploading files, first check if the files exist in the current file
list. For the ones that do, show a conflict dialog.
For the rest, upload directly.
If the upload operation detects a conflict on the server side, it will
also continue populating the conflict dialog.
From now on, server side conflict can only occur if someone concurrently
uploaded a file into the same folder but the current user hasn't
refreshed the list yet.
2015-09-28 17:50:11 +02:00
f9acf4627e
Fix sidebar interaction
...
- Clicking a file row or selecting it will open the sidebar.
- When sidebar is open, its contents update with the last selection.
- Dragging doesn't open the sidebar but does update its contents if it was
open already.
- Switching folders closes the sidebar.
- Close sidebar when highlighted file got deleted/removed from list
2015-09-28 15:23:37 +02:00
f35b6833ff
Fix order of actions in the files actions menu
2015-09-28 11:19:49 +02:00
46475b8114
Switch from Math.floor() to Math.ceil() when sending the dimension to Preview
...
Fixes #18203
2015-09-27 12:46:25 +02:00
28d3c1cc0b
fix filelist checkboxes
2015-09-25 00:51:39 +02:00
4c62d71db7
Merge pull request #19277 from owncloud/files-plusbuttonfix
...
Only render the plus button when it makes sense
2015-09-23 11:31:52 +02:00
9fbd3fa6c1
Merge pull request #19270 from owncloud/files-sidebar-fixfortrashandco
...
Properly show sidebar for trash and sharing sections
2015-09-22 23:53:15 +02:00
a7d84287ad
Only render the plus button when it makes sense
2015-09-22 16:47:52 +02:00
fa725fba73
Properly show sidebar for trash and sharing sections
2015-09-22 15:28:48 +02:00
a35144e961
Properly translate file actions
2015-09-22 14:52:52 +02:00
4d77fac191
Merge pull request #19048 from owncloud/details-icon
...
add details icon for file actions dropdown
2015-09-16 13:56:30 +02:00
2356ba2494
fix accessibility of New button, use alt text instead of tooltip
2015-09-16 11:51:58 +02:00
e7e0cfe93d
Properly show sidebar when clicking on share button
2015-09-16 07:23:29 +02:00
e90065881d
Bring back the share icon and update its status
...
Display share icon in file list row.
Update share icon status when the sharing state changed.
2015-09-16 07:23:28 +02:00
d1f7087b6c
Merge pull request #18979 from owncloud/sidebare-preview-fixes
...
Sidebare preview fixes
2015-09-16 00:12:25 +02:00
7ab57f7f27
Add details icon for details menu item
2015-09-15 17:52:01 +02:00
19e1d35373
Fix path for fileinfomodel in subdirectories
2015-09-15 14:29:37 +02:00
d0cea82969
Fixed sidebar toggle entry
...
Properly highlight the row after selecting the item.
This also fixes the unit tests by changing the order of registration of
file actions.
2015-09-14 20:45:30 +02:00
8a6574e81a
Keep right sidebar open, add Details action
2015-09-14 20:45:30 +02:00
004de1425e
Merge pull request #18630 from owncloud/files-combineuploadbutton
...
Combine upload action into the "New" menu
2015-09-07 14:03:57 +02:00
310d797284
Add versions tab to files sidebar
...
- move versions to a tab in the files sidebar
- added mechanism to auto-update the row in the FileList whenever values
are set to the FileInfoModel given to the sidebar
- updated tags/favorite action to make use of that new mechanism
2015-09-03 16:47:24 +02:00
4ba2333507
Added unit tests for "new" file menu and small fixes
...
- added unit tests for NewFileMenu
- use generateUrl for FileList.createFile and FileList.createDirectory
- added unit tests for FileList.createFile and FileList.createDirectory
2015-09-03 12:17:35 +02:00
e85620ab69
larger preview for images in the sidebar
2015-09-02 10:32:43 +02:00
59273a8863
Combine upload action into the "New" menu
...
Refactored the new menu to be encapsulated in the NewFileMenu JS class
2015-08-28 17:27:48 +02:00
a86602a157
Properly hide sidebar when switching between files app sections
...
Since there are multiple sidebars, one for each files app section, we
need to hide the correct ones.
2015-08-25 11:07:47 +02:00
37939fb0e8
Parse mtime from the data attributes
2015-08-24 17:16:20 +02:00
5fd36d017e
Merge pull request #18378 from owncloud/files-delete-spinner
...
Fix spinner when deleting all files in a folder
2015-08-19 14:31:23 +02:00
bd6beaaae2
Merge pull request #18354 from owncloud/files-fixdnd
...
Fix file drag and drop JS error
2015-08-19 14:30:21 +02:00
730f1d199a
Fix spinner when deleting all files in a folder
2015-08-18 11:14:41 +02:00
bbff530b65
Move decaration to the beginning of the block
2015-08-18 10:34:30 +03:00
009c008ed8
Fix file drag and drop JS error
2015-08-17 16:09:29 +02:00
72799ffba2
Move selectionVars into if statement
2015-08-17 15:28:55 +03:00
69c550ce51
Fix the string counting a selected files/dirs
...
The old one contains untranslatable ' & ' if both files and dirs are
selected. The new code is especially designed to reuse strings from file
listing summary view (apps/files/js/filesummary.js), so no translation
is broken.
2015-08-14 14:50:25 +03:00
4e53b5922d
Merge pull request #18178 from owncloud/files-sidebar-actions
...
Sidebar file actions
2015-08-13 17:17:10 +02:00
e5444a1a5d
replace tipsys with tooltips
2015-08-12 23:09:49 +02:00
c964eff17b
Make file actions work from sidebar
...
The favorite icon in the sidebar now triggers the file action and also
updates itself according to the model's state when triggered from the
file row.
The thumbnail triggers the default action.
Currently only one FileInfoModel is used for the selection and state
synchronization between views.
FileList reload now auto-closes the sidebar.
2015-08-12 17:30:20 +02:00
ca34921cdf
Implement file actions dropdown
...
File actions now have two types "inline" and "dropdown". The default is
"dropdown".
The file actions will now be shown in a dropdown menu.
2015-08-10 14:12:34 +02:00
15e16d335d
Merge pull request #17656 from owncloud/files-rightsidebar
...
Basic work for right sidebar
2015-08-10 13:14:15 +02:00
8e2369f72b
Make sure to hide empty content message when mask is shown
2015-08-07 15:57:16 +02:00
5af59c6871
rename sidebar element and use css and js utility functions to core
2015-08-07 01:22:43 +02:00
f508cf40da
sidebar shall not overlap but shrink the contnet
2015-08-07 01:22:43 +02:00
f11946c8c0
Improve layout, fix mime icon
2015-08-07 01:22:43 +02:00
b6192db610
Disable right sidebar in public file list page
2015-08-07 01:22:43 +02:00
deb9d4d778
Right sidebar now has its own scrollbar
2015-08-07 01:22:43 +02:00
ad90ba27cd
Styling fixes + hightlight in files sidebar
...
Sidebar scrolls with contents
Highlight currently show file
2015-08-07 01:22:43 +02:00
ff614a7dbd
More fixes to the right sidebar
...
Sidebar now works in all file list views.
Moved owner to share tab.
2015-08-07 01:22:43 +02:00
12e5f310dd
Improved right sidebar
...
Added owner info.
Added animation, but causes scrollbal.
Default file action now when clicking on name directly.
Fixed icon.
Added empty share tab.
2015-08-07 01:22:42 +02:00
9854e71d2c
Basic work for right sidebar
...
Adds right sidebar with registrable panels (still WIP)
2015-08-07 01:22:42 +02:00
5699fff889
Merge pull request #17175 from owncloud/add-download-feedback
...
Add loading spinner to download icon
2015-07-30 16:34:35 +02:00
f67477206b
fixed tooltip for modified date
2015-07-27 15:56:03 +02:00
009d1f3214
move updateFileActionSpinner to OCA.Files.FileActions
2015-07-22 10:35:15 +02:00
b0f21c0a43
The external directories should get the correct icon
2015-07-17 14:30:12 +02:00
43afa4c0e3
refactor this to proper separation of concerns
2015-07-15 11:14:20 +02:00
eb7a796ad9
Fix unit tests
2015-07-09 18:42:46 +02:00
7d943b2ddc
Make the filelist get the mimetypeicon from the mimetype
2015-07-09 13:56:43 +02:00
5c381ea532
Move calls to Files.getMimeIcon to OC.MimeType.getIconUrl
2015-07-09 13:40:13 +02:00
3f5aa27d49
refactoring into proper methods
2015-07-07 15:16:37 +02:00
e557fe0aab
Add proper download started feedback
...
* this code adds a cookie when a special get parameter is set
* the content of this get parameter is used as value for the cookie
* the cookie expires after 20 seconds
* the JS code checks every 500 milliseconds for the cookie
-> if the cookie is set the request returned and the download is started
2015-07-07 13:56:49 +02:00
28a8697995
Reduce timeout for download spinner to 2 seconds
2015-07-07 13:56:49 +02:00
16c29021e6
Add loading spinner to multi select download button
2015-07-07 13:56:48 +02:00
ca1da0acb7
add check if server returns a 500 and display error
...
resolves https://github.com/owncloud/core/issues/17170
2015-06-26 12:50:09 -04:00
e01db549a0
Merge pull request #17048 from owncloud/hotfix/fix-firewall-blocking-dir-message
...
adding correct blocking logic for ffw
2015-06-23 15:08:47 +02:00
5466dcadc0
adding correct blocking logic for fff
2015-06-22 11:42:42 -04:00
9dde482315
remove whitespace on bottom when no search results, fix laylout, fix #16878
2015-06-22 15:30:29 +02:00
8eda9ae83c
add filter-empty class if no search result in current folder
2015-06-22 12:13:05 +02:00
d256425aba
Truncate preview resolution
...
This prevents having float numbers appear in the URL
2015-06-11 17:17:40 +02:00
b1713b2f75
Enable file icons & previews in "Shared ..." categories
...
* sharing API returns now the mimetype icon path
* file previews are now lazyloaded by default (as the doc says)
* fixes #16086
2015-05-06 18:32:52 +02:00
53a23364ef
Added empty content message for empty read-only folders
2015-04-21 14:31:13 +02:00
d728b85fdd
adjust controls bar width to not overlay scrollbar
2015-03-27 01:34:55 +01:00
92f0dba3c8
Show hidden files (dot files) in gray
2015-03-26 10:35:27 +01:00
2b8ef3aca9
Fix middle click on breadcrumb
2015-03-24 22:05:02 +01:00
8e02592e3f
fix issue with previews not being displayed if filename contains apostrophe
2015-02-22 16:51:16 +01:00
b7ff0d44d8
apply backslash fix to _setCurrentDir
2015-02-19 20:20:33 +01:00
7f24e77cfc
Disallow ctrl click to select when selection not allowed
2015-01-15 18:16:27 +01:00
d40301492d
Auto-blur when clicking on file to download
2015-01-15 18:08:36 +01:00
d20a1bbdbf
Merge pull request #13154 from owncloud/fix13141
...
don't show no files yet when mask is in place, fixes #13141
2015-01-12 22:48:25 +01:00
512ba327f7
Allow dropping files on the table container
...
Make it possible to drop files below the table even if the table is
smaller than the window height.
Added a check to make sure upload is not triggered on invisible lists.
2015-01-12 12:29:26 +01:00
e4840b5250
Don't double encode string
...
We already use `.text()` here which automatically properly encodes the string. Thus the string will be double-encoded and look ugly. (i.e. when you search for ">" you will see "No results found for >")
Fixes itself.
2015-01-10 01:19:37 +01:00
45a20744fc
add js tests for filelist filtering
2015-01-09 10:49:22 +01:00
0bb91cfcf3
don't show no files yet when mask is in place, fixes #13141
2015-01-07 15:59:39 +01:00
357fbd88be
use class for no results div instead of id. the elements are not unique.
2015-01-06 14:34:35 +01:00
926737fdb7
clear search when navigating via breadcrumbs
2015-01-06 13:55:51 +01:00
Vincent Petry
Robin Appelman
Björn Schießle
Lukas Reschke
Vincent Chan
Dmitry Popov
Pellaeon Lin
Fabian
Christoph Wurst
Thomas Müller
Christoph Wurst
Joas Schilling
Jan-Christoph Borchardt
Erik Pellikka
Stefan Weil
Roeland Jago Douma
Thomas Müller
Robin McCorkell
Robin Appelman
Morris Jobke
Olivier Paroz
Hendrik Leppelsack
Hasso Tepper
Hasso Tepper
Arthur Schiwon
Roeland Jago Douma
Clark Tomlinson
Bjoern Schiessle
Georg Ehrke
Jörn Friedrich Dreyer