Commit Graph

34581 Commits

Author SHA1 Message Date
Morris Jobke f56ae37e8f
Opening the trashbin causes errors in log for files without preview
* put a file without a generated preview in the trashbin
  (e.g. a *.docx file)
* open the trashbin
* following errors will show up in the nextcloud.log:
	- filesize(): stat failed for ...
	- fopen(...): failed to open stream: No such file or directory at ...
	- fread() expects parameter 1 to be resource, boolean given at ...
	- fclose() expects parameter 1 to be resource, boolean given at ...
	- imagecreatefromstring(): Empty string or invalid image at ...

This is because the preview code tries to load an SVG image, which
is obviously only text.

The fix simply handles this before the loading happens and the web UI
keeps showing the default mimetype icon.
2016-09-09 13:53:06 +02:00
Lukas Reschke f715b5ea2e
Don't print exception message in HTML
The exception message is potentially influenced by user input and could thus be confusing (e.g. somebody could try to open a file like "Please send a mail to support@foo.com", and then the message would include that string.

It is thus reasonable to not show the exception message by default. Also for the browser view I added an `exit()` at the end, as otherwise the XML exception would be attached.
2016-09-09 13:52:34 +02:00
Lukas Reschke 67439951e6
Filter more mimetypes
There's no need to allow more than those defined mimetypes for images.
2016-09-09 12:33:10 +02:00
Roeland Jago Douma ba104233b0
Move remote_shares OCS endpoint to AppFramework 2016-09-09 07:40:33 +02:00
Nextcloud bot f5aafdc897
[tx-robot] updated from transifex 2016-09-09 00:09:31 +00:00
Morris Jobke c16aefcff5 Merge pull request #1317 from nextcloud/add-sharing-disclaimer
Adding a optional disclaimer to the anonymous upload page
2016-09-08 21:18:28 +02:00
Morris Jobke 5ac26d12f0 Merge pull request #1247 from nextcloud/storage-id-global-cache
more efficient querying of numeric storage ids
2016-09-08 21:09:14 +02:00
Lukas Reschke 268c5a0aa0
Adjust test 2016-09-08 20:34:04 +02:00
Lukas Reschke 404b212b87
Use l10n 2016-09-08 20:11:54 +02:00
Lukas Reschke 9a2ae2fe7d
Fix tests 2016-09-08 20:11:21 +02:00
Roeland Jago Douma e18fecae47 Merge pull request #1297 from nextcloud/catch-exceptions-with-invalid-passwords
Catch the exception of the password policy app
2016-09-08 19:54:27 +02:00
Morris Jobke 6bb95de1c5
Adding a optional disclaimer to the anonymous upload page 2016-09-08 18:44:27 +02:00
Morris Jobke d8c4f18c0c Merge pull request #1328 from nextcloud/add-exemption-for-osx
Add exemptions for incompatible UAs
2016-09-08 18:39:33 +02:00
Lukas Reschke 6ac890812f
Add exemptions for incompatible UAs
Some user agents are notorious and don't really properly follow HTTP
 specifications. For those, have an automated opt-out. Since the protection
for remote.php is applied in base.php as starting point we need to opt out
here.
2016-09-08 17:20:46 +02:00
Morris Jobke 7cd1369f76 Merge pull request #1323 from nextcloud/show-download-button-for-updates-atm
Show an download button instead of the updater
2016-09-08 15:40:41 +02:00
Lukas Reschke ef56b0b5c9 Merge pull request #1318 from nextcloud/11-supports-php7.1
Master supports PHP 7.1
2016-09-08 13:23:18 +02:00
Joas Schilling fd6ed3aacc Merge pull request #1315 from nextcloud/remove_password_compat
[3rdparty] PasswordCompat is no longer required
2016-09-08 12:33:28 +02:00
Joas Schilling 0cec06d0c8
Change updater URL 2016-09-08 12:30:17 +02:00
Joas Schilling 27a3c68d84
Fix tests 2016-09-08 11:13:36 +02:00
Joas Schilling 202ae42506
Show an update button instead of the updater 2016-09-08 10:59:14 +02:00
Roeland Jago Douma 3e46c925f8
[3rdparty] PasswordCompat is no longer required 2016-09-08 09:57:52 +02:00
Lukas Reschke b7decc52e9
Master supports PHP 7.1 2016-09-08 09:20:33 +02:00
Lukas Reschke ff691b4d8a Merge pull request #836 from nextcloud/php7.1
Add PHP 7.1 drone tests
2016-09-08 09:19:59 +02:00
Joas Schilling cdfe538452 Merge pull request #1243 from nextcloud/fix-detection-of-file-types-a-bit
Fix detection of file types a bit
2016-09-08 09:19:33 +02:00
Nextcloud bot b992bf2142
[tx-robot] updated from transifex 2016-09-08 00:10:21 +00:00
Roeland Jago Douma 9d00f367f9
Compare arrays not json strings
In php 7.1 the pretty print json output changed. Thus now we compare
arrays.
2016-09-07 23:06:18 +02:00
Lukas Reschke 1b2021a243
Use the PHP 7.1-3 tag
Bumps the PHP version from beta2 to RC1
2016-09-07 22:24:29 +02:00
Lukas Reschke d4cbc24bae
Update 3rdparty ref 2016-09-07 22:09:37 +02:00
Roeland Jago Douma 1cdf4e9540
Set default 2016-09-07 22:09:32 +02:00
Roeland Jago Douma fb4850ffa8
Fix intergrity checker
* Set salt length to 0
  See https://tools.ietf.org/html/rfc3447#page-38
* Fix tests for new phpunit
2016-09-07 22:09:29 +02:00
Lukas Reschke 1937e6eb35
Use updated phpseclib ref 2016-09-07 22:09:09 +02:00
Thomas Müller 1631ef5acc
Initialize array elements properly 2016-09-07 22:09:08 +02:00
Thomas Müller aa10231027
$this->blackListedClassNames is unknown 2016-09-07 22:09:08 +02:00
Lukas Reschke 9915f68a80
Add PHP 7.1 drone tests 2016-09-07 22:09:08 +02:00
Lukas Reschke 25a1a68bc9 Merge pull request #1310 from nextcloud/shared-with-you-owner
dont show shares you own in "shared with you"
2016-09-07 22:05:44 +02:00
Lukas Reschke 0a33ebdb13 Merge pull request #1314 from nextcloud/nodb_getmock_be_gone
Fix PHPUnit warnings on NODB runs
2016-09-07 22:03:41 +02:00
Roeland Jago Douma 680b557a4b
Fix apps warnings 2016-09-07 20:42:38 +02:00
Roeland Jago Douma 835daedbbc
Fix getMock settings 2016-09-07 20:42:38 +02:00
Roeland Jago Douma ab797929e2
Fix getMock Updater 2016-09-07 20:42:38 +02:00
Roeland Jago Douma d8a4769cd6
Fix getMock Template 2016-09-07 20:42:38 +02:00
Roeland Jago Douma 9d4729cb6a
Fix getMock TempManagerTest 2016-09-07 20:42:38 +02:00
Roeland Jago Douma 80c519fe89
Fix getMock Share 2016-09-07 20:42:38 +02:00
Roeland Jago Douma 65409f5327
Fix getMock SetupTest 2016-09-07 20:42:38 +02:00
Roeland Jago Douma e1096c964d
Fix getMock Security 2016-09-07 20:42:38 +02:00
Roeland Jago Douma dc60f4c441
Fix getMock Repair 2016-09-07 20:42:38 +02:00
Roeland Jago Douma 1b5ed67857
Fix getMock Migration 2016-09-07 20:42:38 +02:00
Roeland Jago Douma b8b9fc2b1c
Fix getMock OCSClient 2016-09-07 20:42:38 +02:00
Roeland Jago Douma c95d5c77d7
Fix getMock LegacyHelperTest 2016-09-07 20:42:38 +02:00
Roeland Jago Douma f167e65d49
Fix getMock L10NTest 2016-09-07 20:42:38 +02:00
Roeland Jago Douma ba3a90d30c
Fix getMock checkertest 2016-09-07 20:42:37 +02:00