Commit Graph

57948 Commits

Author SHA1 Message Date
Morris Jobke f2969dc9ca
Merge pull request #26212 from nextcloud/fix-dashboard-background
Make background cover whole viewport
2021-03-19 20:30:49 +01:00
Morris Jobke 2cae541a1a
Merge pull request #26070 from nextcloud/path-prefix-index
add a prefix index to filecache.path
2021-03-19 20:21:36 +01:00
Robin Appelman b28f0a0e94
add a prefix index to filecache.path
The reason that `filecache.path` hasn't had an index added is the mysql limitation of ~1kb for indexeded fields,
which is to small for the `path`, however mysql supports indexing only the first N bytes of a column instead of the entire column,
allowing us to add an index even if the column is to long.

Because the index doesn't cover the entire column it can't be used in all situations where a normal index would be used, but it does cover the `path like 'folder/path/%'` queries that are used in various places.

Sqlite and Postgresql don't support prefix indexes, but they also don't have the 1kb limit and DBAL handles the differences in index creation.

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 18:52:25 +01:00
Vincent Petry cdb1d3468b
Merge pull request #26061 from nextcloud/bugfix/noid/encryption-update-failure
Log and continue when failing to update encryption keys during for individual files
2021-03-19 17:36:34 +01:00
Robin Appelman b38618c813
use node search api for legacy file search endpoint
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 16:08:01 +01:00
Robin Appelman a0fb6d2518
pass order from unified search to file search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 16:07:57 +01:00
Robin Appelman bfe3712372
handle ordering in folder search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 16:07:54 +01:00
Morris Jobke fb09f3d31d
Merge pull request #26145 from nextcloud/smb-force-write-option
add (hidden) option to always show smb root as writable
2021-03-19 15:31:04 +01:00
Vincent Petry e6fd9b2f55
Merge pull request #25129 from nextcloud/bugfix/smb-notify-subpath
Fix files_external:notify command when running withing a subdirectory
2021-03-19 14:53:16 +01:00
Sascha Wiswedel 8b145c7858 Removed unnecessary padding
Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
2021-03-19 14:24:10 +01:00
Vincent Petry 82891cd498
Fix phpcs issues in encryption update
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-19 14:12:10 +01:00
Julius Härtl 76170a58eb
Log and continue when failing to update encryption keys during for individual files
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-19 14:12:07 +01:00
Jo Sprague dc1413cad9
Make background cover whole viewport
Without a min-height, wider viewports can result in a blank white space at the bottom of the screen. This CSS ensures that doesn't happen.

Signed-off-by: Jo Sprague <git@josprague.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-19 14:06:22 +01:00
Robin Appelman feed42dd6d
folder filtering in sql
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 13:41:00 +01:00
Roeland Jago Douma 1286848731
Merge pull request #23718 from nextcloud/already-shared-error-message
expand 'path is already shared' error message
2021-03-19 13:39:22 +01:00
Robin Appelman de713967c0
cleanup fileinfo creation
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 13:35:37 +01:00
Julien Veyssier 086cf56b21
Merge pull request #26196 from nextcloud/fix/app-sidebar-description-slot
Adapt files and app settings to @nc/vue changes
2021-03-19 13:32:46 +01:00
Julien Veyssier 3c172ce600 adapt files and app settings sidebar 'primary-actions' slot that became 'description' in @nc/vue v3.3.0
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-19 12:56:35 +01:00
Christoph Wurst e68c4a4ed3
Only perform login check during ownership transfer for encryption
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-19 11:25:56 +01:00
Vincent Petry 7bf5adb1fa
Merge pull request #26200 from nextcloud/bugfix/26197/fix-expiration-validation-confusion
Update user share must use correct expiration validation
2021-03-19 10:51:21 +01:00
Nextcloud bot 9e70b83f13
[tx-robot] updated from transifex 2021-03-19 02:24:56 +00:00
Robin Appelman a428f7d1e0
format
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 17:44:30 +01:00
Robin Appelman bd229e7548
handle limit and offset in folder file search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 17:38:31 +01:00
Robin Appelman 50e374c12f
only require user to be set in a query that handles tags
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 17:16:28 +01:00
Vincent Petry a9e3d2a10f
Update user share must use correct expiration validation
Updating a user or group share now uses the correct method for the
validation of the expiration date. Instead of using the one from links
it uses the one for internal shares.

To avoid future confusion, the method "validateExpirationDate" has been
renamed to "validateExpirationDateLink".

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-18 17:12:28 +01:00
John Molakvoæ 6ade109b60
Merge pull request #26194 from nextcloud/techdebt/noid/remove-duplicate-sharing-unit-integration-tests-group-permission
Remove duplicate unit test in sharing that checks for group permission updates
2021-03-18 16:37:29 +01:00
Robin Appelman f8bca545df
unify handling of Folder::search methods into "new" query objects
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 16:35:41 +01:00
Robin Appelman 14a1b5063e
use "newer" node search api directly in unified search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 16:22:29 +01:00
Roeland Jago Douma 8f22d48f7a
Merge pull request #26189 from nextcloud/techdept/qbmapper-execute-update-query
Use executeQuery and executeUpdate in the QBMapper
2021-03-18 16:17:54 +01:00
Christoph Wurst 0d8b3baf61
Use executeQuery and executeUpdate in the QBMapper
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-18 15:40:18 +01:00
Morris Jobke b34035f845
Merge pull request #26193 from nextcloud/techdebt/noid/remove-sharing-duplicate-unit-integration-tests
Permission tests for the sharing are fully covered in sharing v1 integration tests
2021-03-18 11:34:15 +01:00
Morris Jobke d650de13a4
Remove duplicate unit test in sharing that checks for group permission updates
* it was skipped before anyways
* it is covered for example in build/integration/sharing_features/sharing-v1-part3.feature#L517-L548 (see 54f8f75f6f/build/integration/sharing_features/sharing-v1-part3.feature (L517-L548))
* more permission updates are tested in the webdav section, where an OCS API is called and the WebDAV response is checked for the properly changed permission

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-18 10:31:56 +01:00
Morris Jobke e6bd23acf9
Permission tests for the sharing are fully covered in sharing v1 integration tests
See build/integration/sharing_features/sharing-v1*.features for the exact same tests. Especially part3 that covers most of the different permission setups over webdav.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-18 10:15:42 +01:00
kesselb dd39f5e871
Merge pull request #25112 from nextcloud/repair-exception
dont error the entire repair process when a repair step errors
2021-03-18 10:14:47 +01:00
Morris Jobke 6401d88283
Merge pull request #25331 from nextcloud/fix-valid-storages-removed-when-cleaning-remote-storages
Fix valid storages removed when cleaning remote storages
2021-03-18 08:57:09 +01:00
Robin Appelman 9e3775618b
log full expection during repair step
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:45:17 +01:00
Robin Appelman 9135a42781
make repair errors more visible
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:45:16 +01:00
Robin Appelman c75b82adbb
dont error the entire repair process when a repair step errors
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:45:16 +01:00
Morris Jobke 5cdc3e9c9d
Merge pull request #26188 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
[Automated] Update psalm-baseline.xml
2021-03-18 08:30:44 +01:00
Nextcloud-PR-Bot 3959313b2c Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-18 04:34:21 +00:00
Nextcloud bot a186d08471
[tx-robot] updated from transifex 2021-03-18 02:25:02 +00:00
Morris Jobke 37feee4e87
Merge pull request #24384 from nextcloud/cleanup/remove-old-migration-check
Remove dead code from checking core/apps before upgrades
2021-03-17 21:29:19 +01:00
Julius Härtl a2f3077ee8
Skip db migration simulation for core schema changes
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-17 21:08:22 +01:00
Morris Jobke 459e0b311b
Merge pull request #25924 from nextcloud/bugfix/noid/only-mark-migrations-as-installed-after-executing-them-in-case-the-developer-broke-them
Only mark migrations as installed after execution
2021-03-17 20:29:28 +01:00
Morris Jobke f56e5bb0db
Merge pull request #25676 from nextcloud/drop/utl-is-ie
Drop \OCP\Util::isIe
2021-03-17 20:18:11 +01:00
John Molakvoæ f1fefd91df
Merge pull request #26160 from nextcloud/enh/eslint 2021-03-17 18:14:31 +01:00
Morris Jobke 6867ba8e33
Merge pull request #24580 from nextcloud/enh/noid/db-convert
DB conversion: improve console output
2021-03-17 17:52:42 +01:00
Joas Schilling 0d46fafd41
Merge pull request #26161 from nextcloud/bugfix/noid/improve-matching-of-phonebook-searches
Improve search results when only phonebook-matches can we autocompleted
2021-03-17 15:22:03 +01:00
John Molakvoæ (skjnldsv) 87d39375d8
Fix comments filesplugin
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 14:45:29 +01:00
Morris Jobke d011df6aa7
Merge pull request #26076 from nextcloud/enh/noid/ldap-occ-user-reset
adds ldap user:reset command
2021-03-17 14:36:18 +01:00