Commit Graph

57209 Commits

Author SHA1 Message Date
Nextcloud-PR-Bot 510be67e94 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-01-13 04:59:54 +00:00
Nextcloud bot 6cf9c88596
[tx-robot] updated from transifex 2021-01-13 02:20:19 +00:00
Arthur Schiwon 02b703193a
really use known groups
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-12 20:52:52 +01:00
Christoph Wurst 2c9cdc1cdb
Add our own DB exception abstraction
Right now our API exports the Doctrine/dbal exception. As we've seen
with the dbal 3 upgrade, the leakage of 3rdparty types is problematic as
a dependency update means lots of work in apps, due to the direct
dependency of what Nextcloud ships. This breaks this dependency so that
apps only need to depend on our public API. That API can then be vendor
(db lib) agnostic and we can work around future deprecations/removals in
dbal more easily.

Right now the type of exception thrown is transported as "reason". For
the more popular types of errors we can extend the new exception class
and allow apps to catch specific errors only. Right now they have to
catch-check-rethrow. This is not ideal, but better than the dependnecy
on dbal.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 16:38:23 +01:00
blizzz 3447ea4955
Merge pull request #25089 from nextcloud/enhancement/ocp-db-types
Add our own db column types via the public API
2021-01-12 15:24:15 +01:00
Roeland Jago Douma e44f275cfe
Merge pull request #25088 from nextcloud/fix/allow_app_updates_again
Allow installing/updating of apps again
2021-01-12 14:34:21 +01:00
Christoph Wurst c1d4f8161b
Migrate internal classes to the OCP db col types
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 14:09:13 +01:00
Christoph Wurst d4e6463eb2
Add our own constants for db column types
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 14:09:13 +01:00
Vincent Petry 90c0e943dd
Merge pull request #24606 from hosting-de/feature/allow-symlinks-configurable
Add 'allow Symlinks' as an option to config.php
2021-01-12 13:20:26 +01:00
Roeland Jago Douma 41c80d6c19
Fix option in the client code itself as well
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-12 12:36:21 +01:00
Roeland Jago Douma 9b58a027e3
Allow installing/updating of apps again
The Guzzle API changed. We shall now use sink

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-12 10:51:41 +01:00
Roeland Jago Douma b89e6f50e4
Merge pull request #25080 from nextcloud/fix/file-scan-db
Fix database connection usage in the files scanner
2021-01-12 10:46:02 +01:00
Johannes Leuker ac88bcbd5f Add 'allow Symlinks' as an option to config.php
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-01-12 10:38:39 +01:00
Morris Jobke 15924b8832
Merge pull request #25087 from nextcloud/techdebt/noid/update-psalm-baseline-as-recommended.xml
Update psalm baseline to remove obsolete stuff
2021-01-12 10:14:11 +01:00
Vincent Petry eeac11a687
Fix casing of MySQLPlatform class name
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-01-12 09:39:59 +01:00
Vincent Petry 5a8f15e167
Update psalm baseline to remove obsolete stuff
As seen in CI static checks, some blocks in the baseline were not needed any
more.

This will fix static checks in CI.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-01-12 09:26:20 +01:00
Nextcloud bot c8cbb73c05
[tx-robot] updated from transifex 2021-01-12 02:19:49 +00:00
blizzz 7cdc7adf59
Merge pull request #25038 from nextcloud/bugfix/noid/install-mysql8-with-php8
Don't try a transaction for the migrator on MySQL
2021-01-11 18:07:11 +01:00
Christoph Wurst 3678823748
Fix database connection usage in the files scanner
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-11 16:45:14 +01:00
Roeland Jago Douma fdd111924f
Merge pull request #25039 from nextcloud/fix/libxml-use-internal-errors-deprecated
Only use libxml_disable_entity_loader on php older than 8
2021-01-11 16:14:38 +01:00
Joas Schilling 2d34ca4143
Only rollback when not MySQL
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-11 16:11:02 +01:00
dependabot-preview[bot] a599a7d099
Merge pull request #25048 from nextcloud/dependabot/npm_and_yarn/webdav-3.6.2 2021-01-11 14:10:56 +00:00
Morris Jobke 8f614acade
Merge pull request #25034 from nextcloud/bugfix/noid/load-authentication-for-app-upgrades
Make sure to do priority app upgrades first
2021-01-11 14:44:10 +01:00
Roeland Jago Douma 6c8f2dc7bc
Merge pull request #25016 from nextcloud/enh/noid/add-check-for-unsupported-db
Add setup check to verify that the used DB version is still supported…
2021-01-11 14:21:42 +01:00
Morris Jobke 5ed673e5eb
Merge pull request #25073 from nextcloud/psalm/24521/remove-unneeded-casts
Remove unneeded casts that were found by Psalm
2021-01-11 14:15:16 +01:00
dependabot-preview[bot] a85e628fc3 Bump webdav from 3.6.1 to 3.6.2
Bumps [webdav](https://github.com/perry-mitchell/webdav-client) from 3.6.1 to 3.6.2.
- [Release notes](https://github.com/perry-mitchell/webdav-client/releases)
- [Changelog](https://github.com/perry-mitchell/webdav-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/perry-mitchell/webdav-client/compare/v3.6.1...v3.6.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-01-11 12:50:09 +00:00
Arthur Schiwon f9484d15cb
DB: warn on parameter number constraints
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-11 13:43:34 +01:00
Arthur Schiwon 45e3261ad5
respect DB limits limit per statement and query
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-11 13:43:34 +01:00
Roeland Jago Douma 683685b72c
Merge pull request #25070 from nextcloud/feature/noid/card-ros-definitions
Deck Rich-Object-String definitions for deck boards and cards
2021-01-11 13:31:21 +01:00
Morris Jobke 27c932ae29
Merge pull request #24910 from nextcloud/dependachristoph/composer/scss-1.4.0
Bump scssphp/scssphp from 1.0.3 to 1.4.0
2021-01-11 13:25:00 +01:00
Roeland Jago Douma d0fdc6ef08
Merge pull request #25069 from nextcloud/bugfix/noid/regression-dont-touch-assignable-column
Don't remove assignable column for now
2021-01-11 13:17:35 +01:00
Morris Jobke 24d436cb60
Remove unneeded casts that were found by Psalm
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-11 13:14:41 +01:00
Julius Härtl a2f024ae1d
Unquote string when removing the hash from a color
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-11 12:41:25 +01:00
Julius Härtl 3ec20be575
Make SCSS compliant
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-11 12:41:25 +01:00
Christoph Wurst c3cb288268
Bump scssphp/scssphp from 1.0.3 to 1.4.0
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-11 12:41:25 +01:00
Joas Schilling 078ecac188
Deck Rich-Object-String definitions for deck boards and cards
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-11 12:03:13 +01:00
Vincent Petry 2a93c403a4
Don't remove assignable column for now
It causes side effects.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-01-11 11:58:14 +01:00
dependabot-preview[bot] 8b656e321b
Merge pull request #25049 from nextcloud/dependabot/npm_and_yarn/webpack-4.45.0 2021-01-11 10:55:29 +00:00
dependabot-preview[bot] 429b4b8a14 Bump webpack from 4.44.2 to 4.45.0
Bumps [webpack](https://github.com/webpack/webpack) from 4.44.2 to 4.45.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.44.2...v4.45.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-01-11 09:57:01 +00:00
Morris Jobke 82ee3043ce
Merge pull request #24661 from nextcloud/external-storage-cant-edit
dont offer to edit external config settings if we can't edit them
2021-01-11 10:42:48 +01:00
Roeland Jago Douma da3a986447
21 beta6
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-11 09:54:10 +01:00
Nextcloud bot ca93c9708c
[tx-robot] updated from transifex 2021-01-11 02:19:52 +00:00
Nextcloud bot 97743df3fc
[tx-robot] updated from transifex 2021-01-10 02:22:39 +00:00
Roeland Jago Douma 6f6f732c94
Merge pull request #25050 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
[Automated] Update psalm-baseline.xml
2021-01-09 08:54:46 +01:00
Nextcloud-PR-Bot f6969d9878 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-01-09 04:53:55 +00:00
dependabot-preview[bot] e0e0d729db
Merge pull request #25047 from nextcloud/dependabot/npm_and_yarn/sinon-9.2.3 2021-01-09 03:09:48 +00:00
Nextcloud bot b137ac468f
[tx-robot] updated from transifex 2021-01-09 02:21:37 +00:00
dependabot-preview[bot] 1e0eb579ce
Bump sinon from 9.2.2 to 9.2.3
Bumps [sinon](https://github.com/sinonjs/sinon) from 9.2.2 to 9.2.3.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sinonjs/sinon/compare/v9.2.2...v9.2.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-01-09 02:17:49 +00:00
Christoph Wurst f8efab7c85
Only use libxml_disable_entity_loader on php older than 8
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 16:33:46 +01:00
Joas Schilling 3cdfe7b0f4
Don't try a transaction for the migrator on MySQL
As per https://dev.mysql.com/doc/refman/8.0/en/implicit-commit.html
CREATE TABLE statements automatically commit always. The only reason
this worked in the past was that PHPs PDO connection didn't check the
actual state on commit, but only checked their internal state.
But in PHP8 this was fixed:
https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L446-L450
So now commit() fails because the internal PDO connection implicitly
commited already.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-08 16:25:40 +01:00