9a0b7e207e
properly use limit and offset for search in Jail wrapper
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-31 13:56:28 +00:00
a0e0627de0
Don't break OCC if an app is breaking in it's Application class
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 07:42:04 +00:00
4ec4a99869
Limit size of properties to 2048 characters
...
It is unreasonable to expect that one of these fields would be longer
than 2048 characters. Whilst some have definitely lower limits (such as
for phone numbers or domain names), a upper bound as sanity check makes
sense.
Backport of https://github.com/nextcloud/server/pull/26433
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-29 20:45:11 +02:00
02001520e0
Do not try to contact lookup server if not needed
...
In some cases (for example you never send data to the lookup server)
there is no need for this job to even try.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-29 09:23:02 +02:00
4f8c89f8a5
Fail when creating new files with an empty path
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-28 10:06:03 +00:00
498ac1c6f5
Do not allow to overwrite some variables
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:39:53 +00:00
2b0fd23ecf
Fix ratelimit template
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:39:52 +00:00
bcf9c14047
Log deprecation only as debug
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 15:14:55 +00:00
56d7b1a382
Respect the error level when logging
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 15:14:53 +00:00
0145fd0b5c
private cannot be final
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2021-04-26 07:08:14 +00:00
86de5d9265
Explicitly check hex2bin input
...
For #23197
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-22 14:01:25 +02:00
6bd49e256b
Fix empty password check for mail shares
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-21 08:00:29 +02:00
89960468ae
ensure redis returns bool for hasKey
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-20 08:36:55 +00:00
61545e7a89
Increase subnet matcher
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-12 10:36:26 +00:00
3a1444ee71
Fix phpcs issues in encryption update
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-01 07:56:20 +00:00
c2a072b27d
Log and continue when failing to update encryption keys during for individual files
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 07:56:19 +00:00
1e3e339e69
Merge pull request #26378 from nextcloud/backport/25500/stable20
...
[stable20] fix(translation): replace static error message
2021-03-31 10:08:34 +02:00
47abd1f37e
gracefully handle deleteFromSelf when share is already gone
...
- handling race conditions
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-30 20:26:20 +00:00
8b6706ea7d
revert(comment)
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-03-30 19:26:14 +00:00
09a92dc7cd
revert(exception): keep throwing an exception for now
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-03-30 19:26:13 +00:00
2703777014
fix(translation): replace static error message
...
as suggested by @kesselb in nextcloud/server#25490
Signed-off-by: Samuel <faust64@gmail.com>
2021-03-30 19:26:13 +00:00
99e2e5f6b9
Merge pull request #26258 from nextcloud/backport/26198/stable20
...
[stable20] Handle limit offset and sorting in files search
2021-03-30 20:53:11 +02:00
a8c6ffaf9a
Merge pull request #26290 from nextcloud/backport/21484/stable20
...
[stable20] show better error messages when a file with a forbidden path is encountered
2021-03-26 13:51:02 +01:00
3fe78684ad
Log when a storage is marked as unavailable
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-25 16:12:12 +00:00
82a2492c33
show better error messages when a file with a forbidden path is encountered
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-25 10:56:44 +00:00
4b65a1dcd7
fix type hints
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:35:08 +01:00
4ede9dbb07
use node search api for legacy file search endpoint
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:01:17 +01:00
055af29371
handle ordering in folder search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:01:05 +01:00
671b99251e
folder filtering in sql
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:00:58 +01:00
4e60b9ffe2
cleanup fileinfo creation
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:00:53 +01:00
dbd8b0ae82
format
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:00:47 +01:00
6a639ec1d0
handle limit and offset in folder file search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:00:41 +01:00
4655f6feb1
only require user to be set in a query that handles tags
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:00:35 +01:00
a624243236
unify handling of Folder::search methods into "new" query objects
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:00:29 +01:00
dfcf6ad106
Catch invalid cache source storage path
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-24 11:05:32 +00:00
fd29d77817
expand 'path is already shared' error message
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 17:32:14 +01:00
4ad89c1761
Update user share must use correct expiration validation
...
Updating a user or group share now uses the correct method for the
validation of the expiration date. Instead of using the one from links
it uses the one for internal shares.
To avoid future confusion, the method "validateExpirationDate" has been
renamed to "validateExpirationDateLink".
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-19 09:57:29 +00:00
f088b942cb
Merge pull request #26125 from nextcloud/backport/25533/stable20
...
[stable20] send share notification instead of erroring on duplicate share
2021-03-19 09:19:14 +01:00
e36e4a571e
implement PagedProvider for file search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:22:34 +01:00
57042ab107
limit constructing of result objects in file search
...
even thought we currently have no proper way of limiting the search itself, we can at least limit the construction of the result objects.
this saves about 40% of the time spend in the search request in my local testing
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:22:31 +01:00
d3b279d98d
Merge pull request #26052 from nextcloud/backport/26048/stable20
...
[stable20] cache baseurl in url generator
2021-03-17 20:14:05 +01:00
4f18ff9815
Merge pull request #25944 from nextcloud/backport/25659/stable20
...
[stable20] catch notfound and forbidden exception in smb::getmetadata
2021-03-17 20:13:57 +01:00
71b793f8a1
Merge pull request #26091 from nextcloud/backport/25722/stable20
...
[stable20] apply object store copy optimization when 'cross storage' copy is wit…
2021-03-17 20:09:56 +01:00
c4da8d4e55
Merge pull request #26152 from nextcloud/backport/26137/stable20
...
[stable20] dont allow creating users with __groupfolders as uid
2021-03-17 20:06:56 +01:00
2982fa346b
Merge pull request #26181 from nextcloud/backport/26003/stable20
...
[stable20] Add getID function to the simplefile implementation
2021-03-17 20:06:15 +01:00
fe3b3a9cec
Merge pull request #26147 from nextcloud/backport/26013/stable20
...
[stable20] Return the fileid from `copyFromCache` and use it instead of doing an extra query
2021-03-17 20:04:11 +01:00
147134fc31
Add getID function to the simplefile implementation
...
Sometimes it is useful to get the actual fileid
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-17 16:15:46 +00:00
534a935433
remove explicit fclose from S3->writeStream
...
streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-17 09:36:11 +00:00
279f0d72f3
dont allow creating users with __groupfolders as uid
...
Fixes https://github.com/nextcloud/groupfolders/issues/338
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 18:51:58 +00:00
436cd31bd2
verify that cache entry is valid
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:04 +00:00
Robin Appelman
Joas Schilling
Lukas Reschke
Roeland Jago Douma
Julius Härtl
Maxence Lange
Vincent Petry
Arthur Schiwon
kesselb
Samuel
Roeland Jago Douma
Morris Jobke
John Molakvoæ (skjnldsv)