Roeland Jago Douma
37199c1da0
Merge pull request #25585 from nextcloud/enhancement/empty-email-validation
...
Micro-optimize validation of empty email addresses
2021-02-11 19:51:06 +01:00
Christoph Wurst
883848b58a
Micro-optimize validation of empty email addresses
...
Then we don't have to construct any validators.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 15:15:38 +01:00
Roeland Jago Douma
cc554890c1
Fix WebP availability check
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-11 11:31:38 +01:00
Roeland Jago Douma
d5dea10517
Merge pull request #25378 from nextcloud/bugfix/noid/mention-match-improvements
...
Improve mention matches
2021-02-11 10:33:15 +01:00
Roeland Jago Douma
7bacd710a1
Merge pull request #25460 from nextcloud/fix/apppassword/always_renew
...
Always renew apppasswords on login
2021-02-10 21:09:20 +01:00
Roeland Jago Douma
cd457cc68b
Always renew apppasswords on login
...
Else you can end up that you renewed your password (LDAP for example).
But they still don't work because you did not use them before you logged
in.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 19:02:37 +01:00
Roeland Jago Douma
25f9203a70
Fix remaining #25359
...
As a wise man once said:
"I like PRs that pass tests before merging"
C. Wurst, Feb 9th 2021
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 15:41:25 +01:00
Christoph Wurst
aabd73912e
Type the service registration
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 09:44:24 +01:00
Robin Appelman
111fa47f10
remove ReconnectWrapper
...
dbal now handles it's own reconnections: https://github.com/doctrine/dbal/blob/3.0.x/UPGRADE.md#the-pingableconnection-interface-is-removed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-09 16:40:09 +01:00
Roeland Jago Douma
f797a94393
Merge pull request #25531 from nextcloud/fix/dispatcher-argument-order
...
Fix the legacy dispatcher argument order
2021-02-09 14:39:12 +01:00
Robin Appelman
ec875227ec
forward query exception when fallback construction fails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-09 13:15:22 +01:00
Christoph Wurst
abc61a9f63
Fix the legacy dispatcher argument order
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 10:47:14 +01:00
Robin Appelman
3401be216d
forward original query exception when querying by name fails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-08 19:13:25 +01:00
Joas Schilling
98032425b4
Fix linter
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:06 +01:00
Joas Schilling
ef7ed47f14
Make Psalm happy
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:06 +01:00
Joas Schilling
1344c61145
Improve mention matches
...
The previous regex didn't correctly match users with . ' or -
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:05 +01:00
Roeland Jago Douma
cd77b1f238
Merge pull request #25499 from nextcloud/test/symfony-adapter
...
Test the symfony adapter / fix missing return object
2021-02-06 13:01:23 +01:00
Roeland Jago Douma
6e461248e0
Merge pull request #25500 from Worteks/fix-sharemanager-genericshareexception
...
fix(translation): replace static error message
2021-02-05 16:17:34 +01:00
Samuel
3a077a3903
revert(comment)
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 13:27:37 +01:00
Samuel
5f8dfa8e4c
revert(exception): keep throwing an exception for now
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 12:52:59 +01:00
Christoph Wurst
f6ddda8dad
Test the symfony adapter
...
To prevent regression in the future.
And make sure we always return an object …
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-05 12:14:47 +01:00
Samuel
59e43b4828
fix(translation): replace static error message
...
as suggested by @kesselb in nextcloud/server#25490
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 12:06:35 +01:00
Christoph Wurst
91e1707498
Log deprecation notice of GenericEventWrapper just once
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-05 08:45:58 +01:00
Roeland Jago Douma
137636b651
Merge pull request #24700 from Imajie/s3-creds
...
Resolves #24699 , Support ES2 and ECS instance providers for S3 buckets
2021-02-02 21:48:22 +01:00
Roeland Jago Douma
5c6d245661
Merge pull request #25393 from nextcloud/fix/25165/repair-dav-shares
...
add repair job for unencoded group share uris
2021-02-02 21:43:42 +01:00
Julius Härtl
18e2e86b95
Avoid template creators being registered multiple times
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-02-02 19:36:31 +01:00
Christoph Wurst
ad2033ef1d
Merge pull request #25444 from nextcloud/bug/25415/move-generic-errors-to-end
...
Check for generic errors at last.
2021-02-02 18:59:43 +01:00
Daniel Kesselberg
fe378200fa
Check for generic errors at last.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-02-02 18:28:49 +01:00
Arthur Schiwon
3ecc6d0a8a
show suggestion to clean up possible invalid shares later
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-29 17:43:58 +01:00
Arthur Schiwon
558f062ca6
add repair job for unencoded calendars
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-29 17:29:10 +01:00
Christoph Wurst
8fcc0e8d8c
Merge pull request #25302 from mziech/patch-2
...
Use RFC-compliant URL encoding for cookies
2021-01-29 13:38:02 +01:00
Julius Härtl
222d8e6c1a
Use proper path for scanner
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-29 09:40:46 +01:00
Julius Härtl
0d384dedaa
Obtain the user language from the passed in user id
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-29 08:56:32 +01:00
Julius Härtl
39a4b1c401
Normalize compared path to avoid renaming to the same directory
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-29 08:43:17 +01:00
Roeland Jago Douma
7e727a1a31
The objectid is a string
...
This allows the query to use the index. Else it has to resort on
scanning all the rows.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-28 22:09:55 +01:00
Julius Härtl
6c1b357973
Move TemplateProvider registration to boot context and make template type registration lazy
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:21 +01:00
Julius Härtl
0111381529
Only create template directory if it is present in the default skeleton
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:20 +01:00
John Molakvoæ (skjnldsv)
4f90766ba3
Skip template picker if none available
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-28 12:00:20 +01:00
Julius Härtl
7e6d69d166
Add templatedirectory config value to let admins have their custom templates by default
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:20 +01:00
John Molakvoæ (skjnldsv)
78e114ed72
Add template picker
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-28 12:00:18 +01:00
Julius Härtl
4974404774
files: Create files from template API
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 11:59:46 +01:00
Roeland Jago Douma
3a9c7f99f6
Merge pull request #25335 from nextcloud/fix/app-fetcher-php-compat-comparison
...
Fix/app fetcher php compat comparison
2021-01-27 15:14:52 +01:00
Christoph Wurst
e0f0e6e41a
Merge pull request #25268 from nextcloud/enh/previews/sgi-tga
...
Add SGI and TGA preview support
2021-01-27 14:54:27 +01:00
Christoph Wurst
b4f71ccf4d
Fix app fetcher php comparison to allow wider ranges
...
When app app specifies php 7.4 as upper limit we have to allow the
installation on php>7.4.0. The previous version check didn't do that.
This adjusts the regexes to discard any irrelevant suffix after the
three version numbers so that we can use more fine granular checks than
php's version_compare can do out of the box, like for php 7.4 we only
compare the major and minor version numbers and ignore the patch level.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-26 16:35:43 +01:00
Christoph Wurst
652bf9d363
Revert "Fix comparison of PHP versions"
...
This reverts commit bedd9acf78
.
2021-01-26 13:48:06 +01:00
Marco Ziech
4923c6be25
Use RFC-compliant URL encoding for cookies
...
PHP 7.4.2 changed the way how cookies are decoded, applying RFC-compliant raw URL decoding. This leads to a conflict Nextcloud's own cookie encoding, breaking the remember-me function if the UID contains a space character.
Fixes #24438
Signed-off-by: Marco Ziech <marco@ziech.net>
2021-01-24 14:18:28 +01:00
Christoph Wurst
99d525eb36
Convert 2FA token type to string
...
The IConfig service is documented to handle its data as strings, hence
this changes the code a bit to ensure we store keys as string and
convert them back when reading.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-22 14:09:37 +01:00
John Molakvoæ (skjnldsv)
d47b84be67
Add SGI and TGA preview support
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-22 10:42:51 +01:00
Morris Jobke
10214fbee0
Merge pull request #25214 from nextcloud/dependabot/composer/phpseclib/phpseclib-2.0.30
...
Bump phpseclib/phpseclib from 2.0.25 to 2.0.30
2021-01-21 10:25:02 +01:00
Robin Appelman
d182043e83
explicitly set permissions on newly created folders
...
this works around any `umask` that might be set and limiting the folder permissions
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-20 17:15:57 +01:00