Commit Graph

24445 Commits

Author SHA1 Message Date
Morris Jobke 5448306238
Merge pull request #26658 from nextcloud/bugfix/noid/continue-on-denied-acls
Do not stop directory listing when ACL is blocking access
2021-04-20 21:35:19 +02:00
Morris Jobke ea0f022816
Merge pull request #26661 from nextcloud/bugfix/noid/fix-ldap-unit-test
Fix LDAP unit tests
2021-04-20 21:34:21 +02:00
Morris Jobke 6c0bb2c338
Merge pull request #26594 from nextcloud/enh/2fa/bootstrap
Move 2FA registration to IBootstrap
2021-04-20 21:30:15 +02:00
Morris Jobke 25406ebba2
Merge pull request #26652 from nextcloud/bugfix/noid/fix-broken-test
Fix broken Expiration test
2021-04-20 21:28:36 +02:00
Roeland Jago Douma a34085e1a2 Move 2fa backupscode to new registration
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 21:01:16 +02:00
Roeland Jago Douma 85bdf6c0fc
Merge pull request #26660 from nextcloud/bugfix/noid/fix-twofactor-backupcodes-tests
Fix twofactor backup code tests
2021-04-20 20:44:33 +02:00
Roeland Jago Douma d34d3d168d
Merge pull request #26659 from nextcloud/bugfix/noid/fix-updatenotification-test
Fix update notification tests
2021-04-20 20:43:56 +02:00
Joas Schilling 379664974c
Fix DAV unit tests
6) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAccept
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

7) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptSequence
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

8) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptRecurrenceId
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

9) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptTokenNotFound
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

10) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptExpiredToken
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

11) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testDecline
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

12) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testProcessMoreOptionsResult
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

13) OCA\DAV\Tests\unit\CalDAV\CalendarTest::testConfidentialClassification with data set #0 (3, false)
No method rule is set

14) OCA\DAV\Tests\unit\DAV\Migration\RefreshWebcalJobRegistrarTest::testRun
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:30:21 +02:00
Joas Schilling 39e248d330
Fix LDAP unit tests
20) OCA\user_ldap\tests\Jobs\UpdateGroupsTest::testHandleKnownGroups
Trying to configure method "fetchAll" which cannot be configured because it does not exist, has not been specified, is final, or is static

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:22:52 +02:00
Joas Schilling fe8d98f84b
Fix twofactor backup code tests
16) OCA\TwoFactorBackupCodes\Tests\Unit\Listener\ActivityPublisherTest::testHandleCodesGeneratedEvent
Method publish may not return value of type Mock_IEvent_11bf8381, its return declaration is ": void"

17) OCA\TwoFactorBackupCodes\Tests\Unit\Controller\SettingsControllerTest::testCreateCodes
Method getBackupCodesState may not return value of type string, its return declaration is ": array"

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:18:15 +02:00
Julius Härtl 8f01bc65f1
Continue iterating over diretory contents and just hide file if denied by acl
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-20 17:17:09 +02:00
Joas Schilling 42140ab53f
Fix update notification tests
18) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #1 ('app2', '1.0.1', '1.0.0', '1.0.0', true, array('user1'), array(array('user1')))
Method notify may not return value of type Mock_INotification_2134ee38, its return declaration is ": void"

19) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #2 ('app3', '1.0.1', false, false, true, array('user2', 'user3'), array(array('user2'), array('user3')))
Method notify may not return value of type Mock_INotification_2134ee38, its return declaration is ": void"

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:15:31 +02:00
Joas Schilling fc6fbb6499
Fix broken Expiration test
15) Warning
The data provider specified for OCA\Files_Trashbin\Tests\ExpirationTest::testGetMaxAgeAsTimestamp is invalid.
PHPUnit\Util\Exception: Method timestampTestData does not exist

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:53:00 +02:00
Jan C. Borchardt 9d1e2c5082
Merge pull request #26548 from nextcloud/design/files-accessibility
Files & Core accessibility fixes
2021-04-20 13:51:40 +02:00
Morris Jobke 67ab4dd6c7
Merge pull request #26624 from nextcloud/enh/sharing/readperm
Consider read permission in sharing tab
2021-04-20 09:27:45 +02:00
Julius Härtl 59f8685af2
Merge pull request #26633 from nextcloud/enh/sharee/lookup_later
Make lookup search explicit
2021-04-20 05:38:00 -01:00
Nextcloud bot 79116e825c
[tx-robot] updated from transifex 2021-04-20 02:25:58 +00:00
Morris Jobke a67f0b0c47
Merge pull request #26615 from nextcloud/enh/ffs/require_read
Require read permissions for federated shares
2021-04-19 21:50:48 +02:00
Jan C. Borchardt 738ac612d2
Fix accessibility of federation menu privacy buttons
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:54 +02:00
Jan C. Borchardt 64e90cdc66
Fix accessibility of profile picture section
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:54 +02:00
Jan C. Borchardt f86a2239e7
Fix missing label of Files navigation sublist toggles
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:53 +02:00
Jan C. Borchardt abedc275d9
Fix missing label of grid view toggle
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:53 +02:00
Jan C. Borchardt 749a266f78
Add proper labels for personal settings privacy toggles
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 20:34:47 +02:00
Jan C. Borchardt 317c77f70f
Improve focus feedback for file list actions
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 20:34:46 +02:00
Jan C. Borchardt a649fbc404
Fix summary footer position and text contrast
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 20:34:46 +02:00
Roeland Jago Douma 2ef326d6b6
Merge pull request #26618 from nextcloud/bugfix/noid/fix-english-language
Fix English source string
2021-04-19 20:08:04 +02:00
Roeland Jago Douma dcd45427a6 Make lookup search explicit
Speedsup sharee lookup quite a bit.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 20:05:21 +02:00
Roeland Jago Douma adab9deb3e
Merge pull request #26601 from nextcloud/dependabot/npm_and_yarn/nextcloud/dialogs-3.1.2
Bump @nextcloud/dialogs from 3.1.1 to 3.1.2
2021-04-19 19:53:14 +02:00
Roeland Jago Douma 68dadc01af Consider read permission in sharing tab
When updating a share we should make sure to use all the old permissions
(and only change what we actually changed). So the READ permission in
this case should also be fetched instead of always granted.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 15:10:51 +02:00
dependabot[bot] 5370c54084 Bump @nextcloud/dialogs from 3.1.1 to 3.1.2
Bumps [@nextcloud/dialogs](https://github.com/nextcloud/nextcloud-dialogs) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/nextcloud/nextcloud-dialogs/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-dialogs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-dialogs/compare/v3.1.1...v3.1.2)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-04-19 11:37:24 +00:00
Joas Schilling 422ecdeb20
Fix English source string
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-19 13:11:34 +02:00
Roeland Jago Douma 5c42c303e4 Require read permissions for federated shares
Else they end up as weird shares that can't be properly utilized by
other parties anyway.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 12:53:49 +02:00
Roeland Jago Douma 241dfab33f Do not allow adding file drop shares to your own cloud
There is no reason for this and you can't create such shares normally
anyway.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 12:17:58 +02:00
Nextcloud bot 8c82dd37b4
[tx-robot] updated from transifex 2021-04-19 02:26:04 +00:00
Nextcloud bot 286acbedef
[tx-robot] updated from transifex 2021-04-18 02:24:11 +00:00
Nextcloud bot 3ab7d6cf3e
[tx-robot] updated from transifex 2021-04-17 02:24:04 +00:00
Roeland Jago Douma 9b86e6f829 Listen to proper UserDeletedEvent
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 14:31:40 +02:00
Roeland Jago Douma 0593b039fc Move over notification to new registration
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 13:56:28 +02:00
Roeland Jago Douma ec66943efd
Merge pull request #26559 from J0WI/updno-strict
Updatenotification: add missing strict_types
2021-04-16 10:16:25 +02:00
Roeland Jago Douma 3d1015c87a
Merge pull request #26560 from J0WI/backupcodes-strict
2FA backupcodes: add strict typing
2021-04-16 10:14:53 +02:00
Roeland Jago Douma 7d8ff27928
Merge pull request #26558 from J0WI/dashboard-strict
Dashboard: add missing strict_types
2021-04-16 10:13:02 +02:00
Nextcloud bot 07278ed57d
[tx-robot] updated from transifex 2021-04-16 02:25:50 +00:00
J0WI 899413b506 Format header
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-15 16:57:06 +02:00
J0WI 09368e7cf5 2FA backupcodes: add strict typing
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-15 16:57:06 +02:00
Vincent Petry af61486aea
Separate settings for remote share expiration
Added separate settings for default and enforced expiration date for
remote shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +02:00
Vincent Petry 2650da70ca
Unit tests for federated share expiration date
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:03 +02:00
Vincent Petry b0aaafe259
Fix expire date capability for federated shares
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:03 +02:00
Vincent Petry 8680bafc5c
Implement expiration date for federated shares
Add expiration date field in UI.
Save expiration date when creating or updating federated share.
Read expiration date from DB in federated share provider.
Applies to both federated user and group shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:00 +02:00
Nextcloud bot 8ef920fdf9
[tx-robot] updated from transifex 2021-04-15 02:25:10 +00:00
J0WI 684a0da48a Dashboard: add missing strict_types
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-14 16:46:25 +02:00