Commit Graph

57708 Commits

Author SHA1 Message Date
Roeland Jago Douma d5dea10517
Merge pull request #25378 from nextcloud/bugfix/noid/mention-match-improvements
Improve mention matches
2021-02-11 10:33:15 +01:00
Konrad Abicht d60dd8a208 added unit tests for LoginFlowV2Service::startLoginFlow
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-11 09:56:09 +01:00
Konrad Abicht f29748a5e1 added unit tests for LoginFlowV2Service::getByLoginToken
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-11 09:49:39 +01:00
Konrad Abicht b0a2278a7e added unit tests for LoginFlowV2Service::poll
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-11 09:38:29 +01:00
Nextcloud bot 02885358a9
[tx-robot] updated from transifex 2021-02-11 02:20:37 +00:00
Christoph Wurst 8a474305fa
Merge pull request #25570 from nextcloud/enh/dashboard/psalm_fixes
Some psalm fixes for the DashboardController
2021-02-10 21:37:18 +01:00
Roeland Jago Douma 7bacd710a1
Merge pull request #25460 from nextcloud/fix/apppassword/always_renew
Always renew apppasswords on login
2021-02-10 21:09:20 +01:00
Roeland Jago Douma a6cd238517 Some psalm fixes for the DashboardController
* Use the AppFramework IInitialState
* Set return type

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 20:00:04 +01:00
Roeland Jago Douma d0cf4e2f58
Merge pull request #24904 from nextcloud/enh/github-psalm
Have psalm analysis directly on github
2021-02-10 19:03:55 +01:00
Roeland Jago Douma cd457cc68b Always renew apppasswords on login
Else you can end up that you renewed your password (LDAP for example).
But they still don't work because you did not use them before you logged
in.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 19:02:37 +01:00
Roeland Jago Douma 1cc23c6e6e
Merge pull request #25558 from nextcloud/deprecate/generic-event-wrapper
Deprecate the GenericEvent wrapper
2021-02-10 18:57:07 +01:00
Roeland Jago Douma 847ee4041a
Merge pull request #25566 from nextcloud/fix/25359/followup
Fix remaining #25359
2021-02-10 18:02:24 +01:00
Christoph Wurst 039ecbdcf9
Merge pull request #25560 from nextcloud/enhancement/pure-psr-event
Make our event base class independent of Symfony and follow PSR
2021-02-10 16:13:06 +01:00
Roeland Jago Douma 25f9203a70 Fix remaining #25359
As a wise man once said:

"I like PRs that pass tests before merging"
C. Wurst, Feb 9th 2021

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 15:41:25 +01:00
Christoph Wurst 2f26ff40e9
Merge pull request #25359 from nextcloud/enhancement/typed-service-registration
Type the service registration
2021-02-10 15:31:42 +01:00
Roeland Jago Douma 8677870a09
Merge pull request #25435 from nextcloud/fix/favorite-icon
Fix favorite dark icon
2021-02-10 15:19:04 +01:00
Christoph Wurst 0a28440bf6
Make our event base class independent of Symfony and follow PSR
Symfony is migrating towards a pure PSR event dispatcher, hence their
event class is POPO that implements the PSR stoppable event interface.
Since we can do that ourself and this change doesn't come with any API
changes (breakage), it's easy for us to become independent of Symfony
but also stay PSR-compliant at the same step.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 15:15:29 +01:00
Roeland Jago Douma f9a4871bd4
Merge pull request #25557 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
[Automated] Update psalm-baseline.xml
2021-02-10 15:15:04 +01:00
Roeland Jago Douma cc18213c98 Have psalm analysis directly on github
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 14:57:36 +01:00
Lukas Reschke d42f9e65a2
Merge pull request #25554 from nextcloud/fix/pslam/tainted_cookie
tain-escape the cookie input
2021-02-10 12:20:49 +01:00
Christoph Wurst aabd73912e
Type the service registration
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 09:44:24 +01:00
Christoph Wurst f76ec25e58
Deprecate the GenericEvent wrapper
This class is a convenience type to replace the old Symfony GenericEvent
with our own type, to ease the transition from Symfony events to our
(PSR) events. Hence we can deprecate the class as precaution to smoothen
the next transition step in the future.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 08:54:08 +01:00
Nextcloud-PR-Bot 130ce14892 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-02-10 04:31:13 +00:00
Nextcloud bot decb70b9ac
[tx-robot] updated from transifex 2021-02-10 02:20:59 +00:00
Roeland Jago Douma 784a752c0f tain-escape the cookie input
we only set the cookie if it is a proper <=32 char alphanum string.
Otherwise we just ignore the input.
Makes psalm also happier so that we can focus on other errors.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-09 22:35:18 +01:00
Christoph Wurst e4ca0c9fa0
Merge pull request #25548 from k00ni/pr/add-tests-for-LoginFlowV2Credentials
Added tests for OC\Core\Data\LoginFlowV2Credentials
2021-02-09 21:37:37 +01:00
Lukas Reschke 1fb03b3b2f
Merge pull request #25545 from k00ni/fix/Dockerfile-wrong-package-name-php7.4-acpu
Corrected package name used in .devcontainer/Dockerfile (php7.4-acpu => php7.4-apcu)
2021-02-09 21:26:30 +01:00
Christoph Wurst 3c2ea99940
Merge pull request #25546 from nextcloud/techdept/deprecate-event-constants
Deprecate all remaining event constants
2021-02-09 20:19:04 +01:00
Christoph Wurst f96f0f6cad
Merge pull request #25543 from nextcloud/deprecate/idb-events
Deprecate the internal IDBConnection event name constants
2021-02-09 18:50:55 +01:00
Christoph Wurst f8808e260d
Move app_password_created to a typed event
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 18:49:35 +01:00
Christoph Wurst 4201fb25d3
Merge pull request #25549 from nextcloud/remove-reconnect-wrapper
remove ReconnectWrapper
2021-02-09 18:15:56 +01:00
Robin Appelman 111fa47f10
remove ReconnectWrapper
dbal now handles it's own reconnections: https://github.com/doctrine/dbal/blob/3.0.x/UPGRADE.md#the-pingableconnection-interface-is-removed

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-09 16:40:09 +01:00
Konrad Abicht a50c615d37 simplified tests
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 15:48:37 +01:00
Konrad Abicht a28705064b fixed coding style issue
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 15:40:19 +01:00
Konrad Abicht b38a619212 added tests for OC\Core\Data\LoginFlowV2Credentials
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 15:25:37 +01:00
Roeland Jago Douma f797a94393
Merge pull request #25531 from nextcloud/fix/dispatcher-argument-order
Fix the legacy dispatcher argument order
2021-02-09 14:39:12 +01:00
Christoph Wurst 4c6bc62f38
Merge pull request #25535 from nextcloud/query-exception-foreward
Improve exception when auto-wiring fails
2021-02-09 14:27:43 +01:00
Christoph Wurst 4fc0b2c639
Deprecate all remaining event constants
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 13:53:41 +01:00
Konrad Abicht f987eaea10 corrected package name used in .devcontainer/Dockerfile (php7.4-acpu => php7.4-apcu)
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 13:52:52 +01:00
Roeland Jago Douma a36186980d
Merge pull request #25542 from nextcloud/fix-file-checker
Add .devcontainer to file-checker.php
2021-02-09 13:20:10 +01:00
Robin Appelman ec875227ec
forward query exception when fallback construction fails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-09 13:15:22 +01:00
Christoph Wurst 3d075c370a
Deprecate the internal IDBConnection event name constants
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 11:27:59 +01:00
Lukas Reschke d4c718acad
Add .devcontainer to file-checker.php
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-02-09 11:22:29 +01:00
Christoph Wurst abc61a9f63
Fix the legacy dispatcher argument order
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 10:47:14 +01:00
Nextcloud bot 9eea1e56dc
[tx-robot] updated from transifex 2021-02-09 02:20:45 +00:00
Roeland Jago Douma 983f7f3e49
Merge pull request #25493 from Worteks/fix-filessharing-debug
fix(log): remove debug log in _formatRemoteShare, suggested by @maxbes
2021-02-08 21:40:05 +01:00
Roeland Jago Douma 4854f91d94
Merge pull request #25423 from nextcloud/codespace
Add support for Codespaces
2021-02-08 21:27:02 +01:00
Robin Appelman 3401be216d
forward original query exception when querying by name fails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-08 19:13:25 +01:00
Lukas Reschke 838c7005d3 Install more PHP modules by default
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-02-08 17:16:29 +00:00
Lukas Reschke b68ff8df64 Hard-code SMTP configuration
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-02-08 17:08:42 +00:00