6fcf729545
[tx-robot] updated from transifex
2019-03-14 16:08:31 +00:00
e36cede994
remove unused use statement
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-03-06 00:34:29 +01:00
5dd2207c95
fix nested group retrieval also for 2 other cases
...
and also consolidate logic in one method
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-03-05 11:07:40 +01:00
459b8a4845
Fixed unit test: groupsMatchFilter will not be called multiple times anymore.
...
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2019-03-05 11:07:40 +01:00
e7c506cff1
Reduce queries to LDAP by caching nested groups
...
Nested groups are now cached in a CappedMemoryCache object to reduce
queries to the LDAP backend.
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2019-03-05 11:07:40 +01:00
afb182650e
user_ldap: really resolve nested groups
...
The previous patch fixed the problem only for one level of indirection
because groupsMatchFilter() had been applied on each recursive call (and
thus there would be no second level if the first level fails the check).
This new implementation replaces the recursive call with a stack that
iterates all nested groups before filtering with groupsMatchFilter().
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2019-03-05 11:07:40 +01:00
c2d8a36d9a
user_ldap: Filter groups after nexted groups
...
Currently groupsMatchFilter is called before nested groups are resolved.
This basicly breaks this feature since it is not possible to inherit
membership in a group from another group.
Minimal example:
Group filter: (&(objectClass=group),(cn=nextcloud))
Nested groups: enabled
cn=nextcloud,ou=Nextcloud,ou=groups,dn=company,dn=local
objectClass: group
cn=IT,ou=groups,dn=company,dn=local
objectClass: group
memberOf: cn=nextcloud,ou=Nextcloud,ou=groups,dn=company,dn=local
cn=John Doe,ou=users,dn=company,dn=local
objectClass: person
memberOf: cn=IT,ou=groups,dn=company,dn=local
Since 'cn=IT,ou=groups,dn=company,dn=local' doesn't match the group
filter, John wouldn't be a member of group 'nextcloud'.
This patch fixes this by filtering the groups after all nested groups
have been collected. If nested groups is disabled the result will be the
same as without this patch.
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2019-03-05 11:07:35 +01:00
6ee7286b41
Fix tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-01 20:57:01 +01:00
374f89aba1
[tx-robot] updated from transifex
2019-03-01 01:12:36 +00:00
057e81a1e2
[tx-robot] updated from transifex
2019-02-28 01:12:39 +00:00
36b01e3c2d
[tx-robot] updated from transifex
2019-02-27 01:12:05 +00:00
876e2792d0
[tx-robot] updated from transifex
2019-02-26 01:12:12 +00:00
5df6400e28
[tx-robot] updated from transifex
2019-02-25 01:12:18 +00:00
73473de5de
Fixed grammar
...
Reported at Transifex.
Signed-off-by: Mark Ziegler <mark.ziegler@rakekniven.de>
2019-02-22 19:49:36 +01:00
10388eab34
[tx-robot] updated from transifex
2019-02-21 01:12:02 +00:00
ad0b67cbce
[tx-robot] updated from transifex
2019-02-19 01:12:10 +00:00
0b7b938a60
[tx-robot] updated from transifex
2019-02-18 01:12:09 +00:00
1374183f92
[tx-robot] updated from transifex
2019-02-17 01:13:29 +00:00
685c13e091
add GUI option to set the $home placeholder
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-02-14 15:22:22 +01:00
792bcb82ae
add LDAP ConfigHandler for external storages and "$home" var
...
* handler registered upon OCA\\Files_External::loadAdditionalBackends
event as user_ldap is loaded before files_external
* new configuration field "ldapExtStorageHomeAttribute" (not in GUI yet)
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-02-14 15:22:22 +01:00
5c10a46445
ensure attribute names are lower cased
...
otherwise they will be skipped when the results is being formatted and the
lower-cased result keys do not match.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-02-14 14:13:32 +01:00
4d8c42a4fb
[tx-robot] updated from transifex
2019-02-14 01:12:26 +00:00
45777abce0
[tx-robot] updated from transifex
2019-02-08 01:12:39 +00:00
0df5110127
[tx-robot] updated from transifex
2019-02-06 11:27:29 +00:00
18ae9d267a
Comment fix.
2019-01-30 23:23:09 +01:00
c868892d2d
iterate over bases instead of doing parallel search
...
parallel search is not compatible with paged search, but the letter is
usually always applied.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-01-28 23:00:59 +01:00
4611ad5a9c
[tx-robot] updated from transifex
2019-01-26 01:12:19 +00:00
2277c21f3e
[tx-robot] updated from transifex
2019-01-24 01:12:02 +00:00
2ba75ac9b0
[tx-robot] updated from transifex
2019-01-23 01:12:05 +00:00
e35a5ef387
[tx-robot] updated from transifex
2019-01-16 01:12:34 +00:00
56ad07b85e
[tx-robot] updated from transifex
2019-01-15 01:12:14 +00:00
8edd9b0e33
[tx-robot] updated from transifex
2019-01-14 01:12:00 +00:00
363c0c31f4
[tx-robot] updated from transifex
2019-01-13 01:12:53 +00:00
208788173d
Npmize (vendor) scripts
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 15:01:59 +01:00
a1b6333712
[tx-robot] updated from transifex
2019-01-05 01:11:57 +00:00
c1ddd2fec9
Merge pull request #13138 from nextcloud/enhancement/noid/ldap-remnants-detected-field
...
register and show when an LDAP user was detected as unavailable/deleted
2019-01-04 22:48:05 +01:00
925043c60c
ensure db is pristine before starting the tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-01-04 22:10:22 +01:00
a1f9ed1d7d
[tx-robot] updated from transifex
2019-01-04 01:12:28 +00:00
8d5b74b6b6
[tx-robot] updated from transifex
2018-12-31 01:11:41 +00:00
760c502f3c
[tx-robot] updated from transifex
2018-12-28 01:11:49 +00:00
1c3f468d56
[tx-robot] updated from transifex
2018-12-27 01:11:41 +00:00
9d5f7c7f62
[tx-robot] updated from transifex
2018-12-24 01:11:46 +00:00
85f14bc591
LDAP: extend remnants output with "detected on" field
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-12-21 17:24:28 +01:00
fbd4e9e651
add tests for the DUI
...
as they are interact with the DB they are more integraiton than unit tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-12-21 17:24:23 +01:00
8bacbffe28
do not forgot to store the second displayname portion
...
otherwise it causes a chain reaction of system addressbook updates
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-12-20 23:11:00 +01:00
3d53398d07
[tx-robot] updated from transifex
2018-12-19 01:11:46 +00:00
f36082838e
[tx-robot] updated from transifex
2018-12-18 01:11:34 +00:00
e7950a5bd6
Merge pull request #12693 from nextcloud/fix/11474/fix-first-ldap-login
...
fix exception on LDAP mapping during login
2018-12-17 13:07:21 +01:00
feb5366a42
LDAP clear cache on config modification also when done via API or CLI
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-12-17 00:31:27 +01:00
51f13a7e9c
[tx-robot] updated from transifex
2018-12-14 01:12:32 +00:00
7034df7d77
[tx-robot] updated from transifex
2018-12-13 01:11:56 +00:00
95d33cd889
[tx-robot] updated from transifex
2018-12-04 01:12:05 +00:00
68f04686a0
[tx-robot] updated from transifex
2018-11-29 01:11:34 +00:00
c32cc4a194
cache users as existing after mapping
...
during login they might be cached as non-existing and cause an Exception
in the long run
reduces some duplication, too
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-11-27 17:07:59 +01:00
6ce849f7b8
Add return type
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-11-25 12:30:54 +01:00
d17b32afd7
Fix count on string
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-11-24 22:06:45 +01:00
1751c28c28
Bump versions of server and the requirements of apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-23 10:28:40 +01:00
d664a9b37b
[tx-robot] updated from transifex
2018-11-23 01:12:51 +00:00
def8af3e7e
[tx-robot] updated from transifex
2018-11-16 01:12:14 +00:00
159d75945a
Merge pull request #12292 from nextcloud/fix/2947/lapse-sizelimit-error
...
avoid logging of "Partial search results returned: Sizelimit exceeded…"
2018-11-15 10:48:57 +01:00
aa88254f64
Shorten index name of calendar changes table
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-14 10:14:23 +01:00
bb352fb667
Use the defined func()->count() instead of manual counting
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-08 15:44:45 +01:00
deec5a70a0
avoid logging of "Partial search results returned: Sizelimit exceeded at"
...
LDAP servers respond with that even if a limit was passed with the
request. Having this statement logged causes a lot of confusion.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-11-07 13:15:55 +01:00
9d7f02ec47
[tx-robot] updated from transifex
2018-11-04 01:14:02 +00:00
0c5d9127e8
remove app specific IUserTools and consolidate test
...
Just some house keeping. IUserTools with used in even older days for
easier creation of Access instances…
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-30 22:44:50 +01:00
8b2b238d86
Merge pull request #12054 from nextcloud/fix/5212/interact-with-userobject
...
LDAP: announce display name changes so that addressbook picks it up
2018-10-30 13:38:16 +01:00
49456e42f9
do not run into UniqueConstraintViolationException
...
… when an unmapped user logs in for the first time when background job
mode is ajax and no memcache was configured.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-30 12:12:03 +01:00
31ccf8580a
Merge pull request #12070 from nextcloud/fix/noid/announce-chosen-uid
...
announce the chosen uid (fixes wrong variable usage)
2018-10-30 10:12:04 +01:00
d47e1513bc
remove unneeded empty search attribute values, fixes #12086
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-29 13:21:02 +01:00
05f909dcf3
fixes wrong variable usage
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-26 18:03:41 +02:00
a226f65aa2
Fix off-by-one bugs
...
This fixes warnings from LGTM:
Off-by-one index comparison against length may lead
to out-of-bounds read.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-26 17:31:42 +02:00
bbe44108b5
only write when the displayname differs, but then announce it
...
refs #5212 and fixes #9112
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-25 23:41:12 +02:00
2048872f9e
functions that were checked for are present since PHP 5.4, supported is >=/
...
* so the check from older days is really not necessary anymore
* resolves #10923
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-25 22:50:42 +02:00
a9fb21f9fc
[tx-robot] updated from transifex
2018-10-23 14:54:28 +00:00
171fe69db7
Merge pull request #11932 from nextcloud/font-nunito
...
Change typeface to Nunito
2018-10-23 15:14:10 +02:00
d9aa484641
Fix font-face on LDAP tooltip
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 13:12:08 +02:00
2ad38200fb
Add missing semicolons
...
This fixes some recommendations from LGTM:
Avoid automated semicolon insertion (90% of all statements
in the enclosing function have an explicit semicolon).
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-19 11:24:24 +02:00
b458ed9c82
Properly escape column name in "createFunction" call
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-16 15:24:02 +02:00
d9fe68ed12
[tx-robot] updated from transifex
2018-10-05 00:12:56 +00:00
b6e86121bc
[tx-robot] updated from transifex
2018-10-01 00:12:39 +00:00
dafd708075
[tx-robot] updated from transifex
2018-09-30 00:12:06 +00:00
73aabbd3c0
[tx-robot] updated from transifex
2018-09-29 00:12:16 +00:00
2ace0df82a
[tx-robot] updated from transifex
2018-09-27 00:12:26 +00:00
2f45045c96
[tx-robot] updated from transifex
2018-09-26 00:12:23 +00:00
bdb01064e2
[tx-robot] updated from transifex
2018-09-25 00:12:07 +00:00
bd89af478e
[tx-robot] updated from transifex
2018-09-22 00:12:06 +00:00
0211e17e3f
[tx-robot] updated from transifex
2018-09-21 00:12:08 +00:00
d9247f7640
Merge pull request #11245 from nextcloud/bugfix/8288/userldap-getusername-on-null
...
Check if user is null before getUsername
2018-09-18 11:38:16 +02:00
2a51572cc4
[tx-robot] updated from transifex
2018-09-17 00:12:30 +00:00
2d30511fa6
Check if user is null before getUsername
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-09-16 19:33:03 +02:00
40bb45225a
[tx-robot] updated from transifex
2018-09-16 00:12:29 +00:00
6112adfe06
[tx-robot] updated from transifex
2018-09-14 00:12:27 +00:00
10351cb9da
[tx-robot] updated from transifex
2018-09-13 00:12:08 +00:00
3653a2c889
[tx-robot] updated from transifex
2018-09-08 00:12:33 +00:00
3a08f71981
[tx-robot] updated from transifex
2018-09-06 00:12:53 +00:00
47cc5e5895
Update version requirements and versions of shipped apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-09-05 14:27:06 +02:00
bcaf9a48bb
[tx-robot] updated from transifex
2018-09-05 00:12:50 +00:00
021dad53be
[tx-robot] updated from transifex
2018-09-01 00:12:17 +00:00
4da9a15b32
[tx-robot] updated from transifex
2018-08-30 00:12:07 +00:00
8b47f45afa
[tx-robot] updated from transifex
2018-08-27 00:12:14 +00:00
d644cafae7
[tx-robot] updated from transifex
2018-08-25 00:12:33 +00:00
c850b3ac20
Merge pull request #10820 from nextcloud/fix/noid/emptydefaultprefix
...
[LDAP] The WebUI Wizard also should not assign empty config IDs
2018-08-24 21:37:00 +02:00
503fbc953e
[tx-robot] updated from transifex
2018-08-24 00:12:20 +00:00
7807add02d
[LDAP] The WebUI Wizard also should not assign empty config IDs
...
With 689df9a843#3270 .
The web UI creates now also a full configuration on first load. This fixes
#5094 .
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-23 17:58:35 +02:00
c0f48a7b40
[tx-robot] updated from transifex
2018-08-23 00:12:59 +00:00
65410ab1cb
[tx-robot] updated from transifex
2018-08-22 00:12:11 +00:00
3d8f174774
Resolve all group memberships properly
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-08-21 10:57:50 +02:00
9cf11bd73c
Merge pull request #10687 from nextcloud/fix/noid/false-positive-change-mention
...
don't blame randome people for background email updates
2018-08-20 14:37:41 +02:00
2b903aa267
fix unit tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-15 16:11:07 +02:00
62a9ec12bc
[tx-robot] updated from transifex
2018-08-15 00:13:40 +00:00
b497b06867
don't force LDAP updates on userExists anymore
...
and remove some deprecated code
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-14 17:57:24 +02:00
d05c815796
Merge pull request #8855 from nextcloud/feature/noid/ldap-integration-autotests
...
behat integration tests for LDAP
2018-08-14 14:14:22 +02:00
90a656305b
Bump autoloaders
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-10 15:03:22 +02:00
103a2c30fb
[tx-robot] updated from transifex
2018-08-10 00:12:26 +00:00
59e35e3bf7
tests for user storage location
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-10 00:28:44 +02:00
b069b13226
convert pagination tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
0f6d98eed2
convert connection tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
eaf352b8d1
integration test to ensure entries without displayname don't cause trouble
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
4e8db8aa11
convert LDAP offline and backup server integration tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
a39c995083
FIX: emit assignedUserId only for users
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
3450ed4536
integration test checking the group filter
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:10 +02:00
6a9bee478d
[tx-robot] updated from transifex
2018-08-01 00:11:59 +00:00
0c7a17795b
[tx-robot] updated from transifex
2018-07-28 00:12:07 +00:00
4d060755e5
[tx-robot] updated from transifex
2018-07-23 00:12:05 +00:00
a927d2fc08
[tx-robot] updated from transifex
2018-07-20 00:12:09 +00:00
858bd67eff
Fix tests for backup ldap server connection
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-13 09:16:57 +02:00
c2616df541
Only bind if configuration for the first server is available
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-13 08:25:10 +02:00
8ccb99f416
Merge pull request #10098 from nextcloud/feature/noid/ldap-image-attribute
...
allow admin to disable fetching of avatars as well as a specific attribute
2018-07-11 12:19:58 +02:00
0e0dd2a90b
[tx-robot] updated from transifex
2018-07-11 00:12:15 +00:00
a22bc0e787
[tx-robot] updated from transifex
2018-07-10 08:21:14 +00:00
846ab25fc0
adjust and add more unit tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-05 11:50:49 +02:00
343036e55c
allow admin to disable fetching of avatars as well as a specific attribute
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-05 11:12:51 +02:00
a4dda465c2
let user set avatar in nextcloud von LDAP provides invalid image data
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-03 01:45:07 +02:00
552da85df8
Iron User_LDAP tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-03 00:29:34 +02:00
28e64afb8c
Merge pull request #10034 from nextcloud/fix/noid/ldap-silence-quota-logmsgs
...
lower log level for quota manipulation cases
2018-06-28 23:06:23 +02:00
cc51a00c93
lower log level for quota manipulation cases
...
and simplify the forest of ifs a little bit
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-28 21:10:07 +02:00
7a728f2154
LDAP backup server should not be queried when auth fails
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-27 23:12:07 +02:00
e4551106f5
[tx-robot] updated from transifex
2018-06-22 00:12:11 +00:00
f9c98d8621
[tx-robot] updated from transifex
2018-06-21 00:12:47 +00:00
cad8824a8e
[tx-robot] updated from transifex
2018-06-20 00:12:26 +00:00
db9ad32d75
[tx-robot] updated from transifex
2018-06-16 00:13:15 +00:00
84a1c915e6
[tx-robot] updated from transifex
2018-06-15 00:12:49 +00:00
d91bed9490
[tx-robot] updated from transifex
2018-06-12 00:12:46 +00:00
36d74047f7
[tx-robot] updated from transifex
2018-06-03 00:12:47 +00:00
d9238b810a
[tx-robot] updated from transifex
2018-06-02 00:12:30 +00:00
9ac36dc30b
[tx-robot] updated from transifex
2018-05-31 00:12:36 +00:00
7df563ee39
[tx-robot] updated from transifex
2018-05-30 00:12:08 +00:00
c0ed6f91a8
Merge pull request #9640 from nextcloud/fix/9502/missedstatecheck
...
check user state when fetching to avoid dealing with offline objects, fixes #9502
2018-05-29 16:55:14 +02:00
645eaaa434
[tx-robot] updated from transifex
2018-05-29 00:12:21 +00:00
73cacb8896
check user state when fetching to avoid dealing with offline objects
...
fixes #9502
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-05-29 01:10:03 +02:00
Nextcloud bot
Arthur Schiwon
Roland Tapken
Julius Härtl
rakekniven
Filis Futsarov
Christoph Wurst
Morris Jobke
Daniel Kesselberg
Joas Schilling
Roeland Jago Douma
Stefan Weil
Jan-Christoph Borchardt
Roeland Jago Douma