23e2baeb95
Add option to check share ACL's when listing directories
...
If a file or folder in a directory doesn't have read permissions they
will not be shown
Note that enabling this option incurs a performance penalty additional
requests need to be made to get all the acl.
Additionally the acl resolving logic is fairly primitive at the moment
and might not work correctly in all setups (it should error to showing
the entry)
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-21 16:26:12 +02:00
8f650feede
Merge pull request #20114 from nextcloud/techdebt/noid/allow-some-apps-to-have-root-urls
...
Allow some apps to have root URLs in their own routing file
2020-04-21 16:00:34 +02:00
f0c1041d2e
[tx-robot] updated from transifex
2020-04-21 02:16:40 +00:00
9735b5d61f
Add method to storage backends to get directory content with metadata
...
Currently you need to use `opendir` and then call `getMetadata` for
every file, which adds overhead because most storage backends already
get the metadata when doing the `opendir`.
While storagebackends can (and do) use caching to relief this problem,
this adds cache invalidation dificulties and only a limited number of
items are generally cached (to prevent memory usage exploding when
scanning large storages)
With this new methods storage backends can use the child metadata they
got from listing the folder to return metadata without having to keep
seperate caches.
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-20 15:45:04 +02:00
708b4991d9
Fix legacy routes
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
078ac97939
[tx-robot] updated from transifex
2020-04-16 02:17:30 +00:00
3e849daf11
Fix issues with Keystone auth v3 in files_external app
...
Signed-off-by: Julien Lutran <julien.lutran@corp.ovh.com>
2020-04-15 10:33:08 +02:00
bccd13ffae
[tx-robot] updated from transifex
2020-04-15 02:17:12 +00:00
6187cea304
[tx-robot] updated from transifex
2020-04-13 02:19:45 +00:00
28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
1584c9ae9c
Add visibility to all methods and position of static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
078b12a9b0
[tx-robot] updated from transifex
2020-04-10 02:18:23 +00:00
008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup
...
Remove all extra whitespace PSR2 does not like
2020-04-09 20:39:37 +02:00
64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords
...
Use php keywords in lowercase
2020-04-09 16:25:14 +02:00
f4c09f299d
Make sure there is exactly one newline after imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:14:31 +02:00
bcd13296de
Make sure every file ends with an empty newline
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:11:50 +02:00
a8a06a82d2
Remove trailing whitespaces from comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:09:23 +02:00
44577e4345
Remove trailing and in between spaces
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
36b3bc8148
Use php keywords in lowercase
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 14:04:56 +02:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
41b5e5923a
Use exactly one empty line after the namespace declaration
...
For PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +02:00
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
732a239cfd
Merge pull request #20363 from nextcloud/smb-3.2.3
...
update icewind/smb to 3.2.3
2020-04-09 08:16:43 +02:00
85e369cddb
Fix multiline comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +02:00
2340f4f2d5
update icewind/smb to 3.2.3
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-08 17:30:47 +02:00
8146e1988c
[tx-robot] updated from transifex
2020-04-08 02:18:45 +00:00
1d62b9786f
Merge pull request #20276 from nextcloud/files-external-param-tooltop
...
allow setting tooltips for external storage config options
2020-04-06 16:42:39 +02:00
cac1480bf8
[tx-robot] updated from transifex
2020-04-05 02:18:04 +00:00
857957b45e
allow setting tooltips for external storage config options
...
allows explaining non-obvious config options a bit more
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-03 15:44:53 +02:00
4e8bbc4e34
[tx-robot] updated from transifex
2020-04-03 12:08:12 +00:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
fa4162e86f
Merge pull request #20208 from nextcloud/smb-folder-contents-normalize-path
...
normalize smb path while listing folder contents
2020-03-30 10:06:39 +02:00
20ecbd60fd
Merge pull request #20207 from nextcloud/smb-3.2.1
...
update icewind/smb to 3.2.1
2020-03-30 10:05:48 +02:00
89710bbdcf
[tx-robot] updated from transifex
2020-03-29 02:20:14 +00:00
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
...
Remove unused imports
2020-03-27 17:14:08 +01:00
ef7bb5225a
normalize smb path while listing folder contents
...
currently when listing `'/'`, it will include a double slash in the paths used for the listing logic
this causes unneeeded cache misses in the statCache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-27 17:04:53 +01:00
b41e62db99
update icewind/smb to 3.2.1
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-27 16:57:55 +01:00
f680f19364
[tx-robot] updated from transifex
2020-03-27 02:18:20 +00:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
2ee65f177e
Use the shorter phpunit syntax for mocked return values
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:21:27 +01:00
74936c49ea
Remove unused imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +01:00
e4d85fa284
[tx-robot] updated from transifex
2020-03-25 02:18:27 +00:00
be4cf8992d
[tx-robot] updated from transifex
2020-03-23 02:19:02 +00:00
c5cb3bb665
Do not use the deprecated service name
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-19 15:04:23 +01:00
0eb3c3ed18
Merge pull request #19932 from nextcloud/remove-placeholder-check
...
remove the requirement that everything that looks like a placeholder …
2020-03-17 21:34:08 +01:00
82d4bdd770
[tx-robot] updated from transifex
2020-03-17 02:18:42 +00:00
0d6c8a3476
[tx-robot] updated from transifex
2020-03-15 02:19:16 +00:00
db49ae3cb6
fix external storage controller tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-13 15:33:47 +01:00
59082661ca
remove the requirement that everything that looks like a placeholder is substituted
...
While maybe not common, `$` is a valid option in config fields
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-13 15:29:14 +01:00
17bc35e4f1
Merge pull request #19915 from nextcloud/external-storage-password-placeholders
...
Use placeholder values for password fields in external storage webui
2020-03-13 10:54:40 +01:00
0d112d7901
Use placeholder values for password fields in external storage webui
...
This prevents the password from being sent to the webui.
While an admin will always be able to retrieve the passwords (as they
can do arbitrairy code execution by design) this prevents casual
password snooping
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-12 19:45:23 +01:00
99aa7adaef
[tx-robot] updated from transifex
2020-03-12 02:19:02 +00:00
223ee42a53
faster implementation of SFTP write stream
...
using mostly the same techniques as the read stream
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-10 16:18:40 +01:00
fe4e80093e
Faster implementation of sftp read stream
...
- Keeps a single file handle open instead of creating a new one for
every stream_read
- Read from sftp in large chunks instead of the 8k internal php size
- Request a read for the next chunk while we're still processing the
current one
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-06 16:57:18 +01:00
48b374f683
[tx-robot] updated from transifex
2020-03-05 02:18:19 +00:00
dccecf822d
[tx-robot] updated from transifex
2020-02-28 02:18:36 +00:00
0e7163c7c1
[tx-robot] updated from transifex
2020-02-26 02:18:20 +00:00
9d122c39ab
[tx-robot] updated from transifex
2020-02-23 02:19:29 +00:00
eb28572f9b
[tx-robot] updated from transifex
2020-02-19 02:18:14 +00:00
8a841fc331
[tx-robot] updated from transifex
2020-02-14 02:18:09 +00:00
c34570faf8
[tx-robot] updated from transifex
2020-02-13 02:19:26 +00:00
29ec5e6c96
[tx-robot] updated from transifex
2020-02-11 02:18:33 +00:00
6a82bb1f00
[tx-robot] updated from transifex
2020-02-08 02:18:22 +00:00
1afe8906bc
[tx-robot] updated from transifex
2020-02-07 02:20:10 +00:00
d2d7e37b7b
Merge pull request #19312 from nextcloud/fix/18195/do-not-overwrite-user-glob-auth
...
do not overwrite global user auth credentials with empty values
2020-02-06 10:20:56 +01:00
698cfbd9cb
[tx-robot] updated from transifex
2020-02-06 02:18:41 +00:00
7e1d14d9a5
do not overwrite global user auth credentials with empty values
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-02-06 00:14:29 +01:00
f11e4c9ec4
Merge pull request #19300 from nextcloud/rakekniven-patch-1
...
l10n: Triple dot to ellipsis
2020-02-05 14:22:46 +01:00
e1bc815813
l10n: Triple dot to ellipsis
...
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
2020-02-05 06:31:42 +01:00
23fc654fc4
[tx-robot] updated from transifex
2020-02-05 02:18:06 +00:00
750181d283
[tx-robot] updated from transifex
2020-02-03 02:16:46 +00:00
f39c1a21f8
[tx-robot] updated from transifex
2020-02-02 02:17:40 +00:00
0585c76d16
[tx-robot] updated from transifex
2020-01-29 02:18:13 +00:00
22e3a74f90
[tx-robot] updated from transifex
2020-01-24 02:16:52 +00:00
2a01308d5c
[tx-robot] updated from transifex
2020-01-23 02:18:24 +00:00
53516032f7
Compile templates
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-01-21 16:26:05 +01:00
8728eab9d7
Fix app updates
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-21 14:00:58 +01:00
53c37a170d
[tx-robot] updated from transifex
2020-01-21 02:17:28 +00:00
4c1e631be9
[tx-robot] updated from transifex
2020-01-20 02:17:27 +00:00
434fd438d9
[tx-robot] updated from transifex
2020-01-19 02:17:21 +00:00
46706d01e0
[tx-robot] updated from transifex
2020-01-05 02:30:34 +00:00
797b603a1f
[tx-robot] updated from transifex
2020-01-04 02:27:44 +00:00
67b14cc0bd
[tx-robot] updated from transifex
2020-01-02 02:27:10 +00:00
1d8da461d5
[tx-robot] updated from transifex
2019-12-23 02:27:33 +00:00
c81e05db98
[tx-robot] updated from transifex
2019-12-22 02:28:34 +00:00
1b46621cd3
Update license headers for 18
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-20 09:23:25 +01:00
f63156976b
fix credentials saving success message notification color
...
was red, now green
Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
2019-12-18 15:32:39 +01:00
c60955f436
[tx-robot] updated from transifex
2019-12-12 02:26:32 +00:00
98e2291f7a
[tx-robot] updated from transifex
2019-12-10 02:16:43 +00:00
0360ab408e
Merge pull request #18256 from nextcloud/files-aditional-scripts-new-events
...
Use non-depricated events for loading additional scripts in files app
2019-12-09 21:24:55 +01:00
1c585d2c50
use OCP\EventDispatcher\GenericEvent in more places
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-12-09 14:24:57 +01:00
43efa40864
rejig right to left join for sqlite's satisfaction
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-12-06 11:37:31 +01:00
da84b36186
[tx-robot] updated from transifex
2019-12-06 02:16:59 +00:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +01:00
fae3ae8a2d
[tx-robot] updated from transifex
2019-12-05 02:16:52 +00:00
254d4e0964
Merge pull request #17920 from nextcloud/fix/15258/ext-storage-respect-deletion
...
when a user was deleted remove them from applicable list, unless...
2019-12-04 15:28:57 +01:00
7f80859ce4
[tx-robot] updated from transifex
2019-12-04 09:24:13 +00:00
4cbaf69bc3
[tx-robot] updated from transifex
2019-12-03 02:16:46 +00:00
6725a4b746
[tx-robot] updated from transifex
2019-11-30 02:16:49 +00:00
4baab51f4c
extend with group deletion handling
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-11-28 17:03:33 +01:00
be85d00a38
when a user was delete remove them from applicable list, unless
...
it is the only user, then remove the mount
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-11-28 17:03:33 +01:00
669302e570
Merge pull request #18064 from nextcloud/feature/php74
...
Add php7.4 support
2019-11-28 08:36:10 +01:00
563f9153a2
[tx-robot] updated from transifex
2019-11-28 02:16:54 +00:00
e3e782b63d
Fix external storagestests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 15:28:34 +01:00
3a7cf40aaa
Mode to modern phpunit
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 15:27:18 +01:00
c007ca624f
Make phpunit8 compatible
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:41 +01:00
7015501a74
Merge pull request #18005 from nextcloud/fix/manual-app-instances
...
Remove some more direct app instance creations
2019-11-26 09:20:14 +01:00
123c4aa4e0
[tx-robot] updated from transifex
2019-11-26 02:15:57 +00:00
9002b0f245
Merge pull request #18088 from nextcloud/dependabot/npm_and_yarn/handlebars-4.5.3
...
Bump handlebars from 4.5.2 to 4.5.3
2019-11-25 20:02:58 +01:00
11b57c062a
Bump handlebars from 4.5.2 to 4.5.3
...
Bumps [handlebars](https://github.com/wycats/handlebars.js ) from 4.5.2 to 4.5.3.
- [Release notes](https://github.com/wycats/handlebars.js/releases )
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md )
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.5.2...v4.5.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2019-11-25 13:13:57 +00:00
c7d5b8fc49
Merge pull request #18079 from nextcloud/fixes/phpcs
...
Some php-cs fixes
2019-11-25 14:07:00 +01:00
97385cef33
Remove some more direct app instance creations
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-11-25 08:42:16 +01:00
573c800b00
[tx-robot] updated from transifex
2019-11-25 02:15:54 +00:00
4f2837017c
[tx-robot] updated from transifex
2019-11-23 02:16:07 +00:00
68748d4f85
Some php-cs fixes
...
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +01:00
afa0f2c0d8
[tx-robot] updated from transifex
2019-11-20 02:16:19 +00:00
d8db8b1be5
Merge pull request #17873 from nextcloud/fix/17846/make-timeout-opt
...
Make timeout a optional parameter
2019-11-13 12:55:53 +01:00
9a460f9e39
[tx-robot] updated from transifex
2019-11-12 02:16:12 +00:00
eb5faa85a2
Compile handlebars
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-11-11 13:26:22 +01:00
cd7c7d78d7
[tx-robot] updated from transifex
2019-11-10 02:16:59 +00:00
2bd591f227
Make timeout a optional parameter
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-11-09 15:18:52 +01:00
e517ca0530
[tx-robot] updated from transifex
2019-11-04 02:15:26 +00:00
827a3c545a
[tx-robot] updated from transifex
2019-11-03 02:16:06 +00:00
686f1931ae
[tx-robot] updated from transifex
2019-11-02 02:14:58 +00:00
75b94cb5be
[tx-robot] updated from transifex
2019-11-01 07:46:26 +00:00
41cd251246
Bring back external storage group select delete
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-30 16:13:54 +01:00
97fd61ac45
[tx-robot] updated from transifex
2019-10-29 02:15:20 +00:00
4f2391d439
[tx-robot] updated from transifex
2019-10-27 02:14:12 +00:00
f9e323c188
[tx-robot] updated from transifex
2019-10-26 02:15:17 +00:00
4c83e9ce5f
Merge pull request #17616 from nextcloud/bug/15486/dont-fclose
...
Remove superfluous fclose
2019-10-23 19:51:17 +02:00
baee9ddc35
[tx-robot] updated from transifex
2019-10-23 02:15:24 +00:00
908f13e9b9
[tx-robot] updated from transifex
2019-10-22 02:15:41 +00:00
230f685987
Remove superfluous fclose
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-10-21 11:31:07 +02:00
560d9c3006
[tx-robot] updated from transifex
2019-10-21 02:15:49 +00:00
e0e938295e
[tx-robot] updated from transifex
2019-10-20 02:16:43 +00:00
64f1ad9381
added documentation links on settings pages ( #17585 )
...
added documentation links on settings pages
2019-10-18 12:06:42 +02:00
41c92813c3
[tx-robot] updated from transifex
2019-10-18 02:15:23 +00:00
126444d5a6
added documentation links on settings pages
...
Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
2019-10-17 15:09:49 +02:00
7f8ff16c76
[tx-robot] updated from transifex
2019-10-12 02:15:10 +00:00
85dbde060d
[tx-robot] updated from transifex
2019-10-08 02:15:01 +00:00
e9cef938ea
[tx-robot] updated from transifex
2019-10-05 02:15:04 +00:00
23af2726e8
[tx-robot] updated from transifex
2019-10-04 02:15:27 +00:00
74dcd84ee8
[tx-robot] updated from transifex
2019-10-02 02:15:09 +00:00
b9bc2417e7
Comply to eslint
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-01 17:16:09 +02:00
f9870eec2c
[tx-robot] updated from transifex
2019-10-01 12:41:53 +00:00
9e2bb5ef36
Move oauth admin settings to initialstate
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2019-09-28 13:30:34 +00:00
c8cd607681
Remove input id on login form ( #17294 )
...
Remove input id on login form
2019-09-28 10:46:31 +02:00
f737dc9a86
Remove input id on login form
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2019-09-28 08:15:03 +00:00
Robin Appelman
Roeland Jago Douma
Nextcloud bot
Joas Schilling
Julien Lutran
Christoph Wurst
Christoph Wurst
John Molakvoæ
Joas Schilling
Arthur Schiwon
rakekniven
John Molakvoæ (skjnldsv)
Roeland Jago Douma
Sascha Wiswedel
dependabot-preview[bot]
Julius Härtl
Daniel Kesselberg