Commit Graph

54117 Commits

Author SHA1 Message Date
Daniel Calviño Sánchez 87be93126f Fix share permission checkboxes enabled when permissions can not be set
A sharee can reshare a file and set the edit, create, delete and share
permissions of the reshare only if the received share has edit, create,
delete and share permissions, or if they were revoked in the received
share after being set in the reshare. Therefore, the permission
checkboxes in the share menu should be enabled only if the user can set
them (otherwise trying to check them will lead to an error).

Note that "sharePermissions" has all the permissions if the file is not
a reshare but a file owned by the user.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-06-29 20:16:03 +00:00
Joas Schilling b33c074d6e Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-29 12:08:33 +00:00
Joas Schilling 1c2d8faf34 Precalculate the primary element color for dark mode too
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-29 12:08:33 +00:00
Nextcloud bot e5e833a519
[tx-robot] updated from transifex 2020-06-29 02:16:45 +00:00
Nextcloud bot b2a6b874c4
[tx-robot] updated from transifex 2020-06-28 02:16:19 +00:00
Nextcloud bot 207d3e4a7c
[tx-robot] updated from transifex 2020-06-27 02:16:52 +00:00
Julius Härtl 737b65894b Remove rescanDelay from directory mtime
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-06-25 14:54:09 +00:00
Arthur Schiwon 43b8b0c14f fix strings being passed where arrays where expected
also brought type hints up to internal API level

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-25 08:06:29 +00:00
Nextcloud bot 8a0185d29b
[tx-robot] updated from transifex 2020-06-25 02:16:52 +00:00
blizzz 58804caf89
Merge pull request #21568 from nextcloud/backport/21564/stable19
[stable19] fix obsolete usage of OCdialogs
2020-06-24 22:44:26 +02:00
blizzz ca845138b7
Merge pull request #21571 from nextcloud/backport/21565/stable19
[stable19] comment was wrong, block is needed nevertheless
2020-06-24 22:41:25 +02:00
Daniel Calviño Sánchez 4401cd2717 Add acceptance test for disabling create permission after sharing
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-06-24 19:22:39 +00:00
Daniel Calviño Sánchez 244a7e16f3 Add acceptance test for sharing a folder without create permission
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-06-24 19:22:39 +00:00
Daniel Calviño Sánchez ae3af29646 Add acceptance test for sharing a file without edit permission
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-06-24 19:22:38 +00:00
Daniel Calviño Sánchez e815b13265 Generalize functions to get locators for share permission checkboxes
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-06-24 19:22:38 +00:00
Robin Appelman 654f5a2109 relax permissions mask check for detecting part file rename
with files drop uploads the original file name isn't always used for the '.ocTransferId' source path

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-06-24 19:11:18 +00:00
Arthur Schiwon 2a3ebe4353 comment was wrong, block is needed nevertheless
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-24 19:07:38 +00:00
Arthur Schiwon 003407e094 fix obsolete usage of OCdialogs
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-24 17:01:17 +00:00
Joas Schilling d4343de3eb
Merge pull request #21541 from nextcloud/backport/21417/stable19
[stable19] Fix modal support for vue apps and dark theme
2020-06-24 13:32:57 +02:00
Roeland Jago Douma 41587bd8fb
Merge pull request #21550 from nextcloud/backport/21535/stable19
[stable19] Fix language in share notes email for users
2020-06-24 09:02:09 +02:00
Nextcloud bot 7824599d71
[tx-robot] updated from transifex 2020-06-24 02:16:54 +00:00
Joas Schilling 407e3df585 Fix language in share notes email for users
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 21:29:49 +00:00
Joas Schilling 1230916274
Rebuild JS files
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 14:18:11 +02:00
Joas Schilling dc62eb086d
Darker background for dark mode
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 14:12:01 +02:00
Joas Schilling cf700c7ab4
Make the confirm dialog modal by default
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 14:09:51 +02:00
Joas Schilling 7723529d31
Fix modal support for vue apps
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 14:09:44 +02:00
Roeland Jago Douma 6b5db20fc9
Merge pull request #21526 from nextcloud/backport/21479/stable19
[stable19] Allow to specify the cookie type for appframework responses
2020-06-23 14:04:53 +02:00
Joas Schilling d1df66f7af Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 12:04:50 +00:00
Joas Schilling 9ce288163c Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 12:04:50 +00:00
Joas Schilling 83b0d37093 Add another test for exact matching of a user in group restriction
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 12:04:50 +00:00
Joas Schilling 7a36a4b99c Move back to IGroupManager::displayNamesInGroup()
The problem is that despite it's name IGroup::searchDisplayName()
only searches by userid and this is less fixable than changing back to this method here

Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 12:04:49 +00:00
Nextcloud bot 86fdf17eed
[tx-robot] updated from transifex 2020-06-23 02:17:20 +00:00
Roeland Jago Douma 286f79c388
Merge pull request #21447 from nextcloud/backport/21406/stable19
[stable19] Disable Client-Side Monitoring on AWS storage
2020-06-22 16:29:05 +02:00
Arthur Schiwon 002e1f1ed2
available since 19.0.1
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-22 13:43:18 +02:00
Roeland Jago Douma c21a976bc4 Allow to specify the cookie type for appframework responses
In general it is good to set them to Lax. But also to give devs more
control over them is not a bad thing.

Helps with #21474

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-06-22 11:02:50 +00:00
Roeland Jago Douma d1c19fbe23
Merge pull request #21521 from nextcloud/backport/21478/stable19
[stable19] Clarify that the email is always shared within the instance
2020-06-22 11:03:53 +02:00
Joas Schilling 127cfeee90 Clarify that the email is always shared within the instance
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-22 06:51:59 +00:00
Roeland Jago Douma adb5a80674
Merge pull request #21485 from nextcloud/backport/21482/stable19
[stable19] Don't log Keys
2020-06-21 09:19:35 +02:00
Nextcloud bot 973c933b71
[tx-robot] updated from transifex 2020-06-21 02:16:17 +00:00
Roeland Jago Douma a29355806a
Merge pull request #21493 from nextcloud/backport/21492/stable19
[stable19] acceptence tests shall specify which branch to pick when cloning apps
2020-06-20 16:01:09 +02:00
Roeland Jago Douma c62000c0bb
Merge pull request #21495 from nextcloud/backport/21483/stable19
[stable19] Give up after 10 seconds in SCSS timeout
2020-06-20 16:00:27 +02:00
Nextcloud bot b9c7865045
[tx-robot] updated from transifex 2020-06-20 02:16:46 +00:00
Roeland Jago Douma 88e121d684 Give up after 10 seconds in SCSS timeout
Else we keep idling for ages which leads to bad UX

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-06-19 19:29:56 +00:00
Arthur Schiwon 90de43dc94
acceptence tests shall specify which branch to pick when cloning apps
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-19 21:09:37 +02:00
blizzz 8f35a66100
Merge pull request #21491 from nextcloud/backport/21421/stable19
[stable19] getXbyY can still return false, e.g. when using ldap write support
2020-06-19 20:45:38 +02:00
blizzz 8e02367453 be more clear about the condition
Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com>
2020-06-19 18:03:07 +00:00
Arthur Schiwon 6f49974851 getXbyY can still return false, e.g. when using ldap write support
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-19 18:03:07 +00:00
Joas Schilling 0ebbabebe8 Don't log Keys
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-19 13:11:18 +00:00
Nextcloud bot e5b468fb1a
[tx-robot] updated from transifex 2020-06-19 02:16:37 +00:00
Nextcloud bot 085b076d84
[tx-robot] updated from transifex 2020-06-18 02:16:45 +00:00