fe8d98f84b
Fix twofactor backup code tests
...
16) OCA\TwoFactorBackupCodes\Tests\Unit\Listener\ActivityPublisherTest::testHandleCodesGeneratedEvent
Method publish may not return value of type Mock_IEvent_11bf8381, its return declaration is ": void"
17) OCA\TwoFactorBackupCodes\Tests\Unit\Controller\SettingsControllerTest::testCreateCodes
Method getBackupCodesState may not return value of type string, its return declaration is ": array"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:18:15 +02:00
8f01bc65f1
Continue iterating over diretory contents and just hide file if denied by acl
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-20 17:17:09 +02:00
42140ab53f
Fix update notification tests
...
18) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #1 ('app2', '1.0.1', '1.0.0', '1.0.0', true, array('user1'), array(array('user1')))
Method notify may not return value of type Mock_INotification_2134ee38, its return declaration is ": void"
19) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #2 ('app3', '1.0.1', false, false, true, array('user2', 'user3'), array(array('user2'), array('user3')))
Method notify may not return value of type Mock_INotification_2134ee38, its return declaration is ": void"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:15:31 +02:00
c6978bac80
Fix security credentials manager test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:04:24 +02:00
fc6fbb6499
Fix broken Expiration test
...
15) Warning
The data provider specified for OCA\Files_Trashbin\Tests\ExpirationTest::testGetMaxAgeAsTimestamp is invalid.
PHPUnit\Util\Exception: Method timestampTestData does not exist
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:53:00 +02:00
79ebc7f24c
Fix test by defining plurals
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:43:43 +02:00
2228b285c5
Only check translations insteda of the full file
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:43:43 +02:00
3cf447ac44
Fix PHP CS
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:43:43 +02:00
2b8e47dcac
Correclty use plural for share exception
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:43:40 +02:00
5a514a9a41
Correctly replace all PHP placeholders with the parameters
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:05 +02:00
439457d2b4
Fix languages that miss a string in the translation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:04 +02:00
a4c6749b02
Add a check for the pipe character
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:04 +02:00
157147cb8e
"Symfony\Component\Translation\PluralizationRules" is deprecated
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:04 +02:00
94322971a5
Merge pull request #26550 from nextcloud/fix/noid/prefer-cloudshare-over-mail-take2
...
hide mail share if a cloud share is possible – backend only solution
2021-04-20 14:26:14 +02:00
92ca49d21d
save a whitespace today
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-20 14:03:01 +02:00
f8d1ee5cfa
ignore mail shares of related remote share results
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-20 14:02:35 +02:00
9d1e2c5082
Merge pull request #26548 from nextcloud/design/files-accessibility
...
Files & Core accessibility fixes
2021-04-20 13:51:40 +02:00
a923761acb
l10n: Spelling unification
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-20 11:33:31 +02:00
8398762d78
Fail when creating new files with an empty path
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-20 11:20:20 +02:00
67ab4dd6c7
Merge pull request #26624 from nextcloud/enh/sharing/readperm
...
Consider read permission in sharing tab
2021-04-20 09:27:45 +02:00
69290781ff
Handle device login like an alternative login
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 09:11:33 +02:00
59f8685af2
Merge pull request #26633 from nextcloud/enh/sharee/lookup_later
...
Make lookup search explicit
2021-04-20 05:38:00 -01:00
79116e825c
[tx-robot] updated from transifex
2021-04-20 02:25:58 +00:00
a67f0b0c47
Merge pull request #26615 from nextcloud/enh/ffs/require_read
...
Require read permissions for federated shares
2021-04-19 21:50:48 +02:00
738ac612d2
Fix accessibility of federation menu privacy buttons
...
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:54 +02:00
64e90cdc66
Fix accessibility of profile picture section
...
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:54 +02:00
f86a2239e7
Fix missing label of Files navigation sublist toggles
...
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:53 +02:00
abedc275d9
Fix missing label of grid view toggle
...
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:53 +02:00
34396091e8
Fix screenreader label of search icon
...
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:53 +02:00
749a266f78
Add proper labels for personal settings privacy toggles
...
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 20:34:47 +02:00
317c77f70f
Improve focus feedback for file list actions
...
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 20:34:46 +02:00
a649fbc404
Fix summary footer position and text contrast
...
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 20:34:46 +02:00
2ef326d6b6
Merge pull request #26618 from nextcloud/bugfix/noid/fix-english-language
...
Fix English source string
2021-04-19 20:08:04 +02:00
dcd45427a6
Make lookup search explicit
...
Speedsup sharee lookup quite a bit.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 20:05:21 +02:00
adab9deb3e
Merge pull request #26601 from nextcloud/dependabot/npm_and_yarn/nextcloud/dialogs-3.1.2
...
Bump @nextcloud/dialogs from 3.1.1 to 3.1.2
2021-04-19 19:53:14 +02:00
4b376a107b
Add automatic handling of "ElementNotInteractable" exceptions
...
In the WebDriver protocol, when a command fails because it can not
interact with the target element, an "element not interactable" error is
generated. It can be a transitive issue (for example, due to an
animation), so when the error is received the command should be tried
again, just like done, for example, with "ElementNotVisible" exceptions.
However, the last version of the "instaclick/php-webdriver" library
compatible with the Selenium Driver of Mink did not support yet that
WebDriver error. And even if Chrome is run using the old protocol an
unknown "element not interactable" error can be received anyway in some
cases. When an unknown error is received by the
"instaclick/php-webdriver" library it is thrown as a generic Exception
so, until the library can be updated, the message of generic exceptions
is checked and the command is retried if it matched.
For the time being "element not interactable" errors are handled like
"ElementNotVisible" exceptions; this may need to change once the error
is better understood.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-19 16:35:11 +02:00
eeb72c3338
update icewind/smb to 3.4.1
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-19 16:00:47 +02:00
68dadc01af
Consider read permission in sharing tab
...
When updating a share we should make sure to use all the old permissions
(and only change what we actually changed). So the READ permission in
this case should also be fetched instead of always granted.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 15:10:51 +02:00
9a69b88393
Merge pull request #26613 from nextcloud/enh/no_add_to_your_nc_file_drop
...
Do not allow adding file drop shares to your own cloud
2021-04-19 14:56:19 +02:00
5370c54084
Bump @nextcloud/dialogs from 3.1.1 to 3.1.2
...
Bumps [@nextcloud/dialogs](https://github.com/nextcloud/nextcloud-dialogs ) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/nextcloud/nextcloud-dialogs/releases )
- [Changelog](https://github.com/nextcloud/nextcloud-dialogs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nextcloud/nextcloud-dialogs/compare/v3.1.1...v3.1.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-04-19 11:37:24 +00:00
422ecdeb20
Fix English source string
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-19 13:11:34 +02:00
2ab8268128
Do not check Oracle column constraints in unrelated migrations
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-19 13:05:34 +02:00
5c42c303e4
Require read permissions for federated shares
...
Else they end up as weird shares that can't be properly utilized by
other parties anyway.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 12:53:49 +02:00
2866f4f7d2
Merge pull request #26614 from nextcloud/crl/noid/update-crl-revoked-news
...
Update root.crl due to revoked news.crt
2021-04-19 12:29:29 +02:00
241dfab33f
Do not allow adding file drop shares to your own cloud
...
There is no reason for this and you can't create such shares normally
anyway.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 12:17:58 +02:00
49dfb8721d
Update root.crl due to revoked news.crt
...
See https://github.com/nextcloud/app-certificate-requests/pull/382
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-04-19 11:56:37 +02:00
dd2f3e36b0
Merge pull request #26605 from nextcloud/dependabot/npm_and_yarn/ssri-6.0.2
...
[Security] Bump ssri from 6.0.1 to 6.0.2
2021-04-19 06:16:08 -01:00
751be29c73
Merge pull request #26555 from nextcloud/techdebt/noid/run-migrator-tests-on-OCI
...
Run migrator tests on OCI
2021-04-19 08:57:41 +02:00
8c82dd37b4
[tx-robot] updated from transifex
2021-04-19 02:26:04 +00:00
2445c82750
l10n: Improve styling
...
"Empty field" information shifted to the end of the sentence. It looks more stylistic.
2021-04-18 11:39:46 +02:00
Joas Schilling
Julius Härtl
Morris Jobke
blizzz
Jan C. Borchardt
Valdnet
Nextcloud bot
Roeland Jago Douma
Roeland Jago Douma
Daniel Calviño Sánchez
Robin Appelman
dependabot[bot]
Christoph Wurst
Joas Schilling