e39db808fb
Fix rendering of the sidebar in Files app
...
When a view is rendered it should not be concerned with where it is
going to be placed in the document; in general this should be a
responsibility of the object using the view.
Moreover, when the details view is rendered it should simply prepare a
skeleton that includes the root elements provided by the plugins; those
elements will be updated by the plugins as needed when a file or a tab
is selected.
Finally, the details view should not be explicitly rendered. The
rendering removes the previous elements, but that is needed only when
the details view is in a dirty state, that is, when new plugins were
added since the last time that it was rendered. However, that dirty
state is internally handled, and the view is automatically rendered
again if needed when a file info is set.
Due to all that the details view is no longer explicitly rendered when
updating it with a different file. Also, as each file list has its own
details view, and each details view has its own element, but there can
be only one details view/sidebar element in the document, when the file
list updates the details view it also replaces the current one in the
document with its own details view if needed (that is, if it is not the
current one already).
Besides that, when the element of a details view is replaced with the
element of a different details view the old one should be detached from
the document, but never removed. Otherwise the event handlers would not
work when that element is attached again later (when changing to a
different section in the Files app and then going back to the previous
one).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-22 05:58:25 +01:00
78056a3bef
Fix whitespace and file action cleanup
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-20 19:46:49 +01:00
fb8aa31dbf
Allow to hide download option for folders shared by link
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-20 19:46:35 +01:00
eb039608f9
Make number of file list entries depending on the width for grid view
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-18 10:44:53 +01:00
8bf7ec26e0
[tx-robot] updated from transifex
2018-11-18 01:12:58 +00:00
9a6d60e95f
Merge pull request #12474 from nextcloud/default-to-files-list
...
Rollback to default list view
2018-11-16 13:48:16 +01:00
def8af3e7e
[tx-robot] updated from transifex
2018-11-16 01:12:14 +00:00
1deda8fd65
Rollback to default list view
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-15 20:29:10 +01:00
790ee0c8a3
Merge pull request #12467 from nextcloud/bugfix/11901/show-thumbnail-on-rename
...
Show thumbnail on rename
2018-11-15 14:09:55 +01:00
c09560627f
Enhance jsunit tests
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-15 13:40:05 +01:00
61f7eecc0b
Show thumbnail on rename
...
* does not hide thumbnail when rename is shown
* fixes layout for grid and list view
* fixes #11901
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-15 12:14:15 +01:00
d70b010432
Merge pull request #12447 from nextcloud/bugfix/12446/fix-oracle-install-again
...
Shorten index name of calendar changes table
2018-11-15 10:47:51 +01:00
10c9b37461
[tx-robot] updated from transifex
2018-11-15 01:12:14 +00:00
c126c3f56a
Update PHPDoc to fix typos
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-14 21:21:41 +01:00
aa88254f64
Shorten index name of calendar changes table
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-14 10:14:23 +01:00
fef51895c2
[tx-robot] updated from transifex
2018-11-14 01:12:12 +00:00
5e84824839
[tx-robot] updated from transifex
2018-11-13 01:12:40 +00:00
48395baa7e
[tx-robot] updated from transifex
2018-11-12 01:12:49 +00:00
55f0c2ac3b
[tx-robot] updated from transifex
2018-11-08 01:12:18 +00:00
c48722c201
Fix file move tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-07 11:14:19 +01:00
c26d847d19
[tx-robot] updated from transifex
2018-11-07 01:12:29 +00:00
e03bc6e4c9
Merge pull request #12303 from nextcloud/grid-for-all-file-templates
...
Add grid toggle for every files view
2018-11-06 17:29:31 +01:00
cac2f7f4d6
Fix tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-06 16:05:34 +01:00
ccd89f366d
Merge pull request #11968 from nextcloud/feature/noid/drop-verbose-appscan
...
Replace $verbose with VERBOSITY_VERBOSE for scanFiles method
2018-11-06 14:41:39 +01:00
98edf3612c
Fix min trhumbnail size
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-06 11:45:19 +01:00
5682d302c7
Add grid toggle for every files view
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-06 11:42:18 +01:00
a88e7d30f3
Merge pull request #11831 from nextcloud/feature/noid/drop-verbose-scan
...
Replace $verbose with VERBOSITY_VERBOSE
2018-11-06 10:21:51 +01:00
54a30a4b81
[tx-robot] updated from transifex
2018-11-06 01:12:39 +00:00
f350f2e3ec
Merge pull request #12128 from tomasz-grobelny/fix_file_move
...
Fix file move operation for large number of files
2018-11-06 00:24:27 +01:00
cd31bea2b7
Merge pull request #12289 from nextcloud/ie11-grid-disable
...
Disable grid for ie
2018-11-05 22:48:24 +01:00
e0de0a122f
Disable grid for ie
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-05 17:27:09 +01:00
a793b1027c
Ask before cancelling an ongoing upload
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-05 10:11:50 +01:00
4be625b128
Merge pull request #12231 from nextcloud/bugfix/10934/setmodel_before_render
...
Set the filemodel before rending the detailsview
2018-11-05 08:07:49 +01:00
c28ea52155
[tx-robot] updated from transifex
2018-11-05 01:12:32 +00:00
1fa6e0be23
Merge remote-tracking branch 'upstream/master' into fix_file_move
...
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-04 09:39:19 +00:00
9d7f02ec47
[tx-robot] updated from transifex
2018-11-04 01:14:02 +00:00
41687ef00f
Fix move related tests
...
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-03 23:01:32 +00:00
b1fd72c1cf
Set the filemodel before rending the detailsview
...
fixes #10934
Else it triggers the rendering two times. Resulting is weird state in
for example the comments. Because the comments for OLD_FILEID are
retrieved but then the model is changed to NEW_FILEID. But the old
comments still get in and get parsed.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-02 22:45:25 +01:00
bfab6ccf1b
Merge pull request #12180 from nextcloud/sidebar-fixes
...
Sidebar fixes, mostly fixing design of tabs
2018-11-01 12:42:03 +01:00
0247a0d6db
Merge pull request #12162 from nextcloud/file-menu-align
...
Align file menu below '+' button, fix #5595
2018-11-01 12:01:05 +01:00
4e12132e43
Fix issues with clipboard button for local link in sidebar
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-11-01 04:11:20 +01:00
9d5982ba4b
[tx-robot] updated from transifex
2018-11-01 01:12:59 +00:00
838105877c
Merge pull request #11647 from nextcloud/make-possible-for-tab-views-to-add-css-classes-to-their-container
...
Make possible for tab views to add CSS classes to their container
2018-10-31 15:37:48 +01:00
1cc05af7a6
Align file menu below '+' button, fix #5595
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-31 11:20:02 +01:00
9c68db5ffb
slightly round off thumbnails in list view too
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-31 00:01:58 +01:00
68a27debd1
Fix file move operation for large number of files
...
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-10-30 15:37:21 +01:00
c0477afb5d
Properly hide files when searching
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-29 14:51:29 +01:00
18fef12721
[tx-robot] updated from transifex
2018-10-29 01:13:07 +00:00
13abee2836
[tx-robot] updated from transifex
2018-10-28 00:12:49 +00:00
0092e3adec
[tx-robot] updated from transifex
2018-10-27 00:12:35 +00:00
Daniel Calviño Sánchez
Julius Härtl
Nextcloud bot
Morris Jobke
John Molakvoæ (skjnldsv)
Joas Schilling
John Molakvoæ
Daniel Kesselberg
Roeland Jago Douma
Tomasz Grobelny
Roeland Jago Douma
Jan-Christoph Borchardt