Commit Graph

24415 Commits

Author SHA1 Message Date
Nextcloud bot 096806087c
[tx-robot] updated from transifex 2021-03-17 02:24:19 +00:00
Morris Jobke 0f2c4ff64c
Use correct exception type hint in catch statement
Found by psalm update 4.6.2 to 4.6.3 in #26111

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-16 22:06:07 +01:00
Robin Appelman 5ffaa94fbc
add (hidden) option to always show smb root as writable
some smb servers are very insistent in reporting that the root of the share is readonly, even if it isn't.

This works around the problem by adding a hidden option to overwrite the permissions of the root of the share.

This can be enabled using

```bash
occ files_external:config <mount id> root_force_writable true
```

where you can find your mount id using

```bash
occ files_external:list
```

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:35:35 +01:00
Vincent Petry c6d2d8746c
Fix CS in CacheTest
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-16 11:43:53 +01:00
Nextcloud bot 72e6201869
[tx-robot] updated from transifex 2021-03-16 02:24:42 +00:00
Vincent Petry e559afb8d4
Merge pull request #25136 from nextcloud/cachejail-search-filter
do cachejail search filtering in sql
2021-03-15 17:45:30 +01:00
John Molakvoæ (skjnldsv) 223fe2aae6
Fix default missing initial state for templates
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-15 17:23:30 +01:00
Vincent Petry 6997344931
Log exceptions when creating share
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.

In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-15 12:00:41 +01:00
Nextcloud bot f82edda9c1
[tx-robot] updated from transifex 2021-03-15 02:23:58 +00:00
Nextcloud bot 44ce623923
[tx-robot] updated from transifex 2021-03-14 02:23:41 +00:00
Nextcloud bot 0869c75d5a
[tx-robot] updated from transifex 2021-03-13 02:22:53 +00:00
Roeland Jago Douma bf39adb49b
Merge pull request #26049 from nextcloud/search-file-limit-results
limit constructing of result objects in file search
2021-03-12 12:58:49 +01:00
blizzz 812bc83b56
Merge pull request #26080 from nextcloud/bugfix/noid/only-clear-known-users-when-we-had-at-least-one-phonebook-entry
Only clear known users when we had at least one phonebook entry
2021-03-12 10:45:36 +01:00
Joas Schilling 5c3551cf2f
Only clear known users when we had at least one phonebook entry
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-12 09:04:13 +01:00
Nextcloud bot cd3ef614be
[tx-robot] updated from transifex 2021-03-12 02:22:44 +00:00
Roeland Jago Douma a1757f83a3
Merge pull request #26067 from nextcloud/techdept/psalm/trashbin/execute
Cleanp execute usage in the trashbin
2021-03-11 21:03:15 +01:00
Roeland Jago Douma 2cbc2710ec
Merge pull request #26066 from nextcloud/techdept/psalm/type_error
Fix type error in CheckBackupCodes bg job
2021-03-11 21:02:35 +01:00
John Molakvoæ c8368af3cb
Merge pull request #26068 from nextcloud/bugfix/noid/fix-comments-value-update
Fix comments field value update
2021-03-11 19:32:25 +01:00
Roeland Jago Douma a3b1c1cea3
Merge pull request #26064 from nextcloud/techdept/psalm/type_oauth_db
Add psalm annotation to the DB handlers of OAuth2
2021-03-11 16:46:08 +01:00
Roeland Jago Douma 8008b33b8d Cleanp execute usage in the trashbin
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-11 15:39:42 +01:00
Vincent Petry a60127acc8
Fix comments field value update
Fixes issue where the comment field value was not properly read out of
the rich content field.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-11 15:39:33 +01:00
Roeland Jago Douma c19708a85e Fix type error in CheckBackupCodes bg job
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-11 15:33:15 +01:00
dependabot-preview[bot] 69c4578b5b
Merge pull request #26057 from nextcloud/dependabot/npm_and_yarn/nextcloud/vue-3.7.2 2021-03-11 14:11:40 +00:00
Robin Appelman 424db15dea
limit constructing of result objects in file search
even thought we currently have no proper way of limiting the search itself, we can at least limit the construction of the result objects.

this saves about 40% of the time spend in the search request in my local testing

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-11 14:49:57 +01:00
Roeland Jago Douma c2f7c417b2 Add psalm annotation to the DB handlers of OAuth2
* Psalm annotations
* To new executeUpdate

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-11 14:33:15 +01:00
Christoph Wurst 95cddb84e2
Merge pull request #25569 from nextcloud/JakubOnderka-patch-1
file-upload: Correctly handle error responses for HTTP2
2021-03-11 13:54:55 +01:00
John Molakvoæ (skjnldsv) 31ddfb0294
Fix SharingInput Multiselect
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-11 12:30:15 +01:00
John Molakvoæ (skjnldsv) 7f06a0cf8e
Compile js
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-11 12:14:48 +01:00
Roeland Jago Douma f90090d2b3
Merge pull request #26019 from ste101/patch-1
Allow webp as background image
2021-03-11 10:52:31 +01:00
Christoph Wurst ba369c134e
Merge pull request #25911 from nextcloud/bugfix/noid/fix-share-password-saving
Only clear share password model when actually saved
2021-03-11 10:48:34 +01:00
Vincent Petry 65bb949376
Merge pull request #26032 from nextcloud/techdept/psalm/requesthandlerController_loggerinterface
Move requesthandler controller to LoggerInterface
2021-03-11 10:37:41 +01:00
Vincent Petry 3462444def
Only clear share password model when actually saved
Instead of always clearing the password in the share model, now only do
it when it was actually saved.

Fixes an issue where saving another field would clear the password too
early and prevent it to be saved when the dropdown closed.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-11 09:07:30 +01:00
Joas Schilling 56b08c04c7
Merge pull request #26031 from nextcloud/feature/noid/allow-autocomplete-based-on-phone-sync
Allow autocomplete based on phone sync
2021-03-11 08:29:21 +01:00
Nextcloud bot 31cc0741cb
[tx-robot] updated from transifex 2021-03-11 02:23:08 +00:00
Joas Schilling 61ed57b757
Rename some parameters and methods to make the API more clear
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 20:30:29 +01:00
Roeland Jago Douma a6447a5c03
Merge pull request #25940 from nextcloud/dependabot/npm_and_yarn/css-loader-5.1.1
Bump css-loader from 5.0.1 to 5.1.1
2021-03-10 19:56:40 +01:00
Joas Schilling 07095fd122
Also clear the knownUser when changing via the settings endpoint
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 19:37:10 +01:00
Joas Schilling 78efabb073
Fix CS hopefully
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:51:28 +01:00
Joas Schilling 5b53b6f977
Add a setting to restrict returning a full match unless in phonebook or same group
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:25:57 +01:00
Joas Schilling 177ae33ba1
Add a hint that the settings are OR based
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:56 +01:00
Joas Schilling 236aa194e2
Restrict autocompletion also based on the phonebook known users
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:55 +01:00
Joas Schilling b71268e38b
Add a config setting to restrict autocompletion to phonebook matches
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:55 +01:00
Joas Schilling c7be18c0d6
Add a service to find out if a user knows another user
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:55 +01:00
dependabot-preview[bot] 613a5760f1 Bump css-loader from 5.0.1 to 5.1.1
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 5.0.1 to 5.1.1.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v5.0.1...v5.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-10 16:47:32 +01:00
Jakub Onderka 296ffc7d34 file-upload: Correctly handle error responses for HTTP2
Signed-off-by: Jakub Onderka <ahoj@jakubonderka.cz>
2021-03-10 16:30:37 +01:00
Robin Appelman 66781e74ad
update icewind/smb to 3.4.0
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-10 15:31:09 +01:00
Joas Schilling 7baefcfc74
Delete matches when the user is being deleted
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 15:05:49 +01:00
Joas Schilling 55a5d26c56
Delete matches when a user changes their phone number
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 15:05:48 +01:00
Joas Schilling f62d9b50fd
Store when a user knows another user based on phone number
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 15:05:48 +01:00
kesselb 62929cc646
Merge pull request #26029 from nextcloud/enh/boostrap/provisioning_api
Provisioning API to IBootstrap
2021-03-10 14:34:02 +01:00
Joas Schilling a1e5090b3f
Fix some psalm warnings
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 13:02:08 +01:00
Roeland Jago Douma d090f970dd
Merge pull request #25537 from nextcloud/dependabot/npm_and_yarn/marked-2.0.0
[Security] Bump marked from 1.2.8 to 2.0.0
2021-03-10 10:37:45 +01:00
Roeland Jago Douma e5b1d59dfd Provisioning API to IBootstrap
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-10 09:39:47 +01:00
Roeland Jago Douma cb232001a8
Merge pull request #26030 from nextcloud/techdept/psalm/scss-deprecations
Fix SCSS compiler deprecated function usages
2021-03-10 09:22:03 +01:00
Julius Härtl 2608dec387
Merge pull request #25916 from nextcloud/bugfix/noid/trashbin-delete-all
Remove trash items from other trash backends when deleting all
2021-03-10 08:57:41 +01:00
Roeland Jago Douma f421fd25ba Move requesthandler controller to LoggerInterface
* LoggerInterface
* executeUpdate
* log exception when there is one (just so we ahve the trace)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-10 08:50:38 +01:00
dependabot-preview[bot] c5783194e6 Bump marked from 1.2.8 to 2.0.0
Bumps [marked](https://github.com/markedjs/marked) from 1.2.8 to 2.0.0.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js)
- [Commits](https://github.com/markedjs/marked/compare/v1.2.8...v2.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-10 08:36:09 +01:00
Nextcloud bot 310e6550b1
[tx-robot] updated from transifex 2021-03-10 02:22:57 +00:00
Roeland Jago Douma 321085d0a7 Fix SCSS compiler deprecated function usages
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-09 20:39:40 +01:00
Christoph Wurst 7f3051e5bf Drop \OCP\Util::isIe
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-09 20:29:42 +01:00
dependabot-preview[bot] 34e8f2f40d Bump handlebars from 4.7.6 to 4.7.7
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.7.6 to 4.7.7.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.7.6...v4.7.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-09 18:53:30 +00:00
Vincent Petry 77401e8c1c
Hide expiration date field for remote shares
Remote shares currently do not support expiration date.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-09 10:40:14 +01:00
ste101 d41e12f2e2
Allow webp as background image 2021-03-09 10:17:06 +01:00
Roeland Jago Douma f5da1ec51d
Merge pull request #25998 from nextcloud/techdept/psalm/personalsettings
Fix some types in the Settings Personal pages
2021-03-09 09:41:18 +01:00
Roeland Jago Douma 05b5715f41
Merge pull request #25970 from nextcloud/dependabot/npm_and_yarn/nextcloud/vue-dashboard-1.1.0
Bump @nextcloud/vue-dashboard from 1.0.1 to 1.1.0
2021-03-09 09:35:21 +01:00
Nextcloud bot 73bf04c2f5
[tx-robot] updated from transifex 2021-03-09 02:23:53 +00:00
Roeland Jago Douma 3e72d29f67
Merge pull request #26012 from nextcloud/dependabot/npm_and_yarn/elliptic-6.5.4
[Security] Bump elliptic from 6.5.3 to 6.5.4
2021-03-08 20:44:04 +01:00
dependabot-preview[bot] 95bddaf36f [Security] Bump elliptic from 6.5.3 to 6.5.4
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. **This update includes a security fix.**
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.3...v6.5.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-08 18:47:16 +00:00
Roeland Jago Douma bf5d5c57a3
Merge pull request #26005 from nextcloud/techdept/psalm/fix_invalid_check
Fix invalid check after constructing DateTime
2021-03-08 19:38:31 +01:00
Lukas Reschke 7ba89c13e7
Merge pull request #25960 from nextcloud/techdept/admin_audit
Pimp admin audit
2021-03-08 16:48:36 +01:00
Roeland Jago Douma 988b9f49c5 Fix invalid check after constructing DateTime
We construct an object. Either that works on not.But the result can't be
false.

Found by psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 16:32:34 +01:00
dependabot-preview[bot] c386e59446 Bump @nextcloud/vue-dashboard from 1.0.1 to 1.1.0
Bumps [@nextcloud/vue-dashboard](https://github.com/nextcloud/nextcloud-vue-dashboard) from 1.0.1 to 1.1.0.
- [Release notes](https://github.com/nextcloud/nextcloud-vue-dashboard/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-vue-dashboard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-vue-dashboard/compare/v1.0.1...v1.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-08 11:54:04 +00:00
Roeland Jago Douma e44be839bb Fix some types in the Settings Personal pages
* Fix types
* Typed the code

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 11:05:41 +01:00
Roeland Jago Douma 109b84b025 Add return type to functions
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 08:56:53 +01:00
Roeland Jago Douma 69b26c73f3 Fix some redundant casts
Happier psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 08:51:08 +01:00
Nextcloud bot e8f087d7d1
[tx-robot] updated from transifex 2021-03-08 02:23:08 +00:00
Nextcloud bot c28542ef7f
[tx-robot] updated from transifex 2021-03-07 02:22:07 +00:00
Roeland Jago Douma e72f92b777
Merge pull request #25959 from nextcloud/techdept/logger/AccessibilityController
AccessibilityController to LoggerInterface
2021-03-06 10:51:34 +01:00
Nextcloud bot 41f9fdab1c
[tx-robot] updated from transifex 2021-03-06 02:22:22 +00:00
Julius Härtl b6e434f02a
Merge pull request #25945 from nextcloud/dependabot/npm_and_yarn/core-js-3.9.1
Bump core-js from 3.8.3 to 3.9.1
2021-03-05 15:21:35 +01:00
Roeland Jago Douma f5dc657e94 Move background job to DI
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-05 14:57:07 +01:00
Roeland Jago Douma 5ec2323f25 Move admin_audit to LoggerInterface
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-05 14:51:55 +01:00
Roeland Jago Douma 900e7f99aa AccessibilityController to LoggerInterface
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-05 14:38:36 +01:00
Roeland Jago Douma c7c5150ddb
Merge pull request #25932 from nextcloud/bugfix/noid/fix-fed-share-add-to-nc
Skip empty obsolete owner when adding to own NC
2021-03-05 14:33:16 +01:00
Joas Schilling f92d21e80e
Merge pull request #25870 from nextcloud/techdept/settings/move_group_activity_events
Move group activities to events
2021-03-05 13:05:06 +01:00
dependabot-preview[bot] 6c8650d414 Bump core-js from 3.8.3 to 3.9.1
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.8.3 to 3.9.1.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.9.1/packages/core-js)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-05 11:34:26 +01:00
Christoph Wurst 11e2286a82
Merge pull request #25588 from nextcloud/techdept/custom-psr-logger
Migrate custom loggers to PSR
2021-03-05 09:46:07 +01:00
Roeland Jago Douma 128b682b7c Fixed error after merge in UsersController
This was moved to the LoggerInterface so the recent merge of #25589
broke master.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-05 09:14:01 +01:00
Roeland Jago Douma 4a9f3ef232
Merge pull request #25589 from nextcloud/provisioning-api-invalid-argument
forward invalid argument message to frontend when creating a user fails
2021-03-05 08:59:50 +01:00
Roeland Jago Douma 54cffefed4
Merge pull request #25660 from hosting-de/feature/add-backend-list-groups
Show group backends in occ group:list --info and group:info
2021-03-05 08:49:43 +01:00
Roeland Jago Douma e6ef096e52
Merge pull request #25659 from nextcloud/smb-getmetadata-catch
catch notfound and forbidden exception in smb::getmetadata
2021-03-05 08:49:23 +01:00
Nextcloud bot a6c9688fd6
[tx-robot] updated from transifex 2021-03-05 02:22:00 +00:00
Robin Appelman b844293536 catch notfound and forbidden exception in smb::getmetadata
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-04 21:34:54 +01:00
Christoph Wurst b0fe408d1f
Merge pull request #25927 from nextcloud/enh/sharebymail/set_expiration_on_creation
Sharebymail: set expiration on creation
2021-03-04 18:17:54 +01:00
Vincent Petry 5be9acab84
Skip empty obsolete owner when adding to own NC
The owner field is nowadays always empty when adding a federated share
using "Add to your Nextcloud", so don't check for it.

Fixes an issue where "Add to your Nextcloud" doesn't add anything.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-04 15:54:21 +01:00
Roeland Jago Douma d247a5fb47 Sharebymail: set expiration on creation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 13:49:21 +01:00
Roeland Jago Douma 997259d1cd Activity: show if files are hidden or not
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 13:14:52 +01:00
Roeland Jago Douma 3bbacb2f54
Merge pull request #25881 from nextcloud/techdept/psalm/sharesplugin
Fix the SharesPlugin
2021-03-04 12:33:20 +01:00
Christoph Wurst cdc9a1efd9
Merge pull request #25912 from nextcloud/techdept/psalm/sharedstorage_some_types
Add some typing to SharedStorage
2021-03-04 12:31:17 +01:00
Roeland Jago Douma 7b9ca4f7c2 Add some typing to SharedStorage
Makes psalm a bit more happy.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 10:49:42 +01:00
Julius Härtl 69c2864aca
Add appconfig to always show the unique label of a sharee
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-04 09:25:45 +01:00
Nextcloud bot 365d31743f
[tx-robot] updated from transifex 2021-03-04 02:22:10 +00:00
Roeland Jago Douma 5325c3002c
Merge pull request #25917 from nextcloud/techdept/kill_deprecated/ocp_api
Remove deprecated \OCP\API
2021-03-03 21:57:34 +01:00
Roeland Jago Douma a58b4ceaab
Merge pull request #25889 from nextcloud/techdept/psalm/fix_group_manager_function_return_type
Fix types in the Group Manager
2021-03-03 20:55:52 +01:00
Roeland Jago Douma cc744740b7 Remove deprecated \OCP\API
Time to remove this forgood now.
Remaining constant moved over
The world is a tiny bit better

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 20:54:32 +01:00
Julius Härtl 895e6a57b9
Merge pull request #25805 from nextcloud/bugfix/23468/clear-share-after-select
Clear multiselect after selection in share panel
2021-03-03 17:25:31 +01:00
Roeland Jago Douma 0829fea5e7
Merge pull request #25896 from nextcloud/techdept/qbmapper
Move DirectMapper to QBMapper
2021-03-03 14:58:51 +01:00
Roeland Jago Douma 68ec18323d Fix types in the Group Manager
Psalm found an issue. However the issue found was because of lying
docblocks. Fixed those and did some typing to make it all better.

For #25839

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 14:52:47 +01:00
Julius Härtl 930b40bd8a
Remove trash items from other trash backends when deleting all
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-03 14:26:35 +01:00
Roeland Jago Douma b87e54bb1c
Merge pull request #25902 from nextcloud/techdept/psalm/loggerinterface/part2
LoggerInterface for provisioning API Controllers
2021-03-03 12:53:15 +01:00
Roeland Jago Douma ee7702e5f0 Move DirectMapper to QBMapper
Mapper has been deprecated for some time now.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 12:35:14 +01:00
Vincent Petry c541094be0 Clear multiselect after selection in share panel
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-03 11:38:00 +01:00
Roeland Jago Douma f492a6aac3 Move group activities to events
Use the fancy events.
Nicer code
Nicely isolated code

win-win

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 11:33:33 +01:00
Roeland Jago Douma ce430c3613
Merge pull request #25892 from nextcloud/techdept/initialstate/part1
Move some settings over to the IInitialState
2021-03-03 11:08:42 +01:00
Roeland Jago Douma a1be5f33af
Merge pull request #25895 from nextcloud/techdept/psalm/pimp_sharingcheckmiddleware
Pimp sharingcheckmiddleware
2021-03-03 10:28:32 +01:00
Roeland Jago Douma ed772cd889
Merge pull request #25818 from nextcloud/dependabot/npm_and_yarn/lodash-4.17.21
Bump lodash from 4.17.20 to 4.17.21
2021-03-03 08:39:21 +01:00
Nextcloud bot e11be3b693
[tx-robot] updated from transifex 2021-03-03 02:21:24 +00:00
Roeland Jago Douma dc7eb2bd85 LoggerInterface for provisioning API Controllers
Sweep swoop swaap swuup
away with the deprecated stuff

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 21:46:51 +01:00
blizzz ef5389603c
Merge pull request #25860 from nextcloud/fix/noid/ldap-bind-expired
do not die after LDAP auth failed with expired acc
2021-03-02 21:34:03 +01:00
Roeland Jago Douma bc961baa40 Move some settings over to the IInitialState
The old one has been deprecated. Part one of many.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 21:11:56 +01:00
dependabot-preview[bot] 7d279f8527 Bump lodash from 4.17.20 to 4.17.21
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.20...4.17.21)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-02 20:51:19 +01:00
Roeland Jago Douma 5c952e83fc Pimp sharingcheckmiddleware
Reported by psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 20:36:04 +01:00
Roeland Jago Douma 04dc321ee7
Merge pull request #25884 from nextcloud/techdept/psalm/no_cast
Remove redundant casts
2021-03-02 18:52:44 +01:00
Roeland Jago Douma 19e2136963 Update autoloader files
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 16:36:21 +01:00
Roeland Jago Douma 4f37e0ce55 Remove redundant casts
For #25839

In short with the connection adapter we now have the function is typed
to int (and casts itself). So it is not needed anymore.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 16:32:13 +01:00
Roeland Jago Douma c40228a65a Fix the SharesPlugin
Another attempt to fix all the typing and handling in the sharesplugin.
In short we should probably have a lot more type hinting in several
places.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 16:29:06 +01:00
Roeland Jago Douma 2afa1c5739
Merge pull request #25862 from nextcloud/techdept/psalm/some_loggers
Move away some ILoggers
2021-03-02 15:01:44 +01:00
Robin Appelman a2ecac7197
Merge pull request #25568 from nextcloud/move-storage-disable-cache
disable trasbin during the moveFromStorage fallback
2021-03-02 13:23:58 +00:00
Julius Härtl cfa2d22f4e
Merge pull request #25797 from nextcloud/bugfix/noid/templates-fileactions
Do not trigger a full filelist reload after creating a new file from a template
2021-03-02 14:15:19 +01:00
Lukas Reschke 41dc18342f
Merge pull request #25854 from nextcloud/techdept/psalm/checksetupcontroller
Fix lying docblocks
2021-03-02 13:33:21 +01:00
Roeland Jago Douma 38f761f25f Move away some ILoggers
Makes psalm happier

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 10:47:25 +01:00
Julius Härtl 1d5ee0324e
Bump bundles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-02 10:46:48 +01:00
Julius Härtl 14c872a96a
At least try to give the full context for the file action
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-02 10:46:48 +01:00
Julius Härtl f3a8b0ac88
Do not trigger a full filelist reload after creating a new file
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-02 10:46:48 +01:00
Julius Härtl 20094af7f9
Merge pull request #25670 from nextcloud/enh/psalm/redundantcasts
Fix a few RedundantCast
2021-03-02 10:46:00 +01:00
dependabot-preview[bot] e4cc176e00
Merge pull request #25821 from nextcloud/dependabot/npm_and_yarn/babel/core-7.13.8 2021-03-02 08:13:02 +00:00
Christoph Wurst 7be2ce82e7
Merge pull request #25544 from nextcloud/refactor/app-password-created-event
Move app_password_created to a typed event
2021-03-02 08:18:59 +01:00
Nextcloud bot 63f68e0412
[tx-robot] updated from transifex 2021-03-02 02:22:18 +00:00
dependabot-preview[bot] b486e26b81 Bump @babel/core from 7.12.16 to 7.13.8
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.12.16 to 7.13.8.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.13.8/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-01 21:30:34 +00:00
Arthur Schiwon 5ad08c7c84
do not die after LDAP auth failed with expired acc
- some servers return error code 53

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-01 19:20:05 +01:00
Roeland Jago Douma e28173863e Card::getOwner should return the actual value
I guess we never call this at runtime or it would already ahve done boom
very loudly.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 16:51:36 +01:00
Roeland Jago Douma 3d0dff0d2b Fix lying docblocks
* typed the return
* removed unneeded temp variable

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 16:48:04 +01:00
Johannes Leuker 2796ef80ff Show group backends in occ group:list --info and group:info
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-01 16:02:08 +01:00
Roeland Jago Douma 5cd1880daa Fix a few RedundantCast
Reported by psalm
For #25641

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 16:00:32 +01:00
blizzz 9cd39b0b8c
Merge pull request #25757 from nextcloud/fix/noid/ldap-cyclic-group-memberships
fix detecting cyclic group memberships
2021-03-01 12:07:59 +01:00
John Molakvoæ cc7f4ab1ea
Merge pull request #25803 from nextcloud/bugfix/25364/make-compatible-app-message-less-confusing
Make the compatible app message less confusing for multi versions apps
2021-03-01 10:37:13 +01:00
Nextcloud bot 9a90bfba32
[tx-robot] updated from transifex 2021-03-01 02:20:19 +00:00
Nextcloud bot 24d5afb1b1
[tx-robot] updated from transifex 2021-02-28 02:19:54 +00:00
Nextcloud bot 65b0511d79
[tx-robot] updated from transifex 2021-02-27 02:22:23 +00:00
Joas Schilling 4807ce3b08 Make the compatible app message less confusing for multi versions apps
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-26 10:56:35 +00:00
Vincent Petry 53b162bad9
Fix focus-visible outline for files checkboxes
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-02-26 10:15:21 +01:00
Nextcloud bot b4ccadea2b
[tx-robot] updated from transifex 2021-02-26 02:21:45 +00:00
kesselb c663cbe666
Merge pull request #25778 from noiob/patch-1
Remove double space in sharebymail SettingsManager
2021-02-25 19:31:34 +01:00
Nextcloud bot c8f7a808fd
[tx-robot] updated from transifex 2021-02-25 02:21:21 +00:00
noiob f28ee36e20 Remove double space so php-cs stops complaining
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-02-24 11:33:19 +01:00
Nextcloud bot b89fbaf52d
[tx-robot] updated from transifex 2021-02-24 02:22:06 +00:00
Arthur Schiwon 4d33449faa
fix detecting cyclic group memberships
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-23 22:50:43 +01:00
Nextcloud bot ff54a0481b
[tx-robot] updated from transifex 2021-02-23 02:39:25 +00:00
John Molakvoæ 1eca8d21ee
Merge pull request #25602 from nextcloud/bugfix/noid/only-create-share-once
Avoid creating two share links when password is enforced
2021-02-22 12:08:49 +01:00
Vincent Petry f321538c9b
Merge pull request #25689 from nextcloud/bugfix/noid/disable-updater-ui-when-disabled
Hide update channel + button when web update is disabled
2021-02-22 09:29:56 +01:00
Nextcloud bot 3ff92423e2
[tx-robot] updated from transifex 2021-02-21 02:39:59 +00:00
Nextcloud bot ac2577a594
[tx-robot] updated from transifex 2021-02-20 02:37:22 +00:00
Julius Härtl 9073c09c62 Avoid creating two share links when password is enforced
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-19 11:16:38 +00:00
John Molakvoæ 946430862e
Merge pull request #24978 from dems54/issue24139 2021-02-19 08:20:58 +01:00
Nextcloud bot c222bac9ed
[tx-robot] updated from transifex 2021-02-19 02:20:56 +00:00
dependabot-preview[bot] eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +01:00
Vincent Petry 6ce469132c
Hide updater button when web updater is disabled
Whenever the web updater is disabled, the updater button and its
matching token requesting endpoints are disabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-02-18 08:53:57 +01:00
Nextcloud bot 5f194dad24
[tx-robot] updated from transifex 2021-02-18 02:21:54 +00:00
Roeland Jago Douma 00d1a58a09
Merge pull request #25681 from nextcloud/techdebt/noid/cleanup-provisioning
Cleanup appinfo usage
2021-02-17 21:16:09 +01:00
Robin Appelman b5db4502d0
disable trasbin during the moveFromStorage fallback
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-17 16:08:57 +01:00
Roeland Jago Douma ff1c5c4e25 Move getChangesForAddressBook to QueryBuilder
Makes psalm happy, and makes me happy.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-17 09:06:00 +01:00
Roeland Jago Douma 644e6df02e
Merge pull request #25440 from nextcloud/bugfix/noid/cache-the-user-backend-info-for-30s
Cache the user backend info for 5mins
2021-02-17 08:56:55 +01:00
Nextcloud bot 57212a99f9
[tx-robot] updated from transifex 2021-02-17 02:21:05 +00:00
Joas Schilling 89d2eaca0a
Cleanup appinfo usage
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-16 15:51:25 +01:00
Samuel 2dac72ddea Merge remote-tracking branch 'upstream/master' into feat-federatedfilesharing-logging 2021-02-16 14:33:22 +01:00
Roeland Jago Douma 2ea3cb7c93 Drop redundant indes
Those indexes are already covered by others. So those can just be used.
THose extra indexes just take up space.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-16 11:38:43 +01:00
Christoph Wurst a649dff179
Merge pull request #25669 from nextcloud/fix/psalm/encryptall
Harden EncryptAll check for empty email
2021-02-16 08:16:19 +01:00
Nextcloud bot 45d36ec2b2
[tx-robot] updated from transifex 2021-02-16 02:21:36 +00:00
Roeland Jago Douma 918af40f05 Harden EncryptAll check for empty email
Reported by psalm
For #25641

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 22:28:28 +01:00
Roeland Jago Douma df4c2508d6 Fix some RedundantCast in dav code
For #25641

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 20:50:28 +01:00
Roeland Jago Douma a61c3705f8
Merge pull request #25655 from nextcloud/bugfix/noid/dark-mode-applist-icons
Fix app icon list in dark mode
2021-02-15 20:34:56 +01:00
kesselb a33803a31b
Merge pull request #25653 from nextcloud/fix/psalm/offlineuser
Some psalm OfflineUser fixes
2021-02-15 17:04:16 +01:00
Roeland Jago Douma 9fd72b0d3a
Merge pull request #25595 from nextcloud/enh/caldavbackend/getChangesForCalendar_querybuilder
Move getChangesForCalendar to QueryBuilder
2021-02-15 16:39:46 +01:00
Joas Schilling f83de9d194
Fix app icon list in dark mode
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-15 16:26:30 +01:00
Roeland Jago Douma 3f4ece256e Some psalm OfflineUser fixes
For #25641

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 13:36:02 +01:00
Roeland Jago Douma 9929adde08
Merge pull request #25594 from wankdanker/files_sharing_owner_display_name
Use ownerDisplayName for SharingEntry Tooltip
2021-02-15 13:17:25 +01:00
Christoph Wurst 797527e5ea
Merge pull request #25578 from nextcloud/enh/simplify_weatherservice
Always use the cache
2021-02-15 12:27:03 +01:00
Christoph Wurst 5faa34abb1
Merge pull request #25625 from nextcloud/enh/psalm/substr
Check substr results
2021-02-15 12:17:57 +01:00
Roeland Jago Douma b0f205f97c Move getChangesForCalendar to QueryBuilder
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 12:07:26 +01:00
Christoph Wurst 65465b5abc
Merge pull request #25636 from nextcloud/fix/psalm/closure_return_types
Add some closure return types
2021-02-15 12:07:24 +01:00
Joas Schilling 645f83121e
Cache the user backend info for 300s
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-15 10:36:08 +01:00
Roeland Jago Douma 507d5cf8ad Check substr results
Else this might lead to unexpeted errors.
Found by psalm.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 10:07:13 +01:00
Roeland Jago Douma bd8b1786c5 Some psalm fixes in the settings app
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 10:00:35 +01:00
Roeland Jago Douma 84de7a8d63
Merge pull request #25580 from nextcloud/enh/fix/psalm_pluginmanager
Enhancing the dav pluginmanager
2021-02-15 09:11:16 +01:00
Nextcloud bot b418a680e7
[tx-robot] updated from transifex 2021-02-15 02:20:11 +00:00
Roeland Jago Douma d2569eed58 Fix PluginManager annotation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-14 12:46:50 +01:00
Roeland Jago Douma e62790cfe2 Add some closure return types
Found by psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-14 12:43:31 +01:00
Roeland Jago Douma 19f7476f77 Use correct namespace (casing) in CalendarHome
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-14 12:36:41 +01:00
Nextcloud bot 65cd62e875
[tx-robot] updated from transifex 2021-02-14 02:20:02 +00:00
Roeland Jago Douma 7d8e9baa77
Revert "use the configured forwarded headers for the setup check" 2021-02-13 18:03:32 +01:00