Commit Graph

23605 Commits

Author SHA1 Message Date
Joas Schilling 8027dcbc6f
Don't leave cursors open when tests fail
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-09 12:28:17 +01:00
Morris Jobke 46002a46a6
Merge pull request #23933 from nextcloud/bugfix/noid/user-ldap-ocdb
Use query builder instead of OC_DB in user_ldap
2020-11-09 10:07:25 +01:00
Morris Jobke c7ff0c71b4
Shortcut to avoid file system setup when generating the logo URL
If an SVG is requested and the app config value for logoMime is set then the logo is there. Otherwise we need to check it and maybe also generate a PNG from the SVG (that's done in getImage() which needs to be called then).

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-09 10:01:34 +01:00
John Molakvoæ 05d3326664
Merge pull request #23574 from nextcloud/fix/23569
Fix link share label placeholder not showing
2020-11-09 09:14:21 +01:00
Joas Schilling 3f370f3732
Test requires the DB
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-09 08:40:00 +01:00
Nextcloud bot f5be2c722a
[tx-robot] updated from transifex 2020-11-09 02:18:51 +00:00
Nextcloud bot 2b2af705f7
[tx-robot] updated from transifex 2020-11-08 02:18:22 +00:00
Gary Kim 25d260838b
Fix link share label placeholder not showing
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-11-07 20:27:29 -05:00
Richard Steinmetz f1c242c71d
Use png icons in caldav reminder emails
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2020-11-07 14:09:22 +01:00
dependabot-preview[bot] e063824f17 Bump node-sass from 4.14.1 to 5.0.0
Bumps [node-sass](https://github.com/sass/node-sass) from 4.14.1 to 5.0.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.14.1...v5.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-07 11:25:57 +00:00
John Molakvoæ e90e499c8b
Merge pull request #23936 from nextcloud/bugfix/noid/trashbin-ocdb
Use query builder instead of OC_DB in trashbin
2020-11-07 10:19:23 +01:00
Nextcloud bot 1d203b0fb9
[tx-robot] updated from transifex 2020-11-07 02:18:58 +00:00
Morris Jobke 1a30e4d28f
Merge pull request #23821 from nextcloud/td/enh/no_fs_setup_by_default
Do not setup the default FS on normal routes
2020-11-06 23:03:09 +01:00
Joas Schilling e52925c5fb
Use query builder instead of OC_DB in trashbin
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 22:33:59 +01:00
Arthur Schiwon c96a9a9001
fix insert values
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-06 13:30:19 +01:00
Arthur Schiwon 4104416e81
only delete specified config
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-06 13:01:37 +01:00
Joas Schilling 8547934e20
Correctly place the array type 2020-11-06 12:09:58 +01:00
Joas Schilling c5b6e4bc09
Use query builder to interact with member management
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 11:28:53 +01:00
Joas Schilling 5fba0e562f
Use query builder instead of OC_DB in user_ldap
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 11:25:28 +01:00
Roeland Jago Douma 448044d831
Fix getstorage call
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-06 09:03:32 +01:00
Roeland Jago Douma 48d843858d
Do not setup the default FS on normal routes
This should help with load times hopefully. Only initialize the FS if we
actually ned it.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-06 09:03:32 +01:00
dependabot-preview[bot] bc5b58cb29
Bump css-loader from 3.6.0 to 5.0.1
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.6.0 to 5.0.1.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.6.0...v5.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-06 09:00:20 +01:00
John Molakvoæ 404785dd2b
Merge pull request #23347 from st3iny/enhancement/19526/new-share-pending-confirm-button 2020-11-06 08:04:07 +01:00
Nextcloud bot c8d3f03bde
[tx-robot] updated from transifex 2020-11-06 02:19:11 +00:00
Morris Jobke f657f0c455
Merge pull request #23906 from nextcloud/techdebt/noid/simplify-can-change-user-pasword
Simplify the check if admin can change password based on encryption status
2020-11-05 23:39:13 +01:00
Morris Jobke a223f603f9
Simplify the check if admin can change password based on encryption status
Found by Psalm:
```
/home/runner/work/server/server/apps/settings/lib/Controller/UsersController.php:324:8:error - RedundantCondition: Type true for $isEncryptionModuleLoaded is never falsy
```

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-05 22:20:34 +01:00
Julius Härtl 88eebf9ed6
Merge pull request #23004 from nextcloud/files-scan-background
only run the background scanner for users that have unscanned files
2020-11-05 22:15:01 +01:00
Vincent Petry 5474c299d9
Make link share avatar icon blue again
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-11-05 17:14:29 +01:00
Vincent Petry 88d019e696
Fix link share avatar icon
Use "icon-class" instead of "class" as this is how to tell the component
that we don't want initials displayed.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-11-05 16:43:48 +01:00
Richard Steinmetz a46c329734
Add confirm button in new link share pending expire/password menu
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2020-11-05 15:55:39 +01:00
Christoph Wurst d31ff68f17
Remove old hide modules option for webpack
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-05 09:58:37 +01:00
Nextcloud bot 6d4d7faf8b
[tx-robot] updated from transifex 2020-11-05 02:18:49 +00:00
Morris Jobke c3969d9493
Merge pull request #23792 from nextcloud/techdebt/noid/group-unread-comment-count-query
Add a function to get the unread count for multiple objects in one go
2020-11-04 21:45:44 +01:00
Roeland Jago Douma 8bd39fccf4
Have the CommentsPropertiesPlugin use the new fancy method
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-04 16:37:42 +01:00
Christoph Wurst 8f14403a9c
Merge pull request #23897 from nextcloud/bugfix/23236
Move help to separate stylesheet
2020-11-04 15:32:21 +01:00
Julius Härtl f1c416da24
Make user status styles scoped
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-04 13:33:47 +01:00
Julius Härtl 8cf7c63a71
Move help to separate stylesheet
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-04 13:17:16 +01:00
Morris Jobke dd93532526
Cleanup ImageManager::getImage()
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-04 10:08:36 +01:00
Nextcloud bot ea0b66fe70
[tx-robot] updated from transifex 2020-11-04 02:19:00 +00:00
Morris Jobke 8d02ee9ac7
Merge pull request #21693 from nextcloud/fix/noid/import-certificates-only-by-system
Improve CertificateManager to not be user context dependent
2020-11-03 21:48:37 +01:00
Roeland Jago Douma 7a0ac37c94
Merge pull request #23866 from nextcloud/fix/noid/fix-grid-view-in-systemtags-view
Fix grid view toggle in tags view
2020-11-03 19:43:13 +01:00
marco 5c93321354
Merge pull request #23798 from nextcloud/add/default_font_size
Add default font size
2020-11-03 18:25:27 +01:00
Morris Jobke 403d54607e
Fix grid view in tags view
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 14:35:10 +01:00
GretaD bfe87e501d Add default font size
Signed-off-by: GretaD <gretadoci@gmail.com>
2020-11-03 13:58:04 +01:00
Julius Härtl e9af7b84f9
Merge pull request #23737 from nextcloud/fix-gif-login-image
Fix GIF being converted when used as a login image
2020-11-03 10:31:42 +01:00
Morris Jobke 1c05c9f4f2
Merge pull request #23842 from nextcloud/bugfix/noid/emptystatusmessage
UserStatus: clear status message if message is null
2020-11-03 10:28:33 +01:00
Morris Jobke 9435ec2b4e
Remove unneeded service - found by Psalm
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 10:06:33 +01:00
Morris Jobke 1c496a5a35
Add a background job that checks for potential user imported SSL certificates and shows a warning in the admin settings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 10:06:33 +01:00
Nextcloud bot a6719390e2
[tx-robot] updated from transifex 2020-11-03 02:19:16 +00:00
Morris Jobke dc479aae2d
Improve CertificateManager to not be user context dependent
* removes the ability for users to import their own certificates (for external storage)
* reliably returns the same certificate bundles system wide (and not depending on the user context and available sessions)

The user specific certificates were broken in some cases anyways, as they are only loaded if the specific user is logged in and thus causing unexpected behavior for background jobs and other non-user triggered code paths.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 00:13:01 +01:00
Jacob Neplokh ef8822d3c7
Add gif to if-statement to not convert
- SVGs are already there, so I just added it alongside it (as recommended by https://github.com/nextcloud/server/issues/16232#issuecomment-679920284)

Signed-off-by: Jacob Neplokh <me@jacobneplokh.com>
2020-11-02 13:52:49 -08:00
blizzz 1a3daa6ff9
Merge pull request #23799 from nextcloud/fix/noid/ldap-update-groups-null
LDAP: fix null where IUser is expected in update groups background job
2020-11-02 18:14:01 +01:00
Simon Spannagel ad58d13814 UserStatus: no message means clear status message. This fixes #23332
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2020-11-02 17:59:44 +01:00
nhirokinet 830348dbee
Add SVG support check to setup check
Signed-off-by: nhirokinet <nhirokinet@nhiroki.net>
2020-11-02 11:29:08 +01:00
Nextcloud bot 3f94c014f0
[tx-robot] updated from transifex 2020-11-02 02:19:04 +00:00
Nextcloud bot b1620344f3
[tx-robot] updated from transifex 2020-11-01 02:18:23 +00:00
Roeland Jago Douma e70461281f
Merge pull request #23811 from nextcloud/dependabot/npm_and_yarn/vue-loader-15.9.4
Bump vue-loader from 15.9.3 to 15.9.4
2020-10-31 14:57:07 +01:00
dependabot-preview[bot] 1bcc1822bc Bump vue-loader from 15.9.3 to 15.9.4
Bumps [vue-loader](https://github.com/vuejs/vue-loader) from 15.9.3 to 15.9.4.
- [Release notes](https://github.com/vuejs/vue-loader/releases)
- [Changelog](https://github.com/vuejs/vue-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-loader/compare/v15.9.3...v15.9.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-10-31 08:04:02 +00:00
Nextcloud bot ffda62b421
[tx-robot] updated from transifex 2020-10-31 02:18:47 +00:00
Arthur Schiwon 3a51160221
fix potentially passing null to events where IUser is expected
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-30 16:30:01 +01:00
Arthur Schiwon fd44087530
adds unit test for updategroups background job
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-30 16:30:00 +01:00
Morris Jobke 1654826e83
Merge pull request #23742 from nextcloud/enhancement/eventdispatcher-typed-listener-callable
Type the event dispatcher listener callables with Psalm
2020-10-30 09:54:48 +01:00
Nextcloud bot 11fca45e4c
[tx-robot] updated from transifex 2020-10-30 02:19:09 +00:00
Roeland Jago Douma 22f04a7cc3
Fix invalid usages of the new dispatcher
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-29 20:15:04 +01:00
Roeland Jago Douma 9b15b66ec9
Merge pull request #23778 from nextcloud/doc/22649/document-settings-before-template-event
Document settings BeforeTemplateRenderedEvent
2020-10-29 19:27:54 +01:00
leith abdulla 8c1f17383b resolve review comments
update styling for conditionals and simplifying conditional by only
relying on dtstart instead of also counting vevents (since they imply
the same condition, assuming valid events)

Signed-off-by: leith abdulla <online-nextcloud@eleith.com>
2020-10-29 07:31:56 -07:00
Christoph Wurst ecdfe961f8
Merge pull request #23775 from nextcloud/doc/22221/document-ldap-backend-events
Document the backend registered events of LDAP
2020-10-29 14:05:51 +01:00
Morris Jobke e2e7c2d014
Document settings BeforeTemplateRenderedEvent
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-29 11:15:31 +01:00
Morris Jobke 28e2551313
Merge pull request #23671 from nextcloud/Valdnet-patch-4
l10n: Name with a capital letter: SharingInput.vue
2020-10-29 11:14:22 +01:00
Morris Jobke 0053ec82ac
Document the backend registered events of LDAP
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-29 09:18:46 +01:00
Morris Jobke 5fab33ddc5
Merge pull request #23770 from nextcloud/techdebt/noid/remove-deprecated-isection
Remove ISection in favor of IIconSection
2020-10-29 09:00:57 +01:00
npmbuildbot-nextcloud[bot] 26a0fec69a Compile assets
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-10-29 07:55:53 +00:00
leith abdulla a40a307b65 handle vcalander documents with recurrence with exemptions or edits
when importing ics files from third party services (ex: google), long
running recurrence vcalander objects can contain numerous vevents
relating to past exemptions or edits.

these objects are handled incorrectly, leading to incorrect first and/or
last occurence dates from being inferred. as a result, a number of
imported events are not rendered in the calendar.

this PR makes use of EventIterator's constructor that takes in an array
of VEVENTS to properly handle these complex cases.

Also of note is that other parameter signatures of EventIterator's constructor,
will be deprecated, according to comments in sabre dav EventIterator.php

Signed-off-by: leith abdulla <online-nextcloud@eleith.com>
2020-10-28 21:07:00 -07:00
Nextcloud bot f576374fe6
[tx-robot] updated from transifex 2020-10-29 02:19:13 +00:00
Morris Jobke b8ed997238
Remove ISection in favor of IIconSection
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-28 23:05:00 +01:00
Valdnet bb38fd8fd5
l10n: Name with a capital letter: SharingInput.vue 2020-10-28 21:14:11 +01:00
blizzz 6b2cf46125
Merge pull request #23752 from nextcloud/fix/noid/wfe-ux-errors
inform the user when flow config data exceeds thresholds
2020-10-28 16:05:35 +01:00
Roeland Jago Douma 4ade7f12f2
Merge pull request #23750 from nextcloud/fix/sabre/authinitevent
Don't overwrite the event if we use it later
2020-10-28 14:39:03 +01:00
Arthur Schiwon 1eb86e46fd
inform the user when flow config data exceeds thresholds
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-28 14:07:14 +01:00
Roeland Jago Douma c5e0ef1972
Don't overwrite the event if we use it later
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-28 13:24:17 +01:00
npmbuildbot[bot] 34100f1775
Compile assets
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-28 10:28:19 +01:00
John Molakvoæ (skjnldsv) 72aeb8ef05
Add mentions data
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-28 10:26:08 +01:00
John Molakvoæ (skjnldsv) a57473f820
Hide long messages
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-28 10:26:08 +01:00
John Molakvoæ (skjnldsv) cf43b70db6
Fix white-space display
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-28 10:26:08 +01:00
John Molakvoæ (skjnldsv) a20f598049
Prevent submitting empty messages
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-28 10:26:08 +01:00
Morris Jobke 510b653330
Merge pull request #23723 from nextcloud/fix/dav_server_auth_init
Also run the SabreAuthInitEvent for the main server
2020-10-28 09:08:03 +01:00
Nextcloud bot e4288529fa
[tx-robot] updated from transifex 2020-10-28 02:18:52 +00:00
dependabot-preview[bot] faefbe1346 Bump dompurify from 2.1.1 to 2.2.0
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.1.1 to 2.2.0.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](https://github.com/cure53/DOMPurify/compare/2.1.1...2.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-10-27 20:39:03 +00:00
Roeland Jago Douma 28d82394f1
Merge pull request #23720 from nextcloud/lowercase-email
save email as lower case
2020-10-27 20:14:43 +01:00
Roeland Jago Douma 49854f58d3
Merge pull request #23725 from nextcloud/enh/noid/specify-accept-argument-for-avatar-upload
Specify accept argument to avatar upload input field
2020-10-27 19:54:14 +01:00
Roeland Jago Douma 157c5abbc4
Merge pull request #23721 from nextcloud/reset-avatar-cropper
reset avatar cropper before showing
2020-10-27 19:52:10 +01:00
Morris Jobke f6448779ad
Specify accept argument to avatar upload input field
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-27 15:51:37 +01:00
Roeland Jago Douma 46ce7277c7
Also run the SabreAuthInitEvent for the main server
else for example trusted servers breaks

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-27 15:23:27 +01:00
Robin Appelman 76be867898
reset avatar cropper before showing
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-27 15:00:50 +01:00
Robin Appelman cbd6e65678
save email as lower case
email addresses are case insensitive

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-27 14:56:52 +01:00
Vincent Petry 66ce56e424
Fix default quota display value in user row
When selecting default quota in the dropdown, the actual numeric value
or "Unlimited" will be displayed instead of "0 B". This matches whatever
is displayed after refreshing the page.

In the case where the default quota is unlimited, for which the server
returns -3 instead of "none", the frontend now also shows "Unlimited"
instead of "0 B".

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-10-27 13:00:43 +01:00
Roeland Jago Douma 25f347a49a
Merge pull request #23645 from nextcloud/fix/fe/s3/isset_first
Check if array elements exist before using them
2020-10-27 11:55:37 +01:00
dependabot-preview[bot] 4419d3e4de
Merge pull request #23662 from nextcloud/dependabot/npm_and_yarn/nextcloud/vue-3.1.0 2020-10-27 09:10:37 +00:00
blizzz 41fe4dc043
Merge pull request #23700 from nextcloud/fix/noid/remnants-sharee-display
Use ShareManager to determine shares of unlocatable LDAP users and fix an issue in a condition
2020-10-27 09:39:34 +01:00
dependabot-preview[bot] 3b72136f9d Bump @nextcloud/vue from 3.0.0 to 3.1.0
Bumps [@nextcloud/vue](https://github.com/nextcloud/nextcloud-vue) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/nextcloud/nextcloud-vue/releases)
- [Commits](https://github.com/nextcloud/nextcloud-vue/compare/v3.0.0...v3.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-27 08:08:28 +00:00