be56374c51
Fix sorting of favorite files
...
The sort comparator checks the "isFavorite" property of the FileInfo
objects to compare. That property is set when the file list is loaded
and the response from the server is parsed, and thus a freshly loaded
file list has the proper sorting for favorite files. However, the
property is not set in other cases, like when the FileInfo objects are
derived from FileInfoModels due to a file being marked as a favorite or
a text editor being closed, which causes the file to be sorted in the
wrong position.
There is no need to add the property in those situations, though; in all
cases the TagsPlugin adds a "tags" array property that contains an
OC.TAG_FAVORITE tag, so that tag can be checked instead of "isFavorite".
Moreover, although "isFavorite" was added by the main "_parseFileInfo"
function it did not really belong there but to the "FileInfoParser" from
the TagsPlugin; however, as that property now is not used anywhere it
was removed altogether.
A cleaner solution would have been to make the sort comparator
extensible by plugins like other behaviours of the file list and then
add the sorting logic related to favorite files to the TagsPlugin.
However, right now only the TagsPlugin would need to alter the main
sorting logic, and it seems like a corner case anyway. Even if it is
implemented as a plugin, favorite files is a core feature, so for the
time being it will be taken into account directly in the main sorting
logic; making the sort comparator extensible by plugins is defered until
there are other use cases for that.
Fixes #5410
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-07-05 15:01:23 +02:00
8ccc2e2758
Merge pull request #5396 from nextcloud/gpx-mimetype
...
add gpx mimetype
2017-06-15 13:23:32 +02:00
fc47d0bbaa
Merge pull request #5244 from nextcloud/dynamic-percentual-appmenu-limit
...
Now using dynamic percentual appmenu limit
2017-06-14 11:36:04 -05:00
0f92a2c6fd
bycatch, x-ldif entry was missing
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-06-14 11:47:44 +02:00
4d692b6966
add location filetype icon
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-06-14 11:46:00 +02:00
cec2893d3b
Show at least 8 icons, don't use percentage on mobile
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2017-06-14 11:14:04 +02:00
64d39aad25
Localize contacts menu search input placeholder
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2017-06-14 10:29:36 +02:00
376fe0e246
Fix escaping of user and group names in "shared by" message
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-06-13 12:14:21 +02:00
69b6504285
Merge pull request #5167 from nextcloud/rakekniven-patch-2
...
l10n improvements from transifex
2017-06-12 16:18:54 -05:00
6b3b341775
Merge pull request #5315 from nextcloud/global-eval
...
execute eval in global scope, addresses #5314
2017-06-12 15:52:55 -05:00
8ecdeaa716
Remove the char because it breaks the export from transifex
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-06-12 16:30:08 +02:00
c0c5df31c0
Decimal percentage, dynamic appIcon width
...
Signed-off-by: Patrik Kernstock <info@pkern.at>
2017-06-10 17:33:01 +02:00
944738c71d
execute eval in global scope, addresses #5314
...
unsure whether this is properly supported everywhere, injection is not an
option for us
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-06-09 13:43:09 +02:00
c88e4e2feb
Now using dynamic percentual appmenu limit
...
Signed-off-by: Patrik Kernstock <info@pkern.at>
2017-06-04 03:26:40 +02:00
f2d999aa70
Update setupchecks.js
...
Fixed typo and removed doclink symbol.
Reported at transifex
Update util.php
Another l10n improvement from transifex.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-31 13:41:45 +02:00
65d52a1ddf
Closed #5121 , remove appmenu limit
...
Signed-off-by: Patrik Kernstock <info@pkern.at>
2017-05-26 19:39:22 +02:00
1fedf450ac
Update Opcache recommendation
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-21 18:21:28 -05:00
e9ab452ff3
rename secure drop back to files drop because of name collision with securedrop.org
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-05-18 16:55:58 +02:00
0828df5ed4
Disable the API endpoints as well
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-05-11 17:03:57 +02:00
34d97aa51c
Request proper size for contacts menu
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-05-08 11:20:49 +02:00
e4aac15a92
Update login flow redirection
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-05-04 19:21:22 +02:00
2216e5dcd0
Fix event firing
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-05-04 09:22:28 +02:00
6f2cc42885
Add radio class to read/write sharing options and 1px left adjustment
...
Signed-off-by: Felix A. Epp <work@felixepp.de>
2017-05-04 01:34:29 +02:00
758576f608
Fix read-only label id
...
Signed-off-by: Felix A. Epp <work@felixepp.de>
2017-05-04 01:33:03 +02:00
2e32ab945b
Make files drop more permanent
...
Implement the suggestions from #2207
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-05-04 00:30:51 +02:00
6d9cb62f79
Merge pull request #4611 from nextcloud/js-use-dot-notation
...
Use dot notation for array access - JSLint recommendation
2017-05-02 21:44:44 +02:00
94c2f12226
Merge pull request #4638 from nextcloud/fix-copy-tooltip
...
Fix "Copied" message for public links
2017-05-02 10:10:23 +02:00
2ce71f8c24
Fix "Copied" message for public links
...
* share a file/fodler by public link and click the
copy to clipboard icon and watch the tooltip
* before: it said "Copy"
* after: it now says "Copied" after clicking the button
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-01 17:58:12 -03:00
8cb3115acf
Merge pull request #4615 from nextcloud/js-reduce-share.js-complexity
...
Remove abandoned methods in OC.Share that refer to old API endpoints
2017-05-01 20:44:19 +02:00
4904117ba8
Merge pull request #4612 from nextcloud/js-fix-long-lines
...
Fix some long lines in JS - JSLinut recommendation
2017-05-01 19:55:56 +02:00
92b73db053
Merge pull request #4613 from nextcloud/remove-unused
...
Remove unused JS file
2017-05-01 19:42:12 +02:00
a2f6fea408
Merge pull request #4610 from nextcloud/js-semicolons
...
Fix semicolon at end of JS lines
2017-05-01 16:55:35 +02:00
99f98ca343
Merge pull request #4614 from nextcloud/js-fix-dialogs-and-octemplate
...
Fix variable definitions in oc dialogs
2017-05-01 16:54:53 +02:00
23858504eb
Fix variable definition in sharedialogview.js
...
* improves readability of conditional statements
and fixes warning in JSLint for varibale definition
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-01 01:32:54 -03:00
4cd8b3379b
Remove unused methods from OC.Share
...
* they do calls against core/ajax/share.php which doesn't exist anymore
* also the methods are not called in any of our apps or any of the apps in the appstore
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-01 01:29:00 -03:00
d222351c87
Fix variable definitions in oc dialogs
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-01 01:09:29 -03:00
26b92ada0e
Remove unused JS file
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-01 00:59:10 -03:00
a9ccfe06d9
Fix some long lines in JS - JSLinut recommendation
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-01 00:49:00 -03:00
80a5e0a735
Use dot notation for array access - JSLint recommendation
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-01 00:45:41 -03:00
11b9d224fd
Fix semicolon at end of JS lines
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-01 00:42:53 -03:00
3e8c5441f7
Merge pull request #4521 from nextcloud/custom-mount-types
...
allow apps to set custom mount types
2017-04-28 12:50:38 +02:00
ec272f3ac3
Merge pull request #4574 from nextcloud/rename-extension-point
...
Rename extension point
2017-04-28 11:15:28 +02:00
9e7f7ba7f6
Add sharing types for guests
...
Fixes https://github.com/nextcloud/guests/issues/4
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-04-28 09:56:57 +02:00
e974f26afa
Rename extension point
...
To align with upstream.
Fixes https://github.com/nextcloud/guests/issues/3
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-04-28 09:49:02 +02:00
ab9a36e872
allow apps to set custom mount types
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-04-28 09:38:21 +02:00
9c4275a832
Show tooltip for second action.
...
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
2017-04-27 18:11:35 +02:00
646db7f88d
Merge pull request #4518 from nextcloud/downstream-25838
...
Fix share indicator handling
2017-04-26 19:23:27 +02:00
17a31a51c6
Fix share indicator handling
...
Properly update the fileInfoModel with the updated share types, which
also updates the file list row indicator properly
2017-04-26 13:38:12 +02:00
6bbc682c4b
handle 404 separately
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-04-26 09:30:21 +02:00
99b201a188
unit test jquery.contactsmenu
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-04-26 09:28:15 +02:00
Daniel Calviño Sánchez
blizzz
Morris Jobke
Julius Härtl
Christoph Wurst
Joas Schilling
Patrik Kernstock
rakekniven
Bjoern Schiessle
Roeland Jago Douma
Mario Danic
Felix A. Epp
Roeland Jago Douma
Lukas Reschke
Robin Appelman
Ivan Sein
Vincent Petry
Georg Ehrke