Commit Graph

24377 Commits

Author SHA1 Message Date
Valdnet 107bbebb6c
Fix l10n
Issue: #26286
2021-03-25 10:26:50 +01:00
Nextcloud bot 9af8c0b380
[tx-robot] updated from transifex 2021-03-25 02:25:39 +00:00
Robin Appelman 8a92229485
getStorage can also return null
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 14:56:40 +01:00
Robin Appelman 98c3eb6cad
add dry-run option to files_external:notify
and add some additional logging

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 14:28:04 +01:00
John Molakvoæ da6019df67
Merge pull request #26255 from nextcloud/Valdnet-patch-6
l10n: Separate ellipsis
2021-03-24 09:13:20 +01:00
Nextcloud bot bb8a71266e
[tx-robot] updated from transifex 2021-03-24 02:25:07 +00:00
Valdnet 21db5bf9b9
l10n: Separate ellipsis
Unifying the text string with the others.
2021-03-23 09:12:52 +01:00
Roeland Jago Douma a219fa587a
Merge pull request #25776 from nextcloud/fix/sabre-file-checksum-no-file-info
Only write checksum if we have a valid file info
2021-03-23 08:59:21 +01:00
Christoph Wurst 24ec924586
Merge pull request #26033 from nextcloud/enh/comments/to_initialstate
Move comments to initial state
2021-03-23 08:33:42 +01:00
Nextcloud bot a81408a8e1
[tx-robot] updated from transifex 2021-03-23 02:24:02 +00:00
Morris Jobke 1c074e7602
Merge pull request #26198 from nextcloud/unified-search-node
Handle limit offset and sorting in files search
2021-03-22 21:48:51 +01:00
Roeland Jago Douma 8988406789 Move comments to initial state
* Do not extend the jssettings
* Just use the proper intial state
* Use it in the js code as well

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 20:31:56 +00:00
Morris Jobke 1eb084cfd3
Merge pull request #25498 from Worteks/feat-federatedfilesharing-logging
feat(federatedfilesharing): log errors, as suggested by @maxbes
2021-03-22 21:21:53 +01:00
Christoph Wurst 8152189b09 Only write checksum if we have a valid file info
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-22 21:11:07 +01:00
Roeland Jago Douma 90909ab9b9
Merge pull request #26149 from nextcloud/fix/ownership-transfer-ready-encryption
Only perform login check during ownership transfer for encryption
2021-03-22 20:28:25 +01:00
John Molakvoæ 6b4cfc5805
Merge pull request #26231 from nextcloud/Valdnet-patch-6
l10n: Add words user and because in ShareByMailProvider.php
2021-03-22 09:42:01 +01:00
Valdnet 1dab60a79d
l10n: Add changes to text string for user 2021-03-22 09:01:45 +01:00
Daniel Calviño Sánchez f99876997a
Remove duplicated query for email shares
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 06:50:47 +01:00
John Molakvoæ (skjnldsv) 0f3f6a6c54
Fix tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:47 +01:00
John Molakvoæ (skjnldsv) a100186e5e
Sharing link & mail parity
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:45 +01:00
John Molakvoæ (skjnldsv) 5e519fe17a
Clear the input after adding a new share
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:41:33 +01:00
John Molakvoæ (skjnldsv) c47e79fc67
Handle enforced password for mail shares in the WebUI
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:40:43 +01:00
John Molakvoæ (skjnldsv) c8e0809d43
Extract GeneratePassword function to its own file
This is needed to be able to use the function from other components.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:40:41 +01:00
John Molakvoæ (skjnldsv) 100d5d9a47
Add labels to mail shares
Now the email is shown on a second line if a label is set.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:34:09 +01:00
Nextcloud bot ae19cb168f
[tx-robot] updated from transifex 2021-03-22 02:23:45 +00:00
Morris Jobke 9e9b014e31
Merge pull request #26046 from nextcloud/smb-3.4.0
update icewind/smb to 3.4.0
2021-03-21 21:05:57 +01:00
Nextcloud bot 8c7e246d98
[tx-robot] updated from transifex 2021-03-21 02:23:12 +00:00
Valdnet 4b4b1f6ff1
l10n: Add word user in ShareByMailProvider.php
Standardizing text strings with other Nextcloud applications.
2021-03-20 15:37:32 +01:00
dependabot-preview[bot] c5c6d19676 Bump marked from 2.0.0 to 2.0.1
Bumps [marked](https://github.com/markedjs/marked) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js)
- [Commits](https://github.com/markedjs/marked/compare/v2.0.0...v2.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-20 15:35:43 +01:00
dependabot-preview[bot] 017537ab95 Bump clipboard from 2.0.6 to 2.0.8
Bumps [clipboard](https://github.com/zenorocha/clipboard.js) from 2.0.6 to 2.0.8.
- [Release notes](https://github.com/zenorocha/clipboard.js/releases)
- [Commits](https://github.com/zenorocha/clipboard.js/compare/v2.0.6...v2.0.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-20 12:46:13 +00:00
dependabot-preview[bot] 387370fd37 Bump dompurify from 2.2.6 to 2.2.7
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.2.6 to 2.2.7.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](https://github.com/cure53/DOMPurify/compare/2.2.6...2.2.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-20 11:43:39 +01:00
Roeland Jago Douma 78e5120d98
Merge pull request #26213 from nextcloud/wiswedel/fix/style/files/settingsDisplacement
Removed unnecessary padding
2021-03-20 10:54:27 +01:00
Nextcloud bot cb2745a541
[tx-robot] updated from transifex 2021-03-20 02:23:44 +00:00
Morris Jobke f2969dc9ca
Merge pull request #26212 from nextcloud/fix-dashboard-background
Make background cover whole viewport
2021-03-19 20:30:49 +01:00
Robin Appelman a0fb6d2518
pass order from unified search to file search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 16:07:57 +01:00
Morris Jobke fb09f3d31d
Merge pull request #26145 from nextcloud/smb-force-write-option
add (hidden) option to always show smb root as writable
2021-03-19 15:31:04 +01:00
Vincent Petry e6fd9b2f55
Merge pull request #25129 from nextcloud/bugfix/smb-notify-subpath
Fix files_external:notify command when running withing a subdirectory
2021-03-19 14:53:16 +01:00
Sascha Wiswedel 8b145c7858 Removed unnecessary padding
Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
2021-03-19 14:24:10 +01:00
Jo Sprague dc1413cad9
Make background cover whole viewport
Without a min-height, wider viewports can result in a blank white space at the bottom of the screen. This CSS ensures that doesn't happen.

Signed-off-by: Jo Sprague <git@josprague.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-19 14:06:22 +01:00
Julien Veyssier 086cf56b21
Merge pull request #26196 from nextcloud/fix/app-sidebar-description-slot
Adapt files and app settings to @nc/vue changes
2021-03-19 13:32:46 +01:00
Julien Veyssier 3c172ce600 adapt files and app settings sidebar 'primary-actions' slot that became 'description' in @nc/vue v3.3.0
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-19 12:56:35 +01:00
Christoph Wurst e68c4a4ed3
Only perform login check during ownership transfer for encryption
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-19 11:25:56 +01:00
Nextcloud bot 9e70b83f13
[tx-robot] updated from transifex 2021-03-19 02:24:56 +00:00
John Molakvoæ 6ade109b60
Merge pull request #26194 from nextcloud/techdebt/noid/remove-duplicate-sharing-unit-integration-tests-group-permission
Remove duplicate unit test in sharing that checks for group permission updates
2021-03-18 16:37:29 +01:00
Robin Appelman 14a1b5063e
use "newer" node search api directly in unified search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 16:22:29 +01:00
Christoph Wurst 0d8b3baf61
Use executeQuery and executeUpdate in the QBMapper
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-18 15:40:18 +01:00
Morris Jobke b34035f845
Merge pull request #26193 from nextcloud/techdebt/noid/remove-sharing-duplicate-unit-integration-tests
Permission tests for the sharing are fully covered in sharing v1 integration tests
2021-03-18 11:34:15 +01:00
Morris Jobke d650de13a4
Remove duplicate unit test in sharing that checks for group permission updates
* it was skipped before anyways
* it is covered for example in build/integration/sharing_features/sharing-v1-part3.feature#L517-L548 (see 54f8f75f6f/build/integration/sharing_features/sharing-v1-part3.feature (L517-L548))
* more permission updates are tested in the webdav section, where an OCS API is called and the WebDAV response is checked for the properly changed permission

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-18 10:31:56 +01:00
Morris Jobke e6bd23acf9
Permission tests for the sharing are fully covered in sharing v1 integration tests
See build/integration/sharing_features/sharing-v1*.features for the exact same tests. Especially part3 that covers most of the different permission setups over webdav.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-18 10:15:42 +01:00
Morris Jobke 6401d88283
Merge pull request #25331 from nextcloud/fix-valid-storages-removed-when-cleaning-remote-storages
Fix valid storages removed when cleaning remote storages
2021-03-18 08:57:09 +01:00
Nextcloud bot a186d08471
[tx-robot] updated from transifex 2021-03-18 02:25:02 +00:00
Morris Jobke f56e5bb0db
Merge pull request #25676 from nextcloud/drop/utl-is-ie
Drop \OCP\Util::isIe
2021-03-17 20:18:11 +01:00
John Molakvoæ f1fefd91df
Merge pull request #26160 from nextcloud/enh/eslint 2021-03-17 18:14:31 +01:00
Joas Schilling 0d46fafd41
Merge pull request #26161 from nextcloud/bugfix/noid/improve-matching-of-phonebook-searches
Improve search results when only phonebook-matches can we autocompleted
2021-03-17 15:22:03 +01:00
John Molakvoæ (skjnldsv) 87d39375d8
Fix comments filesplugin
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 14:45:29 +01:00
Morris Jobke d011df6aa7
Merge pull request #26076 from nextcloud/enh/noid/ldap-occ-user-reset
adds ldap user:reset command
2021-03-17 14:36:18 +01:00
John Molakvoæ (skjnldsv) 043b5a9de4
Fix TerserPlugin
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 13:03:39 +01:00
John Molakvoæ (skjnldsv) 5d9bb5e247
Lint fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 13:03:38 +01:00
Arthur Schiwon 1b0355f2c6
adds ldap user:reset command
- allows to delete data of existing LDAP users, which otherwise is safe
  guarded
- ensures that the user is not being deleted on LDAP through a plugin

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-17 11:23:48 +01:00
Vincent Petry ab5c19bb08
Merge pull request #26131 from nextcloud/fix/initialstate-templates
Fix default missing initial state for templates
2021-03-17 10:18:03 +01:00
Joas Schilling 3379e69ecc
Fix parameter types in docs
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-17 09:51:31 +01:00
Vincent Petry 98fb265e9f
Merge pull request #26153 from nextcloud/psalm/26111/fix-undefined-exception-class
Use correct exception type hint in catch statement
2021-03-17 09:41:47 +01:00
Nextcloud bot 096806087c
[tx-robot] updated from transifex 2021-03-17 02:24:19 +00:00
Morris Jobke 0f2c4ff64c
Use correct exception type hint in catch statement
Found by psalm update 4.6.2 to 4.6.3 in #26111

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-16 22:06:07 +01:00
Robin Appelman 5ffaa94fbc
add (hidden) option to always show smb root as writable
some smb servers are very insistent in reporting that the root of the share is readonly, even if it isn't.

This works around the problem by adding a hidden option to overwrite the permissions of the root of the share.

This can be enabled using

```bash
occ files_external:config <mount id> root_force_writable true
```

where you can find your mount id using

```bash
occ files_external:list
```

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:35:35 +01:00
Vincent Petry c6d2d8746c
Fix CS in CacheTest
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-16 11:43:53 +01:00
Nextcloud bot 72e6201869
[tx-robot] updated from transifex 2021-03-16 02:24:42 +00:00
Vincent Petry e559afb8d4
Merge pull request #25136 from nextcloud/cachejail-search-filter
do cachejail search filtering in sql
2021-03-15 17:45:30 +01:00
John Molakvoæ (skjnldsv) 223fe2aae6
Fix default missing initial state for templates
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-15 17:23:30 +01:00
Vincent Petry 6997344931
Log exceptions when creating share
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.

In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-15 12:00:41 +01:00
Nextcloud bot f82edda9c1
[tx-robot] updated from transifex 2021-03-15 02:23:58 +00:00
Nextcloud bot 44ce623923
[tx-robot] updated from transifex 2021-03-14 02:23:41 +00:00
Nextcloud bot 0869c75d5a
[tx-robot] updated from transifex 2021-03-13 02:22:53 +00:00
Roeland Jago Douma bf39adb49b
Merge pull request #26049 from nextcloud/search-file-limit-results
limit constructing of result objects in file search
2021-03-12 12:58:49 +01:00
blizzz 812bc83b56
Merge pull request #26080 from nextcloud/bugfix/noid/only-clear-known-users-when-we-had-at-least-one-phonebook-entry
Only clear known users when we had at least one phonebook entry
2021-03-12 10:45:36 +01:00
Joas Schilling 5c3551cf2f
Only clear known users when we had at least one phonebook entry
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-12 09:04:13 +01:00
Nextcloud bot cd3ef614be
[tx-robot] updated from transifex 2021-03-12 02:22:44 +00:00
Roeland Jago Douma a1757f83a3
Merge pull request #26067 from nextcloud/techdept/psalm/trashbin/execute
Cleanp execute usage in the trashbin
2021-03-11 21:03:15 +01:00
Roeland Jago Douma 2cbc2710ec
Merge pull request #26066 from nextcloud/techdept/psalm/type_error
Fix type error in CheckBackupCodes bg job
2021-03-11 21:02:35 +01:00
John Molakvoæ c8368af3cb
Merge pull request #26068 from nextcloud/bugfix/noid/fix-comments-value-update
Fix comments field value update
2021-03-11 19:32:25 +01:00
Roeland Jago Douma a3b1c1cea3
Merge pull request #26064 from nextcloud/techdept/psalm/type_oauth_db
Add psalm annotation to the DB handlers of OAuth2
2021-03-11 16:46:08 +01:00
Roeland Jago Douma 8008b33b8d Cleanp execute usage in the trashbin
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-11 15:39:42 +01:00
Vincent Petry a60127acc8
Fix comments field value update
Fixes issue where the comment field value was not properly read out of
the rich content field.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-11 15:39:33 +01:00
Roeland Jago Douma c19708a85e Fix type error in CheckBackupCodes bg job
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-11 15:33:15 +01:00
dependabot-preview[bot] 69c4578b5b
Merge pull request #26057 from nextcloud/dependabot/npm_and_yarn/nextcloud/vue-3.7.2 2021-03-11 14:11:40 +00:00
Robin Appelman 424db15dea
limit constructing of result objects in file search
even thought we currently have no proper way of limiting the search itself, we can at least limit the construction of the result objects.

this saves about 40% of the time spend in the search request in my local testing

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-11 14:49:57 +01:00
Roeland Jago Douma c2f7c417b2 Add psalm annotation to the DB handlers of OAuth2
* Psalm annotations
* To new executeUpdate

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-11 14:33:15 +01:00
Christoph Wurst 95cddb84e2
Merge pull request #25569 from nextcloud/JakubOnderka-patch-1
file-upload: Correctly handle error responses for HTTP2
2021-03-11 13:54:55 +01:00
John Molakvoæ (skjnldsv) 31ddfb0294
Fix SharingInput Multiselect
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-11 12:30:15 +01:00
John Molakvoæ (skjnldsv) 7f06a0cf8e
Compile js
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-11 12:14:48 +01:00
Roeland Jago Douma f90090d2b3
Merge pull request #26019 from ste101/patch-1
Allow webp as background image
2021-03-11 10:52:31 +01:00
Christoph Wurst ba369c134e
Merge pull request #25911 from nextcloud/bugfix/noid/fix-share-password-saving
Only clear share password model when actually saved
2021-03-11 10:48:34 +01:00
Vincent Petry 65bb949376
Merge pull request #26032 from nextcloud/techdept/psalm/requesthandlerController_loggerinterface
Move requesthandler controller to LoggerInterface
2021-03-11 10:37:41 +01:00
Vincent Petry 3462444def
Only clear share password model when actually saved
Instead of always clearing the password in the share model, now only do
it when it was actually saved.

Fixes an issue where saving another field would clear the password too
early and prevent it to be saved when the dropdown closed.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-11 09:07:30 +01:00
Joas Schilling 56b08c04c7
Merge pull request #26031 from nextcloud/feature/noid/allow-autocomplete-based-on-phone-sync
Allow autocomplete based on phone sync
2021-03-11 08:29:21 +01:00
Nextcloud bot 31cc0741cb
[tx-robot] updated from transifex 2021-03-11 02:23:08 +00:00
Joas Schilling 61ed57b757
Rename some parameters and methods to make the API more clear
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 20:30:29 +01:00
Roeland Jago Douma a6447a5c03
Merge pull request #25940 from nextcloud/dependabot/npm_and_yarn/css-loader-5.1.1
Bump css-loader from 5.0.1 to 5.1.1
2021-03-10 19:56:40 +01:00
Joas Schilling 07095fd122
Also clear the knownUser when changing via the settings endpoint
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 19:37:10 +01:00
Joas Schilling 78efabb073
Fix CS hopefully
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:51:28 +01:00