Commit Graph

19477 Commits

Author SHA1 Message Date
dependabot[bot] e81ff4ebcb
Bump webpack from 4.23.1 to 4.24.0 in /apps/updatenotification
Bumps [webpack](https://github.com/webpack/webpack) from 4.23.1 to 4.24.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.23.1...v4.24.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-11-05 01:13:08 +00:00
dependabot[bot] 39b111d58d
Bump css-loader from 1.0.0 to 1.0.1 in /apps/updatenotification
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v1.0.0...v1.0.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-11-05 01:12:42 +00:00
Nextcloud bot c28ea52155
[tx-robot] updated from transifex 2018-11-05 01:12:32 +00:00
Marius Blüm 9340a6a0e4
Change "Advanced options" to h3
Signed-off-by: Marius Blüm <marius@lineone.io>
2018-11-04 23:52:22 +01:00
Roeland Jago Douma 72b7c9ffa0
Merge pull request #12105 from nextcloud/using-resharing-right-to-display-shares
Shares are displayed to users with resharing rights
2018-11-04 21:08:11 +01:00
John Molakvoæ (skjnldsv) 60d8b56856
Added multi-get vcf download plugin
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-04 20:01:49 +01:00
Roeland Jago Douma ab8c2b0719
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-04 13:55:49 +01:00
Roeland Jago Douma 5d3051ff62
Do not log FileLock as exception
There is no reason to log FileLock errors as exceptions to the log file.
Locks happen for very legit reasons and it is actually a sign of the
code doing its job.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-04 13:55:49 +01:00
Tomasz Grobelny 1fa6e0be23 Merge remote-tracking branch 'upstream/master' into fix_file_move
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-04 09:39:19 +00:00
Jonas Sulzer afd39c27af
make twofactor .button inlin-block
fixes #3752

Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
2018-11-04 04:01:40 +01:00
Nextcloud bot 9d7f02ec47
[tx-robot] updated from transifex 2018-11-04 01:14:02 +00:00
Tomasz Grobelny 41687ef00f Fix move related tests
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-03 23:01:32 +00:00
Nextcloud bot f196394c44
[tx-robot] updated from transifex 2018-11-03 01:12:38 +00:00
Roeland Jago Douma b1fd72c1cf
Set the filemodel before rending the detailsview
fixes #10934

Else it triggers the rendering two times. Resulting is weird state in
for example the comments. Because the comments for OLD_FILEID are
retrieved but then the model is changed to NEW_FILEID. But the old
comments still get in and get parsed.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-02 22:45:25 +01:00
Roeland Jago Douma 9d89f8bbac
Merge pull request #12071 from nextcloud/addressbook-uid-check-migration
Addressbook uid check migration
2018-11-02 19:37:48 +01:00
Roeland Jago Douma c8cf986527
Fix files_sharing
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-02 19:20:37 +01:00
Roeland Jago Douma 2452a3ec73
Properly query the methodreflector
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-02 19:20:37 +01:00
Roeland Jago Douma 30a1237f81
Merge pull request #11875 from nextcloud/add-support-for-sending-the-password-for-a-link-share-by-nextcloud-talk
Add support for sending the password for a link share by Nextcloud Talk
2018-11-02 14:54:46 +01:00
John Molakvoæ (skjnldsv) 66624cfe0a
Phpunit fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-02 14:20:53 +01:00
Morris Jobke f5728f2c14
Merge pull request #12190 from forsd/AddtestFiles_Trashbin
Add test OCA\Files_Trashbin\Capabilities
2018-11-02 14:01:25 +01:00
Roeland Jago Douma 7ba8700ba1
Merge pull request #12148 from nextcloud/suppress-wrong-audit-log-message
suppress wrong audit log messages about failed login attempts
2018-11-02 13:52:50 +01:00
Julius Härtl 166907afef
Merge pull request #12182 from nextcloud/3rdparty/sabre-3.2.3
[3rdparty] Bump sabre/dav to 3.2.3
2018-11-02 13:09:46 +01:00
Maxence Lange 77b95ccd12
revert tests
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2018-11-02 12:10:49 +01:00
Maxence Lange 0fc8a0f58e
user can have his resharing rights revoked, yet seeing created shares
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2018-11-02 12:10:49 +01:00
Maxence Lange 236a293f6a
check parents resharing rights
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2018-11-02 12:10:48 +01:00
Maxence Lange 275cea5d9c
limit to circles moderator
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2018-11-02 12:09:28 +01:00
Maxence Lange 72ad2d60b5
display shares to circles moderator
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2018-11-02 12:09:28 +01:00
Maxence Lange 68c44bb642
shares are displayed to users with resharing rights
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2018-11-02 12:09:26 +01:00
Nextcloud bot 3b5e031e6b
[tx-robot] updated from transifex 2018-11-02 01:13:34 +00:00
Daniel Calviño Sánchez adf80aa8b3 Add sending the password by Talk for a link share to ShareAPIController
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-02 01:57:48 +01:00
Daniel Calviño Sánchez 52cada951b Check "note", "label" and "hide download" too in update share tests
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-02 01:56:07 +01:00
Morris Jobke f28691c26e
Merge pull request #11844 from nextcloud/multiple-link-shares
allow to create multiple link shares via share api
2018-11-01 22:36:09 +01:00
Jan-Christoph Borchardt 9dea41f8fe Fix wording, sort 'Add another link' to bottom so it does not confuse
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-11-01 21:33:10 +01:00
Jan-Christoph Borchardt 7bfb32230a Use primary color for share link icon background instead of bland grey
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-11-01 21:33:10 +01:00
John Molakvoæ (skjnldsv) 206d6126b6 Fix note display
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-01 21:30:45 +01:00
John Molakvoæ (skjnldsv) 106ed07d6a Copy link outside menu
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-01 21:30:45 +01:00
John Molakvoæ (skjnldsv) 1bd6d39b39 Migrate link shares to array
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-01 21:29:40 +01:00
Morris Jobke 7246f2ace5
Update PHPDoc to reflect the actual behaviour
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-01 15:02:50 +01:00
John Molakvoæ (skjnldsv) d89edb28c4
move migration
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-01 15:02:50 +01:00
John Molakvoæ (skjnldsv) 9afff2fb20
Properly set uid and create and update
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-01 15:00:49 +01:00
Morris Jobke d842cd1eec
Merge pull request #12150 from nextcloud/techdebt/noid/ldap-rm-iusertools
remove app specific IUserTools and consolidate test
2018-11-01 13:52:45 +01:00
Unknown 0ad76cc81a Add test OCA\Files_Trashbin\Capabilities 2018-11-01 17:20:34 +05:00
Morris Jobke bfab6ccf1b
Merge pull request #12180 from nextcloud/sidebar-fixes
Sidebar fixes, mostly fixing design of tabs
2018-11-01 12:42:03 +01:00
Morris Jobke 0247a0d6db
Merge pull request #12162 from nextcloud/file-menu-align
Align file menu below '+' button, fix #5595
2018-11-01 12:01:05 +01:00
Roeland Jago Douma e94ee7cbca
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-01 11:31:41 +01:00
Morris Jobke 15ef354ace
Merge pull request #12129 from nextcloud/versions-modular-api
modular versions api
2018-11-01 10:59:47 +01:00
Roeland Jago Douma 3503329b52
Merge pull request #12072 from nextcloud/writestream
extend storage api to allow directly writing a stream to storage
2018-11-01 07:52:31 +01:00
Bjoern Schiessle feb9f72e8b adjust unit tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-11-01 04:27:25 +01:00
Jan-Christoph Borchardt 4e12132e43
Fix issues with clipboard button for local link in sidebar
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-11-01 04:11:20 +01:00
Jan-Christoph Borchardt bb1d503f3e
Add icon to Versions sidebar tab
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-11-01 04:10:55 +01:00
Bjoern Schiessle 5e90711600 allow to update lables for public link shares
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-11-01 02:18:55 +01:00
Bjoern Schiessle f377a61f90 allow to add labels to shares
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-11-01 02:15:07 +01:00
Nextcloud bot 9d5982ba4b
[tx-robot] updated from transifex 2018-11-01 01:12:59 +00:00
Robin Appelman 4403d771ad
modular versions api
Allows apps to register version backends for storage types
The existing versions backend is wrapped in a "legacy" backend.

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-11-01 00:21:48 +01:00
Robin Appelman 9b3cc72f7c
fix writeStream for jail wrapper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-31 21:10:57 +01:00
Robin Appelman 4094a5e74a
update dav tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-31 21:10:54 +01:00
Robin Appelman 93de63777e
extend storage api to allow directly writing a stream to storage
this removes the need for temporary storages with some external storage backends.
The new method is added to a separate interface to maintain compatibility with
storage backends implementing the storage interface directly (without inheriting common)

Currently the interface is implemented for objectstorage based storages and local storage
and used by webdav uploads

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-31 21:10:44 +01:00
Arthur Schiwon 0d1370f2f6
Revert "Populate the mention-notification with the actual message"
This reverts commit d295ff5367.
2018-10-31 16:16:51 +01:00
Julius Härtl 838105877c
Merge pull request #11647 from nextcloud/make-possible-for-tab-views-to-add-css-classes-to-their-container
Make possible for tab views to add CSS classes to their container
2018-10-31 15:37:48 +01:00
blizzz 83cff3178b
Merge pull request #12009 from nextcloud/feature/noid/populate-notification-message-with-the-comment
Populate the mention-notification with the actual message
2018-10-31 11:51:55 +01:00
Jan-Christoph Borchardt 1cc05af7a6
Align file menu below '+' button, fix #5595
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-31 11:20:02 +01:00
Roeland Jago Douma 3a6b525a34
Merge pull request #12095 from MasterOfDeath/OCA-ShareByMail-Capabilities-test-unit
OCA\ShareByMail\Capabilities add unit test
2018-10-31 10:15:03 +01:00
Roeland Jago Douma 2574394625
Merge pull request #12147 from MasterOfDeath/OCA-SystemTags-Activity-Setting-add-unit-test
OCA\SystemTags\Activity\Setting unit test
2018-10-31 10:13:50 +01:00
Bjoern Schiessle d0411b2369
allow to create multiple link shares via share api
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-10-31 06:55:52 +01:00
Jan-Christoph Borchardt 9c68db5ffb
slightly round off thumbnails in list view too
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-31 00:01:58 +01:00
Arthur Schiwon 0c5d9127e8
remove app specific IUserTools and consolidate test
Just some house keeping. IUserTools with used in even older days for
easier creation of Access instances…

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-30 22:44:50 +01:00
Bjoern Schiessle 0efd29f41f
first check if the user is already logged in and then try to authenticate via apache, this way we suppress wrong audit log messages about failed login attempts
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-10-30 22:14:52 +01:00
blizzz 1293affc84
Merge pull request #12020 from nextcloud/bugfix/11795/calendar_invitation_fallback_lang
Calendar invitation: use system default instead of sender's language as fallback
2018-10-30 22:05:20 +01:00
Rinat Gumirov 6760c3e699 OCA\SystemTags\Activity\Setting unit test
Signed-off-by: Rinat Gumirov <rinat.gumirov@mail.ru>
2018-10-31 01:26:59 +05:00
MasterOfDeath f465839e34 OCA\ShareByMail\Capabilities unit test
OCA\ShareByMail\Capabilities unit test

Signed-off-by: Rinat Gumirov <rinat.gumirov@mail.ru>
2018-10-31 00:07:44 +05:00
Roeland Jago Douma 674930da7f
Move ExpiredTokenException to the correct namespace
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-30 19:30:45 +01:00
Roeland Jago Douma 41ff001b77
Merge pull request #11899 from nextcloud/enhancement/noid/sharing-consolidation
Sharing user consolidation
2018-10-30 19:27:05 +01:00
Tomasz Grobelny 68a27debd1 Fix file move operation for large number of files
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-10-30 15:37:21 +01:00
Daniel Calviño Sánchez bfb2a914d2 Honour "hide download" in the public share page
When the "hide download" property of a share is set the public share
page will not show the download button nor the menu with the download,
direct link and "Add to your Nextcloud" actions; the "downloadURL"
hidden field will not be included either in the generated HTML.

Despite that, note that the "downloadURL" parameter is still set and
passed to the template, as this could be needed anyway to generate
previews (for example, of audio files).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-30 15:18:55 +01:00
Roeland Jago Douma c237a3f003 Expose hide download to public page
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-30 15:18:55 +01:00
Roeland Jago Douma abbb946bbb Propegate hide download state in share provider
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-30 15:18:55 +01:00
Morris Jobke b28a0c10bf
Merge pull request #11946 from nextcloud/bugfix/11945/fix-js-namespace-of-files-external
Fix JS namespace of files_external app
2018-10-30 14:57:57 +01:00
Julius Härtl ffc32222f1
Styling papercuts
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 14:43:34 +01:00
Julius Härtl b9c5e569d3
Update AddressBookImpl documentation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 14:43:08 +01:00
Roeland Jago Douma c1698948b8
Merge pull request #12130 from nextcloud/fix/reset_bruteforce_oauth
Reset bruteforce on token refresh OAuth
2018-10-30 14:26:50 +01:00
Roeland Jago Douma 8b2b238d86
Merge pull request #12054 from nextcloud/fix/5212/interact-with-userobject
LDAP: announce display name changes so that addressbook picks it up
2018-10-30 13:38:16 +01:00
Joas Schilling d295ff5367
Populate the mention-notification with the actual message
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-30 13:29:58 +01:00
Arthur Schiwon 49456e42f9
do not run into UniqueConstraintViolationException
… when an unmapped user logs in for the first time when background job
mode is ajax and no memcache was configured.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-30 12:12:03 +01:00
Roeland Jago Douma 75456b057d
Reset bruteforce on token refresh OAuth
When using atoken obtained via OAuth the token expires. Resulting in
brute force attempts hitting the requesting IP.

This resets the brute force attempts for that UID on a valid refresh of
the token.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-30 11:21:27 +01:00
Julius Härtl 61af607525
Make enhancing entries with type property optional
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:35 +01:00
Julius Härtl 192324e4de
Make dropdown height 6 1/2 entries
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:35 +01:00
Julius Härtl 5059605c99
Increase max-width of the share autocompletion suggestions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:34 +01:00
Julius Härtl 3e11515b9c
Merge contacts and add type of result to the UI
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:34 +01:00
Julius Härtl 8b92a6c9cb
Add type of properties to address book results
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:34 +01:00
Julius Härtl 45d8aeb9f2
Remove federated sharing address books which are the same as local ones
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:33 +01:00
Julius Härtl 6dde7e1183
Improve share select list
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:32 +01:00
Morris Jobke 31ccf8580a
Merge pull request #12070 from nextcloud/fix/noid/announce-chosen-uid
announce the chosen uid (fixes wrong variable usage)
2018-10-30 10:12:04 +01:00
Joas Schilling 9645e545b3 Fix JS namespace of files_external app
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-30 09:43:26 +01:00
Nextcloud bot 9f99232865
[tx-robot] updated from transifex 2018-10-30 01:12:54 +00:00
Roeland Jago Douma 90dc8fb42e
A folder should get a folder mimetype
If doing achunked upload the mimetype of the folder would otherwise be
guessed from the path. Which always returned application/octet-stream.

If an access control rule to block that is in place this means that all
chunked uploads fail hard in directories as the isCreatable on the
directory always fails.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-29 21:35:08 +01:00
Morris Jobke 963d968f06
Merge pull request #12113 from nextcloud/fileinfo-getextension
Add getExtension() to FileInfo
2018-10-29 17:23:27 +01:00
Morris Jobke 76c31857cb
Merge pull request #12107 from nextcloud/fix/12086/no-unintentional-empty-attributes
remove unneeded empty LDAP search attribute values
2018-10-29 17:00:14 +01:00
Roeland Jago Douma 3aae3c82a4
Merge pull request #12041 from nextcloud/gridfixes
Properly hide files when searching
2018-10-29 16:12:44 +01:00
John Molakvoæ c05e8acdb1
Merge pull request #12019 from nextcloud/icons-svg-api-fixes
Move svg api endpoint
2018-10-29 15:45:45 +01:00
Robin Appelman e5c3e4b76f
Add getExtension() to FileInfo
this is a fairly common operation so it makes sense to prevent having
to repeatedly implement it.

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-29 15:24:02 +01:00
Roeland Jago Douma 4a642fc004
Merge pull request #12106 from nextcloud/bugfix/noid/federated-settings-logo
Fix logo path in personal federated sharing settings
2018-10-29 14:54:20 +01:00
John Molakvoæ (skjnldsv) c0477afb5d
Properly hide files when searching
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-29 14:51:29 +01:00
Arthur Schiwon d47e1513bc
remove unneeded empty search attribute values, fixes #12086
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-29 13:21:02 +01:00
Julius Härtl 4dda244ce2
Fix logo path in personal federated sharing settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-29 13:18:39 +01:00
Julius Härtl 4b7ef668a4
Adjust accessibility app color replacement
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-29 12:09:44 +01:00
dependabot[bot] 8c202f3af1
Bump webpack from 4.22.0 to 4.23.1 in /apps/oauth2
Bumps [webpack](https://github.com/webpack/webpack) from 4.22.0 to 4.23.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.22.0...v4.23.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-29 10:43:49 +00:00
dependabot[bot] 55f94695d0
Bump webpack from 4.22.0 to 4.23.1 in /apps/updatenotification
Bumps [webpack](https://github.com/webpack/webpack) from 4.22.0 to 4.23.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.22.0...v4.23.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-29 08:22:25 +00:00
Roeland Jago Douma 972f4191f4
Merge pull request #12096 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/webpack-4.23.1
Bump webpack from 4.22.0 to 4.23.1 in /apps/accessibility
2018-10-29 09:19:35 +01:00
Nextcloud bot 18fef12721
[tx-robot] updated from transifex 2018-10-29 01:13:07 +00:00
dependabot[bot] 0e750aa3c9
Bump webpack from 4.22.0 to 4.23.1 in /apps/accessibility
Bumps [webpack](https://github.com/webpack/webpack) from 4.22.0 to 4.23.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.22.0...v4.23.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-28 18:28:05 +00:00
Nextcloud bot 13abee2836
[tx-robot] updated from transifex 2018-10-28 00:12:49 +00:00
Nextcloud bot 0092e3adec
[tx-robot] updated from transifex 2018-10-27 00:12:35 +00:00
Arthur Schiwon 05f909dcf3
fixes wrong variable usage
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-26 18:03:41 +02:00
Stefan Weil a226f65aa2 Fix off-by-one bugs
This fixes warnings from LGTM:

    Off-by-one index comparison against length may lead
    to out-of-bounds read.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-26 17:31:42 +02:00
Morris Jobke 31c3814b0a
Merge pull request #12038 from nextcloud/assemblystream_size
Implement the size of an assembly stream
2018-10-26 17:02:16 +02:00
Roeland Jago Douma 70e4884e02
Implement the size of an assembly stream
This will make it possible to act propely on moves of future files if we
need to know the size (like for max size virus scanning).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-26 10:43:11 +02:00
Morris Jobke 7aa76a82bc
Merge pull request #12053 from nextcloud/enhancement/10923/remove-unncessary-check
remove LDAP::hasPagedResultSupport() from PHP < 5.4 days
2018-10-26 10:28:47 +02:00
Nextcloud bot aff53d6e34
[tx-robot] updated from transifex 2018-10-26 00:12:48 +00:00
Arthur Schiwon bbe44108b5
only write when the displayname differs, but then announce it
refs #5212 and fixes #9112

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-25 23:41:12 +02:00
Arthur Schiwon 2048872f9e
functions that were checked for are present since PHP 5.4, supported is >=/
* so the check from older days is really not necessary anymore
* resolves #10923

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-25 22:50:42 +02:00
Morris Jobke 6ad7f32938
Merge pull request #12016 from nextcloud/wip/noid/icon-base64
Directly embed icons into the icon-vars css file
2018-10-25 16:04:23 +02:00
Morris Jobke 0a2476fcb3
Merge pull request #11988 from nextcloud/docs/jsdoc-build
JSdoc build fixes and move build script out of the root folder
2018-10-25 15:49:27 +02:00
Daniel Calviño Sánchez 661756b02a Set error expected by the DAV client for a failed move
A revert triggers a move in the DAV client, and the DAV client expects a
DAV error message to be provided by the server in case of failure; if
no error message is given the client ends trying to get an attribute
from an undefined object and "crashes".

Besides that, if the revert fails the "done" callback of the promise
(the first parameter of "then") is never called, so a "fail" callback
should be used instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-25 13:07:06 +02:00
Daniel Calviño Sánchez 24abfd8869 Wait for the promise to be fulfilled before running the next test
In Jasmine 2.5 the "it" function takes an optional parameter that should
be called when the async work is completed (returning a promise was
introduced in Jasmine 2.7, so it is not supported yet in the tests). If
the parameter is not declared then the next test is executed without
waiting for the asynchronous work in the previous one to finish, which
could cause that asynchronous work to finish while a different test is
being run.

Note that if that happens the test could still work as expected if it
relied only in local variables. However, in the case of the successful
revert tests, the stubs being checked are not the ones created when that
test was initialized, but the ones created when the next test, the
failed revert test, was initialized and the previous variables were
replaced (although the model itself calls the proper stubs, as they are
set through parameters in function calls).

Besides all that, the checks in the failed revert test were never
executed due to a different problem which will be fixed in the next
commit.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-25 12:25:41 +02:00
Julius Härtl d21ded67a7
Keep list of icons in a separate file for use in the accessibility app
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-25 12:16:10 +02:00
Nextcloud bot 58fde16226
[tx-robot] updated from transifex 2018-10-25 00:13:01 +00:00
Morris Jobke 88904200e0
Merge pull request #11889 from stweil/lgtm
Remove replace call which does not replace anything
2018-10-24 23:55:55 +02:00
Georg Ehrke 5c51d84a67
Calendar invitation: use system default instead of sender's language as fallback
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-24 18:39:30 +02:00
Bjoern Schiessle 87657fffd8
skip already encrypted files on encrypt all command
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-10-24 16:53:39 +02:00
Julius Härtl d14434fa2e
Adjust some jsdocs
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-24 16:24:16 +02:00
Julius Härtl 5d888984a0
Fix jsdocs build on server repo
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-24 15:41:08 +02:00
Morris Jobke 37782b1084
Merge pull request #11573 from nextcloud/gridview-table
Files grid view
2018-10-24 15:31:23 +02:00
Morris Jobke 2ec5d2a6de
Merge pull request #11533 from nextcloud/accessibility-cache-fixes
Added cache override to ensure an always up-to-date accessibility css
2018-10-24 15:04:29 +02:00
Stefan Weil a13c80062d Remove replace call which does not replace anything
The original code replaced / by /.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-24 14:53:52 +02:00
Roeland Jago Douma b3a0d87117
Merge pull request #10888 from nextcloud/bug/noid/fix-missing-quickaccess-favorite-folder-on-add
Bug/noid/fix missing quickaccess favorite folder on add
2018-10-24 13:45:40 +02:00
Nextcloud bot ded746f821
[tx-robot] updated from transifex 2018-10-24 00:12:31 +00:00
Roeland Jago Douma b853102a8f
Merge pull request #11886 from nextcloud/feature/noid/principal_search_displayname
Principal property search for users and groups with {DAV:}display name
2018-10-23 21:26:31 +02:00
Roeland Jago Douma 41fbda00ed
Merge pull request #11928 from stweil/fix
Fix use of undeclared variable
2018-10-23 21:15:53 +02:00
Roeland Jago Douma 530e39b061
Merge pull request #11778 from nextcloud/versions-webui-dav
move versions webui over to the dav api
2018-10-23 20:21:05 +02:00
John Molakvoæ (skjnldsv) ede6472e52
Fix FF performance and recals issues
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 18:07:15 +02:00
Morris Jobke 4ad27260a9
Merge pull request #11439 from nextcloud/trash-modular-api
Modular trashbin api
2018-10-23 17:11:16 +02:00
John Molakvoæ (skjnldsv) 8013dab044
Allow focus on input with keyboard
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 17:00:47 +02:00
Nextcloud bot a9fb21f9fc
[tx-robot] updated from transifex 2018-10-23 14:54:28 +00:00
John Molakvoæ (skjnldsv) cf57df6e73
Restore table head
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 16:46:45 +02:00
John Molakvoæ (skjnldsv) b6981dcecb
Merge branch 'master' of https://github.com/nextcloud/server into gridview-table
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 16:44:20 +02:00
Morris Jobke ae94c5a94c
Merge pull request #11943 from nextcloud/buttons-round
Round off buttons 'pill style' like on the website
2018-10-23 16:29:47 +02:00
Morris Jobke 869df2ee7a
Merge pull request #11980 from nextcloud/assemblly-stream-lazy
lazy open first source stream in assemblystream
2018-10-23 16:17:49 +02:00
Morris Jobke 9b092fd4bd
Merge pull request #11967 from nextcloud/fix-opening-a-section-again-in-the-files-app
Fix opening a section again in the Files app
2018-10-23 15:29:55 +02:00
Jan-Christoph Borchardt b04ebd8553
Round off buttons 'pill style' like on the website
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 15:18:37 +02:00
Morris Jobke 171fe69db7
Merge pull request #11932 from nextcloud/font-nunito
Change typeface to Nunito
2018-10-23 15:14:10 +02:00
Roeland Jago Douma d11609a152
Merge pull request #11974 from nextcloud/bugfix/noid/lax-csp-on-talk-shares
Use lax CSP when the share is a talk share
2018-10-23 14:29:52 +02:00
Jan-Christoph Borchardt ade50d3b71
Remove font-specifics from high contrast theme because we are now on regular+bold anyway
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 13:13:07 +02:00
Jan-Christoph Borchardt 0158703590
Fix font-face in dyslexia-friendly theme
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 13:12:32 +02:00
Jan-Christoph Borchardt d9aa484641
Fix font-face on LDAP tooltip
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 13:12:08 +02:00
John Molakvoæ (skjnldsv) 26ca7a0e2f
Add filepicker toggle
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 10:38:00 +02:00
Roeland Jago Douma 31d1179c41
Merge pull request #11973 from nextcloud/bug/accessibility/get_js_without_uid
If there is no UID do not explode accessibility javascript
2018-10-23 10:18:45 +02:00
John Molakvoæ (skjnldsv) bf6a1650ce
Use preview-x & preview-y on public pages
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:59:34 +02:00
John Molakvoæ (skjnldsv) ec05e5d048
Fix public background override
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:54:09 +02:00
John Molakvoæ (skjnldsv) e0dde083d0
Public fixes, request & default to grid
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:43:02 +02:00
John Molakvoæ (skjnldsv) 8652ada561
Tooltip on hover only
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:27:27 +02:00
John Molakvoæ (skjnldsv) efdb535a5d
Fix grey background over thumbnail
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:23:22 +02:00
John Molakvoæ (skjnldsv) b662977862
Fix table hidden on empty folder
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:18:14 +02:00
dependabot[bot] 0ee610f012
Bump webpack from 4.20.2 to 4.22.0 in /apps/updatenotification
Bumps [webpack](https://github.com/webpack/webpack) from 4.20.2 to 4.22.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.20.2...v4.22.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-22 20:43:17 +00:00
Stefan Weil a887c6e77b Fix use of undeclared variable
This fixes a warning from LGTM:

    Variable 'data' is used before its declaration.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-22 21:07:52 +02:00
Robin Appelman 2f518b6ac8
lazy open first source stream in assemblystream
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-22 16:11:13 +02:00
Georg Ehrke 5cfb5ec176
allow group principal search for dav displayname property
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:18 +02:00
Georg Ehrke 218253db76
allow user principal search for dav displayname property
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:18 +02:00
Georg Ehrke 10f0296ad6
overwrite Sabre/DAV's handler for calendar-user-type to report correct user type
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:18 +02:00
Georg Ehrke 325e366b58
add correct calendar-user-type to resource and room backend
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:13 +02:00
Roeland Jago Douma f737ae719d
Merge pull request #11960 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/webpack-4.22.0
Bump webpack from 4.20.2 to 4.22.0 in /apps/oauth2
2018-10-22 15:31:09 +02:00
Daniel Kesselberg 1ad42e8f81
Revert changes not related to $verbose
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-22 14:29:49 +02:00
Roeland Jago Douma 3ac15a45ea
If there is no UID do not explode accessibility javascript
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-22 11:26:21 +02:00
Joas Schilling 3febeb6ca7
Use lax CSP when the share is a talk share
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-22 10:57:55 +02:00
Daniel Kesselberg 1177ad7bb9
Remove quiet and verbose from Command/Scan
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-21 22:15:10 +02:00
Daniel Kesselberg 816fbf9b9f
Replace $verbose with VERBOSITY_VERBOSE for scanFiles method
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-21 22:15:10 +02:00
Daniel Kesselberg 2422dfe619
Replace $verbose with VERBOSITY_VERBOSE for scanFiles method
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-21 22:06:44 +02:00
Daniel Calviño Sánchez 0426ba6de5 Remove event handler no longer needed
The custom handler for "URL changed" events were added to reload the
file list whenever the sections for favorites and shares were opened;
this was used to fix the problem of not reloading the file lists when
opening them for a second time. However, besides that the handlers were
not really necessary, and as the root of the bug was fixed in the
previous commit those handlers are now removed.

The file list for tags uses the handler for a different purpose, though,
so that one was kept.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-21 20:21:59 +02:00
Daniel Calviño Sánchez 449349e901 Fix opening a section again in the Files app
When a section is open in the Files app a "show" event is triggered.
File list objects handle that event by reloading themselves, but only
if the file list was shown at least once. However, the file list objects
of plugins are created when the "show" event is triggered for the first
time for their section; as the file list objects register their handler
for the "show" event when they are created they never handle the first
triggered "show" event, as the handler is set while that event is being
already handled. Therefore, from the point of view of the handler, the
second time that a "show" event was triggered it was seen as if the file
list was shown for the first time, and thus it was not reloaded. Now the
"shown" property is explicitly set for those file lists that are created
while handling a "show" event, which causes them to be reloaded as
expected when opening their section again.

Note that it is not possible to just reload the file list whenever it is
shown; the file list is reloaded also when the directory changes, and
this can happen when the web page is initially loaded and the URL is
parsed. In that case, if file lists were reloaded when shown for the
first time then it could be reloaded twice, one with the default
parameters due to the "show" event and another one with the proper
parameters once the URL was parsed, and the files that appeard in the
list would depend on which response from the server was received the
last.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-21 20:21:19 +02:00
dependabot[bot] f4353a9acd
Bump webpack from 4.20.2 to 4.22.0 in /apps/oauth2
Bumps [webpack](https://github.com/webpack/webpack) from 4.20.2 to 4.22.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.20.2...v4.22.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-21 11:36:20 +00:00
dependabot[bot] 3ea326f811
Bump webpack from 4.20.2 to 4.22.0 in /apps/accessibility
Bumps [webpack](https://github.com/webpack/webpack) from 4.20.2 to 4.22.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.20.2...v4.22.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-21 11:35:11 +00:00
Roeland Jago Douma f544c9fec9
Merge pull request #11927 from stweil/clean
Remove duplicate condition
2018-10-19 21:15:04 +02:00
Stefan Weil 81c0f2a9a7
Remove duplicate condition
This fixes a warning from LGTM:

    Operands additionnalShares and additionnalShares are identical.

Fix also the typo in the parameter name.
2018-10-19 20:19:08 +02:00
Stefan Weil c5d3febf37
Add missing variable declarations
This fixes errors from LGTM like the following one:

    Variable i is used like a local variable,
    but is missing a declaration.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-19 20:17:55 +02:00
Roeland Jago Douma 543c863434
Merge pull request #11931 from nextcloud/bug/do_not_emit_pre_hooks_twice_objectstore
Do not emit preHooks twice on non-part-storage
2018-10-19 19:56:42 +02:00
Roeland Jago Douma 97717ae3a7
Merge pull request #11905 from nextcloud/design/noid/tab-icons
Add icon to file sidebar tabs
2018-10-19 16:53:56 +02:00
Morris Jobke 851f525889
Merge pull request #11668 from nextcloud/bugfix/7726/convert_caldav_subscription_source_to_long_text
convert source column in calendarsubscription table to (long) text
2018-10-19 15:49:17 +02:00
Morris Jobke 6a979a0ba0
Merge pull request #11823 from lex111/fix-illegible-text-color-in-size-and-modified-columns
Fix illegible text color in columns Size and Modified on dark theme
2018-10-19 15:31:51 +02:00
Roeland Jago Douma b51e503aea
Do not emit preHooks twice on non-part-storage
The old code would emit the hooks twice. Thus having the version written
twice. Which is not very performant as it is first read twice as well.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-19 12:19:53 +02:00
Morris Jobke d35b6513cd
Merge pull request #11922 from stweil/semicolons
Add missing semicolons
2018-10-19 12:07:59 +02:00
Morris Jobke 08476297c3
Merge pull request #11917 from nextcloud/csp/files_external
Move files_external to compiled handlebars
2018-10-19 12:06:42 +02:00
Stefan Weil 2ad38200fb Add missing semicolons
This fixes some recommendations from LGTM:

    Avoid automated semicolon insertion (90% of all statements
    in the enclosing function have an explicit semicolon).

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-19 11:24:24 +02:00
Morris Jobke 1226c13201
Add .l10nignore
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-19 10:41:37 +02:00
Morris Jobke 1b44bdfb58
Add .l10nignore files for compiled assets
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-19 10:29:36 +02:00
Roeland Jago Douma c43e0d6e28
Move files_external to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-19 08:41:01 +02:00
Alexey Pyltsyn 30cbd137e8 Fix illegible text color in columns Size and Modified on dark theme: rework after review
Signed-off-by: Alexey Pyltsyn <lex61rus@gmail.com>
2018-10-18 20:49:46 +03:00
blizzz 5daa4f27e1
Merge pull request #11882 from nextcloud/feature/noid/consider-net-connection
Do not try to contact lookup server without internet connection or URL
2018-10-18 18:24:41 +02:00
Arthur Schiwon 8e4ae23c48
Do not try to contact lookup server without internet connection or URL
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-18 17:49:28 +02:00
Julius Härtl 45804b5bef
Add icon to file sidebar tabs
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-18 15:54:17 +02:00
Jan-Christoph Borchardt 0f299d1077
Revert "Remove negative z-index on thumbnail-wrapper, caused thumbnails to not show"
This reverts commit fb7fb1cebae5af129c4474a380e0f5e55f79569f.

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:11 +02:00
Jan-Christoph Borchardt 8614693e9a
Reduce bottom whitespace on share link page
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:10 +02:00
Jan-Christoph Borchardt 25ae3ea296
More space for filename on public share page since there is no share icon
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:10 +02:00
Jan-Christoph Borchardt d979da3755
In "Deleted files", do not show "Restore" text next to icon as there is no space
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:10 +02:00
Jan-Christoph Borchardt bdfece12b2
Fix tabbability to view-toggle, action on Enter to be fixed
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
Jan-Christoph Borchardt 35ef2b2737
Adjustments for public share page, actions menu, view toggle
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
Jan-Christoph Borchardt c0648efe3a
Remove negative z-index on thumbnail-wrapper, caused thumbnails to not show
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
Jan-Christoph Borchardt 1d486673f6
If there is a comment, show it instead of the share icon
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
Jan-Christoph Borchardt 64607f5491
If an avatar is present, show that instead of the icon
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:08 +02:00
John Molakvoæ (skjnldsv) b532c95162
Border radius
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:08 +02:00
John Molakvoæ (skjnldsv) 1f1dddcc5e
Fix spacing
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:08 +02:00
John Molakvoæ (skjnldsv) 184c1b03e3
Default to grid
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:08 +02:00
John Molakvoæ (skjnldsv) 07224da3d4
Fix focus background
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:08 +02:00
John Molakvoæ (skjnldsv) cd1cfe002d
Improve default visual and selection + default to file link
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:07 +02:00
John Molakvoæ (skjnldsv) 872b866a69
Tooltip
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:07 +02:00
John Molakvoæ (skjnldsv) c4cce14134
Remember toggle and events handler
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:07 +02:00
John Molakvoæ (skjnldsv) 49fda8ba56
Hidden footer
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:06 +02:00
John Molakvoæ (skjnldsv) 4911f06c3e
Loading hidden fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:06 +02:00
John Molakvoæ (skjnldsv) bb56d75f2b
Set grid variable and overall size adjustement
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:06 +02:00
John Molakvoæ (skjnldsv) 5b8dd4d4d6
Fixed multiselect and header
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:05 +02:00
Jan-Christoph Borchardt 39ff82f707
Use grid view in other file views too
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:05 +02:00
Jan-Christoph Borchardt e704899e22
Show view toggle in controls bar
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:05 +02:00
Jan-Christoph Borchardt 2a42a8da3e
Center align the footer file number & size summary
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:05 +02:00
Jan-Christoph Borchardt 32d6090c8b
Fetch high resolution thumbnails for grid view
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:04 +02:00
Jan-Christoph Borchardt 5b293a96f2
Also add border-radius to thumbnail
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:04 +02:00
Jan-Christoph Borchardt 1983f91e29
Fix grey background behind selection checkbox
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:04 +02:00
Jan-Christoph Borchardt 34038136b0
Fix popovermenu position
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:04 +02:00
Jan-Christoph Borchardt 10c96656a2
Adjust design of grid view
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:03 +02:00
John Molakvoæ (skjnldsv) f717bed085
Grid init
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:03 +02:00
Morris Jobke 729b853a30
Merge pull request #11853 from nextcloud/csp/comments
Move more comments to compiled handlebars
2018-10-18 11:40:00 +02:00
Morris Jobke 4e53ea6dbd
Merge pull request #11822 from nextcloud/bugfix/noid/forbid_freebusy_but_allow_local_delivery
allow local delivery of schedule message while prohibiting FreeBusy requests
2018-10-18 11:35:51 +02:00
blizzz 0c05ed1d3d
Merge pull request #11878 from nextcloud/no-require-same-site-cookie-on-assets
Don't require Same Site Cookies on assets
2018-10-18 10:24:56 +02:00
Robin Appelman 9e0ebf1830
store user for trashitem in the trashitem
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-17 15:21:09 +02:00
Robin Appelman 136113a22b
remove user parameter from `ITrashItem::getOriginalLocation`
since the target user is known at the time of creating the trashitem
the original location can already be adjusted on a per user level

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-17 14:58:02 +02:00
Robin Appelman a369adb4cd
fix trash storage wrapper tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-17 14:57:43 +02:00
Robin Appelman b94fbcebeb
fix preview controller tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-17 14:57:40 +02:00
Robin Appelman f5a41e2e15
fix error message for folder preview request
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-17 14:57:37 +02:00
Robin Appelman d38163e895
fix trashbin previews for modular api
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-17 14:56:48 +02:00
Robin Appelman 4adac445dc
fix select statement
fix select statement
Make trashbin api modules

Apps can register trashbin backends for specific storages,
allowing them to modify trashbin behavior for storages

The old trashbin implementation has been wrapped in a "legacy" backend,
for future work this can be replaced with a new backend that better handles
shares while still keeping the legacy backend around to keep existing trash
from being accessible

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-17 14:56:45 +02:00
blizzz 2634ceb35b
Merge pull request #11862 from nextcloud/bugfix/ensure_cache_it_init
Double check for failed cache with a shared storage
2018-10-17 13:12:57 +02:00
Thomas Citharel d63de5471b Don't require Same Site Cookies on assets
Which can be used for public iframe embeeding

See https://github.com/nextcloud/calendar/issues/169

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-10-17 09:24:21 +02:00
Georg Ehrke f5dc7b7f07
move disableFreeBusy check from User principal backend to Scheduling Outbox collection. This allows to keep local delivery of scheduling messages while prohibiting FreeBusy requests
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-16 20:27:33 +02:00
Alexey Pyltsyn 5911367a18 Fix illegible text color in columns Size and Modified on dark theme
Signed-off-by: Alexey Pyltsyn <lex61rus@gmail.com>
2018-10-16 21:06:01 +03:00
Morris Jobke b88ab75c3a
Merge pull request #11870 from nextcloud/fix/noid/proper-column-name-escaping
Properly quote column name in "createFunction" call
2018-10-16 17:02:26 +02:00
Morris Jobke b458ed9c82
Properly escape column name in "createFunction" call
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-16 15:24:02 +02:00
Roeland Jago Douma 2849f24154
Merge pull request #11839 from nextcloud/csp/files_drop
Move files_drop to compiled handlebars
2018-10-16 12:16:31 +02:00
Roeland Jago Douma 1bc388e507
Double check for failed cache with a shared storage
When obtaining the SourceRootInfo we can call init. If this fails the
cache is set to a failed cache and the storage to a failed storage.
However we did not check for this. Which means that if the storage was
invalid it would fail later on.

Now we will properly error out.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-16 10:57:37 +02:00
Morris Jobke afaee648dd
Merge pull request #11358 from Zulan/fix-welcome-l10n
Fix welcome l10n
2018-10-16 09:01:59 +02:00
Roeland Jago Douma bee5bbbf0e
Move files_drop to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-16 08:27:06 +02:00
Roeland Jago Douma 353fddfbb9
Merge pull request #11849 from nextcloud/csp/fileactionsmenu
Move fileactionsmenu to compiled handlebars
2018-10-15 21:22:07 +02:00
Roeland Jago Douma e7443ee892
Move more comments to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-15 19:52:22 +02:00
Julius Härtl c316eb6b97
Tests: Properly compare the file action label
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-15 19:18:20 +02:00
zulan cf266ee004 Get l10n within NewUserMailHelper to ensure it always uses the new user's language.
Some related tests had to be changed because they relied on internals, see also from the PHPUnit documentation:
"Exercise caution when using [the at] matcher as it can lead to brittle tests which are too closely tied to specific implementation details."

Signed-off-by: Zulan <git@zulan.net>
2018-10-15 19:01:46 +02:00
Roeland Jago Douma a1b7449202
Move fileactionsmenu to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-15 15:51:40 +02:00
Roeland Jago Douma 8c4c4b700f
Move workflowengine to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-15 14:55:25 +02:00
Georg Ehrke b83918ed6d
convert source column in calendarsubscription table to (long) text
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-15 13:16:31 +02:00
Morris Jobke 24a2107e03
Fix a case where "password_by_talk" was not a boolean (e.g. null or "0") and actively cast it to a boolean
This was the error message that we have seen:

```
Argument 1 passed to OC\\Share20\\Share::setSendPasswordByTalk() must be of the type boolean, null given, called in apps/sharebymail/lib/ShareByMailProvider.php on line 981
```

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-12 17:01:54 +02:00
Joas Schilling 16817f3743
Make activity events strict
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-12 12:12:12 +02:00
Morris Jobke b5753d0efa
Merge pull request #11759 from nextcloud/feature/11504/sharing-favicon
Use default favicon on sharing pages
2018-10-12 10:30:21 +02:00
Robin Appelman ee84d83519
move versions webui over to the dav api
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-11 20:42:41 +02:00
Roeland Jago Douma dd8350b3b3
Merge pull request #10778 from suntorytimed/patch-1
check for empty string
2018-10-11 19:05:38 +02:00
Julius Härtl 2538079876
Use default favicon on sharing pages
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-11 16:29:24 +02:00
Morris Jobke 0acae1d4aa
Merge pull request #11719 from nextcloud/techdebt/noid/allow-to-mock-new-datetime
Allow to inject/mock `new \DateTime()` similar to time()
2018-10-10 14:54:15 +02:00
Felix Nüsse 8dc449990d fix for favorites-quickaccess: newly added folders dont show up when added to favorites
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2018-10-10 13:33:44 +02:00
Joas Schilling 78cc4171ee
Fix mock of ITimeFactory
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-10 12:42:20 +02:00
Nextcloud bot 7c26bbbd82
[tx-robot] updated from transifex 2018-10-10 00:13:11 +00:00
Morris Jobke ab3599155f
Merge pull request #11716 from nextcloud/bugfix/noid/use-numeric-placeholders-for-rtl-translations
Use numeric placeholders if there are multiple, so that RTL languages…
2018-10-09 16:31:52 +02:00
Morris Jobke ddfc362779
Revert "in 14 the click action gets lost in the Backbone view." 2018-10-09 15:33:01 +02:00
Morris Jobke 877823eb9d
Merge pull request #11709 from nextcloud/refactor/jquery-beforeunload
Fix depracted jQuery.bind call
2018-10-09 14:48:42 +02:00
Joas Schilling ea21aa3f7a
Use numeric placeholders if there are multiple, so that RTL languages can operate better
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-09 14:32:14 +02:00
Christoph Wurst 9af69ca2a5
Fix usage of deprecated OC.webroot
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-09 13:53:59 +02:00
Christoph Wurst 912729c427
Fix depracted jQuery.bind call
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-09 12:00:48 +02:00
Nextcloud bot d07c5db947
[tx-robot] updated from transifex 2018-10-09 00:12:27 +00:00
Roeland Jago Douma 1178e85206
Merge pull request #11664 from nextcloud/feature/noid/has-been-interrupted-throw-exception
Syntactic sugar for hasBeenInterrupted
2018-10-08 21:31:29 +02:00
Morris Jobke 6994a2a87d
Merge pull request #11679 from nextcloud/refactor/remove-ie8-apis
Remove IE8 APIs
2018-10-08 18:36:07 +02:00
Morris Jobke 2a9e006355
Merge pull request #11518 from nextcloud/feature/noid/save-s3-requests
S3 reuse information from listObject and skip headObject
2018-10-08 18:28:38 +02:00
Morris Jobke 3330600dc5
Merge pull request #11682 from nextcloud/refactor/remove-deprecated-unused-fileDownloadPath
Remove deprecated and unused fileDownloadPath
2018-10-08 18:04:08 +02:00
Morris Jobke 5d83645a00
Merge pull request #11680 from nextcloud/refactor/remove-deprecated-svg-apis
Remove deprecated SVG helpers for old IEs
2018-10-08 17:30:14 +02:00
Morris Jobke c4ac9bcea2
Merge pull request #10782 from nextcloud/fix/10774/deadtagaction
in 14 the click action gets lost in the Backbone view.
2018-10-08 17:14:00 +02:00
Morris Jobke fe2a600823
Merge pull request #10839 from nextcloud/bugfix/10212/use_class_implementation
adjust Calendar resource / room interfaces to use class implementation
2018-10-08 17:00:50 +02:00
Christoph Wurst 576e44f890
Remove deprecated and unused fileDownloadPath
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-08 16:46:36 +02:00
Daniel Kesselberg 4cbea5f7e1
Remove value from cache on delete/clear
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-08 16:40:39 +02:00
Christoph Wurst dccb3ab5b2
Remove deprecated SVG helpers for old IEs
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-08 16:33:41 +02:00
Christoph Wurst dd459bbb7a
Remove OC.scaleFixForIE8
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-08 16:17:16 +02:00
Morris Jobke 8110a3be69
Merge pull request #11599 from nextcloud/feature/7136/workflow-engine-filename
Add FileName to Workflow engine
2018-10-08 13:57:57 +02:00
Daniel Kesselberg 311de17730
Rename method to abortIfInterrupted
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-08 13:05:00 +02:00
Daniel Kesselberg be5e992021
Fix typo
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-08 13:02:12 +02:00
Morris Jobke 7971ba5cc6
Merge pull request #10898 from nextcloud/feature/10684/default-logo-color-theme-colors
Switches the default logo color depending on the primary color
2018-10-08 10:33:22 +02:00
Nextcloud bot 80f7add485
[tx-robot] updated from transifex 2018-10-08 00:12:54 +00:00
Georg Ehrke 1c6f666bbf
adjust Calendar resource / room interfaces to use class implementation
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-08 01:25:20 +02:00
Daniel Kesselberg 752f637207
Adjust code for changed method signature
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-07 18:17:29 +02:00
Nextcloud bot 4c47ec005f
[tx-robot] updated from transifex 2018-10-07 00:12:21 +00:00
Nextcloud bot 7dd2212b2c
[tx-robot] updated from transifex 2018-10-06 00:12:15 +00:00
Daniel Kesselberg 28fc7b5061
Ignore case for is and !is
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-05 17:54:48 +02:00
Nextcloud bot d9fe68ed12
[tx-robot] updated from transifex 2018-10-05 00:12:56 +00:00
Michael Weimann 044ab0cbec
Adapts the theming util to the new core logo image path
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-10-04 20:43:27 +02:00
Daniel Kesselberg 37ae5cb100
Change placeholder
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-04 17:59:29 +02:00
Daniel Calviño Sánchez 53aad9901d Make possible for tab views to add CSS classes to their container
In general the style of the tabs container should not change depending
on which tab is the currently selected one. However, this could be
needed in some very specific cases, so now the tab views can specify the
extra CSS classes to be used in their container when they are selected.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-04 17:56:23 +02:00
Roeland Jago Douma 363ec1d3c3
Remove leftover '
Followup to #11583

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-04 16:02:09 +02:00
Daniel Kesselberg 4c4f50ee2d
Remove unused import
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-04 14:23:45 +02:00
Roeland Jago Douma 13b1cd5cb8
Allow userId to be null
Fixes #10852

A quick hack. Still ensures some type safety however now also accepts
null. Else we'd need to add a whole new layer of middlewares.

This can only happen when a guest user wants to access a controller that
requries the user_id.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-04 13:04:58 +02:00
Roeland Jago Douma 1161b838d7
Move newfilemenu to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-04 09:55:05 +02:00