Commit Graph

7666 Commits

Author SHA1 Message Date
Roeland Jago Douma c8c4ce2da5
Bump strengthify to 0.5.3
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-10 21:48:24 +01:00
Daniel Calviño Sánchez 58d00bf6fb Fix password displayed as username in Firefox password manager dialog
When finishing the setup of Nextcloud through the WebUI (setting admin
user and database) Firefox offers to save the username and password.
However, the password was shown in both the username and password fields
of the Firefox password manager dialog.

The problem was that the password input element (in the HTML form) is
cloned in a text input element, which is used to show the password in
plain text when clicking on the "Show password" button. As it was a text
input immediately followed by a password input Firefox seemed to assume
that it had to be the username and ignored the real username field, no
matter the value set for the "autocomplete" attribute. Now the cloned
text input is added after the password input, so Firefox no longer
thinks that the cloned text input is the username field and the password
manager dialog shows the proper username instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-05 02:45:34 +01:00
Morris Jobke 08dbcd238d
Merge pull request #7696 from nextcloud/fix-appmenu-height
Fix small issues with the app menu
2018-01-04 17:55:21 +01:00
Roeland Jago Douma 82f03e1314
Clear login token once apppassword is generated
Fixes #7697

When using the new login flow a token will be generated since we login.
However after that we generate yet another token to return (as we
should).

However we should kill the current session token as we are done with it.
And will never use it again.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-04 14:30:40 +01:00
Julius Härtl a3753193ef
Fix popover shadow in app menu
Make sure the app menu popover shadow does overlay the active indicator

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-04 12:33:10 +01:00
Julius Härtl 738c144a21
Fix app menu popover alignment
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-04 12:32:22 +01:00
Morris Jobke d984c4cdf1
Merge pull request #7693 from splitt3r/fix-js-type-hint
Fixed js typehint for showHtml method
2018-01-04 11:01:02 +01:00
Nextcloud bot 298b79410d
[tx-robot] updated from transifex 2018-01-04 09:48:31 +00:00
splitt3r 6ca7a3e650 Fixed js typehint for showHtml method 2018-01-04 10:05:15 +01:00
Morris Jobke 19280adc0d
Merge pull request #7611 from nextcloud/fix-7445
Don't attempt to translate login names to uids when uids are provided
2018-01-03 23:45:31 +01:00
Roeland Jago Douma 62d71158a9
Merge pull request #7680 from nextcloud/fix-7609
format links in comments
2018-01-03 16:59:08 +01:00
Julius Härtl 63b4d7e183
Remove css invert since we are using svg filters for now
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-03 14:42:08 +01:00
Julius Härtl 8a226811dc
Invert app icons on IE11 as well
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-03 14:42:07 +01:00
Morris Jobke b4a473869e
Add margin around inline links
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-03 14:09:10 +01:00
Arthur Schiwon 4f3d52a364
never translate login names when requiring with a user id
where appropriate, the preLoginNameUsedAsUserName hook should be thrown.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-03 13:25:00 +01:00
Arthur Schiwon 282567fced
format links in comments
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-03 13:11:20 +01:00
blizzz 02b092f358
Merge pull request #7487 from nextcloud/no-password-confirm-with-sso
disable password confirmation with SSO
2018-01-03 11:48:45 +01:00
Julius Härtl c7fbf4dfb1
Fix logo URL in SCSS variables
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-03 09:32:33 +01:00
Morris Jobke 9d43724d45
Merge pull request #7526 from nextcloud/make-possible-for-apps-to-disable-the-navigation-bar-slide-gesture
Make possible for apps to disable the navigation bar slide gesture
2018-01-03 00:12:54 +01:00
Bjoern Schiessle 1bcbeb24bc
disable password confirmation with SSO
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-01-02 20:30:37 +01:00
Julius Härtl f5f6ed664d
Hide stay logged in checkbox when flow authentication is used
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2017-12-28 11:15:26 +01:00
John Molakvoæ d0e7b0d8c3
Merge pull request #7478 from nextcloud/breadcrumbs-buttons-fixes-gallery
Fixed breadcrumbs calculation and actions flow
2017-12-22 09:11:16 +01:00
Morris Jobke 0b8a9fcaea
Merge pull request #7572 from nextcloud/fix-box-shadow
Fix box shadow of header elements
2017-12-20 13:52:53 +01:00
John Molakvoæ (skjnldsv) 3105a2780b
zindex fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-12-20 13:50:44 +01:00
Morris Jobke 0fef608927
Add the webkit sticky position prefix
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-20 13:48:09 +01:00
Marin Treselj eebc70cf1e
Make contorls stick to the top when scrolling
Signed-off-by: Marin Treselj <marin@pixelipo.com>
2017-12-20 13:48:09 +01:00
Marin Treselj 228ca16bea
Dynamic control bar width
Signed-off-by: Marin Treselj <marin@pixelipo.com>
2017-12-20 13:48:09 +01:00
Morris Jobke f854831045
Fix box shadow of header elements
* unify shadow blur from 3px to 10px
* remove opacity of background of app labels
* for IE: use box-shadow as fallback (because the filter: drop-shadow is not supported)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-20 11:45:21 +01:00
Roeland Jago Douma 325637f4f3
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-19 18:49:27 +01:00
Roeland Jago Douma 328047f638
Also do callback on the failing function
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-19 18:49:26 +01:00
Julius Härtl d497f79625
Fix fallback when image loading fails
With the new avatar endpoint there is no difference between unknown
users and errors when generating the placeholder avatar. Therefore the
avatar function will now show the old placeholder if both a user and
displayname was given as parameters.

In case there is no displayname provided we cannot build the proper
placeholder so the unknown user placeholder is shown.

The displayname is not required for the avatar anymore, so we can
get rid of the old code path for placeholders.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-19 18:49:26 +01:00
Roeland Jago Douma 6b5e3a9365
Still call callback once avatar is loaded
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-19 18:49:26 +01:00
John Molakvoæ (skjnldsv) a118817a69
Add loading icon on avatar
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-12-19 18:49:26 +01:00
Roeland Jago Douma 6371b76598
Since we now always generate an avatar do not load the placeholder
The js and php code differ ever so slightly. So having the placeholder
for a second and then the image is just weird.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-19 18:49:25 +01:00
blizzz b6fcf59881
Merge pull request #7576 from nextcloud/fix_7574
Use javascript to send the actual password reset
2017-12-19 18:05:14 +01:00
Roeland Jago Douma cdaf99cf58
Use javascript to send the actual password reset
Fixes #7574

During some refactoring the event linked to password reset got removed.
This ment that we just submitted a normal POST but without the CSRF
token. And none of the js magic to redirect afterwards.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-19 14:00:47 +01:00
Daniel Calviño Sánchez 48b62a0eee Fix opening the menu in a Share page
".popovermenu" elements are visible or not depending on whether they
also have the "open" CSS class or not. "#header .menu" elements were
always hidden, so when both rules applied to the same element, like in
the menu of a Share page, the element was always hidden due to
"#header .menu" being more specific than ".popovermenu" and thus
overriding its rules. Now, "#header .menu" elements are hidden only if
they are not a ".popovermenu" too.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-19 06:58:58 +01:00
Roeland Jago Douma e294323df2
Merge pull request #7517 from nextcloud/add-index-to-share-table
Add index to share_with column in the share table
2017-12-18 22:23:53 +01:00
Roeland Jago Douma a84d11de7b
Merge pull request #7531 from nextcloud/ldap/createdistributed
don't use deprecated method for requesting memcache
2017-12-18 22:08:32 +01:00
Bjoern Schiessle 41ee23a054
make occ command more generic
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-12-18 21:14:45 +01:00
Bjoern Schiessle de98581421
add index for share_with table for newly created tables
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-12-18 21:14:45 +01:00
Bjoern Schiessle fda98ee917
add occ command to add a index to share_with at the share table
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-12-18 21:14:45 +01:00
Morris Jobke d2d73f1ce8
Also replace all other occurences
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-18 20:57:11 +01:00
Roeland Jago Douma d6e74fe375
Use injected AppManager
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-18 20:26:44 +01:00
Daniel Calviño Sánchez de4028336a Force the drag to end when the navigation bar Snap is disabled by an app
When a Snap was disabled it stopped listening to the events, but if a
drag gesture was being performed it was kept as active. Thus, when the
Snap was enabled again move events were handled as if the Snap had never
been disabled, causing the gesture handling to continue where it was
left.

When the Snap for the navigation bar is disabled by an app it could be
as a result of a different gesture being recognized by the app (for
example, a vertical swipe) once both gestures have started. In that case
when the other gesture ends and the Snap is enabled again any pointer
movement will cause the navigation bar to slide until an "up" event is
triggered again (obviously not the desired behaviour).

Due to all this now when the Snap for the navigation bar is disabled by
an app the current drag gesture for the navigation bar is ended.

Note that this was added as a parameter to "Snap.disable()" instead of
done unconditionally to keep back-compatibility with the previous
behaviour (probably not really needed as it is unlikely that any app is
using the Snap library relying on that behaviour... but just in case).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-14 21:42:39 +01:00
Daniel Calviño Sánchez a5db0d2825 Make possible for apps to disallow the navigation bar slide gesture
On narrow screens a slide gesture can be used to open or close the
navigation bar. However that gesture could conflict at times with the
gestures used by certain apps (for example, if the right sidebar is open
the user may expect to close it by dragging it to the right, but that
could open the navigation bar instead depending on how the events are
handled). This commit makes possible for apps to disallow and allow
again that slide gesture.

In any case, note that applications can only disallow the gesture,
but they can not enable it. That is, they can prevent the gesture from
being used on narrow screens, but they can not make the gesture work on
wide screens; they are always limited by the base rules set by the core.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-14 21:41:22 +01:00
Daniel Calviño Sánchez 173f28a09d Add unit tests for the navigation bar slide gesture
The slide gesture is enabled or disabled depending on the width of the
browser window. In order to easily control that width the karma-viewport
plugin is now used in the unit tests.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-14 19:17:40 +01:00
Morris Jobke 784d256103
Merge pull request #7480 from nextcloud/fix_7454
Check for FreeType functions required for avatars
2017-12-13 18:25:05 +01:00
Roeland Jago Douma ee20741526 Add tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-13 17:22:58 +01:00
Roeland Jago Douma 7618473a44 Add warning regarding freetype support
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-13 17:20:48 +01:00