a223f603f9
Simplify the check if admin can change password based on encryption status
...
Found by Psalm:
```
/home/runner/work/server/server/apps/settings/lib/Controller/UsersController.php:324:8:error - RedundantCondition: Type true for $isEncryptionModuleLoaded is never falsy
```
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-05 22:20:34 +01:00
9435ec2b4e
Remove unneeded service - found by Psalm
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 10:06:33 +01:00
1c496a5a35
Add a background job that checks for potential user imported SSL certificates and shows a warning in the admin settings
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 10:06:33 +01:00
830348dbee
Add SVG support check to setup check
...
Signed-off-by: nhirokinet <nhirokinet@nhiroki.net>
2020-11-02 11:29:08 +01:00
e2e7c2d014
Document settings BeforeTemplateRenderedEvent
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-29 11:15:31 +01:00
b8ed997238
Remove ISection in favor of IIconSection
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-28 23:05:00 +01:00
28d82394f1
Merge pull request #23720 from nextcloud/lowercase-email
...
save email as lower case
2020-10-27 20:14:43 +01:00
cbd6e65678
save email as lower case
...
email addresses are case insensitive
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-27 14:56:52 +01:00
60efad45cf
Update CheckSetupController.php
2020-10-26 09:42:01 +01:00
0dbb99a81b
Merge pull request #23161 from nextcloud/enh/noid/setup-checks2
...
Remove setup check for php mail
2020-10-08 22:40:37 +02:00
d9015a8c94
Format code to a single space around binary operators
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +02:00
9c8e8007f9
Remove setup check for php mail
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-10-03 21:58:55 +02:00
68ce17e59b
Unify links to php.net
...
Update all links to https://www.php.net/
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-09-17 17:40:04 +02:00
05edd1e5d6
Merge pull request #22890 from nextcloud/techdebt/18680/help-static-code-analysis-understand-code
...
Help static code analysis to understand code
2020-09-17 08:51:20 +02:00
096fe20611
Help static code analysis to understand code.
...
It adds proper type hints to private namespace to allow private namespace methods.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-09-16 16:37:17 +02:00
d3680e682a
Remove not needed semicolon and PHPDoc hint
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 16:18:43 +02:00
f959828616
emit typed event for user management
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-08 22:50:05 +02:00
0e6344f543
Merge pull request #22650 from nextcloud/fix/noid/fix-psalm-warning
...
Only load viewer in settings if the viewer app is enabled
2020-09-07 20:41:49 +02:00
ce1e873a0a
Only load viewer in settings if the viewer app is enabled
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-07 20:25:57 +02:00
1f7f93a695
Update license headers for Nextcloud 20 (again)
...
There are still lots of outdated headers, so time for another round of
updates.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-09-07 14:37:44 +02:00
4c48d6bf18
Add 'Reasons to use Nextcloud in your organization' call to action in settings
...
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2020-09-07 08:30:01 +02:00
7a1748e6f0
Show changelog in apps management
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-09-03 19:16:13 +00:00
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
b09620651c
Don't use deprecated getIniWrapper() anymore
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-20 16:35:38 +02:00
da584462d1
Merge pull request #22018 from nextcloud/bugfix/noid/harden-key-generation
...
Harden SSE key generation
2020-08-19 20:42:34 +02:00
603d7dab5e
Add setup check that links to the migration documentation
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 15:45:45 +02:00
d7f66c36ac
Fix "misplaced variables" warning of Psalm in PHPDoc statements
...
Ref #21787
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-17 17:46:57 +02:00
36cfdd320b
Harden key generation
...
There might be cases where multiple requests trigger the key generation
at the same time and the instance ends up with a non-fitting
public/private key pair. Therefore the whole key generation should be
locked. Other than that this makes sure that user key generation return
values are properly validated.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-14 07:58:40 +02:00
93ba8faabc
Fix name of app config option to properly reflect what it does
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 13:34:31 +02:00
53fab3fe5f
Add app config option to disable "Email was changed by admin" email
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-12 12:27:43 +02:00
326a04d12c
Merge pull request #22004 from nextcloud/enh/noid/setup-checks-php
...
Add setup checks for php default charset and output buffering.
2020-08-07 20:55:04 +00:00
2aa6256f38
Merge pull request #22102 from nextcloud/feature/noid/app-navigation-via-unified-search
...
App navigation via unified search
2020-08-05 22:53:03 +02:00
d2c0569b49
Fix search providers order and IDs
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-05 17:57:17 +02:00
99fbaa9cba
Very top of the tops
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-05 17:51:18 +02:00
5be04942e7
Hide navigation links which dont lead anywhere (looking at you user status)
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-05 17:50:20 +02:00
fcdd702040
App navigation via unified search
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-05 16:42:36 +02:00
ea8f68bea6
Hand in the route and the parameters of the request
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-08-05 12:52:16 +00:00
d98f7c1bd8
Make apps handle the order logic
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-05 11:37:45 +02:00
71b62c4203
Show mime icon, bump bundles, make the SearchResultEntry class non-abstract, Fix header search icon, various fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-04 21:36:22 +02:00
5d41a3f9a2
Add settings sections to unified search
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-03 17:03:06 +02:00
89c6a2bc1f
Add setup checks for php default charset and output buffering.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-07-26 00:54:16 +02:00
7870ca0663
Use the proper IAppContainer and IServerContainer type hints to know which code runs with which container
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-21 20:44:05 +02:00
91e7f12088
Adjust apps' code to use the ContainerInterface
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-21 20:43:18 +02:00
090a54adab
Migrate settigns to the PSR container
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 15:55:04 +02:00
2ad95feab6
Merge pull request #21816 from nextcloud/techdebt/noid/federatedfilesharing-to-ibootstrap
...
Use IBootstrap for the app federatedfilesharing
2020-07-14 20:44:05 +02:00
7e281a07bb
Use IBootstrap for the app federatedfilesharing
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-14 16:34:43 +02:00
fa9dfd83c9
Fix AppFramework services
...
* We can't just register an alias as the services need the appId to be
injected. if we just register an alias this blows up since the main
container doesn't have the appId.
* Moved the Authtokens over to show the PoC works
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-14 16:01:14 +02:00
54d36c047b
Merge pull request #21741 from nextcloud/debt/noid/url-generator-does-not-implement-i-user-session
...
Fix type for $urlGenerator
2020-07-08 09:06:56 +02:00
ba0ef74c06
Fix type for $urlGenerator
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-07-08 09:06:29 +02:00
4d8b4ef3cc
Merge pull request #21533 from nextcloud/techdebt/noid/dedicated-method-to-get-a-users-language
...
Techdebt/noid/dedicated method to get a users language
2020-07-04 08:56:13 +02:00
db8267db26
Use the new method everywhere
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-03 10:59:43 +02:00
87dd760a89
Replace TYPE with TYPES
...
As TYPE::* is deprecated.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-06-30 23:46:22 +02:00
6e46df26a8
Unify settings middleware with others
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 20:18:38 +02:00
c5d2958ac7
Migrate Settings to new bootstrap mechanism
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-17 09:22:22 +02:00
ce7a15e804
Merge pull request #21274 from nextcloud/bug/21268/paswordless-for-everyone
...
Enable passwordless for everyone not only admins.
2020-06-07 15:04:47 +02:00
8325ab4bf0
Merge pull request #21224 from nextcloud/techdebt/noid/remove-unreachable-controller-and-route
...
Remove controller and routes which have no UI component anyway
2020-06-07 10:42:19 +02:00
761a7bf6a2
Enable passwordless for everyone not only admins.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-06-06 21:34:49 +02:00
d1b43d4fc2
Use \OC::$CLI instead of PHP_SAPI
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-06-04 11:31:09 +02:00
7dcb1cdb42
Remove controller and routes which have no UI component anyway
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-04 10:41:08 +02:00
653162a709
use the loginname to verify the old password in user password changes
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-26 16:53:25 +02:00
fce716b905
Fix languages empty array
...
Signed-off-by: GretaD <gretadoci@gmail.com>
2020-05-08 10:03:58 +02:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
19171d77e2
Merge pull request #19191 from laurisb/patch-1
...
Improve Opcache detection
2020-04-15 11:03:05 +02:00
a307d82e1d
Merge pull request #20427 from nextcloud/bug/noid/fix-password-reset-activity
...
Fix password reset saying Admin changed my password when reset from login page
2020-04-13 13:15:49 +02:00
1cc793888f
Merge pull request #20421 from nextcloud/fix/20393/recommendend_webauthn_mods
...
Show setup check for recommended php modules
2020-04-12 15:56:10 +02:00
18e8af4bb8
Fix password reset saying Admin changed my password when reset from
...
login page
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-10 18:05:43 +02:00
28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
a7c8d26d31
Add visibility to all properties and move static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:48:31 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
75836f004d
Show setup check for recommended php modules
...
Fixes #20393
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-10 13:25:12 +02:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
2a529e453a
Use a blank line after the opening tag
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:50:14 +02:00
41b5e5923a
Use exactly one empty line after the namespace declaration
...
For PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +02:00
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
85e369cddb
Fix multiline comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +02:00
bc6a5ef5c4
Merge pull request #19890 from nextcloud/enh/comments-reference-id
...
Add optional comments reference_id
2020-04-02 11:34:21 +02:00
19ca921676
Merge pull request #20241 from nextcloud/fix/license-headers-19
...
Update the license headers for Nextcloud 19
2020-04-01 12:44:21 +02:00
53db05a1f6
Start with webauthn
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-03-31 22:17:07 +02:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
720dc4e93d
Add optional column oc_comments.reference_id
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-31 10:51:15 +02:00
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
...
Remove unused imports
2020-03-27 17:14:08 +01:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
74936c49ea
Remove unused imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +01:00
3b26bfe879
Merge pull request #20127 from nextcloud/bugfix/noid/check-user-on-remote-wipe
...
Check the user on remote wipe
2020-03-24 20:26:52 +01:00
b0ea022a3e
Add basic reverseproxy misconfig detection to setupchecks
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-03-23 10:37:08 +01:00
381decca49
Add setting to restrict user enumeration to groups
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-20 10:43:55 +01:00
73643fe70b
Make sure app_install_overwrite is an array
...
otherwise in_array will complain.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-03-16 22:33:47 +01:00
9935c71ec3
Check the user on remote wipe
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-16 09:29:28 +01:00
c8a360cd7a
Merge pull request #19580 from nextcloud/debt/noid/outdated-check
...
Update check for outdated php version.
2020-03-10 20:10:54 +01:00
f65e36a70c
Hide development notice when subscription is valid
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-06 13:08:23 +01:00
d47daefe38
Revive the "send email to new users" toggle for the user form
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-02-28 14:01:03 +01:00
f228d73b38
Update check for outdated php version.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-02-24 20:14:13 +01:00
8e8e912015
Make sure quota_preset is using numerical indexes
...
If one set quota_present to "default, none, 1 GB, 5 GB, 10 GB" the old implementation will remove default and none but keep the array indexes. Later json_encode will recognize a array with 2 as first index as object and hence quotaPreset.reduce will fail.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-02-22 20:06:16 +01:00
f464f2313f
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-10 10:14:02 +01:00
bf74c4f21b
Warn admins about delayed cron executions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-08 10:21:54 +01:00
af8ad96285
Use the l10n from settings
...
Fixes #19261
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-02-03 09:44:59 +01:00
bfaf3fff33
Move Admin Settings also to info.xml
...
More cleanup of the Settings apps. Makes the manager cleaner and a
proper manager.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-31 16:55:17 +01:00
b68cb1fc0c
Use activity registration for the settings
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-31 15:12:32 +01:00
c9253cce6c
Move personal settings to proper registration
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-30 22:06:28 +01:00
Morris Jobke
nhirokinet
Roeland Jago Douma
Robin Appelman
timm2k
Christoph Wurst
Daniel Kesselberg
J0WI
Arthur Schiwon
Jan C. Borchardt
Julius Härtl
Joas Schilling
John Molakvoæ (skjnldsv)
Roeland Jago Douma
Thomas Citharel
GretaD
Joas Schilling
Christoph Wurst