14acded171
Make sure the file is readable before attempting to create a preview
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-30 11:34:02 +02:00
9ddff6ff35
Merge pull request #9617 from nextcloud/users-sort-case-fix
...
Ignore case when sorting users
2018-05-28 15:52:37 +02:00
ad6e548411
Added case example to tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-26 12:07:49 +02:00
441cedf1df
Fix Settings\ManagerTest
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-25 10:41:17 +02:00
e1af2f4766
Rename sync clients section to mobile & desktop
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-24 15:06:28 +02:00
84482eb25a
Merge pull request #9435 from nextcloud/bugfix/noid/fix_force_language_html_attr
...
make sure force language is reflected in html lang attribute
2018-05-23 23:45:24 +02:00
bc34a7f4e9
Get rid of shareItem
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-05-23 19:51:37 +02:00
9c23c7c821
Fix ViewTest
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-23 19:12:51 +02:00
2a21471c74
make sure force language is reflected in html lang attribute
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-05-22 19:30:25 +02:00
4f5814c27b
tests
...
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
2018-05-21 01:24:45 +02:00
4a3471595a
test: add unit test for files:scan --shallow
...
Signed-off-by: Yuze Chi <i@blaok.me>
2018-05-18 14:51:08 -07:00
6b7cf46727
Certain tokens can expire
...
However due to the nature of what we store in the token (encrypted
passwords etc). We can't just delete the tokens because that would make
the oauth refresh useless.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-17 16:10:19 +02:00
aba255997a
Allow the rotation of tokens
...
This for example will allow rotating the apptoken for oauth
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-16 19:27:19 +02:00
991d9b5c3a
Fix session tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-15 11:32:25 +02:00
466297829e
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-15 10:56:40 +02:00
0dffd07a60
Add tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-14 13:30:22 +02:00
362e6b2903
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-14 13:30:22 +02:00
d161d4473e
Merge pull request #9029 from nextcloud/settings-restructure
...
Restructure server settings
2018-05-07 12:29:53 +02:00
0ff83f7230
Do not allow folder creation with quota of 0
...
Fixes #4577
Users with a quota of 0 are a special case. Since they can't (ever)
create files on their own storage. Therefor it makes no real that they
can create folders (and possible share those etc).
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-03 11:31:23 +02:00
35cb529df3
Fix settings tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:25 +02:00
9bfc108b79
Cleanup and fix tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:24 +02:00
aff5fe68b3
use SystemConfig, less dependencies, and not publicly needed
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 23:54:11 +02:00
0e6a317516
revert Log's dependency to SystemConfig to work during Installation
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 12:10:53 +02:00
cfc3ab0119
offer API to create own File log. admin_audit makes use of it
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 12:10:52 +02:00
5fbf184134
destaticfy Log classes
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 12:00:06 +02:00
38a90130ce
move log constants to ILogger
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 10:45:52 +02:00
0ed6f9c2da
Merge pull request #9129 from nextcloud/feature/noid/proper-comments-offset
...
Add proper comment offset support
2018-04-22 20:47:30 +02:00
9f4e928c0f
Merge pull request #9225 from nextcloud/bugfix/9157/ipv6-database-host
...
Allow IPv6 database hosts
2018-04-22 20:43:29 +02:00
cccdfaa6e9
Fix FakeManager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-04-19 17:12:07 +02:00
a4cb83df27
Add tests for special domain name
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-19 13:59:08 +02:00
d686b19a16
Add tests for domains
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-19 13:58:02 +02:00
78ee3abb78
Move regex to a function and add tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-04-19 12:49:36 +02:00
f50abde7ac
Add proper comment offset support
...
The offset is based on the last known comment instead of limit-offset,
so new comments don't mess up requests which get the history of an object-
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-04-18 14:23:15 +02:00
46d0d0cda1
fix appinfo parsing when a single localized option is provided
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-17 11:14:03 +02:00
9ee1febf62
Provide an option to disable HTML emails
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-16 19:00:05 +02:00
89a9d35d90
dont keep shared database locks when running cli scripts
...
For cli scripts we don't have the assumption that the universe will be cleaned up soon
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-11 19:21:45 +02:00
88c1b8edbd
Merge pull request #9024 from nextcloud/fix/app-fetcher-major-minor-versions
...
Fix version comparison with minor and patch level requirements
2018-04-11 15:48:23 +02:00
7a3ce073da
Merge pull request #8946 from nextcloud/log-exceptions-as-nested-array-2
...
Log exceptions as nested array instead of encoded json
2018-04-11 14:24:47 +02:00
185a260f6b
Merge pull request #9074 from nextcloud/ARGON2I
...
Add ARGON2I support to the hasher
2018-04-11 11:04:42 +02:00
ac939e8fd4
Fix version comparison with minor and patch level requirements
...
If an app requires a specific minor or path level server version,
the version_compare prevented the installation as only the major
version had been compared and that checks obviously returns `false`.
Now the full version is used for comparison, making it possible to
release apps for a specific minor or patch level version of Nextcloud.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-04-11 10:08:23 +02:00
b9583c6dce
Log exceptions as nested array instead of encoded json
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-10 15:53:43 +02:00
8b9bd37e4e
Fixed tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-09 15:13:11 +02:00
84316aec66
Add ARGON2I support to the hasher
...
When on php7.2 we can use the new and improved ARGON2I hashing.
This adds support for that to the hasher. When verifying an old hash
we'll update rehash to move all hashes eventually to the new hash
function.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-04 15:43:50 +02:00
73e6eea57e
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-04 12:50:54 +02:00
c3900c9d0d
Merge pull request #9018 from nextcloud/fix-copy-encrypted-files
...
reset encryptionVersion to '1' if a file was stream copied
2018-04-03 18:24:27 +02:00
a0923d9ffb
reset encryptionVersion to '1' if a file was stream copied, because this means that we basically write the file from scratch
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-04-03 18:01:23 +02:00
1d7b14dfb1
Use app version to generate scss filename
...
Fixed scsscacher tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-28 08:33:46 +02:00
af31fa82e8
Fix test
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 12:06:45 +01:00
f843b7edfe
Merge pull request #8506 from nextcloud/use-appmanager
...
Use isInstalled of AppManger instead of reimplement it
2018-03-22 09:55:19 +01:00
514de5dfa1
Use isInstalled of AppManger instead of reimplement it
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-21 11:34:18 +01:00
934eade56f
Migrate tests for contacts manager to correct test class
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-21 10:43:18 +01:00
ec1e039790
Show EOL warning in the update section
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-20 15:52:30 +01:00
1088068c60
Remove \OCP\Files::tmpFolder
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-19 10:54:39 +01:00
47a3008141
Remove \OCP\Files::tmpFile
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-19 10:52:35 +01:00
208e38e84e
Merge pull request #8255 from nextcloud/bugfix/noid/group-display-name
...
Full implement group display names
2018-03-15 12:07:30 +01:00
8d4b76c0e2
Remove deprecated OCP\Contacts
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-14 10:47:09 +01:00
7785c3752f
Remove deprecated HTTPHelper
...
* Remove the HTTP Helper
* Remove from Server Containter
* Removed legacy share tests that use it
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 21:54:56 +01:00
57eaa48e3d
Merge pull request #8788 from nextcloud/cleanup-oc_api
...
Remove unused methods and constants from legacy OC_API
2018-03-13 08:52:24 +01:00
a1232f46ca
Remove unused methods and constants from legacy OC_API
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 18:03:25 +01:00
2b335fd607
Use insertIfNotExist of the new interface
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 17:45:49 +01:00
432e529827
Merge pull request #8784 from nextcloud/remove-unused-deprecated-apphelper
...
Remove unused and deprecated class and interface AppHelper
2018-03-12 16:33:46 +01:00
f5c5c5181f
Remove unused and deprecated class and interface AppHelper
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 15:27:10 +01:00
44289ff134
Use proper method to format absolute timestamp
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 15:16:52 +01:00
054a45c079
Merge pull request #8710 from nextcloud/followup/8596/tests-for-user-pagination
...
Tests for email collaborators pagination
2018-03-09 11:21:21 +01:00
7a7c350a2d
Merge pull request #8716 from nextcloud/fix-cache-prefixing
...
Remove base url from global cache prefix
2018-03-08 21:12:54 +01:00
720e64ba55
Fixed caldav tests and metadata 2
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:50 +01:00
d80f13ef99
Fix Metadata tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:50 +01:00
882096653e
Fix calculation if there are more results
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 16:22:16 +01:00
3d7ae4aa97
Add tests for finding own email and user results pagination
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 13:26:26 +01:00
a2db959f5c
Merge pull request #8593 from eneiluj/master
...
Allow public page access to apps with group restrictions
2018-03-08 11:27:52 +01:00
3ad7daeda5
Add tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-08 11:05:18 +01:00
95366bbd1f
Fix tests to use ICacheFactory
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-07 15:09:43 +01:00
8d865483f4
Merge pull request #8714 from nextcloud/8705
...
Check if the cached js file exists
2018-03-07 14:45:43 +01:00
448a5e574e
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-07 14:04:21 +01:00
de56915605
Merge pull request #7419 from Abijeet/feature-7175
...
Fixes #7175 - Allow to search for email address in user management
2018-03-06 21:53:37 +01:00
d179186430
Remove testcase
...
Since a token now always requires a string we don't need to test for
null
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-05 16:14:46 +01:00
0c500e460f
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-05 09:06:51 +01:00
158aac00a0
Merge pull request #8289 from nextcloud/appdata_hardening
...
AppData hardening
2018-03-02 11:26:36 +01:00
7bc3c2e057
Merge pull request #7363 from nextcloud/default-share-perms
...
Let the admin configure the default share permissions
2018-02-27 13:44:34 +01:00
8b5997483c
Hardening of SimpleFile getContent
...
if file_get_contents fails remove the file. And traverse up the tree
checking if the other folders are there.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-27 13:35:09 +01:00
01f420c7ac
Merge pull request #8051 from nextcloud/public-template
...
Public page template response
2018-02-27 13:33:19 +01:00
3285becdc1
fix unit tests
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-02-27 12:29:25 +01:00
1615312bf1
add share permissions to settings page
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-02-27 12:29:25 +01:00
5a4aa2b7dd
Add test for PublicTemplateResponse
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:53 +01:00
6994bce951
Loglevel is an int
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-27 10:45:35 +01:00
4077f16aec
Make ILogger strict
...
* Make implementations strict
* Add scalar typehints
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-27 10:41:46 +01:00
a60d7a8563
Merge pull request #8541 from nextcloud/translate-permission-error-page
...
Provide translated error message for permission error
2018-02-26 17:50:21 +01:00
cf35c4b03a
Provide translated error message for permission error
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-26 17:00:29 +01:00
0ee45d3d20
Fix proper types
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-22 15:51:19 +01:00
e1bdeb786e
Merge pull request #8472 from nextcloud/strict_integritycheck
...
Make OC\IntegrityCheck strict
2018-02-22 10:01:50 +01:00
72e745be26
Handle strict typing in Checker and fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 21:09:08 +01:00
ca9f364fd4
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 10:55:52 +01:00
8e5120ce66
Merge pull request #8206 from nextcloud/bugfix/noid/fix-collaboration-result-size
...
Better result handling of email search
2018-02-20 23:02:53 +01:00
b30e035e25
Better result handling of email search
...
1. Local users should not be returned when searching for empty string
2. The limit of the response should be respected
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-20 17:38:32 +01:00
ac63c207a9
Merge pull request #8411 from nextcloud/add-strict-types-to-oc_app
...
Add strict types to OC_App
2018-02-17 21:34:20 +01:00
9dc3b04802
Fix app version to be always string and neither array nor null
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 16:05:13 +01:00
211212f4b3
App manager is not needed anymore
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-16 17:13:36 +01:00
17a26dfcc1
Validate the info.xml against the appstore schema file
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-16 10:23:51 +01:00
14bc9b1714
Merge pull request #8095 from nextcloud/webapps-capabilities
...
Expose navigation entries as API endpoint
2018-02-15 16:55:12 +01:00
24f96513fd
Merge pull request #8259 from nextcloud/guzzle6
...
update guzzlehttp/guzzle to 6.3.0
2018-02-14 22:26:19 +01:00
f9dbaf6f2a
Make sure we test the proper order in the NavigationManagerTest
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-12 17:22:32 +01:00
9b25ff9fcb
adjust httpclient to guzzle6
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-09 17:13:21 +01:00
df6e23c98c
add ci for swift primary storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-08 15:18:25 +01:00
26e0c14c6d
Merge pull request #8033 from nextcloud/s3-uploader
...
Use S3Client::upload instead of splitting single/multipart upload ourselves
2018-02-08 14:30:02 +01:00
047fb6d2c5
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-03 22:16:09 +01:00
b87e5a0f2e
Move depsCache clearing to SCSSCacher/JSCombiner
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-03 15:21:51 +01:00
5460166ff5
Add tests and class mapping
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-03 15:21:51 +01:00
372e06d742
Add all parameters to returnValueMap
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-31 14:15:12 +01:00
1429146083
Merge pull request #8096 from nextcloud/feature/6382/do-not-cache-settings-in-db-anymore
...
Do not cache the settings/sections in the database anymore
2018-01-31 12:49:45 +01:00
4fcdfbf5de
Merge pull request #8078 from nextcloud/theming-validate-scss
...
SCSS hardening
2018-01-29 16:12:10 +01:00
d971b104ed
Do not cache the settings/sections in the database anymore
...
This caused more troubles then it had benefits, especially
when an app got disabled or was removed without being disabled.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-29 15:47:37 +01:00
7405dfb544
Update tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-29 14:37:18 +01:00
5ec7296f6d
Add tests for URL rewriting
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 19:56:13 +01:00
b9bbb894f8
Merge pull request #7916 from nextcloud/2fa_log
...
Add 2FA to logfile
2018-01-25 15:57:32 +01:00
8160d0bc2a
Merge pull request #8036 from nextcloud/phpunit6
...
Require PHPUnit 6.5 or higher
2018-01-25 14:50:46 +01:00
c92eff919e
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-25 13:25:09 +01:00
3917a54113
Class "ProgressBar" is declared "final" and cannot be mocked.
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-25 11:33:26 +01:00
bf2be08c9f
Fix risky tests without assertions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-25 11:33:25 +01:00
870023365c
Fix "Undefined method setExpectedException()"
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-24 18:10:16 +01:00
c3424df1f0
Require PHPUnit 6.5 or higher
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-24 17:23:59 +01:00
3499cbdb76
Use S3Client::upload instead of splitting single/multipart upload ourselves
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-24 17:22:05 +01:00
1daddd678e
Merge pull request #8002 from nextcloud/dont_polutelog_dav_emaillogin
...
Dont polute the log on DAV emaillogin
2018-01-24 14:00:01 +01:00
4537faa5da
Merge pull request #7918 from nextcloud/properly-log-exceptions
...
Properly log the full exception instead of only the message
2018-01-23 11:56:02 +01:00
2a38605545
Properly log the full exception instead of only the message
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-23 10:57:21 +01:00
ef127a30ec
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-23 10:35:37 +01:00
d9b1492e03
Remove old repair steps that aren't executed anymore
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-22 14:51:02 +01:00
c70927eaa0
Remove not needed 3rdparty app disabling during upgrade for PHP 5.x
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-19 14:00:27 +01:00
f0b7b2dedf
Merge pull request #7911 from nextcloud/improve-oc_image
...
Improve OC_Image code to not guess the type of input
2018-01-18 14:39:08 +01:00
3d4c698f44
Improve OC_Image code to not guess the type of input, but actually request the specific methods to be called
...
Followup to #7836
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-18 13:40:55 +01:00
1e7b20f615
Remove IAppConfig::setValue
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-17 21:41:57 +01:00
09f8a755ec
Remove IAppConfig::getValue
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-17 21:41:56 +01:00
6e29b8731e
Merge pull request #7914 from nextcloud/fix-7254
...
format self-mentions, but don't offer them
2018-01-17 14:59:46 +01:00
6fdd686111
do not offer the handle of the current user for auto completion
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-17 13:49:18 +01:00
3784fa2074
comments should compile mentions also if done by author
...
it is used by clients for formatting reasons, there is no reason not format
the author if her handle is included in the comment body.
It is unrelated to sending out notifications.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-17 13:48:43 +01:00
24c58d39f4
Merge pull request #7909 from nextcloud/fix-migration-type-hints
...
Fix the type hints of migrations and correctly inject the wrapped sch…
2018-01-17 13:47:58 +01:00
f8756d96bc
Merge pull request #7847 from nextcloud/avatarmanager_strict
...
Fixes for avatarmanager
2018-01-17 13:46:18 +01:00
4a5282ba21
Fix the type hints of migrations and correctly inject the wrapped schema into migrations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-17 11:37:36 +01:00
4ef302c0be
Request->getHeader() should always return a string
...
PHPDoc (of the public API) says that this method returns string but it also returns null, which is not allowed in some method calls. This fixes that behaviour and returns an empty string and fixes all code paths that explicitly checked for null to be still compliant.
Found while enabling the strict_typing for lib/private for the PHP7+ migration.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-17 09:51:31 +01:00
cb0dbfa987
Merge pull request #7900 from nextcloud/strict_security
...
Make OCP\Security stricter
2018-01-17 09:29:32 +01:00
d1420ef481
Merge pull request #7901 from nextcloud/strict_cache_factory
...
Made the cache factory strict
2018-01-17 06:51:04 +01:00
0b464e5274
Merge pull request #7884 from nextcloud/cleanup-oc_user
...
Cleanup OC_User and OCP\User
2018-01-17 05:33:07 +01:00
0e0db37658
Make OCP\Security stricter
...
* Add typehints
* Add return types
* Opcode opts from phpstorm
* Made strict
* Fixed tests: No need to test bogus values anymore strict typing fixes
this
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 22:01:19 +01:00
c5fcfb0709
Made the cache factory strict
...
* Return types
* Typehints
* made strict
* fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 21:58:20 +01:00
55532f19d9
Cleanup OC_User and OCP\User
...
* mainly removes deprecated methods and old static code
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-16 18:39:11 +01:00
326d55db81
Support arbitrary number of arguments for d:or and d:and in search queries
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-16 13:22:28 +01:00
7bc9a69c3f
Remove deprecated core API
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-15 17:54:50 +01:00
419de27b6d
Merge pull request #7840 from nextcloud/dep_config
...
Remove deprecated \OCP\Config
2018-01-14 22:21:37 +01:00
48ea7251d7
Use \OC\User\Manager internally in the avatarmanager
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 21:32:54 +01:00
cf0a339997
Make OC\Security\RateLimiting strict
...
* Add return types
* Add scalar argument types
* Made strict
* Cleaned up phpstorm inspections
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 21:08:23 +01:00
8a41d05761
Remove deprecated \OCP\Config
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 14:25:04 +01:00
Roeland Jago Douma
Morris Jobke
John Molakvoæ (skjnldsv)
Julius Härtl
Roeland Jago Douma
Georg Ehrke
Maxence Lange
Blaok
Arthur Schiwon
Joas Schilling
Robin Appelman
Christoph Wurst
Björn Schießle