ae367c7e97
Fix elementToFile to also return path when defined
...
Fixes issue when opening the share dialog for a file inside the favorite
list, and the file is from a subfolder
2016-02-08 22:33:39 +01:00
d537cae063
cleanup jobs for comments and comment read marks
2016-02-05 15:36:21 +01:00
f0caf41232
Cleanup job for system and user tag orphaned when file was deleted
...
Whenever a file was deleted (also from trash), the tag mapping is
pointing at a fileid that doesn't exist any more.
This cleanup job will delete such orphaned mapping entries.
2016-01-29 11:51:47 +01:00
22010517f5
Merge pull request #21752 from owncloud/files-delete-fix
...
Only check selection for delete permissions, not parent folder
2016-01-26 16:13:10 +01:00
6e096936e5
update JS humanFileSize to use KB instead of kB
2016-01-19 10:51:57 +01:00
df7db3685e
Remove faulty directory permissions test
2016-01-15 20:46:39 +00:00
682821c71e
Happy new year!
2016-01-12 15:02:18 +01:00
665d7b25b0
Add unit test for file update
2016-01-09 22:47:26 +01:00
d27826bac0
Correctly render uploadtext indicator only on folders
2015-12-18 18:09:46 +01:00
1f715289bf
Removed deprecated function OC_User::deleteUser
...
Replaced with proper OCP calls
2015-12-17 16:18:40 +01:00
835911bce5
Removed deprecated private OC_User::createUser
...
All function calls are replaced with the recommended (which was already
the body of the function).
2015-12-17 16:18:40 +01:00
4d9e12b8bc
Fix mount type root detection
...
Since Webdav doesn't contain that information, we need to rely on the
parent folder's mount type to find out whether a child item is a
shared/external root or not.
Fixed the mount type detection logic and added unit test.
Also added a fix that ignores detection if no parent folder exists (ex:
shared file list, favorites, etc)
2015-12-14 10:44:47 +01:00
baa5a69c55
Bring back file delete action text to be based on context
...
For received shares, the delete action becomes "Unshare" and for
personal mounts it becomes "Disconnect storage".
This also makes it possible from now on to pass a function to a file
action's "displayName" attribute.
2015-12-11 15:14:30 +01:00
ffc49a24f0
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2015-12-10 16:43:37 +01:00
e241d26316
Compute share permissions in the view
...
The share permissions are now computed in the View/FileInfo instead of
storing them directly/permanently on the storage
2015-12-08 13:04:22 +01:00
2ceae43989
Merge pull request #20545 from owncloud/scan-storage-in-background-job
...
Move files/ajax/scan.php to background job
2015-12-03 16:53:46 +01:00
8aaab0dbad
Allow framing 'self'
...
This is required by the pdf viewer, since the files app on master uses the AppFramework it had applied the more strict defaults which made it not work on master.
2015-12-02 17:30:40 +01:00
23046ca5b7
Inject the database connection
2015-11-30 17:14:47 +01:00
e9094b8a41
Only require the interface
2015-11-30 17:14:47 +01:00
6e0596432c
Add a unit test that executes the query
2015-11-30 17:14:47 +01:00
623d34972d
Oracle can not return statements but only values
...
So evaluate the condition directly and return 1 or 0
2015-11-30 17:12:48 +01:00
1480964768
Adding more test suites to group DB
2015-11-30 10:55:05 +01:00
3bb6dcea64
Apply DB group annotation ...
2015-11-30 10:55:05 +01:00
391bc49dab
Move files/ajax/scan.php to background job
...
The background job will now be executed in chunks of 500 users all 10 minutes.
2015-11-28 13:06:53 +01:00
fa2be0750c
Make files app use Webdav for most operations
2015-11-22 16:05:50 +01:00
8fc0e05564
Remove "Text file" entry in the "+" menu
...
The text editor app will register this instead.
Also made "fileList" a non-private attribute to make it possible for
plugins to access the attached file list object.
2015-11-19 15:36:21 +01:00
daa388ce8d
Move index.php from files to AppFramework
...
1. Allows it to use the more secure CSP rules of the AppFramework.
2. Adds some unit tests.
2015-11-16 21:10:11 +01:00
80cf4e84e3
Fix file action download spinner
2015-10-30 14:58:53 +01:00
9c9158e6b7
Fix icon update to be more consistent
...
Makes the details bar show the same icon as in the list.
2015-10-29 12:59:51 +01:00
8f09d5b67c
Update license headers
2015-10-26 14:04:01 +01:00
abd0ba1f25
Fix file upload, conflict dialog, also in public link
...
- Use "FileList" instead of "OCA.Files.App.fileList" that doesn't exist in public
link page.
- Fix public link upload by properly adding the form data using a new
utility function "addFormData". That one is needed because IE8 upload
and regular upload use a different format...
2015-10-21 12:18:06 +02:00
899165113c
Merge pull request #19742 from owncloud/shareinfo_performance
...
Do not calculate non essential info
2015-10-20 14:25:36 +02:00
416da0dfe9
fix delete orphan shares test with object home storage
2015-10-16 21:41:51 +02:00
204b3ca189
Do not register sidebar panels when no sidebar
2015-10-15 16:30:50 +02:00
5e9ca79788
Do not calculate non essential info
...
There is no need to calculate a human readable date on the server side.
We supply the mtime and a client can easily convert that himself if
needed. This is already done most of the time since the date is often
not in the exact right format.
There is also no need to attach icon info. We have that available in
javascript. And else the client should get the right icon based on the
mimetype for its platform.
* Updated tests
2015-10-13 14:56:55 +02:00
b945d71384
update licence headers via script
2015-10-05 21:15:52 +02:00
6bf6ff9564
If an inline files action provides an alt text show it
...
* Added unit tests for icon display
* Added unit tests for icon alt text display
2015-10-03 15:47:20 +02:00
4b3a5a257f
Fix moment.js "a few seconds ago" with "seconds ago"
...
* fixes #18627
2015-10-02 10:51:51 +02:00
750f19340f
Merge pull request #19310 from owncloud/hide-sort-indicator
...
hide sort indicator when in multiselect mode, ref #19056
2015-09-30 11:07:45 +02:00
733673b39d
Merge pull request #19365 from owncloud/files-detailsbar-interaction
...
Fix sidebar interaction
2015-09-29 14:44:28 +02:00
d52361b09b
Disable sorting when multiselect is enabled in file list
2015-09-29 13:24:33 +02:00
f9acf4627e
Fix sidebar interaction
...
- Clicking a file row or selecting it will open the sidebar.
- When sidebar is open, its contents update with the last selection.
- Dragging doesn't open the sidebar but does update its contents if it was
open already.
- Switching folders closes the sidebar.
- Close sidebar when highlighted file got deleted/removed from list
2015-09-28 15:23:37 +02:00
a8fb0038e9
Hide sidebar tab headers conditionally
...
Added canDisplay() in DetailsTabView that should return false if the tab
header of this tab must be hidden
2015-09-28 14:57:44 +02:00
72024ad201
Merge pull request #19404 from owncloud/files-sidebar-sorttabs
...
Fix tabs order in files sidebar
2015-09-28 12:55:38 +02:00
5e4a52d3c2
Fix tabs order in files sidebar
2015-09-28 12:30:12 +02:00
f35b6833ff
Fix order of actions in the files actions menu
2015-09-28 11:19:49 +02:00
004de1425e
Merge pull request #18630 from owncloud/files-combineuploadbutton
...
Combine upload action into the "New" menu
2015-09-07 14:03:57 +02:00
310d797284
Add versions tab to files sidebar
...
- move versions to a tab in the files sidebar
- added mechanism to auto-update the row in the FileList whenever values
are set to the FileInfoModel given to the sidebar
- updated tags/favorite action to make use of that new mechanism
2015-09-03 16:47:24 +02:00
73c61941e2
Tags in FileInfo map must be an array
...
Fixes FileList.elementToFile to make an array for the tags instead of
keeping the original joined string
2015-09-03 13:01:14 +02:00
4ba2333507
Added unit tests for "new" file menu and small fixes
...
- added unit tests for NewFileMenu
- use generateUrl for FileList.createFile and FileList.createDirectory
- added unit tests for FileList.createFile and FileList.createDirectory
2015-09-03 12:17:35 +02:00
3ea9f97c36
Fix sidebar thumbnail loading JS unit tests
2015-09-03 08:24:50 +02:00
c6053daf43
Fixes failing tests
2015-08-31 00:14:07 +02:00
5e6fa3c938
Fix trashbin sidebar
...
Do not display size as it is not available.
Use display name instead of name to remove the ".d123456" suffix.
2015-08-25 11:29:35 +02:00
37939fb0e8
Parse mtime from the data attributes
2015-08-24 17:16:20 +02:00
31d62c10bf
Merge pull request #17501 from tbartenstein/patch-1
...
Update fileinfo.php
2015-08-24 09:57:27 +02:00
5e1c2aecc7
fix unit test for folder renaming (icon)
...
fix unit test to go with #17501 and check for the new icon
2015-08-21 18:54:09 +02:00
ffff156965
Merge pull request #18310 from hasso/selection-string-fix
...
Fix the string counting a selected files/dirs
2015-08-18 10:43:17 +02:00
97bc73ad49
Update unit test to reflect the string change
2015-08-17 15:31:44 +03:00
e2549fa660
Improve right sidebar tabs behavior
...
Tab heads are not rendered if only one tab.
The tab contents is updated on-demand. This means that if a tab is not
visible it is not rendered at first. If the tab was already rendered
through switching, its model will not get updated until the next time it
becomes visible. This will prevent needless rerendering of invisible tab
contents, especially considering that some tabs might need extra ajax
requests.
2015-08-14 16:51:04 +02:00
c964eff17b
Make file actions work from sidebar
...
The favorite icon in the sidebar now triggers the file action and also
updates itself according to the model's state when triggered from the
file row.
The thumbnail triggers the default action.
Currently only one FileInfoModel is used for the selection and state
synchronization between views.
FileList reload now auto-closes the sidebar.
2015-08-12 17:30:20 +02:00
d04a6bce6f
Merge pull request #17709 from owncloud/fileactions-dropdown
...
Move file actions to dropdown
2015-08-11 15:13:59 +02:00
0abc637782
Merge pull request #18171 from owncloud/fix-language-of-files-activities-in-emails
...
Correctly make use of the languageCode argument in the files activity extension
2015-08-11 12:34:58 +02:00
984ae8140d
Fixed file actions menu to close when reclicking trigger
...
FileActionsMenu is now a backbone view.
The trigger and highlight handling is now done in the
FileActions.showMenu() method using events.
2015-08-11 11:35:46 +02:00
81c3bbad57
Correctly make use of the languageCode argument in the files activity extension
2015-08-10 14:40:33 +02:00
9454e9043a
Updated unit tests for file actions and actions menu
2015-08-10 14:12:34 +02:00
038d29b8de
Fix unit test for tipsy->tooltip change
2015-08-10 11:23:39 +02:00
9c402c761f
fix timezone issue with unittest
2015-08-07 01:22:45 +02:00
bdfab8108e
Fix sidebar mtime display unit test
2015-08-07 01:22:45 +02:00
781ba420c9
Use own tabs impl in files sidebar
...
Also change style.
2015-08-07 01:22:44 +02:00
734c6b0b6f
extend MainFileInfoDetailView JS tests
2015-08-07 01:22:43 +02:00
e0bcd56402
More work on right sidebar unit tests
2015-08-07 01:22:43 +02:00
3e44ca6dc2
Added unit tests for right sidebar
2015-08-07 01:22:43 +02:00
5699fff889
Merge pull request #17175 from owncloud/add-download-feedback
...
Add loading spinner to download icon
2015-07-30 16:34:35 +02:00
eb7a796ad9
Fix unit tests
2015-07-09 18:42:46 +02:00
3d8297c254
Fix unit tests and introduce better mocks of the HTML
2015-07-07 13:56:49 +02:00
d1f0ff372e
Merge pull request #17163 from owncloud/update-licenses
...
Update license headers
2015-06-27 20:22:23 +02:00
ca1da0acb7
add check if server returns a 500 and display error
...
resolves https://github.com/owncloud/core/issues/17170
2015-06-26 12:50:09 -04:00
f63915d0c8
update license headers and authors
2015-06-25 14:13:49 +02:00
5466dcadc0
adding correct blocking logic for fff
2015-06-22 11:42:42 -04:00
13617c8bf1
Check target name on rename with web UI
...
When renaming over the web UI, check early that the target name is
valid.
This prevents nonsensical error messages when renaming to a name with a
trailing backslash.
2015-05-29 19:30:09 +02:00
fdbc21fc6c
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2015-05-19 11:23:06 +00:00
69f88b38c9
Fix file name validation in New menu
2015-04-27 16:31:18 +02:00
f4bc852db3
Show hint if there is no delete permission
...
* add class .no-permission which shows the default delete icon
* fixes #15172
* add unit test for no permission and for delete permission
2015-04-23 21:49:59 +02:00
53a23364ef
Added empty content message for empty read-only folders
2015-04-21 14:31:13 +02:00
02614d214e
Merge pull request #15437 from owncloud/deleteorphanedfiles
...
[command] delete orphaned file cache entries
2015-04-10 00:09:56 +02:00
9c76d068c3
Merge pull request #15196 from owncloud/limit-file-activities-to-favorites
...
Limit file activities to favorites
2015-04-09 00:18:31 +02:00
f8cfc03f36
Replace originalStorage in tests with a proper teardown
...
The purpose of $originalStorage in unit tests was to remount the old
root.
However that storage itself is already wrapped by storage wrapper, so
remounting it would rewrap the storage several times.
This fix makes use of "loginAsUser()" and "logout()" from the TestCase
class to properly initialize and cleanup the FS as expected.
2015-04-08 12:45:38 +02:00
cefdcea021
[command] delete orphaned file cache entries
...
* ./occ files:cleanup
* delete file cache entries without an existing storage
2015-04-08 10:23:56 +02:00
e16d61e293
Remove server timezone dependency from files list test
2015-04-07 10:12:15 +02:00
730efe25a4
Make scrutinizer happy
2015-04-01 12:13:49 +02:00
efcc2e87ab
Adjust by/self filter aswell and fix tests
2015-03-31 17:35:04 +02:00
9233d32834
Move tag related code into a helper so we can test the query without a view
2015-03-30 17:21:06 +02:00
2b0906cdff
Adding a pending indicator to the files summary - fixes #14853
2015-03-27 01:16:29 +01:00
a8b756154a
Merge pull request #14495 from owncloud/update-mailmap-01
...
Updating .mailmap
2015-03-26 17:17:18 +01:00
b585d87d9d
Update license headers
2015-03-26 11:44:36 +01:00
92f0dba3c8
Show hidden files (dot files) in gray
2015-03-26 10:35:27 +01:00
dac4436807
Merge pull request #15170 from owncloud/middleclickbreadcrumb
...
Fix middle click on breadcrumb
2015-03-26 00:19:52 +01:00
b3de3d7245
Fix breadcrumb click JS unit test
2015-03-25 09:27:55 +01:00
0ea3878111
No longer directly output OC_Image for thumbnails
...
* Only use public interfaces
- Injected IPreview
* Added unit tests
2015-03-24 18:55:06 +01:00
abacfd84da
fixing js unit tests
2015-03-09 10:38:38 +01:00
06aef4e8b1
Revert "Updating license headers"
...
This reverts commit 6a1a4880f0
2015-02-26 11:37:37 +01:00
6a1a4880f0
Updating license headers
2015-02-23 12:13:59 +01:00
6e9a2515ea
Merge pull request #14278 from owncloud/fix-index
...
Check if the offset exists before accessing
2015-02-20 14:56:13 +01:00
b7ff0d44d8
apply backslash fix to _setCurrentDir
2015-02-19 20:20:33 +01:00
3213b04aef
Check if the offset exists before accessing
...
This checks if the offset exists before accessing it and also adds unit tests to this function which would have catched this before 🙈
Fixes https://github.com/owncloud/core/issues/14277
2015-02-17 17:08:23 +01:00
b848062d88
Parse backslash as directory separator in breadcrumb
...
This will parse backslashes as directory separators in breadcrumbs. Thus when accessing something like `/index.php/apps/files?dir=foo\foo` the breadcrumb will properly resolve this instead of showing `foo\foo`
Fixes https://github.com/owncloud/core/issues/13643
2015-01-24 09:56:00 +01:00
7f24e77cfc
Disallow ctrl click to select when selection not allowed
2015-01-15 18:16:27 +01:00
c4aeb0b5b5
Merge pull request #13289 from owncloud/fav-keepfavoncancelrename
...
Properly update internal file info with updated tags
2015-01-13 08:28:30 +01:00
d20a1bbdbf
Merge pull request #13154 from owncloud/fix13141
...
don't show no files yet when mask is in place, fixes #13141
2015-01-12 22:48:25 +01:00
8cc13031e9
Return path attribute for ajax rename operations
...
This fixes an issue when renaming files from a flat list view like
"Favorites" or "Shared with you", in which case the path needs to be
present in the response to make sure the data-path attribute is properly
set in the JS side.
2015-01-12 18:15:31 +01:00
dac7828480
Return tags after rename
...
To make it possible for the web UI to correctly display the tag/favorite
information after a rename, this information is now returned in the
rename response
2015-01-12 18:14:17 +01:00
ef1dd3ea0a
Properly update internal file info with updated tags
...
Whenever tags are updated, they need to be updated in the file list's
file info array as well.
This commit also adds unit tests and makes sure that whichever tags are
sent back by the server after update are used when updating
attributes/fileinfo.
2015-01-12 17:58:57 +01:00
45a20744fc
add js tests for filelist filtering
2015-01-09 10:49:22 +01:00
6ba8881343
add file summary filter spec tests
2015-01-02 10:28:42 +01:00
75e8b39826
Merge pull request #12879 from owncloud/mountconfig
...
Add mount specific options
2014-12-18 23:38:14 +01:00
ec0401f97b
be more explicit in JS unit tests - caused by accessibility issues
2014-12-18 01:27:58 +01:00
fd85424742
Add getMountPoint to FileInfo
2014-12-17 14:03:50 +01:00
ab35459cac
Propertly restore thumbnail on cancel/rename/move
...
Since the thumbnail is now in a div, the code that tries to change the
thumbnail have been adapted here as well.
2014-12-17 13:12:57 +01:00
33eb4483b2
Fixed has-favorites CSS
2014-12-15 15:18:29 +01:00
a5bb66f4a7
Added favorites feature to the files app
2014-12-15 12:10:54 +01:00
5b3971f002
Merge pull request #12639 from owncloud/bad_mtime_format
...
Fix formatting of bad dates from external storages
2014-12-13 10:07:10 +01:00
fdbb68a3c3
Return ? if mtime is 0 or -1
...
Tooltip contains 'Unable to determine date'. Fixes #6395
2014-12-12 23:54:18 +00:00
81e9d43e23
Move file thumbnail into the label element
2014-12-11 18:21:25 +01:00
d3188159d2
Merge pull request #12394 from owncloud/files-fileactionsimprovements
...
Improve FileActions JS to allow for custom rendering
2014-12-08 11:30:21 +01:00
0dcfd5f20b
Modified filesort test cases to test for large sizes & timestamps
2014-12-03 23:45:57 +01:00
e8cbb8e2d8
Add js unit test
2014-11-26 12:14:35 +01:00
e689bc745f
Improve FileActions JS to allow for custom rendering
...
This improves the OCA.Files.FileActions class to support passing a
"render" function in the action object.
The default function "_defaultRenderFunction" is used by default and
renders actions in the usual actions container.
Moved "Rename" and "Delete" to custom render functions.
2014-11-24 16:26:50 +01:00
76ebd3a050
Make apps/ extend the \Test\TestCase and fix overwritten methods
2014-11-19 14:52:09 +01:00
bb540722cd
Use base class to reset the file mapper
2014-11-19 14:52:07 +01:00
6625d5c88f
Correctly restore previous root mount point after testing
2014-11-17 10:48:19 +01:00
1979ec70a5
JS unit tests fix - use toBeUndefined() instead of toEqual(null)
2014-11-04 10:37:16 +01:00
f776bcd4a0
remove unnecessary require calls - the ownCloud class loader is supposed to take care of this
2014-10-30 17:20:40 +01:00
8198e70f24
Changed fileList.pageSize to function call
2014-10-15 19:18:35 +02:00
63145f5765
Typo
2014-10-15 19:17:21 +02:00
5033fc4e52
Stub for pageSize, because now it is dynamically calculated
2014-10-15 15:09:01 +02:00
2ac953e6a8
correct progress-icon to icon-loading-small
2014-09-22 18:24:32 +02:00
91d9d45c6c
correct delete-icon to icon-delete, fix #11128
2014-09-22 18:17:33 +02:00
05cf940983
Tentative fix for legacy file actions unit test side effect
...
Sometimes the JS unit test with legacy file actions fail.
This fix runs the legacy file actions tests on a dummy instead of the
real one.
2014-09-16 15:38:44 +02:00
f1bfe35cda
Added permission check for drag and drop
...
When dropping files onto a read-only folder, a notification
is now shown instead of attempting to upload.
This for both the drag for upload and drag from inside the file list
cases.
2014-09-04 20:18:24 +02:00
607ea636be
Fixed folder icon update routine when share owner exists
...
Whenever a folder has a "data-share-owner" attribute, the icon is now
properly updated to a shared folder icon.
2014-08-15 16:19:50 +02:00
bc8e1ebf75
new unit test added
2014-08-11 12:03:08 +02:00
5565eabb81
Merge pull request #9683 from owncloud/fix_#8819_sorting
...
Fix #8819 sorting
2014-07-22 10:11:00 +02:00
d0cd4d5ad9
Adjusted tests for new default sorting
2014-07-17 20:27:55 +02:00
22653e21a2
Propagate file action changes to the file lists
...
Whenever an app needs to register an event late, it does that on the
original file actions object.
Since the file actions that the file list work on is a merged list, not
the original one, the registration event needs to be propagated there as
well.
2014-07-09 12:26:33 +02:00
4fe1cdd2a7
Add machine readable error messages to OC\JSON
...
Reload the files app in case of authentication errors, expired tokens or disabled app
Reloading will triger the full server side handeling of those errors
formatting
fix missing semicolon + some jshint warnings
2014-07-04 16:20:27 +02:00
07118f599e
Fix FileActions merging override
...
When merging FileActions, the register() functio needs to correctly
override the previously merged action handler without affecting the
original one.
2014-07-04 12:56:04 +02:00
025b71d068
Use fileActionsReady to re-render sharing icons
...
Whenever file actions are modified, either by registering new actions or
when appending a new page of entries, the sharing app is now notified so
it can correctly refresh the sharing icon status.
Additionally, the core's loadIcons() method is also used to load the
existing shares and also refresh the sharing icons afterwards.
2014-07-01 21:32:04 +02:00
509cdebab7
Fix fileActionsReady event after deferred file actions update
2014-07-01 18:50:54 +02:00
3b2fd5e4e6
Merge pull request #9254 from owncloud/fileactions-deferred
...
Sync file list with file actions
2014-06-27 15:03:21 +02:00
b975f0e718
Merge pull request #9174 from owncloud/breadcrumbfix
...
Breadcrumb width calculation fix
2014-06-27 13:51:18 +02:00
Vincent Petry
Arthur Schiwon
Thomas Müller
Morris Jobke
Robin McCorkell
Roeland Jago Douma
Scrutinizer Auto-Fixer
Lukas Reschke
Joas Schilling
Robin Appelman
Jan-Christoph Borchardt
Raghu Nayyar
tbartenstein
Hasso Tepper
Roeland Jago Douma
Clark Tomlinson
Jenkins for ownCloud
Jörn Friedrich Dreyer
Robin McCorkell
brumsel
Joas Schilling
Nazar Mokrynskyi
Bjoern Schiessle
Remco Brenninkmeijer