Commit Graph

143 Commits

Author SHA1 Message Date
Joas Schilling 96253c7c1b
Add missing parent::__construct() calls to Jobs
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-14 16:35:12 +01:00
Julius Härtl a0444bc69c
Merge pull request #24247 from nextcloud/bugfix/noid/ocm-providerId-string 2020-12-09 17:25:59 +01:00
Julius Härtl 8f6c2ec357
Move columns to bigint
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-08 16:05:53 +01:00
Joas Schilling f648635758
Make the throwing optional, so background tasks don't break
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +01:00
Joas Schilling 46b073d7ce
Add a config for default region of phone numbers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +01:00
Joas Schilling 9e04e6f99a
Also translate the phone number when coming in via the accounts manager API directly
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +01:00
Joas Schilling efe79f2937
Validate and standardize the phone number on saving
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +01:00
Joas Schilling c2913f18d2
Also return the phone number and twitter handle on the API
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +01:00
Joas Schilling da9462b482
Make code strict
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +01:00
Morris Jobke fe79a1ad3e
Harden setup check for TLS version if host is not reachable
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 13:17:05 +01:00
Roeland Jago Douma 6166e1a157
Use proper OCP\BackgroundJobs\Job
And typehunt the IJobList

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-25 15:03:06 +01:00
Vincent Petry 2143f2bb82
Set up FS before querying storage info in settings
The personal info section of the personal settings is querying the
storage quota information. For this it requires the FS to be setup which
is not always guaranteed.

This fixes an issue where refreshing the settings page would cause it to
fail after Redis caches are full. It is likely that when Redis cache is
populated, some code path is initializing the FS, so it works so far.
But when the cache is populated, that code path is skipped so the FS is
not guaranteed to be setup...

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-11-13 17:06:37 +01:00
Joas Schilling d5df033ede
Create primary keys on all tables and add a command to create the afterwards
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:36:27 +01:00
Morris Jobke a223f603f9
Simplify the check if admin can change password based on encryption status
Found by Psalm:
```
/home/runner/work/server/server/apps/settings/lib/Controller/UsersController.php:324:8:error - RedundantCondition: Type true for $isEncryptionModuleLoaded is never falsy
```

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-05 22:20:34 +01:00
Morris Jobke 9435ec2b4e
Remove unneeded service - found by Psalm
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 10:06:33 +01:00
Morris Jobke 1c496a5a35
Add a background job that checks for potential user imported SSL certificates and shows a warning in the admin settings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 10:06:33 +01:00
nhirokinet 830348dbee
Add SVG support check to setup check
Signed-off-by: nhirokinet <nhirokinet@nhiroki.net>
2020-11-02 11:29:08 +01:00
Morris Jobke e2e7c2d014
Document settings BeforeTemplateRenderedEvent
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-29 11:15:31 +01:00
Morris Jobke b8ed997238
Remove ISection in favor of IIconSection
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-28 23:05:00 +01:00
Roeland Jago Douma 28d82394f1
Merge pull request #23720 from nextcloud/lowercase-email
save email as lower case
2020-10-27 20:14:43 +01:00
Robin Appelman cbd6e65678
save email as lower case
email addresses are case insensitive

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-27 14:56:52 +01:00
timm2k 60efad45cf
Update CheckSetupController.php 2020-10-26 09:42:01 +01:00
Roeland Jago Douma 0dbb99a81b
Merge pull request #23161 from nextcloud/enh/noid/setup-checks2
Remove setup check for php mail
2020-10-08 22:40:37 +02:00
Christoph Wurst d9015a8c94
Format code to a single space around binary operators
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +02:00
Daniel Kesselberg 9c8e8007f9
Remove setup check for php mail
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-10-03 21:58:55 +02:00
Roeland Jago Douma 05edd1e5d6
Merge pull request #22890 from nextcloud/techdebt/18680/help-static-code-analysis-understand-code
Help static code analysis to understand code
2020-09-17 08:51:20 +02:00
Daniel Kesselberg 096fe20611
Help static code analysis to understand code.
It adds proper type hints to private namespace to allow private namespace methods.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-09-16 16:37:17 +02:00
Morris Jobke d3680e682a
Remove not needed semicolon and PHPDoc hint
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 16:18:43 +02:00
Arthur Schiwon f959828616
emit typed event for user management
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-08 22:50:05 +02:00
Morris Jobke 0e6344f543
Merge pull request #22650 from nextcloud/fix/noid/fix-psalm-warning
Only load viewer in settings if the viewer app is enabled
2020-09-07 20:41:49 +02:00
Morris Jobke ce1e873a0a
Only load viewer in settings if the viewer app is enabled
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-07 20:25:57 +02:00
Christoph Wurst 1f7f93a695
Update license headers for Nextcloud 20 (again)
There are still lots of outdated headers, so time for another round of
updates.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-09-07 14:37:44 +02:00
Jan C. Borchardt 4c48d6bf18
Add 'Reasons to use Nextcloud in your organization' call to action in settings
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2020-09-07 08:30:01 +02:00
Julius Härtl 7a1748e6f0 Show changelog in apps management
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-09-03 19:16:13 +00:00
Christoph Wurst 2a054e6c04
Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
Joas Schilling b09620651c
Don't use deprecated getIniWrapper() anymore
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-20 16:35:38 +02:00
Morris Jobke da584462d1
Merge pull request #22018 from nextcloud/bugfix/noid/harden-key-generation
Harden SSE key generation
2020-08-19 20:42:34 +02:00
Morris Jobke 603d7dab5e
Add setup check that links to the migration documentation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 15:45:45 +02:00
Morris Jobke d7f66c36ac
Fix "misplaced variables" warning of Psalm in PHPDoc statements
Ref #21787

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-17 17:46:57 +02:00
Julius Härtl 36cfdd320b
Harden key generation
There might be cases where multiple requests trigger the key generation
at the same time and the instance ends up with a non-fitting
public/private key pair. Therefore the whole key generation should be
locked. Other than that this makes sure that user key generation return
values are properly validated.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-14 07:58:40 +02:00
Morris Jobke 93ba8faabc
Fix name of app config option to properly reflect what it does
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 13:34:31 +02:00
Morris Jobke 53fab3fe5f
Add app config option to disable "Email was changed by admin" email
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-12 12:27:43 +02:00
blizzz 326a04d12c
Merge pull request #22004 from nextcloud/enh/noid/setup-checks-php
Add setup checks for php default charset and output buffering.
2020-08-07 20:55:04 +00:00
Morris Jobke 2aa6256f38
Merge pull request #22102 from nextcloud/feature/noid/app-navigation-via-unified-search
App navigation via unified search
2020-08-05 22:53:03 +02:00
John Molakvoæ (skjnldsv) d2c0569b49
Fix search providers order and IDs
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-05 17:57:17 +02:00
Joas Schilling 99fbaa9cba
Very top of the tops
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-05 17:51:18 +02:00
Joas Schilling 5be04942e7
Hide navigation links which dont lead anywhere (looking at you user status)
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-05 17:50:20 +02:00
Joas Schilling fcdd702040
App navigation via unified search
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-05 16:42:36 +02:00
Joas Schilling ea8f68bea6 Hand in the route and the parameters of the request
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-08-05 12:52:16 +00:00
John Molakvoæ (skjnldsv) d98f7c1bd8
Make apps handle the order logic
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-05 11:37:45 +02:00