Commit Graph

6703 Commits

Author SHA1 Message Date
Kristof Hamann c44126abb5 Unlock files even if an exception occurs
Signed-off-by: Kristof Hamann <korelstar@users.noreply.github.com>
2017-11-12 14:38:44 +01:00
aimakun ed727c9c8c Issue #6991: Fix mismatch copyFromStorage method signature between \OC\Files\Storage\Common and its child classes
Signed-off-by: Teerapong Kraiamornchai <aima.kun@gmail.com>
2017-11-01 00:22:35 +07:00
dartcafe 9c08e3a4a6
Fix future time spans
Signed-off-by: dartcafe <github@dartcafe.de>
2017-10-22 07:52:28 +02:00
Roeland Jago Douma 502ec178b5
MP3 without cover don't get a preview
* Fixes #2739

It tries to create an image from an SVG file. Which we don't support. So
this fails and prints an log line. Then we fall back anyways to the 404
and fetch the default icon.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-09-28 23:15:02 +02:00
Arthur Schiwon ed0d42dcea
don't pass User object when uid string is expected
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-09-27 17:52:33 +02:00
Robin Appelman 12b02e9785
Fix function builder
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-09-22 16:06:57 +02:00
Joas Schilling 12df8dd69f
Add brackets around concat statements so comparing the result works as intended
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-09-22 16:04:24 +02:00
Robin Appelman f1b7dbf46b
Fix version for repair step
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-09-22 15:50:10 +02:00
Robin Appelman d132b80111
rename fun to func
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-09-22 15:50:10 +02:00
Robin Appelman f9eda2706a
Add function builder to the query builder
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-09-22 15:47:48 +02:00
Robin Appelman ed6c61256d
Add MD5() to sqlite
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-09-22 15:47:48 +02:00
Robin Appelman a96dd73f6c
chunk getting invalid paths and reuse queries
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-09-22 15:47:48 +02:00
Robin Appelman 19ce46ed34
use a generator instead of fetching all rows at once
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-09-22 15:47:48 +02:00
Robin Appelman f01bd935ed
adjust to moved repair step
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-09-22 15:47:48 +02:00
Morris Jobke daa2c86965
Run repair step only once
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-09-22 15:47:47 +02:00
Robin Appelman 0597d3f72f
Add repair step for invalid paths
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-09-22 15:47:47 +02:00
Robin Appelman c5803ef0db
fix moving folders out of a cache jail
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-09-22 15:47:47 +02:00
Lukas Reschke d5c2f7f7af
Ensure log message is UTF-8 encoded
PHP's json_encode only accept proper UTF-8 strings, loop over all
elements to ensure that they are properly UTF-8 compliant or convert
them manually.

Without this somebody passing an invalid User Agent may make json_encode
return false which will get logged as empty newline.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-08-21 10:22:16 +02:00
Joas Schilling 564b2f974f Use DI
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-20 16:34:16 +02:00
Vincent Petry a78b13da82 Skip null groups in group manager (#26871) (#26956)
* Skip null groups in group manager (#26871)

* Skip null groups in group manager

* Also skip null groups in group manager's search function

* Add more group null checks in sharing code

* Add unit tests for null group safety in group manager

* Add unit tests for sharing code null group checks

* Added tests for null groups handling in sharing code

* Ignore moveShare optional repair in mount provider

In some cases, data is inconsistent in the oc_share table due to legacy
data. The mount provider might attempt to make it consistent but if the
target group does not exist any more it cannot work. In such case we
simply ignore the exception as it is not critical. Keeping the
exception would break user accounts as they would be unable to use
their filesystem.

* Adjust null group handing + tests

* Fix new group manager tests

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-07-20 16:29:14 +02:00
Morris Jobke bb1ff50f63 Merge pull request #5215 from nextcloud/autocomplete-settings-stable11
[stable11] some sharing settings
2017-07-05 11:22:39 +02:00
Morris Jobke 3e9cda35cb Merge pull request #5190 from nextcloud/treat-session-regid-error-stable11
[stable11] Treat PHP Errors on User session regenerate
2017-06-14 23:20:27 -05:00
Arthur Schiwon 6f1fd9ce08
change PHP errors to ErrorException in the session (PHP >=7)
Otherwise it might be that authentication apps are being disabled on
during operation while in fact the session handler has hiccup.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-06-14 12:57:07 +02:00
Lukas Reschke c6cd90f18c Merge pull request #5363 from nextcloud/exclude-files-external-dir-from-encryption-stable11
[stable11] don't try to encrypt/decrypt the certificate bundle
2017-06-14 09:50:14 +02:00
Morris Jobke f6181d8e16 Merge pull request #4913 from nextcloud/backport-4810-mimetype-update
[stable11] Fix mimetype update query
2017-06-13 17:39:31 -05:00
Robin Appelman 460df4c007
filter missing groups in share provider
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-06-13 10:55:09 +02:00
Bjoern Schiessle f8addd4cf9
don't try to encrypt/decrypt the certificate bundle
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-06-13 10:16:18 +02:00
Morris Jobke fef75ff2c0
Use intval() for validation of config options
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-06-01 12:33:41 +02:00
Morris Jobke 26c8f82ba2
Improve the UX for sharing settings
* shows a info when list is potentially truncated
* shows a warning when characters length is not enough

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-06-01 12:33:06 +02:00
Arthur Schiwon ee7c6e0db8
emit changeUser only if there really was a change (quota, displayname)
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-06-01 11:50:09 +02:00
Arthur Schiwon 05881fa4ed
remove unnecessary lines…
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-05-31 12:26:03 +02:00
Arthur Schiwon aecb85cf64
Treat PHP Errors on User session regenerate
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-05-31 12:15:06 +02:00
Robin Appelman d212a5167d
round the mtime in touch
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-05-18 13:22:52 +02:00
Joas Schilling 59f621e9cd
Fix variable names
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-05-17 10:30:03 +02:00
Joas Schilling 2e3fe61f99
Fix order of parameter and escaping
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-05-17 10:29:53 +02:00
Joas Schilling c85a770ecf
Actually we want to update the mimetype of all files ending with the suffix
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-05-17 10:29:42 +02:00
Rello ff41ee40bf
don´t change folders with --repair-filecache
check if folder is "httpd/unix-directory" and don´t perform here #27585
2017-05-17 10:29:31 +02:00
Vincent Petry e47d8028dc
Prevent PHP request to get killed when using fclose callback (#26775)
* Prevent PHP request to get killed when using fclose callback

* Add ignore_user_abort everywhere where the time limit is set to 0

Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-04-25 14:11:38 +02:00
Joas Schilling ce8aee4a4e
Better validation of allowed user names
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-04-19 09:21:46 +02:00
Robin Appelman 6d5adb8b8f
Dont use the permissions mask while scanning
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-04-10 16:35:46 +02:00
Jörn Friedrich Dreyer 1bc28261d5
make JobList::next() lock free
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-04-07 13:03:16 -05:00
Joas Schilling 02a47150db Merge pull request #4242 from nextcloud/encryption-fix-mail-share-stable11
[stable11] take share by mail into consideration if we calculate the access list
2017-04-06 14:09:28 +02:00
Joas Schilling 562b930046 Merge pull request #4225 from nextcloud/stable11-token-save-scope
[Stable11] token save scope
2017-04-06 14:08:00 +02:00
Bjoern Schiessle d0b93ad404
take share by mail into consideration if we calculate the access list
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-04-06 12:00:42 +02:00
Lukas Reschke 462073c686
Remove verbose error message
There's no need to have this included in the error message.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-04-05 23:14:04 +02:00
Robin Appelman f4b6c34ddf
Save the scope of an auth token in the session
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-04-05 23:00:53 +02:00
Joas Schilling cf8a680b97
Fix the update from NC 10 and 11 to the latest NC 11
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-03-30 15:31:50 +02:00
Morris Jobke 9a526a2eb8
Fix return value of getAllowedPreviousVersions()
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-03-30 15:22:40 +02:00
Joas Schilling e8bbef462f
Prevent migration from ownCloud 10 to Nextcloud 11
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-03-30 15:22:39 +02:00
Morris Jobke e44f6e9235 Merge pull request #3842 from nextcloud/no-empty-wildcard-search-11
[11] dont allow empty wildcard search
2017-03-14 23:09:19 -06:00