011aab52ff
Merge pull request #13156 from nextcloud/enhancement/npmize
...
Use npm for js depdencies, bundle with webpack
2019-01-09 20:16:05 +01:00
1728075946
Bump select2 from 3.4.5 to 3.4.8
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 16:57:08 +01:00
83068c39e5
Update select2, include css
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 15:02:01 +01:00
15400fcf7b
Use `jquery-ui-dist` instead of `jquery-ui` to resolve an issue with effects
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 15:02:01 +01:00
01a6181d9f
Don't load old vendor files during jsunit tests
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 15:02:00 +01:00
1e80259051
Remove core.js
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 15:02:00 +01:00
5bf06a19a8
Move vendored css ponyfill to npm
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 15:02:00 +01:00
208788173d
Npmize (vendor) scripts
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 15:01:59 +01:00
2cebdbbf2d
use triple equal signs according to style guide
...
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-09 11:28:51 +01:00
2fa36a768f
move to new folder
...
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-09 11:28:51 +01:00
dd0b0d8711
use triple equal signs according to style guide
...
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-09 11:28:51 +01:00
808cf39961
change menu's orientation to make sure it is completly visible
...
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-09 11:28:51 +01:00
b555fb3ff5
open name prompt on pressing enter
...
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-09 11:28:51 +01:00
ff1e0e2302
reset name of new folder and prevent the form from being submitted twice
...
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-09 11:28:51 +01:00
dba14fac8b
add functionality to create new folder in file picker
...
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-09 11:28:51 +01:00
076f6b8ed1
Merge pull request #13363 from nextcloud/fix/loginflow_apptoken_ios
...
Fix loginflow with apptoken enter on iOS
2019-01-04 22:42:24 +01:00
e6ac233947
Fix loginflow with apptoken enter on iOS
...
It seems iOS doesn't like us to change the location. So now we submit it
to the server that geneartes the redirect.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-04 21:51:36 +01:00
0aa30b76de
Merge pull request #13134 from nextcloud/bugfix/13088/404-instead-of-exception
...
returns a 404 instead of exception if app is not installed - #13088
2019-01-04 17:08:04 +01:00
248e824f48
Remove check for outdated caches
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-01-02 10:46:14 +01:00
a3be286273
Make setup check also pass with a 501 status
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-12-19 07:41:25 +01:00
b0ac37d778
Merge pull request #13033 from RandieM/password-reset-checkbox-invisible
...
fixes issue #12383
2018-12-13 19:43:46 +01:00
6e91329872
Merge pull request #12923 from nextcloud/fix/12832/share-autocomplete
...
Fixes the share autocomplete layout
2018-12-13 14:07:18 +01:00
7fb312b07a
fixes issue #12383
2018-12-12 15:37:45 +01:00
91ba494caf
Move to handlebars.runtime.min
...
Since we do no longer allow to compile handlebars online because of the
CSP anyway. it makes sense to also move away from the full handlebars
suite 71kb vs 14kb
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-10 22:15:35 +01:00
5723f77ef7
Fixes the share autocomplete scrollbars
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-12-08 20:51:06 +01:00
17b2827bbf
Add setup check for pending bigint conversion
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-12-05 13:42:31 +01:00
5b22225351
Update casing of PHP inside method name
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-12-05 00:03:05 +01:00
f5ad80fc57
Add setup check for recommended PHP modules (i.e. Imagick, intl)
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-12-05 00:03:05 +01:00
388f5dd6cc
Merge pull request #11718 from nextcloud/dependachristoph/bower/jquery-ui-1.12.1
...
Bump jquery-ui from 1.10 to 1.12.1
2018-12-04 10:19:56 +01:00
2824622feb
Fix dialogs, button position
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-11-30 16:11:33 +01:00
a915594b03
Merge pull request #12734 from nextcloud/feature/noid/check-nginx-woff2
...
Add check for missing .woff2 rule in Nginx via setup check
2018-11-29 19:36:56 +01:00
6aefd8389b
Merge pull request #12732 from nextcloud/polishing-fixes
...
Polishing fixes
2018-11-29 18:21:31 +01:00
f77e519137
Merge pull request #12674 from nextcloud/date-title-to-linkshare
...
Date title to linkshare
2018-11-29 17:02:14 +01:00
f5894b653d
Add check for missing .woff2 rule in Nginx via setup check
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-29 17:01:43 +01:00
d526ab55fb
Fix default filepicker style and gridview
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-29 14:05:10 +01:00
5e4990fadd
Remove redirect page
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-29 10:27:22 +01:00
ec93cf7603
Update to jquery-ui v1.12.0
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-11-26 21:06:15 +01:00
f735c65db2
Better identification of the public link shares
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-26 18:41:49 +01:00
8e240d1197
Properly handle errors (including 500)
...
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-24 23:55:42 +01:00
654880da25
Merge pull request #12468 from nextcloud/multiselect-removal-fix
...
Remove conflicting multiselect
2018-11-22 08:49:09 +01:00
78056a3bef
Fix whitespace and file action cleanup
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-20 19:46:49 +01:00
61c869675d
Compile handlebars
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-20 19:46:49 +01:00
fb8aa31dbf
Allow to hide download option for folders shared by link
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-20 19:46:35 +01:00
ebc690bbe3
Merge pull request #12491 from nextcloud/share-menu-click-fix
...
Fix share link password input
2018-11-20 15:35:22 +01:00
7a9ea03943
Fix share link password input
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-20 14:40:40 +01:00
a9de88e96e
Merge pull request #12350 from nextcloud/filepicker-sorting
...
Enable sorting in file picker
2018-11-20 13:34:51 +01:00
5e5cced48c
Properly align loading indicator when switching folders
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-16 14:50:40 +01:00
916cdb260e
Flip sort indicators
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-16 14:12:47 +01:00
3e11337b3b
Allow sorting in the file picker
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-16 14:12:41 +01:00
d0e2a22e83
Fix login loader position and theming support
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-16 12:48:13 +01:00
a8dafc2ff8
Remove conflicting multiselect
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-15 14:08:13 +01:00
0c9e411f76
Merge pull request #12418 from nextcloud/bugfix/noid/do-not-show-integrity-warning-always
...
Remove outdated integrity warning on each page
2018-11-12 22:44:55 +01:00
761ba1801b
Remove outdated integrity warning on each page
...
* integrity warning is shown during update and in the admin setup checks
* there is also the plan to retire this old way of notification
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-12 16:54:38 +01:00
cddc6c0207
fixup! Use nextcloud-password-confirmation
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-12 12:54:17 +01:00
1cb5f316ed
Use nextcloud-password-confirmation
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-12 11:59:38 +01:00
f77e24e725
Merge pull request #12332 from nextcloud/bugfix/12314/existing-link-title
...
Also use default label if share label is null
2018-11-07 16:58:41 +01:00
35a9c51efa
Merge pull request #12334 from nextcloud/bugfix/12164/share-dialog-userid
...
Only show label if the shareWith value is relevant
2018-11-07 16:56:55 +01:00
d110f0c29c
Also use default label if share label is null
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-07 16:04:51 +01:00
8ed945a519
Only show label if the shareWith value is relevant
...
For local users / groups the display name is enough to show, we just need details for email/remote shares
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-07 15:40:50 +01:00
2ba519a5d4
Add es6-shim as polyfill and minify underscore.js
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-07 11:14:18 +01:00
0f1edd538e
Merge pull request #12273 from nextcloud/public-share-enforce-pass-fix
...
Fix password enforce on public share links
2018-11-06 18:28:08 +01:00
a3bf860be7
Fix sharedialog failure handler
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-06 10:47:27 +01:00
eeeb19079f
Add focus on pending popover opening
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-06 10:32:00 +01:00
e0de0a122f
Disable grid for ie
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-05 17:27:09 +01:00
11b6c22595
Fix password enforce on public share links
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-05 10:50:06 +01:00
72b7c9ffa0
Merge pull request #12105 from nextcloud/using-resharing-right-to-display-shares
...
Shares are displayed to users with resharing rights
2018-11-04 21:08:11 +01:00
a696c011c2
Fix app menu calculation for random size of the right header
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-02 19:57:06 +01:00
376704e834
Add "Password protect by Talk" to the menu of link shares
...
When Talk is enabled the menu for link shares now shows a checkbox to
protect the password by Talk (that is, to show the "Request password by
Talk" UI in the authentication page for the link share).
Although in e-mail shares protecting the share with a password and
protecting the password by Talk are mutually exclusive actions (as when
the password is set it is sent to the sharee, so it must be set again
when protecting it by Talk to be able to verify the identity of the
sharee), in the case of link shares protecting the password by Talk is
an additional step to protecting the share with a password (as just
setting the password does not disclose it to anyone). As such, the
checkbox is shown only when there is a password set for the link share
(even if the field itself for the password is not shown, like when they
are enforced in the settings).
Note that the icon set for the field, "icon-passwordtalk", does not
currently exist; it is the same used for e-mail shares, and it is needed
simply to get the right padding in the menu.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-02 13:30:18 +01:00
2a17811caf
Use property to check if a share entry is shared with the current user
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-02 12:10:48 +01:00
2804f3a761
Add uid_owner to enable permission settings on the views
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-02 12:09:29 +01:00
59377dbd50
Remove reshare owner entry from the share list
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-02 12:09:29 +01:00
b73e03724c
Show share settings for owner and reshare owners only
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-02 12:09:29 +01:00
f28691c26e
Merge pull request #11844 from nextcloud/multiple-link-shares
...
allow to create multiple link shares via share api
2018-11-01 22:36:09 +01:00
876d6ec8e6
Fixed jsunit
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-01 21:33:11 +01:00
0a70544cd9
Password policy fix and menu open on first share
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-01 21:33:11 +01:00
9dea41f8fe
Fix wording, sort 'Add another link' to bottom so it does not confuse
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-11-01 21:33:10 +01:00
a7ea3d29fa
Fix password enforcement
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-01 21:33:05 +01:00
260290ec41
Fix enforce date
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-01 21:30:46 +01:00
206d6126b6
Fix note display
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-01 21:30:45 +01:00
106ed07d6a
Copy link outside menu
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-01 21:30:45 +01:00
1bd6d39b39
Migrate link shares to array
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-01 21:29:40 +01:00
95e34407bf
Add tests for edit permission state on file shares
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-31 12:12:24 +01:00
2c990ade77
Do not set indeterminate state for file shares
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-31 11:23:23 +01:00
41ff001b77
Merge pull request #11899 from nextcloud/enhancement/noid/sharing-consolidation
...
Sharing user consolidation
2018-10-30 19:27:05 +01:00
a1e3098322
Add "Hide download" to the menu of link shares
...
Hiding the download does not depend on other settings and it does not
affect other settings either (for example, it would be possible to hide
the downloads yet make the share editable), so a simple checkbox was
added to the menu. However, note that this option is only available for
files, but not for folders.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-30 15:18:55 +01:00
e6952edaf4
Don't enforce merged property
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 11:37:11 +01:00
f116461d4b
Show one share method per contact for inaccurate results
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:36 +01:00
e8e898ede8
Use tab to complete selected entry to the share entry
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:35 +01:00
3313c0142d
Simplify share list text
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:35 +01:00
3e11515b9c
Merge contacts and add type of result to the UI
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:34 +01:00
06d8438fda
Group share suggestions by userid
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:34 +01:00
a1c6e44700
Add collaborators uuid to properly render the avatar and for later grouping
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:33 +01:00
e5cae301eb
Highlight search term in sharing results
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:33 +01:00
6dde7e1183
Improve share select list
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:32 +01:00
0a2476fcb3
Merge pull request #11988 from nextcloud/docs/jsdoc-build
...
JSdoc build fixes and move build script out of the root folder
2018-10-25 15:49:27 +02:00
116268a2b5
Merge pull request #11893 from caugner/7837-filesize-format-with-locale
...
Formats file sizes using the user's locale
2018-10-25 14:05:20 +02:00
d14434fa2e
Adjust some jsdocs
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-24 16:24:16 +02:00
37782b1084
Merge pull request #11573 from nextcloud/gridview-table
...
Files grid view
2018-10-24 15:31:23 +02:00
df6e9109c8
Merge pull request #11396 from nextcloud/wellknown-webfinger
...
adding .well-known/webfinger
2018-10-24 14:51:15 +02:00
d5e142a336
OC.getCanonicalLocale: fix tests
...
Signed-off-by: Claas Augner <git@caugner.de>
2018-10-24 11:17:58 +02:00
00b8be60f2
humanFileSize: use toLocaleString
...
humanFileSize: add test with locale
humanFileSize: use canonical locale
humanFileSize: skip test w/o toLocaleString support
humanFileSize: stub getCanonicalLocale
OC.getCanonicalLocale: cover undefined case
humanFileSize: fix getCanonicalLocale stub
Signed-off-by: Claas Augner <git@caugner.de>
2018-10-24 09:18:39 +02:00
b6981dcecb
Merge branch 'master' of https://github.com/nextcloud/server into gridview-table
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 16:44:20 +02:00
26ca7a0e2f
Add filepicker toggle
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 10:38:00 +02:00
c039bd2bd1
Filepicker grid
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 10:04:03 +02:00
c5d3febf37
Add missing variable declarations
...
This fixes errors from LGTM like the following one:
Variable i is used like a local variable,
but is missing a declaration.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-19 20:17:55 +02:00
efee380e95
Merge pull request #11885 from dpeukert/master
...
Check if the X-XSS-Protection header contains the required fields
2018-10-19 15:32:17 +02:00
2ad38200fb
Add missing semicolons
...
This fixes some recommendations from LGTM:
Avoid automated semicolon insertion (90% of all statements
in the enclosing function have an explicit semicolon).
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-19 11:24:24 +02:00
7a5d6ac15c
Fix failing tests and add some more
...
Signed-off-by: Daniel Peukert <dan.peukert@gmail.com>
2018-10-17 18:51:01 +02:00
2da4f96bd6
Remove arrow function
...
Signed-off-by: Daniel Peukert <dan.peukert@gmail.com>
2018-10-17 18:10:37 +02:00
b2dfcb5a18
Check if the X-XSS-Protection header contains the required fields
...
Signed-off-by: Daniel Peukert <dan.peukert@gmail.com>
2018-10-17 14:28:51 +02:00
0b4ea70995
Tests: Remove spacing from html before comparing the template
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-16 10:49:34 +02:00
0a4a23f015
Move jquery.contactsmenu.js to compiled handlebars
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-16 09:51:36 +02:00
056a74e323
Fix plural function to be hardcoded
...
No more weird eval to construct a plural function.
We just use the plural function from symfony.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-14 20:45:36 +02:00
365f68372f
Use jQuery.getScript to dynamically load script
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-14 20:45:36 +02:00
b68661ed6e
Allow "same-origin" as "Referrer-Policy"
...
Fixes #11531
Although "same-origin" is more strict than e.g. strict-origin it showed up a warning in setupcheck
Based on https://scotthelme.co.uk/a-new-security-header-referrer-policy/
Signed-off-by: Moritz Beck <git@birkenstab.de>
2018-10-11 13:17:26 +02:00
fe45db6ae2
Merge pull request #11744 from burned42/fix_percent_sign_breaking_all_files_view
...
Remove duplicate call to decodeURIComponent
2018-10-11 12:20:07 +02:00
c2916b62d3
Ignore "session_lifetime" if it can not be converted to a number
...
When "session_lifetime" can not be converted to a number the interval
becomes a NaN due to dividing it by 2. This NaN was "dragged" over all
the other mathematical operations and caused the csrftoken to be got
again and again due to an infinite loop with no pauses in "setInterval".
Now, the interval is set to the default value instead if the
"session_lifetime" can not be converted to a number.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-11 10:53:25 +02:00
0f030d885b
Remove duplicate call to decodeURIComponent
...
Signed-off-by: Bernd Stellwag <burned@zerties.org>
2018-10-11 08:00:28 +02:00
d143b43a04
Make possible to set the expected status of the well known URL check
...
The check is based on the HTTP status returned by the URL, and different
URLs may return different status (for example, DAV returns 207, while
a service like WebFinger would return 200), so the expected status needs
to be set depending on the URL.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-10 13:48:56 +02:00
b8d54bd53a
Fix a misleading setup check for .well-known/caldav & carddav
...
The problem is that the version without the slash is the correct one.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-10 10:41:02 +02:00
9af69ca2a5
Fix usage of deprecated OC.webroot
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-09 13:53:59 +02:00
43ed8bb91a
Merge pull request #11693 from nextcloud/refactor/remove-legacy-sharemodel-areavatarsenabled
...
Remove deprecated and unused legacy ShareConfigModel.areAvatarsEnabled()
2018-10-09 09:09:35 +02:00
47f0447ce0
Remove deprecated and unused legacy ShareConfigModel.areAvatarsEnabled()
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-09 07:58:06 +02:00
e836a1457c
Remove deprecated and noop APIs from OC.AppConfig
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-09 07:54:34 +02:00
6994a2a87d
Merge pull request #11679 from nextcloud/refactor/remove-ie8-apis
...
Remove IE8 APIs
2018-10-08 18:36:07 +02:00
3330600dc5
Merge pull request #11682 from nextcloud/refactor/remove-deprecated-unused-fileDownloadPath
...
Remove deprecated and unused fileDownloadPath
2018-10-08 18:04:08 +02:00
8acd503975
Merge pull request #11681 from nextcloud/refactor/remove-deprecated-getScrollBarWidth
...
Remove deprecated window.getScrollBarWidth
2018-10-08 17:43:10 +02:00
576e44f890
Remove deprecated and unused fileDownloadPath
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-08 16:46:36 +02:00
a0499f4404
Remove deprecated window.getScrollBarWidth
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-08 16:41:33 +02:00
dccb3ab5b2
Remove deprecated SVG helpers for old IEs
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-08 16:33:41 +02:00
d9783af7bd
Remove outdated comment
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-08 16:21:31 +02:00
d5b53d0ede
Remove OC.isIE8
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-08 16:18:51 +02:00
dd459bbb7a
Remove OC.scaleFixForIE8
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-08 16:17:16 +02:00
8932a51b91
Extract translated strings of compiled handlebars
...
Follow up to #11615
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-05 12:32:48 +02:00
363ec1d3c3
Remove leftover '
...
Followup to #11583
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-04 16:02:09 +02:00
b0fd31496b
Move OC.Share to compiled handlebars
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-04 09:53:45 +02:00
cd7c17482e
Move systemtags to compiled handlebars
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-04 09:53:44 +02:00
c8e617b07c
Set nonce for loading the zxcvbn
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-03 17:05:01 +02:00
48f483a352
Add missing compiled mimetype list - see #10135
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-01 15:54:02 +02:00
9b8e884b19
Change wording of 'Copy URL' to more understandable 'Copy link'
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-01 11:02:12 +02:00
7e5b7f75ba
Bump templates to handlebars 4.0.12
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-28 21:17:08 +02:00
d867f9f091
Merge pull request #11037 from nextcloud/trash-webui-dav
...
Use trashbin dav endpoint to list trash in webui
2018-09-28 16:03:24 +02:00
c9e93b8084
Compile contactmenu handlebars templates
...
Fixes #11029
For https://github.com/orgs/nextcloud/projects/18
Ship the compiled handlebars templates. This makes it possible to have a
scricter CSP.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-27 20:33:58 +02:00
073fddcc28
fix trashbin infoparsers interfering with other dav clients
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-20 17:03:56 +02:00
91066954a8
pass existing data to info parsers
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-20 17:03:30 +02:00
dda0dfd5f1
Merge pull request #11171 from nextcloud/bugfix/noid/shared-by-info-for-room-shares-without-names
...
Better shared-by info for conversations without names
2018-09-19 13:45:31 +02:00
a2c8b3f00b
Merge pull request #11151 from nextcloud/davclient-js-decode
...
fix js files client for user names with spaces
2018-09-13 11:17:29 +02:00
d062c8687b
Merge pull request #11036 from nextcloud/fix/10903/users-undefined-maxautocompleteresults
...
fix check for more users in sharing dialogue
2018-09-13 09:49:43 +02:00
a1c969a170
Merge pull request #10840 from webfoersterei/refactor/5530-urandom-check
...
Refactor secure randomness check
2018-09-13 09:29:42 +02:00
b628ec4701
adjust and extend js unit tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-09-12 17:49:48 +02:00
7f0de11bd5
Better shared-by info for conversations without names
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-09-11 12:57:36 +02:00
4893e1765f
don't user a higher paging size than max autocomplete entries are set
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-09-10 23:15:46 +02:00
e7b0f8b001
fix check for more users
...
after a refactor users et al were undefined. The check condition was moved.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-09-10 23:15:42 +02:00
4491a41a72
fix js files client for user names with spaces
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-10 22:37:01 +02:00
c14c6e5ccf
Make possible to pick both files and folders
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-30 14:40:12 +02:00
f080fa55ac
Store the mime type filter always as an array
...
This will make easier to check if both directories and files should be
pickable.
This also removes an unused assignment to the mime type.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-30 14:23:47 +02:00
66f2b155ce
Fix empty mime type filter
...
When the mime type is an empty array no filter should be applied.
However, the filter was loosely compared to an empty array, but as
arrays are objects then it became an implicit strict equality comparison
which always failed due to being different objects. Now the length of
the array is compared instead, and also moved outside the loop as it is
not needed to check it for each file.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-30 14:02:50 +02:00
4508a12188
Prevent default action from being executed when the button is disabled
...
When "enter" is pressed in the file picker a "click" event is triggered
on the primary action button. However, in some cases, like when the file
picker is in "Choose" mode and the current directory in the file picker
is the root folder, the primary action button is disabled. In those
cases pressing enter should not trigger a click action on the button and
be ignored instead.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-30 10:25:09 +02:00
1edf345d4d
Use empty alt tag for avatars since there is always the name next to it
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-26 18:29:02 +02:00
006e150c87
Change check if secure randomness is possible.
...
Signed-off-by: Timo Förster <tfoerster@webfoersterei.de>
2018-08-24 23:12:02 +02:00
8761856a71
Merge pull request #10838 from nextcloud/header-fixes-and-public-note
...
Header fixes and public note
2018-08-24 22:21:55 +02:00
13230f180a
Fix jsunit
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 22:05:48 +02:00
7ce520e83e
Add support for rooms in the list of candidates to share with UI
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-24 18:06:48 +02:00
421daf6ab0
Fix public share link order
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 17:40:05 +02:00
ddd18aa375
Fix public link order and fix skip to content
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 16:54:01 +02:00
3cb52b868a
Fix header calculation and better public design
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 15:45:39 +02:00
ba66cad1b4
Fix keyboard menu element event detection
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-22 09:54:40 +02:00
2bab916c53
Adds license to files. Updates the branch.
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 20:46:23 +02:00
6d749bf021
Merge pull request #10700 from nextcloud/fix/10516/sharepermissions
...
Fix share dialog sidebar in share views
2018-08-20 17:14:12 +02:00
37869d9b2f
Merge pull request #10628 from nextcloud/feature/10154/app-directory-permission-check
...
Adds a permission check for app directories
2018-08-20 17:08:18 +02:00
7aed47f776
Adds tests for the memory checks
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 15:24:10 +02:00
c164409ee7
Adds a memory limit warning for console commands if the limit is below the recommended value
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 15:24:10 +02:00
1d2bc9c45e
Adds tests for the setup memory limit checks
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 15:24:10 +02:00
c2fced4463
Adds a setup check for the memory limit
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 15:24:10 +02:00
be873c234b
adapt jsunit test
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-16 23:08:15 +02:00
d79943f498
Merge pull request #10608 from nextcloud/header-menu-fixes
...
Fix header menu & contact popover
2018-08-16 09:50:25 +02:00
c435bfe703
Disabled checkboxes and design fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-16 07:31:17 +02:00
e89567eb53
Take base permissions from DAV, fixes #10516
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-15 15:27:31 +02:00
b9c448d855
Fix password enforce on public links
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 11:51:25 +02:00
846b8572ed
Tests fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-10 13:54:21 +02:00
7191d676ab
Merge pull request #10619 from nextcloud/bugfix/4550/redirect-page-update
...
Redirect to the same page after an update
2018-08-10 11:14:03 +02:00
ebcfe33d0d
Extends the setup check js tests
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-09 19:48:39 +02:00
b2e60e365d
Adds a setup check for app directory permissions.
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-09 19:47:55 +02:00
46d340045d
Merge pull request #10598 from schoonc/patch-1
...
Removed unused variable isFile
2018-08-09 17:00:03 +02:00
4823b2746e
Redirect to the same page after an update
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-09 15:19:58 +02:00
fc4f122881
Align to the left
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-09 12:47:50 +02:00
b0917dfac9
Removed unused variable isFile
2018-08-09 00:30:42 +03:00
e1561f0e8f
Add custom handling for room shares to the resharer information
...
Like done with group shares, received room shares are described as such
in the UI.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:44 +02:00
2d062daa11
Add custom handling for room shares to the list of sharees
...
Like done for other types of shares, room shares are now explicitly
described as such in the UI.
The avatar used is the image provided in the "shareWithAvatar" property
of the share. If none is given then the avatar is the first letter of
the display name of the room share with a coloured background seeded
from the room token. If the display name of the room is empty then no
letter is shown in the avatar; no special handling is done in that case.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
7292a986a0
Add type for room shares
...
This type represents shares with a Nextcloud Talk conversation.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
6d7bf81421
Fix HTML on update error page
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-08-03 13:30:49 +02:00
4574698443
Fix double container on 'Possible CSRF attack' page
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-08-01 18:54:48 +02:00
369a6c13eb
Merge pull request #10474 from danielkesselberg/bugfix/10379/no-files-in-here
...
Set emptyText depending on filepicker type
2018-08-01 12:56:08 +02:00
6b9093ce6d
Set emptyText depending on filepicker type
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-07-31 22:49:01 +02:00
3f45ab97da
Improve URL detection
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-31 17:11:46 +02:00
bc83656604
Reword share comment feature
...
Fixes #10403
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-31 14:20:22 +02:00
1f635bb892
Use small loading indicator for avatars smaller than 32px
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-25 14:26:27 +02:00
a96137ef0b
Merge pull request #10310 from nextcloud/accessibility-header
...
Accessibility fixes for header and global elements
2018-07-25 00:07:37 +02:00
fe25092312
Remove deprecated keyboard events & properties
...
Signed-off-by: Kevin Ndung'u <kevgathuku@gmail.com>
2018-07-24 19:02:56 +02:00
911093549e
Make possible to enable "sending password by Talk" from the share menu
...
Until now the password to be sent by mail was set by enabling a checkbox
in the share menu and then entering the password in an input field shown
below. Now, when Talk is enabled, another item is added to the share
menu to do the same for a password to be sent by Talk.
Sending the password by mail and sending it by Talk are mutually
exclusive actions, so when one of the checkboxes is enabled the other
one is automatically disabled.
Note that the icon set for the field, "icon-passwordtalk", does not
currently exist; it simply mimics the "icon-passwordmail" (which does
not exist either) used for the field of the password protect by mail to
get the right padding in the menu.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 14:45:42 +02:00
0274507cb1
Acceptance and mobile navigation fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 11:01:11 +02:00
b41d0d32e2
Merge pull request #10218 from nextcloud/share-comments
...
allow to add a personal note to a share
2018-07-24 09:12:03 +02:00
705439ca7b
Do not bind reset password link if an url is set
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-23 15:01:03 +02:00
da0bdd1391
Design structure fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 16:09:13 +02:00
58debbe42c
Tests fixes and design bump
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:21 +02:00
e302cadae2
Don't use shorthand syntax for functions
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-21 15:02:21 +02:00
d4de77afb9
No remote note and various fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:21 +02:00
3a11c26cb4
Public fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
c71d3dc9bf
Public share
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
967a97904f
fix post url
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:20 +02:00
fc2767bbbb
Autoresize + autoloader
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
0a7e34f6c8
Popovermenu migration
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
4e08d8342e
UI set share note!
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
8d3f58c391
Jsunit fixes 1
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:04 +02:00
d6b718584e
Sidebar fix
...
Fix sidebar and scrollbar on content
Sidebar fixes, and sidebar-width + header-height variables
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:37:00 +02:00
7f0d60fefc
Enter key on menu registration
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:19:55 +02:00
6d083c4de9
Make left sidebar toggle also work with keyboard
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-20 23:19:55 +02:00
07271087b0
Fix style of the user facing whats new popup
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-17 14:02:14 +02:00
82021b2b1b
Merge pull request #5280 from nextcloud/shared-with-display-name
...
sharedWithDisplayName & sharedWithAvatar
2018-07-13 17:29:57 +02:00
14314584ba
Merge pull request #10110 from nextcloud/feature/100500/whats-new-info-users
...
Display What's New info to users
2018-07-13 17:25:51 +02:00
83b1de4493
Fix unit tests - follow up to #10197
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-11 22:02:45 +02:00
3036b1d03d
Merge pull request #9895 from nextcloud/fed-group-shares
...
implement federated group sharing
2018-07-11 21:44:48 +02:00
5262d60e94
Merge pull request #10197 from nextcloud/feature/9410/improve-opcache-feedback
...
Improve opcache feedback
2018-07-11 19:27:09 +02:00
72d17ff02c
Improve url detection in comments
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-11 16:23:56 +02:00
f6f49c77f7
opcache module check
...
Improved the speed of isOpcacheProperlySetup() (instant return instead of continuing when we're already failed), added a check for the opcache extension itself. Potentially fixes #9410
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-11 16:08:40 +02:00
f0aaf62b24
fix js tests
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:49 +02:00
2abc705632
start to get fed group shares into the share dialog
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:47 +02:00
ca6094f390
wire the frontend
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-05 20:29:00 +02:00
772bbd99be
Backend work to provide NC whats New info to users
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-05 14:33:08 +02:00
6a0c54d5bf
Add warning to setup checks if the default mailer is still php
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-04 08:28:33 +02:00
f824ff500d
Fix code integrity check-warning link
...
Signed-off-by: Marius Blüm <marius@lineone.io>
2018-06-29 11:33:29 +02:00
61842f66ee
Merge pull request #5623 from nextcloud/locale-setting
...
Add user locale/region setting
2018-06-29 08:03:43 +02:00
fd41192bb4
fix OC.getLocale()
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-27 13:19:49 +02:00
bf6bfad76b
OC.getLocale() now returns Locale and no longer Language
...
Added OC.getLanguage() to get Language
<html lang=''> still gets language, though according to IETF BCP47 locale should be good.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-06-27 13:19:40 +02:00
e1936a49e7
Fix "parsing" of email-addresses in comments and chat messages
...
\\b matches any non-word character, including \@ and \-
In order to not detect urls in the middle of email-addresses,
we need to check for white space characters and beginning of the
message instead.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-06-27 13:04:05 +02:00
8ed50d4b63
prefill userid for login after password reset
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-21 15:18:07 +02:00
8ebc3d90a0
Merge pull request #9518 from nextcloud/feature/5986/public_share_controller_middleware
...
Public share middleware & controller
2018-06-21 10:09:20 +02:00
938553ab07
IE11 css vars compatibility
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:21:54 +02:00
31392c2443
Move public auth page over
...
Now this is in core so the basics (that 99% of the app will want to
use) looks always the same.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:53:37 +02:00
d82ef72161
Merge pull request #9197 from nextcloud/fix-avatar-center
...
Fix avatar generator centering
2018-06-15 16:16:13 +02:00
ed4309ce41
Unify colour algorithm output
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-13 18:46:04 +02:00
9c4aecb539
Merge all setup checks into one controller
...
* renamed hasMissingIndexes to missingIndexes
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-13 15:25:08 +02:00
cd87a40eb3
Merge pull request #9836 from nextcloud/feature/noid/merge-tips-and-tricks-into-setup-checks
...
Merge tips & tricks section into setup checks
2018-06-13 13:18:40 +02:00
4a0b7aaf6c
Merge tips & tricks section into setup checks
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-13 12:05:38 +02:00
624d191ef6
Fix wrong hint about missing indexes
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-13 11:56:43 +02:00
393d9aae74
Add a hint that some indexes are not added yet
...
* gives the admin a chance to discover the missing indexes and improve the performance of the instance without digging through the manual
* nicely integrated in the setup checks where this kind of hints belong to
* also adds an option to integrate this from an app based on events
* fix style of setting warnings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-06 16:55:01 +02:00
4b70c9f89d
Add referrer policy setup check
...
Fixes #9122
Based on https://www.w3.org/TR/referrer-policy/ and
https://scotthelme.co.uk/a-new-security-header-referrer-policy/
Setting a sane Referrer-Policy will tell the browser if/when to send
referrer headers when accessing a link from Nextcloud. When configured
properly this results in less tracking and less leaking of (possibly)
sensitive urls
* Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-04 09:21:35 +02:00
10b33cd5d0
Add placeholder to input in OCdialog prompt
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-24 14:02:25 +02:00
33b65faba0
Allow to specify custom text on admin password confirmation dialogs
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-24 14:01:58 +02:00
2e3517eb00
display details on sharing panel
...
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
2018-05-21 01:24:45 +02:00
0009adae80
SharedWithDisplayName + SharedWithAvatar
...
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-05-21 01:24:45 +02:00
d607e7b924
Move the webui over to the new dav endpoint
...
We should use the new dav endpoint everywhere now.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-08 23:02:19 +02:00
43c1e51a5f
Merge pull request #9151 from UncleAlbie/dialog-sort
...
Sort files in dialog by name.
2018-05-07 18:39:24 +02:00
0771dad57f
Do not add sharePermission logic in JS
...
We have a dedicated dav property. We should do all the magic in 1 place.
Not several.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 12:14:37 +02:00
0bae516c66
Merge pull request #9224 from nextcloud/accessibility-improvements
...
Add labels for Contacts menu and Settings, thanks to @MarcoZehe
2018-04-19 14:47:17 +02:00
f8e3b572c8
Remove no longer needed escaping of special characters
...
The escaping of special characters was needed when the ids of the
permission checkboxes for shares were based on the "shareWith" field.
Since they are based on the "shareId" field the escaping is no longer
needed, as the "sharedId" is expected to always contain compatible
characters.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-18 17:03:45 +02:00
1466586033
Fix ids of permission checkboxes for shares
...
The ids of permission checkboxes for shares were generated using the
"shareWith" field of the share. The "shareWith" field can contain spaces
(as spaces are allowed, for example, in user or circle names), so this
could cause the id attribute of the HTML element to contain spaces too,
which is forbidden by the HTML specification.
It is not just a "formal" issue, though; when the list was rendered, if
the id contained a space the selector to get the checkbox element was
wrong (as it ended being something like
"#canEdit-view1-name with spaces") and thus the initial state of the
checkbox was not properly set.
Besides that, "shareWith" can contain too single quotes, which would
even cause the jQuery selector to abort the search and leave the UI in
an invalid state.
Instead of adding more cases to the regular expression to escape special
characters and apply it too when the ids are created now the ids of
permission checkboxes for shares are based on the "shareId" field
instead of on "shareWith", as "shareId" is expected to always contain
compatible characters.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-18 15:25:23 +02:00
df3c1ac283
Add proper ARIA attributes and structure to header for accessibility, thanks to @MarcoZehe
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 15:07:42 +02:00
e977246d7c
Sort files in dialog by name.
...
Signed-off-by: Patrik Novotný <patrik.novotny@gmx.com>
2018-04-18 08:44:40 +02:00
6cb40cf0c4
Fix js tests with placeholder
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-13 10:20:51 +02:00
04f47a7653
Merge pull request #8535 from nextcloud/new-color-generator
...
New color generator algorithm
2018-04-12 14:37:53 +02:00
d3f2b6aef4
Merge pull request #8820 from nextcloud/mtime-sort
...
Sorts filepicker files by modified date
2018-04-12 10:54:44 +02:00
8d27dce716
Merge pull request #9002 from nextcloud/whitespace
...
More whitespace: Increase header height from 45px to 50
2018-04-10 23:05:01 +02:00
275b9868b2
Fixed documentation
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-06 21:32:45 +02:00
bca8d83f02
New algorithm
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-06 21:32:44 +02:00
2e60f91ab1
Move external share saving to template
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 13:11:55 +02:00
bbeb3402b6
Move styling and menu handling to publicpage.js
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 12:21:39 +02:00
4a3538bbd8
Fix app menu, popovers and searchbox
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-04 15:05:58 +02:00
203bf51543
Keep showing the working icon while there are pending operations
...
Before, whenever a pending operation (getting the suggestions,
confirming a share or selecting a recipient) finished the working icon
was hidden and the confirm button was shown again, even if there were
other pending operations (the most common case is typing slowly on the
input field, as several operations to get the suggestions could pile if
the server response is not received fast enough). Now, the working icon
is not hidden until the last pending operation finishes.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-21 04:35:26 +01:00
a2c52cd6a5
Extract code to restore the UI after confirming a share
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-21 04:35:23 +01:00
9a0fbe307d
Discard cached suggestions when adding a share
...
The suggestions depend on the results returned by the server, but also
on the sharees already shared with. Due to that adding a share changes
the suggestions, so now the cached suggestions are discarded when a
share is added.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-21 04:34:14 +01:00
6eb5cc5412
Reuse last suggestions if the same parameters are used
...
When a share is confirmed the suggestions are got to check if there is
an exact match. Usually the suggestions were already got with the same
parameters in order to fill the autocomplete dropdown, so to avoid a
superfluous request now the last suggestions are reused when got again,
although only if the same parameters as the last time are used.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-21 04:31:08 +01:00
10a4f8e45e
Confirm a share also by pressing enter on the input field
...
Besides confirming a share by clicking on the confirm button now it is
possible to do it by pressing enter on the input field.
Clicking on the confirm button implicitly hides the autocomplete
dropdown. On the other hand, pressing enter on the input field does not,
so the autocompletion must be disabled and closed when the confirmation
begins and then enabled again once it finishes. Otherwise the
autocomplete dropdown would be visible and it would be possible to
interact with it while the share is being confirmed.
The order in which the input field and the autompletion are disabled is
important. Internally, the autocompletion sets a timeout when the input
field is modified that requests the suggestions to the server and then
shows them in the dropdown. That timeout is not cancelled when the
autocompletion is disabled, but when the input field loses its focus and
the autocompletion is not disabled. Therefore, the input field has to be
disabled (which causes it to lose the focus) before the autocompletion
is disabled. Otherwise it could happen that while a share is being
confirmed the timeout ends, so an autocompletion request is sent and
then, once the share is successfully confirmed and thus the
autocompletion is enabled again, the request is received and the
autocomplete dropdown is shown with the old suggestions. Strange, but
possible nevertheless ;-)
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:05 +01:00
9371b61c4d
Add a share when clicking on the confirm button
...
Clicking on the confirm button now adds a share, but only if there is
just a single exact match. If there are no exact matches or there is
more than one exact match no share is added, and the autocomplete
dropdown is shown again with all the suggestions.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:05 +01:00
5e2a8cca1b
Return also exact matches besides all suggestions
...
"_getSuggestions" returned all the suggestions from the server, which
are composed by exact matches and partial matches. Now the exact matches
are also returned on their own parameter. This will be used by the
button to confirm a share.
Note that until now the order of the suggestions was "exact users,
partial users, exact groups, partial groups, exact..."; this commit also
changes that order to become "exact users, exact groups, exact...,
partial users, partial groups, partial...". This is not a problem, as
the suggestions were used in the autocomplete dropdown, and this new
order is arguably better than the old one, as all exact matches appear
now at the beginning.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
89b0e34d9b
Extract code to filter suggestions to its own function
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
1c440519c2
Show an error when getting the suggestions succeeds with failure content
...
Instead of silently failing now an error is shown to the user when the
ajax call to get the suggestions succeeds yet it returns failure content
(for example, if an "OCSBadRequestException" was thrown in the server).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
ed1452d7a0
Use "showTemporary" instead of explicitly hiding the notification
...
"OC.Notification.hide" expects the notification to be hidden to be
passed as an argument. As it was being used to show a temporary
notification the combination of "OC.Notification.show" and
"OC.Notification.hide" was replaced by a single call to
"OC.Notification.showTemporary".
The timeout could have been specified in the options of the call, but it
was left to the default value (7 seconds) for consistency with other
notifications.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
fcef15af80
Move stub setup outside the test method
...
Stubs should be restored outside the test method in which they are used
to ensure that they are properly restored no matter the result of the
test (for example, if an exception is thrown).
Besides that, this will make possible to reuse the stub in other sibling
tests without having to explicitly setup it in them.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
d606219576
Extract code to get suggestions to its own method
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
3980364b6d
Add autocompletion tests for each type of share
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
8af9c553e6
Add tests for exact search results already shared with
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
375eab9df3
Add tests for emails and circles already shared with
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
6fef01c481
Adjust search term to test
...
As the server response is faked the search term is ignored in the tests.
However, it is clearer to use a search term that would make the server
return what the faked response contains.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:03 +01:00
ce7775acd0
Replace information icon with confirmation button in share input
...
The confirmation button right now is just an icon; its behaviour will be
added in the following commits.
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-03-20 19:09:03 +01:00
ed4b4458eb
Use the display name in the avatar for a circle share
...
Before, the avatar for a circle share was generated using the
"share_with" field as the seed for "imageplaceholder". Due to this, when
the "share_with" field is set to the circle ID the character shown in
the avatar was just a random character instead of the first character of
the display name. Now the "share_with" is still used as the seed for the
colour, but the display name is used as the text of the avatar.
This adds support for "share_with" fields set to the circle ID while
being backwards compatible with "share_with" fields set to the circle
name.
Note that when "share_with" fields is set to the circle name the colour
of the avatar is different in the list of suggested sharees and in the
list of current sharees, but that also happened before these changes
(due to a different seed being used in each place).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-16 04:58:25 +01:00
6bac63adec
sorts filepicker files by modified date
...
Signed-off-by: Sagorika Das <sagorika1996@gmail.com>
2018-03-14 18:11:50 +05:30
b9720703e8
Add CSRF token controller to retrieve the current CSRF token
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-03-08 16:48:50 +01:00
72861f2dfb
Use correct variables
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-04 14:12:29 +01:00
15a3caedc0
Create special option to toggle header menu container
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-04 14:12:29 +01:00
67699f9506
Clean scss, use proper loading icon and menu position on narrow screens
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-04 14:12:28 +01:00
ad7ddbc068
Set autocomplete=new-password for mail share password
...
This avoids the browser to do autocompletion on the mail share password
field.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-28 13:47:06 +01:00
7bc3c2e057
Merge pull request #7363 from nextcloud/default-share-perms
...
Let the admin configure the default share permissions
2018-02-27 13:44:34 +01:00
20ec0344a2
Fix JSDoc
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-27 12:29:25 +01:00
7466468af1
Fix share capabilities JS tests
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-02-27 12:29:25 +01:00
1615312bf1
add share permissions to settings page
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-02-27 12:29:25 +01:00
7d0102bf73
expose capabilities in js
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-02-27 12:29:25 +01:00
d07d66e24b
Add public template
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:52 +01:00
452e96e2a7
Merge pull request #8390 from dasisdormax/master
...
Add indeterminate state to share permission checkbox
2018-02-26 16:17:35 +01:00
3992484323
Remove unused var in OC.Notification.showTemporary
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-02-19 11:00:58 +01:00
Roeland Jago Douma
Christoph Wurst
Florian Schunk
Morris Jobke
Roeland Jago Douma
Daniel Kesselberg
Julius Härtl
John Molakvoæ
RandieM
Michael Weimann
Jan-Christoph Borchardt
John Molakvoæ (skjnldsv)
Tomasz Grobelny
Daniel Calviño Sánchez
Claas Augner
Claas Augner
Stefan Weil
Daniel Peukert
Moritz Beck
Bernd Stellwag
Robin Appelman
Joas Schilling
Arthur Schiwon
Joas Schilling
Timo Förster
schoonc
Kevin Ndung'u
Bjoern Schiessle
Cthulhux
Marius Blüm
Georg Ehrke
Thomas Citharel
Maxence Lange
Patrik Novotný
Sagorika Das
Vincent Petry