Commit Graph

1045 Commits

Author SHA1 Message Date
Morris Jobke f4d543b2de
Merge pull request #27007 from francoisfreitag/script
Prefer string $file over 1-element array in script()
2021-05-18 10:27:56 +02:00
Roeland Jago Douma e008b7915e
Merge pull request #27000 from nextcloud/enh/apptoken/check_apptoken
Harden apptoken check
2021-05-18 09:28:48 +02:00
François Freitag d887851183 Prefer string $file over 1-element array in script()
The string syntax is more obvious. There should be one (and preferably
only one) way of doing things.

Signed-off-by: François Freitag <mail@franek.fr>
2021-05-18 09:24:05 +02:00
Roeland Jago Douma 4a2775a442 Harden apptoken check
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-17 16:05:45 +02:00
dependabot-preview[bot] 93aff09bda
Bump @babel/core from 7.13.16 to 7.14.2
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.13.16 to 7.14.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.2/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-05-17 09:51:33 +02:00
Nextcloud bot 5ea903d824
[tx-robot] updated from transifex 2021-05-16 02:26:44 +00:00
blizzz b8b2e796bf
Merge pull request #26959 from nextcloud/techdebt/noid/verifiyuserdata-iaccountmanager
VerifyUserData shall use IAccountManager, not private API
2021-05-12 23:35:39 +02:00
Arthur Schiwon 9977027321
VerifyUserData shall use IAccountManager, not private API
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 22:57:20 +02:00
Arthur Schiwon a49588bbe5
PersonalInfo settings to use public AccoutManager API
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 22:55:34 +02:00
Nextcloud bot 488eea82dc
[tx-robot] updated from transifex 2021-05-10 02:31:42 +00:00
Nextcloud bot df71883c9a
[tx-robot] updated from transifex 2021-05-09 02:25:15 +00:00
Nextcloud bot 461a975749
[tx-robot] updated from transifex 2021-05-08 02:24:54 +00:00
Nextcloud bot 42f0f27240
[tx-robot] updated from transifex 2021-05-06 02:25:32 +00:00
Nextcloud bot 6d3aef1849
[tx-robot] updated from transifex 2021-05-04 02:26:15 +00:00
Nextcloud bot 5cccbbdd45
[tx-robot] updated from transifex 2021-05-01 02:26:34 +00:00
Nextcloud bot f3baab3159
[tx-robot] updated from transifex 2021-04-30 02:27:46 +00:00
dependabot-preview[bot] fdf54e9e43
Merge pull request #26736 from nextcloud/dependabot/npm_and_yarn/babel/core-7.13.16 2021-04-29 07:15:26 +00:00
Nextcloud bot e0f700b1bd
[tx-robot] updated from transifex 2021-04-29 02:26:26 +00:00
dependabot-preview[bot] c9b6f42c1a Bump @babel/core from 7.13.15 to 7.13.16
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.13.15 to 7.13.16.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.13.16/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-04-28 12:47:31 +00:00
Nextcloud bot be4f665d2d
[tx-robot] updated from transifex 2021-04-28 02:25:44 +00:00
Joas Schilling aa651fd629
Merge pull request #26259 from nextcloud/feature/noid/validate-website-to-be-valid
Validate the website field input to be a valid URL
2021-04-26 13:56:01 +02:00
Nextcloud bot 4ded8a08b7
[tx-robot] updated from transifex 2021-04-26 02:24:39 +00:00
Nextcloud bot da17db0fdc
[tx-robot] updated from transifex 2021-04-25 02:24:52 +00:00
Nextcloud bot 39764b05b1
[tx-robot] updated from transifex 2021-04-24 02:26:38 +00:00
Daniel Calviño Sánchez da84ed7d4c Fix active scope not visible in the menu if excluded
Depending on some settings (for example, if lookup server upload is
disabled) some items can be hidden in the scope menu. However, if the
user selected an scope in the past once the settings were changed the
scope was no longer visible in the menu. Now the active scope will be
always visible in the menu, although if it is an excluded scope it will
be disabled. Selecting any other scope will then hide the excluded and
no longer active one.

When upload to the lookup server is disabled the scope menu was hidden
for display name and email in the personal information settings; now the
menu will be always shown to enable the above described behaviour.

Note that the menu will be shown even if there is a single available
scope so the user can read its description.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:42 +02:00
Daniel Calviño Sánchez 67dd087ce4 Fix deleting properties of user settings when not given explicitly
The controller can receive an optional subset of the properties of the
user settings; values not given are set to "null" by default. However,
those null values overwrote the previously existing values, so in
practice any value not given was deleted from the user settings. Now
only non null values overwrite the previous values.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez ac0c18327e Fix TypeError when "email" is not given in the controller request
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez a7431817b9 Respect additional user settings not covered by the controller
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.

Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).

This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez c5e3d2e5c2 Add more unit tests for setting user settings
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez 190ffd75b7 Change default test data to values less similar to empty values
Right now it makes no difference, but this should make future tests
clearer, specially in case of failure.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +02:00
Daniel Calviño Sánchez ef5d538448 Extract default test data to a helper getter
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +02:00
Daniel Calviño Sánchez 8cae515daa Use constants from interface rather than class
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +02:00
Nextcloud bot 539c065e8e
[tx-robot] updated from transifex 2021-04-23 02:26:10 +00:00
Joas Schilling d80cc76ee7
Validate the website field input to be a valid URL
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 16:34:13 +02:00
Nextcloud bot 634b6b8b57
[tx-robot] updated from transifex 2021-04-22 02:26:21 +00:00
John Molakvoæ 3da956bcdc
Merge pull request #23529 from Simounet/feat/23397-settings-new-user-modal
Settings: new user row replaced by a modal
2021-04-21 16:38:46 +02:00
Morris Jobke 3e7f7e5f9b
Merge pull request #26474 from nextcloud/caugner-patch-mariadb-in-mysql-support-warning
Mention MariaDB in MySQL support warning
2021-04-21 16:26:37 +02:00
Simounet 45c3b2a478
Settings: new user row replaced by a modal
Signed-off-by: Simounet <contact@simounet.net>
2021-04-21 14:42:46 +02:00
Nextcloud bot e58344fb2a
[tx-robot] updated from transifex 2021-04-21 02:25:58 +00:00
Jan C. Borchardt 9d1e2c5082
Merge pull request #26548 from nextcloud/design/files-accessibility
Files & Core accessibility fixes
2021-04-20 13:51:40 +02:00
Nextcloud bot 79116e825c
[tx-robot] updated from transifex 2021-04-20 02:25:58 +00:00
Jan C. Borchardt 738ac612d2
Fix accessibility of federation menu privacy buttons
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:54 +02:00
Jan C. Borchardt 64e90cdc66
Fix accessibility of profile picture section
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:54 +02:00
Jan C. Borchardt 749a266f78
Add proper labels for personal settings privacy toggles
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 20:34:47 +02:00
Joas Schilling 422ecdeb20
Fix English source string
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-19 13:11:34 +02:00
Nextcloud bot 8c82dd37b4
[tx-robot] updated from transifex 2021-04-19 02:26:04 +00:00
Nextcloud bot 3ab7d6cf3e
[tx-robot] updated from transifex 2021-04-17 02:24:04 +00:00
Nextcloud bot 07278ed57d
[tx-robot] updated from transifex 2021-04-16 02:25:50 +00:00
Vincent Petry af61486aea
Separate settings for remote share expiration
Added separate settings for default and enforced expiration date for
remote shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +02:00
Nextcloud bot 8ef920fdf9
[tx-robot] updated from transifex 2021-04-15 02:25:10 +00:00