Commit Graph

19648 Commits

Author SHA1 Message Date
Morris Jobke b89b7ae885
Merge pull request #14512 from nextcloud/smb-3.0.2-15
update icewind/smb to 3.0.2
2019-03-04 17:45:25 +01:00
Jan-Philipp Litza 6c5c01974f dav: Fix handling of chunked WebDAV upload
When $data is null (which can happen when $request->getBodyAsStream() returns
null), the Exceptions says "copied bytes: 0, expected filesize: 0", which
sounds more like success...
2019-03-04 16:44:21 +00:00
John Molakvoæ (skjnldsv) 2ca4473e28 Do not cut full color on accessibility svg color invert
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-03-04 16:40:03 +00:00
Robin Appelman 594075f841
update icewind/smb to 3.0.2
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-03-04 16:40:45 +01:00
Roeland Jago Douma 4ee9069b7e
Merge pull request #14472 from felixn/stable15
Fix for issue #13319: load oc-backbone-webdav before loading versions app
2019-03-04 12:19:34 +01:00
Felix Nieuwenhuizen b0c0bf84f6 Fix for issue #13319: load oc-backbone-webdav before loading versions app
Signed-off-by: Felix Nieuwenhuizen <felix@tdlrali.com>
2019-03-02 15:54:20 +01:00
Ari Selseng 054637f731 Fix a bug with smb notify having leading slash when it should not
Signed-off-by: Ari Selseng <ari@selseng.net>
2019-03-01 20:04:31 +00:00
Nextcloud bot 068b754d31
[tx-robot] updated from transifex 2019-03-01 01:12:48 +00:00
Roeland Jago Douma 988524d6b9
Merge pull request #14414 from nextcloud/backport/13844/stable15
[stable15] Bugfix for issue 10862: Trash-bin ignores trashbin_retention_obligation
2019-02-28 09:43:17 +01:00
Morris Jobke 92d0c28de4
Merge pull request #14376 from nextcloud/backport/13514/stable15
[stable15] Fix grid toggle button on public page
2019-02-28 09:42:02 +01:00
Nextcloud bot aac2669762
[tx-robot] updated from transifex 2019-02-28 01:12:49 +00:00
Felix Nieuwenhuizen 0685b98e1c Fix for issue 10862: calculation of free space ignores external storage (doesn't count towards quota)
Signed-off-by: Felix Nieuwenhuizen <felix@tdlrali.com>
2019-02-27 14:56:53 +00:00
Nextcloud bot 192bb12d5b
[tx-robot] updated from transifex 2019-02-27 01:12:18 +00:00
Nextcloud bot 1985b88e84
[tx-robot] updated from transifex 2019-02-26 01:12:22 +00:00
John Molakvoæ (skjnldsv) 6d744ef4ee Fix grid toggle button on public page
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-02-25 20:20:12 +00:00
Nextcloud bot a7b322bd65
[tx-robot] updated from transifex 2019-02-25 01:12:29 +00:00
Nextcloud bot 9bc2070c59
[tx-robot] updated from transifex 2019-02-24 01:13:54 +00:00
Nextcloud bot 3832207081
[tx-robot] updated from transifex 2019-02-23 01:12:55 +00:00
Roeland Jago Douma 69519252a9
Merge pull request #14340 from nextcloud/backport/14332/stable15
[stable15] Fix unsafe array access
2019-02-22 14:49:57 +01:00
Daniel Kesselberg 9caf7bbd47 Check if array element is present before access
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-02-22 11:53:27 +00:00
John Molakvoæ 38212f5028
Merge pull request #14331 from nextcloud/backport/14329/stable15
[stable15] Apply theme to 2FA button
2019-02-22 12:53:10 +01:00
Nextcloud bot b879d28f24
[tx-robot] updated from transifex 2019-02-22 01:12:21 +00:00
Julius Härtl aa7cfa09df Apply theme to button elements as well
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-02-21 18:14:35 +00:00
Nextcloud bot b42e3fa1b3
[tx-robot] updated from transifex 2019-02-21 01:12:14 +00:00
Morris Jobke 37cb480900
Merge pull request #14312 from nextcloud/backport/14255/stable15
[stable15] Fix ocm end-point discovery discovery
2019-02-20 16:46:30 +01:00
Bjoern Schiessle f3f8ab1a19
adjust json to match the definition
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2019-02-20 15:41:34 +01:00
Roeland Jago Douma bb26c2628d
Merge pull request #14301 from nextcloud/backport/14300/stable15
[stable15] Use proper scroll container when dragging files
2019-02-20 15:27:16 +01:00
Roeland Jago Douma c9a4f010dc
Merge pull request #14273 from nextcloud/backport/14210/stable15
[stable15] Fix empty file uploads to S3 (and other streaming storages)
2019-02-20 15:26:36 +01:00
Roeland Jago Douma 7cc3486229
Hanlde writestream not closing source
Fixes #14298

If a storage doesn'tclose the write stream then $isEOF is not yet set.
So we have to fallback.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-20 11:52:44 +01:00
Julius Härtl ce33f58459 Use proper scroll container when dragging files
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-02-20 10:10:32 +00:00
Nextcloud bot 02b3704de9
[tx-robot] updated from transifex 2019-02-20 01:12:06 +00:00
Daniel Kesselberg bc71889657 Call headObject if file not in filecache 🙈
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-02-19 11:38:15 +00:00
Daniel Kesselberg db27cb20af Prefix $path for filename for internal file cache
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-02-19 11:38:14 +00:00
Roeland Jago Douma 141ea50716
Make sure that we have a stream
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-19 10:16:11 +01:00
Roeland Jago Douma 6bdd9d123e
Add a wrapper to determine if a file is EOF
The stream is already closed at this point. Which means feof will always
return false. We have to determine if the stream is EOF in the
preCloseCallback. And pass this info along. Then the logic works as
expected.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-19 10:16:11 +01:00
Roeland Jago Douma 39cfa50539 Catch Request exception in testRemoteUrl
Else the background job fails hard if the remote has for example an
invalid certificate.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-19 07:05:49 +00:00
Nextcloud bot 4a0feef83d
[tx-robot] updated from transifex 2019-02-19 01:12:20 +00:00
Nextcloud bot 84ab16bac4
[tx-robot] updated from transifex 2019-02-18 01:12:21 +00:00
Nextcloud bot 4651c25f17
[tx-robot] updated from transifex 2019-02-17 01:13:40 +00:00
Nextcloud bot 5eb304a69a
[tx-robot] updated from transifex 2019-02-16 01:12:35 +00:00
Nextcloud bot 2869e06d12
[tx-robot] updated from transifex 2019-02-15 01:13:02 +00:00
Roeland Jago Douma 220b674836
Fix trashbin restore translation
The files app doesn't have this entry.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-14 21:44:09 +01:00
Roeland Jago Douma cab6215e36
Merge pull request #14207 from nextcloud/backport/14177/stable15
[stable15] Fix small glitches in update notification page
2019-02-14 19:41:01 +01:00
Morris Jobke acf5f47076
Fix style of warning for EoL version
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-02-14 15:40:51 +01:00
Arthur Schiwon d34e021af0 ensure attribute names are lower cased
otherwise they will be skipped when the results is being formatted and the
lower-cased result keys do not match.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-02-14 14:08:27 +00:00
Nextcloud bot 262c5a6236
[tx-robot] updated from transifex 2019-02-14 01:12:38 +00:00
Nextcloud bot 68e5c9d258
[tx-robot] updated from transifex 2019-02-13 01:12:25 +00:00
Nextcloud bot 40b40c94a2
[tx-robot] updated from transifex 2019-02-12 01:12:37 +00:00
Nextcloud bot 29975fab3f
[tx-robot] updated from transifex 2019-02-11 01:12:32 +00:00
Nextcloud bot d049403a82
[tx-robot] updated from transifex 2019-02-10 01:13:39 +00:00
Nextcloud bot 0cf2c7be7c
[tx-robot] updated from transifex 2019-02-09 01:12:50 +00:00
Morris Jobke 6ae8e99c1b
Merge pull request #13982 from nextcloud/stable15-12917-clean-code-and-fix-drop-zone-shadow
[stable15] Clean code and fix drop zone shadow
2019-02-08 09:34:04 +01:00
Joas Schilling 7fc115d0a5
Merge pull request #14101 from nextcloud/backport/14083/stable15
[stable15] Make sure the relative path is always a string
2019-02-08 08:41:41 +01:00
Nextcloud bot 8660fc3502
[tx-robot] updated from transifex 2019-02-08 01:12:50 +00:00
Joas Schilling c29520013c Fix wrong method call
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-02-07 22:40:11 +00:00
Joas Schilling 86b76bb514 Make sure the relative path is always a string
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-02-07 22:40:10 +00:00
Roeland Jago Douma 252d49dd79
Merge pull request #14094 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/stable15/lodash-4.17.11
[Security] Bump lodash from 4.17.10 to 4.17.11 in /apps/accessibility
2019-02-07 22:37:14 +01:00
Roeland Jago Douma ded5c2f220
Merge pull request #14093 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/stable15/lodash-4.17.11
[Security] Bump lodash from 4.17.10 to 4.17.11 in /apps/updatenotification
2019-02-07 22:21:55 +01:00
dependabot[bot] 4c026286e9
[Security] Bump lodash from 4.17.10 to 4.17.11 in /apps/accessibility
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.11. **This update includes security fixes.**
- [Release notes](https://github.com/lodash/lodash/releases)
- [Changelog](https://github.com/lodash/lodash/blob/master/CHANGELOG)
- [Commits](https://github.com/lodash/lodash/compare/4.17.10...4.17.11)

Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-07 21:13:01 +01:00
dependabot[bot] 0576526880
[Security] Bump lodash in /apps/updatenotification
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.11. **This update includes security fixes.**
- [Release notes](https://github.com/lodash/lodash/releases)
- [Changelog](https://github.com/lodash/lodash/blob/master/CHANGELOG)
- [Commits](https://github.com/lodash/lodash/compare/4.17.10...4.17.11)

Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-07 21:11:54 +01:00
dependabot[bot] 621e0aea0b
[Security] Bump lodash from 4.17.10 to 4.17.11 in /apps/oauth2
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.11. **This update includes security fixes.**
- [Release notes](https://github.com/lodash/lodash/releases)
- [Changelog](https://github.com/lodash/lodash/blob/master/CHANGELOG)
- [Commits](https://github.com/lodash/lodash/compare/4.17.10...4.17.11)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-02-07 19:12:36 +00:00
Morris Jobke 89c67b3e6e
Merge pull request #14029 from nextcloud/backport/13954/stable15
[stable15] Show original path in trashbin
2019-02-07 16:47:23 +01:00
Morris Jobke 30171e7941
Merge pull request #13978 from nextcloud/backport/13972/stable15
[stable15] trim filename in webfrontend for windows compatibility
2019-02-07 16:47:02 +01:00
Roeland Jago Douma 386b8595b1
Merge pull request #13961 from nextcloud/backport/13945/stable15
[stable15] Show autocompletion as soon as "@" is typed
2019-02-07 16:44:37 +01:00
Morris Jobke b4a5fd5a9d
Merge pull request #14068 from nextcloud/smb-3.0.1-15
[15] update icewind/smb to 3.0.1
2019-02-07 16:36:58 +01:00
Morris Jobke f36a2b28af
Merge pull request #14076 from nextcloud/bugfix/14022/stable15-not-working-external-storages
[stable15] Make external storages browsable again in the web UI
2019-02-07 11:05:08 +01:00
Morris Jobke ca9b9865ff
Reintroduce status check for external storages
Fixes #14022

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-02-07 10:15:29 +01:00
Nextcloud bot 7b1720ba5d
[tx-robot] updated from transifex 2019-02-06 22:18:33 +00:00
Robin Appelman 23d4e910a8
update icewind/smb to 3.0.1
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-02-06 18:13:27 +01:00
Nextcloud bot 3e72cc16e7
[tx-robot] updated from transifex 2019-02-06 11:27:41 +00:00
Morris Jobke 5ffb793b71 Show original path in trashbin via extraData
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-05 14:12:08 +00:00
Roeland Jago Douma b6e5669949
Revert "[stable15] Show original path in trashbin" 2019-02-05 15:10:32 +01:00
Morris Jobke cba2c1fd1a Show original path in trashbin via extraData
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-05 13:09:15 +00:00
fnuesse 150d15ba39 Extract variable for yellow color in icons
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2019-02-01 16:21:23 +01:00
fnuesse df01d12d91 Fix drop zone shadow
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez 371df903d6 Unify handling of dropping one file or several files on the trash bin
When a single file was dropped on the trash bin the file information was
gotten from the original element in the file list. When several files
were dropped on the trash bin the file information was gotten from the
helper elements being dragged around. The helper element also contain
the needed file information when a single file is being dragged, so the
handling was unified to always get the file information from the helper
elements.

As the handling of several files is the same as before there is still
the issue of only deleting those files shown in the drag helper instead
of all the selected files.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez 66b908f9f2 Use full names instead of abbreviations in variable names
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez e2c4dbca51 Make code format more consistent with the rest of the file
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez c72e75c4c3 Replace double quotes with single quotes
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez 8e6cedb157 Add missing trailing ";"
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez 414804d534 Remove unneeded triggering of event
The "droppedOnTrash" event was being triggered when the file list was
initialized, but it should be triggered only when the user actually
drops a file on the trash bin.

Besides that, the event had no effect; only the file list handles it,
but as it was not triggered on any element it ended being triggered on
the document, and thus not handled. Moreover, even if it had been
triggered on the file list it would have been done before the handler
was set, so it would not have been handled anyway. And even if it had
been handled no data was provided, so the handler would have failed.

In conclusion, triggering the event there was not needed, and thus it
was removed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez e94412e9e8 Remove duplicated variable declaration
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez 7b7da7b190 Remove leftover from a WIP
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez 1f9c881d0f Remove hack to prefetch the starred trash icon
Since 6ad7f32938 SVG icons are directly embedded in "icons-vars.css", so
the starred trash icon is now loaded along with the regular trash icon
all at once. Therefore it is not needed to explicitly prefetch it using
a hidden div.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Christian Aigner e4c20ae67d HBOX-297 trim in webfrontend for new files to stay compatible with windows 2019-02-01 11:13:10 +00:00
Morris Jobke f46a251625
Revert "trim filename in webfrontend for windows compatibility" 2019-02-01 11:59:49 +01:00
Daniel Calviño Sánchez c3ff11bb08 Show autocompletion as soon as "@" is typed
In order to show the autocompletion it was needed to type at least
another character after "@", so only the mentions that matched that
character were shown. Now the autocompletion is shown as soon as "@" is
typed, which shows all the possible mentions.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-31 19:19:31 +00:00
Christian Aigner 6637d97376 HBOX-297 trim in webfrontend for new files to stay compatible with windows 2019-01-31 15:30:20 +01:00
Morris Jobke d34b7e594b
Merge pull request #13920 from nextcloud/backport/13891/stable15
[stable15] Remove warning in case of external storage error
2019-01-30 15:34:22 +01:00
Morris Jobke 24007e706c
Merge pull request #13918 from nextcloud/backport/13412/stable15
[stable15] forward error message from password policy
2019-01-30 15:25:06 +01:00
Morris Jobke dbdc5c4dd4
Merge pull request #13887 from nextcloud/backport/13883/stable15
[stable15] Fix dropping a folder on a folder row
2019-01-30 14:09:20 +01:00
Morris Jobke 1f52990013
Merge pull request #13905 from nextcloud/backport/13830/stable15
[stable15] Allow shared versions again in legacy backend
2019-01-30 12:01:42 +01:00
John Molakvoæ (skjnldsv) a1f8f67974 Remove warning in case of external storage error
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-01-30 10:56:38 +00:00
Robin Appelman 60126556be forward error message from password policy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-01-30 10:14:55 +00:00
Roeland Jago Douma 75b5286169
Merge pull request #13904 from nextcloud/backport/13886/stable15
[stable15] add fallback for trashbin original location
2019-01-30 10:19:12 +01:00
Roeland Jago Douma ae826f5a2f
Merge pull request #13884 from nextcloud/backport/13865/stable15
[stable15] fix paged search with multiple bases (LDAP)
2019-01-30 09:31:13 +01:00
Roeland Jago Douma a36577463d Allow shared versions again in legacy backend
To make sure that the versions in the legacy backend are shared again we
have to check the storage of a file. Since all shared files are still on
the owners storage.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-30 08:23:50 +00:00
Roeland Jago Douma 3a34132b06
Merge pull request #13804 from nextcloud/backport/13802/stable15
[stable15] Fix long comment in dark theme
2019-01-30 09:08:48 +01:00
Robin Appelman a6f6a3aa5d add fallback for trashbin original location
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-01-30 08:04:49 +00:00
Daniel Calviño Sánchez 4321e0fc6d Fix dropping a folder on a folder row
When the uploaded files have a relative path (that is, when a folder is
uploaded) it is first ensured that all the parent folders exist, which
is done by trying to create them. When a folder is created in the
currently opened folder the file list is updated and a row for the new
folder is added. However, this was done too when the folder already
existed, which caused the previous row to be removed and a new one added
to replace it.

For security reasons, some special headers need to be set in requests;
this is done automatically for jQuery by handling the "ajaxSend" event
in the document. In the case of DAV requests, if the headers are not set
the server rejects the request with "CSRF check not passed".

When a file or folder is dropped on a folder row the jQuery upload
events are chained from the initial drop event, which has the row as its
target. In order to upload the file jQuery performs a request, which
triggers the "ajaxSend" event in the row; this event then bubbles up to
the document, which is then handled by adding the special headers to the
request.

However, when a folder was dropped on a folder row that folder row was
removed when ensuring that the folder exists. The jQuery upload events
were still triggered on the row, but as it had been removed it had no
parent nodes, and thus the events did not bubble up. Due to this the
"ajaxSend" event never reached the document when triggered on the
removed row, the headers were not set, and the upload failed.

All this is simply fixed by not removing the folder row when trying to
create it if it existed already.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-29 14:46:07 +00:00