mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
57,518 Commits 349 Branches 696 Tags 1.6 GiB
Commit Graph

2884 Commits

Author SHA1 Message Date
blizzz 849c13f202
Merge pull request #22472 from nextcloud/fix/contacts-interaction-blob-postgres 
Fix writing BLOBs to postgres with recent contacts interaction
 2020-08-31 15:07:22 +02:00
Julius Härtl ac2999a26a
Transfer shares of the transferred root node 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-08-31 14:23:34 +02:00
Roeland Jago Douma 7b8364e001
Merge pull request #21288 from lmamane/master 
Return correct loginname in credentials
 2020-08-28 16:11:46 +02:00
Christoph Wurst 3bc54bfd06
Fix writing BLOBs to postgres with recent contacts interaction 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-08-28 14:30:33 +02:00
Roeland Jago Douma b5e9f7e846
Merge pull request #22432 from nextcloud/enh/phpdoc 
Add php docs build script
 2020-08-26 21:18:11 +02:00
Julius Härtl 45a474071e
Remove @package annotations from public namespace 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-08-26 16:59:40 +02:00
Julius Härtl 94c0ca4b8c
Remove wrongly annotated package names 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-08-26 12:35:27 +02:00
Joas Schilling 0934aee46b
Merge pull request #22359 from nextcloud/fix/noid/flow-leaking-scope 
fix possible leaking scope in Flow
 2020-08-25 10:40:26 +02:00
Christoph Wurst 2a054e6c04
Update the license headers for Nextcloud 20 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-08-24 14:54:25 +02:00
Arthur Schiwon 28c0eea8cb
fix possible leaking scope in Flow 
- a configured flow can be brought into consideration, despite its event
  was not fired
- it could either run through
- or run into a RuntimeException and killing processing of valid flows

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-08-24 13:44:01 +02:00
Lionel Elie Mamane ac8b40b8b1
Return correct loginname in credentials, 
even when token is invalid or has no password.

Returning the uid as loginname is wrong, and leads to problems when
these differ. E.g. the getapppassword API was creating app token with
the uid as loginname. In a scenario with external authentication (such
as LDAP), these tokens were then invalidated next time their underlying
password was checked, and systematically ceased to function.

Co-authored-by: kesselb <mail@danielkesselberg.de>
for: switch to consistent camelCase

Signed-off-by: Lionel Elie Mamane <lionel@mamane.lu>
 2020-08-20 16:02:22 +02:00
Morris Jobke c449d54204
Merge pull request #22304 from nextcloud/techdebt/noid/matching-param-names 
Use matching parameter names form interfaces and implementations
 2020-08-19 19:34:02 +02:00
Morris Jobke fedf9c69d9
Use matching parameter names form interfaces and implementations 
Found by Psalm 3.14.1

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-19 18:16:35 +02:00
Joas Schilling 35a8519591
Fix CS 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-08-19 11:20:36 +02:00
Joas Schilling e66bc4a8a7
Send "429 Too Many Requests" in case of brute force protection 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-08-19 11:20:35 +02:00
Morris Jobke e47cfc9a54
Properly add new methods to interface and document in PHPDoc for getRootMounts() 
Introduced in #22063 and was just forgotten.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-17 17:13:46 +02:00
Daniel Kesselberg 10ac844448
Update documentation for QueryBuilder::set 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-08-14 19:55:01 +02:00
Morris Jobke 16d83ab30a
Remove getLastJob from IJobList 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-13 21:50:06 +02:00
Morris Jobke 725fecee34
Merge pull request #21344 from nextcloud/fix/twofactor-cleanup-event 
Emit an event for every disabled 2FA provider during cleanup
 2020-08-13 07:25:01 +02:00
Morris Jobke 8fc877ff7d
Merge pull request #22117 from nextcloud/activity-settings-grouping 
allow grouping of activity settings
 2020-08-11 11:24:23 +02:00
Morris Jobke 782a2df392
Add PHP doc for events 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-10 14:24:24 +02:00
Morris Jobke 54726d5934
Merge pull request #21738 from nextcloud/techdebt/14552/migrate-OC_Group-post_removeFromGroup 
Migrate OC_Group post_removeFromGroup hook to actual event object
 2020-08-07 17:46:00 +02:00
Morris Jobke 96d418b379
Add proper deprecation message 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-07 17:45:45 +02:00
Morris Jobke 438ac23e2a
Distribute preview folders in appdata in multibucket setup to multiple buckets 
* introduces a new IRootMountProvider to register mount points inside the root storage
* adds a AppdataPreviewObjectStoreStorage to handle the split between preview folders and bucket number

Ref #22033

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-06 22:19:20 +02:00
Morris Jobke 3f1c48598d
Merge pull request #22112 from nextcloud/enh/noid/flow-entity-recreatable-state 
Allow Flow entity state to be recreated
 2020-08-06 09:36:32 +02:00
Julius Härtl 018be662f4
Refactor API to match the widget wording 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-08-05 17:03:38 +02:00
Joas Schilling 55473dd2eb
Merge pull request #22104 from nextcloud/enh/search/make-app-handle-the-order-logic 
Make apps handle the order logic
 2020-08-05 16:38:45 +02:00
Robin Appelman 227e362842
allow grouping of activity settings 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-08-05 16:13:03 +02:00
Morris Jobke 6fbf8fceac
Merge pull request #22106 from nextcloud/feature/noid/user_status_api 
Provide a PHP Api for UserStatus
 2020-08-05 15:30:48 +02:00
Joas Schilling ea8f68bea6 Hand in the route and the parameters of the request 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-08-05 12:52:16 +00:00
John Molakvoæ a4d511d827
Merge pull request #22099 from nextcloud/fix/unified-search 2020-08-05 14:17:42 +02:00
Georg Ehrke 0e0e0d19e8
Provide a PHP Api for UserStatus 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2020-08-05 13:48:46 +02:00
Arthur Schiwon 6c1c9273c0
Enable Flow entities to recreate state if necessary 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-08-05 13:24:20 +02:00
Morris Jobke 0581356169
Merge pull request #22097 from nextcloud/enh/noid/empty-template 
Add empty renderAs template
 2020-08-05 11:42:29 +02:00
John Molakvoæ (skjnldsv) d98f7c1bd8
Make apps handle the order logic 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-08-05 11:37:45 +02:00
Georg Ehrke b0c5457c42
IAddressBook: add isShared and isSystemAddressBook 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2020-08-05 09:04:41 +02:00
John Molakvoæ (skjnldsv) 71b62c4203
Show mime icon, bump bundles, make the SearchResultEntry class non-abstract, Fix header search icon, various fixes 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-08-04 21:36:22 +02:00
Julius Härtl b51746212e
Add base renderAs template 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-08-04 09:48:43 +02:00
Morris Jobke 489fecac32
Merge pull request #22057 from nextcloud/fix/20009/contactsmenu-limit-users 
contactsmanager shall limit number of results early
 2020-08-03 15:15:46 +02:00
John Molakvoæ (skjnldsv) 1a1b3e20e4 Fix unified search 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-08-03 11:26:03 +00:00
Georg Ehrke 0fad921840
Add user-status app 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2020-07-31 16:45:27 +02:00
Arthur Schiwon 7c56283c3c
contactsmanager shall limit number of results early 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-07-31 12:42:17 +02:00
Morris Jobke 084f5063f2
Deprecate BeforeUserRemovedEvent because it can't be triggered in all cases 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-30 10:21:08 +02:00
Morris Jobke 7e28286e9d
Merge pull request #21542 from nextcloud/activity-notifications 
basic settings system for activity notifications
 2020-07-29 15:36:38 +02:00
Robin Appelman c8427781b4
implement old settings interface 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-24 13:03:35 +02:00
Julius Härtl e1b696929f
Move NotFoundResponse to a proper TemplateResponse 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-24 08:58:14 +02:00
Roeland Jago Douma e0cc95f3aa
Allow user backends to specify a custom logout url 
* Allows SSO backends to do a global logout

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-23 10:42:40 +02:00
Morris Jobke 7870ca0663
Use the proper IAppContainer and IServerContainer type hints to know which code runs with which container 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-21 20:44:05 +02:00
Christoph Wurst e029055e76
Make the bootstrap context return ContainerInterface instances 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-21 20:42:24 +02:00
Robin Appelman 5eb1e75e24
build autoloader 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-21 19:26:59 +02:00
Robin Appelman aa051875f9
improve default notification fallback 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-21 17:40:22 +02:00
Robin Appelman fb5ae20722
basic settings system for activity notifications 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-21 17:12:38 +02:00
Morris Jobke 09e6b26bdd
Merge pull request #21875 from nextcloud/techdebt/deprecate-ilogger 
Deprecate ILogger in favor of the PSR-3 logger
 2020-07-20 16:45:14 +02:00
Morris Jobke 9ae75a3ca9
Merge pull request #21850 from nextcloud/techdebt/noid/register-alternative-logins 
Allow to register AlternativeLogin on RegistrationContext
 2020-07-20 14:20:03 +02:00
Christoph Wurst 22ff03969e
Undeprecate IAppContainer and IServerContainer 
With 4152216bd8 these two interfaces got
deprecated with the reasoning that we only need the base PSR interface.
However, there are cases where in Nextcloud you still want to have a
specific container (the one for the app vs the one for the server) when
you either have a container injected or query one from a container.

With a single interface that would not be possible. So it's probably
better if we leave the two interfaces, but only have them extend the PSR
interface. IContainer – with the custom methods – shall still be phased
out, but the two other sub interfaces can stay for tagging purposes.
Tagging means that no methods shall be added.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-17 10:17:18 +02:00
Joas Schilling cae849bcf9
Merge pull request #21869 from nextcloud/techdebt/noid/add-constants-for-magic-strings 
Add constants for the magic strings of template rendering
 2020-07-16 22:00:57 +02:00
Christoph Wurst 8a433a7226
Deprecate ILogger 
The logger service was always intended to follow the PSR-3 interface.
It's time to embrace this and switch over to the "official" API,
hence this custom interface can be slowly phased out.

With Nextcloud 20 the logger also got support for
* App id filled out automatically
* Exceptions handling (as replacement for logException)

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-16 19:19:23 +02:00
Christoph Wurst efd2835b23
Deprecate the server container getters 
Service locators are an anti pattern. These getters just make it more
appealing to do the wrong thing. If you want to locate a service the bad
way, just use the `get` method on a container – it will do the same in
also one line of code.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-16 18:59:56 +02:00
Joas Schilling 49970639fa
Add constants for the magic strings of template rendering 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-16 15:47:28 +02:00
Joas Schilling 0dfcc132ca
Allow to register AlternativeLogin on RegistrationContext 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-16 14:20:24 +02:00
Christoph Wurst 4152216bd8
Use PSR container interface and deprecate our own abstraction 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-16 13:35:45 +02:00
Morris Jobke c4b53538af
Better event description for BeforeTemplateRenderedEvent in files and files_sharing 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-15 20:15:51 +02:00
Roeland Jago Douma 7d7ba61625
Add real events to load additionalscripts 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-15 14:07:18 +02:00
Julius Härtl 35bdb998ef
Dashboard strict typing 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:28:12 +02:00
Julius Härtl 31a1494529
Add load method for apps to bootstrap their panels 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:28:11 +02:00
Julius Härtl b71de68f43
Cleanup public api methods 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:28:11 +02:00
Julius Härtl f7c04b0415
Deprecate panel register event right away but keep it for not breaking backward compatible apps 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:28:11 +02:00
Julius Härtl 81e5593133
Move to lazy panel registration during registration context 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:27:57 +02:00
Julius Härtl 544fcdb549
Deprecate old dashboard API 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:24:51 +02:00
Julius Härtl 673d70dfc5
Add new dashboard public API 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:24:50 +02:00
Roeland Jago Douma 725872c23a
Make the subscription registry lazy 
This will allow to do lazy registration here which should allow for
loading less (or at least only when needed!).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-09 12:21:06 +02:00
Roeland Jago Douma 7d128ebf3e
Remove old deprecated getAppFolder 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-06 22:06:58 +02:00
Morris Jobke 4e8552929b
Merge pull request #20729 from nextcloud/cleanup/noid/shared-tags-code 
Tags.php and the old sharing mechanism
 2020-07-06 21:30:48 +02:00
Roeland Jago Douma 37b2121ccf
Deprecate registerRoutes 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-06 15:15:20 +02:00
Morris Jobke e20db42a0c
Tags.php and the old sharing mechanism 
The old sharing mechanism isn't working anymore, because it was replaced by Share 2.0. Also it was nowhere used so this removes the code paths and reduces complexity.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-06 14:12:12 +02:00
Morris Jobke fb69d6d195
Merge pull request #21238 from nextcloud/techdebt/noid/deferrable-notification-apps 
Allow notification apps to defer and flush the sending
 2020-07-06 13:50:25 +02:00
Morris Jobke 6c825ee9a0
Merge pull request #21665 from nextcloud/debt/noid/job-list 
Fix wrong phpdoc for execute method
 2020-07-06 11:14:14 +02:00
Morris Jobke b1cdd0dd9b
Use formal type hints instead of informal PHPDoc 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-06 10:13:23 +02:00
Morris Jobke e900f424ce
Merge pull request #21636 from nextcloud/lock-exception-readable-path 
add proper paths to locking exceptions
 2020-07-05 22:37:12 +02:00
Morris Jobke d3d11cb826
Merge pull request #21626 from nextcloud/enhancement/injectible-callables 
Callable parameter injection
 2020-07-05 22:03:12 +02:00
Roeland Jago Douma 4d8b4ef3cc
Merge pull request #21533 from nextcloud/techdebt/noid/dedicated-method-to-get-a-users-language 
Techdebt/noid/dedicated method to get a users language
 2020-07-04 08:56:13 +02:00
Joas Schilling 3d559159f0
Allow notification apps to defer and flush the sending 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-03 16:44:43 +02:00
Christoph Wurst 4a3ea04baa
Callable parameter injection 
This is like what we have to DI and classes, but for callables.

The motivating factor is to get rid of *service locators* in the `boot`
method of apps as a new pattern is about to emerge where we have lots of
`query` calls on the app or server container in order to fetch some
services.

With this little helper it's possible to call another (public) method
and magically have everything injected.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-03 14:37:46 +02:00
Daniel Kesselberg 9b10d35477
Fix wrong phpdoc for execute method 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-07-03 10:47:15 +02:00
Joas Schilling 19e1efd1dd
Merge pull request #21439 from nextcloud/feature/noid/move-autocomplete-filter-event-to-new-dispatcher-and-class 
Move AutoComplete::filterResults to new event dispatcher and GenericE…
 2020-07-03 10:03:34 +02:00
Joas Schilling b997edad10
Add a dedicated method to get the language for another user 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-01 10:20:07 +02:00
Joas Schilling 35c6b1236f
Move AutoComplete::filterResults to new event dispatcher and GenericEvent 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-01 09:57:33 +02:00
Daniel Kesselberg 87dd760a89
Replace TYPE with TYPES 
As TYPE::* is deprecated.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-30 23:46:22 +02:00
Robin Appelman da2d425044
add proper paths to locking exceptions 
while some code paths do wrap the "raw" locking exception into one with a proper path, not all of them do
by adding the proper path to the original exception we ensure that we always have the usefull information in out logs

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-06-30 18:10:42 +02:00
Joas Schilling b7060be18d
Fix robots "noindex, nofollow" signals 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-25 08:29:43 +02:00
Christoph Wurst 27b8637e3e
Deprecate \OCP\ISearch 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-24 14:20:26 +02:00
Christoph Wurst f8e08a74ba
Implement unified search for Files 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-24 14:20:26 +02:00
Christoph Wurst 4488e846a5
Add unified search API 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-24 14:20:25 +02:00
blizzz 859941db32
Merge pull request #21479 from nextcloud/fix/21474/allow_specifying_cookie_type 
Allow to specify the cookie type for appframework responses
 2020-06-22 13:00:12 +02:00
blizzz a899b4775d
Merge pull request #21475 from nextcloud/enh/noid/flow-event-dispatcher 
flow to not use deprecated event dispatcher methods
 2020-06-22 11:18:50 +02:00
Roeland Jago Douma fbf9772a3e
Allow to specify the cookie type for appframework responses 
In general it is good to set them to Lax. But also to give devs more
control over them is not a bad thing.

Helps with #21474

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-06-22 08:38:44 +02:00
Arthur Schiwon 3706eae777
flow to not use deprecated event dispatcher methods 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-06-19 23:03:07 +02:00
Christoph Wurst 2b7b7144d4
Allow crash reporters registration during app bootstrap 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-19 10:38:26 +02:00
Christoph Wurst 5bc8510b3b
Load the app.php before running apps' boot method 
Some apps require the composer autoloader from app.php. If we run boot
before including that file, classes and functions from dependencies
won't be found.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-17 14:44:02 +02:00
Christoph Wurst 69571fb536
Add dedicated API for apps' bootstrapping process 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-17 09:22:21 +02:00
Christoph Wurst 68794ebc92
Emit an event for every disabled 2FA provider during cleanup 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-16 14:38:33 +02:00
Roeland Jago Douma 19712e2773
Merge pull request #21311 from nextcloud/techdebt/noid/make-share-order-reliable 
Always sort shares in a reliable way
 2020-06-09 10:33:41 +02:00
Christoph Wurst fec3fefad7
Deprecate \OCP\IServerContainer::getEventDispatcher 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-08 19:10:26 +02:00
Joas Schilling 56b04c65f7
Always sort shares in a reliable way 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-08 14:47:15 +02:00
Roeland Jago Douma 6aa6ab3e02
Add lazy events for the Node API 
Right now if you want to get events via the Node API you have to have a
real instance of the Root. Which in turns sets up the whole FS.

We should make sure this is done lazy. Else enabling the preview
generator for example makes you setup the whole FS on each and every
authenticated call.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-05-28 12:35:45 +02:00
Roeland Jago Douma c92c378a9c
Copy over the ETag and LastModified when formatting a Dataresponse 
This way the ETag checks etc are all working.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-05-19 09:39:51 +02:00
Joas Schilling 787c2a17e3
Allow links to conversations 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-05-13 16:05:55 +02:00
Roeland Jago Douma 4fbea316a7
Merge pull request #20897 from nextcloud/bugfix/httpcache 
Proxy server could cache http response when it is not private
 2020-05-13 08:27:05 +02:00
Clement Wong e9be3a9090 Add public argument to Http cacheFor() 
Signed-off-by: Clement Wong <git@clement.hk>
 2020-05-10 20:24:14 +02:00
Clement Wong 401210d259 Proxy server could cache http response when it is not private 
Signed-off-by: Clement Wong <git@clement.hk>
 2020-05-10 11:24:08 +02:00
Morris Jobke 08e78ff3b2
Fix OCPSinceChecker and php-cs 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-05-08 11:20:46 +02:00
Roeland Jago Douma 163463dea5
Add InitialState Appframework service 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-05-07 10:13:06 +02:00
Roeland Jago Douma e923d7b42f
Merge pull request #20782 from nextcloud/enh/appframework/appconfig_wrapper 
Simple AppConfig wrapper for the AppFramework
 2020-05-07 08:43:55 +02:00
Roeland Jago Douma 8a8623c569
Simple AppConfig wrapper for the AppFramework 
9 out of 10 cases apps want to access their own appconfig. Hence it
would be nice not to have to enter the app id all the time. This simple
wrapper just passes on the appid in all calls.

Basically this allows for simpler code in the apps.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-05-02 15:34:28 +02:00
Daniel Kesselberg cba7219b25
PHP 7.4 excludes the arguments from stack traces by default. 
That leads to a false positive is not setup via query() but directly warning for every app because
the check does not work anymore.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-04-30 17:00:56 +02:00
Roeland Jago Douma a1f3293c06
Merge pull request #19039 from nextcloud/dav-activity-provide-links-to-calendar 
Provide links to calendar in event creation/update activities
 2020-04-30 09:10:56 +02:00
Christoph Wurst cb057829f7
Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Thomas Citharel deb2ea9cea
Provide links to calendar in event creation/update activities 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2020-04-26 11:11:50 +02:00
Julius Härtl 6709833dc7
Use paginated search for contacts 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-04-23 19:08:16 +02:00
Joas Schilling 3f8168b6e5
Allow some apps to have root URLs in their own routing file 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-18 11:21:28 +02:00
blizzz d55f4183b5
Merge pull request #20505 from nextcloud/fix/noid/system-creds 
do not advertise nulled userId for for systemwide credentials
 2020-04-16 11:53:24 +02:00
Roeland Jago Douma 8971403ada
Merge pull request #20511 from nextcloud/fix/cs-fixer-ldap 
PHP-CS-Fixer green
 2020-04-16 10:37:49 +02:00
Roeland Jago Douma d9990b09b8
PHP-CS-Fixer green 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-04-16 09:25:17 +02:00
Roeland Jago Douma bb4dedb015
Provide the proper language to the mailer 
Else we can't properly translate the footer in the recipients e-mail
language.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-04-16 09:04:13 +02:00
Arthur Schiwon 5437844b7e
fix credentialsManager documentation and ensure userId to be used as string 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-15 19:34:23 +02:00
Joas Schilling 5e402f8aae
Check all remotes for local access 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-14 18:56:06 +02:00
Christoph Wurst 28f8eb5dba
Add visibility to all constants 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:54:27 +02:00
Christoph Wurst 1584c9ae9c
Add visibility to all methods and position of static keyword 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:51:06 +02:00
Christoph Wurst 1762a409f9
Merge pull request #20422 from nextcloud/techdebt/format-control-structs-classes-methods 
Format control structures, classes, methods and function
 2020-04-10 16:38:23 +02:00
Roeland Jago Douma eba3726e1e
Merge pull request #19495 from nextcloud/preview-generate-batch 
optimize batch generation of previews
 2020-04-10 15:57:06 +02:00
Christoph Wurst caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst 14c996d982
Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Christoph Wurst bcd13296de
Make sure every file ends with an empty newline 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:11:50 +02:00
Christoph Wurst a8a06a82d2
Remove trailing whitespaces from comments 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:09:23 +02:00
Christoph Wurst 44577e4345
Remove trailing and in between spaces 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:07:47 +02:00
Christoph Wurst afbd9c4e6e
Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Robin Appelman 7d386872e5
optimize batch generation of previews 
by allowing the generation of multiple previews at once we save on having to find, open and decode the max-preview for every preview of the same file

the main use case for this is the preview generator app (pr for that comming next)

in my local testing this saves about 25% of time when using the preview generator app

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-04-09 12:50:59 +02:00
Robin Appelman 5cd12cd7c3
allow generating multiple preview sizes for a single file at once 
this saves having to do some of the overhead multiple times

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-04-09 12:50:55 +02:00
Christoph Wurst 2a529e453a
Use a blank line after the opening tag 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:50:14 +02:00
Christoph Wurst 41b5e5923a
Use exactly one empty line after the namespace declaration 
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:48:10 +02:00
Christoph Wurst 2fbad1ed72
Fix (array) indent style to always use one tab 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 10:16:08 +02:00
Christoph Wurst 85e369cddb
Fix multiline comments 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-08 22:24:54 +02:00
Julius Härtl 56aa8fd035
Properly hint exceptions thrown by getUserFolder 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-04-03 23:06:26 +02:00
Arthur Schiwon e394f6a5b5
fixes the return type of BeforeUserLoggedInEvent 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-03 18:01:14 +02:00
Joas Schilling bc6a5ef5c4
Merge pull request #19890 from nextcloud/enh/comments-reference-id 
Add optional comments reference_id
 2020-04-02 11:34:21 +02:00
Roeland Jago Douma 19ca921676
Merge pull request #20241 from nextcloud/fix/license-headers-19 
Update the license headers for Nextcloud 19
 2020-04-01 12:44:21 +02:00
Roeland Jago Douma 84f3d2ddeb
[POC] Event for failed login attempts 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-03-31 21:41:02 +02:00
Christoph Wurst 1a9330cd69
Update the license headers for Nextcloud 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-31 14:52:54 +02:00
Joas Schilling a20e81f0f3
Allow to set and get the reference id 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-31 10:51:16 +02:00
Joas Schilling 720dc4e93d
Add optional column oc_comments.reference_id 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-31 10:51:15 +02:00
Christoph Wurst 463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports 
Remove unused imports
 2020-03-27 17:14:08 +01:00
Christoph Wurst b80ebc9674
Use the short array syntax, everywhere 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 16:34:56 +01:00
Christoph Wurst 74936c49ea
Remove unused imports 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:08:08 +01:00
Christoph Wurst 23eb0462e5
Use lowercase true, false and null constants 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 21:53:04 +01:00
Christoph Wurst b3e194f38e
Add a public event for contacts interaction 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 16:02:05 +01:00
Arne Hamann a16aa99586
Added Hook before Message is send 
Signed-off-by: Arne Hamann <kontakt+github@arne.email>
 2020-03-24 20:57:27 +01:00
Julius Härtl 8edc824526 Expose enumeration config though share manager 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-03-20 10:43:56 +01:00
Roeland Jago Douma 458ec33aa2
Merge pull request #19967 from roscomputing/enh/19958/usejsnoncedocs 
add docs for useJsNonce
 2020-03-17 15:09:50 +01:00
Pavel Krasikov 4c01326913 add docs for useJsNonce 
Signed-off-by: Pavel Krasikov <klonishe@gmail.com>
 2020-03-15 17:02:11 +03:00
Roeland Jago Douma b6245be302
Merge pull request #19746 from nextcloud/locked-exception-forward-existing 
pass the existing locks info when making locked exception with absolu…
 2020-03-09 19:31:45 +01:00
Christoph Wurst 5fc4c91a76
Fix mismatching doc block parameter types 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-06 16:28:42 +01:00
Robin Appelman fab22ac14c
pass the existing locks info when making locked exception with absolute paths 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-03-02 19:29:44 +01:00
Roeland Jago Douma de34786303
Merge pull request #19493 from nextcloud/simplefile-new-lazy 
Create SimpleFile only when writing the content
 2020-02-28 16:07:02 +01:00
Joas Schilling 0f08acfe31
Merge pull request #19321 from nextcloud/enh/allow-to-overwrite-share-target-mountpoints 
Allow to overwrite share target mountpoints
 2020-02-28 13:41:13 +01:00
Robin Appelman 63608ef461
allow writing content directly when creating new SimpleFile 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-02-28 12:55:22 +01:00
Robin Appelman 5ca1929e8c
Create SimpleFile only when writing the content 
instead of first creating an empty file and then writing the content.

This solves the overhead of creating an empty file with the common pattern:

```php
$file = $simpleFilder->newFile('foo.txt');
$file->putContent('bar.txt');
```

roughly halving the number of storage and database operations that need to be done when creating a `SimpleFile`.

This is not automatically done with `File` because that has a more complex api which I'm more hesitant to touch.
Instead the `Folder::newFile` api has been extended to accept the content for the new file.

In my local testing, the overhead of first creating an empty file took about 20% of the time for preview generation

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-02-28 12:55:22 +01:00
Christoph Wurst f83589f75d
Merge pull request #19670 from nextcloud/techdebt/noid/allow-to-remove-listeners 
Allow to remove listeners
 2020-02-27 13:08:42 +01:00
Joas Schilling 3ffed42925
Allow to remove listeners 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-02-27 11:04:23 +01:00
Joas Schilling 9c9f8fa5f7
Allow non integer ids in Entity Mapper 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-02-26 14:44:45 +01:00
Roeland Jago Douma f885cef537
Merge pull request #19478 from Tim-Obert/bug/19475/fix-routes-generation-authpublicsharecontroller 
Change the route generation of AuthPublicShareController.php
 2020-02-23 16:43:31 +01:00
Christoph Wurst dd9d4696f2
Merge pull request #19412 from nextcloud/fix/19404/make-favorite-public 
Make TAG_FAVORITE public
 2020-02-21 17:47:53 +01:00
Joas Schilling 841f2f3b04
Allow to overwrite share target mountpoints 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-02-17 09:04:19 +01:00
TimObert 4c1834dace Fix requested changes 
Signed-off-by: Tim Obert <tobert@w-commerce.de>
 2020-02-14 14:16:31 +01:00
Tim Obert 058180d386 Change the route generation of AuthPublicShareController.php and adjust the routes for file sharing 
Signed-off-by: Tim Obert <tobert@w-commerce.de>
 2020-02-14 12:12:04 +01:00
Joas Schilling dc050fb5e5
Allow to overwrite the path on the cache event 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-02-13 08:38:33 +01:00
Daniel Kesselberg 6235175b6d
Make TAG_FAVORITE public 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-02-12 15:11:58 +01:00
Arthur Schiwon e008444887
always require a message paramter for data logging 
also ensure it plays well with current log reader

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-01-28 13:00:13 +01:00
Arthur Schiwon 46aaeb4561
log Flow activity 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-01-28 10:58:57 +01:00
Christoph Wurst 6127c288e8 Fix license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-01-13 14:23:49 +01:00
Roeland Jago Douma 86bccde9c7
Merge pull request #17861 from nextcloud/fix-tab-navigation-of-menu-in-public-share-pages 
Fix tab navigation of menu in public share pages
 2020-01-07 21:00:00 +01:00
Roeland Jago Douma 25d4f3230d
Use the new Events in Flow 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-02 16:40:49 +01:00
Daniel Calviño Sánchez 883a71ce8e Split the menu entry for external shares in two 
The external shares entry showed a "button" that, when pressed, replaced
the button with the input to set the remote share address. The "button"
was actually a label for the input, so when the label was focused it
transferred the focus to the input and thus pressing enter or space did
not show the input. Moreover, inputs inside links are not valid HTML,
and once shown there was no way to hide the input again.

Due to all this, and for consistency with the direct link input, the
external share input was moved to a different menu item that is shown
and hidden when the button, which nows is also a real button, is
clicked.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-12-30 10:29:36 +01:00
Daniel Calviño Sánchez 33b2f4e295 Format HTML elements 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-12-30 10:29:36 +01:00
Christoph Wurst 35c2a9fe0a
Merge pull request #18483 from nextcloud/fix/license-headers-18 
Update license headers for 18
 2019-12-20 14:19:22 +01:00
blizzz 40684a5423
Merge pull request #18080 from nextcloud/enhancement/noid/add-timeout 
adding timeout param
 2019-12-20 12:16:32 +01:00
Christoph Wurst 1b46621cd3
Update license headers for 18 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-20 09:23:25 +01:00
Joas Schilling faf58e4cac
Merge pull request #17018 from nextcloud/feature/noid/allow-to-force-enable-via-cli 
Allow to force enable apps via CLI
 2019-12-16 12:34:27 +01:00
Roeland Jago Douma 3b8fbf129e
Merge pull request #18384 from nextcloud/fix/18255/global_config_to_always_accept 
config.php setting to always accept internal shares
 2019-12-16 09:50:45 +01:00
Roeland Jago Douma bb4264c565
config.php setting to always accept internal shares 
Part of #18255

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-16 09:07:25 +01:00
Joas Schilling 3eee359d7f
Allow to force enable apps via CLI 
Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-13 13:06:12 +01:00
Maxence Lange 78f00f800c nullable params 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2019-12-13 09:17:08 -01:00
Christoph Wurst b81b824da1
Add typed events for the filesystem/scanner 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-13 09:41:05 +01:00
Roeland Jago Douma c6e51924c8
Merge pull request #18236 from nextcloud/bugfix/noid/always-detect-mimetype-by-content-in-workflows 
Allow to detect mimetype by content
 2019-12-12 11:19:55 +01:00
Maxence Lange 9bdc5823ce +ManuallyLockedException 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2019-12-12 09:19:40 -01:00
Roeland Jago Douma c71e9de5ff
Merge pull request #18350 from nextcloud/enhancement/typed-group-events-II 
Add typed events for all group hooks and legacy events
 2019-12-11 12:28:03 +01:00
Christoph Wurst 917f1807fd
Merge pull request #18348 from nextcloud/enhancement/typed-user-events-II 
Add typed events for all user hooks and legacy events
 2019-12-11 12:02:32 +01:00
Roeland Jago Douma 9a40ccfbf0
Merge pull request #18224 from nextcloud/bugfix/noid/direct-editing-path 
Use file path for direct editing
 2019-12-11 11:17:26 +01:00
Christoph Wurst 73fdb8e016
Add typed events for all group hooks and legacy events 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-11 10:22:21 +01:00
Christoph Wurst d808f9c053
Add typed events for all user hooks and legacy events 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-11 10:00:24 +01:00
Roeland Jago Douma 2b581814f3
Add interface for notification handler for dimissed events 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-10 10:02:24 +01:00