a7aa7de6c2
Add a unit test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-12-13 13:54:18 +01:00
32bf8ec826
Don't use cached informations for app version
...
When installing an app from the appstore the `\OC_App::getAppVersion` code is triggered twice:
- First when the downloader tries to compare the current version to the new version on the appstore to check if there is a newer version. This protects against downgrade attacks and is implemented in `\OC\Installer::downloadApp`.
- Second, when the app is actually installed the current version is written to the database. (`\OC\Installer::installApp`)
This fails however when the version is actually cached. Because in step 1 the cached version will be set to "0" and then be reused in the second step.
While this is probably not the cleanest version I assume this is an approach that is least invasive. Feedback and suggestions welcome :)
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-12-09 18:01:45 +01:00
7aa510b2f0
Document updater channel & check for correct PHP version in updater
...
* see https://github.com/nextcloud/updater/issues/53
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2016-12-06 00:19:13 +01:00
aac3024878
Merge pull request #2505 from nextcloud/sudo-mode-provisioning-api
...
Require sudo mode on the provisioning API
2016-12-05 22:29:29 +01:00
e368a745aa
Set last-login-check on basic auth
...
Else the last-login-check fails hard because the session value is not
set and thus defaults to 0.
* Started with tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-12-05 20:57:15 +01:00
1253d1008a
Merge pull request #2411 from nextcloud/fix-encryption-home-storage
...
check if the file should really be encrypted before we update the file cache
2016-12-05 15:38:12 +01:00
1a379b0fdc
update test
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-12-02 18:04:21 +01:00
2ca29f709b
Add tests
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-12-01 18:52:32 +01:00
62ec31eb7b
Merge pull request #2152 from nextcloud/preview_cleanupjob
...
Adds background job to cleanup all previews.
2016-11-30 10:39:21 +01:00
0f8fe77b3a
check if the file should really be encrypted before we update the file cache
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2016-11-29 20:34:45 +01:00
d86b29b42b
Merge pull request #2066 from nextcloud/fix-redirect-double-encoding
...
do not double encode the redirect url
2016-11-29 17:21:43 +01:00
3950ce9223
Merge pull request #2351 from nextcloud/remember-session-default
...
do not remember session tokens by default
2016-11-28 14:05:04 +01:00
0cc771ce19
Merge pull request #2353 from nextcloud/renew-session-token-remember
...
copy remember-me value when renewing a session token
2016-11-28 14:04:13 +01:00
6543182d13
fix parameter order
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2016-11-28 10:00:53 +01:00
ad610ae772
Merge pull request #2327 from nextcloud/exclude-pre-releases
...
Exclude pre-release versions as per SemVer
2016-11-28 09:55:24 +01:00
2183a1f3e6
copy remember-me value when renewing a session token
...
On renew, a session token is duplicated. For some reason we did
not copy over the remember-me attribute value. Hence, the new token
was deleted too early in the background job and remember-me did
not work properly.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2016-11-27 14:19:57 +01:00
9b808c4014
do not remember session tokens by default
...
We have to respect the value of the remember-me checkbox. Due to an error
in the source code the default value for the session token was to remember
it.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2016-11-27 14:03:28 +01:00
64fb0fb3dd
Merge pull request #2276 from nextcloud/update-email-address
...
Update email address
2016-11-25 11:40:20 +01:00
29402e2c0a
Exclude pre-release versions as per SemVer
...
As SemVer can be used apps could define a release like "10.0.0-alpha". This is something that we don't support at the moment in the server and we should filter all prereleases.
Ref https://github.com/nextcloud/server/pull/2307#issuecomment-262911588
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-25 11:32:46 +01:00
0de685c562
bring back setEmailAddress for the user management
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2016-11-25 10:26:48 +01:00
3fc75073b8
update accounts table if email address or display name changes from outside
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2016-11-25 10:26:47 +01:00
72f9920a58
Add Identityproof tests
...
* Add tests for Key
* Add tests for Manager
* Add tests for Signer
* Removed URLGenerator from Signer
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-24 21:50:19 +01:00
6a4c0cf237
Loop for newest version in appstore response
...
The current implementation when fetching apps from the appstore is to assume that the first element is the newest version, this is now always applicable and leads to the fact that for some apps (e.g. nextant) the newest version is not delivered. This can be easily tested by comparing the version of the downloaded Nextant version.
This change will loop over all releases delivered by the appstore and chooses the newest compatible one. While not the cleanest solution, it does its job.
Most of the code are actually unit tests. Whereas I have copied the whole original response from the appstore and also have performed the transformation. So that's why the diff looks so huge.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-24 14:29:57 +01:00
a05b8b7953
Harden cookies more appropriate
...
This adds the __Host- prefix to the same-site cookies. This is a small but yet nice security hardening.
See https://googlechrome.github.io/samples/cookie-prefixes/ for the implications.
Fixes https://github.com/nextcloud/server/issues/1412
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-23 12:53:44 +01:00
df215625f1
Merge pull request #1972 from nextcloud/invalid-files-from-scanner
...
Make sure we don't scan files that can not be accessed
2016-11-22 12:55:54 +01:00
cd24010fa4
Merge pull request #2214 from nextcloud/remove-logging
...
remove old logging section
2016-11-21 17:17:02 +01:00
0048b3aa2e
update tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-11-21 15:59:08 +01:00
d001dbd259
Adjust unit tests
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-21 11:30:03 +01:00
fb91bf6a5b
Add a signer class for signing
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-21 11:30:00 +01:00
b23a4ca96b
push public user data to the lookup server
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2016-11-21 11:29:59 +01:00
c5e61947a9
remove old test class
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2016-11-21 11:29:59 +01:00
08e6541a88
fix unit tests
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2016-11-21 11:29:58 +01:00
40b99734d3
introduce accounts table and keep it up-to-date with the data added to the personal settings
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-21 11:29:41 +01:00
558f169671
Move the validation into one place only
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-21 09:23:37 +01:00
4652d203e3
Make sure we don't scan files that can not be accessed
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-21 09:23:32 +01:00
78a318d388
Add test if repair step is already done
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-19 20:26:53 +01:00
ccb05dbb17
Adds background job to cleanup all previews.
...
* A repair step that inserts a background job for each user
* Each background job will delete for 15 seconds if it takes longer we
reschedule. This is done so instances that don't use the system cron
won't time out.
* Added tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-19 20:14:44 +01:00
8ec2e34576
Merge pull request #1602 from nextcloud/ignore-mod-env
...
Add system config htaccess.IgnoreFrontController for prettyURLs w/o mod_env
2016-11-18 21:42:56 +01:00
46768e71d9
Merge pull request #2076 from nextcloud/log_preview_access
...
Dispatch event on preview request
2016-11-18 20:45:29 +01:00
332eaec4c0
Merge pull request #1447 from nextcloud/password-confirmation-for-some-actions
...
Password confirmation for some actions
2016-11-18 15:42:30 +01:00
8b9ad46ba3
Merge pull request #768 from nextcloud/s3-objectstore
...
Add S3 objectstore backend
2016-11-18 14:55:07 +01:00
b2d9c20aac
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-18 12:10:51 +01:00
caacb6c261
Expose getAppPath to public API
...
Signed-off-by: Julius Haertl <jus@bitgrid.net>
2016-11-17 19:24:24 +01:00
1614b310ef
Add system config htaccess.IgnoreFrontController for prettyURLs w/o mod_env
...
Added the system config which sets all conditions to true that query the
FrontControllerActive mod_env variable.
Signed-off-by: Felix A. Epp <work@felixepp.de>
2016-11-16 22:28:49 +01:00
4ac5fdcf11
add tests for FileInfo::isMounted
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-11-16 15:30:37 +01:00
e4d1cf0f6d
add tests for http/output
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-11-16 15:30:37 +01:00
eefd059716
add amazon s3 objectstore backend
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-11-16 15:30:36 +01:00
64e896cc0d
split testing of objectstoragestorage and objectstore implementations
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-11-16 15:30:36 +01:00
e633f2f8df
add test
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-11-16 15:24:33 +01:00
e77432783b
Add test for setting up fake fs
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-11-16 15:24:32 +01:00
59d6003f89
Adds NullCache ans NullStorage tests for Lockdown
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-16 15:24:31 +01:00
e5bc80b31d
Adds TokenProvider and Mapper tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-16 15:24:31 +01:00
91851c37be
add tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-11-16 15:24:30 +01:00
4c3d18a9fc
explicit types
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-11-16 15:24:29 +01:00
b8958ee937
Fix activity manager tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-16 09:25:45 +01:00
28babd319b
Merge pull request #2137 from nextcloud/make-sure-tests-run-on-phpunit-4-again
...
Add a magic wrapper to allow phpunit4 to run the code again
2016-11-15 21:48:55 +01:00
b775d935f2
Endpoint is now 11.0.0
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-15 15:10:17 +01:00
5fd428413b
Adjust previous fallbacks
...
11.0 is 11 and not 9.2 anymore
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-15 15:07:58 +01:00
e76ef9aaa8
Add a magic wrapper from hell to allow phpunit4 to run the code again
...
Remove this once phpunit 5 is the lowest supported version, by reverting:
https://github.com/nextcloud/server/pull/2137
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-15 14:49:14 +01:00
506ccdbd8d
Introduce an event for first time login based on the last login time stamp
...
Use firstLogin event to trigger creation of default calendar and default address book
Delay login of admin user after setup so that firstLogin event can properly be processed for the admin
Fixing tests ...
Skeleton files are not copied over -> only 3 cache entries are remaining
Use updateLastLoginTimestamp to properly setup lastLogin value for a test user
2016-11-14 14:50:10 +01:00
16a110e803
Merge pull request #2067 from nextcloud/fileinfo-lazy-substorages
...
only query substorages to calculate the final mtime/size/etag when we need it
2016-11-14 11:39:02 +01:00
7cb0df28e2
Prevent downgrade attacks for apps
...
We should verify the app versions when installing a new update, otherwise this could result in downgrade attacks when an attacker just copies the old signature.
Plus it prevents the case that in case of a bug in the appstore actually an older version gets installed.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-11 18:53:26 +01:00
99ada40df4
Dispatch event on preview request
...
Fixes : #73
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-10 14:28:09 +01:00
cbcdf69dc2
only query substorages to calculate the final mtime/size/etag lazily
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-11-10 13:59:22 +01:00
0ebffa4a5f
do not double encode the redirect url
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2016-11-09 16:14:46 +01:00
9305094b8b
Add test and adjust PHP function arguments
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-09 10:49:57 +01:00
92e5fb4053
Add tests for validity of the definitions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-09 10:08:29 +01:00
706b5c3fb6
Use a php class for the definitions to avoid loading problems
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-09 08:52:07 +01:00
4393e8003b
Make sure the database is not replaced while we make a backup of the service
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-08 16:32:41 +01:00
04ece69a33
Cleanup OC_Group usage a bit
...
This is deprecated internal stuff. Should not be used anymore.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-04 20:55:47 +01:00
c0bbae28f0
Merge pull request #1741 from nextcloud/new_preview
...
Improve previews
2016-11-03 21:07:16 +01:00
7ba7949dc1
Merge pull request #1994 from nextcloud/proper-cron-hints
...
Show a hint for system based cron user name
2016-11-03 14:11:37 +01:00
87855aa97b
Added genertor helper & tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-03 14:00:33 +01:00
2164085f22
Fix urlgenerator test
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-03 14:00:33 +01:00
b33ceb6fdd
Merge pull request #1915 from nextcloud/downstream-26398
...
Add using casing check/fix for initMountPoints
2016-11-03 12:14:28 +01:00
0741346385
Show a hint for system based cron user name
...
* makes it easier to setup cron job
* gives hints for PHP documentation
* disables the cron setting if requirements not met
* fixes #1989
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2016-11-03 10:38:00 +01:00
6920e609c0
Adjust tests and DI for Share.php
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-02 23:26:49 +01:00
68cebef64c
DI for root.php
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-02 23:16:51 +01:00
39573e602d
Merge pull request #1978 from nextcloud/remove-send-mail-option
...
Remove send mail option
2016-11-02 22:36:05 +01:00
889e0a574b
Fix mock warning in some FS tests ( #26464 )
2016-11-02 22:21:47 +01:00
f737426eca
Add using casing check/fix for initMountPoints
2016-11-02 22:21:46 +01:00
c1feae1684
Merge pull request #1981 from nextcloud/multibucket-num-buckets
...
Allow setting a maximun number of buckets for multibucket
2016-11-02 22:05:57 +01:00
049bcae29e
Allow setting a maximun number of buckets for multibucket
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-11-02 21:31:24 +01:00
a8b7df9cc1
Add tests
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-02 21:10:51 +01:00
2c4035e806
Inject config and logger
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-02 20:30:37 +01:00
e6b52ef4cd
Merge pull request #1347 from nextcloud/bring-back-remember-me
...
fix remember me login
2016-11-02 18:32:38 +01:00
f556c58c22
remove 'send mail notification' option from sharing, replaced by send-by-mail feature
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2016-11-02 18:30:38 +01:00
e81d04cd8d
Merge pull request #1940 from nextcloud/new-appstore
...
Use new appstore API
2016-11-02 17:00:24 +00:00
9d6e01ef40
Add missing tests and fix PHPDoc
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-02 13:39:17 +01:00
6f86e468d4
inject ISecureRandom into user session and use injected config too
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2016-11-02 13:39:16 +01:00
d907666232
bring back remember-me
...
* try to reuse the old session token for remember me login
* decrypt/encrypt token password and set the session id accordingly
* create remember-me cookies only if checkbox is checked and 2fa solved
* adjust db token cleanup to store remembered tokens longer
* adjust unit tests
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2016-11-02 13:39:16 +01:00
370123b8b0
Merge pull request #1966 from nextcloud/fix-csrf-token-generation
...
Fix CSRF token generation / validation
2016-11-02 12:09:30 +01:00
e5d78a3523
Fix CSRF token generation / validation
...
Operate on raw bytes instead of base64-encoded strings.
Issue was introduced in a977465
2016-11-02 10:38:05 +01:00
318160647a
add method to check if a share provider for a given type is loaded
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2016-11-01 19:54:39 +01:00
7e2159e9bb
Add defaultShareProvider & federatedshareprovider tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-01 13:52:37 +01:00
d2110ebb0b
Add Manager unit tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-01 12:35:50 +01:00
0eeef26a8e
Add tests for installer method
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-31 19:39:35 +01:00
8acb54aa0b
Add update support
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-31 17:17:47 +01:00
89fc4358ba
Use substr and explode instead of a regex
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-31 17:17:45 +01:00
8d83e239f3
Fix tests
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-31 17:17:45 +01:00
32cf661215
Use new appstore API
...
This change introduces the new appstore API in Nextcloud.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-31 17:17:44 +01:00
3692769b0a
Add getShareTypesInFolder to optimize folder listening
...
Signed-off-by: Robin Appelman <icewind@owncloud.com>
2016-10-31 15:55:40 +01:00
83e7cfd13a
Fix more tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-28 22:16:28 +02:00
f722640a32
Proper DI of config
...
* Fixed comments
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-28 10:13:35 +02:00
f8352fcb8d
introduce callForSeenUsers and countSeenUsers ( #26361 )
...
* introduce callForSeenUsers and countSeenUsers
* add tests
* oracle should support not null on clob
* since 9.2.0
2016-10-28 08:44:05 +02:00
d4969abc9d
Merge pull request #1800 from nextcloud/nextcloud-rich-object-strings
...
Nextcloud rich object strings
2016-10-27 15:30:58 +02:00
b7046d390f
Remove internal share mail function
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-26 20:52:41 +02:00
b98dfaccd9
Merge pull request #1920 from nextcloud/legacy-pages-should-also-receive-the-nonce
...
Add nonce also to legacy CSP
2016-10-26 16:41:34 +02:00
cde7f535bd
Merge pull request #1738 from nextcloud/comments-provide-displaynames-with-mentions
...
comment mentions: show displayname not uid
2016-10-26 14:02:49 +02:00
c20ab0049f
Identify Chromium as Chrome
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-26 12:07:10 +02:00
e351ba56f1
Move browserSupportsCspV3 to CSPNonceManager
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-25 22:03:10 +02:00
89574367bc
Merge pull request #1871 from nextcloud/use-csp-nonces
...
Use CSP nonces
2016-10-25 14:46:00 +02:00
740ff9108b
Merge pull request #1884 from nextcloud/downstream-26292
...
Fix logClientIn for non-existing users (#26292 )
2016-10-25 11:24:13 +02:00
890f752a6b
Merge pull request #1452 from nextcloud/appconfig-endpoint
...
Appconfig endpoint
2016-10-25 10:57:48 +02:00
593d52fe91
Fix and cleanup SessionTest
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-25 09:34:27 +02:00
6d1e858aa4
Fix logClientIn for non-existing users ( #26292 )
...
The check for two factor enforcement would return true for non-existing
users. This fix makes it return false in order to be able to perform
the regular login which will then fail and return false.
This prevents throwing PasswordLoginForbidden for non-existing users.
2016-10-25 09:34:27 +02:00
38b3ac8213
Add ContentSecurityPolicyNonceManager
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-24 16:35:31 +02:00
03ec052b4e
App dependencies are now analysed on app enable as well - not only on app install.
2016-10-24 15:59:46 +02:00
9e6634814e
Add support for CSP nonces
...
CSP nonces are a feature available with CSP v2. Basically instead of saying "JS resources from the same domain are ok to be served" we now say "Ressources from everywhere are allowed as long as they add a `nonce` attribute to the script tag with the right nonce.
At the moment the nonce is basically just a `<?php p(base64_encode($_['requesttoken'])) ?>`, we have to decode the requesttoken since `:` is not an allowed value in the nonce. So if somebody does on their own include JS files (instead of using the `addScript` public API, they now must also include that attribute.)
IE does currently not implement CSP v2, thus there is a whitelist included that delivers the new CSP v2 policy to newer browsers. Check http://caniuse.com/#feat=contentsecuritypolicy2 for the current browser support list. An alternative approach would be to just add `'unsafe-inline'` as well as `'unsafe-inline'` is ignored by CSPv2 when a nonce is set. But this would make this security feature unusable at all in IE. Not worth it at the moment IMO.
Implementing this offers the following advantages:
1. **Security:** As we host resources from the same domain by design we don't have to worry about 'self' anymore being in the whitelist
2. **Performance:** We can move oc.js again to inline JS. This makes the loading way quicker as we don't have to load on every load of a new web page a blocking dynamically non-cached JavaScript file.
If you want to toy with CSP see also https://csp-evaluator.withgoogle.com/
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-24 12:27:50 +02:00
ab91fa2660
Merge pull request #1820 from nextcloud/4byte-filenames
...
Allow 4byte unicode filenames on supported platforms
2016-10-24 10:38:25 +02:00
7998689bc9
Added method to DB and fix test
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-24 09:45:04 +02:00
eaf152efeb
Fix DateTime comparisson
...
Datetime now returns microseconds. But if the database doesn't store
those comparing them for equality most likely fails.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-21 13:43:39 +02:00
0b1fb180a5
Make AppConfig part of the public API
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-21 09:09:23 +02:00
2799b0a821
Merge pull request #1835 from nextcloud/downstream-24948
...
Move OC\Files\Storage\Shared to the right namespace
2016-10-20 23:48:15 +02:00
9e9fef46d9
Get rid of very old oc:// stream wrapper ( #26381 )
2016-10-20 20:46:30 +02:00
c7ba73e6f4
Merge pull request #1824 from nextcloud/downstream-26423
...
Ensure $commands being an array
2016-10-20 20:43:26 +02:00
fca8bd44ab
Fix shared storage namespace in DecryptAll class
2016-10-20 20:36:50 +02:00
246bb9f33d
Move OC\Files\Storage\Shared to the right namespace
2016-10-20 20:27:44 +02:00
ef842ef20a
Ensure $commands being an array - fixes #26073
2016-10-20 15:40:27 +02:00
7836a8d8c7
use short array syntax
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2016-10-20 15:40:22 +02:00
9f2d9895a5
Restore all services when a tests failed/finished for better testcase isolation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-20 15:19:41 +02:00
122edcd0c1
Make sure all tests use the TestCase method to overwrite services
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-20 15:19:41 +02:00
e5ce61b174
add missing methods to test fake manager
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-20 14:32:32 +02:00
b35d2fd8f2
Allow rich object subjects for Notifications
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-20 12:14:59 +02:00
2098648850
Add Rich Object Definitions and a validator
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-20 12:14:51 +02:00
5d98ab83e9
resolve displayname via manager and registerable resolvers
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-19 00:34:00 +02:00
fea3e20a80
move mention extraction to (I)Comment and report mentions via DAV
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-19 00:33:55 +02:00
303e073724
Do not skip when mysql uses utf8mb4
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-19 00:15:01 +02:00
43b7b143f4
Fix test of repair step
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-19 00:15:01 +02:00
17a2723948
Fix the test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-19 00:15:01 +02:00
296a3274cf
only disable unicode test on mysql
2016-10-19 00:15:01 +02:00
972e560e72
Adding tests for 4 byte unicode characters
...
* success on SQLite and Postgres
* failure on MySQL due to the limited charset that only supports up to 3 bytes
2016-10-19 00:15:01 +02:00
96f8f209b9
Merge pull request #1449 from nextcloud/comments-user-mention
...
Notifications for simple @-mentioning in comments
2016-10-17 09:30:47 +02:00
62e19dfa80
Merge pull request #1441 from nextcloud/getby-id-less-queries
...
optimize Folder::getById to use less queries
2016-10-14 15:18:23 +02:00
53eb0f7f42
Merge pull request #1037 from nextcloud/no-double-token-update
...
dont update the auth token twice
2016-10-14 14:53:17 +02:00
1bcd2ca8e3
emit pre-update event for comments
...
* notifications can be cleaned up, no polluted DB
* updating comments will re-notify users or remove notifications, depending on the message
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-12 18:06:22 +02:00
0d842e0550
optimize Folder::getById to use less queries
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-10-12 16:12:28 +02:00
7eba1d806b
Add tests for commands in info.xml
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-11 19:48:31 +02:00
b1641cc113
Fix QueryBuilderTests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-11 12:30:46 +02:00
90db361827
Add test to ensure token times are updated
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-10-11 11:06:24 +02:00
25ed6714c7
dont update the auth token twice
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-10-11 11:05:25 +02:00
3c173378e8
Fix typehint
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-10 22:13:51 +02:00
2806a4bca7
Cleanup test case
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-10 22:13:47 +02:00
a0cb809342
Merge pull request #1660 from nextcloud/add-notification-icon-to-api
...
Add an icon to the notification API
2016-10-10 09:32:34 +02:00
195fc041da
Merge pull request #1663 from nextcloud/dont-reparse-info-xml
...
Dont reparse info xml + cache AppInfo XML
2016-10-10 09:22:43 +02:00
ce9e33bd3c
Merge pull request #1656 from nextcloud/appinfo-check-class-existance
...
Make sure all the jobs, command, provides and migrations are valid
2016-10-10 09:04:27 +02:00
0245dd7221
Simplify isSubDirectory check
...
Shaves off another 9ms per request as can be seen at https://blackfire.io/profiles/compare/dd54cef3-e58d-4a22-b8f4-c7c4b70697be/graph
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-07 21:56:43 +02:00
0c2b17c80f
Cache AppInfo in Memory Cache if configured
...
This saves around 20ms on a bare-bone instance, on bigger ones more (depending on the number of installed apps).
See https://blackfire.io/profiles/compare/fc326ad3-100d-49b8-8ea9-8343240f53f3/graph
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-07 21:29:23 +02:00
67d3574bdf
Don't parse info.xml but reuse already cached app infos - fixes #25603 ( #25968 )
...
* Don't parse info.xml but reuse already cached app infos - fixes #25603
* Use === in InfoParser. Fixes test
* InfoParser should not depend on UrlGenerator - fixes issue with session being closed too early
2016-10-07 20:58:22 +02:00
e1073cf442
Notificacations for simple @-mentioning in comments
...
(WIP) notify user when mentioned in comments
Fix doc, and create absolute URL for as notification link.
PSR-4 compatibility changes
also move notification creation to comments app
Do not notify yourself
unit test for controller and application
smaller fixes
- translatable app name
- remove doubles in mention array
- micro perf optimization
- display name: special label for deleted users, keep user id for users that could not be fetched from userManager
Comment Notification-Listener Unit Test
fix email adresses
remove notification when triggering comment was deleted
add and adjust tests
add missing @license tags
simplify NotificationsController registration
appinfo simplification, php docs
make string easier to translate
adjust test
replace dispatcher-based listeners with a registration method and interface
safer to not pass optional data parameter to setSubject for marking as processed. ID and mention suffices
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
update comment
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-07 17:11:19 +02:00
c77933ca22
Add an icon to the notification API
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-07 17:00:24 +02:00
c02a50a432
Make sure all the jobs, command, provides and migrations are valid
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-07 14:25:18 +02:00
626daabb56
Prefilter inaccessible shares in DefaultShareProvider::getSharedWith()
...
The DefaultShareProvider now does a DB-level check to find out whether
file_source is accessible at all (deleted file) or whether it's in the
trashbin of a home storage.
One small corner case where the home storage id is in md5 form cannot
be covered properly with this approach.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-06 13:57:58 +02:00
ea9b1cc340
Merge pull request #1306 from nextcloud/simplefs
...
Introducing AppData
2016-10-06 09:25:15 +02:00
a1f5364d7f
Generate coverage for quick DB tests
...
This adds the "QUICKDB" group which excludes some tests that abuse unit tests as integration tests as displayed in https://github.com/nextcloud/server/issues/1626
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-05 13:55:44 +02:00
7512683ea9
Fix avatar tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-05 11:00:17 +02:00
6807cb684f
avatar to appdata
...
* Fix AvatarTest
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-05 11:00:16 +02:00
ac38a3a654
Add Tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-05 11:00:16 +02:00
f27b7fa8d1
Do not use underscores in PSR4 namespaces of the backup codes app
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2016-10-03 21:47:33 +02:00
bf0371429c
Remove database requirement from test
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-03 14:15:18 +02:00
341cd0ef61
Merge pull request #1582 from nextcloud/make-comments-100-tested
...
Add test for setTopmostParentId and getTopmostParentId
2016-09-30 01:04:29 +02:00
d5f39164a1
Add test for setTopmostParentId and getTopmostParentId
...
This wasn't tested before as proven by the coverage data.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-09-29 22:43:48 +02:00
4d1acfd4ef
Only trigger postDelete hooks when the user was deleted...
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-09-29 15:40:53 +02:00
f6ff60f4cb
Make sure that comments, notifications and preferences are deleted
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-09-29 15:40:53 +02:00
19f94ac5f9
Merge pull request #1549 from nextcloud/kill-update-simulation
...
Kill update simulation
2016-09-28 16:29:09 +02:00
c4d263199c
Merge pull request #1521 from nextcloud/fix-mimetypedetect-hiddenfolder
...
Fix mimetype detection inside hidden folders (#26138 )
2016-09-27 18:52:48 +02:00
da0cea404d
Kill update simulation
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-09-27 18:43:53 +02:00
615b69677e
Use the same URL everywhere
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-09-27 14:52:22 +02:00
6f955defe4
Return the autoupdater value from the server
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-09-27 14:38:10 +02:00
9b4de310bd
Fix mimetype detection inside hidden folders ( #26138 )
...
Downstreaming of https://github.com/owncloud/core/pull/26138
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-09-26 11:31:03 +02:00
6dace7f6ad
Add tests
2016-09-15 13:11:36 +02:00
e39e1bdf4e
Merge pull request #1395 from nextcloud/issue-369-htaccess-max-sizes
...
Make sure memory limit is > post size and upload filesize
2016-09-13 22:39:08 +02:00
a3c8534b7b
Make sure memory limit is > post size and upload filesize
2016-09-13 16:50:36 +02:00
db710e0b03
Make tests work with 4.8 at least
2016-09-13 16:31:33 +02:00
368f407698
Fix getMock UtilTest
2016-09-13 09:09:53 +02:00
d616984879
Fix getMock User
2016-09-13 09:09:53 +02:00
478b86e5e5
Fix getMock UrlGeneratortest
2016-09-13 09:09:53 +02:00
2f36bbecb8
Fix getMock TagTest
2016-09-13 09:09:53 +02:00
1d166d645b
Fix getMock ManagerTest
2016-09-13 09:09:53 +02:00
7bc2d178ca
Fix getMock CertificateMangerTest
2016-09-13 09:09:53 +02:00
5aad530e6c
Fix getMock RepairUnmergedSharesTest
2016-09-13 09:09:53 +02:00
cd5183dccc
Fix getMock DBLockingProviderTest
2016-09-13 09:09:53 +02:00
dcf8091d69
Fix getMock HelperStorageTest
2016-09-13 09:09:53 +02:00
31532ecf13
Fix getMock ViewTest
2016-09-13 09:09:52 +02:00
5069b74f8b
Fix getMock scannertest
2016-09-13 09:09:52 +02:00
d277053f22
Fix getMock QuotaTest
2016-09-13 09:09:52 +02:00
fe15dccb45
Fix getMock FolderTests
2016-09-13 09:09:52 +02:00
d77982c03f
Fix getMock UserMountcacheTest
2016-09-13 09:09:52 +02:00
4b8d474ec5
Fix getMock Cache
2016-09-13 09:09:52 +02:00
3782edf49c
Fix getMock DecryptAllTest
2016-09-13 09:09:52 +02:00
16e88a7ebf
Fix getMock ManagerTest
2016-09-13 09:09:52 +02:00
77779d678f
Fix getMock FileCacheTest
2016-09-13 09:09:52 +02:00
c4ef825ceb
Fix getMock JobListTest
2016-09-13 09:09:52 +02:00
9404c04512
Fix getMock AppTests
2016-09-13 09:09:50 +02:00
6eba111e09
Fix failing preview unit tests ( #26039 )
2016-09-12 16:46:39 +02:00
c16aefcff5
Merge pull request #1317 from nextcloud/add-sharing-disclaimer
...
Adding a optional disclaimer to the anonymous upload page
2016-09-08 21:18:28 +02:00
5ac26d12f0
Merge pull request #1247 from nextcloud/storage-id-global-cache
...
more efficient querying of numeric storage ids
2016-09-08 21:09:14 +02:00
9a2ae2fe7d
Fix tests
2016-09-08 20:11:21 +02:00
6bb95de1c5
Adding a optional disclaimer to the anonymous upload page
2016-09-08 18:44:27 +02:00
0cec06d0c8
Change updater URL
2016-09-08 12:30:17 +02:00
ff691b4d8a
Merge pull request #836 from nextcloud/php7.1
...
Add PHP 7.1 drone tests
2016-09-08 09:19:59 +02:00
cdfe538452
Merge pull request #1243 from nextcloud/fix-detection-of-file-types-a-bit
...
Fix detection of file types a bit
2016-09-08 09:19:33 +02:00
9d00f367f9
Compare arrays not json strings
...
In php 7.1 the pretty print json output changed. Thus now we compare
arrays.
2016-09-07 23:06:18 +02:00
ab797929e2
Fix getMock Updater
2016-09-07 20:42:38 +02:00
d8a4769cd6
Fix getMock Template
2016-09-07 20:42:38 +02:00
9d4729cb6a
Fix getMock TempManagerTest
2016-09-07 20:42:38 +02:00
80c519fe89
Fix getMock Share
2016-09-07 20:42:38 +02:00
65409f5327
Fix getMock SetupTest
2016-09-07 20:42:38 +02:00
e1096c964d
Fix getMock Security
2016-09-07 20:42:38 +02:00
dc60f4c441
Fix getMock Repair
2016-09-07 20:42:38 +02:00
1b5ed67857
Fix getMock Migration
2016-09-07 20:42:38 +02:00
b8b9fc2b1c
Fix getMock OCSClient
2016-09-07 20:42:38 +02:00
c95d5c77d7
Fix getMock LegacyHelperTest
2016-09-07 20:42:38 +02:00
f167e65d49
Fix getMock L10NTest
2016-09-07 20:42:38 +02:00
ba3a90d30c
Fix getMock checkertest
2016-09-07 20:42:37 +02:00
97f6410ac8
Fix getMock Http Client
2016-09-07 20:42:37 +02:00
aa670cab14
Fix getMock HTTPHelper
2016-09-07 20:42:37 +02:00
28c801b3d5
Fix getMock MetaDataTest
2016-09-07 20:42:37 +02:00
7656a8fa12
File getMock Files tests
2016-09-07 20:42:37 +02:00
a819fd3f1e
Fix getMock FileChunkingTest
2016-09-07 20:42:37 +02:00
4da1ee99d6
Fix getMock Encryption
2016-09-07 20:42:37 +02:00
9ea2153e9b
Fix getMock Command/Intergrity
2016-09-07 20:42:37 +02:00
4066f04c4b
Fix getMock MapperTestUtility
2016-09-07 20:42:37 +02:00
2d9574db34
fix tests
2016-09-07 17:27:41 +02:00
e8e950a4d2
more efficient querying of numeric storage ids
2016-09-07 17:22:40 +02:00
7c0951244a
Deprecate getEditionString()
2016-09-06 16:05:28 +02:00
b6bdf81d55
Merge pull request #1275 from nextcloud/OCS_forward_headers_cleanup
...
Internal OCS Controller cleanup
2016-09-06 14:46:05 +02:00
3c55fe6bab
Split OCS version handling
...
This cleans up a bit the OCSController/Middleware. Since the 2 versions
of OCS differ a bit. Moved a lot of stuff internal since it is of no
concern to the outside.
2016-09-06 11:57:39 +02:00
c609e291bd
Fix getMock share
2016-09-06 09:33:48 +02:00
1a05201543
Fix getMock Avatar
2016-09-06 09:33:48 +02:00
4d3b92e687
Fix getMock Authentication
2016-09-06 09:29:27 +02:00
777c3ee325
Add FileDisplayResponse
...
A lazy implementation of the DisplayResponse that only hits the
filesystem if the etag and mtime do not match.
2016-09-05 15:09:54 +02:00
06fa486706
Merge pull request #1158 from nextcloud/cache_avatars
...
Cache avatars
2016-09-05 15:08:43 +02:00
db6a3367ad
Merge pull request #1259 from nextcloud/language_order
...
ACCEPT_LANGUAGE goes before default_langauge
2016-09-05 12:37:44 +02:00
24d90a4bb1
Correctly remove the charset from finfo mimetype
2016-09-05 09:48:22 +02:00
581a83c2a1
Fix AppTest and intergration test
2016-09-05 09:42:58 +02:00
ddb659dd90
increase core version number to trigger db ugprade and fix app manager tests
2016-09-05 08:51:13 +02:00
8acb734854
add 2fa backup codes app
...
* add backup codes app unit tests
* add integration tests for the backup codes app
2016-09-05 08:51:13 +02:00
0228bc6e66
ACCEPT_LANGUAGE goes before default_langauge
...
See https://github.com/nextcloud/server/issues/970
Before we had
1. Users settings in personal settings
2. Admins default language settings
3. Accept-Language settings of the browser
However this is not in line with
https://www.w3.org/International/questions/qa-lang-priorities
So this changes the order to
1. Users settings in personal settings
3. Accept-Language settings of the browser
2. Admins default language settings
2016-09-04 13:19:40 +02:00
7ffed2deae
Merge pull request #1221 from nextcloud/proper_204_304_response
...
No body or content-length for 204 and 304 responses
2016-09-01 15:04:09 +02:00
a3c1d74829
Remove unneeded Windows logic
2016-09-01 10:47:57 +02:00
21a87d3c2e
No body or content-length for 204 and 304 responses
...
See: https://tools.ietf.org/html/rfc7230#section-3.3
2016-08-31 23:07:48 +02:00
f9cea0b582
Merge pull request #797 from nextcloud/only-match-for-auth-cookie
...
Match only for actual session cookie
2016-08-31 15:59:16 +02:00
e4311a2ebd
Merge pull request #608 from nextcloud/small-encryption-improvement
...
skip shared files, if files get decrypted only for a specific user we…
2016-08-31 12:30:37 +02:00
57f9117843
Merge pull request #1087 from nextcloud/get-delay-twice
...
dont get bruteforce delay twice
2016-08-30 18:43:01 +02:00
6a85882f61
Fix tests
2016-08-30 09:00:22 +02:00
4afe4bda26
Merge pull request #891 from nextcloud/us_25810
...
[OC] Fix unmerged shares repair targetdecision
2016-08-30 08:22:34 +02:00
d5518735c9
always return numeric storage id as int, also check type equality in test asserts
2016-08-29 14:20:51 +02:00
6c93fe08f5
dont get bruteforce delay twice
2016-08-29 13:36:49 +02:00
4d85ffc27c
Merge pull request #1054 from nextcloud/less-cache-hits
...
Reduce the number of cache operations for dav operations
2016-08-27 22:44:29 +02:00
89c78bbce4
Merge pull request #1031 from nextcloud/2fa-infinite-redirect-loop
...
prevent infinite redirect loops if the there is no 2fa provider to pass
2016-08-26 16:03:05 +02:00
ad4cab130e
Merge pull request #1069 from nextcloud/l10ntest_nodb
...
L10N tests do not require DB
2016-08-25 23:38:27 +02:00
c5bdb4d4e8
L10N tests do not require DB
...
* Makes CI a bit more efficient
* Cleanup getMock warning
2016-08-25 22:41:23 +02:00
04cffe6d81
CappedMemoryCacheTest does not require DB
...
Makes CI a bit more efficient
2016-08-25 22:32:39 +02:00
2693ae870e
cache user folders
2016-08-25 17:22:25 +02:00
6af2efb679
prevent infinite redirect loops if the there is no 2fa provider to pass
...
This fixes infinite loops that are caused whenever a user is about to solve a 2FA
challenge, but the provider app is disabled at the same time. Since the session
value usually indicates that the challenge needs to be solved before we grant access
we have to remove that value instead in this special case.
2016-08-24 10:49:23 +02:00
2f1b17d44a
Merge pull request #1007 from nextcloud/shared-storage-non-recursive
...
Fix shared storage recursive setup
2016-08-23 22:15:38 +02:00
a0c2342c20
prevent infinite recursion while getting storage from mount
2016-08-23 14:52:18 +02:00
3ed102497e
Merge pull request #995 from nextcloud/workflow-section
...
Workflow section + hidden empty sections
2016-08-23 11:20:43 +02:00
5cd3f4e4dc
add test
2016-08-22 16:56:00 +02:00
baa91809bd
adjust test
2016-08-22 08:29:49 +02:00
7972fa5527
enlist only registered sections that also have settings registered to
2016-08-22 08:29:49 +02:00
d50e7ee36c
Remove reading PATH_INFO from server variable
...
Having two code paths for this is unreliable and can lead to bugs. Also, in some cases Apache isn't setting the PATH_INFO variable when mod_rewrite is used.
Fixes https://github.com/nextcloud/server/issues/983
2016-08-19 14:48:13 +02:00
162b153f22
Fix loading of ThemingDefaults
2016-08-19 11:26:22 +02:00
fe80bb1aff
Merge pull request #867 from nextcloud/notification-primary-action-always-first
...
Make sure the primary action is always the first one
2016-08-17 19:31:14 +02:00
df9b509ed3
Improve regexp to detect duplicate folders when repairing unmerged shares
2016-08-17 15:31:47 +02:00
7a2d25fab4
Fix unmerged shares repair with mixed group and direct shares
...
Whenever a group share is created after a direct share, the stime order
needs to be properly considered in the repair routine, considering that
the direct user share is appended to the $subShares array and breaking
its order.
2016-08-17 15:31:36 +02:00
56b94b220d
Improve file_target finding logic when repairing unmerged shares
...
Pick the most recent subshare that has no parenthesis from duplication
which should match whichever name the user picked last. If all
subshares have duplicate parenthesis names, use the least recent group
share's target instead.
2016-08-17 15:31:35 +02:00
027069cbae
Merge pull request #846 from nextcloud/provisioning_api_ocs
...
Move Provisioning API to the AppFramework
2016-08-17 10:23:13 +02:00
4943441bde
adjust tests to latest changes
2016-08-16 18:59:45 +02:00
717e22267a
Merge branch 'master' into implement_712
2016-08-16 18:31:59 +02:00
c044aa34fa
Make the capabilities manager more error proof
...
If an app registers an invalid capabilty we should not crash hard.
Instead we should catch the exception. Log it (error) and carry on.
* Added tests
2016-08-15 20:37:19 +02:00
7ffb7b0d84
Use MockBuilder instead of createMock
...
CI uses an older PHPUnit
2016-08-15 16:43:22 +02:00
8a7a0f3287
Add unit tests
2016-08-15 16:25:34 +02:00
3ed05f8769
Make sure the primary action is always the first one
2016-08-15 11:13:54 +02:00
a0b22227fc
Add tests
2016-08-14 18:34:01 +02:00
1f370c97ed
OCSController requires DataResponse
...
The OCS Controller requires a DataResponse object to be returned.
This means that all error handling will have to be done via exceptions
thrown and handling in the middleware.
2016-08-10 12:40:26 +02:00
9fbdb0efe8
Merge pull request #529 from nextcloud/vendor-maintenance-downgrade
...
Allow downgrades of maintenance accross vendors
2016-08-10 00:25:53 +02:00
5214b62d55
Merge pull request #691 from nextcloud/ocs_allow_all_old_routes
...
Allow ocs/v2.php/cloud/... routes
2016-08-09 20:52:49 +02:00
b53ea18ea5
Match only for actual session cookie
...
OVH has implemented load balancing in a very questionable way where the reverse proxy actually internally adds some cookies which would trigger a security exception. To work around this, this change only checks for the session cookie.
2016-08-09 19:23:08 +02:00
b4ed4e152e
Merge pull request #746 from nextcloud/jail-root
...
getJailedPath expects $path to have a trailing /
2016-08-09 11:04:11 +02:00
0032a5c2d1
Hanlde Core and Settings app in AppFramework
...
'core' and 'settings' are just apps but we treat them slightly
different. Make sure that we construct the correct namespace so we can
actually do automatic AppFramework stuff.
2016-08-08 20:48:16 +02:00
63f6d2d558
Allow ocs/v2.php/cloud/... routes
...
One of the possibilities of the old OCS API is that you can define the
url yourself.
This PR makes this possible again by adding an optional root elemenet to
the route. Routes are thus:
.../ocs/v2.php/<root>/<url>
By default <root> = apps/<app>
This will allow for example the provisioning API etc to be in
../ovs/v2/php/cloud/users
2016-08-08 15:01:26 +02:00
f37fa6e45c
Move Share backends to PSR-4 instead of using class path ( #24941 )
2016-08-05 14:13:41 +02:00
f1cd68d713
Adding test case for getPathById including a jailed cache where root is just empty
2016-08-05 14:06:05 +02:00
0c6352e095
Fix RepairUnmergedShares to not skip valid repair cases
...
The repair step was a bit overeager to skip repairing so it missed the
case where a group share exists without subshares but with an
additional direct user share.
2016-08-03 10:16:28 +02:00
67fa6bf9bc
Add repair step for unmerged shares (WIP)
2016-08-03 10:16:28 +02:00
5c718b13b8
We should properly check for 'true' instaed of the bool
2016-08-01 08:52:50 +02:00
f7f5216aa3
Dark hackery to not always disable CSRF for OCS controllers
2016-07-29 15:49:27 +02:00
54ae8eede3
Merge pull request #556 from nextcloud/nextcloud-version-check
...
Allow apps to check for a given nextcloud version
2016-07-29 09:26:25 +02:00
351cab6bce
skip shared files, if files get decrypted only for a specific user we shouldn't touch files owned by a different user.
2016-07-27 15:39:24 +02:00
8bdd0adcee
Support subdir in the OCS v2 endpoint
...
We should check against the ending substring since people could
run their nextcloud in a subfolder.
* Added test
2016-07-27 15:28:35 +02:00
9c21067c19
fix enabled apps tests
2016-07-27 08:36:03 +02:00
6482be040b
fix unit tests
2016-07-26 16:43:58 +02:00
0fcc39cd8e
Translate the server version for nextcloud
2016-07-26 14:40:18 +02:00
2f42a3fc31
Add workflowengine
2016-07-26 11:16:34 +02:00
352e24e703
Merge pull request #292 from nextcloud/recent-files
...
Add "Recent" file listing
2016-07-25 15:25:02 +01:00
4ad0c383ad
Merge pull request #523 from Faldon/master
...
Renamed file logging
2016-07-25 11:41:24 +02:00
81e103074e
use limit instead of since when listing recent files
2016-07-22 15:20:55 +02:00
a4ba3eadd0
fix test
2016-07-22 15:20:55 +02:00
5c34346479
Allow downgrades of maintenance accross vendors
2016-07-22 14:51:43 +02:00
61a1d56d27
Renamed test classes for file logging tests.
2016-07-22 14:47:50 +02:00
e321ecd592
add recent files to node api
2016-07-22 14:39:32 +02:00
72b06d250d
Add tests
2016-07-22 12:53:47 +02:00
ba3f4f118e
Changed logtype to file instead of owncloud.
...
- Updated the config sample to point to log_type='file'
- Renamed the Class for logfile logging to File in namespace 'OC\Log\'.
Changed the occurrences of 'OC\Log\Owncloud' to 'OC\Log\File'.
- Renamed the Class for log:file command to File in namespace 'OC\Core\Command\Log\File'.
Changed registration of the command to use 'OC\Core\Command\Log\File'.
- Changed default Syslog tag to Nextcloud
- Retained backwards compatibility for configs with 'logtype' => 'owncloud'
- Adjusted tests for the new file log.
Closes #490 .
2016-07-22 11:44:19 +02:00
c385423d10
Merge pull request #479 from nextcloud/add-bruteforce-throttler
...
Implement brute force protection
2016-07-21 00:31:02 +02:00
c1589f163c
Mitigate race condition
2016-07-20 23:09:27 +02:00
ba4f12baa0
Implement brute force protection
...
Class Throttler implements the bruteforce protection for security actions in
Nextcloud.
It is working by logging invalid login attempts to the database and slowing
down all login attempts from the same subnet. The max delay is 30 seconds and
the starting delay are 200 milliseconds. (after the first failed login)
2016-07-20 22:08:56 +02:00
020a2a6958
Merge pull request #476 from nextcloud/port-same-site-cookies
...
[master] Port Same-Site Cookies to master
2016-07-20 21:35:02 +02:00
78cad699fe
Merge pull request #475 from nextcloud/ocs-middleware
...
Add OCS Middleware
2016-07-20 21:04:25 +02:00
e08278494d
Merge pull request #471 from nextcloud/storage-fopenspecialchars
...
Added storage tests for fopen with special chars
2016-07-20 20:56:59 +02:00
5f32b57332
Add unit tests
2016-07-20 20:03:49 +02:00
a299fa38a9
[master] Port Same-Site Cookies to master
...
Fixes https://github.com/nextcloud/server/issues/50
2016-07-20 18:37:57 +02:00
1264e9644f
Merge pull request #402 from nextcloud/smb-notifications
...
smb update notifications
2016-07-20 16:19:21 +02:00
631af42b3a
Added storage tests for fopen with special chars
...
This makes it possible to test special chars with unit tests.
There is already a test for directories but there was none for file
names.
2016-07-20 15:13:24 +02:00
0bda09236e
Add route tests
2016-07-18 11:09:49 +02:00
6f9236fb3b
Merge pull request #381 from nextcloud/postgres-setup
...
use pdo for postgres setup
2016-07-15 21:30:51 +02:00
a3fa0d00c3
Cleanup ManagerTest
...
* Fix deprecated getMock call
* No longer requires DB
2016-07-14 13:49:18 +02:00
c04e7b13c3
Merge pull request #392 from nextcloud/roottest_nodb
...
RootTest does not require DB
2016-07-13 16:54:19 +02:00
29eeeb2273
Save the files external mount id in the mount cache table
2016-07-13 16:34:08 +02:00
927be847b9
RootTest does not require DB
...
* Removed from DB group
* Also mock the manager
* Fixed deprecated getMock warnings
2016-07-13 14:35:34 +02:00
b288c6796a
fix test
2016-07-13 14:33:04 +02:00
f2d091a963
Fix failing tests after db split
2016-07-13 09:26:19 +02:00
8d739f308b
Some UtilTests require DB
...
In the current setup there is no DI so no way to mock them.
2016-07-11 21:05:39 +02:00
5b6f5f1a07
LegacyGroupTest need DB
...
Those old tests make it impossible in the current state to abstract
away.
2016-07-11 21:02:27 +02:00
4ebf001b2e
Improve ManagerTest
...
* No DB required
* Fixed phpunit 5.4 warnings
2016-07-11 21:02:27 +02:00
31018adab3
Improve GroupTest
...
* No longer require DB
2016-07-11 21:02:27 +02:00
e8169e0d71
Merge pull request #364 from nextcloud/ca-bundle-tests
...
add test for needsRebundling() check
2016-07-11 17:34:31 +02:00
7c64e1973f
add test for needsRebundling() check
2016-07-11 15:51:48 +02:00
3b4535c3be
Improve NodeTest
...
* Do not use DB
* Fix phpunit-5.4 warnigns
* Moved commong stuff to setup
2016-07-11 15:41:02 +02:00
0c1cf5f7eb
Merge pull request #347 from nextcloud/drop-windows-foo
...
Remove unneeded checks if it runs on a Windows machine
2016-07-11 13:16:03 +02:00
6ea77abb38
Fix some more tests
2016-07-11 10:59:27 +02:00
1ace70d2c2
Merge pull request #351 from nextcloud/improve_filetest_unittest
...
Improve FileTest
2016-07-11 10:40:13 +02:00
937c9519d6
Mock logger
2016-07-11 08:50:30 +02:00
2fa9e67294
Fix phpunit-5.4 wargning
...
* getMock is deprecated.
* \PDOStatement mocking fails hard on phpunit 4.8
2016-07-11 08:50:07 +02:00
58dd278b4e
Correction is no longer required in php7
2016-07-08 19:36:17 +02:00
c91aebc437
Fix phpunit Trait warning
2016-07-08 19:36:17 +02:00
3a60626b77
Improve FileTest
...
* No longer requires DB
* Fixed phpunit 5.4 warnings
* Moved common stuff to Setup phase
2016-07-08 19:35:51 +02:00
c2d88a08b7
Remove unneeded checks if it runs on a Windows machine
...
* the setup check is still there
2016-07-08 15:55:17 +02:00
66a134e69e
Disallow certain malformed domain names even if they match the trusted domain expression
...
Stricter checking for valid domain names
2016-07-06 23:51:04 +00:00
2b4ceae620
Trusted domain wildcard checking made shorter, supporting multiple *
...
Added test cases
2016-07-06 23:38:30 +00:00
90b7f74da7
Changed name of default logfile from owncloud.log to nextcloud.log.
2016-07-04 11:50:32 +02:00
179a355b2c
Merge remote-tracking branch 'upstream/master' into master-sync-upstream
2016-07-01 11:36:35 +02:00
3acdc1339d
Merge pull request #206 from nextcloud/ci-mysql
...
Add mysql job to CI
2016-06-30 09:06:19 +02:00
01829e8d7c
mysql only works with 3 byte UTF-8
2016-06-29 15:53:23 +02:00
b55ab6d22a
Various database migration fixes ( #25209 )
...
* String columns with a length higher then 4000 are converted into a CLOB columns automagically - we have to respect this when migrating
* Adding schema migration tests to prevent unnecessary and non-sense migration steps
Fix Oracle autoincrement and unsigned handling
* Fix sqlite integer type for autoincrement
* Use lower case table names - fixes pg
* Fix postgres with default -1 - this only affect pg 9.4 servers - 9.5 seems to work fine
2016-06-29 14:54:41 +02:00
1710de8afb
Login hooks ( #25260 )
...
* fix login hooks
* adjust user session tests
* fix login return value of successful token logins
* trigger preLogin hook earlier; extract method 'loginWithPassword'
* call postLogin hook earlier; add PHPDoc
2016-06-27 22:16:22 +02:00
6670d37658
Merge remote-tracking branch 'upstream/master' into master-sync-upstream
2016-06-27 18:23:00 +02:00
2a990a0db5
verify user password on change
2016-06-27 14:08:11 +02:00
d4989c8037
remove old hook, no longer needed
2016-06-27 14:05:27 +02:00
630e4b1b46
check password for link shares
2016-06-27 14:05:27 +02:00
199c8e304c
Merge pull request #25250 from owncloud/linkshare-includedeletewithuploadperms
...
Add explicit delete permission to link shares
2016-06-27 12:14:05 +02:00
7a9d60d87e
Merge remote-tracking branch 'upstream/master' into master-upstream-sync
2016-06-26 12:55:05 +02:00
89198e62e8
check login name when authenticating with client token
2016-06-24 13:57:09 +02:00
0ad065cb8d
Repair step to adjust link share delete permissions
2016-06-24 09:48:48 +02:00
955635c7aa
Add explicit delete permission to link shares
...
Link shares always allowed deletion, however internally the permissions
were stored as 7 which lacked delete permissions. This created an
inconsistency in the Webdav permissions.
This fix makes sure we include delete permissions in the share
permissions, which now become 15.
In case a client is still passing 7 for legacy reasons, it gets
converted automatically to 15.
2016-06-24 09:48:48 +02:00
3db5de95bd
Merge pull request #25172 from owncloud/token-login-validation
...
Token login validation
2016-06-22 13:58:56 +02:00
2b493e2f9d
Merge remote-tracking branch 'upstream/master' into master-sync-upstream
2016-06-21 11:18:22 +02:00
b805908dca
update session token password on user password change
2016-06-21 10:24:25 +02:00
62e6de5df3
fix unit tests
2016-06-20 13:52:51 +02:00
56199eba37
fix unit test warning/errors
2016-06-20 10:41:23 +02:00
fb36fd495b
fix DefaultTokenMapperTest
2016-06-20 09:25:15 +02:00
5c68084823
fix default token provider tests
2016-06-20 09:17:19 +02:00
8ef5431e7a
fix user session tests
2016-06-20 09:10:11 +02:00
c4149c59c2
use token last_activity instead of session value
2016-06-17 15:42:28 +02:00
82b50d126c
add PasswordLoginForbiddenException
2016-06-17 11:02:07 +02:00
3521f974db
assert app is loaded in unit tests
2016-06-16 11:08:43 +02:00
a40d64ff7f
load 2FA provider apps before querying classes
2016-06-16 10:12:16 +02:00
9c328de4ab
Merge pull request #24415 from owncloud/optimize_sharingdisabled_for_user
...
Optimize isSharingDisabledForUser
2016-06-16 09:27:48 +02:00
1251df3e17
Merge pull request #25075 from owncloud/fix_23265
...
Remove shares of the root folder
2016-06-16 09:27:06 +02:00
05967a6904
Merge pull request #25093 from owncloud/issue-12816-clean-tags-from-deleted-users
...
Clean up tags of deleted users
2016-06-15 12:20:29 +02:00
ea4c5e6e0a
Fix unit tests
2016-06-14 13:24:48 +02:00
123bf78ca8
Clean up tags of deleted users
2016-06-14 12:38:09 +02:00
ae02685e6f
Merge branch 'master' of https://github.com/owncloud/core into downstream-160614
2016-06-14 01:06:25 +02:00
465807490d
create session token only for clients that support cookies
2016-06-13 19:44:05 +02:00
64471b5d4a
Remove shares of the root folder
...
Fixes #23265
(A possibly costly) repair job to remove cyclic shares.
2016-06-13 15:07:41 +02:00
5daa9a5417
fail hard if 2fa provider can not be loaded ( #25061 )
2016-06-13 12:46:45 +02:00
42c66efea5
Merge branch 'master' of https://github.com/owncloud/core into downstream-160611
2016-06-11 15:34:43 +02:00
842cc2a788
Merge pull request #19 from nextcloud/files-drop
...
add "hide file list" option
2016-06-10 18:29:09 +02:00
52a0c939ab
Merge pull request #24863 from owncloud/propagator-batching
...
Propagator batching for the file scanner
2016-06-10 17:45:52 +02:00
60225284f3
Add not-null columns for oracle
2016-06-10 12:44:49 +02:00
1b66db72d9
Repair job to fix permissions for avatars
...
Fixes #22978
On some older installations the permissions for the userRoot and the
avatars are not correct. This breaks since we now use the Node API in
the avatar code.
This repair job makes sure that the permissions are set correctly.
* Unit tests added
2016-06-10 12:44:49 +02:00
a636e4ff28
Downstream 2016-06-09
...
Merge branch 'master' of https://github.com/owncloud/core into downstream-160609
2016-06-09 18:45:12 +02:00
51fd2602a7
Revert "Downstream 2016-06-08"
2016-06-09 17:41:57 +02:00
7d51fd0310
Add repair step to clean old calendar/contact shares
...
fixes #21889
2016-06-09 15:48:45 +02:00
bb54ab0db8
add hide file list option
2016-06-09 15:15:17 +02:00
bee918693a
dissalow symlinks in local storages that point outside the datadir
2016-06-09 14:00:01 +02:00
4f27c2c433
Allow to decrypt user '0' files only
2016-06-09 14:00:00 +02:00
0041d89dc2
Do not allow to store boolean configs, they behave unexpected on postgres
2016-06-09 13:59:58 +02:00
67c2c85b05
allow deleting "ghost files" trough the View and Node api
2016-06-09 13:59:58 +02:00
826e276a79
Merge pull request #24973 from owncloud/token-password-session-token
...
When creating a session token, make sure it's the login password and …
2016-06-09 11:58:04 +02:00
aca4ea12c1
Merge pull request #24826 from owncloud/cors-client-login
...
use client login method on CORS routes
2016-06-09 10:31:14 +02:00
e49307014c
Do not log token or challenge with exception stacktrace ( #25026 )
...
* Make the filtering better readable
* Add some more methods to the sensitive list
2016-06-08 16:32:58 +02:00
9997c431c3
use client login method on CORS routes
2016-06-08 15:18:53 +02:00
ec929f07f2
When creating a session token, make sure it's the login password and not a device token
2016-06-08 13:31:55 +02:00
8d0948977e
Merge pull request #24899 from owncloud/local-storage-symlinks
...
dissalow symlinks in local storages that point outside the datadir
2016-06-08 10:19:24 +02:00
ed92f4c427
Merge pull request #24983 from owncloud/issue-23776-do-not-allow-boolean-user-config
...
Do not allow to store boolean configs, they behave unexpected on postgres
2016-06-08 10:14:08 +02:00
b7935dcebd
Merge pull request #24998 from owncloud/issue-24994-allow-decrypting-user-0-only
...
Allow to decrypt user '0' files only
2016-06-08 10:12:28 +02:00
38451c85f1
skip failing tests
2016-06-07 17:54:40 +02:00
7b1b723e5b
dissalow symlinks in local storages that point outside the datadir
2016-06-07 14:01:53 +02:00
d4ba982131
Allow to decrypt user '0' files only
2016-06-07 09:13:11 +02:00
911fd3ead4
Do not allow to store boolean configs, they behave unexpected on postgres
2016-06-06 12:38:20 +02:00
63408fa6ef
allow deleting "ghost files" trough the View and Node api
2016-06-03 13:30:59 +02:00
11900baaf3
add tests for propagator batching
2016-06-02 15:09:15 +02:00
5b1eb416d8
Fix TestCase::invokePrivate to work with static classes
2016-06-01 14:28:59 +02:00
5ad8fa7675
Add keepUnicode value in the cache key of normalizedPathCache
2016-06-01 14:28:59 +02:00
c58d8159d7
Create session tokens for apache auth users
2016-05-31 17:07:49 +02:00
a441220f24
Merge pull request #24628 from owncloud/decryptall-checkifneedsprocessing
...
[decrypt_all] Check if file needs to decrypted or not for speed up large oc setups.
2016-05-31 10:12:03 +02:00
718f0757e4
Fix for #23066 ( #24689 )
2016-05-31 06:53:28 +02:00
b15babd061
fix unit tests
2016-05-30 14:49:27 +02:00
4b1e8a1184
One more PSR-4 fix ( #24852 )
2016-05-26 16:31:26 +02:00
4cfefda891
Move Test\Files\Storage\Wrapper\EncodingTest to PSR-4
2016-05-25 15:26:14 +02:00
28ce7dd262
do not allow client password logins if token auth is enforced or 2FA is enabled
2016-05-24 17:54:02 +02:00
d3fb5d618e
Merge pull request #24748 from owncloud/login-explicitly
...
Log in explicitly, save login name when generating browser/device tokens
2016-05-24 17:51:49 +02:00
e7110c7678
Merge pull request #24760 from owncloud/objectstore_multibucket
...
Objectstore multibucket
2016-05-24 15:15:59 +02:00
ad10485cec
when generating browser/device token, save the login name for later password checks
2016-05-24 11:49:15 +02:00
abe338f433
Store user bucket in preferences
2016-05-23 21:57:41 +02:00
4f6670d759
Merge pull request #24658 from owncloud/invalidate-disabled-user-session
...
invalidate user session if the user was disabled
2016-05-23 20:50:25 +02:00
87fa86a69a
Merge pull request #24559 from owncloud/2fa
...
two factor auth
2016-05-23 20:50:03 +02:00
e03e4921a0
Fix Name
2016-05-23 20:42:08 +02:00
7ef21b0b27
Add unit tests for ObjectHomeMountProvider
2016-05-23 20:42:08 +02:00
12b63258d5
Add mapper unit tests
2016-05-23 20:42:08 +02:00
eca57be336
Only recurse into incomplete folders during background scans
2016-05-23 14:40:35 +02:00
57525a02f8
Merge pull request #24703 from owncloud/personal-settings-auth-tokens
...
Personal settings auth tokens
2016-05-23 14:17:01 +02:00
bd87f67473
Merge pull request #24349 from owncloud/nfd-storagewrapper
...
Add wrapper for NFD encoding workaround
2016-05-23 13:45:33 +02:00
dfb4d426c2
Add two factor auth to core
2016-05-23 11:21:10 +02:00
c20cdc2213
invalidate user session if the user is disabled
2016-05-23 10:32:16 +02:00
5ba1add03c
Merge pull request #24603 from owncloud/federated_reshare
...
flat federated re-share
2016-05-23 09:52:13 +02:00
74277c25be
add button to invalidate browser sessions/device tokens
2016-05-23 09:11:12 +02:00
7a6966cdfe
Merge pull request #24732 from owncloud/autoloader_fix
...
Autoloader fix
2016-05-21 19:09:22 +02:00
8646802850
Merge pull request #24696 from owncloud/lock-jobs-while-executing
...
Lock jobs while executing them, to allow multiple executors to run in…
2016-05-21 19:08:15 +02:00
d0a2fa0506
Lock jobs while executing them, to allow multiple executors to run in parallel
2016-05-21 01:59:25 +02:00
7b25839bd5
use share initiator as fall back to access the file
...
in case of federated re-shares the owner can be a remote user.
Therefore we can't always use to owner to access the local file
2016-05-20 21:15:15 +02:00
88740f035d
Act on effective system tag canAssign permission
...
Whenever the server returns true for the can-assign Webdav property of
a system tag, it means the current user is allowed to assign,
regardless of the value of user-assignable.
This commit brings the proper logic to the web UI to make it possible
for users to assign when they have the permission.
2016-05-20 17:56:02 +02:00
b5eb3d9e5a
Add system tag assignability check with groups
...
Whenever a user is not an admin, a tag is visible but not
user-assignable, check whether the user is a member of the allowed
groups.
2016-05-20 17:56:02 +02:00
3cd65fe25d
Add systemtag_group table and get/set methods
...
Added systemtag to group mapping table.
Added methods in ISystemTagManager to get/set the group mappings.
2016-05-20 17:56:02 +02:00
09b3883d9c
Updated canUser* functions in SystemTagManager to accept objects
2016-05-20 17:56:02 +02:00
8343cfb64b
Add interface methods for permission check
...
Instead of checking for admin perm, use interface method
canUserAssignTag and canUserSeeTag to check for permissions.
Allows for more flexible implementation.
2016-05-20 17:56:02 +02:00
54b637e83c
Fix unit tests
2016-05-20 16:35:07 +02:00
94ad54ec9b
Move tests/ to PSR-4 ( #24731 )
...
* Move a-b to PSR-4
* Move c-d to PSR-4
* Move e+g to PSR-4
* Move h-l to PSR-4
* Move m-r to PSR-4
* Move s-u to PSR-4
* Move files/ to PSR-4
* Move remaining tests to PSR-4
* Remove Test\ from old autoloader
2016-05-20 15:38:20 +02:00
e8d082208d
Fixes for encoding wrapper
...
Improved label
Fixed rename/copy/moveFromStorage/copyFromStorage and added tests
Improved findPathToUse algo
2016-05-20 09:33:59 +02:00
63bbbf29f4
Add wrapper for NFD encoding workaround
2016-05-20 09:33:59 +02:00
b495895017
Merge pull request #24728 from owncloud/no-more-test_-files
...
Fix autoloader for Test* files
2016-05-20 09:29:01 +02:00
f8180391fd
Create a Fallback in the old autoloader for PSR-4 Test\TestCase
2016-05-19 15:45:34 +02:00
ffa4633822
No more Test_* files exist, remove autoloading
2016-05-19 15:38:16 +02:00
f42cdec4c4
Merge pull request #24725 from owncloud/ocs-provider-psr4
...
Move OCS Provider to PSR-4 namespace
2016-05-19 15:36:19 +02:00
3b3940df6b
Merge pull request #24660 from owncloud/no-token-login-for-disabled-users
...
don't allow token login for disabled users
2016-05-19 15:32:09 +02:00
61b3260ebd
Merge pull request #24716 from owncloud/fix-test-namespaces-2
...
Fix test namespaces [files-]
2016-05-19 15:31:43 +02:00
20f229eed9
Move OCS Provider to PSR-4 namespace
2016-05-19 11:10:32 +02:00
bae4118b4f
Fix renamed class
2016-05-19 10:33:12 +02:00
e36a27d21c
Merge pull request #24712 from owncloud/fix-test-namespaces
...
Fix test namespaces [a-e]
2016-05-19 10:30:07 +02:00
320b1c3abf
Fix more failures
2016-05-19 10:11:42 +02:00
f24179a327
Fix deprecated private method
2016-05-19 09:44:53 +02:00
e88a9b2fed
Fix missing backtick before OC
2016-05-19 09:41:45 +02:00
e823d50044
Fix "Class 'Test\Security\DateTime' not found"
2016-05-19 09:40:34 +02:00
9a4253ef7c
Fix lib/
2016-05-19 09:38:52 +02:00
55fc6536d3
FIx lib/ a-d
2016-05-19 09:27:21 +02:00
7f3f16d155
Fix namespace in user/
2016-05-19 09:19:03 +02:00
a107e7de7b
Fix namespace in share/
2016-05-19 09:15:10 +02:00
68481c10e6
Fix namespaces in security/
2016-05-19 09:02:58 +02:00
a9f24a74a2
Fix namespace in repair/
2016-05-19 08:59:37 +02:00
d19d6533dd
Fix public/ namespace in tests
2016-05-19 08:56:47 +02:00
859d2bc0ff
Fix namespace of memcache/ and ocs/
2016-05-19 08:53:06 +02:00
71603fe348
Fix namespace in log/ and mail/
2016-05-19 08:50:14 +02:00
0ab1120a33
Fix namespaces in tests/lib/integritycheck
2016-05-19 08:48:22 +02:00
51db410e67
Fix namespaces in tests/lib/http/
2016-05-19 08:46:58 +02:00
995d4b7ecd
Fix namespaces in tests/lib/groups/
2016-05-19 08:44:41 +02:00
b1458d590d
Fix namespaces and class names in tests/lib/files/
2016-05-19 08:41:01 +02:00
f824f3e5f3
don't allow token login for disabled users
2016-05-18 21:10:37 +02:00
f57407e73e
Fix file name in tests/lib/encryption
2016-05-18 18:57:46 +02:00
ba230888c6
Fix filenames and class names in tests/lib/comments
2016-05-18 18:57:46 +02:00
bbf758b1b0
Fix file name of command test
2016-05-18 18:57:46 +02:00
1b6cd583f7
Fix namespace of tests/cache/
2016-05-18 18:57:46 +02:00
c54d79947b
Fix missing namespaces in tests/lib/db/
2016-05-18 18:57:45 +02:00
5ce5eb195a
Fix namespace for archive tests
2016-05-18 18:57:45 +02:00
9eade36ae5
Fix namespaces in AppFramework tests
2016-05-18 18:57:45 +02:00
0626578739
add method to query all user auth tokens
2016-05-18 18:25:37 +02:00
98b465a8b9
a single token provider suffices
2016-05-18 09:20:48 +02:00
5c9103287f
Group fixup ( #24621 )
...
* Move used OC_Group_xx to \OC\Group
* Add (deprecated) legacy wrapper in legacy, OC_Group_xx
* Replace deprecated use of OC_Group_xx with \OC\Group\xx
2016-05-17 16:06:44 +02:00
e383a9506d
Merge pull request #24617 from owncloud/autoloader_no_private
...
our autoloader should not load classes in \OC
2016-05-13 17:30:10 +02:00
9ac763a640
Merge pull request #24594 from owncloud/authtoken-name-column-size
...
Use CLOB for auth token names to allow long user agent strings
2016-05-13 11:56:52 +02:00
d022b6fad4
Fix unit tests
2016-05-13 11:33:21 +02:00
eb79b83831
Move functions.php to legacy
...
This file should really be properly namespaced etc!
2016-05-13 08:54:07 +02:00
c28e462583
Use CLOB for auth token names to allow long user agent strings
2016-05-12 11:19:17 +02:00
69dafd727d
delete the token in case an exception is thrown when decrypting the password
2016-05-11 13:36:46 +02:00
af707fba41
use the query builder instead of raw sql statements
2016-05-11 13:36:46 +02:00
46bdf6ea2b
fix PHPDoc and other minor issues
2016-05-11 13:36:46 +02:00
f0f8bdd495
PHPDoc and other minor fixes
2016-05-11 13:36:46 +02:00
dff108e97b
fix mock builder for old phpunit versions
2016-05-11 13:36:46 +02:00
fbb5768587
add unit tests for all new classes
2016-05-11 13:36:46 +02:00
aa85edd224
increase token column width
...
add some range to time() assertions
2016-05-11 13:36:46 +02:00
8cc5f6036f
Fix existing tests
2016-05-11 13:36:46 +02:00
f6ee738ba8
Add \OC\User\Backend
...
Since some apps (ldap et al) still depend on OC_User_Backend this seemed
like the cleanest approach.
2016-05-10 19:53:36 +02:00
9e1d9871a8
Move OC_User_Database to \OC\User\Database
2016-05-10 19:53:36 +02:00
e8e72aa910
Merge pull request #24434 from owncloud/permalinks
...
Permalinks
2016-05-10 09:44:50 +02:00
8b428d84c0
Make update server URL configurable
...
Currently testing the updates is a big problem and not really super easy possible. Since we now have a new updater server we should also make this configurable so that people can properly test updates.
2016-05-09 11:25:58 +02:00
108bd26856
Fix unit tests broken after #24457
...
Timeout was increased but tests were not updated.
2016-05-09 08:54:30 +02:00
caefe23bb6
Send permalink in internal share notification emails
2016-05-06 16:46:59 +02:00
873849e843
Merge pull request #24432 from owncloud/issue-24270-never-save-app-language-into-request-lang
...
Do not save the language as request lang for apps when we didn't find…
2016-05-04 13:47:08 +02:00
9fbb8ce302
Do not save the language as request lang for apps when we didn't find any
2016-05-04 08:28:13 +02:00
4b2544925f
Merge pull request #23844 from owncloud/disable-user
...
Add occ commands to enable and disable a user + a disabled user can n…
2016-05-03 15:22:41 +02:00
fc82047e26
Move OC_Log_xx to \OC\Log namespace
2016-05-03 08:57:26 +02:00
adf7e7295e
Merge pull request #24375 from owncloud/archive_move
...
Move OC_Archive to \OC\Archive and PSR-4
2016-05-03 08:37:01 +02:00
c87bd0432a
Merge pull request #24380 from owncloud/move-activity-manager-to-namespace
...
Move activity manager to the namespace
2016-05-03 07:40:04 +02:00
0cb434686c
Move OC_Archive_XX to PSR-4
...
* Fix code
* Fix tests
2016-05-02 19:32:51 +02:00
05cf552f66
Merge pull request #24322 from owncloud/install-and-uninstall-repair-steps
...
Adding repair steps for install and uninstall
2016-05-02 17:50:29 +02:00
b84825f030
Merge pull request #24229 from owncloud/session-id-wrapper
...
add ISession::getId() wrapper for session_id
2016-05-02 16:49:38 +02:00
7bfc617b03
Move activity manager to the namespace
2016-05-02 11:57:24 +02:00
3397e27657
Remove the password from the validateUserPass() method as well
2016-05-02 10:44:09 +02:00
9c9fec36dd
Add occ commands to enable and disable a user + a disabled user can no longer login - fixes #23838
2016-05-02 09:31:22 +02:00
e049953d1a
OC_Installer -> \OC\Installer
2016-05-02 08:52:06 +02:00
e59ccc5fe9
Merge pull request #24299 from owncloud/availability-avoid-concurrency
...
Prevent concurrent storage availability checks
2016-04-29 17:43:31 +02:00
66ebc2ee6f
Merge pull request #24337 from owncloud/add-db-group-for-required-tests
...
Add the DB group for preview tests that require the database
2016-04-29 15:02:27 +02:00
6571da1519
Merge pull request #24305 from owncloud/update-show-repair-step-progress
...
[Update] show repair step progress ...
2016-04-29 13:47:15 +02:00
a85be14b62
Add the DB group for tests that require the database
2016-04-29 09:30:47 +02:00
4c1b55be92
allow app developers to specify the minimum int size
...
simplify comparison
remove additional null
fix off by 1 error
2016-04-28 22:55:15 +02:00
0e774e0fd8
Merge pull request #24274 from owncloud/async-repair-steps
...
Introduce background repair steps
2016-04-28 14:11:43 +02:00
bbd2a07525
Remove emitter from class Repair
2016-04-28 13:52:01 +02:00
77cec29b10
Prevent concurrent availability checks
2016-04-26 22:30:09 +01:00
ddbebe91f0
Merge pull request #24246 from owncloud/local-invalid
...
error out if a local storage isn't setup correctly
2016-04-26 20:57:56 +02:00
2f01c83a01
add tests
2016-04-26 16:08:52 +02:00
e93bf80b29
throw SessionNotAvailableException if session_id returns empty string
2016-04-26 14:51:21 +02:00
2ee7d2485c
Introduce background repair steps
2016-04-26 11:56:56 +02:00
23e7ad7a78
Merge pull request #24256 from owncloud/scanner-propagate
...
triger the propagator from the command line scanner
2016-04-26 10:05:39 +02:00
61054df36d
triger the propagator from the command line scanner
2016-04-25 17:23:48 +02:00
c7542c02db
Introduce OCP\Migration\IRepairStep and adopt all repair steps to this new interface - refs #24198
2016-04-25 15:01:13 +02:00
0d53e86421
add ISession::getId() wrapper for session_id
2016-04-25 10:36:24 +02:00
8c7c713e86
Merge pull request #24187 from owncloud/fs-initmountpoint-rethrowifusernotfoundagain
...
Mark $usersSetup only if user was found in initMountPoints
2016-04-22 17:25:40 +02:00
4eebccd81f
Fix inconsistent nameing of AppFramework
2016-04-22 16:00:00 +02:00
cc4efc4c03
Merge pull request #24085 from owncloud/feedback-on-app-migrations
...
App migration steps need to push feedback to the user ....
2016-04-22 14:39:11 +02:00
13c01e62cf
Mark $usersSetup only if user was found in initMountPoints
...
initMountPoints is marking a user as successfully initialized too
early. If the user was not found an NoUserException was thrown, the
second time initMountPoints is called would not rethrow the exception
and happily continue.
This fix makes sure that we consistently throw NoUserException when
initMountPoints is called repeatedly with invalid users.
2016-04-22 14:29:41 +02:00
43323b0062
Merge pull request #24183 from owncloud/change-background-job-sort-order
...
Change the sort order of background jobs to be DESC instead of ASC
2016-04-22 13:33:54 +02:00
085bcd7da2
Throw NoUserException when attempting to init mount point for null user
...
In some scenarios initMountPoints is called with an empty user, and
also there is no user in the session.
In such cases, it is unsafe to let the code move on with an empty user.
2016-04-22 11:46:33 +02:00
04cee6a7db
Change the sort order of background jobs to be DESC instead of ASC
...
In theory, if your instance ever creates more jobs then your system cron can
handle, the default background jobs get never executed anymore. Because
everytime when the joblist returns the next job it looks for the next ID,
however there is always a new next ID, so it will never wrap back to execute
the low IDs. But when we change the sort order to be DESC, we make sure that
these low IDs are always executed, before the system jumps back up to
execute the new IDs.
2016-04-22 10:49:55 +02:00
d0030aad6c
Remove deprecated HTTPHelper from InfoParser
2016-04-22 08:38:41 +02:00
06a4da43ec
[master] Ignore certificate file if it starts with file://
2016-04-21 19:02:31 +02:00
b50d3255fb
Merge pull request #22791 from owncloud/enc_master_key_improvements
...
Enc master key improvements
2016-04-21 11:48:26 +02:00
cd01c440a0
Merge pull request #23919 from owncloud/cyclyc-share-dep-example
...
SharedStorage to new sharing code + cleanup
2016-04-20 20:37:27 +02:00
cdcabbd0b3
Merge pull request #24098 from owncloud/fix_23782
...
When calling file_put_contents clear the checksum
2016-04-20 20:37:01 +02:00
aa33ab0c03
Merge pull request #24094 from owncloud/move_dummy_group_backend_to_test
...
Move the group dummy backend to test
2016-04-20 11:55:00 +02:00
0dbcbc4cae
When the scanner detects a file is changed clear checksum
...
Fixes #23782 and #23783
If the file scanner detects a changed file we clear the checksum while
we update the cache.
* Unit test added
2016-04-19 20:20:45 +02:00
5b2ef92eb2
Merge pull request #24004 from owncloud/dont-transfer-files-to-not-ready-user
...
Introduce isReadyForUser and verify in file transfer ownership
2016-04-19 15:56:47 +02:00
dd7e0d13e5
Move the group dummy backend to test
...
The dummy backend is only used for testing and should thus reside in
tests.
2016-04-19 15:13:31 +02:00
92abb5f23d
Fix tests
2016-04-19 14:04:00 +02:00
1773dcbef2
Merge pull request #23973 from owncloud/share_move_post_delete_from_group_hook
...
Move post_removeFromGroup to shareManager
2016-04-19 06:59:58 +02:00
1626850fc9
Remove deprecated HTTPHelper
2016-04-18 17:28:10 +02:00
5c3183cedd
Move version check code out of class Updater
2016-04-18 17:12:59 +02:00
331e4efacb
Move login form into controller
...
First step on getting the authorisation stuff cleaned up. This is only for the login form, all other stuff is still where it is.
2016-04-15 17:36:23 +02:00
50e20e531e
Introduce isReadyForUser and verify in file transfer ownership - fixes #23786
2016-04-15 15:07:40 +02:00
6144ced7a0
Move post_removeFromGroup to shareManager
...
The last sharing hook to be moved over.
* Added unit tests
* Removed old tests that relied on old behaviour
* Removed old hooks.php
2016-04-13 15:00:12 +02:00
ef93ec8bc2
Add test
2016-04-12 21:32:40 +02:00
fdee771aca
Add unit testing capabilities for templates ( #23708 )
...
Add unit testing capabilities for templates
2016-04-12 12:49:11 +02:00
495a964ca2
Migrate post_groupDelete hook to share manager ( #23841 )
...
The hook now calls the share manager that will call the responsible
shareProvider to do the proper cleanup.
* Unit tests added
Again nothing should change it is just to cleanup old code
2016-04-12 09:46:25 +02:00
8e16e7bf34
Merge pull request #23856 from owncloud/share_remove_addtogroup_hooks
...
Remove pre/post_addToGroup hooks for shares
2016-04-11 15:05:20 +02:00
2a0244df27
Fix mappertest
2016-04-08 15:23:09 +02:00
f9ade49c7e
Fix notification tests
2016-04-08 15:23:06 +02:00
e65e7a5ad7
Fix ShareManager tests
2016-04-08 15:22:57 +02:00
1d3d43b1e9
Merge pull request #23553 from owncloud/lock-ttl-execution-time
...
Make lock ttl configurable
2016-04-08 14:53:26 +02:00
bd3bde2f3b
Set proper permissions on link share
...
If we do not allow public upload we should limit the permissions on
links shares upon retrieval.
* Added unit test
* Allow fetching federated shares by token as well
2016-04-08 14:17:05 +02:00
3fae4c82d2
Remove pre/post_addToGroup hooks for shares
...
There is no need to perform the checks for unique targets on add to
group as we have to do this all when mounting the shares anyway.
2016-04-08 11:56:38 +02:00
0de15a86f0
Merge pull request #23773 from owncloud/share_move_delete_user_hook
...
Migrate post_userDelete hook to share manager
2016-04-07 13:01:10 +02:00
cdedda99e4
Make lock ttl configurable
2016-04-07 08:24:13 +02:00
02e226a6b3
tests: Fix typos (found by codespell)
...
Fix also a small grammar issue.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2016-04-06 15:08:27 +02:00
93b1768eb7
Merge pull request #23819 from owncloud/move-core-completely-to-psr4
...
Move OC/Core completely to PSR-4
2016-04-06 13:31:44 +02:00
5a0c936f99
Remove OC/Settings from old autoloader
2016-04-06 11:34:53 +02:00
c952adabb5
Remove OC/Core autoloading from old autoloader
2016-04-06 11:34:29 +02:00
4445ef82e0
Test locking with strange filename
2016-04-05 16:13:28 +02:00
e0cee43cf0
Migrate post_userDelete hook to share manager
...
This makes the post_userDelete hook call the sharemanager. This will
cleanup to and from this user.
* All shares owned by this user
* All shares with this user (user)
* All custom group shares
* All link share initiated by this user (to avoid invisible link shares)
Unit tests are added for the defaultshare provider as well as the
federated share provider
2016-04-04 14:15:38 +02:00
2bff34be56
Merge pull request #23707 from owncloud/make-sure-that-encrypted-version-is-set
...
Make sure that the encrypted version is set
2016-03-31 20:37:17 +02:00
fdb59079a2
Merge pull request #23675 from owncloud/fix_encryption_versions_on_external_storages
...
fix creation of versions of encrypted files on external storages
2016-03-31 20:36:03 +02:00
93ed965cbb
fix creation of versions of encrypted files on external storages
...
in order to create a 1:1 copy of a file if a version gets created
we need to store this information on copyBetweenStorage(). This
allows us to by-pass the encryption wrapper if we read the source file.
2016-03-31 19:24:47 +02:00
c427bf3b5d
Make sure that the encrypted version is set
...
The code path called when using external storage with WebDAV is using `\OC\Files\Storage\Wrapper\Encryption::getMetaData` which did not contain the actual encrypted version inside the cache entry version. This lead to the following:
1. User uploaded a file
2. File is created and `\OC\Files\Storage\Wrapper\Encryption::getMetaData` is called. It has an empty `encryptedVersion` but sets `encrypted` to either `true` or `false`.
3. The call when updating the file cache will use the old version.
2016-03-31 18:06:37 +02:00
8da48a4482
Add unit tests
...
Add some unit tests for setting the internal id and the provider id
2016-03-30 23:08:35 +02:00
2f4294e781
Add setId and setProviderID to the public interface
...
Fixes #23337
We only allow the id to be set once!
2016-03-30 22:55:03 +02:00
66ee9d56fc
Merge pull request #23628 from owncloud/avatar-remove
...
only remove avatars from the folder we store them in
2016-03-30 17:00:09 +02:00
9ce5e4b01f
Non moveable mount points should always be UPDATE+DELETE shareable
...
Fixes #23536
The new sharing code is much stricter in checking permissions. However
for non moveable mounts the permissions UPDATE+DELETE are not reported
on the mount point.
This is just a quick fix.
* Updated unit tests
2016-03-30 13:33:16 +02:00
c22697e09e
only remove avatars from the folder we store them in
2016-03-30 10:24:43 +02:00
b8812c8cba
Merge pull request #23154 from owncloud/avatar-save-failure
...
dont die when we cant save the resized avatar, log instead
2016-03-24 22:43:17 +01:00
ea07a428f4
Merge pull request #22506 from owncloud/node-get-from-cache
...
Query the cache when checking if a node exists
2016-03-23 13:08:17 +01:00
fc18d33ff8
Merge pull request #22895 from owncloud/cleanup_default_share_provider
...
Remove support for old shares in the default share provider
2016-03-23 11:02:28 +01:00
efd378814c
Merge pull request #23362 from owncloud/fix-l10n-for-themes
...
Read available l10n files also from theme folder
2016-03-23 09:22:21 +01:00
b26b8d17eb
Remove support for old shares in the default share provider
...
In 9.0 we converted the old shares to the new shares. So for 9.1 we can
savely remove the fallback code.
This code was required when there was no initiator set.
* Fixed unit tests
2016-03-23 07:58:17 +01:00
52826d0e24
Block group sharing in API and in share manager
...
* Fix tests
2016-03-22 17:13:34 +01:00
dcca20a48a
Save the query when we get tags for no objects
2016-03-22 11:13:11 +01:00
0b0b3253bb
properly use fileinfo objects
2016-03-21 14:20:33 +01:00
5e6c905a14
pass the fileinfo to the node if available
2016-03-21 13:53:33 +01:00
76455204c0
Inject server root - allows proper testing and separation of concerns
2016-03-18 13:59:44 +01:00
5e267589d4
only create and update user specific key if no master key is enabled
2016-03-18 11:06:14 +01:00
23c0f4ff5f
Read available l10n files also from theme folder
...
The old behaviour was that only languages could be used for an app
that are already present in the apps/$app/l10n folder. If there is
a themed l10n that is not present in the apps default l10n folder
the language could not be used and the texts are not translated.
With this change this is possible and also the l10n files are
loaded even if the default l10n doesn't contain the l10n file.
2016-03-17 16:15:37 +01:00
676041ba7e
Ensure that stored version is at least 1 for cross-storage copy
...
In case of a move operation from an unencrypted to an encrypted
storage the old encrypted version would stay with "0" while the
correct value would be "1". Thus we manually set the value to "1"
for those cases.
See also https://github.com/owncloud/core/issues/23078
2016-03-16 10:36:15 +01:00
f7140294f2
Merge pull request #23157 from owncloud/remove-share-prop-entries
...
remove old share propagation entries from appconfig
2016-03-15 16:04:17 +01:00
27760ae54e
Merge pull request #23164 from owncloud/db-connection-precondition-fix
...
Prevent certain DBs throwing exceptions on same-value updates
2016-03-15 16:03:55 +01:00
7b06dd485d
Merge pull request #23250 from owncloud/fix-support-for-php7-in-htaccess
...
Fix several .htaccess and .user.ini related problems
2016-03-15 16:03:18 +01:00
1b2f1cc272
Prevent certain DBs throwing exceptions on same-value updates
...
A PreconditionNotMetException must only be thrown if explicit
preconditions are specified for setValues(), not if the value is merely
the same as was already in the DB.
2016-03-15 13:02:19 +01:00
0aa83511a1
remove old share propagation entries from appconfig
2016-03-15 12:50:22 +01:00
1db82073a4
Generate a valid URL for link notification
...
fixes #23197
* Updated unit test
2016-03-15 11:10:24 +01:00
5278bfe0e4
Add support for custom values in integrity checker
2016-03-15 10:41:17 +01:00
2f67aa9bc4
Fix errors in memcached implementation
2016-03-14 12:39:34 +01:00
54e750ba78
dont die when we cant save the resized avatar, log instead
2016-03-11 13:44:35 +01:00
dc6789fd5b
Explicitly check for port
...
The setup uses `\OCP\IRequest::getInsecureServerHost` which in some cases can also include a port. This makes the trusted domain check fail thus.
I've decided to add this here that way because adjusting the setup would require parsing the host properly. This is not something that can be done very good in PHP. Check the following example for why `parse_url` is not our friend: https://3v4l.org/k501Z
2016-03-10 22:32:29 +01:00
7301b43eb6
Added tests
...
* Unit tests for OC_Filechunking to verify the isComplete function
* Intergration tests to show that shuffling chunks is all fine
2016-03-07 21:20:13 +01:00
72c8187cbb
Keep "encryptedVersion" when calling `\OC\Files\View::copy`
...
When calling `\OC\Files\View::copy` we should also keep the version to ensure that the file will always have the correct version attached and can be successfully decrypted.
To test this the following steps are necessary (from https://github.com/owncloud/core/issues/22781#issuecomment-191328982 ):
1. setup a new ownCloud 9.0 beta2
2. enable encryption
2. upload a docx (5.7MB large)
3. upload the same file again and overwrite the existing file
4. I can download the original file and the first version
5. I restore the first version
6. restored version can no longer be downloaded with the error described above
The manual cache operation in `\OCA\Files_Versions\Storage` is unfortunately necessary since `\OCA\Files_Versions\Storage::copyFileContents` is not using `\OCP\Files\Storage::moveFromStorage` in the case when an object storage is used. Due to the workaround added in 54cea05271
2016-03-03 14:15:36 +01:00
2a0cda74d4
Use IQueryBuilder::PARAM_* instead of \PDO::PARAM_*
2016-02-29 09:44:40 +01:00
6526c122af
Merge pull request #22683 from owncloud/fix_22682
...
Relax rootfolder check
2016-02-29 08:53:58 +01:00
b116e80c56
Relax rootfolder check
...
* Updated unit tests
* Added intergration test
2016-02-26 16:05:32 +01:00
bfcdf40a64
Expiration date can only be enforced if default is enabled
...
If the default expiration date is not enebaled it can not be enforced.
* Added unit tests
2016-02-26 11:38:06 +01:00
62d7885c3b
Merge pull request #22660 from owncloud/fix_22656
...
Do not allow sharing of the users root folder
2016-02-26 10:49:12 +01:00
0795cc373d
Merge pull request #22646 from owncloud/fix_22642
...
Set default expiration date if none given on share creation
2016-02-26 10:48:21 +01:00
cbde4bb92f
Merge pull request #22650 from owncloud/fix_hook
...
Fix verifyExpirationDate passwordSet argument
2016-02-26 09:32:41 +01:00
8213d5df4f
Do not allow sharing of the root folder
...
Sharing of the users root folder should not be allowed as it is very
weird UX. Also many of our clients have no proper way of displaying
this.
Added unit test
Also added intergration tests to make sure we won't allow it in the
future.
2016-02-25 20:40:30 +01:00
9412f69104
Fix verifyExpirationDate passwordSet argument
...
Password set should be false if the password is null.
Also updated the unit tests to tests this now.
2016-02-25 15:39:02 +01:00
efc966698f
Merge pull request #22579 from owncloud/fix_broken_unencrypted_size
...
Heal unencrypted file sizes at download time (second approach)
2016-02-25 14:34:48 +01:00
6d4f80d680
Set default expiration date if none given on share creation
...
When we create a share for the first time we should set the default
expiration date. If none is given.
Fixes #22642
2016-02-25 14:21:46 +01:00
2ec1c738d0
Merge pull request #22573 from owncloud/issue-22568-allow-string-object-ids
...
Make sure we can store strings as per the interface
2016-02-24 12:15:23 +01:00
834b51b83b
recalculate unencrypted size if we assume that the size stored in the db is not correct
2016-02-23 15:09:46 +01:00
fb8b34bdd0
Allow defining a limit and offset for getObjectIdsForTags
2016-02-23 09:04:15 +01:00
24c7f38a00
Make sure we can store strings as per the interface
2016-02-22 15:43:20 +01:00
f8677628d4
Merge pull request #22503 from owncloud/issue_22500
...
When (re-)sharing an incomming federated share set the corrent owner
2016-02-19 16:07:43 +01:00
b5281b61ed
Merge pull request #22410 from owncloud/fix_22119
...
Do not copy skeleton on avatar access
2016-02-19 16:06:40 +01:00
2dcf887cce
When (re-)sharing an incomming federated share set the corrent owner
...
Incomming federated shares are a special kind. We mount them as normal
webdav shares but we do supply owner info with the federated cloud id of
the share owner.
Since we do not yet have the new resharing behaviour on federated shares
we need to set the correct owner. Which will allow sharing and proper
mounting for other users.
fixes #22500
2016-02-19 12:43:03 +01:00
ec6e8c1ab6
fix unit test
2016-02-18 12:39:19 +01:00
c6fef52939
Merge pull request #22416 from owncloud/fix_22402
...
Return proper error string if sharing for this user is disabled
2016-02-16 13:37:22 +01:00
d5226c88ac
Merge pull request #22338 from owncloud/fix_22247
...
Allow more characters in filenames
2016-02-16 13:37:07 +01:00
ed6843e87b
Return proper error string if sharing for this user is disabled
...
Fixes #22402
2016-02-16 10:22:49 +01:00
47d28155a8
Do not copy skeleton on avatar access
...
Fixes #22119
Just try to get the folder of the user. If it is not there a
NotFoundException will be thrown. Which will be handled by the avatar
endpoint.
2016-02-16 09:18:38 +01:00
7048d428b1
Remove unneeded parameter from OC_App::getEnabledApps
2016-02-15 13:33:07 +01:00
248c571c56
Merge pull request #22331 from owncloud/dav-nonexisting-part
...
fix getNodeForPath for non existing part files
2016-02-13 18:24:00 +01:00
207c09c511
Merge pull request #22309 from owncloud/infinite-recursion-on-expired-link
...
Do not getShare in deleteShare, it's already there when deleting
2016-02-12 11:11:26 +01:00
e99c4d83dc
Merge pull request #22317 from owncloud/fix_invisible_linkshares
...
Do not allow invisible link shares
2016-02-12 11:10:58 +01:00
759b19775d
Fix unit tests
2016-02-12 07:49:36 +01:00
c3e4ced64a
fix getNodeForPath for non existing part files
2016-02-11 17:22:40 +01:00
4533cb9c59
Add parent for invisible link shares
2016-02-11 13:29:23 +01:00
8cfdc62eae
Update info checker requirements
2016-02-11 11:54:13 +01:00
2aa206e900
Fix unit tests
2016-02-11 11:21:12 +01:00
9bb97c714b
fixing unit tests
2016-02-09 23:43:26 +01:00
29f6f451a9
Merge pull request #22192 from owncloud/fix_19685
...
Only set the default expiration date on share creation
2016-02-09 23:38:00 +01:00
2982017682
Merge pull request #22228 from owncloud/comments-limit-message
...
Limit comment message to 1k chars
2016-02-09 16:35:23 +01:00
ee65cd0bd8
Only set the default expiration date on share creation
...
Fixes #19685
The default expiration date should only be set when we create a new
share. So if a share is created and the expiration date is unset. And
after that the password is updated the expiration date should remain
unset.
2016-02-09 11:05:14 +01:00
347ad3e223
Limit comment message to 1k chars
2016-02-09 03:14:30 +01:00
cd00751de5
Send events when enabling and disabling of apps
2016-02-09 02:51:12 +01:00
fad85ad19f
Fix unit tests
2016-02-08 11:30:48 +01:00
8486d61764
getSharesBy should also expire link shares
2016-02-06 13:31:54 +01:00
3028ec5440
Delete expired share when fetched by id
2016-02-06 13:31:54 +01:00
5ed56d9edb
Delete a link share if it is expired on access
...
If we access a link share we should check if it has expired already.
If so we should remove it and throw a ShareNotFound exception
2016-02-06 13:31:54 +01:00
5832178f59
Merge pull request #22139 from owncloud/comments-files-cleanup
...
cleanup jobs for comments and comment read marks
2016-02-06 13:26:00 +01:00
065141f6f4
Move casting to IExpressionBuilder
2016-02-05 21:26:30 +01:00
fb76d7de69
remove unused Storage->getLocalFolder
2016-02-05 16:48:08 +01:00
169874957a
Path should be relative
2016-02-04 19:19:10 +01:00
b57aac0a89
[Share 2.0] Add missing post_update_permissions hook
2016-02-04 19:18:25 +01:00
d8faeab421
Merge pull request #21766 from farukuzun/master
...
Add some mimetypes
2016-02-04 16:49:31 +01:00
1619968a03
Merge pull request #22111 from owncloud/use-intermediate-certificate
...
Use intermediate root authority + sign other release channels
2016-02-04 16:17:47 +01:00
0f22a8db1d
Also add type (file/folder) to IShare object
...
We need this for the hooks :(
2016-02-04 14:28:09 +01:00
2c0cb5a00e
Unit test for delete lazy shares
2016-02-04 13:30:42 +01:00
e0bc128eb5
Add unit tests
2016-02-04 13:05:05 +01:00
fc215d0980
Make the share object lazy
...
Share providers can now just pass in a fileId. And the node will only be
created once needed.
2016-02-04 12:51:23 +01:00
6ffd8f3e0d
Introduce some mimetypes for richdocuments
...
* application/vnd.lotus-wordpro
* application/vnd.visio
* application/vnd.wordperfect
* application/msonenote
2016-02-04 13:48:21 +02:00
b594aa18ee
Merge pull request #22110 from owncloud/comment-types-always-plural
...
types shall always be plural
2016-02-04 10:55:49 +01:00
5f300ac275
Allow specifing the signing path
2016-02-03 20:08:40 +01:00
9370491822
types shall always be plural
2016-02-03 19:28:15 +01:00
96662c4d0d
[Share 2.0] Fix shareManager
2016-02-03 19:25:29 +01:00
eb904c7aa9
[Share 2.0] Fix defaultshare provider
2016-02-03 19:25:29 +01:00
74abbbc0d6
Merge pull request #22098 from owncloud/cleanup-core-apps
...
Cleanup core apps
2016-02-03 14:17:10 +01:00
599eb141b4
Make sure tests don't leave a stray directory behind
2016-02-03 12:57:22 +01:00
dc32f49c6e
[Share 2.0] Use GenericShareException
2016-02-02 14:23:45 +01:00
4d7130ad31
[Share 2.0] Add exceptions to OCP
2016-02-02 14:07:11 +01:00
ce053b9808
Merge pull request #22013 from owncloud/share2_moveshare
...
[Share 2.0] Allow moving of shares
2016-02-02 13:34:50 +01:00
2d1d89ee29
Merge pull request #22049 from owncloud/issue-22041-activities-for-systemtags
...
Issue 22041 activities for systemtags
2016-02-02 13:08:01 +01:00
eee6f3d406
Merge pull request #22057 from owncloud/share2_update_hash
...
Update old password hashed for link shares on access
2016-02-02 12:37:31 +01:00
c9006d6d56
Merge pull request #21988 from owncloud/allow-search-in-synced-addressbooks
...
Allow search in synced addressbooks
2016-02-02 12:37:12 +01:00
2316cb1f8b
[Share 2.0] Allow moving of shares
...
* Only recipient can move a share
* Unit tests
2016-02-02 11:34:52 +01:00
b01d50216e
The local address book is replaced now by the system addressbook as part of the dav app
2016-02-02 10:56:33 +01:00
403547f0ea
[Share 2.0] Allow recipient to be passed in to getShareById
...
* This allows us to retrieve usergroup shares for a given id.
If the user deleted a share or moved it this will be a different share
2016-02-02 10:41:57 +01:00
d5126b1ad4
Dispatch events when tags are added/updated/deleted
2016-02-02 09:57:42 +01:00
591613fce2
Dispatch some events when tags are un-/assigned
2016-02-02 09:57:42 +01:00
619a4d2e52
Update old password hashed for link shares on access
...
Fixes https://github.com/owncloud/core/issues/16594
2016-02-01 21:46:32 +01:00
b4853f3fce
Merge pull request #21967 from owncloud/comments-webdav
...
Comments WebDAV adjustements
2016-02-01 16:17:45 +01:00
84d9704121
Merge pull request #22028 from owncloud/share_hook_expirationdate
...
Share hook expirationdate
2016-02-01 14:13:54 +01:00
32067ac49b
Merge pull request #21989 from owncloud/make-csp-modifiable
...
Add public API to give developers the possibility to adjust the global CSP defaults
2016-02-01 10:10:40 +01:00
a025b2865f
Merge pull request #22022 from owncloud/share_ocs_filter_path_sharedwithme
...
Add path filter to OCS Share API shared_with_me=true
2016-02-01 09:00:31 +01:00
d3e79f3bb6
Add Unit tests
2016-01-30 15:40:35 +01:00
67bf225fbe
Merge pull request #21956 from owncloud/cross-cache-move
...
Add fallback moveFromCache implementation
2016-01-29 17:03:16 +01:00
a24e7f6558
Add path filter to OCS Share API ?shared_with_me=true
...
This allows all clients to quickly get the share info for a given path.
Instead of returning everything and filtering it then manually on the
client side.
2016-01-29 15:36:23 +01:00
01cdc70f9c
introduce comments read marke tables, comes with user cleanup after deletion
2016-01-29 13:08:02 +01:00
d2882b9021
Comments WebDAV adjustements
2016-01-29 13:08:02 +01:00
ec3f6549f6
Add fallback moveFromCache implementation
2016-01-29 13:06:59 +01:00
1ff4ec1cd3
[Share 2.0] When deleting a group share delete children
...
For group shares we can have children. Those are custom shares when a
user has moved or deleted a group share. Those also have to be deleted
if the group share is removed.
2016-01-28 20:35:46 +01:00
809ff5ac95
Add public API to give developers the possibility to adjust the global CSP defaults
...
Allows to inject something into the default content policy. This is for
example useful when you're injecting Javascript code into a view belonging
to another controller and cannot modify its Content-Security-Policy itself.
Note that the adjustment is only applied to applications that use AppFramework
controllers.
To use this from your `app.php` use `\OC::$server->getContentSecurityPolicyManager()->addDefaultPolicy($policy)`,
$policy has to be of type `\OCP\AppFramework\Http\ContentSecurityPolicy`.
To test this add something like the following into an `app.php` of any enabled app:
```
$manager = \OC::$server->getContentSecurityPolicyManager();
$policy = new \OCP\AppFramework\Http\ContentSecurityPolicy(false);
$policy->addAllowedFrameDomain('asdf');
$policy->addAllowedScriptDomain('yolo.com');
$policy->allowInlineScript(false);
$manager->addDefaultPolicy($policy);
$policy = new \OCP\AppFramework\Http\ContentSecurityPolicy(false);
$policy->addAllowedFontDomain('yolo.com');
$manager->addDefaultPolicy($policy);
$policy = new \OCP\AppFramework\Http\ContentSecurityPolicy(false);
$policy->addAllowedFrameDomain('banana.com');
$manager->addDefaultPolicy($policy);
```
If you now open the files app the policy should be:
```
Content-Security-Policy:default-src 'none';script-src yolo.com 'self' 'unsafe-eval';style-src 'self' 'unsafe-inline';img-src 'self' data: blob:;font-src yolo.com 'self';connect-src 'self';media-src 'self';frame-src asdf banana.com 'self'
```
2016-01-28 18:36:46 +01:00
b7710ab6d7
Merge pull request #21858 from owncloud/getMountsForFileId
...
add IUserMountCache->getMountsForFileId
2016-01-28 11:20:42 +01:00
34e912ab6b
[Share 2.0] Fix interfaces and comments
...
* Made comments more clear
* Removed unneeded methods
* IShares shareTime is now a proper DateTime object
* IShares getPath -> getNode & setPath -> setNode
* Fix unit tests
2016-01-28 07:54:09 +01:00
f2e70441e4
[Share 2.0] Add getShareManager to OCP\IServerContainer
2016-01-27 22:04:37 +01:00
185b9c6edd
[Share 2.0] Move IShare to OCP
2016-01-27 22:04:37 +01:00
0832cca54e
[Share 2.0] Fix IShare
2016-01-27 22:04:09 +01:00
cb1a64b949
Check whether ownCloud is installed
...
ownCloud might not yet be setup. This causes an issue as the user config requires a setup ownCloud. Thus this needs a block whether ownCloud is installed or not.
Fixes https://github.com/owncloud/core/issues/21955
2016-01-27 18:30:18 +01:00
6973718fb8
Merge pull request #21940 from owncloud/share2_do_not_returned_removed_group_shares
...
[Share 2.0] Properly handle user deleted group shares
2016-01-27 16:16:06 +01:00
2563c3ffaf
Fix failing oracle and postgres tests
2016-01-27 12:53:44 +01:00
644a8ab797
add IUserMountCache->getMountsForFileId
2016-01-27 12:53:44 +01:00
1594371c8c
Merge pull request #21741 from owncloud/l10n-improvements
...
Move methods to the factory that are not related to translating, but to guessing/finding the language
2016-01-27 09:37:00 +01:00
5b7a1b13f3
Merge pull request #21887 from owncloud/share2_updateShare
...
[Sharing 2.0] update share
2016-01-27 09:36:41 +01:00
c274f03e12
Merge pull request #21906 from owncloud/querybuilder-clob-comparison
...
Querybuilder clob comparison
2016-01-27 09:36:21 +01:00
a4900d721f
[Share 2.0] Properly handle user deleted group shares
...
If a user deletes a group share we create a special share entry. To the
API this is just a normal group share for that user with permissions 0.
But we should not return this.
2016-01-27 09:02:12 +01:00
d11682dcb4
Fix comments from Thomas
2016-01-26 15:31:52 +01:00
7514695399
Fix Oracle comparisons
2016-01-26 14:56:07 +01:00
bd444ae3c3
Add tests for clob comparisons
2016-01-26 14:56:07 +01:00
c090d709e7
We must resolve to the proper usergroup share
2016-01-26 14:14:54 +01:00
f413b3ff3a
Add tests for findAvailableLanguages
2016-01-26 14:02:32 +01:00
70396581eb
Add tests for findLanguage()
2016-01-26 14:02:32 +01:00
fe411788b7
Remove tests for wrapper
2016-01-26 14:02:31 +01:00
b24b198a83
Add tests for the factory
2016-01-26 14:02:31 +01:00
8f9cc51559
Add tests for the new l10n class
2016-01-26 14:02:31 +01:00
1199619518
Move legacy test file to new location
2016-01-26 14:02:31 +01:00
2cb26a9151
Fix the tests
2016-01-26 14:02:31 +01:00
043625ee52
Move findLanguage() and setLanguageFromRequest() to factory
2016-01-26 14:02:31 +01:00
44c073b1e6
[share 2.0] manager unit tests
2016-01-26 13:59:58 +01:00
59c2aae54f
[Share 2.0] Fix unit tests
2016-01-26 13:59:58 +01:00
7239fea0f0
[Share 2.0] Add unit test for the default share provider
2016-01-26 13:59:58 +01:00
5285460669
Merge pull request #21845 from owncloud/sync-system-addressbook-on-avatar-change
...
Changing the avatar of the user emits the changeUser event which trig…
2016-01-26 11:37:17 +01:00
2bafb1c649
Merge pull request #21894 from owncloud/refactor-csrf
...
Add new CSRF manager for unit testing purposes
2016-01-26 11:36:56 +01:00
a1ca9de0f5
Trigger change on avatar delete
2016-01-25 20:56:04 +01:00
68ef6e1bdd
Assert that User::triggerChange is called upon avatar change
2016-01-25 20:05:11 +01:00
f165ad8864
Changing the avatar of the user emits the changeUser event which triggers update of the system addressbook
2016-01-25 20:05:11 +01:00
a977465af5
Add new CSRF manager for unit testing purposes
...
This adds a new CSRF manager for unit testing purposes, it's interface is based upon https://github.com/symfony/security-csrf . Due to some of our required custom changes it is however not possible to use the Symfony component directly.
2016-01-25 20:03:40 +01:00
728caf13f8
Adding support of -1 as size to be passed into get and getFile
2016-01-25 16:54:40 +01:00
99e9c81c8b
Merge pull request #21841 from owncloud/share2_deletefromself
...
[Share 2.0] Add deleteFromSelf method
2016-01-22 17:27:17 +01:00
7731b29136
Merge pull request #21719 from owncloud/move-notification-api-to-ocp
...
Move the notification API to public namespace
2016-01-22 16:20:26 +01:00
a6600e95dc
[Share 2.0] Add deleteFromSelf method
...
This allows recipient to delete a share. For user shares this is the
same as deleting (at least for now).
But for group shares this means creating a new share with type 2. With
permissions set to 0.
2016-01-22 15:06:50 +01:00
9b4c9a0357
Merge pull request #18531 from owncloud/ext-user-credentials
...
External storage 'Login credentials' auth mechanism
2016-01-22 13:14:14 +01:00
0bccdbc959
Merge pull request #21849 from owncloud/add-custom-marker-into-htaccess
...
Add custom marker into htaccess and execute integrity check after installation
2016-01-22 13:13:59 +01:00
e3013a99ef
Merge pull request #21816 from owncloud/require-a-specific-path-instead-of-autoguessing
...
Use path instead of app id for occ app signing
2016-01-22 13:13:41 +01:00
bc62aa1ef5
Exclude .htaccess modifications from code checker
...
After the initial installation ownCloud will write some content into the .htaccess file such as the 404 or 403 directives. This adds a magic marker into the .htaccess file and only the content above this marker will be compared in the integrity checker.
2016-01-22 11:51:54 +01:00
1410120758
Merge pull request #20768 from owncloud/mount-cache
...
cache mountpoints in the db
2016-01-22 11:01:54 +01:00
ee02165005
Move the notification API to public namespace
2016-01-22 10:32:42 +01:00
e2e5eedb40
Merge pull request #21824 from owncloud/list-of-notifiers
...
Make it possible to get a list of notifiers for a potential settings …
2016-01-22 10:24:46 +01:00
3cca8498cb
Make it possible to get a list of notifiers for a potential settings page
2016-01-22 08:47:21 +01:00
9b5ea18ce5
Add Unit tests for the default share provider
2016-01-21 16:06:12 +01:00
e2f231d051
Merge pull request #21761 from owncloud/share2_link
...
Share2 link
2016-01-21 15:43:08 +01:00
7c7467fe42
Merge pull request #21792 from owncloud/systemtags-managerfactory
...
Allow custom implementation of system tag managers
2016-01-21 12:13:01 +01:00
88bc8634d2
Add Unit tests
2016-01-20 21:56:55 +01:00
ea367b598a
Use path instead of app id
...
This change requires the usage of a path instead of the App ID when signing code. This has the advantage that developers can also sign code under a different location to make it easier. (e.g. remove `.git`, …)
Also it adds an example command usage as well as a link to the documentation
2016-01-20 20:38:18 +01:00
899f9bd113
Allow custom implementation of system tag managers
...
Added config.php option to replace the default implementation of system
tag manager and system tag object mapper.
Also adjusted the comments manager factory to inject the server container
2016-01-20 16:36:10 +01:00
99415a9f7f
multiple minor fies
2016-01-20 16:32:52 +01:00
222e719c87
sort in tests
2016-01-20 16:30:22 +01:00
8940429976
log duplicates
2016-01-20 16:30:22 +01:00
cf6ee1c866
cache mountpoints in the db
2016-01-20 16:30:22 +01:00
aeb89947a2
Introduce IUser::setEMailAddress and add hook mechanism
2016-01-20 14:57:20 +01:00
7a946a05f5
Properly DI the servercontainer
2016-01-20 08:33:36 +01:00
930555bd5e
properly use standard
...
* JEDEC standard - https://en.wikipedia.org/wiki/JEDEC_memory_standards#Unit_prefixes_for_semiconductor_storage_capacity
2016-01-19 10:41:12 +01:00
14c98b4df7
Merge pull request #21519 from owncloud/propagate-folder-size
...
propagate folder size in the same query for write updates
2016-01-18 16:57:30 +01:00
7ba715d144
fix test
2016-01-18 12:08:58 +01:00
da4127d23b
Introduce CredentialsManager for storage of credentials in DB
...
CredentialsManager performs a simple role, of storing and retrieving
encrypted credentials from the database. Credentials are stored by user
ID (which may be null) and credentials identifier. Credentials
themselves may be of any type that can be JSON encoded.
The rationale behind this is to avoid further (mis)use of
oc_preferences, which was being used for all manner of data not related
to user preferences.
2016-01-18 11:10:41 +01:00
88cd615214
Introduce IDBConnection::setValues()
...
setValues() attempts to insert a new row, or failing that, update an
existing row. The ability to set preconditions is also available.
2016-01-18 11:10:41 +01:00
807cf750b3
Merge pull request #21705 from owncloud/improve-background-job-message
...
Improve background job error message
2016-01-15 20:12:26 +01:00
ddbbe1742f
propagate folder size in the same query for write updates
2016-01-15 15:36:52 +01:00
f6c4b10189
Add message key to context of logException
2016-01-15 14:55:30 +01:00
b37634a57d
Merge pull request #21721 from owncloud/capped-memcache-indirect-set
...
Allow indirect set in CappedMemoryCache
2016-01-15 12:37:36 +01:00
d8867f7692
Merge pull request #21723 from owncloud/prevent-group-enable-for-apps
...
Prevent group enable for apps
2016-01-15 12:26:43 +01:00
52040a3f23
Merge pull request #20898 from owncloud/cache-interfaces
...
Public Cache interfaces
2016-01-15 12:02:31 +01:00
e3a0858444
Check whether the app can be enabled for groups
2016-01-14 15:45:48 +01:00
d195584a32
Allow indirect set in CappedMemoryCache
2016-01-14 15:00:41 +01:00
d2c579e167
fix quota wrapper
2016-01-14 12:54:42 +01:00
62d383e1ba
fix tests
2016-01-14 12:54:42 +01:00
0f454ff5aa
Use namedparameter
2016-01-14 10:54:40 +01:00
86f08f59d6
use logException() to properly log the exception
2016-01-14 10:40:23 +01:00
64c8427d81
Improved error message for failing background job
2016-01-14 09:49:40 +01:00
4cc2230c58
[Share 2.0] Fix pre_share and post_share hooks
2016-01-13 21:56:04 +01:00
5f5951c8cf
[Share 2.0] Let the factory do the factory stuff
...
* Updated unit tests (bit cleaner now)
2016-01-13 16:35:15 +01:00
cbd3050f4c
[Share 2.0] Use full share id (providerId:shareId)
...
Now that we support multiple managers we communicate shares to the
outside as 'providerId:shareId'. This makes sures that id's are unique
when references from the OCS API.
However, since we do not want to break the OCS API v1 we need to
somewhat hack around this.
When we switch to OCS API v2 (which we should when we support more
custom providers). We will change the id to always be the fullShareId.
2016-01-13 16:35:15 +01:00
67b7ebccd1
[Share 2.0] Add share provider factory
...
* Add providers
* Add share manager to server container
* Use share manager from server container
* Properly get the share manager
2016-01-13 16:35:14 +01:00
b4de427c1e
[Share 2.0] Allow registering of share providers
...
* Properly register the default share provider
2016-01-13 16:35:07 +01:00
3ee3d02a76
Merge pull request #20018 from owncloud/cache_group_backend
...
The group database backend should cache groups
2016-01-13 15:58:21 +01:00
0c65f4b2c6
Fix unit test
...
No idea why they passed locally before as well on the branch on the PR. Scary...
2016-01-13 11:22:44 +01:00
37e8a87d46
Merge pull request #21591 from owncloud/add-code-checking-for-apps
...
Verify signature of apps with level "Official" coming from the appstore
2016-01-13 10:35:00 +01:00
5565b19382
Merge pull request #21648 from owncloud/smb-statcache-cap
...
cap the number of entries we cache in smb's statcache
2016-01-13 10:33:43 +01:00
08e73d2c8f
Add hidden config switch to disable code integrity checking
...
This adds a hidden config flag that allows somebody to disable the code integrity check. If `integrity.check.disabled` is set to `true` in the config file:
1. The integrity check functions will return always an empty result
2. The integrity check is not performed when installing apps
3. The integrity check is not performed when updating apps
4. The integrity check is not performed when updating the core
Furthermore this adds support for a list of channels that the code checker will run on. At the moment this is only stable because I didn't want to break any build scripts that we have. Once we have a proper CA setup and updated the build process to sign the releases we can add the RC, alpha, beta as well as daily releases. So everything except "git" basically.
2016-01-12 18:48:36 +01:00
d8d6368dd7
cap the number of entries we cache in smb's statcache
2016-01-12 13:26:58 +01:00
c15cab7ed6
Allow admins to add system wide root certificates
2016-01-12 12:50:59 +01:00
3ec8789c77
Merge pull request #21628 from owncloud/deprecated_secure_random_funcions
...
Replace deprecated function calls to SecureRandom
2016-01-12 09:12:13 +01:00
3c8f4784e9
Inject DBConnection
...
* Use query builder
* Minor unit tests additions
2016-01-12 08:24:08 +01:00
07fd3889b1
Fix unit tests
2016-01-11 20:29:48 +01:00
876fb83ddc
getMediumStrengthGenerator is deprecated and does not do anything anymore
2016-01-11 20:06:30 +01:00
98c4951f45
getLowStrengthGenerator does not do anything anymore
2016-01-11 19:59:15 +01:00
eccd9ca1cb
Remove unused deprecated function
2016-01-11 16:41:46 +01:00
e01a488b31
Remove generateRandomBytes from OC_Util
2016-01-10 22:07:33 +01:00
c009d5dcc1
Verify signature of apps with level "Official" coming from the appstore
...
This change will verify the signature of all apps with the level "Official" coming from the appstore or if they have been signed before.
2016-01-10 19:40:28 +01:00
a1a8a06042
Merge pull request #21527 from owncloud/remove_all_avatars
...
Remove all cache avatars on avatar deletion
2016-01-08 09:41:25 +01:00
4e6f6518ff
Remove all cache avatars on avatar deletion
...
Fixes #21513
Since we cache the generated avatars. We should also delete the
generated sizes when we remove the avatar.
2016-01-07 20:51:18 +01:00
1cc6fddead
Merge pull request #21498 from owncloud/cleanup-OC_DB
...
Cleanup OC_DB methods
2016-01-07 20:13:16 +01:00
f6f492ba4e
Merge pull request #21502 from owncloud/di_mimetypedetector
...
Add 'OCP\Files\IMimeTypeDetector' to DI container
2016-01-07 16:18:55 +01:00
9ca670f94f
Merge pull request #21505 from owncloud/allow-downgrades-for-brave-developers
...
Allow downgrades for our brave developers, that switch between branches
2016-01-07 16:03:36 +01:00
601457d221
Merge pull request #20773 from owncloud/share2.0_create
...
[Sharing 2.0] create share
2016-01-07 14:57:05 +01:00
190cc2bb67
Remove OC_DB::getConnection
2016-01-07 14:54:55 +01:00
fddece9552
Remove OC_DB::insertid
2016-01-07 14:54:55 +01:00
547fbfdb76
Remove OC_DB::dropTable
2016-01-07 14:54:54 +01:00
fd7ed93937
Allow downgrades for our brave developers, that switch between branches
2016-01-07 14:18:33 +01:00
cd35ad6aaa
Add 'OCP\Files\IMimeTypeDetector' to DI container
...
* Added test to server container as well
2016-01-07 13:20:43 +01:00
604897945b
Move lib/repair to lib/private/repair
2016-01-07 09:14:35 +01:00
1358e5dcd9
[Sharing 2.0] Some error cases report 404 instead of 403
2016-01-06 15:25:29 +01:00
26280e1f19
[Sharing 2.0] Add L10N instance to manager for translated errors
2016-01-06 14:53:43 +01:00
b15be8f96f
[Share 2.0] Make the share manager ready for share creation
2016-01-06 14:53:43 +01:00
a08c497808
[Share 2.0] Make share provider ready for create shares
2016-01-06 14:53:43 +01:00
836e96a95e
Assign DB group for unit tests
2016-01-04 15:09:01 +01:00
fec41e7539
Move regeneration of session ID into session classes
...
There were code paths that nowadays call ISession::login directly thus bypassing the desired regeneration of the session ID. This moves the session regeneration deeper into the session handling and thus ensures that it is always called. Furthermore, I also added the session regeneration to the remember me cookie plus added some test case expectations for this.
2016-01-04 15:09:01 +01:00
24271cf953
Merge pull request #21216 from owncloud/fopen-statcache
...
Clear SMB statcache after fopen
2015-12-28 10:21:26 +01:00
b2df7b6b8a
Fix unit test
2015-12-24 09:20:26 +01:00
23c754aed3
prefer scalar type hints over phpdoc annotation
...
use method exists lookup to be safe and not break on old hhvm versions
add test that checks if type hint is preferred over annotation
2015-12-24 09:20:26 +01:00
d7169ffdec
Restore DB connection after failure
...
In case of failure, PHPUnit seems to skip `tearDown`, so any useful
assertion messages cannot be shown because `tearDownAfterClass` is
throwing an error because of database usage.
This commit makes sure we also restore the database in
`tearDownAfterClass` to prevent the data root restoration to fail
2015-12-21 18:14:29 +01:00
0b913f00c7
Merge pull request #21289 from owncloud/issue-20399-keep-periodic-background-jobs
...
Do not delete background jobs, in case an exception occured
2015-12-21 09:47:07 +01:00
6cdaf754b2
Merge pull request #21290 from owncloud/public-api-usage-getversion
...
Use OCP\Util::getVersion instead of the internal private implementation
2015-12-18 16:07:01 +01:00
ed98cdf532
Use OCP\Util::getVersion instead of the internal private implementation
2015-12-18 15:26:54 +01:00
36cc0528e3
Merge pull request #21288 from owncloud/deprecated_helper_mimetypes
...
Remove deprecated OC_Helper mimetype functions
2015-12-18 15:23:05 +01:00
54558bb5b2
Fix the test to expect the new behaviour
2015-12-18 15:05:32 +01:00
a743047e82
Merge pull request #21283 from owncloud/cleanup_config
...
Cleanup OC_Config mess
2015-12-18 14:54:38 +01:00
50e8773307
Merge pull request #21280 from owncloud/drop-unused-methods
...
OC_Helper::makeURLAbsolute is not used anymore
2015-12-18 14:49:55 +01:00
22d1b1285e
Merge pull request #21277 from owncloud/querybuild-joblist
...
Use the query builder for the joblist queries
2015-12-18 13:44:02 +01:00
a54be132fc
Removed deprecated unsused function OC_Helper::getStringMimeType
2015-12-18 13:43:44 +01:00
4f20e3bac0
Removed deprecated OC_Helper::getSecureMimeType
2015-12-18 13:42:59 +01:00
450e2f3bd3
Move OC_Helper code to OCP\Util for linkToRemote
2015-12-18 12:00:18 +01:00
0a09004d39
Inject Config into SystemConfig
2015-12-18 11:53:41 +01:00
e42f262d85
properly use OCP\Util instead of OC_Helper
2015-12-18 11:46:21 +01:00
3d55569a27
OC_Helper::makeURLAbsolute is not used anymore
2015-12-18 11:37:18 +01:00
a18c0983d5
Use TempManager instead of tmpFile
2015-12-18 11:25:33 +01:00
90b0831cec
Use TempManager instead of tmpFolder
2015-12-18 11:19:53 +01:00
9e97bef935
Merge pull request #21268 from owncloud/cleanup-OC_Helper-getFileNameMimeType
...
Use proper public API for OC_Helper::getFileNameMimeType
2015-12-18 10:15:33 +01:00
551e553bf4
Merge pull request #21264 from owncloud/deprecated_oc_user_methods
...
Cleanup OC_User deprecated methods
2015-12-18 10:15:18 +01:00
345e68cafa
Use the query builder for the joblist queries
2015-12-18 09:50:23 +01:00
2709244acd
Only perform tearDown operations on the database if we have a connection to it .....
2015-12-17 17:29:50 +01:00
8f6a257f1b
Use proper base class
2015-12-17 17:29:17 +01:00
26f416b9f5
Assert that there are no xml error left
2015-12-17 17:18:42 +01:00
ecdf88e41b
Use proper public API for OC_Helper::getFileNameMimeType
2015-12-17 17:07:48 +01:00
1f715289bf
Removed deprecated function OC_User::deleteUser
...
Replaced with proper OCP calls
2015-12-17 16:18:40 +01:00
835911bce5
Removed deprecated private OC_User::createUser
...
All function calls are replaced with the recommended (which was already
the body of the function).
2015-12-17 16:18:40 +01:00
7e44ea5da0
Remove deprecated function OC_User::getManager
...
Private deprecated function => removed
Replaced all instances with suggested replacement
2015-12-17 16:18:34 +01:00
e3ed42135d
Merge pull request #21240 from owncloud/avatar_speedup
...
Avatar speedup
2015-12-17 14:43:21 +01:00
205c239eab
Remove deprecated OC_Helper::linkTo function
2015-12-17 11:51:40 +01:00
d796c43841
[Avatars] Add function to get the Node of the avatar
...
Since we usually just get the avatar and stream the content to the users
there is no need to first create an image in memory.
2015-12-16 20:29:02 +01:00
38a2467a4f
test for statcache after fopen
2015-12-15 13:48:17 +01:00
efc030aa25
don't allow to create a federated share if source and target server are the same
2015-12-14 17:16:14 +01:00
f831d93f3f
Merge pull request #20878 from owncloud/proper-htaccess-support-in-code-signing-checker
...
Also run .htaccess routine when installing on another system than Apache
2015-12-11 11:46:37 +01:00
6317ba8cb4
Merge pull request #21135 from owncloud/add-polyfill
...
Add polyfills for PHP55, PHP56 and PHP70 functionalities
2015-12-11 11:40:51 +01:00
f3360d51c6
Use PHP polyfills
2015-12-11 08:47:36 +01:00
ffc49a24f0
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2015-12-10 16:43:37 +01:00
df15d54db6
Merge pull request #21072 from owncloud/db-lock-ttl
...
Remove all locks after ttl from the db
2015-12-10 13:51:18 +01:00
29b6a03fc1
Add assertion to test
...
This seems to be missing on that test.
2015-12-10 09:29:24 +01:00
81d763be42
use expectedException annotation, not via method call, for consistency
2015-12-09 16:55:07 +01:00
fdd06ba1f8
use getLastInsertId from query builder for convenience
2015-12-09 16:33:34 +01:00
e191953942
Remove all locks after ttl from the db
2015-12-09 14:53:24 +01:00
8e298f51f8
adjust test's fakemanager to interface change
2015-12-09 14:38:01 +01:00
0c1c029571
hardening, add some checks for whitespace-only strings
2015-12-09 14:34:23 +01:00
8acbb7aef9
rework test about overwriting default comments manager
2015-12-09 14:34:23 +01:00
d3692c3283
namespaces for tests
2015-12-09 14:34:23 +01:00
9a440c06b0
OC not oc
2015-12-09 14:34:23 +01:00
e3dbc3d40c
different strategy in cleaning up after user was deleted
...
we do not listen to deletion hooks anymore, because there is no guarantee that they
will be heard - requires that something fetches the CommentsManager first.
Instead, in the user deletion routine the clean up method will be called directly. Same way
as it happens for files, group memberships, config values.
2015-12-09 14:34:23 +01:00
2ce2de0ae5
add icommentsmanger and icomment implementation
...
register CommentsManager service, allow override, document in config.sample.php
don't insert autoincrement ids in tests, because of dislikes from oracle and pgsql
specify timezone in null date
only accepts strings for ID parameter that can be converted to int
replace forgotten hardcoded IDs in tests
react on deleted users
react on file deletion
Postgresql compatibility
lastInsertId needs *PREFIX* with the table name
do not listen for file deletion, because it is not reliable (trashbin, external storages)
add runtime cache for comments
2015-12-09 14:34:23 +01:00
5c95939bf3
Merge pull request #21061 from owncloud/fix-oracle-last-insert-id-test
...
Fix the last insert id test by changing to an autoincremen…
2015-12-09 11:53:43 +01:00
bc744ff6de
Merge pull request #21038 from owncloud/share-computesharepermissions-notstore
...
Fix (re)share permission checks in a few code paths
2015-12-09 10:04:56 +01:00
5c0be3b565
Fix the last insert id test by changing to an autoincrement table
2015-12-09 09:51:33 +01:00
28e9bc1156
Fix more unit tests to pass a mock storage instead of null to FileInfo
2015-12-08 16:33:39 +01:00
45fe8271ab
Merge pull request #21030 from owncloud/querybuilder-new-features
...
Querybuilder new features
2015-12-08 13:51:45 +01:00
85409b6701
Merge pull request #20786 from owncloud/systemtags-dav
...
DAV endpoint for system tags
2015-12-08 13:51:25 +01:00
9f98849306
Add a method to the get "to use" table and column name
2015-12-08 11:04:28 +01:00
fe8dc0bd5e
Merge pull request #21022 from owncloud/get-rid-of-by-reference
...
Get rid of by reference
2015-12-08 11:04:25 +01:00
a3391248e4
Add select distinct to the query builder
2015-12-08 09:49:21 +01:00
f2c7acb3c0
Allow getting the last insert id without much hassle
2015-12-08 09:40:20 +01:00
6d3eb7673d
Add unit test for nested arrays
2015-12-08 09:07:38 +01:00
8289943a0f
Do not trust casting
2015-12-08 08:50:00 +01:00
0a89073c47
Run .htaccess updates in any case
...
This is the same what we also do in updater.php and thus this aligns the code. Makes the code paths more consistent.
2015-12-08 08:16:24 +01:00
453e1bf66e
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2015-12-07 15:43:36 +00:00
a9e5faf7d0
Merge pull request #20981 from owncloud/issue-19848-multiple-emails-for-sharelink
...
Allow sending a share email to multiple users
2015-12-07 15:17:19 +01:00
820c3b852d
Add a unit test for single user case as well
2015-12-07 12:01:02 +01:00
5b87413792
Allow sending a share email to multiple users
2015-12-07 10:49:34 +01:00
0c3d97921f
Merge pull request #20904 from owncloud/view-mime-filter
...
Fix mimetype filter in getDirectoryContent
2015-12-07 10:20:43 +01:00
316b907a13
Fixed system tags DAV and API and docs
2015-12-04 17:30:50 +01:00
602b636d3e
Merge pull request #20807 from owncloud/dont-append-redirect-url-if-user-is-already-logged-in
...
Don't append redirect URL if user is logged-in
2015-12-03 16:53:59 +01:00
0fe5506e91
Merge pull request #20921 from owncloud/last-OC_Config-removals-in-tests
...
Reduce OC_Config usage in tests/
2015-12-03 15:24:41 +01:00
cbe6eeffa1
last change of OC_Config to the proper interface in tests/
2015-12-03 14:03:05 +01:00
2d1cc8aaeb
Merge pull request #19461 from owncloud/reuse_code
...
reuse code
2015-12-03 13:55:50 +01:00
542ce7dd0d
Reduce OC_Config usage in tests/
2015-12-03 13:48:19 +01:00
19b2fe6a3a
Fix mimetype filter in getDirectoryContent
2015-12-03 13:09:13 +01:00
e9c8f82fc5
Replace OC_Config in tests with IConfig calls
2015-12-03 09:38:41 +01:00
c6bda8d6ca
Merge pull request #20902 from owncloud/drop-OC_Config-from-tests
...
Replace OC_Config in tests with IConfig calls
2015-12-03 09:30:47 +01:00
e7239b6553
Merge pull request #20872 from owncloud/systemtags-better-not-found-exception
...
Systemtags better not found exception
2015-12-03 09:26:05 +01:00
a5c80ba8bc
Merge pull request #20894 from owncloud/post-delete-meta-view
...
Also add metadata for postDelete hooks triggered from the view
2015-12-03 09:24:54 +01:00
d331e0d4f8
Replace OC_Config in tests with IConfig calls
2015-12-02 23:14:52 +01:00
dcc7ff09ba
Adding unit test for MailNotifications::sendInternalShareMail()
2015-12-02 21:42:14 +01:00
eebe2b9c23
User IUser::getEMailAddress() all over the place
2015-12-02 21:25:05 +01:00
df5872ec50
Merge pull request #20719 from owncloud/adding-system-addressbook-of-users
...
Adding system addressbook for users of this instance - a occ command …
2015-12-02 16:17:58 +01:00
28ceab2f61
Fix endless recursion
2015-12-02 14:44:41 +01:00
0062888aaf
Also add metadata for postDelete hooks triggered from the view
2015-12-02 13:51:26 +01:00
8d218bf3ef
Merge pull request #20875 from owncloud/remove-changepropagator
...
remove old propagation logic
2015-12-02 13:03:31 +01:00
c46ea30248
Merge pull request #20865 from owncloud/post-delete-meta
...
Add metadata to post delete hooks
2015-12-02 10:12:54 +01:00
0391cc0451
Fix getCloudId
2015-12-02 09:14:41 +01:00
fe67db1ad0
Adding unit test for User::getCloudId()
2015-12-02 09:14:41 +01:00
df6fc6cc70
Add the user's cloud id to the vCard
2015-12-02 09:14:41 +01:00
dad6470baa
Add IUser::getAvatarImage() for easy access
2015-12-02 09:14:41 +01:00
b00db2c933
DI in avatar code
...
* DI in avatar code
* Use the node API
* More unit tests
* Unit tests no longer require DB
2015-12-01 22:15:43 +01:00
62cc316c6a
remove old propagation logic
2015-12-01 16:50:20 +01:00
2515cb17be
Support pretty URLs
...
This changeset allows ownCloud to run with pretty URLs, they will be used if mod_rewrite and mod_env are available. This means basically that the `index.php` in the URL is not shown to the user anymore.
Also the not deprecated functions to generate URLs have been modified to support this behaviour, old functions such as `filePath` will still behave as before for compatibility reasons.
Examples:
http://localhost/owncloud/index.php/s/AIDyKbxiRZWAAjP => http://localhost/owncloud/s/AIDyKbxiRZWAAjP
http://localhost/owncloud/index.php/apps/files/ => http://localhost/owncloud/apps/files/
Due to the way our CSS and JS is structured the .htaccess uses some hacks for the final result but could be worse... And I was just annoyed by all that users crying for the removal of `index.php` ;-)
2015-12-01 16:46:07 +01:00
08d07cc4db
Fix the unit test by running tearDown() and cleaning tags before the test
2015-12-01 15:00:44 +01:00
1d0c041ac8
Add a method to get the list of tags from the TagNotFound Exception
2015-12-01 14:54:34 +01:00
0d63e95a5d
Add metadata to post delete hooks
2015-12-01 13:22:58 +01:00
4971015544
Add code integrity check
...
This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository.
Furthermore, there is a basic implementation to display problems with the code integrity on the update screen.
Code signing basically happens the following way:
- There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release 😉 ). This certificate is not intended to be used for signing directly and only is used to sign new certificates.
- Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`, apps need to be signed with a certificate that either has a CN of `core` (shipped apps!) or the AppID.
- The command generates a signature.json file of the following format:
```json
{
"hashes": {
"/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d",
"/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9"
},
"certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----",
"signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl"
}
```
`hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`.
Steps to do in other PRs, this is already a quite huge one:
- Add nag screen in case the code check fails to ensure that administrators are aware of this.
- Add code verification also to OCC upgrade and unify display code more.
- Add enforced code verification to apps shipped from the appstore with a level of "official"
- Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release
- Add some developer documentation on how devs can request their own certificate
- Check when installing ownCloud
- Add support for CRLs to allow revoking certificates
**Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature:
```
➜ master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt
Successfully signed "core"
```
Then increase the version and you should see something like the following:
As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen.
For packaging stable releases this requires the following additional steps as a last action before zipping:
1. Run `./occ integrity:sign-core` once
2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.
2015-12-01 11:55:20 +01:00
08248f66ba
Merge pull request #20650 from owncloud/systemtags-core
...
Implement systemtag managers and mapper
2015-11-30 15:38:43 +01:00
b8b0ae0944
Fix phpstorm complains in tests
2015-11-30 13:36:22 +01:00
b94aadc440
Cleanup imports and type hinting
2015-11-30 12:45:30 +01:00
f4eb15d340
Show error template
...
Otherwise this leads to an endless redirection in case of a CSRF exception. Also sets user expectation right.
2015-11-30 11:25:52 +01:00
dddfa6de78
Don't break app on travis
2015-11-30 10:55:13 +01:00
318e5e2864
More group DB
2015-11-30 10:55:13 +01:00
f9fc254672
Add DB group to some files_external tests
...
Adding group Db to federation tests and ldap tests
Add group DB to Test_UrlGenerator
Adding group DB to trashbin and versions tests
Adding group DB to Test_Util_CheckServer for pg
2015-11-30 10:55:10 +01:00
757aa45db7
Adding more DB groups to test suits
...
Adding more DB groups to test suits
2015-11-30 10:55:06 +01:00
56170dd825
Further unit test suite tweats
2015-11-30 10:55:05 +01:00
1480964768
Adding more test suites to group DB
2015-11-30 10:55:05 +01:00
7e71d8231e
Mock DIContainer to not hit the database
2015-11-30 10:55:05 +01:00
3bb6dcea64
Apply DB group annotation ...
2015-11-30 10:55:05 +01:00
03ee3b9aec
A TestCase which is not annotated to be in group DB will not allow access to the database connection.
...
This is necessary to categorize unit test and avoid duplicate test case execution - it also allows us to closely review unit test implementations to identify unnecessary db calls.
2015-11-30 10:55:05 +01:00
24d5ce9a58
Add phpunit group for tests
2015-11-30 10:25:53 +01:00
9c1dbaf0ad
Merge pull request #20788 from owncloud/catch-missing-route
...
Dont die when we're missing a route
2015-11-30 10:11:12 +01:00
4c4331982c
Merge pull request #20789 from owncloud/scanner-skip-not-available
...
Skip unavailable storages in scanner
2015-11-27 22:57:47 +01:00
b666367a79
Added system tags data structure and PHP side managers
...
Added SystemTagManager and SystemTagObjectMapper
2015-11-27 17:54:29 +01:00
aa822f76e2
fix tests
2015-11-27 17:05:58 +01:00
ae71f80f4a
Skip unavailable storages in scanner
2015-11-27 14:02:50 +01:00
e0e51fd79f
Added tests.
2015-11-27 02:45:49 -08:00
8fe878afe9
Merge pull request #20602 from owncloud/fix-installed-apps
...
Always installed apps includes the hardcoded ones from shipped.json
2015-11-26 16:50:05 +01:00
80c43ffc6c
Merge pull request #20702 from owncloud/move-user-principal-into-subfolder
...
Users are available under it's own principal resource named 'principa…
2015-11-26 16:49:49 +01:00
19d5059109
Merge pull request #20393 from owncloud/querybuilder-select-with-alias
...
Add a method to select a field or value with alias
2015-11-26 16:19:20 +01:00
3882cc8ef3
Merge pull request #20744 from owncloud/oc_helper-getMimeType-cleanup
...
Remove last occurences of OC_Helper::getMimeType()
2015-11-26 12:37:25 +01:00
5a33390a69
Merge pull request #20731 from owncloud/per-storage-updater
...
Make Cache\Updater per storage
2015-11-26 12:01:44 +01:00
4fcab98694
Remove unused internal methods
...
* removes OC_Helper::mb_substr_replace and OC_Helper::mb_str_replace
* keeps public interface wrapper working as expected
2015-11-26 10:25:43 +01:00
9318606faf
Remove last occurences of OC_Helper::getMimeType()
...
* ref #4774
2015-11-26 10:18:32 +01:00
b799e42b4e
Introduce \OCP\IUser::getEMailAddress()
2015-11-25 22:23:34 +01:00
9ec2f8886e
Merge pull request #20691 from owncloud/share2.0_di_fixes
...
[Sharing 2.0] di fixes
2015-11-25 15:25:50 +01:00
b025f07fb7
Make Cache\Updater per storage
2015-11-25 14:16:00 +01:00
50f6817ce9
Merge pull request #20439 from owncloud/etag-propagate-in-storage
...
Take submount etag into account for folder etags
2015-11-25 12:49:54 +01:00
a2b8483779
[Sharing 2.0] Default share provider only generic DI
...
No injection of userfolders etc. Only generic DI components
(IRootFolder) etc should be used to make sure we can also run this from
the cli
2015-11-24 10:26:36 +01:00
aeae73b364
[Sharing 2.0] Removed unused DI stuff
...
The share manager etc should not care about filtering stuff. They should
return what is asked for them.
2015-11-24 10:26:36 +01:00
018bd3ee24
Make sure that object id can be a string
2015-11-23 14:18:15 +01:00
df906f475b
Merge pull request #20617 from owncloud/fix-usage-of-lastInsertId
...
lastInsertId() is properly working with Oracle if the table name is p…
2015-11-23 13:29:08 +01:00
240cc1c4ea
Merge pull request #20543 from owncloud/share2.0_fix_hooks
...
Move hook and delete children logic to share manager
2015-11-23 13:28:49 +01:00
1c7d7288c4
Add a method to select a field or value with alias
2015-11-23 13:28:31 +01:00
bc69cb2de3
fix unit tests
2015-11-23 13:13:26 +01:00
1360e22d7c
[Sharing 2.0] Move hook and delete children logic to share manager
...
To make sure hooks are always fired and child entries are always
cleaned. This logic is moved to the share manager.
* Updated unit tests
2015-11-23 12:28:54 +01:00
9f69021691
lastInsertId() is properly working with Oracle if the table name is properly passed in
2015-11-23 11:44:08 +01:00
a370c29068
Use a DateTime object instead of a timestamp
2015-11-23 11:41:48 +01:00
32ab973254
add unit tests for OC_Util::add* methods
2015-11-23 11:03:09 +01:00
358858c9e3
Fix undefined HTTP_USER_AGENT
2015-11-22 16:05:50 +01:00
427d107b9f
Merge pull request #20614 from owncloud/use-mocks-when-testing-isSharingDisabledForUser
...
Use mocks when testing isSharingDisabledForUser
2015-11-20 15:22:52 +01:00
c565a7b042
Fix failing unit test 💀
2015-11-19 16:44:43 +01:00
9ec2850c78
Use mocks when testing isSharingDisabledForUser
2015-11-19 15:36:16 +01:00
a95d4c2b22
update tests
2015-11-19 13:32:04 +01:00
888df3933d
take the etag of child mounts into account for the folder etag
...
this replaces shared etag propagation
2015-11-19 13:32:00 +01:00
0b8335ff2f
Make the JobList test more robust by sorting the result of getAll before comparison
2015-11-19 09:25:34 +01:00
8db9c49cda
Merge pull request #20551 from owncloud/notification-fix-tests
...
Notification - Add tests for the "return $this" and fix it on the new method
2015-11-18 09:12:27 +01:00
74ce6d29e1
Merge pull request #20544 from owncloud/move-index-to-appframework
...
Move index.php from files to AppFramework
2015-11-17 12:49:38 +01:00
2fde6a77d7
Add tests for the "return $this" and fix it on the new method
2015-11-17 09:26:13 +01:00
705d208a8a
Merge pull request #20539 from owncloud/notification-api-adjustment
...
Notification api update
2015-11-17 08:39:06 +01:00
daa388ce8d
Move index.php from files to AppFramework
...
1. Allows it to use the more secure CSP rules of the AppFramework.
2. Adds some unit tests.
2015-11-16 21:10:11 +01:00
40d5d55124
Remove the icon for now
2015-11-16 16:17:23 +01:00
1666af89c2
Add "is primary action" to actions
2015-11-16 16:14:52 +01:00
1e9fc33212
[Share2.0] OCS Share API getShare uses new code
2015-11-16 13:32:28 +01:00
d0464bf772
enable microseconds in log timestamps
2015-11-12 10:33:20 +01:00
20cad09f7f
Add tests for FileInfo owner
2015-11-10 11:06:48 +01:00
960c8cb5bc
Merge pull request #16604 from owncloud/cache-escape-like
...
escape like parameter in cache operations
2015-11-10 09:45:00 +01:00
87e3402ef5
Fix autoloader unit test output
...
Removed leftover print statement
2015-11-09 15:54:40 +01:00
0bb5eadf89
[autoloader] Make sure to load construct full paths
...
This reduces a lot of the autoloader magic and makes sure that we
generate full paths in the autoloader.
2015-11-06 13:36:19 +01:00
cc4f4f222d
Merge pull request #20348 from owncloud/issue-20303-integer-group-names
...
Make sure that group names are strings not integers
2015-11-06 11:48:40 +01:00
8047597a81
Merge pull request #20288 from owncloud/fix_20234
...
make sure that we update the unencrypted size for the versions
2015-11-06 11:17:17 +01:00
292dc553c3
Make sure that group names are strings not integers
2015-11-06 10:40:09 +01:00
556fabf15d
Add test for special character during move
2015-11-05 16:29:38 +01:00
532b8a1ad0
Fix oracle
2015-11-05 15:59:09 +01:00
0be05fdddd
Add unshare hooks
2015-11-05 15:59:09 +01:00
6624fa212a
The new sharing code now handles deletion
...
OCS -> ShareManager -> DefaultShareProvider
2015-11-05 15:59:09 +01:00
51ead4e59b
subadmin methods should not return any null user or group
2015-11-05 11:50:57 +01:00
6d0a324144
make sure that we update the unencrypted size for the versions
2015-11-04 10:59:05 +01:00
73d9699be9
Merge pull request #20135 from owncloud/check-if-null-subadmin
...
Drop OC_SubAdmin and replace usages
2015-10-29 17:07:45 +01:00
530f7229e7
Merge pull request #19869 from owncloud/cache-adjustcurrentmtimeonrename
...
On rename, also refresh storage_mtime of the target file
2015-10-29 11:57:00 +01:00
c6f6a8758b
Drop OC_SubAdmin and replace usages
2015-10-29 11:31:18 +01:00
6043f0afdb
Use the method
2015-10-29 09:26:26 +01:00
e5a7e3124a
Add a repair step that checks for group membership on shares
2015-10-29 09:26:26 +01:00
ca2fd30073
Remove shares where the parent does not exist anymore
2015-10-29 09:26:26 +01:00
f355d4e51a
Fix locking unit tests due to filemtime addition
2015-10-26 15:41:23 +01:00
b900782513
Also adjust storage_mtime of target after rename
...
Some storages like Dropbox change their mtime on rename...
2015-10-26 15:41:23 +01:00
13e817e901
Throw exception on `getPath` if file does not exist
...
Currently the `getPath` methods returned `NULL` in case when a file with the specified ID does not exist. This however mandates that developers are checking for the `NULL` case and if they do not the door for bugs with all kind of impact is widely opened.
This is especially harmful if used in context with Views where the final result is limited based on the result of `getPath`, if `getPath` returns `NULL` PHP type juggles this to an empty string resulting in all possible kind of bugs.
While one could argue that this is a misusage of the API the fact is that it is very often misused and an exception will trigger an immediate stop of execution as well as log this behaviour and show a pretty error page.
I also adjusted some usages where I believe that we need to catch these errors, in most cases this is though simply an error that should hard-fail.
2015-10-25 17:58:21 +01:00
8133d46620
Remove dependency on ICrypto + use XOR
2015-10-21 17:33:41 +02:00
0e9ab13943
New \OC\SubAdmin class
...
* DI
* Tests
* moved OC_SubAdmin to legacy
* Added to private OC\GroupManager
2015-10-21 11:32:38 +02:00
cf9b8fc182
Merge pull request #18184 from owncloud/ocs-merge-headers
...
Merge headers of ocs results
2015-10-21 10:36:37 +02:00
2895c91291
Merge pull request #17641 from owncloud/fix_objectstore_rename
...
don't move files in cache twice, fixes renaming for objectstores
2015-10-19 17:18:57 +02:00
9c5337ca3e
Merge pull request #19833 from owncloud/fix_view_rmdir
...
Removemount expects absolutePath
2015-10-19 16:22:42 +02:00
ef179331bb
Add tests for double cache rename
2015-10-16 21:41:51 +02:00
a87368acb9
Skip checkupdate test for swift
2015-10-16 21:41:51 +02:00
8fdb12f8fb
Check for error when resharing
2015-10-16 20:43:17 +02:00
9e86d71cc5
When sharing with the owner show the path
...
The error message should contain the path that is being shared not the
numeric id.
2015-10-16 20:43:17 +02:00
d8798877df
Added test for rmdir on moveablemount
2015-10-16 16:51:44 +02:00
8fa59033ac
Fix uni tests
2015-10-16 13:17:12 +02:00
f2889dc6e4
Consolidate webdav code - move all to one app
2015-10-16 13:17:12 +02:00
e0d6bd5b6d
Run test only when idn is available
...
IDN is not installed on all machines making the unit test execution fail on those without. Let's make IDN thus a pre-requirement for the text execution.
2015-10-16 11:02:10 +02:00
d904a09a04
The constant is now deprecated
2015-10-14 15:29:38 +02:00
28d6da8158
Merge pull request #19738 from owncloud/proppatch-lastmodified
...
Fix mtime PROPPATCH to be "lastmodified" instead of "getlastmodified"
2015-10-14 12:49:33 +02:00
bfac6c5eb7
Merge pull request #19730 from owncloud/fix_17560
...
Squash collection shares
2015-10-14 12:38:16 +02:00
02513f8d04
Fix mtime PROPPATCH to be "lastmodified" instead of "getlastmodified"
...
Fix regression that makes PROPPATCH of mtime work like it did in OC <=
8.0.
The PROPPATCH must be done on the "lastmodified" property.
The "getlastmodified" now return 403 again.
2015-10-13 12:51:21 +02:00
3891cd9068
Merge pull request #19677 from owncloud/silently-fail-app-upgrade-exceptions-master
...
Silently fail app upgrade exceptions
2015-10-13 11:04:02 +02:00
06aaa059d1
Squash collection shares
...
If folder1 is shared to user2 and user3. And folder1/folder2 is shared
to user4 and user5 then getting all the users with access to
folder1/folder2 should only list user2 and user 3 once.
Previously this was done twice since we request the info two times.
This fix makes sure that we only append unique results to the array.
* Added test
2015-10-13 10:05:49 +02:00
e03f0542e4
Strip directory from scriptName
...
`\OCP\IRequest::getScriptName` will also return the directory, so if ownCloud is installed in a subfolder such as `owncloud/` it will resolve to `/owncloud/ocs/v2.php`. This made this check fail and also made it return invalid status codes.
2015-10-12 23:39:16 +02:00
64a8d01694
Merge pull request #19683 from owncloud/repair-donotrepairfoldermimetypes
...
Do not update mime types for folders with extension
2015-10-12 15:08:19 +02:00
8185eaa6dd
also detect files in a .part folder as part file
2015-10-12 13:59:16 +02:00
0036c637fc
Merge pull request #19657 from owncloud/setup-transport
...
Setup sendmail transport
2015-10-12 13:44:26 +02:00
8098c06e70
Do not update mime types for folders with extension
...
Some folders might have an extension like "test.conf".
This fix prevents to overwrite the folder's mime type with another mime
type while running the mimetype repair step.
2015-10-09 18:16:36 +02:00
4cb5970947
Always pass in ILogger
2015-10-09 14:08:22 +02:00
c8640cdcb0
adjust filesystem tests to objectstore
2015-10-09 12:35:37 +02:00
020bb33150
Merge pull request #19034 from owncloud/http-request-warning
...
Prevent warning decoding content
2015-10-08 21:51:47 +02:00
18394205c2
Setup sendmail transport
...
Replaces https://github.com/owncloud/core/pull/19047 and fixes https://github.com/owncloud/enterprise/issues/854 and https://github.com/owncloud/core/issues/19110
2015-10-08 16:48:18 +02:00
17ffa4a244
Merge pull request #19414 from owncloud/swift_primary_storage_tests
...
Swift primary storage tests
2015-10-08 14:08:56 +02:00
2fda4e38e2
Merge pull request #19546 from owncloud/fix-search-for-node-api
...
Fix search operations for the Node API
2015-10-08 13:17:26 +02:00
1ee56c702d
[WEBDAV] check if delete of source is allowed on move
...
Fixes #5251
If we perform a move we need to make sure first that the source can be
deleted. Else the dest might be cleared but the move will fail later.
* Added unit tests
Eventually we need more and better checking here.
2015-10-07 11:58:16 +02:00
5646e39248
test objectstore with ceph docker
...
use default config for swift primary storage test config
allow testsuite to complete
fix timeout, script cleanup, enable debug for now
use btrfs loopback device, requires privileged container and absolute path
throw exception when storage has problems
debug by echo ...
sleep more, more debug
2015-10-06 16:27:25 +02:00
e28a2ff888
Add unit test for searching in storage root
2015-10-06 15:54:17 +02:00
80a232da6a
Add \OCP\IRequest::getHttpProtocol
...
Only allow valid HTTP protocols.
Ref https://github.com/owncloud/core/pull/19537#discussion_r41252333 + https://github.com/owncloud/security-tracker/issues/119
2015-10-06 14:18:46 +02:00
da640adf68
Merge pull request #19577 from owncloud/share-donotreturnentrieswhenusernotingroup
...
Remove invalid share items from result when missing group membership
2015-10-06 09:24:22 +02:00
1c7244c120
Remove invalid share items from result when missing group membership
...
Group shares usually have subshare entries for every user. In some
situations it can happen that the user was removed from the group but
the subshare entries still exist.
This fix makes sure that such subshare entries are not returned any more
as the user isn't in the group any more.
2015-10-05 17:21:34 +02:00
ac5b3161e4
Add a unit test for "share a file inside a folder that is already shared"
2015-10-05 12:36:16 +02:00
34951efed6
Merge pull request #19574 from owncloud/fix-sharing-tests-assuming-empty-share-table
...
Clear the shares after the test like storages and files
2015-10-05 11:00:34 +02:00
56c35da8d5
Merge pull request #19416 from owncloud/node-hook-connector
...
pass view hooks trough to the node hooks
2015-10-05 10:25:04 +02:00
42b29e39c1
Clear the shares after the test like storages and files
2015-10-05 10:13:45 +02:00
ff89824135
Merge pull request #19272 from owncloud/mimetypes-enhanced
...
Introduce a few new mimetypes for code, fix recursive mimetype aliases
2015-10-02 17:50:34 +02:00
8bdffb5ed3
Merge pull request #19525 from owncloud/share-preventmovemountpointintosharedfolder
...
Prevent moving mount point into already shared folder (outgoing)
2015-10-02 16:50:38 +02:00
64ca00925b
Prevent moving mount point into already shared folder (outgoing)
...
It is already not allowed to share a folder containing mount points /
incoming shares.
This fixes an issue that made it possible to bypass the check by moving
the incoming share mount point into an existing outgoing share folder.
2015-10-02 16:14:42 +02:00
c80dd82fe4
Added mimetype repair step
...
* Version number increased
2015-10-02 16:06:56 +02:00
6b53f7c40e
[l10n] remove unused static methods
2015-10-02 12:51:45 +02:00
8944cb539e
Merge pull request #19510 from owncloud/json-grouplist-sharing-exclude
...
save excluded groups in json format
2015-10-02 12:14:36 +02:00
b6591084a1
Merge pull request #19463 from owncloud/fix_18132
...
encryption: versions should always use the keys of the original file, no need to …
2015-10-01 16:56:28 +02:00
b2dd5cb616
save excluded groups in json format - fixes #10983
2015-10-01 15:37:55 +02:00
1c3e28a73b
Add tests
2015-10-01 13:17:22 +02:00
e7232a848b
versions should always use the keys of the original file, no need to create new one
2015-10-01 10:10:19 +02:00
8f2600a0ea
Also delete all shares before the test, so the count matches
2015-10-01 08:32:24 +02:00
6e104bc933
Repair step to remove bogus expiration dates from non-link shares
2015-10-01 08:27:12 +02:00
ff75652cb7
Merge pull request #19299 from owncloud/fixgetRawPathInfo
...
Fix get raw path info, always return a string
2015-09-30 22:17:02 +02:00
1d8c10cf63
Merge pull request #19468 from owncloud/fix-36-vs-32-previews
...
Change small thumbnails to 32 px
2015-09-30 15:47:34 +02:00
10978a7a61
Merge pull request #19373 from owncloud/sidebar-preview-cover
...
Cover both width and height for the sidebar preview
2015-09-30 11:07:18 +02:00
1051a3c6f5
Change small thumbnails to 32 px
...
* fixes #16913
* fixes issues in IE8 where the thumbnail is too big
2015-09-30 10:49:48 +02:00
fbe43e6a26
cache result of \OCP\Util::needUpgrade()
...
reduce calls of \OCP\Util::needUpgrade()
where \OCP\Util::needUpgrade() is called we can call as well
self::checkUpgrade and use the cached result
In line 877 the call way unnecessary anyway because of the first part of
the if statement
move caching to \OCP\Util::needUpgrade
renaming variable
fixing testNeedUpgradeCore()
cache result of checkUpgrade() in self::$needUpgrade
reduce calls of \OCP\Util::needUpgrade()
where \OCP\Util::needUpgrade() is called we can call as well
self::checkUpgrade and use the cached result
In line 877 the call way unnecessary anyway because of the first part of
the if statement
move caching to \OCP\Util::needUpgrade
renaming variable
fixing testNeedUpgradeCore()
fix typo in variable name
deleting tabs
2015-09-29 15:34:42 +02:00
e735a9915c
Add blob: scheme to default CSP policy
...
Fixes https://github.com/owncloud/core/issues/19438
2015-09-29 14:27:35 +02:00
f41a38ba15
Cover both width and height for the sidebar preview
2015-09-29 13:07:03 +02:00
e21a025887
remove unused use
2015-09-28 17:20:44 +02:00
1e5a41f008
Add hook connector to connect view and node hooks
2015-09-28 17:18:40 +02:00
d68079f932
Merge pull request #18548 from owncloud/repair-mimetype-limitversion
...
Repair mime types only when upgrading from OC 8.0
2015-09-28 12:56:36 +02:00
b50d1aae56
rename config test to prevent autoloader issue
2015-09-28 10:47:49 +02:00
0aaece7de7
Merge pull request #19346 from owncloud/drop-passwords-from-exception-log
...
Remove passwords from logged exception stack traces
2015-09-25 20:04:01 +02:00
9a373cb5bb
Do not blindy copy expiration date on reshare
...
If a file/folder is reshared we should not blindly copy the expiration
date of the parent share. User/Group shares do not have expiration dates
currently, and thus this is always set to null.
Fixes #19119
* Added testcase
2015-09-25 13:06:05 +02:00
db8e7ce8b9
Remove passwords from logged exception stack traces
...
* fixed #16318
* create logException in ILogger
* add unit tests
2015-09-24 20:01:30 +02:00
ebdd6d96ce
Merge pull request #19306 from owncloud/app-code-check-version
...
[App Code Check] add check for version and mandatory fields
2015-09-24 17:38:48 +02:00
bf4c144c6f
Merge pull request #19335 from owncloud/phil-davis-view-typos
...
Comment typos in tests/lib/files/view.php
2015-09-24 14:54:21 +02:00
d697ea58a4
only check if the user exists if a user was added as parameter
2015-09-24 12:21:40 +02:00
9b652ed5d5
[App Code Check] add check for version and mandatory fields
...
* ref #17598
* including unit tests for mandatory fields/versions
2015-09-24 11:58:12 +02:00
330ea18996
Merge pull request #19303 from owncloud/usecorrectvariable
...
Use correct variable
2015-09-24 11:34:19 +02:00
9f9bdd8f90
Comment typos in tests/lib/files/view.php
...
Correct a comment typo just introduced at line 892, plus another and some white space at EOL.
2015-09-24 15:01:45 +05:45
11974477bd
Merge pull request #19326 from owncloud/issue-19314-querybuilder-set-null
...
Allow `set('column', 'null')` to work like in Doctrine's QueryBuilder
2015-09-24 10:57:49 +02:00
df75c17e52
Merge pull request #16479 from owncloud/core-fixgetrelativepathwrongmatches
...
Prevent wrong matches in getRelativePath
2015-09-24 10:25:00 +02:00
70572c1e3c
Allow `set('column', 'null')` to work like in Doctrine
2015-09-24 09:53:09 +02:00
17ef187681
add is* storage tests
2015-09-23 23:41:39 +02:00
ebe9bea709
Unit test for preventing warning decoding content
2015-09-23 14:16:41 +01:00
ca8d589f27
use assertSame, add failing case
2015-09-23 12:31:45 +02:00
bcdb3c26da
Merge pull request #19236 from owncloud/call_dot_directories_function
...
Replaces if ($file === '.' || $file === '..') by public function call isIgnoredDir
2015-09-23 11:34:23 +02:00
ad71d92acf
Merge pull request #19247 from owncloud/fix_locking_copy_operation
...
locking: handle exceptions correctly during copy operation
2015-09-23 11:28:27 +02:00
0bda4d54c5
Repair mime types only when upgrading from OC 8.0
2015-09-23 10:51:37 +02:00
491250320a
Replaces if ($file === '.' || $file === '..') by if(\OC\Files\Filesystem::isIgnoredDir($file)). Eases to find where this operation is used.
2015-09-22 17:53:15 +02:00
63b2bc136a
Move mimetype files into /resources/config/
2015-09-22 16:43:28 +02:00
d26c49b995
Add more tests for relativePath
2015-09-22 11:34:37 +02:00
b9cd5bc1dc
Prevent wrong matches in getRelativePath
...
Before this fix, the root "/files" with path "/files_trashbin" would
return "_trashbin" as relative path...
2015-09-22 11:34:37 +02:00
17a64360e5
catch excexptions during the copy operation and make sure that we free the lock correctly
2015-09-22 11:32:10 +02:00
36ce254ffd
Move dummy backend to Tests namespace
2015-09-22 11:01:11 +02:00
d8901cf7cd
Merge pull request #19221 from owncloud/improved_error_messages
...
decrypt-all: improved error message if user doesn't exists
2015-09-21 16:06:43 +02:00
b520a1e520
Merge pull request #19081 from owncloud/prevent0bytedownloads
...
prevent 0 byte downloads when storage returns false
2015-09-21 13:50:35 +02:00
d2e90b6050
improved error message if user doesn't exists
2015-09-21 13:19:35 +02:00
2c8eaacec7
Merge headers of ocs results
2015-09-21 11:54:46 +02:00
bbf128f1b2
Merge pull request #19098 from owncloud/db-lock-no-transaction
...
Remove the need for the transaction in the database locking backend
2015-09-18 17:02:18 +02:00
d62cffbc9a
Merge pull request #18901 from owncloud/encryption-dav-tests
...
Add tests for doing dav requests with encryption enabled
2015-09-18 14:54:06 +02:00
947e3d7ab5
Add repair step for outdated OCS IDs
...
There is the case where OCs IDs might become outdated such as it has been with the calendar and contacts app which refer to the old dummy entry. This means that users with the old OCS id can't update updates as well will receive invalid state flags. (e.g. "experimental" instead of "approved")
To allow instances to properly update the applications in the future we need to migrate the OCS IDs for now manually.
2015-09-18 13:27:26 +02:00
3ca61db63b
Merge pull request #19017 from owncloud/dav-download-tests
...
Add tests for downloading files over dav
2015-09-18 11:57:28 +02:00
485ea316a1
reuse the same datadir
2015-09-18 11:55:15 +02:00
dc870cb450
Add tests for doing dav requests with encryption enabled
2015-09-18 11:55:15 +02:00
a3d734f6cd
Add trait to enable encryption for a unit test
2015-09-18 11:55:15 +02:00
e3e78f809d
create new mounts every time the mount provider is called
...
important for storage wrappers
2015-09-18 11:55:15 +02:00
5247a0685d
clear up tests a bit
2015-09-18 11:55:15 +02:00
5eddde6486
Add a Sabre plugin that emits an event for apps
2015-09-17 13:59:27 +02:00
05fddec022
expire old lock rows
2015-09-17 13:55:04 +02:00
2839ef3439
add unit test
2015-09-17 11:16:00 +02:00
3cf4fc02f9
fix tests with empty response body
2015-09-16 15:27:22 +02:00
953b64f3f2
Add tests for downloading files over dav
2015-09-16 12:59:15 +02:00
9bd4f2d41e
occ script to disable encryption and to decrypt all files again
2015-09-15 22:39:44 +02:00
9883d5b85d
Merge pull request #18915 from owncloud/node-getfoldercontents-use-view-logic
...
Use the view logic for getFolderContent for the node api
2015-09-15 18:04:01 +02:00
9202d2f45a
fix chunking tests
2015-09-14 20:35:33 +02:00
80f054ddd3
also verify cache in dav upload tests
2015-09-14 20:35:33 +02:00
17b671ee25
adjust tests to handle before/after locking
2015-09-14 20:35:33 +02:00
2d0f0e898d
Only check the "was updated/inserted" when not on Oracle...
2015-09-14 15:27:06 +02:00
7562e4959b
Merge pull request #18658 from owncloud/configurable-temp
...
Configurable temporary directory
2015-09-12 22:04:41 +02:00
188d0e09b8
Add reset method to mimetype loader
...
Used to solve concurrency issues
2015-09-11 12:44:53 +01:00
620173c792
Merge pull request #18851 from owncloud/memcached-getallkeys-fallback
...
Fallback to complete Memcached flush if getAllKeys fails
2015-09-10 20:33:18 +01:00
fb717f254f
Merge pull request #18699 from owncloud/notification-manager
...
Notification manager
2015-09-10 15:26:36 +02:00
7445afdb6f
Merge pull request #18925 from owncloud/change-risky-test
...
Rename data provider to avoid risky test warning
2015-09-09 16:05:01 +02:00
0943781ccf
Rename data provider to avoid risky test warning
...
```
06:49:56 There was 1 risky test:
06:49:56
06:49:56 1) OC\AppFramework\Http\JSONResponseTest::testRenderProvider
06:49:56 This test did not perform any assertions
```
2015-09-09 12:52:54 +02:00
0b91087489
Write to session in batch at the end of the request
2015-09-09 12:48:37 +02:00
e579dd62fd
Write session data to single key
...
This prevents decrypting values multiple times.
2015-09-09 12:48:08 +02:00
c4c9c5ffad
Merge pull request #18684 from owncloud/explicit-upgrade-version
...
Explicit upgrade version + prevent downgrades
2015-09-09 11:08:55 +02:00
9f11b27797
Use the view logic for getFolderContent for the node api
2015-09-08 22:38:50 +02:00
38001d824b
Move interfaces to private until they are no longer experimental
2015-09-08 09:01:02 +02:00
59f37a8dfb
Add tests for the query()
2015-09-08 09:01:02 +02:00
190d2c3d5b
Add tests for the notification manager
2015-09-08 09:01:02 +02:00
270b0bd91b
Add more action tests
2015-09-08 09:01:02 +02:00
c6469be8bd
Add tests for notification
2015-09-08 09:01:02 +02:00
acf8149f17
Add tests for Action
2015-09-08 09:01:01 +02:00
24f5f50b20
Merge pull request #18742 from owncloud/mimetype-updatedb
...
Introduce mimetype DB update occ command
2015-09-06 16:56:35 +02:00
b64e3f8db6
Fallback to complete Memcached flush if getAllKeys fails
...
Newer Memcached's do not support the underlying protocol commands that
getAllKeys() is implemented with. We should fallback to clearing
everything in that case, as causing (temporary) performance problems for
other applications on the server is better than having stale cached data.
2015-09-05 20:02:49 +01:00
c6314fc699
Unit tests for mimetype loader
2015-09-04 17:37:10 +01:00
cdf01f0419
Split mimetype handling to new class
2015-09-04 17:28:20 +01:00
e54513cddd
Merge pull request #18799 from owncloud/appconfig-with-one-request
...
Only query the appconfig once per request
2015-09-03 16:13:14 +02:00
21ba3b8737
Only query the appconfig once
2015-09-03 11:30:57 +02:00
f9e90e92d4
Encode HTML tags in JSON
...
While not encoding the HTML tags in the JSON response is perfectly fine since we set the proper mimetype as well as disable content sniffing a lot of automated code scanner do report this as security bug. Encoding them leads to less discussions and a lot of saved time.
2015-09-03 00:44:46 +02:00
87b3e28f06
Merge pull request #18730 from owncloud/appframework_proper_304
...
Properly return 304 in AppFramework
2015-09-01 15:39:59 +02:00
e9b91b1798
verify the path in the autoloader
2015-09-01 15:03:28 +02:00
f12caf930e
Properly return 304
...
The ETag set in the IF_NONE_MODIFIED header is wraped in quotes (").
However the ETag that is set in response is not (yet). Also we need to
cast the ETag to a string.
* Added unit test
2015-09-01 11:04:41 +02:00
5a1619d80d
Unit test getting temp dir from config
2015-08-30 23:34:38 +01:00
a0dfaf9be3
Clean up TempManager to follow code guidelines
...
tmpBaseDir can be overridden for unit testing purposes
2015-08-30 23:30:56 +01:00
37513f9411
don't read certificates if ownCloud is not installed
2015-08-30 19:00:03 +02:00
289e9130f3
make system root of key storage configurable
2015-08-30 19:00:03 +02:00
2b08659f7d
Restrict upgrades to explicit allowed version
...
version.php now contains the previous ownCloud version from which
upgrades are allowed. Any other upgrades will show a message that the
upgrade/downgrade is not supported.
2015-08-30 18:04:18 +02:00
acae208f2f
moved code to /lib/private/tempmanager.php
...
fix for unit test
some fixes
2015-08-29 16:59:02 +01:00
723f8c8f1b
Merge pull request #18620 from owncloud/add-public-interface-for-factory
...
Add a public interface for the language factory so apps can use it
2015-08-29 16:44:08 +02:00
6e210d960c
Merge pull request #18423 from owncloud/occ_encrypt_all
...
occ command line tool to encrypt all files
2015-08-28 20:44:55 +02:00
bd1215c1dd
Add a test for the interface
2015-08-28 12:08:54 +02:00
ab87274930
Use certificates that expire in 10 years
...
🙊 🙊 🙊
2015-08-27 22:23:08 +02:00
e51fe617d8
copy always file by file to encrypt/decrypt it if needed
2015-08-26 14:58:22 +02:00
8c08dd0ac2
occ tool to encrypt all files
2015-08-26 14:58:22 +02:00
534b2e407a
Merge pull request #17662 from owncloud/locking-db
...
Database backend for locking
2015-08-26 03:56:37 +02:00
f3561e2349
Explicitly specify status code 200 as response code
...
Potentially fixes https://github.com/owncloud/core/issues/17586
2015-08-25 18:07:40 +02:00
b3495a1dc9
Merge pull request #18482 from owncloud/encrypt-session-data
...
Add a session wrapper to encrypt the data before storing it on disk
2015-08-24 12:10:15 +02:00
40b1054530
Merge pull request #18254 from owncloud/mitigate-breach
...
Add mitigation against BREACH
2015-08-24 09:14:27 +02:00
6a3fb0d3b3
Handle failures gracefully, remove switch
2015-08-21 19:16:28 +02:00
36eef2ddab
Add a session wrapper to encrypt the data before storing it on disk
2015-08-21 17:59:23 +02:00
ac086a11c1
Merge pull request #18426 from owncloud/joblist-next-non-existing
...
handle non existing job classes in $jobList->getNext
2015-08-21 10:34:33 +02:00
5f5c3520c9
Merge pull request #18457 from owncloud/test-traits
...
Move common test logic to re-usable traits
2015-08-20 22:28:54 +01:00
24a2fff946
add test mountprovider logic to a trait
2015-08-20 16:39:32 +02:00
9573d7d60d
Merge pull request #18372 from owncloud/issue-18358-object-type-and-id-for-activities
...
Issue 18358 object type and id for activities
2015-08-20 15:53:36 +02:00
3dbfbdaf54
allow moving common test logic into traits
2015-08-20 15:17:14 +02:00
Joas Schilling
Lukas Reschke
Morris Jobke
Roeland Jago Douma
Robin Appelman
Bjoern Schiessle
Christoph Wurst
Christoph Wurst
Roeland Jago Douma
Björn Schießle
Julius Haertl
Felix Epp
Thomas Müller
Vincent Petry
Michael Grosser
Leon Klingele
Robin Appelman
Jörn Friedrich Dreyer
Joas Schilling
Arthur Schiwon
Thomas Müller
Arthur Schiwon
William Bargent
Thomas Pulzer
Johannes Ernst
Lukas Reschke
Christoph Wurst
Roeland Jago Douma
Joas Schilling
Torben Dannhauer
Bernhard Posselt
Robin McCorkell
Stefan Weil
Frank Karlitschek
v1r0x
Faruk Uzun
Robin McCorkell
Scrutinizer Auto-Fixer
Mitar
Christian Schnidrig
Individual IT Services
Phil Davis
Martin
