Commit Graph

10348 Commits

Author SHA1 Message Date
Lukas Reschke a55715d9ed Increase subnet matcher
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-12 10:36:24 +00:00
Morris Jobke 2814fc6442
Merge pull request #26264 from nextcloud/unified-search-node-19
[stable19] Handle limit offset and sorting in files search
2021-04-01 18:17:50 +02:00
Robin Appelman 9c046efd2d
use node search api for legacy file search endpoint
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-01 13:49:45 +02:00
Arthur Schiwon 85225cce0a gracefully handle deleteFromSelf when share is already gone
- handling race conditions

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-30 20:25:43 +00:00
John Molakvoæ (skjnldsv) c74a10ddb4 Catch invalid cache source storage path
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-24 11:07:34 +00:00
Robin Appelman 854697818c
handle ordering in folder search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-23 18:02:29 +01:00
Robin Appelman 245d3b2162
folder filtering in sql
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-23 18:02:26 +01:00
Robin Appelman d257108409
cleanup fileinfo creation
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-23 18:02:22 +01:00
Robin Appelman de65e8187b
handle limit and offset in folder file search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-23 18:02:19 +01:00
Robin Appelman b8d64d67fe
only require user to be set in a query that handles tags
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-23 18:02:15 +01:00
Robin Appelman 549db744dc
unify handling of Folder::search methods into "new" query objects
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-23 18:02:12 +01:00
Morris Jobke ceed64154f
Merge pull request #26148 from nextcloud/backport/26013/stable19
[stable19] Return the fileid from `copyFromCache` and use it instead of doing an extra query
2021-03-19 15:29:14 +01:00
Vincent Petry ecaa02678a
Update user share must use correct expiration validation
Updating a user or group share now uses the correct method for the
validation of the expiration date. Instead of using the one from links
it uses the one for internal shares.

To avoid future confusion, the method "validateExpirationDate" has been
renamed to "validateExpirationDateLink".

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-19 11:07:04 +01:00
Robin Appelman df77c7d37c
limit constructing of result objects in file search
even thought we currently have no proper way of limiting the search itself, we can at least limit the construction of the result objects.

this saves about 40% of the time spend in the search request in my local testing

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:23:16 +01:00
Morris Jobke f302616544
Merge pull request #26092 from nextcloud/backport/25722/stable19
[stable19] apply object store copy optimization when 'cross storage' copy is wit…
2021-03-17 20:09:11 +01:00
Robin Appelman 68fb72b028 remove explicit fclose from S3->writeStream
streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-17 09:36:15 +00:00
Robin Appelman 300c4dd6b8 verify that cache entry is valid
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:13 +00:00
Robin Appelman 53dcc7b1ca also implement for FailedCache and NullCache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:11 +00:00
Robin Appelman cc1a5d5ced use returned file id for object store copy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:09 +00:00
Robin Appelman 603ec9be0c add ICopyFromCache trait to expose existing implementation
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:06 +00:00
Robin Appelman b2903064c9
only use share cacheentry when available
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:27:00 +01:00
Robin Appelman 1d1d4de991
adjust tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:27:00 +01:00
Robin Appelman b9b2c6d2fa
fix search in nested jails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:27:00 +01:00
Robin Appelman 75a48fbc2a
fix cachjail searching for root
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:26:59 +01:00
Robin Appelman 564390e303
do cachejail search filtering in sql
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:26:59 +01:00
Robin Appelman b39f9fb2c9 apply object store copy optimization when 'cross storage' copy is within the same object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 16:16:38 +00:00
Roeland Jago Douma 23e3730a10
Merge pull request #25449 from nextcloud/backport/25393/stable19
[stable19] add repair job for unencoded group share uris
2021-02-17 21:05:16 +01:00
Arthur Schiwon 8315de942c
adjust applicable version
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 20:07:56 +01:00
Arthur Schiwon 1bb5314491
compatibility to Nc 19
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 17:26:18 +01:00
Arthur Schiwon 8f499b9c8a
add missing changes from backport source
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 17:25:41 +01:00
Roeland Jago Douma 68fa9a4f54
Merge pull request #25389 from nextcloud/backport/25302/stable19
[stable19] Use RFC-compliant URL encoding for cookies
2021-02-09 22:07:45 +01:00
Samuel 09f16281a2 revert(comment)
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 15:23:18 +00:00
Samuel d494c6650c revert(exception): keep throwing an exception for now
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 15:23:16 +00:00
Samuel 038def2328 fix(translation): replace static error message
as suggested by @kesselb in nextcloud/server#25490

Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 15:23:14 +00:00
Arthur Schiwon ec12ac058b show suggestion to clean up possible invalid shares later
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-02 20:48:43 +00:00
Arthur Schiwon fcf358e0df add repair job for unencoded calendars
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-02 20:48:39 +00:00
Marco Ziech c5d2ea84e6 Use RFC-compliant URL encoding for cookies
PHP 7.4.2 changed the way how cookies are decoded, applying RFC-compliant raw URL decoding. This leads to a conflict Nextcloud's own cookie encoding, breaking the remember-me function if the UID contains a space character.

Fixes #24438

Signed-off-by: Marco Ziech <marco@ziech.net>
2021-01-29 12:42:14 +00:00
Roeland Jago Douma 6fa08f38b3 The objectid is a string
This allows the query to use the index. Else it has to resort on
scanning all the rows.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-29 07:17:41 +00:00
blizzz a4c7a62394
Merge pull request #25121 from nextcloud/backport/25036/stable19
[stable19] respect DB restrictions on number of arguments in statements and queries
2021-01-28 12:27:52 +01:00
Joas Schilling 1de3cfd049 Don't log keys on checkSignature
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 21:28:32 +00:00
Arthur Schiwon b78ed6ea3f
CI satisfaction
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-15 00:53:48 +01:00
Arthur Schiwon 83b0b84c1f
DB: warn on parameter number constraints
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-15 00:53:37 +01:00
Julius Härtl 16850b940f Make sure to do priority app upgrades first
Otherwise those apps might not be loaded when the others app migrations
are running. The previous loading of authentication apps in the upgrade
step never worked as it just returns in maintenance mode

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-11 13:49:12 +00:00
Morris Jobke 57e165c244
Merge pull request #24593 from nextcloud/backport/23912/stable19
[stable19] use in objectstore copy
2021-01-07 13:28:38 +01:00
Julius Härtl 3f8024932a
Merge pull request #24962 from nextcloud/backport/24683/stable19
[stable19] [Fix #24682]: ensure federation cloud id is retruned if FN property not found
2021-01-07 09:41:40 +01:00
Julius Härtl d77b3345b2
Show unique displayname context in the sharing input
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-05 10:06:32 +01:00
Guillaume Virlet db048845ef [Fix #24682]: ensure federation cloud id is retruned if FN property not found
Signed-off-by: Guillaume Virlet <github@virlet.org>
2021-01-05 08:27:31 +00:00
Roeland Jago Douma 7d282a4e88 Avoid huge exception argument logging
In some cases it might happen that you have an argument that deep down
somewhere has an array with a lot of entries (think thousands). Now
before we would just happily print them all. Which would fill the log.

Now it will just print the first 5. And add a line that there are N
more.

If you are on debug level we will still print them all.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-29 10:46:54 +00:00
Roeland Jago Douma ae49423991 Actually set the TTL on redis set
Else well the keys remain for ever and ever.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-21 13:53:42 +00:00
Robin Appelman dedff0facb use in objectstore copy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-12-07 16:07:25 +00:00