Commit Graph

24194 Commits

Author SHA1 Message Date
Julius Härtl 895e6a57b9
Merge pull request #25805 from nextcloud/bugfix/23468/clear-share-after-select
Clear multiselect after selection in share panel
2021-03-03 17:25:31 +01:00
Roeland Jago Douma 0829fea5e7
Merge pull request #25896 from nextcloud/techdept/qbmapper
Move DirectMapper to QBMapper
2021-03-03 14:58:51 +01:00
Roeland Jago Douma 68ec18323d Fix types in the Group Manager
Psalm found an issue. However the issue found was because of lying
docblocks. Fixed those and did some typing to make it all better.

For #25839

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 14:52:47 +01:00
Julius Härtl 930b40bd8a
Remove trash items from other trash backends when deleting all
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-03 14:26:35 +01:00
Roeland Jago Douma b87e54bb1c
Merge pull request #25902 from nextcloud/techdept/psalm/loggerinterface/part2
LoggerInterface for provisioning API Controllers
2021-03-03 12:53:15 +01:00
Roeland Jago Douma ee7702e5f0 Move DirectMapper to QBMapper
Mapper has been deprecated for some time now.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 12:35:14 +01:00
Vincent Petry c541094be0 Clear multiselect after selection in share panel
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-03 11:38:00 +01:00
Roeland Jago Douma f492a6aac3 Move group activities to events
Use the fancy events.
Nicer code
Nicely isolated code

win-win

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 11:33:33 +01:00
Roeland Jago Douma ce430c3613
Merge pull request #25892 from nextcloud/techdept/initialstate/part1
Move some settings over to the IInitialState
2021-03-03 11:08:42 +01:00
Roeland Jago Douma a1be5f33af
Merge pull request #25895 from nextcloud/techdept/psalm/pimp_sharingcheckmiddleware
Pimp sharingcheckmiddleware
2021-03-03 10:28:32 +01:00
Roeland Jago Douma ed772cd889
Merge pull request #25818 from nextcloud/dependabot/npm_and_yarn/lodash-4.17.21
Bump lodash from 4.17.20 to 4.17.21
2021-03-03 08:39:21 +01:00
Nextcloud bot e11be3b693
[tx-robot] updated from transifex 2021-03-03 02:21:24 +00:00
Roeland Jago Douma dc7eb2bd85 LoggerInterface for provisioning API Controllers
Sweep swoop swaap swuup
away with the deprecated stuff

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 21:46:51 +01:00
blizzz ef5389603c
Merge pull request #25860 from nextcloud/fix/noid/ldap-bind-expired
do not die after LDAP auth failed with expired acc
2021-03-02 21:34:03 +01:00
Roeland Jago Douma bc961baa40 Move some settings over to the IInitialState
The old one has been deprecated. Part one of many.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 21:11:56 +01:00
dependabot-preview[bot] 7d279f8527 Bump lodash from 4.17.20 to 4.17.21
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.20...4.17.21)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-02 20:51:19 +01:00
Roeland Jago Douma 5c952e83fc Pimp sharingcheckmiddleware
Reported by psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 20:36:04 +01:00
Roeland Jago Douma 04dc321ee7
Merge pull request #25884 from nextcloud/techdept/psalm/no_cast
Remove redundant casts
2021-03-02 18:52:44 +01:00
Roeland Jago Douma 19e2136963 Update autoloader files
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 16:36:21 +01:00
Roeland Jago Douma 4f37e0ce55 Remove redundant casts
For #25839

In short with the connection adapter we now have the function is typed
to int (and casts itself). So it is not needed anymore.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 16:32:13 +01:00
Roeland Jago Douma c40228a65a Fix the SharesPlugin
Another attempt to fix all the typing and handling in the sharesplugin.
In short we should probably have a lot more type hinting in several
places.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 16:29:06 +01:00
Roeland Jago Douma 2afa1c5739
Merge pull request #25862 from nextcloud/techdept/psalm/some_loggers
Move away some ILoggers
2021-03-02 15:01:44 +01:00
Robin Appelman a2ecac7197
Merge pull request #25568 from nextcloud/move-storage-disable-cache
disable trasbin during the moveFromStorage fallback
2021-03-02 13:23:58 +00:00
Julius Härtl cfa2d22f4e
Merge pull request #25797 from nextcloud/bugfix/noid/templates-fileactions
Do not trigger a full filelist reload after creating a new file from a template
2021-03-02 14:15:19 +01:00
Lukas Reschke 41dc18342f
Merge pull request #25854 from nextcloud/techdept/psalm/checksetupcontroller
Fix lying docblocks
2021-03-02 13:33:21 +01:00
Roeland Jago Douma 38f761f25f Move away some ILoggers
Makes psalm happier

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 10:47:25 +01:00
Julius Härtl 1d5ee0324e
Bump bundles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-02 10:46:48 +01:00
Julius Härtl 14c872a96a
At least try to give the full context for the file action
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-02 10:46:48 +01:00
Julius Härtl f3a8b0ac88
Do not trigger a full filelist reload after creating a new file
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-02 10:46:48 +01:00
Julius Härtl 20094af7f9
Merge pull request #25670 from nextcloud/enh/psalm/redundantcasts
Fix a few RedundantCast
2021-03-02 10:46:00 +01:00
dependabot-preview[bot] e4cc176e00
Merge pull request #25821 from nextcloud/dependabot/npm_and_yarn/babel/core-7.13.8 2021-03-02 08:13:02 +00:00
Christoph Wurst 7be2ce82e7
Merge pull request #25544 from nextcloud/refactor/app-password-created-event
Move app_password_created to a typed event
2021-03-02 08:18:59 +01:00
Nextcloud bot 63f68e0412
[tx-robot] updated from transifex 2021-03-02 02:22:18 +00:00
dependabot-preview[bot] b486e26b81 Bump @babel/core from 7.12.16 to 7.13.8
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.12.16 to 7.13.8.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.13.8/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-01 21:30:34 +00:00
Arthur Schiwon 5ad08c7c84
do not die after LDAP auth failed with expired acc
- some servers return error code 53

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-01 19:20:05 +01:00
Roeland Jago Douma e28173863e Card::getOwner should return the actual value
I guess we never call this at runtime or it would already ahve done boom
very loudly.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 16:51:36 +01:00
Roeland Jago Douma 3d0dff0d2b Fix lying docblocks
* typed the return
* removed unneeded temp variable

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 16:48:04 +01:00
Johannes Leuker 2796ef80ff Show group backends in occ group:list --info and group:info
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-01 16:02:08 +01:00
Roeland Jago Douma 5cd1880daa Fix a few RedundantCast
Reported by psalm
For #25641

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 16:00:32 +01:00
blizzz 9cd39b0b8c
Merge pull request #25757 from nextcloud/fix/noid/ldap-cyclic-group-memberships
fix detecting cyclic group memberships
2021-03-01 12:07:59 +01:00
John Molakvoæ cc7f4ab1ea
Merge pull request #25803 from nextcloud/bugfix/25364/make-compatible-app-message-less-confusing
Make the compatible app message less confusing for multi versions apps
2021-03-01 10:37:13 +01:00
Nextcloud bot 9a90bfba32
[tx-robot] updated from transifex 2021-03-01 02:20:19 +00:00
Nextcloud bot 24d5afb1b1
[tx-robot] updated from transifex 2021-02-28 02:19:54 +00:00
Nextcloud bot 65b0511d79
[tx-robot] updated from transifex 2021-02-27 02:22:23 +00:00
Joas Schilling 4807ce3b08 Make the compatible app message less confusing for multi versions apps
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-26 10:56:35 +00:00
Vincent Petry 53b162bad9
Fix focus-visible outline for files checkboxes
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-02-26 10:15:21 +01:00
Nextcloud bot b4ccadea2b
[tx-robot] updated from transifex 2021-02-26 02:21:45 +00:00
kesselb c663cbe666
Merge pull request #25778 from noiob/patch-1
Remove double space in sharebymail SettingsManager
2021-02-25 19:31:34 +01:00
Nextcloud bot c8f7a808fd
[tx-robot] updated from transifex 2021-02-25 02:21:21 +00:00
noiob f28ee36e20 Remove double space so php-cs stops complaining
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-02-24 11:33:19 +01:00
Nextcloud bot b89fbaf52d
[tx-robot] updated from transifex 2021-02-24 02:22:06 +00:00
Arthur Schiwon 4d33449faa
fix detecting cyclic group memberships
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-23 22:50:43 +01:00
Nextcloud bot ff54a0481b
[tx-robot] updated from transifex 2021-02-23 02:39:25 +00:00
John Molakvoæ 1eca8d21ee
Merge pull request #25602 from nextcloud/bugfix/noid/only-create-share-once
Avoid creating two share links when password is enforced
2021-02-22 12:08:49 +01:00
Vincent Petry f321538c9b
Merge pull request #25689 from nextcloud/bugfix/noid/disable-updater-ui-when-disabled
Hide update channel + button when web update is disabled
2021-02-22 09:29:56 +01:00
Nextcloud bot 3ff92423e2
[tx-robot] updated from transifex 2021-02-21 02:39:59 +00:00
Nextcloud bot ac2577a594
[tx-robot] updated from transifex 2021-02-20 02:37:22 +00:00
Julius Härtl 9073c09c62 Avoid creating two share links when password is enforced
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-19 11:16:38 +00:00
John Molakvoæ 946430862e
Merge pull request #24978 from dems54/issue24139 2021-02-19 08:20:58 +01:00
Nextcloud bot c222bac9ed
[tx-robot] updated from transifex 2021-02-19 02:20:56 +00:00
dependabot-preview[bot] eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +01:00
Vincent Petry 6ce469132c
Hide updater button when web updater is disabled
Whenever the web updater is disabled, the updater button and its
matching token requesting endpoints are disabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-02-18 08:53:57 +01:00
Nextcloud bot 5f194dad24
[tx-robot] updated from transifex 2021-02-18 02:21:54 +00:00
Roeland Jago Douma 00d1a58a09
Merge pull request #25681 from nextcloud/techdebt/noid/cleanup-provisioning
Cleanup appinfo usage
2021-02-17 21:16:09 +01:00
Robin Appelman b5db4502d0
disable trasbin during the moveFromStorage fallback
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-17 16:08:57 +01:00
Roeland Jago Douma ff1c5c4e25 Move getChangesForAddressBook to QueryBuilder
Makes psalm happy, and makes me happy.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-17 09:06:00 +01:00
Roeland Jago Douma 644e6df02e
Merge pull request #25440 from nextcloud/bugfix/noid/cache-the-user-backend-info-for-30s
Cache the user backend info for 5mins
2021-02-17 08:56:55 +01:00
Nextcloud bot 57212a99f9
[tx-robot] updated from transifex 2021-02-17 02:21:05 +00:00
Joas Schilling 89d2eaca0a
Cleanup appinfo usage
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-16 15:51:25 +01:00
Roeland Jago Douma 2ea3cb7c93 Drop redundant indes
Those indexes are already covered by others. So those can just be used.
THose extra indexes just take up space.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-16 11:38:43 +01:00
Christoph Wurst a649dff179
Merge pull request #25669 from nextcloud/fix/psalm/encryptall
Harden EncryptAll check for empty email
2021-02-16 08:16:19 +01:00
Nextcloud bot 45d36ec2b2
[tx-robot] updated from transifex 2021-02-16 02:21:36 +00:00
Roeland Jago Douma 918af40f05 Harden EncryptAll check for empty email
Reported by psalm
For #25641

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 22:28:28 +01:00
Roeland Jago Douma df4c2508d6 Fix some RedundantCast in dav code
For #25641

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 20:50:28 +01:00
Roeland Jago Douma a61c3705f8
Merge pull request #25655 from nextcloud/bugfix/noid/dark-mode-applist-icons
Fix app icon list in dark mode
2021-02-15 20:34:56 +01:00
kesselb a33803a31b
Merge pull request #25653 from nextcloud/fix/psalm/offlineuser
Some psalm OfflineUser fixes
2021-02-15 17:04:16 +01:00
Roeland Jago Douma 9fd72b0d3a
Merge pull request #25595 from nextcloud/enh/caldavbackend/getChangesForCalendar_querybuilder
Move getChangesForCalendar to QueryBuilder
2021-02-15 16:39:46 +01:00
Joas Schilling f83de9d194
Fix app icon list in dark mode
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-15 16:26:30 +01:00
Roeland Jago Douma 3f4ece256e Some psalm OfflineUser fixes
For #25641

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 13:36:02 +01:00
Roeland Jago Douma 9929adde08
Merge pull request #25594 from wankdanker/files_sharing_owner_display_name
Use ownerDisplayName for SharingEntry Tooltip
2021-02-15 13:17:25 +01:00
Christoph Wurst 797527e5ea
Merge pull request #25578 from nextcloud/enh/simplify_weatherservice
Always use the cache
2021-02-15 12:27:03 +01:00
Christoph Wurst 5faa34abb1
Merge pull request #25625 from nextcloud/enh/psalm/substr
Check substr results
2021-02-15 12:17:57 +01:00
Roeland Jago Douma b0f205f97c Move getChangesForCalendar to QueryBuilder
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 12:07:26 +01:00
Christoph Wurst 65465b5abc
Merge pull request #25636 from nextcloud/fix/psalm/closure_return_types
Add some closure return types
2021-02-15 12:07:24 +01:00
Joas Schilling 645f83121e
Cache the user backend info for 300s
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-15 10:36:08 +01:00
Roeland Jago Douma 507d5cf8ad Check substr results
Else this might lead to unexpeted errors.
Found by psalm.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 10:07:13 +01:00
Roeland Jago Douma bd8b1786c5 Some psalm fixes in the settings app
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 10:00:35 +01:00
Roeland Jago Douma 84de7a8d63
Merge pull request #25580 from nextcloud/enh/fix/psalm_pluginmanager
Enhancing the dav pluginmanager
2021-02-15 09:11:16 +01:00
Nextcloud bot b418a680e7
[tx-robot] updated from transifex 2021-02-15 02:20:11 +00:00
Roeland Jago Douma d2569eed58 Fix PluginManager annotation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-14 12:46:50 +01:00
Roeland Jago Douma e62790cfe2 Add some closure return types
Found by psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-14 12:43:31 +01:00
Roeland Jago Douma 19f7476f77 Use correct namespace (casing) in CalendarHome
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-14 12:36:41 +01:00
Nextcloud bot 65cd62e875
[tx-robot] updated from transifex 2021-02-14 02:20:02 +00:00
Roeland Jago Douma 7d8e9baa77
Revert "use the configured forwarded headers for the setup check" 2021-02-13 18:03:32 +01:00
dependabot-preview[bot] d04f8a8b53
Merge pull request #25619 from nextcloud/dependabot/npm_and_yarn/moment-timezone-0.5.33 2021-02-13 14:18:56 +00:00
Roeland Jago Douma 3b8cf10a8a
Merge pull request #25604 from nextcloud/bugfix/noid/fix-hover-background-for-dark-mode
Fix hover background for dark mode
2021-02-13 15:01:57 +01:00
Roeland Jago Douma ae4e47cbe7
Merge pull request #25608 from nextcloud/trusted-proxy-check-correct-header
use the configured forwarded headers for the setup check
2021-02-13 14:58:26 +01:00
dependabot-preview[bot] 0d597d0707 Bump moment-timezone from 0.5.32 to 0.5.33
Bumps [moment-timezone](https://github.com/moment/moment-timezone) from 0.5.32 to 0.5.33.
- [Release notes](https://github.com/moment/moment-timezone/releases)
- [Changelog](https://github.com/moment/moment-timezone/blob/develop/changelog.md)
- [Commits](https://github.com/moment/moment-timezone/compare/0.5.32...0.5.33)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-13 13:35:27 +00:00
Nextcloud bot 69f0d7d5d4
[tx-robot] updated from transifex 2021-02-13 02:20:27 +00:00
Robin Appelman f824f273b6
add event for when a direct download is triggered
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-12 17:33:12 +01:00