847ed37afc
do not use private AccountManager in UsersController
...
- extends IAccountProperty for verificationData getters and setters
- implementation thereof ^
- and of course adaption of UsersController
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-25 14:35:38 +02:00
f1dbabd910
Merge pull request #26727 from nextcloud/group-exclude-link-share
...
Add option to exclude groups from creating link shares
2021-05-21 15:35:39 +02:00
4a2775a442
Harden apptoken check
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-17 16:05:45 +02:00
b8b2e796bf
Merge pull request #26959 from nextcloud/techdebt/noid/verifiyuserdata-iaccountmanager
...
VerifyUserData shall use IAccountManager, not private API
2021-05-12 23:35:39 +02:00
9977027321
VerifyUserData shall use IAccountManager, not private API
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 22:57:20 +02:00
a49588bbe5
PersonalInfo settings to use public AccoutManager API
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 22:55:34 +02:00
0e6321957d
allow excluding groups from creating link shares
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:11:31 +02:00
aa651fd629
Merge pull request #26259 from nextcloud/feature/noid/validate-website-to-be-valid
...
Validate the website field input to be a valid URL
2021-04-26 13:56:01 +02:00
67dd087ce4
Fix deleting properties of user settings when not given explicitly
...
The controller can receive an optional subset of the properties of the
user settings; values not given are set to "null" by default. However,
those null values overwrote the previously existing values, so in
practice any value not given was deleted from the user settings. Now
only non null values overwrite the previous values.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
ac0c18327e
Fix TypeError when "email" is not given in the controller request
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
a7431817b9
Respect additional user settings not covered by the controller
...
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.
Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).
This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
8cae515daa
Use constants from interface rather than class
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +02:00
d80cc76ee7
Validate the website field input to be a valid URL
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 16:34:13 +02:00
3e7f7e5f9b
Merge pull request #26474 from nextcloud/caugner-patch-mariadb-in-mysql-support-warning
...
Mention MariaDB in MySQL support warning
2021-04-21 16:26:37 +02:00
af61486aea
Separate settings for remote share expiration
...
Added separate settings for default and enforced expiration date for
remote shares.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +02:00
17963ea089
Mention MariaDB in MySQL support warning
2021-04-09 12:31:16 +02:00
bd2e6309b5
Merge pull request #25605 from nextcloud/trusted-proxy-warning-localhost
...
dont show trusted proxy warning when the proxy and remote are both localhost
2021-04-01 13:27:26 +02:00
5d14fd4396
Make extra user profile fields always editable
...
The fields for phone number, address, website and twitter are now
editable regardless whether federated sharing and the lookup server
are enabled or not.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +01:00
278a73789e
Map old account scope properties to new names
...
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +01:00
61ed57b757
Rename some parameters and methods to make the API more clear
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 20:30:29 +01:00
07095fd122
Also clear the knownUser when changing via the settings endpoint
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 19:37:10 +01:00
5b53b6f977
Add a setting to restrict returning a full match unless in phonebook or same group
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:25:57 +01:00
b71268e38b
Add a config setting to restrict autocompletion to phonebook matches
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:55 +01:00
e44be839bb
Fix some types in the Settings Personal pages
...
* Fix types
* Typed the code
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 11:05:41 +01:00
f92d21e80e
Merge pull request #25870 from nextcloud/techdept/settings/move_group_activity_events
...
Move group activities to events
2021-03-05 13:05:06 +01:00
f492a6aac3
Move group activities to events
...
Use the fancy events.
Nicer code
Nicely isolated code
win-win
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 11:33:33 +01:00
bc961baa40
Move some settings over to the IInitialState
...
The old one has been deprecated. Part one of many.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 21:11:56 +01:00
2afa1c5739
Merge pull request #25862 from nextcloud/techdept/psalm/some_loggers
...
Move away some ILoggers
2021-03-02 15:01:44 +01:00
41dc18342f
Merge pull request #25854 from nextcloud/techdept/psalm/checksetupcontroller
...
Fix lying docblocks
2021-03-02 13:33:21 +01:00
38f761f25f
Move away some ILoggers
...
Makes psalm happier
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 10:47:25 +01:00
7be2ce82e7
Merge pull request #25544 from nextcloud/refactor/app-password-created-event
...
Move app_password_created to a typed event
2021-03-02 08:18:59 +01:00
3d0dff0d2b
Fix lying docblocks
...
* typed the return
* removed unneeded temp variable
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 16:48:04 +01:00
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
...
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard ) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases )
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +01:00
bd8b1786c5
Some psalm fixes in the settings app
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 10:00:35 +01:00
7d8e9baa77
Revert "use the configured forwarded headers for the setup check"
2021-02-13 18:03:32 +01:00
01118a2218
use the configured forwarded headers for the setup check
...
instead of always checking against the same header
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-12 14:22:27 +01:00
cc0cc68c8d
dont show trusted proxy warning when the proxy and remote are both localhost
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-12 13:32:51 +01:00
f8808e260d
Move app_password_created to a typed event
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 18:49:35 +01:00
378f116a63
Do not show 2FA settings if the user has no providers available
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-22 13:55:22 +01:00
c1d4f8161b
Migrate internal classes to the OCP db col types
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 14:09:13 +01:00
eeac11a687
Fix casing of MySQLPlatform class name
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-01-12 09:39:59 +01:00
6c8f2dc7bc
Merge pull request #25016 from nextcloud/enh/noid/add-check-for-unsupported-db
...
Add setup check to verify that the used DB version is still supported…
2021-01-11 14:21:42 +01:00
24d436cb60
Remove unneeded casts that were found by Psalm
...
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521 )
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-11 13:14:41 +01:00
bffa61fc32
Add setup check to verify that the used DB version is still supported in the next major release
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-08 13:38:32 +01:00
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +01:00
068e3b2c1e
Set the user language when adding the footer
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-07 15:31:55 +01:00
abfb72378f
Hide client link in welcome mail if an empty customclient_desktop config is set
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-07 10:45:54 +01:00
90d0732828
Fix updating user settings
...
The requests dispatched from the personal settings page don't always
send all the possible params but just a subset. Hence requests currently
fail on master e.g. when you update your email. This makes the arguments
optional again.
Regression of da9462b482
2021-01-05 12:59:50 +01:00
9ce3ea3368
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-30 14:07:05 +01:00
adc4f1a811
Merge pull request #22916 from J0WI/unifiy-links-to-php.net
...
Unify links to php.net
2020-12-22 09:53:31 +01:00
Arthur Schiwon
Morris Jobke
Roeland Jago Douma
Robin Appelman
Joas Schilling
Daniel Calviño Sánchez
Joas Schilling
Vincent Petry
Claas Augner
Roeland Jago Douma
Lukas Reschke
Christoph Wurst
dependabot-preview[bot]
Christoph Wurst
Julius Härtl