Commit Graph

24663 Commits

Author SHA1 Message Date
Nextcloud bot ea05e1a6ae
[tx-robot] updated from transifex 2021-05-03 02:25:36 +00:00
Nextcloud bot a5faa98e6e
[tx-robot] updated from transifex 2021-05-02 02:25:23 +00:00
Nextcloud bot 5cccbbdd45
[tx-robot] updated from transifex 2021-05-01 02:26:34 +00:00
Arthur Schiwon a9f39aab29
fix creating vcards with multiple string values
Internally it is valid to provide multiple values for a property as
plain string. An exampe is given in the PhpDoc of
AddressBookImpl::search().

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-30 21:36:05 +02:00
Nextcloud bot f3baab3159
[tx-robot] updated from transifex 2021-04-30 02:27:46 +00:00
Morris Jobke 22ba8fa78d
Merge pull request #26826 from nextcloud/refactor/dav-typed-calendar-deleted-events
Exclusively use the typed calendar deletion events for DAV
2021-04-29 16:14:10 +02:00
Christoph Wurst 63eb3694e4
Exclusively use the typed calendar deletion events for DAV
We had both in places, but the old one isn't used anywhere outside this
app, so it's time to migrate the code.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-29 15:31:19 +02:00
dependabot-preview[bot] fdf54e9e43
Merge pull request #26736 from nextcloud/dependabot/npm_and_yarn/babel/core-7.13.16 2021-04-29 07:15:26 +00:00
Nextcloud bot e0f700b1bd
[tx-robot] updated from transifex 2021-04-29 02:26:26 +00:00
Morris Jobke b971f69e26
Merge pull request #26461 from nextcloud/bugfix/noid/only-return-editable-displayname-field-when-allowed-by-backend
Only return display name as editable when the user backend allows it
2021-04-28 20:27:40 +02:00
dependabot-preview[bot] c9b6f42c1a Bump @babel/core from 7.13.15 to 7.13.16
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.13.15 to 7.13.16.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.13.16/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-04-28 12:47:31 +00:00
Roeland Jago Douma 758a662b23 Do not try to contact lookup server if not needed
In some cases (for example you never send data to the lookup server)
there is no need for this job to even try.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-28 14:27:46 +02:00
rakekniven 48f05158e5
Merge pull request #26784 from nextcloud/Valdnet-patch-8
l10n: Change to a capital letter
2021-04-28 10:11:32 +02:00
Valdnet c79aba9865
Change size of the letter in test 2021-04-28 08:57:53 +02:00
Nextcloud bot be4f665d2d
[tx-robot] updated from transifex 2021-04-28 02:25:44 +00:00
kesselb 9658bc9dd0
Merge pull request #26785 from nextcloud/fix/noid/ldap-beyond-last-page
LDAP: do not bother to search after the last page
2021-04-27 19:38:18 +02:00
Joas Schilling 0e6e80aaec
Merge pull request #26781 from nextcloud/bugfix/noid/more-auto-add-cleanup
More cleaning after auto-add removal
2021-04-27 15:56:17 +02:00
Joas Schilling 03b467bd23
Also check implementsAction method
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 15:28:02 +02:00
Joas Schilling f67a10e8d0
Only return display name as editable when the user backend allows it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 15:01:30 +02:00
Joas Schilling df47445c01
Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +02:00
Arthur Schiwon 2a5473e146
do not try to search after the last page
- saves an LDAP requests in these cases
- prevents a Protocol Error logged on < 7.3 API (for backports)

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-27 12:52:26 +02:00
Valdnet 505863c55e
l10n: Change to a capital letter
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-27 12:38:28 +02:00
Julius Härtl 9de6efd14e
Merge pull request #26774 from nextcloud/techdebt/noid/ldap-remove-pre73-paged-results 2021-04-27 07:00:28 -01:00
Joas Schilling 1029abc8f6
More cleaning after auto-add removal
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 08:13:47 +02:00
Joas Schilling 3f0b7fd289
Merge pull request #26765 from nextcloud/td/no_more_add_auto_trusted
No longer add trusted servers on federated share creation
2021-04-27 08:06:59 +02:00
John Molakvoæ b8cde2c8b6
Merge pull request #26775 from robottod/patch-1
Remove some deprecated calls from ShareByMailProvider.php
2021-04-27 07:59:27 +02:00
Nextcloud bot 2aad4bbed6
[tx-robot] updated from transifex 2021-04-27 02:25:33 +00:00
Arthur Schiwon 5e8f43a55e
removes PagedResults adapter for PHP < 7.3
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-26 22:57:42 +02:00
robottod 0451927994
Remove some deprecated calls from ShareByMailProvider.php
This moves the execute calls to the executeQuery and executeUpdate calls
Resulting in less calls to deprecated functions

Signed-off-by: rtod <robottod@protonmail.com>
2021-04-26 21:53:56 +02:00
Roeland Jago Douma 71e05b1fd3 No longer add trusted servers on federated share creation
It was disabled by default for ages. And often resulted in unwanted
behavior. If admins want trusted servers they just have to do it
manually.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-26 19:47:55 +02:00
Roeland Jago Douma 70f12e7332 Improve federated permission handling
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-26 16:10:44 +02:00
Joas Schilling aa651fd629
Merge pull request #26259 from nextcloud/feature/noid/validate-website-to-be-valid
Validate the website field input to be a valid URL
2021-04-26 13:56:01 +02:00
Chih-Hsuan Yen fea5b4a8b9
Correctly truncate multibyte strings to fit into the database
Closes: #26174

Signed-off-by: Chih-Hsuan Yen <yan12125@gmail.com>
2021-04-26 16:54:50 +08:00
Nextcloud bot 4ded8a08b7
[tx-robot] updated from transifex 2021-04-26 02:24:39 +00:00
Nextcloud bot da17db0fdc
[tx-robot] updated from transifex 2021-04-25 02:24:52 +00:00
Nextcloud bot 39764b05b1
[tx-robot] updated from transifex 2021-04-24 02:26:38 +00:00
Daniel Calviño Sánchez 8fc8451004
Merge pull request #25417 from nextcloud/fix-account-data-visibility-after-disabling-public-addressbook-upload
Fix account data visibility after disabling public addressbook upload
2021-04-23 16:48:36 +02:00
Christoph Wurst 323f95693c
Close open cursors
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-23 14:35:02 +02:00
Christoph Wurst 72a4f21efe
Use the new executeQuery and executeUpdate methods
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-23 13:21:25 +02:00
Christoph Wurst 94bf14a8dc
Drop default fetch mode parameter
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-23 13:21:25 +02:00
Daniel Calviño Sánchez da84ed7d4c Fix active scope not visible in the menu if excluded
Depending on some settings (for example, if lookup server upload is
disabled) some items can be hidden in the scope menu. However, if the
user selected an scope in the past once the settings were changed the
scope was no longer visible in the menu. Now the active scope will be
always visible in the menu, although if it is an excluded scope it will
be disabled. Selecting any other scope will then hide the excluded and
no longer active one.

When upload to the lookup server is disabled the scope menu was hidden
for display name and email in the personal information settings; now the
menu will be always shown to enable the above described behaviour.

Note that the menu will be shown even if there is a single available
scope so the user can read its description.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:42 +02:00
Daniel Calviño Sánchez 67dd087ce4 Fix deleting properties of user settings when not given explicitly
The controller can receive an optional subset of the properties of the
user settings; values not given are set to "null" by default. However,
those null values overwrote the previously existing values, so in
practice any value not given was deleted from the user settings. Now
only non null values overwrite the previous values.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez ac0c18327e Fix TypeError when "email" is not given in the controller request
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez a7431817b9 Respect additional user settings not covered by the controller
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.

Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).

This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez c5e3d2e5c2 Add more unit tests for setting user settings
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez 190ffd75b7 Change default test data to values less similar to empty values
Right now it makes no difference, but this should make future tests
clearer, specially in case of failure.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +02:00
Daniel Calviño Sánchez ef5d538448 Extract default test data to a helper getter
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +02:00
Daniel Calviño Sánchez 8cae515daa Use constants from interface rather than class
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +02:00
Christoph Wurst 1722044992
Only set copy etag if the destination source can be found
The etag is only set for files, but it's also possible that in edge
cases the copy destination node can't be found. In that case we don't
need to set any etag.

Required for #26083

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-23 10:53:24 +02:00
Nextcloud bot 539c065e8e
[tx-robot] updated from transifex 2021-04-23 02:26:10 +00:00
blizzz 6d25c3c7fe
Merge pull request #26627 from nextcloud/smb-341
update icewind/smb to 3.4.1
2021-04-22 19:58:02 +02:00
Joas Schilling d80cc76ee7
Validate the website field input to be a valid URL
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 16:34:13 +02:00
Joas Schilling da043e52c8
Merge pull request #26586 from nextcloud/bugfix/noid/handle-device-login-like-an-alternative-login
Handle device login like an alternative login
2021-04-22 15:27:58 +02:00
Nextcloud bot 634b6b8b57
[tx-robot] updated from transifex 2021-04-22 02:26:21 +00:00
Roeland Jago Douma 4e39d1ce93
Merge pull request #26609 from nextcloud/Valdnet-patch-6
l10n: Improve styling
2021-04-21 19:56:41 +02:00
John Molakvoæ 3da956bcdc
Merge pull request #23529 from Simounet/feat/23397-settings-new-user-modal
Settings: new user row replaced by a modal
2021-04-21 16:38:46 +02:00
Morris Jobke 3e7f7e5f9b
Merge pull request #26474 from nextcloud/caugner-patch-mariadb-in-mysql-support-warning
Mention MariaDB in MySQL support warning
2021-04-21 16:26:37 +02:00
Robin Appelman effb7dc8ba
set mimetype for objects uploaded to object storages
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-21 15:25:58 +02:00
Simounet 45c3b2a478
Settings: new user row replaced by a modal
Signed-off-by: Simounet <contact@simounet.net>
2021-04-21 14:42:46 +02:00
Robin Appelman 907e997c99
optimize getting share types for recent files
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-21 13:56:11 +02:00
Roeland Jago Douma a384cb4e5a
Merge pull request #26648 from nextcloud/Valdnet-patch-7
l10n: Spelling unification
2021-04-21 11:15:54 +02:00
Nextcloud bot e58344fb2a
[tx-robot] updated from transifex 2021-04-21 02:25:58 +00:00
Morris Jobke 5448306238
Merge pull request #26658 from nextcloud/bugfix/noid/continue-on-denied-acls
Do not stop directory listing when ACL is blocking access
2021-04-20 21:35:19 +02:00
Morris Jobke ea0f022816
Merge pull request #26661 from nextcloud/bugfix/noid/fix-ldap-unit-test
Fix LDAP unit tests
2021-04-20 21:34:21 +02:00
Morris Jobke 6c0bb2c338
Merge pull request #26594 from nextcloud/enh/2fa/bootstrap
Move 2FA registration to IBootstrap
2021-04-20 21:30:15 +02:00
Morris Jobke 25406ebba2
Merge pull request #26652 from nextcloud/bugfix/noid/fix-broken-test
Fix broken Expiration test
2021-04-20 21:28:36 +02:00
Roeland Jago Douma a34085e1a2 Move 2fa backupscode to new registration
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 21:01:16 +02:00
Roeland Jago Douma 85bdf6c0fc
Merge pull request #26660 from nextcloud/bugfix/noid/fix-twofactor-backupcodes-tests
Fix twofactor backup code tests
2021-04-20 20:44:33 +02:00
Roeland Jago Douma d34d3d168d
Merge pull request #26659 from nextcloud/bugfix/noid/fix-updatenotification-test
Fix update notification tests
2021-04-20 20:43:56 +02:00
Joas Schilling 379664974c
Fix DAV unit tests
6) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAccept
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

7) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptSequence
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

8) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptRecurrenceId
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

9) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptTokenNotFound
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

10) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptExpiredToken
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

11) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testDecline
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

12) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testProcessMoreOptionsResult
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

13) OCA\DAV\Tests\unit\CalDAV\CalendarTest::testConfidentialClassification with data set #0 (3, false)
No method rule is set

14) OCA\DAV\Tests\unit\DAV\Migration\RefreshWebcalJobRegistrarTest::testRun
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:30:21 +02:00
Joas Schilling 39e248d330
Fix LDAP unit tests
20) OCA\user_ldap\tests\Jobs\UpdateGroupsTest::testHandleKnownGroups
Trying to configure method "fetchAll" which cannot be configured because it does not exist, has not been specified, is final, or is static

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:22:52 +02:00
Joas Schilling fe8d98f84b
Fix twofactor backup code tests
16) OCA\TwoFactorBackupCodes\Tests\Unit\Listener\ActivityPublisherTest::testHandleCodesGeneratedEvent
Method publish may not return value of type Mock_IEvent_11bf8381, its return declaration is ": void"

17) OCA\TwoFactorBackupCodes\Tests\Unit\Controller\SettingsControllerTest::testCreateCodes
Method getBackupCodesState may not return value of type string, its return declaration is ": array"

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:18:15 +02:00
Julius Härtl 8f01bc65f1
Continue iterating over diretory contents and just hide file if denied by acl
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-20 17:17:09 +02:00
Joas Schilling 42140ab53f
Fix update notification tests
18) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #1 ('app2', '1.0.1', '1.0.0', '1.0.0', true, array('user1'), array(array('user1')))
Method notify may not return value of type Mock_INotification_2134ee38, its return declaration is ": void"

19) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #2 ('app3', '1.0.1', false, false, true, array('user2', 'user3'), array(array('user2'), array('user3')))
Method notify may not return value of type Mock_INotification_2134ee38, its return declaration is ": void"

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:15:31 +02:00
Joas Schilling fc6fbb6499
Fix broken Expiration test
15) Warning
The data provider specified for OCA\Files_Trashbin\Tests\ExpirationTest::testGetMaxAgeAsTimestamp is invalid.
PHPUnit\Util\Exception: Method timestampTestData does not exist

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:53:00 +02:00
Jan C. Borchardt 9d1e2c5082
Merge pull request #26548 from nextcloud/design/files-accessibility
Files & Core accessibility fixes
2021-04-20 13:51:40 +02:00
Valdnet a923761acb
l10n: Spelling unification
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-20 11:33:31 +02:00
Morris Jobke 67ab4dd6c7
Merge pull request #26624 from nextcloud/enh/sharing/readperm
Consider read permission in sharing tab
2021-04-20 09:27:45 +02:00
Joas Schilling 69290781ff Handle device login like an alternative login
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 09:11:33 +02:00
Julius Härtl 59f8685af2
Merge pull request #26633 from nextcloud/enh/sharee/lookup_later
Make lookup search explicit
2021-04-20 05:38:00 -01:00
Nextcloud bot 79116e825c
[tx-robot] updated from transifex 2021-04-20 02:25:58 +00:00
Morris Jobke a67f0b0c47
Merge pull request #26615 from nextcloud/enh/ffs/require_read
Require read permissions for federated shares
2021-04-19 21:50:48 +02:00
Jan C. Borchardt 738ac612d2
Fix accessibility of federation menu privacy buttons
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:54 +02:00
Jan C. Borchardt 64e90cdc66
Fix accessibility of profile picture section
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:54 +02:00
Jan C. Borchardt f86a2239e7
Fix missing label of Files navigation sublist toggles
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:53 +02:00
Jan C. Borchardt abedc275d9
Fix missing label of grid view toggle
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:53 +02:00
Jan C. Borchardt 749a266f78
Add proper labels for personal settings privacy toggles
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 20:34:47 +02:00
Jan C. Borchardt 317c77f70f
Improve focus feedback for file list actions
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 20:34:46 +02:00
Jan C. Borchardt a649fbc404
Fix summary footer position and text contrast
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 20:34:46 +02:00
Roeland Jago Douma 2ef326d6b6
Merge pull request #26618 from nextcloud/bugfix/noid/fix-english-language
Fix English source string
2021-04-19 20:08:04 +02:00
Roeland Jago Douma dcd45427a6 Make lookup search explicit
Speedsup sharee lookup quite a bit.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 20:05:21 +02:00
Roeland Jago Douma adab9deb3e
Merge pull request #26601 from nextcloud/dependabot/npm_and_yarn/nextcloud/dialogs-3.1.2
Bump @nextcloud/dialogs from 3.1.1 to 3.1.2
2021-04-19 19:53:14 +02:00
Robin Appelman eeb72c3338
update icewind/smb to 3.4.1
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-19 16:00:47 +02:00
Roeland Jago Douma 68dadc01af Consider read permission in sharing tab
When updating a share we should make sure to use all the old permissions
(and only change what we actually changed). So the READ permission in
this case should also be fetched instead of always granted.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 15:10:51 +02:00
dependabot[bot] 5370c54084 Bump @nextcloud/dialogs from 3.1.1 to 3.1.2
Bumps [@nextcloud/dialogs](https://github.com/nextcloud/nextcloud-dialogs) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/nextcloud/nextcloud-dialogs/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-dialogs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-dialogs/compare/v3.1.1...v3.1.2)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-04-19 11:37:24 +00:00
Joas Schilling 422ecdeb20
Fix English source string
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-19 13:11:34 +02:00
Roeland Jago Douma 5c42c303e4 Require read permissions for federated shares
Else they end up as weird shares that can't be properly utilized by
other parties anyway.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 12:53:49 +02:00
Roeland Jago Douma 241dfab33f Do not allow adding file drop shares to your own cloud
There is no reason for this and you can't create such shares normally
anyway.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 12:17:58 +02:00
Nextcloud bot 8c82dd37b4
[tx-robot] updated from transifex 2021-04-19 02:26:04 +00:00
Valdnet 2445c82750
l10n: Improve styling
"Empty field" information shifted to the end of the sentence. It looks more stylistic.
2021-04-18 11:39:46 +02:00
Nextcloud bot 286acbedef
[tx-robot] updated from transifex 2021-04-18 02:24:11 +00:00
Nextcloud bot 3ab7d6cf3e
[tx-robot] updated from transifex 2021-04-17 02:24:04 +00:00
Roeland Jago Douma 9b86e6f829 Listen to proper UserDeletedEvent
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 14:31:40 +02:00
Roeland Jago Douma 0593b039fc Move over notification to new registration
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 13:56:28 +02:00
Roeland Jago Douma ec66943efd
Merge pull request #26559 from J0WI/updno-strict
Updatenotification: add missing strict_types
2021-04-16 10:16:25 +02:00
Roeland Jago Douma 3d1015c87a
Merge pull request #26560 from J0WI/backupcodes-strict
2FA backupcodes: add strict typing
2021-04-16 10:14:53 +02:00
Roeland Jago Douma 7d8ff27928
Merge pull request #26558 from J0WI/dashboard-strict
Dashboard: add missing strict_types
2021-04-16 10:13:02 +02:00
castillo92 12948aa217
Update ShareAPIController.php
Change to capital letters in an abbreviation.

Signed-off-by: castillo92 javiercizquierdo@gmail.com
2021-04-16 08:56:20 +02:00
Nextcloud bot 07278ed57d
[tx-robot] updated from transifex 2021-04-16 02:25:50 +00:00
J0WI 899413b506 Format header
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-15 16:57:06 +02:00
J0WI 09368e7cf5 2FA backupcodes: add strict typing
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-15 16:57:06 +02:00
Vincent Petry af61486aea
Separate settings for remote share expiration
Added separate settings for default and enforced expiration date for
remote shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +02:00
Vincent Petry 2650da70ca
Unit tests for federated share expiration date
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:03 +02:00
Vincent Petry b0aaafe259
Fix expire date capability for federated shares
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:03 +02:00
Vincent Petry 8680bafc5c
Implement expiration date for federated shares
Add expiration date field in UI.
Save expiration date when creating or updating federated share.
Read expiration date from DB in federated share provider.
Applies to both federated user and group shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:00 +02:00
Nextcloud bot 8ef920fdf9
[tx-robot] updated from transifex 2021-04-15 02:25:10 +00:00
J0WI 684a0da48a Dashboard: add missing strict_types
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-14 16:46:25 +02:00
J0WI 8fd2be9655 Updatenotification: add missing strict_types
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-14 16:46:02 +02:00
Roeland Jago Douma 644ce9e4f0
Merge pull request #26529 from J0WI/getSystemValue-type
Use correct getSystemValue type
2021-04-14 13:36:56 +02:00
John Molakvoæ 857a40b334
Merge pull request #26533 from nextcloud/fix/add-share-resolve-default
Fix undefined error on add-share
2021-04-14 08:32:26 +02:00
Nextcloud bot 7081c63d09
[tx-robot] updated from transifex 2021-04-14 02:26:51 +00:00
Joas Schilling 421914b4d0
Merge pull request #26467 from nextcloud/feature/noid/allow-apps-to-log-to-audit
Allow apps to log actions into the audit_log
2021-04-13 08:52:08 +02:00
John Molakvoæ (skjnldsv) 4b9991a4f2 Fix undefined error on add-share
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-04-13 06:21:48 +00:00
Nextcloud bot bab06b9abb
[tx-robot] updated from transifex 2021-04-13 02:24:57 +00:00
J0WI 74a7c2eefc Use correct getSystemValue type
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-12 22:54:50 +02:00
Roeland Jago Douma b07a8fd1fe
Merge pull request #26230 from nextcloud/Valdnet-patch-4
l10n: Add word user in FederatedShareProvider.php
2021-04-12 08:35:50 +02:00
Nextcloud bot ac893e843b
[tx-robot] updated from transifex 2021-04-12 02:24:55 +00:00
Valdnet 6da17a6fab l10n: Add word user in FederatedShareProvider.php
Standardizing text strings with other Nextcloud applications.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-11 13:52:54 +02:00
Nextcloud bot d942a5b2be
[tx-robot] updated from transifex 2021-04-11 02:24:42 +00:00
Nextcloud bot bbee01117e
[tx-robot] updated from transifex 2021-04-10 02:31:13 +00:00
Joas Schilling 99e5367208
Move to another namespace and class name
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-09 12:51:57 +02:00
Claas Augner 17963ea089
Mention MariaDB in MySQL support warning 2021-04-09 12:31:16 +02:00
Joas Schilling ca939214bd
Allow apps to log actions into the audit_log
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-09 10:32:45 +02:00
Roeland Jago Douma 30ac98cdcd
Merge pull request #26462 from nextcloud/dependabot/npm_and_yarn/core-js-3.10.1
Bump core-js from 3.9.1 to 3.10.1
2021-04-09 09:42:56 +02:00
Nextcloud bot 9de329a4c2
[tx-robot] updated from transifex 2021-04-09 02:25:11 +00:00
dependabot-preview[bot] e2645a5e70 Bump core-js from 3.9.1 to 3.10.1
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.9.1 to 3.10.1.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.10.1/packages/core-js)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-04-08 15:50:13 +02:00
Joas Schilling aee1f7253c
Show icon-phone when setting is set to private instead of local
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-08 11:17:52 +02:00
Nextcloud bot 41216e68bf
[tx-robot] updated from transifex 2021-04-08 02:24:01 +00:00
Nextcloud bot c391e8692b
[tx-robot] updated from transifex 2021-04-07 02:24:14 +00:00
John Molakvoæ (skjnldsv) cd3b3a6fdf
Fix comments maxAutoCompleteResults initial state
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-04-06 12:22:30 +02:00
Nextcloud bot e9075b02cd
[tx-robot] updated from transifex 2021-04-06 02:25:33 +00:00
Nextcloud bot bb3ba96b37
[tx-robot] updated from transifex 2021-04-05 02:24:46 +00:00
Nextcloud bot bfd926938f
[tx-robot] updated from transifex 2021-04-04 02:24:48 +00:00
Nextcloud bot 6f55d2e293
[tx-robot] updated from transifex 2021-04-03 02:25:32 +00:00
Nextcloud bot 4bea123c7a
[tx-robot] updated from transifex 2021-04-02 02:26:04 +00:00
Roeland Jago Douma bd2e6309b5
Merge pull request #25605 from nextcloud/trusted-proxy-warning-localhost
dont show trusted proxy warning when the proxy and remote are both localhost
2021-04-01 13:27:26 +02:00
Nextcloud bot f016cbe914
[tx-robot] updated from transifex 2021-04-01 02:24:40 +00:00
Morris Jobke 6a81477ffe
Merge pull request #25326 from nextcloud/ldap-factory-no-ldap
make ILDAPProviderFactory usable when there is no ldap setup
2021-03-31 21:23:23 +02:00
blizzz ecf287a094
Merge pull request #26260 from hosting-de/feature/ldap-config-json
Add json, yaml output options to ldap:show-config
2021-03-31 21:12:29 +02:00
Robin Appelman 65b78515bd
make ILDAPProviderFactory usable when there is no ldap setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-31 15:23:33 +02:00
Johannes Leuker 9660a3fa90 Add json, yaml output options to ldap:show-config
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-31 12:36:22 +02:00
John Molakvoæ (skjnldsv) 11437223e9
Compile node
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-31 12:34:13 +02:00
John Molakvoæ (skjnldsv) 3e624dc399
Bump js licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-31 12:17:18 +02:00
Joas Schilling 2f99ae1120
Also check the default phone region when the number has no country code
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 08:45:32 +02:00
Nextcloud bot 855b5fc638
[tx-robot] updated from transifex 2021-03-31 02:24:50 +00:00
Roeland Jago Douma 0a6416f84f
Merge pull request #23444 from nextcloud/notify-dry-run
add dry-run option to files_external:notify
2021-03-30 21:46:27 +02:00
Roeland Jago Douma 7c30d1aa2d
Merge pull request #26219 from nextcloud/relative-path-null
getRelativePath can return null
2021-03-30 21:10:05 +02:00
Roeland Jago Douma 071a38a22f
Merge pull request #26292 from nextcloud/smb-directory-readonly
ignore readonly flag for directories
2021-03-30 13:20:11 +02:00
Roeland Jago Douma 08209e649c
Merge pull request #26324 from J0WI/crypt-drop-openssl-09
Drop OpenSSL 0.9.8 workaround
2021-03-30 11:43:44 +02:00
Joas Schilling ebc3b1f802
Remove notifications when retesting
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-30 10:18:23 +02:00
Nextcloud bot a9ff9670fa
[tx-robot] updated from transifex 2021-03-30 02:24:18 +00:00
Joas Schilling 6ae3de247d
Fix working for phone number integration
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-29 17:04:32 +02:00
Morris Jobke f8bad86097
Merge pull request #26342 from pirate/cal-invite-email-use-pngs
Fix broken Calendar Event Invite email icons in Gmail by using PNGs instead of SVGs
2021-03-29 11:01:46 +02:00
Julius Härtl 6bef9e71da
Merge pull request #26337 from nextcloud/dependabot/npm_and_yarn/url-search-params-polyfill-8.1.1
Bump url-search-params-polyfill from 8.1.0 to 8.1.1
2021-03-29 10:33:38 +02:00
dependabot-preview[bot] e2216d44fd Bump url-search-params-polyfill from 8.1.0 to 8.1.1
Bumps [url-search-params-polyfill](https://github.com/jerrybendy/url-search-params-polyfill) from 8.1.0 to 8.1.1.
- [Release notes](https://github.com/jerrybendy/url-search-params-polyfill/releases)
- [Commits](https://github.com/jerrybendy/url-search-params-polyfill/compare/v8.1.0...v8.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-29 07:41:21 +00:00
Joas Schilling 602de272c0
Merge pull request #26243 from nextcloud/enh/noid/avatar-privacy-new-scope
Avatar privacy and new scope
2021-03-29 09:01:12 +02:00
Nextcloud bot 4564121c56
[tx-robot] updated from transifex 2021-03-29 02:23:55 +00:00
Nextcloud bot be83a32411
[tx-robot] updated from transifex 2021-03-28 02:24:04 +00:00
Nick Sweeting 8c6f0aa3d2 change calendar invite emails to use pngs instead of svgs
Signed-off-by: Nick Sweeting <git@sweeting.me>
2021-03-26 23:57:48 -04:00
Nextcloud bot aec9c8437a
[tx-robot] updated from transifex 2021-03-27 02:24:25 +00:00
J0WI 21494a5b7b Drop OpenSSL 0.9.8 workaround
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-03-26 19:23:10 +01:00
Vincent Petry 00d83a5db0
Capability for federated scope
Added additional capability in the provisioning API to signal whether
the federation scope values can be used.

This is based on whether the lookup server upload is enabled or not.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 16:54:47 +01:00
Vincent Petry aac7b52c66
Change account property capability
Include version number in capability

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
2021-03-26 13:07:10 +01:00
Vincent Petry b66af8a432
Add capability for editable scopes in provisioning API
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:09 +01:00
Vincent Petry b73df5846c
Add property scope tests for AccountManager
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:09 +01:00
Vincent Petry cb9d25c162
Enhance UsersControllerTest of provisioning API with scopes
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:09 +01:00
Vincent Petry 2a312fe4e3
Expose avatarScope through provisioning API
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:09 +01:00
Vincent Petry 266a6fb5f8
OCS allow reading and writing account property scopes
Extends the provisioning API to allow a user to get and set their own
account property scopes.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +01:00
Vincent Petry 5d14fd4396
Make extra user profile fields always editable
The fields for phone number, address, website and twitter are now
editable regardless whether federated sharing and the lookup server
are enabled or not.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +01:00
Vincent Petry 278a73789e
Map old account scope properties to new names
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +01:00
Vincent Petry 9fb447ea42
Adjust scopes menu based on conditions
Now not all fields have the "v2-private" option in place.
Fix dropdown issue when a scope was stored that is not listed after
disabling the lookup server.
Whenever the lookup server upload is disabled, the scope menu is now
displayed where it makes sense to allow switching between the two private
scopes.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +01:00
Vincent Petry b81a1c1bdb
Add new v2-private account scope
Added new v2-private account manager scope that restricts the scope
further by excluding public link access.

Avatars with v2-private account scope are now showing the guest avatar
instead of the real avatar.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:05 +01:00
John Molakvoæ fbbcf26099
Merge pull request #22201 from cweiske/20492-move-contacts-with-birthday
Delete old birthday calendar object when moving contact to another ad…
2021-03-26 07:59:16 +01:00
Christian Weiske 8ee995f214
Delete old birthday calendar object when moving contact to another address book
When an contact is moved to another address book, the contact is copied to
the second address book.
During copying, the birthday event is created - but it gets the same UID
as the contact's birthday event in the first address book.

To prevent the "Calendar object with uid already exists" error that followed,
we need to delete the old entry before the new one is created.

Resolves: https://github.com/nextcloud/server/issues/20492
Signed-off-by: Christian Weiske <cweiske@cweiske.de>
2021-03-26 07:31:16 +01:00
Nextcloud bot 630eddf41b
[tx-robot] updated from transifex 2021-03-26 02:25:32 +00:00
Robin Appelman 43f70e5817
ignore readonly flag for directories
see http://support.microsoft.com/kb/326549

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-25 12:03:09 +01:00
Valdnet 107bbebb6c
Fix l10n
Issue: #26286
2021-03-25 10:26:50 +01:00
Nextcloud bot 9af8c0b380
[tx-robot] updated from transifex 2021-03-25 02:25:39 +00:00
Robin Appelman 8a92229485
getStorage can also return null
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 14:56:40 +01:00
Robin Appelman 98c3eb6cad
add dry-run option to files_external:notify
and add some additional logging

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 14:28:04 +01:00
John Molakvoæ da6019df67
Merge pull request #26255 from nextcloud/Valdnet-patch-6
l10n: Separate ellipsis
2021-03-24 09:13:20 +01:00
Nextcloud bot bb8a71266e
[tx-robot] updated from transifex 2021-03-24 02:25:07 +00:00
Valdnet 21db5bf9b9
l10n: Separate ellipsis
Unifying the text string with the others.
2021-03-23 09:12:52 +01:00
Roeland Jago Douma a219fa587a
Merge pull request #25776 from nextcloud/fix/sabre-file-checksum-no-file-info
Only write checksum if we have a valid file info
2021-03-23 08:59:21 +01:00
Christoph Wurst 24ec924586
Merge pull request #26033 from nextcloud/enh/comments/to_initialstate
Move comments to initial state
2021-03-23 08:33:42 +01:00
Nextcloud bot a81408a8e1
[tx-robot] updated from transifex 2021-03-23 02:24:02 +00:00
Morris Jobke 1c074e7602
Merge pull request #26198 from nextcloud/unified-search-node
Handle limit offset and sorting in files search
2021-03-22 21:48:51 +01:00
Roeland Jago Douma 8988406789 Move comments to initial state
* Do not extend the jssettings
* Just use the proper intial state
* Use it in the js code as well

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 20:31:56 +00:00
Morris Jobke 1eb084cfd3
Merge pull request #25498 from Worteks/feat-federatedfilesharing-logging
feat(federatedfilesharing): log errors, as suggested by @maxbes
2021-03-22 21:21:53 +01:00
Christoph Wurst 8152189b09 Only write checksum if we have a valid file info
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-22 21:11:07 +01:00