Roeland Jago Douma
7301b43eb6
Added tests
...
* Unit tests for OC_Filechunking to verify the isComplete function
* Intergration tests to show that shuffling chunks is all fine
2016-03-07 21:20:13 +01:00
Lukas Reschke
72c8187cbb
Keep "encryptedVersion" when calling `\OC\Files\View::copy`
...
When calling `\OC\Files\View::copy` we should also keep the version to ensure that the file will always have the correct version attached and can be successfully decrypted.
To test this the following steps are necessary (from https://github.com/owncloud/core/issues/22781#issuecomment-191328982 ):
1. setup a new ownCloud 9.0 beta2
2. enable encryption
2. upload a docx (5.7MB large)
3. upload the same file again and overwrite the existing file
4. I can download the original file and the first version
5. I restore the first version
6. restored version can no longer be downloaded with the error described above
The manual cache operation in `\OCA\Files_Versions\Storage` is unfortunately necessary since `\OCA\Files_Versions\Storage::copyFileContents` is not using `\OCP\Files\Storage::moveFromStorage` in the case when an object storage is used. Due to the workaround added in 54cea05271
the stream is directly copied and thus bypassing the FS.
2016-03-03 14:15:36 +01:00
Joas Schilling
2a0cda74d4
Use IQueryBuilder::PARAM_* instead of \PDO::PARAM_*
2016-02-29 09:44:40 +01:00
Thomas Müller
6526c122af
Merge pull request #22683 from owncloud/fix_22682
...
Relax rootfolder check
2016-02-29 08:53:58 +01:00
Roeland Jago Douma
b116e80c56
Relax rootfolder check
...
* Updated unit tests
* Added intergration test
2016-02-26 16:05:32 +01:00
Roeland Jago Douma
bfcdf40a64
Expiration date can only be enforced if default is enabled
...
If the default expiration date is not enebaled it can not be enforced.
* Added unit tests
2016-02-26 11:38:06 +01:00
Thomas Müller
62d7885c3b
Merge pull request #22660 from owncloud/fix_22656
...
Do not allow sharing of the users root folder
2016-02-26 10:49:12 +01:00
Thomas Müller
0795cc373d
Merge pull request #22646 from owncloud/fix_22642
...
Set default expiration date if none given on share creation
2016-02-26 10:48:21 +01:00
Thomas Müller
cbde4bb92f
Merge pull request #22650 from owncloud/fix_hook
...
Fix verifyExpirationDate passwordSet argument
2016-02-26 09:32:41 +01:00
Roeland Jago Douma
8213d5df4f
Do not allow sharing of the root folder
...
Sharing of the users root folder should not be allowed as it is very
weird UX. Also many of our clients have no proper way of displaying
this.
Added unit test
Also added intergration tests to make sure we won't allow it in the
future.
2016-02-25 20:40:30 +01:00
Roeland Jago Douma
9412f69104
Fix verifyExpirationDate passwordSet argument
...
Password set should be false if the password is null.
Also updated the unit tests to tests this now.
2016-02-25 15:39:02 +01:00
Thomas Müller
efc966698f
Merge pull request #22579 from owncloud/fix_broken_unencrypted_size
...
Heal unencrypted file sizes at download time (second approach)
2016-02-25 14:34:48 +01:00
Roeland Jago Douma
6d4f80d680
Set default expiration date if none given on share creation
...
When we create a share for the first time we should set the default
expiration date. If none is given.
Fixes #22642
2016-02-25 14:21:46 +01:00
Thomas Müller
2ec1c738d0
Merge pull request #22573 from owncloud/issue-22568-allow-string-object-ids
...
Make sure we can store strings as per the interface
2016-02-24 12:15:23 +01:00
Bjoern Schiessle
834b51b83b
recalculate unencrypted size if we assume that the size stored in the db is not correct
2016-02-23 15:09:46 +01:00
Joas Schilling
fb8b34bdd0
Allow defining a limit and offset for getObjectIdsForTags
2016-02-23 09:04:15 +01:00
Joas Schilling
24c7f38a00
Make sure we can store strings as per the interface
2016-02-22 15:43:20 +01:00
Thomas Müller
f8677628d4
Merge pull request #22503 from owncloud/issue_22500
...
When (re-)sharing an incomming federated share set the corrent owner
2016-02-19 16:07:43 +01:00
Thomas Müller
b5281b61ed
Merge pull request #22410 from owncloud/fix_22119
...
Do not copy skeleton on avatar access
2016-02-19 16:06:40 +01:00
Roeland Jago Douma
2dcf887cce
When (re-)sharing an incomming federated share set the corrent owner
...
Incomming federated shares are a special kind. We mount them as normal
webdav shares but we do supply owner info with the federated cloud id of
the share owner.
Since we do not yet have the new resharing behaviour on federated shares
we need to set the correct owner. Which will allow sharing and proper
mounting for other users.
fixes #22500
2016-02-19 12:43:03 +01:00
v1r0x
ec6e8c1ab6
fix unit test
2016-02-18 12:39:19 +01:00
Thomas Müller
c6fef52939
Merge pull request #22416 from owncloud/fix_22402
...
Return proper error string if sharing for this user is disabled
2016-02-16 13:37:22 +01:00
Thomas Müller
d5226c88ac
Merge pull request #22338 from owncloud/fix_22247
...
Allow more characters in filenames
2016-02-16 13:37:07 +01:00
Roeland Jago Douma
ed6843e87b
Return proper error string if sharing for this user is disabled
...
Fixes #22402
2016-02-16 10:22:49 +01:00
Roeland Jago Douma
47d28155a8
Do not copy skeleton on avatar access
...
Fixes #22119
Just try to get the folder of the user. If it is not there a
NotFoundException will be thrown. Which will be handled by the avatar
endpoint.
2016-02-16 09:18:38 +01:00
Morris Jobke
7048d428b1
Remove unneeded parameter from OC_App::getEnabledApps
2016-02-15 13:33:07 +01:00
Thomas Müller
248c571c56
Merge pull request #22331 from owncloud/dav-nonexisting-part
...
fix getNodeForPath for non existing part files
2016-02-13 18:24:00 +01:00
Thomas Müller
207c09c511
Merge pull request #22309 from owncloud/infinite-recursion-on-expired-link
...
Do not getShare in deleteShare, it's already there when deleting
2016-02-12 11:11:26 +01:00
Thomas Müller
e99c4d83dc
Merge pull request #22317 from owncloud/fix_invisible_linkshares
...
Do not allow invisible link shares
2016-02-12 11:10:58 +01:00
Roeland Jago Douma
759b19775d
Fix unit tests
2016-02-12 07:49:36 +01:00
Robin Appelman
c3e4ced64a
fix getNodeForPath for non existing part files
2016-02-11 17:22:40 +01:00
Roeland Jago Douma
4533cb9c59
Add parent for invisible link shares
2016-02-11 13:29:23 +01:00
Joas Schilling
8cfdc62eae
Update info checker requirements
2016-02-11 11:54:13 +01:00
Roeland Jago Douma
2aa206e900
Fix unit tests
2016-02-11 11:21:12 +01:00
Björn Schießle
9bb97c714b
fixing unit tests
2016-02-09 23:43:26 +01:00
Thomas Müller
29f6f451a9
Merge pull request #22192 from owncloud/fix_19685
...
Only set the default expiration date on share creation
2016-02-09 23:38:00 +01:00
Thomas Müller
2982017682
Merge pull request #22228 from owncloud/comments-limit-message
...
Limit comment message to 1k chars
2016-02-09 16:35:23 +01:00
Roeland Jago Douma
ee65cd0bd8
Only set the default expiration date on share creation
...
Fixes #19685
The default expiration date should only be set when we create a new
share. So if a share is created and the expiration date is unset. And
after that the password is updated the expiration date should remain
unset.
2016-02-09 11:05:14 +01:00
Arthur Schiwon
347ad3e223
Limit comment message to 1k chars
2016-02-09 03:14:30 +01:00
Arthur Schiwon
cd00751de5
Send events when enabling and disabling of apps
2016-02-09 02:51:12 +01:00
Roeland Jago Douma
fad85ad19f
Fix unit tests
2016-02-08 11:30:48 +01:00
Roeland Jago Douma
8486d61764
getSharesBy should also expire link shares
2016-02-06 13:31:54 +01:00
Roeland Jago Douma
3028ec5440
Delete expired share when fetched by id
2016-02-06 13:31:54 +01:00
Roeland Jago Douma
5ed56d9edb
Delete a link share if it is expired on access
...
If we access a link share we should check if it has expired already.
If so we should remove it and throw a ShareNotFound exception
2016-02-06 13:31:54 +01:00
Thomas Müller
5832178f59
Merge pull request #22139 from owncloud/comments-files-cleanup
...
cleanup jobs for comments and comment read marks
2016-02-06 13:26:00 +01:00
Joas Schilling
065141f6f4
Move casting to IExpressionBuilder
2016-02-05 21:26:30 +01:00
Robin Appelman
fb76d7de69
remove unused Storage->getLocalFolder
2016-02-05 16:48:08 +01:00
Roeland Jago Douma
169874957a
Path should be relative
2016-02-04 19:19:10 +01:00
Roeland Jago Douma
b57aac0a89
[Share 2.0] Add missing post_update_permissions hook
2016-02-04 19:18:25 +01:00
Thomas Müller
d8faeab421
Merge pull request #21766 from farukuzun/master
...
Add some mimetypes
2016-02-04 16:49:31 +01:00