The cursor in click inputs is shown as a pointer to convey that it can
be interacted with. However, in those click inputs that can have
descendants, like buttons, the descendants may not inherit the cursor
from it (for example, a "strong" element would, but a "span" element
would not), which causes a pointer cursor to be shown on some areas of
the button and a different one to be shown on other areas. To prevent
that now all the descendants of click inputs that can have descendants
use a pointer cursor.
On the other hand, if a click input is disabled it can not be interacted
with it, so now disabled click inputs as well as their descendants show
a default cursor instead of a pointer cursor in that case.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
"button, textarea, select, div[contenteditable='true']" were removed and
"audio, canvas, embed, iframe" were added.
Note that this is a coarse-grained list; according to the spec some of
the elements, like canvas or input, might be treated as a replaced
element in some cases and as ordinary elements in others:
https://html.spec.whatwg.org/multipage/rendering.html#replaced-elements
For now all the elements that might be replaced elements use the loading
image by default, so apps will need to override that when the elements
are treated as ordinary elements. Of course that can be flipped in the
future to instead make an element to use the "::after" approach by
default if it is found that the element requires the override often.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Replaced elements do not have "::after" nor "::before" pseudo-elements,
so the regular loading icon needs to be shown using a background image
instead of the default "::after" pseudo-element approach. However, the
CSS rules were not applied on the replaced elements themselves, but on
their descendants. As the descendants might have support for
pseudo-elements the rules were fixed to be applied on the replaced
elements, and only on the replaced elements.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The cursor should be a default cursor, as the text cursor implies that
text can be introduced.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The external shares entry showed a "button" that, when pressed, replaced
the button with the input to set the remote share address. The "button"
was actually a label for the input, so when the label was focused it
transferred the focus to the input and thus pressing enter or space did
not show the input. Moreover, inputs inside links are not valid HTML,
and once shown there was no way to hide the input again.
Due to all this, and for consistency with the direct link input, the
external share input was moved to a different menu item that is shown
and hidden when the button, which nows is also a real button, is
clicked.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
This makes possible to navigate to the menu toggle using the keyboard,
as well as being semantically more correct.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Joas Schilling
Daniel Calviño Sánchez
Marco Ambrosini
Roeland Jago Douma
Gary Kim
Marc Michalsky
Julius Härtl
Christoph Wurst
Jan-Christoph Borchardt
Georg Ehrke
John Molakvoæ
John Molakvoæ (skjnldsv)
Guillaume COMPAGNON
Jonas Sulzer