d2f1225b34
Fix deleting properties of user settings when not given explicitly
...
The controller can receive an optional subset of the properties of the
user settings; values not given are set to "null" by default. However,
those null values overwrote the previously existing values, so in
practice any value not given was deleted from the user settings. Now
only non null values overwrite the previous values.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:11 +02:00
3304d33e3b
Fix TypeError when "email" is not given in the controller request
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:11 +02:00
e30271be4f
Respect additional user settings not covered by the controller
...
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.
Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).
This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:10 +02:00
c130b88004
Add more unit tests for setting user settings
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:09 +02:00
f2e40238a6
Change default test data to values less similar to empty values
...
Right now it makes no difference, but this should make future tests
clearer, specially in case of failure.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:08 +02:00
5a497841be
Extract default test data to a helper getter
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:07 +02:00
eaedf5fcd9
Use constants from interface rather than class
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:07 +02:00
739504bd10
[tx-robot] updated from transifex
2021-04-23 02:26:44 +00:00
f43c25dfe3
[tx-robot] updated from transifex
2021-04-22 02:26:53 +00:00
d11ded9ef9
Merge pull request #26676 from nextcloud/backport/26658/stable19
...
[stable19] Do not stop directory listing when ACL is blocking access
2021-04-21 14:20:39 +02:00
5262bb97f7
Continue iterating over diretory contents and just hide file if denied by acl
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-21 07:24:13 +00:00
e73034b95b
[tx-robot] updated from transifex
2021-04-21 02:26:35 +00:00
418dab9b98
Merge pull request #26646 from nextcloud/backport/26625/stable19
...
[stable19] Fix empty password check for mail shares
2021-04-20 20:47:52 +02:00
489ddb4d04
Merge pull request #26644 from nextcloud/backport/26639/stable19
...
[stable19] ensure redis returns bool for hasKey
2021-04-20 16:22:00 +02:00
2cb71972b7
Merge pull request #26619 from nextcloud/backport/26614/stable19
...
[stable19] Update root.crl due to revoked news.crt
2021-04-20 15:10:00 +02:00
d6c3fce82b
Merge pull request #26645 from nextcloud/backport/26633/stable19
...
[stable19] Make lookup search explicit
2021-04-20 14:08:40 +02:00
3dac09a9d7
Make lookup search explicit
...
Speedsup sharee lookup quite a bit.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 08:39:32 +00:00
9d4a52e07c
ensure redis returns bool for hasKey
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-20 08:39:30 +00:00
4b5a05cfee
Fix empty password check for mail shares
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-20 10:35:58 +02:00
6259ba779e
Merge pull request #26638 from nextcloud/backport/26615/stable19
...
[stable19] Require read permissions for federated shares
2021-04-20 09:06:46 +02:00
16eed4a1ba
[tx-robot] updated from transifex
2021-04-20 02:26:29 +00:00
46823e8f68
Require read permissions for federated shares
...
Else they end up as weird shares that can't be properly utilized by
other parties anyway.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 19:56:14 +00:00
19fb6d7651
Merge pull request #26623 from nextcloud/backport/26613/stable19
...
[stable19] Do not allow adding file drop shares to your own cloud
2021-04-19 21:48:33 +02:00
95c65f756e
Do not allow adding file drop shares to your own cloud
...
There is no reason for this and you can't create such shares normally
anyway.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 13:03:04 +00:00
804431ec93
Update root.crl due to revoked news.crt
...
See https://github.com/nextcloud/app-certificate-requests/pull/382
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-04-19 12:13:56 +00:00
9b86f5f674
Merge pull request #26603 from nextcloud/dependabot/npm_and_yarn/stable19/ssri-6.0.2
...
[Security] Bump ssri from 6.0.1 to 6.0.2
2021-04-19 12:43:47 +02:00
69d60cbcaa
[tx-robot] updated from transifex
2021-04-19 02:26:35 +00:00
6b7f09eacb
[tx-robot] updated from transifex
2021-04-18 02:24:37 +00:00
e5b67bfdb7
[tx-robot] updated from transifex
2021-04-17 02:24:35 +00:00
42df5ff9d5
[Security] Bump ssri from 6.0.1 to 6.0.2
...
Bumps [ssri](https://github.com/npm/ssri ) from 6.0.1 to 6.0.2. **This update includes a security fix.**
- [Release notes](https://github.com/npm/ssri/releases )
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md )
- [Commits](https://github.com/npm/ssri/compare/v6.0.1...v6.0.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-04-16 22:10:29 +00:00
09a5cb1495
[tx-robot] updated from transifex
2021-04-16 02:26:22 +00:00
46686de607
[tx-robot] updated from transifex
2021-04-15 02:25:40 +00:00
f988edd5f7
[tx-robot] updated from transifex
2021-04-14 02:27:20 +00:00
cd76cc773d
[tx-robot] updated from transifex
2021-04-13 02:25:25 +00:00
248efed7fa
Merge pull request #26513 from nextcloud/backport/26439/stable19
...
[stable19] Increase subnet matcher
2021-04-12 13:32:32 +02:00
a55715d9ed
Increase subnet matcher
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-12 10:36:24 +00:00
0de63d7751
Merge pull request #26510 from nextcloud/backport/26230/stable19
...
[stable19] l10n: Add word user in FederatedShareProvider.php
2021-04-12 10:18:10 +02:00
5a2de59a8f
l10n: Add word user in FederatedShareProvider.php
...
Standardizing text strings with other Nextcloud applications.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-12 06:46:50 +00:00
3e8bf30005
[tx-robot] updated from transifex
2021-04-12 02:25:25 +00:00
0aed70e0db
[tx-robot] updated from transifex
2021-04-11 02:25:11 +00:00
08c65167f4
[tx-robot] updated from transifex
2021-04-10 02:31:40 +00:00
2843b84b43
[tx-robot] updated from transifex
2021-04-09 02:25:36 +00:00
8f42028088
Merge pull request #26455 from nextcloud/version/19.0.10/final
...
19.0.10 final
2021-04-08 14:42:56 +02:00
6f61abeaab
Merge pull request #26450 from nextcloud/3rdparty/stable19/phpseclib-2.0.31
...
[3rdparty][stable19] phpseclib-2.0.31
2021-04-08 14:37:08 +02:00
9fca9ff674
[3rdparty][stable19] phpseclib-2.0.31
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-08 11:53:11 +02:00
4112850943
19.0.10 final
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-08 10:22:41 +02:00
26dea5d023
[tx-robot] updated from transifex
2021-04-08 02:24:31 +00:00
f29f06febd
[tx-robot] updated from transifex
2021-04-07 02:24:43 +00:00
6cbf84784a
[tx-robot] updated from transifex
2021-04-06 02:25:58 +00:00
c516405fe1
[tx-robot] updated from transifex
2021-04-05 02:25:12 +00:00
Daniel Calviño Sánchez
Nextcloud bot
Morris Jobke
Julius Härtl
Roeland Jago Douma
Roeland Jago Douma
Arthur Schiwon
Vincent Petry
dependabot-preview[bot]
Lukas Reschke
Valdnet