aa956ab46e
broaden exception handling on webcal refresh
...
when iterating through a calendar, recurrance events can throw an
exception if no instances of the recurrance are found.
this exception is of class `Exception` but the try/catch clause in the
webcal refresh loop only catches `BadRequest` exception.
this leads to the exception bubbling up and thus other calendar events
do not get processed by the event iterator.
this PR broadens the exception to handle both BadRequest and
NoInstanceFoundException so that the full webcal can be processed, even
if minor hiccups are processing on vobject
Signed-off-by: leith abdulla <online-nextcloud@eleith.com>
2020-09-29 20:47:38 -07:00
593d64d935
Merge pull request #17456 from brad2014/feature/brad2014/12391-improve-imip-mail-message-take-2
2020-09-04 19:53:02 +02:00
442af8c5d5
Minor cleanup: php-cs-fixer, tests, interface consistency
...
IMipPlugin.php Removed blank lines to make php-cs-fixer happy.
Minor cleanup: bugs found by Psalm static checker
IEMailTemplate: The public interface to addBodyListItem also needs to include the new plainIndent parameter.
IMipPlugin: Fixes an undefined variable for events that do not have DTEND. Also use explicit string conversion for parameters and properties in several places.
The new email template adds an additional blank line before "button" links in plain text, so the tests were fixed to include that additional blank line.
Signed-off-by: Brad Rubenstein <brad@wbr.tech>
2020-09-02 17:54:36 +02:00
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
67f1ef4658
Add Typed Events for CalDAV- and CardDAV-related Events
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-18 21:40:57 +02:00
234b510652
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-12 13:55:19 +02:00
900617e7d7
Add Event and Task Backends for Unified Search
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-04 16:01:59 +02:00
7e6c0ec284
Use assertEqualsCanonicalizing instead of deprecated assertEquals parameter
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 17:11:29 +02:00
db8267db26
Use the new method everywhere
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-03 10:59:43 +02:00
a1f3293c06
Merge pull request #19039 from nextcloud/dav-activity-provide-links-to-calendar
...
Provide links to calendar in event creation/update activities
2020-04-30 09:10:56 +02:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
deb2ea9cea
Provide links to calendar in event creation/update activities
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-26 11:11:50 +02:00
fd0c1a3bb2
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 08:06:51 +02:00
ebdf66b706
Provide dav setting for user's default calendar
...
And add tests to handle schedule-default-calendar-URL
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-13 15:07:42 +02:00
28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup
...
Remove all extra whitespace PSR2 does not like
2020-04-09 20:39:37 +02:00
64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords
...
Use php keywords in lowercase
2020-04-09 16:25:14 +02:00
44577e4345
Remove trailing and in between spaces
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
36b3bc8148
Use php keywords in lowercase
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 14:04:56 +02:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
85e369cddb
Fix multiline comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +02:00
058ffa37ff
Add default titles for titleless events in invitations
...
Closes #19662
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-03 13:49:25 +02:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
2200cc8562
Merge pull request #19325 from nextcloud/dependachristoph/composer/sabre-4.0
...
Update Sabre (and friends) to 4.0
2020-03-30 09:34:25 +02:00
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
...
Remove unused imports
2020-03-27 17:14:08 +01:00
102a328e65
Fix usage of Sabre\HTTP\Request in unit tests
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
2ee65f177e
Use the shorter phpunit syntax for mocked return values
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:21:27 +01:00
74936c49ea
Remove unused imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +01:00
3427653676
Merge pull request #19986 from nextcloud/bugfix/19980/fix_uid_as_uri
...
RefreshWebcalService: randomly generate calendar-object uri
2020-03-25 08:11:49 +01:00
3e338c9075
Merge pull request #18788 from nextcloud/fix/18782/translate-busy-in-caldav
...
Translate 'Busy' in CalDAV
2020-03-24 15:12:21 +01:00
01db6d4609
Add extra test case to exclude by timerange
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-03-22 14:24:13 +01:00
b0fbba05f2
Added test testSearch
...
Signed-off-by: dartcafe <github@dartcafe.de>
2020-03-22 14:24:13 +01:00
bd1f98cba3
RefreshWebcalService: randomly generate calendar-object uri
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-16 15:36:13 +01:00
e6206731c7
Merge pull request #19252 from nextcloud/bug/fix-notification-object-id
...
Hash event UID to make sure it's not too long for PushProvider notifications
2020-02-25 17:04:25 +01:00
713d3d49ad
Merge pull request #19196 from nextcloud/feature/17126/allow_apps_to_register_their_own_calendars
...
Allow apps to provide Calendars in user's calendarHome
2020-02-23 17:00:03 +01:00
709e7447ed
Translate 'Busy' in CalDAV
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-02-23 22:38:24 +08:00
b46e5cb270
Allow apps to provide Calendars in user's calendarHome
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-02-18 14:35:14 +01:00
8b22b9f046
Move RefreshWebcalJob logic to a proper service so that it may be called
...
independently
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-02-10 16:04:38 +01:00
41fa057285
Hash event UID to make sure it's not too long for PushProvider
...
notifications
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-02-01 18:13:51 +01:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +01:00
c3748cfee3
respect shareapi_allow_share_dialog_user_enumeration in Principal backend for Sabre/DAV
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-12-03 09:44:07 +01:00
6d39c6cb50
Set common-name to user's displayname if none is set
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-11-29 07:48:30 +01:00
3a7cf40aaa
Mode to modern phpunit
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 15:27:18 +01:00
ef4b59d341
More fixes
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:42 +01:00
c007ca624f
Make phpunit8 compatible
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:41 +01:00
68748d4f85
Some php-cs fixes
...
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +01:00
88f6d1c20e
Make push notifications for calendar reminders opt-in
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-09-02 15:18:43 +02:00
eleith
John Molakvoæ
Brad Rubenstein
Christoph Wurst
Georg Ehrke
Morris Jobke
Joas Schilling
Roeland Jago Douma
Thomas Citharel
Christoph Wurst
dartcafe
Joas Schilling
Gary Kim
Roeland Jago Douma