489ac4391b
convert Sessions section
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-06-23 12:36:38 +02:00
045f652ef2
completing PersonalInfo
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-06-23 12:36:37 +02:00
7816c54625
Allow to force a language and set it via the ocs api
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-06-21 11:34:52 +02:00
e30ed1de84
Also allow group admins to toogle the storage location
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-06-20 10:35:22 +02:00
35413d9912
Don't try to save the setting when its not an admin
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-06-19 12:55:00 +02:00
2e8e6f95b9
show used space in user list
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-06-15 14:06:54 +02:00
56adbb4e1d
[docs] remove useless TODO mark
2017-06-12 11:19:31 +02:00
5feabd4634
[fix] Highlight 'everyone' group by default
2017-06-12 10:14:18 +02:00
340fdc1e70
reword sessions to security in personal settings
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-06-06 15:25:28 +02:00
593f6281dc
Combine sessions and app passwords view into one single view
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2017-05-30 09:54:10 +02:00
c7ade85982
Fix group restriction regression
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-19 12:05:09 -05:00
4fa8170394
polish user actions dropdown
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-05-06 16:22:25 +02:00
485d6d6577
use proper return codes and handle failure cases
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-04-29 00:59:09 -03:00
2507e7459d
Improve wording of error messages
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-04-29 00:59:09 -03:00
7be031ae6d
change group id to _disabledUsers
2017-04-29 00:54:30 -03:00
637c75bca1
Implemented visual feedback if a user is disabled in admin user menu.
...
Implemented visuals for enabling/disabling user from admin user list.
Added the controller functions for enabling/disabling a user.
Added the route for changing user status (enabled/disabled) and added an additional route handler in the user controller.
Finished the visuals to reflect current user status and changed user status respectively.
Changed the single icon for enabling/disabling a user into a menu where deletion and state toggling of a user is selectable.
Added displaying of disabled user count.
Improved style of user action menu.
Added proper counting of disabled users.
Removed visual indicator for disabled users.
Moved pseudo-group detection for disabled users from frontend to the controller.
Changed units for newly introduced css values from em to px.
Removed unnecessary png and optimized svg with scour.
Changed the userlist template to display the user action menu with correct width.
Style fixes for better readability and coding style conformity.
Changed the icons for enabling, disabling and deleting a user in the action menu.
2017-04-29 00:54:30 -03:00
4ec05ef050
cleanup template
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-04-28 23:41:38 -03:00
806ca43b52
allow to display the verification code also while verification is already running
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-04-28 23:41:38 -03:00
68ba8572b2
verification button should be clickable directly after status change, not only after page reload
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-04-28 23:41:37 -03:00
072d69ffe4
fix name of website input field
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-04-28 23:41:37 -03:00
2d071792c5
only close verification dialog if the user clicks outside of the dialog
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-04-28 23:41:37 -03:00
ec452a8294
only show verify button if scope is public and the input field contain some value
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-04-28 23:41:37 -03:00
a0ca1c04c3
show and hide verification dialog
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-04-28 23:41:37 -03:00
9a366dbe2e
add missing translation and other small fixes
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-04-28 23:41:36 -03:00
08a33cc475
Fix styling of verification box to popover
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2017-04-28 23:41:36 -03:00
46dd549e80
change status indicator if value was changed
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-04-28 23:41:36 -03:00
ebcb847681
remove action class once the status changes from 'to verify' to 'verifying'
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-04-28 23:41:36 -03:00
06265fe770
make use of verification buttons
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-04-28 23:41:36 -03:00
c9ccdca1ec
add verification dialog
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-04-28 23:41:35 -03:00
b9ebdba7eb
Use .installed layout
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-04-26 20:07:53 +02:00
732c92e93a
Make disableapp.php accept arrays
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-04-26 20:07:50 +02:00
0428254ed6
Don't sort on app bundles
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-04-26 20:07:50 +02:00
4b1ac3fef2
Add titles
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-04-26 20:07:49 +02:00
47cd976035
Add app bundles
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-04-26 20:07:49 +02:00
673b58ef09
Fix adding/removing apps
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2017-04-25 17:31:24 +02:00
88bc43182f
Fix app icon being inverted for app store apps too
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2017-04-25 00:22:57 +02:00
f03e59530a
Show spinner until app store images loaded
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2017-04-25 00:22:57 +02:00
b48d81d59f
Show placeholder for image-less apps in app management
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2017-04-25 00:22:57 +02:00
cf588f03bf
Center spinner in apps management
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2017-04-25 00:22:57 +02:00
47d9bffc53
Make svgs more fluid and consistent remove action, instead of 'remove app'
...
Signed-off-by: Felix A. Epp <work@felixepp.de>
2017-04-25 00:22:57 +02:00
a04413fd75
rename Uninstall to Remove
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2017-04-25 00:22:57 +02:00
a392532e28
also improve layout of apps from store
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2017-04-25 00:22:01 +02:00
ec96faead8
improve wording of Apps mgmt navigation entries
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2017-04-25 00:22:01 +02:00
5e5aa2eeeb
Fix uninstall in tabular view
...
Signed-off-by: Felix A. Epp <work@felixepp.de>
2017-04-25 00:22:01 +02:00
89ac71355d
Add apps category 'all installed'
...
Signed-off-by: Felix A. Epp <work@felixepp.de>
2017-04-25 00:22:01 +02:00
91a4676fc0
Make enabled and disabled apps a tabular list
...
Signed-off-by: Felix A. Epp <work@felixepp.de>
2017-04-25 00:22:01 +02:00
d01832ff64
Merge pull request #4472 from nextcloud/downstream-27714
...
Allow apps to register plugins for the user management
2017-04-24 19:44:57 +02:00
77b202ce80
Allow apps to register plugins for the user management
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-04-24 16:07:02 +02:00
e938663329
Don't send the test mail twice
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-04-24 12:50:29 +02:00
269600a04f
Merge pull request #4369 from nextcloud/fix-translations
...
Fix translations
2017-04-18 18:01:50 -05:00
1c0bffe87f
Fix translations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-04-18 16:40:53 -05:00
a5b4308a51
Don't put the SMTP password into the HTML code
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-04-18 15:44:20 +02:00
12c5c336ad
Merge pull request #4077 from nextcloud/better-navigation-management
...
Register the app management in the normal way
2017-03-26 15:48:19 -06:00
0229c16e5f
Don't use the dropdown for one item only
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-03-26 21:23:18 +02:00
433958e2e3
Move app management to the settings menu
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-03-26 20:26:05 +02:00
2048e3e201
replace name in top right with icon for less noise
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2017-03-26 18:15:34 +02:00
e446d22359
Merge pull request #3917 from michaelletzgus/html5-fix_dup-IDs
...
Fix duplicate id "apps-management"
2017-03-20 01:51:20 -06:00
13718b23e9
trigger event on input autofill
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-03-19 22:00:58 -06:00
0b6ff1706f
Fix duplicate id "apps-management"
...
Make duplicate id "apps-management" a class since IDs must be unique:
https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#the-id-attribute
https://api.jquery.com/id-selector/
Signed-off-by: Michael Letzgus <michaelletzgus@users.noreply.github.com>
2017-03-19 12:36:29 +01:00
780400302c
Rebuild menu to keep order of icons correct
...
Signed-off-by: Julius Haertl <jus@bitgrid.net>
2017-03-16 11:55:10 +01:00
1d6fba03f4
Make enabling/disabling apps work with the new menu
...
Signed-off-by: Julius Haertl <jus@bitgrid.net>
2017-03-16 11:55:10 +01:00
beb3f92c4d
Remove the double password confirmation on changing cron
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-03-13 15:52:16 +01:00
938f432113
Merge pull request #3819 from nextcloud/dont-add-user-to-subadmin
...
Call right function after sudo mode
2017-03-13 14:59:48 +01:00
ec7be8bd43
Call right function after sudo mode
...
This should call the `applyGroupSelect` and not the `applySubadminSelect`.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-03-13 12:22:44 +01:00
f72373dfda
Create app password by pressing enter
...
Signed-off-by: Thijs den Hartog <Thijs@thijsbeer.nl>
2017-03-13 08:57:01 +01:00
3afc16bf77
clean search when new user is added
...
Signed-off-by: giorgia <g.sambrotta@gmail.com>
2017-03-03 14:47:47 +01:00
abc48f9e91
add emptycontent div, show/hide emptycontent div, fix #1070
...
Signed-off-by: giorgia <g.sambrotta@gmail.com>
2017-03-03 14:46:06 +01:00
413d671d9e
Merge pull request #3635 from individual-it/fix_quota_validation
...
better quota validation
2017-02-28 00:27:51 -06:00
f1fccaca06
better quota validation
...
this fixes #3634
1. fixed computerFileSize to be more picky about incorrect values
2. more tests for computerFileSize
3. use computerFileSize to validate user quota
Signed-off-by: Artur Neumann <info@individual-it.net>
2017-02-28 07:38:11 +05:45
387a77e7e0
Merge pull request #3590 from individual-it/correct_text_when_disabling_app
...
show correct text when disabling App
2017-02-23 10:32:19 +01:00
b138d4fdee
show correct text when disabling App
...
during the process of disabling an App the button would show "Enabling
app …"
This is corrected by this patch
Signed-off-by: Artur Neumann <info@individual-it.net>
2017-02-23 11:47:38 +05:45
2e88bec14b
Fix setup issue and refine error messages
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-02-15 17:45:38 -06:00
a37f29964f
add setting for "send password link"
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-02-15 17:45:20 -06:00
200a28255e
Always enable avatars
...
* we introduced this setting in the begining because our
avatar support caused some performance issues, but we
fixed them and should only provide one way how Nextcloud
looks
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-02-13 17:53:33 -06:00
33fb86f68b
Fix detection of the new iOS app
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-02-10 10:10:21 +01:00
89801f76ea
Use the provisioning api in the user management to handle group memberships
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-01-18 14:35:30 +01:00
aea1b72f54
Merge pull request #1594 from nextcloud/markdown-support-for-app-descriptions
...
Markdown support for app descriptions
2017-01-17 11:11:16 +01:00
76bc3bcdef
Allow ordered lists as well
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-01-16 15:00:54 +01:00
ddfc7e6a3f
Manually whitelist tags
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-01-13 18:58:18 +01:00
6a047a045a
Apply DOMPurify over HTML
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-01-13 18:58:18 +01:00
1a7d713883
Don't render non HTTP links, images and quotes
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-01-13 18:33:43 +01:00
1e453576dd
Render markdown
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-01-13 18:33:42 +01:00
c70b3f0e46
use tooltip in user list
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2017-01-13 14:01:15 +01:00
a3e31116b1
Update federationscopemenu.js
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-01-11 21:20:01 +01:00
89252497c6
fix wording for apps mgmt buttons
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2016-12-13 13:19:10 +01:00
73c4112770
Fix #2473
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2016-12-06 18:07:55 +01:00
ab993ad486
hide token configure menu when clicking outside it
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-12-06 15:43:37 +01:00
4f6993a15e
hide all other token dropdowns when showing one
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-12-06 14:11:54 +01:00
7fe02702b0
Merge pull request #2509 from nextcloud/sudo-mode-for-app-enabling
...
Add sudo mode to enabling and disabling apps
2016-12-05 22:06:14 +01:00
86a53b4e19
Merge pull request #2501 from nextcloud/issue-2472-remove-update-notification-after-updating
...
Remove the update warning and the notification after an successful up…
2016-12-05 15:33:41 +01:00
becde58952
Add sudo mode to enabling and disabling apps
...
Otherwise an administrator could bypass sudo mode by installing an app that allows RCE by design. I've by intention excluded the update endpoint from the requirement because updating apps should be as unintruisive as possible.
Not the cleanest approach by adding this to the AJAX endpoints instead of requiring a controller but for 11 this felt safer for me. We can clean this up together later then. (also the other AJAX endpoints in this folder do have the same logic)
Ref https://github.com/nextcloud/server/issues/2487
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-12-05 15:12:28 +01:00
decce7ec8d
Merge pull request #2502 from nextcloud/personal-settings-dead-code
...
remove dead js code from personal settings
2016-12-05 12:06:05 +01:00
3a653b56ee
Remove the update warning and the notification after an successful update
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-12-05 10:50:28 +01:00
46abd9e3d9
remove dead js code from personal settings
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2016-12-05 10:50:04 +01:00
b19b788e7a
Allow emtpy values on personal page and fix saving checkmark position
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2016-12-05 10:48:52 +01:00
0b4ff4f747
Fix password change in user management
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2016-11-30 13:36:37 +01:00
9dead382ef
Fix Regex for iPhone and add iPad
...
The previous Regex worked for an iPhone with version "10.0" but not with "10.0.1" which was wrong. I modified the Regex to also match for those situations.
I also added a Regex for the iPad
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-28 18:42:49 +01:00
dc4ceb7338
Loading icon fix #2198
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2016-11-24 17:28:21 +01:00
cbf943301f
Merge pull request #2224 from nextcloud/fix-visibility-switcher
...
Fix visibility switcher for avatar
2016-11-24 15:47:55 +01:00
e827be759d
Check if data is defined
...
Otherwise when adding a user as subadmin this would throw the following JS error:
```
users.js?v=bc2aae7…:500 Uncaught TypeError: Cannot read property 'message' of undefined(…)(anonymous function) @ users.js?v=bc2aae7…:500j @ jquery.js:3099fireWith @ jquery.js:3211x @ jquery.js:8264(anonymous function) @ jquery.js:8605
```
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-22 18:23:48 +01:00
91f735acf3
Make Christoph happier
...
Apparently this failed for him as per https://github.com/nextcloud/server/pull/2224#issuecomment-262085537
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-21 23:21:53 +01:00
267ecab405
Fix visibility switcher for avatar
...
Fixes #2223
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-21 21:50:57 +01:00
2a712abdfd
use date as device name if no name was given
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2016-11-21 20:28:21 +01:00
5aed91c321
small fixes
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2016-11-21 11:30:03 +01:00
16181c5463
Ask for password when scope is changed
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-21 11:30:02 +01:00
5acc3d3c5e
Highlight current entry
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-21 11:30:02 +01:00
a0c64044b2
Make JS aware of password verification
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-21 11:30:02 +01:00
f062c6daee
fix menu positioning hack
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2016-11-21 11:30:01 +01:00
e53e585e91
put explanatory text directly in popup
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2016-11-21 11:30:01 +01:00
845f0bd401
Fix position of menu
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-21 11:29:58 +01:00
f489fd99c3
change scope to 'local' for display name and avatar
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2016-11-21 11:29:58 +01:00
8f33d9d1c0
update system address book if the user change the personal settings
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2016-11-21 11:29:57 +01:00
9c7533ff6b
fix profile picture fed sharing scope menu
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2016-11-21 11:29:57 +01:00
d1233b47b0
use PUT to update user settings
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-21 11:29:38 +01:00
78f6e29954
Add federation scope to the user avatar
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-21 11:29:33 +01:00
20739c93a6
Persist settings on the server
...
Persist personal settings federated sharing scopes
Show new settings fields in read-only mode too
Insert values on page load
Return updated values; show inline success feedback
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-21 11:29:24 +01:00
c42d977185
Add more personal information fields to the settings page for enhanced federated sharing
...
fix layout
Add generic way of handling input change events
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-21 11:29:10 +01:00
332eaec4c0
Merge pull request #1447 from nextcloud/password-confirmation-for-some-actions
...
Password confirmation for some actions
2016-11-18 15:42:30 +01:00
3ffd9a755f
Fix user management callbacks
...
* properly handle user management actions like display name, email or password field change
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2016-11-18 14:19:07 +01:00
c241539a21
Merge pull request #2108 from nextcloud/properly-parse-ie-useragent
...
Properly parse IE 11 user agent
2016-11-18 13:39:47 +01:00
02ea134152
Fix error displaying on email and add confirmation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-18 12:10:51 +01:00
a53c313878
Require password confirmation to change the Quota
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-18 12:10:51 +01:00
309b21f5a0
Require confirmation to change the displayname
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-18 12:10:51 +01:00
a7feb91282
Confirm on create/delete group
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-18 12:10:51 +01:00
3dc3887dee
More fixes
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-18 12:10:51 +01:00
47f9574302
Hide and show after updating
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-18 12:10:50 +01:00
2fd2e45e42
Require password confirmation for user management
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-18 12:10:50 +01:00
62855c08ff
Require confirmation when changing the email settings
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-18 12:10:50 +01:00
6c3f0fd431
Fix error message displaying
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-18 12:10:50 +01:00
68fa1e5dd8
Require password confirmation for app password
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-18 12:10:50 +01:00
7100a1b347
Merge pull request #2146 from nextcloud/add_copy_tooltip_to_clipboard
...
Adds copy tooltip to clipboards
2016-11-16 17:57:35 +01:00
b7e6e9f83c
Fix tooltips - they now properly change on click
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2016-11-16 15:43:26 +01:00
9157f807cc
dropdown ui
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-11-16 15:24:32 +01:00
da63af8b02
enable deleting/configuring new tokens
...
Signed-off-by: Robin Appelman <icewind@owncloud.com>
2016-11-16 15:24:28 +01:00
1afccde16a
allow configuring filesystem access
...
Signed-off-by: Robin Appelman <icewind@owncloud.com>
2016-11-16 15:24:27 +01:00
b4e27d35f5
app password scope wip
...
Signed-off-by: Robin Appelman <icewind@owncloud.com>
2016-11-16 15:24:27 +01:00
9a613078f6
Properly parse IE 11 user agent
...
* fixes #2101
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2016-11-14 12:35:23 +01:00
ac2135560f
Fix single author with details
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-11 14:11:19 +01:00
78efb1972e
Fix route and js
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-11-06 14:05:53 +01:00
fe544d807a
Removed else statement preventing Success message from displaying causing bug #1875
...
Signed-off-by: Henry Mohn <hmohniii@gmail.com>
2016-11-04 20:40:42 +00:00
e81d04cd8d
Merge pull request #1940 from nextcloud/new-appstore
...
Use new appstore API
2016-11-02 17:00:24 +00:00
a68595742b
Proxy images through usercontent.apps.nextcloud.com
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-31 17:17:47 +01:00
32cf661215
Use new appstore API
...
This change introduces the new appstore API in Nextcloud.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-31 17:17:44 +01:00
247b7f37ce
Color the trusted domain to alert the admin a bit more
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-31 12:22:21 +01:00
890f752a6b
Merge pull request #1452 from nextcloud/appconfig-endpoint
...
Appconfig endpoint
2016-10-25 10:57:48 +02:00
cfae91ab64
Merge pull request #1828 from nextcloud/avatar-picker-improvements
...
Avatar picker improvements
2016-10-24 16:33:18 +02:00
0aec8647c2
use smaller cropper on small screens
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-10-24 13:56:21 +02:00
55c445ff39
set initial cropper to max size
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-10-21 15:08:36 +02:00
3cbaec416a
Fix personal page
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-21 09:51:36 +02:00
103bf6dd28
Switch to public API
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-21 09:09:26 +02:00
0b1fb180a5
Make AppConfig part of the public API
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-21 09:09:23 +02:00
ac167d4dc6
show spinner while loading/cropping avatar
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-10-20 16:36:03 +02:00
154fbe06ce
only show cropper dialog when the cropper is ready
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-10-20 16:25:11 +02:00
9983b5533a
float the avatar cropper over the page
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-10-20 16:23:54 +02:00
5a44b70efc
Prevent flashing the full sized image when cropping an avatar
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-10-20 15:57:34 +02:00
9c3e855812
The red box already makes clear it's an error
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-18 16:22:20 +02:00
f590bb1b3a
Merge pull request #1701 from nextcloud/impr-user-list
...
tidy up adding user to list a little bit
2016-10-13 12:23:12 +02:00
e378cadb56
tidy up adding user to list a little bit
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-11 12:41:19 +02:00
d511acdf66
Better search functionality
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-11 10:35:02 +02:00
b1314942d7
Fix authors that have a mail or homepage
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-11 10:23:45 +02:00
e3717fd466
Improve user list rendering perf by not resorting after every add ( #26282 )
...
The call to UserList.add() was wrong and was passing "user.lastLogin"
as the sort argument which would cause the list to be resorted over and
over again for every added item after loading the next page of users.
2016-10-10 14:51:13 +02:00
8fecf8503a
Merge pull request #1229 from nextcloud/bugfix/change-password-changes
...
Bugfix/change password changes
2016-10-06 12:44:50 +02:00
4afb5d5527
remove old indicators for "saving started" and "saving successful"
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2016-10-06 10:16:50 +02:00
acd90669ff
Fix displaying and searching with multiple authors
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-09-30 11:15:56 +02:00
6b2680f5f5
Removes spinner in case password is wrong as well.
2016-09-17 14:38:26 +02:00
b30908ba5d
Removes tipsy when password verification is going on
2016-09-17 14:38:26 +02:00
16711a2f99
Removes the check mark after 5 second timeout.
2016-09-17 14:38:26 +02:00
91ffb63595
Adds a checkmark when the change is complete.
2016-09-17 14:38:26 +02:00
682ed7ff8f
Disables teh button when clicked change password.
2016-09-17 14:38:26 +02:00
6bb95de1c5
Adding a optional disclaimer to the anonymous upload page
2016-09-08 18:44:27 +02:00
14136295b7
Cache avatars properly
...
* Set proper caching headers for avatars (15 minutes)
* For our own avatar use some extra logic to invalidate when we update
2016-08-30 09:00:16 +02:00
17964a8955
Extra non-available groups also in list
2016-08-29 13:34:28 +02:00
e8c2d62c6b
Users page lazy multiselect group dropdowns
...
Instead of pre-rendering all multiselects with lots of group entries,
the current groups are now displayed as simple labels.
Behind the labels there is a pencil icon like for other fields.
When clicking the pencil icon, the dropdown will be spawned and will
open itself.
Upon closing of the dropdown, the label comes back with the updated
selection and the dropdown is destroyed.
2016-08-29 13:34:13 +02:00
abb3127ff2
fix setting quota to default or unlimited
2016-08-25 15:55:30 +02:00
dfb66e1101
25532_issue_password_update_notification_updated ( #25756 )
...
* Password Update Notification
Added an IF ELSE statement to ensure that feedback is provided to the
user on successfully updating a user password in settings.
* Password Update Success Message
Updated the password update success message
2016-08-19 13:31:19 +02:00
77bce68b45
Fix some jshint errors in settings/users
2016-08-19 10:46:42 +02:00
59da5972f6
SVG defintions always take the first one
...
* Move filter definition out
2016-08-18 16:16:01 +02:00
5581a602cc
Add cachebuster to app icons in the admin screen
2016-08-18 12:44:33 +02:00
28c192c9f5
Fix null reference in IE
2016-08-17 16:04:53 +02:00
bded787d0c
Empty tags are not allowed for image and feColorMatrix in IE11 and below
2016-08-17 15:59:30 +02:00
314b4005bb
Remove hack
2016-08-17 15:16:48 +02:00
1444c1d345
Introduce weird hack for Firefox
...
* everything is 4 times as big (doubled width and doubled height)
2016-08-17 14:45:08 +02:00
960d0d1242
Filter can't be named invert in FF
2016-08-17 13:36:17 +02:00
7c61fa14ae
Fixes image preview when fetched from the store.
2016-08-15 00:49:33 +05:30
c489cd4d3a
Uses javascript to invert the SVGs.
2016-08-11 12:59:57 +05:30
7d643fc539
Add sliding animation
2016-08-10 09:17:14 +02:00
965804425d
Add clipboardjs for token
2016-08-10 09:10:39 +02:00
de44ab0244
Always show delete icon for new tokens
...
* Always show delete icon
* Hide form if the new icon is deleted
2016-08-10 08:58:57 +02:00
c8e4988f85
Apply inverted app icon style to newly installed icons
2016-08-01 21:48:06 +02:00
d705b936a9
fix capitalization of text in users management
2016-07-28 11:30:36 +02:00
2ba5785d68
sort tokens
2016-07-20 15:59:00 +02:00
eb3410322e
improve matching safari user agent
2016-07-20 14:13:23 +02:00
df2dffaf7c
add fancy formating for most browsers
2016-07-19 11:27:58 +02:00
fac970b065
format current and sync client sessions in Personal
2016-07-18 19:39:03 +02:00
3c432a8afe
Use tooltip for ssl certs table
2016-07-13 10:00:02 +02:00
cf79417490
Use tooltip for background job execution time
2016-07-13 09:59:42 +02:00
e9eb94e899
Use tooltip for app management badges
2016-07-13 09:59:08 +02:00
ba16fd0d33
Merge branch 'master' into sync-master
2016-07-07 11:29:46 +02:00
387ac9e048
Merge pull request #25240 from owncloud/remove-svg
...
Remove SVG fallback
2016-07-04 17:49:00 +02:00
a48df671a3
Merge pull request #25253 from owncloud/users-fixotherquotadropdown
...
Fix "Other" value handling in quota dropdown in users page
2016-07-04 16:13:18 +02:00
c47833718f
remove svg classes
2016-07-01 16:36:37 +02:00
c9a2790893
prevent users from deleting their own session token
2016-06-28 16:17:37 +02:00
6670d37658
Merge remote-tracking branch 'upstream/master' into master-sync-upstream
2016-06-27 18:23:00 +02:00
2a990a0db5
verify user password on change
2016-06-27 14:08:11 +02:00
579bc57d16
Merge pull request #25261 from owncloud/app-password-login-name
...
show which login name to use for the new app password
2016-06-27 13:40:20 +02:00
b9edcd78bf
Merge pull request #25252 from owncloud/authtoken-removetooltipondisconnect
...
Remove tooltip when disconnecting token
2016-06-27 10:42:35 +02:00
7a9d60d87e
Merge remote-tracking branch 'upstream/master' into master-upstream-sync
2016-06-26 12:55:05 +02:00
1454b4515c
fix layout
2016-06-24 17:00:59 +02:00
26aacb4e62
show which login name to use for the new app password
2016-06-24 15:31:48 +02:00
0501d8daac
Prevent negative or non-number values in quota input
2016-06-24 09:20:13 +02:00
9092d7f5ea
Fix "Other" value handling in quota dropdown in users page
...
Prevents "other" value to be deleted.
When appending custom value, put it above the "other" entry.
2016-06-23 18:42:11 +02:00
9524115c2c
Remove tooltip when disconnecting token
2016-06-23 18:30:45 +02:00
da4ba82b83
Use OC.Backbone instead of Backbone directly in authtoken JS code
...
Fixes asset pipeline issue with the auth token in personal page
2016-06-23 18:26:01 +02:00
31f3aaa36b
app passwords/device tokens wording
2016-06-21 16:39:51 +02:00
7f22aeb5d6
redirect to new login route ( #25099 )
...
* redirect to new login route
* encode anchor in url and restore it client-side
2016-06-21 16:14:51 +02:00
19b531fd14
fix more strings
2016-06-20 13:14:24 +02:00
205e936370
rename owncloud to nextcloud in Official apps button popup
2016-06-20 01:58:39 +02:00
a5a66f38f1
Fix tooltip position in token list
2016-06-17 15:11:31 +02:00
ea25be51da
fix strengthify in personal settings
2016-06-15 15:27:40 +02:00
edf62eb41a
Add user ID to log entries in admin page
2016-06-10 15:38:21 +02:00
a9ea908413
add tooltip to token names
2016-06-10 14:49:56 +02:00
2989584b45
decrease initial users to load to 50
...
Prevents timeouts on the initial loading of users. proper fix will be in https://github.com/owncloud/core/pull/10994
Workaround for https://github.com/owncloud/core/issues/24734
2016-06-07 11:40:04 +02:00
1671d8e337
remove debug console.log
2016-05-24 13:40:01 +02:00
74277c25be
add button to invalidate browser sessions/device tokens
2016-05-23 09:11:12 +02:00
6495534bcd
add button to add new device tokens
2016-05-23 09:11:12 +02:00
12431aa399
list user's auth tokens on the personal settings page
2016-05-23 09:11:12 +02:00
79f6b7b7ff
Make it possible to exclude admin groups from groups select2
2016-05-20 17:56:02 +02:00
bc1d70f08c
Pass on the error message from the user manager to the UI ( #24526 )
2016-05-11 19:41:13 +02:00
9ad30f9c92
Merge pull request #22783 from patelfenil/bugfix-issue-17320
...
Remove image now not coming when user changes fullname. Fixes #17320
2016-04-25 23:02:00 +02:00
e4a8456d01
replace $().attr('checked') by $().prop('checked', state) or $().is(':checked')
2016-04-19 16:20:17 +02:00
05d203a989
replace $.parseJSON() by JSON.parse()
2016-04-19 15:06:42 +02:00
ff1150bb4d
Properly escape URL
...
Fixes https://github.com/owncloud/core/issues/23499
2016-04-18 17:43:20 +02:00
e90a3b5ba7
Merge pull request #23954 from stweil/master
...
misc: Fix some typos
2016-04-13 11:08:58 +02:00
ee5f5eebe5
misc: Fix some typos
...
Some of them were found by codespell.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2016-04-12 18:36:39 +02:00
7365bd798a
Show tooltip if the app is downloaded from a remote server
...
fixes #14405
2016-04-12 09:39:53 +02:00
a8a98d42cb
improve emptycontent styles
2016-03-31 15:31:04 +02:00
52f51c94db
Merge pull request #15750 from owncloud/loading-feedback-email-usermanagement
...
Add loading feedback for email change in user management
2016-03-31 11:24:27 +02:00
a25872e034
Merge pull request #23495 from owncloud/disable-paste-zone
...
Disable pastezone for jquery.fileupload
2016-03-23 09:03:50 +01:00
f8ae1bb36e
Disable pastezone for jquery.fileupload
...
jquery.fileupload offers the [`pastezone`](https://github.com/blueimp/jQuery-File-Upload/wiki/Options#pastezone ) functionality. This functionality is enabled by default and if somebody copy-pastes something into Chrome it will automatically trigger an upload of the content to any configured jquery.fileupload element embedded in the JS.
This implementation triggers some problems:
1. The pastezone is defined globally by default (🙈 ). So if there are multiple fileupload's on a page (such as in the personal settings) then stuff is going to be uploaded to all embedded uploads.
2. Our server code is not able to parse the data. For example for uploads in the files app we expect a file name which is not specified => Just an error is thrown. You can reproduce this by taking a file into your clipboard and in Chrome then pressing <kbd>CTRL + V</kbd>.
3. When copy-pasting some string from MS Office on the personal page a temporary avatar with said content is created.
Considering that this is anyways was never working at all and causes bugs I've set the `pastezone` to `null`. This mens that upload via copy and paste will be disabled.
Lesson learned: Third-party JS libraries can have some weird details.
2016-03-22 20:28:57 +01:00
35024beb9c
Add `allow sharing with groups` checkbox to admin page
2016-03-22 17:13:34 +01:00
876e032d09
Merge pull request #23370 from owncloud/fix-username-change
...
Update avatar on username change if avatar is set
2016-03-17 19:50:12 +01:00
37d7712411
Rating icons changed to .svg
2016-03-17 17:37:45 +01:00
d79c8c6d13
Update avatar on username change if avatar is set
...
* fixes #20455
2016-03-17 17:34:22 +01:00
aa2b008577
Add loading feedback for email change in user management
...
* show loading indicator while the request is running
* change value after the request succeed - not before and
undo maybe wrong changes
* move markup to HTML template
* show notification temporarily
2016-03-16 17:09:20 +01:00
5fb96a4630
Remove image now not coming when user changes fullname. Fixes #17320
2016-03-07 21:20:29 +05:30
b2bf8f10de
Delete empty file
...
Ref https://github.com/owncloud/core/issues/22803#issuecomment-191749499
2016-03-03 14:04:54 +01:00
1dbe240b0e
Disable app that bricks the server after enabling
...
If an app is getting enabled in the web UI, an ajax call is now made to
make sure the server still works. If it doesn't, it sends an emergency
app disabling call to disable the breaking app.
2016-02-29 12:07:37 +01:00
04da5a56dd
Use the notification instead of the disruptive popup
2016-02-22 09:29:13 +01:00
87746e4ae8
Make app updates better visible
2016-02-18 09:55:11 +01:00
a3eaefa530
Save display name and email address on paste operations - fixes #22245
2016-02-09 16:20:04 +01:00
f0752d7ba1
Allow to delete the email address in user management
2016-02-05 10:27:18 +01:00
faf48e42b7
Move data protection check to javascript
...
fixes #20199
2016-02-01 18:57:58 +01:00
751e99512a
Hide the delete button, until we know its a custom avatar
2016-01-26 12:59:58 +01:00
3038006e8e
Add a default app icon for apps that don't have one
2016-01-22 11:38:11 +01:00
0461b9dbb9
Add a new app type that can not be enabled for groups
2016-01-14 15:45:47 +01:00
ca4f24aa97
Merge pull request #21509 from owncloud/users-scrolltop
...
Keep scroll position in users page when sorting
2016-01-13 11:00:48 +01:00
eac5d9fb3a
Merge pull request #21336 from owncloud/system-root-certs
...
Allow admins to add system wide root certificates
2016-01-12 15:01:46 +01:00
c15cab7ed6
Allow admins to add system wide root certificates
2016-01-12 12:50:59 +01:00
8b6b042ffd
Add config switch to disable the .well-known URL check
2016-01-12 09:53:23 +01:00
f4c04c5f28
Concat also the other results
...
Otherwise this will ignore the two last checks 🙊
2016-01-10 11:39:44 +01:00
0161928fc3
Add check for .well-known URL in the root of the webservers URL
...
* fixes #20012
2016-01-08 23:27:29 +01:00
3a494033d2
Allow searching apps by ID
2016-01-07 16:33:25 +01:00
44f4195eee
Keep scroll position in users page when sorting
...
When sorting, some browsers like Chrome will lose the scroll position,
possibly because the sorting code is touching the DOM elements.
This fix saves the scroll position before sorting and sets it back
afterwards.
2016-01-07 15:48:59 +01:00
e4cf53031b
fix overlap and functionality of cropper
2015-12-28 19:23:40 +01:00
640adde3b9
improve layout of personal settings page
2015-12-28 18:50:50 +01:00
6248bad0f7
Add a default size to the avatar placeholders
...
This removed the need to do an avatar request on the "empty" row in the
user settings.
2015-12-17 16:30:23 +01:00
3818a055b9
Merge pull request #21255 from owncloud/usermanagement-show-password-error-temporary
...
user management: show password error temporary
2015-12-17 16:25:14 +01:00
a81836a42f
Only load the big (128x128) avatar on the perosnal page
...
Before the code was executed on every page if a user was logged in. Now
only on the personal page. Thus saving a request on all other pages.
2015-12-17 13:55:22 +01:00
7a86f10ebc
Update users.js
2015-12-17 12:43:44 +01:00
4f860b7e0a
Merge pull request #20978 from owncloud/fix-dont-show-unsaved-values-in-usermgmt
...
reset mailadress/displayname on blur
2015-12-11 12:15:01 +01:00
cf0d163a32
reset mailadress/displayname on blur
2015-12-07 09:48:54 +01:00
8c9a3ccefc
Do not request an avatar if there is none
2015-12-04 14:56:49 +01:00
50d862e5d1
[Avatars] JS should not load same avatar twice
...
Old code first dit an ajax request to the avatar. Then a new image
object with the same src was created and since we do not cache avatars
yet :( this resulted in 2 sequential requests to the exact same URL
Now if you set the displayname it will first set the placeholder and
then load the avatar in the background. Only once this time!
2015-12-04 10:42:11 +01:00
3ea654d2d4
Use .text instead of .html
...
Makes some static source code analyzers happier.
2015-11-30 23:49:27 +01:00
0265bcfdae
Moved changedisplayname to usercontroller
...
Killed the old static route to change a users display name and moved it
to a properly testable controller.
2015-11-20 16:05:43 +01:00
267d30d4f6
Fix #18072
2015-11-10 10:28:23 +01:00
6959d5ca22
Properly detect setup check messages set in the HTML template
2015-11-08 00:02:59 +00:00
b162761124
Merge pull request #20157 from owncloud/users-fixeveryonecount
...
Fix everyone count for subadmins
2015-11-04 10:28:56 +01:00
7e2fe08778
new checkbox style in app settings
2015-10-31 17:07:07 +01:00
781bca2437
Fix everyone count for subadmins
...
Also moved the logic to the UsersController
2015-10-29 17:41:49 +01:00
69417e3654
Initially load at least 250 users
2015-10-28 11:55:16 +01:00
2849f19cfe
Fix backwards and forward button
2015-10-26 17:05:31 +01:00
e19c49295a
Use speaking ids
2015-10-26 16:15:15 +01:00
618a08aa00
Fix backspace in search and empty content message
2015-10-26 16:15:15 +01:00
145865ade0
Display empty-content when there are no search results
2015-10-26 16:15:14 +01:00
69e4a806b7
Clear search box for now
...
Fix #15651
2015-10-26 16:15:14 +01:00
6532fe8e24
Allow searching by author name and app level as well
2015-10-26 16:15:14 +01:00
a9a6d4c182
Stay on the same category when refreshing the page on the apps list
2015-10-26 16:15:14 +01:00
89e3860e1a
Disable app icon preview in apps page for IE
...
All IE versions are not able to properly upscale SVG icons unless the
said SVG files contain a "viewBox" attribute, which is not always the
case. Also we cannot guarantee that all third party apps will have this
attribute in their icons.
So for now, app icons will not be displayed in IE instead of broken
ones.
2015-10-21 10:50:06 +02:00
df1313d025
Merge pull request #19625 from owncloud/passwordchange-hidestrengthify
...
Properly hide strengthify after password change
2015-10-14 12:52:07 +02:00
4b8632325a
Merge pull request #19627 from owncloud/users-deletebeforecreate
...
Delete last undoable user before user creation
2015-10-14 12:51:51 +02:00
c7aef6c368
Fix uploading avatar and root certs in IE8
2015-10-09 11:19:05 +02:00
14dc36efe6
Properly hide strengthify after password change
2015-10-07 17:56:28 +02:00
a73f31d3a5
Delete last undoable user before user creation
2015-10-07 16:17:38 +02:00
999196b9fb
fix wording
2015-10-06 11:35:08 +02:00
264d123396
Use OC.Dialogs for modal reload message
2015-10-05 22:07:24 +02:00
69d68fbe8e
Reload the page when an app needs an update after being enabled
2015-10-05 22:07:24 +02:00
8944cb539e
Merge pull request #19510 from owncloud/json-grouplist-sharing-exclude
...
save excluded groups in json format
2015-10-02 12:14:36 +02:00
3ce45863ab
Modify the group user count when changing membership of a user
2015-10-02 08:55:53 +02:00
b2dd5cb616
save excluded groups in json format - fixes #10983
2015-10-01 15:37:55 +02:00
Arthur Schiwon
Joas Schilling
Robin Appelman
m4dz
Christoph Wurst
Morris Jobke
Thomas Pulzer
Bjoern Schiessle
Jan-Christoph Borchardt
Lukas Reschke
Julius Härtl
Felix A. Epp
Roeland Jago Douma
Felix Heidecke
Michael Letzgus
Thijs den Hartog
giorgia
Artur Neumann
tobiasKaminsky
John Molakvoæ
John Molakvoæ (skjnldsv)
Roeland Jago Douma
Christoph Wurst
Robin Appelman
Henry Mohn
Michael Grosser
Vincent Petry
Raghu Nayyar
Jack Davis
Hendrik Leppelsack
Lukas Reschke
Christoph Wurst
Timo Witte
Jörn Friedrich Dreyer
Joas Schilling
Thomas Müller
Stefan Weil
Thomas Müller
Roeland Jago Douma
Pau
patelfenil
Joas Schilling
Vincent Chan
michag86
Robin McCorkell