55ad6c1fa2
Properly return an int in the getId function of the cache
...
fixes #16684
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-08-08 06:15:46 +00:00
e7920203ba
Add additional check for read permissions
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-07-29 15:00:12 +00:00
f1f755740d
Check the if we can actually access the storage cache for recent files
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-07-29 15:00:11 +00:00
5959245417
Do not log all locked exceptions
...
This can happen for valid reasons (multiple users writing at the same
time) with for example the text app. Apps should properly handle it. No
reason to log it by default.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-07-27 08:40:00 +00:00
a9ccac2f20
treat sensitive config keys by pattern
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-07-26 13:21:22 +00:00
3f5ce65879
Lock SCSS so we only run 1 job at a time
...
This is bit hacky but a start to lock the SCSS compiler properly
Retry during 10s then give up
Properly get error message
Do not clear locks and properly debug scss caching
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-07-25 13:44:06 +00:00
c7322c7efd
PHPStorm code cleanup
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-07-24 09:51:23 +00:00
27a6f8020b
Get the topmost parent for the parent instead of doing endless recursion
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-07-24 09:51:22 +00:00
abd714d685
Pass $configargs to openssl_pkey_export
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-07-22 14:37:10 +02:00
21822512dc
Fix File#putContents(string) on ObjectStorage
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2019-07-17 20:39:24 +00:00
8e6ac9d678
Do not keep searching for recent
...
If userA has a lot of recent files. But only shares 1 file with userB
(that has no files at all). We could keep searching until we run out of
recent files for userA.
Now assume the inactive userB has 20 incomming shares like that from
different users. getRecent then basically keeps consuming huge amounts
of resources and with each iteration the load on the DB increases
(because of the offset).
This makes sure we do not get more than 3 times the limit we search for
or more than 5 queries.
This means we might miss some recent entries but we should fix that
separatly. This is just to make sure the load on the DB stays sane.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-07-17 05:47:57 +00:00
f7a6f4527e
Log RuntimeException in CleanupCardDAVPhotoCache
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-07-16 06:06:01 +00:00
c208ea49d4
Add catch for RuntimeException
...
getDirectoryListing can throw a NotFoundException or a RuntimeException.
The repair step should be skipped if the cache directory is missing so
a catch for both exceptions is required.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-07-16 06:06:01 +00:00
89f3df067f
addsubtag should push to array
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2019-07-15 06:45:58 +00:00
b62b835f6c
Use HTTP1.1 to read S3 objects
...
Some of the READs otherwise use HTTP/1.0 which is not always supported
by all backends. HTTP/1.1 is there since 1999 way longer than S3 so safe
to assume it is always there IMO.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-07-10 13:20:38 +00:00
ecf60b59ef
Merge pull request #16254 from nextcloud/backport/16208/stable16
...
[stable16] Always set the display name for user shares
2019-07-09 14:44:01 +02:00
ac3cc7829f
Try to delete the cypress folder of the viewer app
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-07-08 17:19:34 +00:00
662fd359f5
Always set the display name for user shares
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-07-05 12:53:45 +00:00
03005dea43
Unify the permission checking in one place only
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-07-03 18:08:08 +00:00
16d1354239
Better check reshare permissions when creating a share
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-07-03 18:08:08 +00:00
e19240b60b
Allow apps to overwrite the maximum length when reading from database
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-07-01 14:39:54 +00:00
555b62a619
verify that paths are valid for recursive local move
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-06-27 14:37:35 +00:00
193e8a750e
Allow apps to store longer messages in the comments API
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-06-27 08:05:02 +00:00
33663ff04e
Merge pull request #16082 from nextcloud/backport/15832/stable16
...
[stable16] Fix full text search for groupfolders
2019-06-26 15:49:12 +02:00
1066e4a952
Fall back to black for non-color values
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-06-26 08:18:17 +00:00
8c1ce34a03
Fix full text search for groupfolders
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-06-25 19:45:27 +00:00
42930f6fab
handle storage exceptions when trying to set mtime
...
not all storage backends can handle setting the mtime and they might
not always handle that error correctly.
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-06-25 15:57:59 +02:00
ab13fe80e4
Revert "[stable16] Fix userid casting in notifications"
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-06-25 12:39:40 +02:00
92f11a646b
Prevent faulty logs from nested setupFS calls
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-06-21 10:01:28 +00:00
9346718cc2
Fix userid casting in notifications
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-06-11 16:31:25 +00:00
376e570b15
Fix missing login hook wih Apache/SAML
...
Without this patch the hook does not transport the information whether the login is
done with an app password or not. The suspicious login app requires the parameter
to function correctly, hence adding it will make suspicious login detection also possible
with SAML users.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-06-11 07:42:25 +00:00
4488293d62
search files by id in shared storages last
...
this prevents unneeded recursion when the file is not in the share
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-05-29 19:57:31 +00:00
7764979281
Check for free space on touch
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-05-28 13:04:49 +00:00
90ca099341
Don't notify admins if no potentially over exposing links found
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-05-27 09:52:20 +00:00
2e567918c1
Check the actual status code for 204 and 304
...
The header is the full http header like: HTTP/1.1 304 Not Modified
So comparing this to an int always yields false
This also makes the 304 RFC compliant as the resulting content length
should otherwise be the length of the message and not 0.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-05-24 17:51:52 +00:00
e643a3e8fb
Allow redis cluster to use password
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-05-22 11:48:04 +00:00
ce3da21b65
Fix l10n for SettingsManager by injecting the l10n factory
...
Fixes #10832
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-05-21 22:51:26 +00:00
9ed21f521b
Only show sharing section if it has content
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-05-21 08:33:55 +00:00
0e8829b8df
Show supported apps in app management
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-05-17 12:21:11 +02:00
0751c1f5f8
Add interfaces to interact with subscription from support app
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-05-13 11:34:59 +00:00
3ab884a479
Use non-absolute logout URL to fix wrong URL in reverse proxy scenario
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-05-08 17:37:19 +00:00
8be9c9b0d9
fix class might be undefined
...
Co-Authored-By: blizzz <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-08 13:52:11 +00:00
b70053be25
remove args from logging of common-spelled methods dependent on class
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-08 13:52:11 +00:00
7886642979
remove setup args from logging
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-08 13:52:10 +00:00
5f93c754b4
Set type for access column on cacheAccessForCollection
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-05-07 22:07:54 +00:00
ecd29001d7
remove extra param in cache update call
...
param was leftover from earlier iterations of the "update event"
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-05-07 15:59:10 +00:00
50827582b6
Make sure all middlewares are only registered once
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-05-06 21:38:13 +00:00
be5cc3a973
Remove the custom prefix from the table name length when checking on the default primary index
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-04-30 12:20:31 +00:00
aa91b0ab3c
take return of mkdir into account, throw exception on failure
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-04-30 07:26:41 +00:00
35ba5ae2a0
remove obsolete use statements
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-04-24 18:02:15 +00:00
Roeland Jago Douma
Julius Härtl
Arthur Schiwon
Joas Schilling
Daniel Kesselberg
Marcel Klehr
Morris Jobke
Maxence Lange
Robin Appelman
Roeland Jago Douma
John Molakvoæ (skjnldsv)
Christoph Wurst
Joas Schilling