Commit Graph

7997 Commits

Author SHA1 Message Date
Morris Jobke 0bae516c66
Merge pull request #9224 from nextcloud/accessibility-improvements
Add labels for Contacts menu and Settings, thanks to @MarcoZehe
2018-04-19 14:47:17 +02:00
Morris Jobke 4d71e12a43
Merge pull request #9237 from nextcloud/fix-ids-of-permission-checkboxes-for-shares
Fix ids of permission checkboxes for shares
2018-04-19 14:11:51 +02:00
Nextcloud bot 7ca526f8ac
[tx-robot] updated from transifex 2018-04-19 00:11:50 +00:00
Daniel Calviño Sánchez f8e3b572c8 Remove no longer needed escaping of special characters
The escaping of special characters was needed when the ids of the
permission checkboxes for shares were based on the "shareWith" field.
Since they are based on the "shareId" field the escaping is no longer
needed, as the "sharedId" is expected to always contain compatible
characters.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-18 17:03:45 +02:00
Jan-Christoph Borchardt 0f9ba852bc
Fix form labels and main landmark on log in page
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 16:14:09 +02:00
Jan-Christoph Borchardt 1c00f82ea5
Do not restrict zooming in
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 15:51:52 +02:00
Jan-Christoph Borchardt 0ee9924b16
Add aria-label to more-apps menu as well
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 15:40:47 +02:00
Jan-Christoph Borchardt 0d675eca56
Ensure proper color contrast according to WCAG AA
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 15:38:30 +02:00
Daniel Calviño Sánchez 1466586033 Fix ids of permission checkboxes for shares
The ids of permission checkboxes for shares were generated using the
"shareWith" field of the share. The "shareWith" field can contain spaces
(as spaces are allowed, for example, in user or circle names), so this
could cause the id attribute of the HTML element to contain spaces too,
which is forbidden by the HTML specification.

It is not just a "formal" issue, though; when the list was rendered, if
the id contained a space the selector to get the checkbox element was
wrong (as it ended being something like
"#canEdit-view1-name with spaces") and thus the initial state of the
checkbox was not properly set.

Besides that, "shareWith" can contain too single quotes, which would
even cause the jQuery selector to abort the search and leave the UI in
an invalid state.

Instead of adding more cases to the regular expression to escape special
characters and apply it too when the ids are created now the ids of
permission checkboxes for shares are based on the "shareId" field
instead of on "shareWith", as "shareId" is expected to always contain
compatible characters.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-18 15:25:23 +02:00
Jan-Christoph Borchardt df3c1ac283
Add proper ARIA attributes and structure to header for accessibility, thanks to @MarcoZehe
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 15:07:42 +02:00
Nextcloud bot d4aa4ff1f4
[tx-robot] updated from transifex 2018-04-18 00:13:30 +00:00
Morris Jobke 0d5142be70
Show a link to the docs instead of a button on the untrusted domain page
Before there was a button to "quickly" add the untrusted domain to the config. This button often didn't worked, because the generated URL was often untrusted as well. Thus removing it and providing proper docs seems to be the better approach to handle this rare case.

Also the log should not be spammed by messages for the untrusted domain accesses, because they are user related and not necessarily an administrative issue.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-17 17:47:11 +02:00
Morris Jobke db8bcfc5f6
Merge pull request #9172 from nextcloud/karma-avatar-tests-fix
Fix js tests with placeholder
2018-04-16 11:32:30 +02:00
Nextcloud bot 13b5e257ab
[tx-robot] updated from transifex 2018-04-14 00:11:46 +00:00
John Molakvoæ (skjnldsv) 6cb40cf0c4
Fix js tests with placeholder
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-13 10:20:51 +02:00
Nextcloud bot b7a64f9c13
[tx-robot] updated from transifex 2018-04-13 00:11:47 +00:00
Jan-Christoph Borchardt 04f47a7653
Merge pull request #8535 from nextcloud/new-color-generator
New color generator algorithm
2018-04-12 14:37:53 +02:00
Morris Jobke d3f2b6aef4
Merge pull request #8820 from nextcloud/mtime-sort
Sorts filepicker files by modified date
2018-04-12 10:54:44 +02:00
Nextcloud bot af53f48ce2
[tx-robot] updated from transifex 2018-04-12 00:19:20 +00:00
Nextcloud bot ecc3bc64aa
[tx-robot] updated from transifex 2018-04-11 00:21:34 +00:00
Morris Jobke e302266a6a
Merge pull request #9137 from nextcloud/default-log-rotate-size
Set the default log rotate size to 100 MB
2018-04-11 02:10:54 +02:00
Morris Jobke 52c0e02bdc
Merge pull request #8910 from nextcloud/fix-login-error
Avoid to leak a user ID that is not a string to reach a user backend
2018-04-11 01:06:38 +02:00
Roeland Jago Douma a3c2035674
Merge pull request #9128 from nextcloud/bugfix/9076/make_oracle_happy
Also make the uid_lower migration work on oracle
2018-04-11 00:41:53 +02:00
Morris Jobke 058f8123e6
Set the default log rotate size to 100 MB
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-11 00:27:51 +02:00
Roeland Jago Douma a07f6d46e3
Use proper types
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-11 00:21:25 +02:00
Morris Jobke fd3c97b93b
Avoid to leak a user ID that is not a string to reach a user backend
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-11 00:03:30 +02:00
Jan-Christoph Borchardt 8d27dce716
Merge pull request #9002 from nextcloud/whitespace
More whitespace: Increase header height from 45px to 50
2018-04-10 23:05:01 +02:00
Julius Härtl 85cb130510
Fix max-width to fit the new margin
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-10 21:34:51 +02:00
Roeland Jago Douma 24cfee8cdd
Also make it the uid_lower migration work on oracle
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-10 10:47:31 +02:00
Nextcloud bot 323ee3cbdc
[tx-robot] updated from transifex 2018-04-10 00:12:10 +00:00
Roeland Jago Douma 123d9f0ce9
Merge pull request #8777 from nextcloud/various-css-fixes
Various css fixes
2018-04-09 10:19:50 +02:00
Roeland Jago Douma b2350810e0
Merge pull request #9115 from nextcloud/feature/noid/login_flow_wording
Improve login flow
2018-04-09 08:45:27 +02:00
Roeland Jago Douma 04f8b99dce
Merge pull request #9118 from nextcloud/video-switch
Add video switch icon
2018-04-09 07:12:24 +02:00
Roeland Jago Douma 177c8972cc
Improve login flow
* Add page explaining you are about to grant access
* Show grant access page after login

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-08 13:42:36 +02:00
Nextcloud bot 72e8ab14ac
[tx-robot] updated from transifex 2018-04-08 00:12:00 +00:00
Jan-Christoph Borchardt 203a8f293b
Add video switch icon
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-07 20:53:36 +02:00
Nextcloud bot 9f194bc682
[tx-robot] updated from transifex 2018-04-07 00:11:49 +00:00
Roeland Jago Douma 33b93db953
Remove unused parameter
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 21:44:23 +02:00
John Molakvoæ (skjnldsv) 275b9868b2
Fixed documentation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-06 21:32:45 +02:00
John Molakvoæ (skjnldsv) bca8d83f02
New algorithm
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-06 21:32:44 +02:00
Roeland Jago Douma 2b7d4d5069
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 19:58:37 +02:00
Roeland Jago Douma caee215120
Always remember me
Fixes #8004

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 15:44:28 +02:00
Roeland Jago Douma e970e9f710
Merge pull request #9076 from nextcloud/feature/7573/user_db_backend_index
Make select queries on user DB backend indexable
2018-04-06 14:56:19 +02:00
Roeland Jago Douma 31454c2072
Bump autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 14:14:58 +02:00
Roeland Jago Douma f90299face
Silence phan
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 13:46:32 +02:00
Roeland Jago Douma 7a7d424e91
Add an uid_lower column to the oc_users table
Add a new column.
In the postSchemaChange copy over the values (with lower).

This should work just fine as this is a very simple operation.
Even if you have 1M users in the db backend this should be fast
enough.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 13:42:50 +02:00
Morris Jobke 2a2ab1b871
Merge pull request #9084 from nextcloud/public-page-template-extend
Public page template enhancements
2018-04-06 13:16:26 +02:00
Nextcloud bot a97b9bf605
[tx-robot] updated from transifex 2018-04-06 00:14:22 +00:00
Julius Härtl 2e60f91ab1
Move external share saving to template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 13:11:55 +02:00
Julius Härtl 30e76f9f14
Add footer to public page template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 12:22:01 +02:00