Commit Graph

4827 Commits

Author SHA1 Message Date
Nextcloud bot 0825530a1b
[tx-robot] updated from transifex 2020-07-03 02:17:12 +00:00
Roeland Jago Douma 1913b1b91f
Merge pull request #21591 from nextcloud/debt/noid/set-path-for-ocm-permissions
Pass $path to ocmPermissions2ncPermissions
2020-07-02 21:10:19 +02:00
Joas Schilling 47a21fad8c
Merge pull request #21597 from nextcloud/techdebt/noid/return-value-for-commands
Add return value to all commands
2020-07-01 11:52:14 +02:00
Nextcloud bot d94ef09998
[tx-robot] updated from transifex 2020-06-28 02:16:10 +00:00
Joas Schilling d7c0b9cced
Also always return in app commands
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-26 15:12:11 +02:00
Daniel Kesselberg 6b1af4ac8c
Pass $path to ocmPermissions2ncPermissions
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-06-25 23:42:36 +02:00
Roeland Jago Douma 7d4682da40
Merge pull request #21379 from nextcloud/fix-share-permission-checkboxes-enabled-when-permissions-can-not-be-set
Fix share permission checkboxes enabled when permissions can not be set
2020-06-24 21:20:17 +02:00
Joas Schilling a2f34f46b2
Fix tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-24 18:13:37 +02:00
Joas Schilling 89ed2c37bf
Update share type constant usage
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-24 16:49:16 +02:00
Nextcloud bot ce9d3b36df
[tx-robot] updated from transifex 2020-06-20 02:16:35 +00:00
Nextcloud bot dd0b9655b2
[tx-robot] updated from transifex 2020-06-19 02:16:27 +00:00
Joas Schilling b740d283a9
Don't initialize Application directly
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-17 12:18:15 +02:00
Nextcloud bot d1b03f5adf
[tx-robot] updated from transifex 2020-06-17 02:15:44 +00:00
Nextcloud bot f04d526681
[tx-robot] updated from transifex 2020-06-14 02:15:50 +00:00
Daniel Calviño Sánchez 3ffb482b4e Fix share permission checkboxes enabled when permissions can not be set
A sharee can reshare a file and set the edit, create, delete and share
permissions of the reshare only if the received share has edit, create,
delete and share permissions, or if they were revoked in the received
share after being set in the reshare. Therefore, the permission
checkboxes in the share menu should be enabled only if the user can set
them (otherwise trying to check them will lead to an error).

Note that "sharePermissions" has all the permissions if the file is not
a reshare but a file owned by the user.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-06-12 00:05:36 +02:00
Roeland Jago Douma 3000148e27
Merge pull request #21347 from nextcloud/fix/21188/pass_share_permissions_to_api_call
Pass the proper share permissions to the create share call
2020-06-10 10:35:48 +02:00
Nextcloud bot 9806dec9b3
[tx-robot] updated from transifex 2020-06-10 02:16:03 +00:00
Roeland Jago Douma d0525df63c
Pass the proper share permissions to the create share call
Fixes #21188

This way we do not run into the share permission issue

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-06-09 20:59:41 +02:00
Roeland Jago Douma 19712e2773
Merge pull request #21311 from nextcloud/techdebt/noid/make-share-order-reliable
Always sort shares in a reliable way
2020-06-09 10:33:41 +02:00
Nextcloud bot 99e14b5ada
[tx-robot] updated from transifex 2020-06-09 02:15:56 +00:00
Joas Schilling 56b04c65f7
Always sort shares in a reliable way
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-08 14:47:15 +02:00
Roeland Jago Douma c5a2caa0fb
Merge pull request #21278 from nextcloud/dependabot/npm_and_yarn/nextcloud/auth-1.3.0
Bump @nextcloud/auth from 1.2.3 to 1.3.0
2020-06-08 08:47:22 +02:00
Nextcloud bot f51c24a70a
[tx-robot] updated from transifex 2020-06-08 02:15:55 +00:00
dependabot-preview[bot] 807e286f42 Bump @nextcloud/auth from 1.2.3 to 1.3.0
Bumps [@nextcloud/auth](https://github.com/nextcloud/nextcloud-auth) from 1.2.3 to 1.3.0.
- [Release notes](https://github.com/nextcloud/nextcloud-auth/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-auth/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-auth/compare/v1.2.3...v1.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-06-07 08:47:37 +00:00
Nextcloud bot e212908cec
[tx-robot] updated from transifex 2020-06-07 02:15:50 +00:00
Nextcloud bot 4cf4ed3697
[tx-robot] updated from transifex 2020-06-06 02:16:00 +00:00
Christoph Wurst eaf4724acc
Move humanFileSize and OC.getCanonicalLocale to npm packages
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-05 08:48:49 +02:00
Nextcloud bot a5232d9805
[tx-robot] updated from transifex 2020-06-05 02:16:34 +00:00
Christoph Wurst 497350a7d3
Merge pull request #20938 from nextcloud/fix/share-talk-verification
Fix the Talk verification
2020-06-03 15:47:54 +02:00
Christoph Wurst 111c8c9e0e
Merge pull request #21181 from nextcloud/fix/remote-share-remove-error-handling
Do not only catch Exceptions but any Throwable during rmt share delete
2020-06-03 11:11:47 +02:00
Nextcloud bot f62f23ed1d
[tx-robot] updated from transifex 2020-06-03 02:16:18 +00:00
Christoph Wurst 09a632242d
Do not only catch Exceptions but any Throwable during rmt share delete
When a remote share is deleted, we notify the remove instance. This may
trigger various error conditions, which we want to catch in order to
avoid undeletable shares. The try-catch, however, did only capture
exceptions, so things like TypeErrors were not caught and caused the
process to fail hard.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-02 09:21:09 +02:00
Daniel Calviño Sánchez fdac2ffe24 Restore previous state when failing to change video verification state
When video verification can not be enabled or disabled the previous
state is set again in the JavaScript share object. This ensures that the
UI will not reflect a misleading state.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-06-01 18:50:13 +02:00
Christoph Wurst 5d92a6a7c9 Fix the Talk verification
When enabling or disabling Talk verification in mail shares the server
expects also a new password to be set. As we always just update one
property at a time this means the Talk verification was impossible to
activate or deactivate. With this patch, we send the talk option AND the
new password. If there is no new password, the Talk option is disabled
(in mail shares; in link shares it is possible to enable or disable the
video verification without changing the password).

When we finally have descriptive text on ActionCheckbox'es we should
definitely add some explanatory text for the user. Right now this is as
good as it gets.

We'll have to backport to 18.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-01 17:21:42 +02:00
Nextcloud bot a1bb18a837
[tx-robot] updated from transifex 2020-05-31 02:16:19 +00:00
Roeland Jago Douma b9e7fd2418 Remove the escape-html global
Already announced for 19 that it would go. So now it realy does go.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-29 08:34:10 +00:00
Daniel Calviño Sánchez 37f231333f Fix reference to wrong class name
\OCP\IShare does not exist; the right name is \OCP\Share\IShare,
although it is already imported as IShare.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 01:41:06 +02:00
Nextcloud bot be7a198762
[tx-robot] updated from transifex 2020-05-24 02:15:55 +00:00
Nextcloud bot 23080fcd9c
[tx-robot] updated from transifex 2020-05-23 02:16:22 +00:00
Nextcloud bot 1b55119c85
[tx-robot] updated from transifex 2020-05-19 02:17:09 +00:00
Morris Jobke ca276a9d60
Merge pull request #20846 from nextcloud/fix/link_fed_perm
Link permissions
2020-05-18 15:45:56 +02:00
Nextcloud bot a8ac6df1d0
[tx-robot] updated from transifex 2020-05-18 02:16:22 +00:00
Nextcloud bot a84eec88e8
[tx-robot] updated from transifex 2020-05-16 02:17:14 +00:00
Roeland Jago Douma 91a2d5e012
Merge pull request #20629 from mejo-/files_sharing_preview_text
Don't load text file preview when text app is available (Fixes: #20615)
2020-05-15 19:47:02 +02:00
Julius Härtl 8289565bc7
Fix share update test
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-05-15 08:19:31 +02:00
Roeland Jago Douma ef34f72167
Have share permissions on link shares if it is enabled
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-15 08:18:03 +02:00
dependabot-preview[bot] 5550aff634 Bump p-queue from 6.3.0 to 6.4.0
Bumps [p-queue](https://github.com/sindresorhus/p-queue) from 6.3.0 to 6.4.0.
- [Release notes](https://github.com/sindresorhus/p-queue/releases)
- [Commits](https://github.com/sindresorhus/p-queue/compare/v6.3.0...v6.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-14 08:43:05 +00:00
Roeland Jago Douma b8e4992ef1
Merge pull request #20909 from nextcloud/dependabot/npm_and_yarn/babel/core-7.9.6
Bump @babel/core from 7.9.0 to 7.9.6
2020-05-14 10:20:58 +02:00
Nextcloud bot 75d50a55b8
[tx-robot] updated from transifex 2020-05-14 02:16:36 +00:00
dependabot-preview[bot] 3d1836ad34 Bump @babel/core from 7.9.0 to 7.9.6
Bumps [@babel/core](https://github.com/babel/babel) from 7.9.0 to 7.9.6.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/compare/v7.9.0...v7.9.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-13 18:27:32 +00:00
Nextcloud bot 901110f068
[tx-robot] updated from transifex 2020-05-12 02:16:11 +00:00
Roeland Jago Douma 2ed7c24b0d
Merge pull request #20902 from nextcloud/dependabot/npm_and_yarn/vue-loader-15.9.2
Bump vue-loader from 15.9.1 to 15.9.2
2020-05-11 09:31:37 +02:00
dependabot-preview[bot] 8f8de7f6d0 Bump vue-loader from 15.9.1 to 15.9.2
Bumps [vue-loader](https://github.com/vuejs/vue-loader) from 15.9.1 to 15.9.2.
- [Release notes](https://github.com/vuejs/vue-loader/releases)
- [Changelog](https://github.com/vuejs/vue-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-loader/compare/v15.9.1...v15.9.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-11 06:56:25 +00:00
Nextcloud bot 90e6b31059
[tx-robot] updated from transifex 2020-05-11 02:16:11 +00:00
Roeland Jago Douma d730579809
Merge pull request #20849 from nextcloud/version/20
20 in development now
2020-05-07 15:31:10 +02:00
Joas Schilling af1dd9f152
Bump app versions and requirements
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-05-07 10:29:04 +02:00
Roeland Jago Douma 35a506d50b
Merge pull request #20831 from nextcloud/fix/sidebar-fileinfo-change
Do not process the same FileInfo twice
2020-05-07 09:20:15 +02:00
Nextcloud bot 97f36e62f2
[tx-robot] updated from transifex 2020-05-07 02:16:14 +00:00
John Molakvoæ (skjnldsv) d37c5c3038 Do not process the same FileInfo twice
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-06 19:41:31 +00:00
John Molakvoæ (skjnldsv) a26ca1e638
Do not filter id matching userId on non-user-share shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 21:36:46 +02:00
John Molakvoæ (skjnldsv) edecd0931e Fix filtering our owner & current user from shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 10:28:33 +00:00
Nextcloud bot 09d7854d0e
[tx-robot] updated from transifex 2020-05-05 02:16:14 +00:00
John Molakvoæ (skjnldsv) ff20da637e Fix federated link sharing permissions
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-04 11:48:11 +00:00
Nextcloud bot 43fefee847
[tx-robot] updated from transifex 2020-05-04 02:16:18 +00:00
Nextcloud bot d2f165e448
[tx-robot] updated from transifex 2020-05-03 02:16:16 +00:00
Gary Kim 8dd23f9854
Fix expiry datepicker allowing all dates
vue2-datepicker expects a `disabled-date` function
rather than `not-before` and `not-after` dates.

This commit updates it so that we now provide
vue2-datepicker with a `disabled-date` function.

Signed-off-by: Gary Kim <gary@garykim.dev>
2020-05-02 18:58:41 +08:00
Nextcloud bot e77e0b0e2f
[tx-robot] updated from transifex 2020-05-02 02:16:32 +00:00
John Molakvoæ (skjnldsv) 31172a0cd9 Process shares only once, better debug and expiration date code
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-01 13:39:57 +00:00
Nextcloud bot 9f448d864b
[tx-robot] updated from transifex 2020-05-01 02:16:47 +00:00
Roeland Jago Douma b2b8be83f8
Merge pull request #20538 from nextcloud/fix/20520/share-expire
Fix share expiration date not shown
2020-04-30 20:55:05 +02:00
Gary Kim 02b5ded840
Fix share expiration date not shown
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-04-30 22:35:52 +08:00
John Molakvoæ (skjnldsv) 6e79fb60d8
Fix public layout header title & description
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-04-30 13:32:28 +02:00
Nextcloud bot 523a8ba5c3
[tx-robot] updated from transifex 2020-04-30 02:17:11 +00:00
Roeland Jago Douma d466a7b808 Allow to navigate to others with access from the sidebar
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-29 17:53:35 +00:00
Christoph Wurst b219eadb8f
Merge pull request #20714 from nextcloud/fix/license-headers-19
Update license headers for 19
2020-04-29 14:24:27 +02:00
Christoph Wurst cb057829f7
Update license headers for 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
dependabot-preview[bot] 08296c04c0 Bump webpack from 4.42.1 to 4.43.0
Bumps [webpack](https://github.com/webpack/webpack) from 4.42.1 to 4.43.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.42.1...v4.43.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-29 09:23:51 +00:00
Morris Jobke 1738e17e20
Merge pull request #19793 from nextcloud/bugfix/noid/link-to-federated-reshare
Fix resharing of federated shares that were created out of links
2020-04-27 11:05:34 +02:00
Nextcloud bot e56ffe5992
[tx-robot] updated from transifex 2020-04-27 02:16:13 +00:00
Nextcloud bot 0eeb660679
[tx-robot] updated from transifex 2020-04-26 02:16:12 +00:00
Roeland Jago Douma 4114bce1e5
Merge pull request #17623 from j3l11234/master
Add support for download share on old android browser
2020-04-24 16:01:45 +02:00
Jonas Meurer afeeb1eb1f
Don't load text file preview when text app is available (Fixes: #20615)
When opening a shared text document, the files_sharing app uses
internal preview support in case no other app to open the text file is
available.

So far, it only checks for the old files_texteditor app, not for the new
new text app. This commit fixes this by checking for both.

Signed-off-by: Jonas Meurer <jonas@freesources.org>
2020-04-24 11:14:21 +02:00
Robin Appelman 7a4ea4a6b6
make php-cs happy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-23 13:35:30 +02:00
Nextcloud bot 79e3823d72
[tx-robot] updated from transifex 2020-04-23 02:16:54 +00:00
Morris Jobke f0ad46dec8
Merge pull request #20575 from nextcloud/fix/sharing-suggestions
Fix Sharing recommendation user display
2020-04-22 14:56:01 +02:00
Nextcloud bot ac57bbcf99
[tx-robot] updated from transifex 2020-04-22 02:17:06 +00:00
Roeland Jago Douma 8f650feede
Merge pull request #20114 from nextcloud/techdebt/noid/allow-some-apps-to-have-root-urls
Allow some apps to have root URLs in their own routing file
2020-04-21 16:00:34 +02:00
Julius Härtl 5646f7c761
Link shares have reshare permission if outgoing federated shares are enabled
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-21 14:35:29 +02:00
John Molakvoæ (skjnldsv) 7eceba7dae Fix Sharing recommendation user display
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-21 07:48:10 +00:00
Nextcloud bot f0c1041d2e
[tx-robot] updated from transifex 2020-04-21 02:16:40 +00:00
Robin Appelman 9735b5d61f
Add method to storage backends to get directory content with metadata
Currently you need to use `opendir` and then call `getMetadata` for
every file, which adds overhead because most storage backends already
get the metadata when doing the `opendir`.

While storagebackends can (and do) use caching to relief this problem,
this adds cache invalidation dificulties and only a limited number of
items are generally cached (to prevent memory usage exploding when
scanning large storages)

With this new methods storage backends can use the child metadata they
got from listing the folder to return metadata without having to keep
seperate caches.

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-20 15:45:04 +02:00
Nextcloud bot e9930aebc7
[tx-robot] updated from transifex 2020-04-19 02:16:10 +00:00
Joas Schilling 1b93d5f1db
PHP CS fixes
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Joas Schilling 685d7b0637
Directly use the class to get the service
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Joas Schilling e45c87cd2e
Fix creating the share controller
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Joas Schilling 3f8168b6e5
Allow some apps to have root URLs in their own routing file
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Nextcloud bot 148bdabd58
[tx-robot] updated from transifex 2020-04-18 02:16:28 +00:00
Nextcloud bot 078ac97939
[tx-robot] updated from transifex 2020-04-16 02:17:30 +00:00
Joas Schilling 609b8aff12
Also disallow ; in remote urls
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-14 18:56:06 +02:00
John Molakvoæ (skjnldsv) 47146a1992 Properly display share error messages
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-14 08:39:40 +00:00