Commit Graph

19522 Commits

Author SHA1 Message Date
fnuesse df01d12d91 Fix drop zone shadow
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez 371df903d6 Unify handling of dropping one file or several files on the trash bin
When a single file was dropped on the trash bin the file information was
gotten from the original element in the file list. When several files
were dropped on the trash bin the file information was gotten from the
helper elements being dragged around. The helper element also contain
the needed file information when a single file is being dragged, so the
handling was unified to always get the file information from the helper
elements.

As the handling of several files is the same as before there is still
the issue of only deleting those files shown in the drag helper instead
of all the selected files.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez 66b908f9f2 Use full names instead of abbreviations in variable names
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez e2c4dbca51 Make code format more consistent with the rest of the file
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez c72e75c4c3 Replace double quotes with single quotes
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez 8e6cedb157 Add missing trailing ";"
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez 414804d534 Remove unneeded triggering of event
The "droppedOnTrash" event was being triggered when the file list was
initialized, but it should be triggered only when the user actually
drops a file on the trash bin.

Besides that, the event had no effect; only the file list handles it,
but as it was not triggered on any element it ended being triggered on
the document, and thus not handled. Moreover, even if it had been
triggered on the file list it would have been done before the handler
was set, so it would not have been handled anyway. And even if it had
been handled no data was provided, so the handler would have failed.

In conclusion, triggering the event there was not needed, and thus it
was removed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez e94412e9e8 Remove duplicated variable declaration
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez 7b7da7b190 Remove leftover from a WIP
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Daniel Calviño Sánchez 1f9c881d0f Remove hack to prefetch the starred trash icon
Since 6ad7f32938 SVG icons are directly embedded in "icons-vars.css", so
the starred trash icon is now loaded along with the regular trash icon
all at once. Therefore it is not needed to explicitly prefetch it using
a hidden div.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 16:21:23 +01:00
Morris Jobke f46a251625
Revert "trim filename in webfrontend for windows compatibility" 2019-02-01 11:59:49 +01:00
Christian Aigner 6637d97376 HBOX-297 trim in webfrontend for new files to stay compatible with windows 2019-01-31 15:30:20 +01:00
Morris Jobke d34b7e594b
Merge pull request #13920 from nextcloud/backport/13891/stable15
[stable15] Remove warning in case of external storage error
2019-01-30 15:34:22 +01:00
Morris Jobke 24007e706c
Merge pull request #13918 from nextcloud/backport/13412/stable15
[stable15] forward error message from password policy
2019-01-30 15:25:06 +01:00
Morris Jobke dbdc5c4dd4
Merge pull request #13887 from nextcloud/backport/13883/stable15
[stable15] Fix dropping a folder on a folder row
2019-01-30 14:09:20 +01:00
Morris Jobke 1f52990013
Merge pull request #13905 from nextcloud/backport/13830/stable15
[stable15] Allow shared versions again in legacy backend
2019-01-30 12:01:42 +01:00
John Molakvoæ (skjnldsv) a1f8f67974 Remove warning in case of external storage error
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-01-30 10:56:38 +00:00
Robin Appelman 60126556be forward error message from password policy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-01-30 10:14:55 +00:00
Roeland Jago Douma 75b5286169
Merge pull request #13904 from nextcloud/backport/13886/stable15
[stable15] add fallback for trashbin original location
2019-01-30 10:19:12 +01:00
Roeland Jago Douma ae826f5a2f
Merge pull request #13884 from nextcloud/backport/13865/stable15
[stable15] fix paged search with multiple bases (LDAP)
2019-01-30 09:31:13 +01:00
Roeland Jago Douma a36577463d Allow shared versions again in legacy backend
To make sure that the versions in the legacy backend are shared again we
have to check the storage of a file. Since all shared files are still on
the owners storage.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-30 08:23:50 +00:00
Roeland Jago Douma 3a34132b06
Merge pull request #13804 from nextcloud/backport/13802/stable15
[stable15] Fix long comment in dark theme
2019-01-30 09:08:48 +01:00
Robin Appelman a6f6a3aa5d add fallback for trashbin original location
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-01-30 08:04:49 +00:00
Daniel Calviño Sánchez 4321e0fc6d Fix dropping a folder on a folder row
When the uploaded files have a relative path (that is, when a folder is
uploaded) it is first ensured that all the parent folders exist, which
is done by trying to create them. When a folder is created in the
currently opened folder the file list is updated and a row for the new
folder is added. However, this was done too when the folder already
existed, which caused the previous row to be removed and a new one added
to replace it.

For security reasons, some special headers need to be set in requests;
this is done automatically for jQuery by handling the "ajaxSend" event
in the document. In the case of DAV requests, if the headers are not set
the server rejects the request with "CSRF check not passed".

When a file or folder is dropped on a folder row the jQuery upload
events are chained from the initial drop event, which has the row as its
target. In order to upload the file jQuery performs a request, which
triggers the "ajaxSend" event in the row; this event then bubbles up to
the document, which is then handled by adding the special headers to the
request.

However, when a folder was dropped on a folder row that folder row was
removed when ensuring that the folder exists. The jQuery upload events
were still triggered on the row, but as it had been removed it had no
parent nodes, and thus the events did not bubble up. Due to this the
"ajaxSend" event never reached the document when triggered on the
removed row, the headers were not set, and the upload failed.

All this is simply fixed by not removing the folder row when trying to
create it if it existed already.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-29 14:46:07 +00:00
Arthur Schiwon 2b8a669d31 iterate over bases instead of doing parallel search
parallel search is not compatible with paged search, but the letter is
usually always applied.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-01-29 13:25:23 +00:00
Jan-Christoph Borchardt 8fa8f51ed5 Accessibility: Fix header icon opacity with high contrast theme
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-01-27 17:56:15 +00:00
Nextcloud bot fc0480282a
[tx-robot] updated from transifex 2019-01-26 01:12:28 +00:00
Joas Schilling 87b7dd0af2 Merge the str_replacements
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-24 20:37:18 +00:00
Joas Schilling 63a1ef9154 Fix linear-gradient for long comments on dark-theme
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-24 20:37:17 +00:00
Morris Jobke d823f6fba8
Merge pull request #13792 from nextcloud/backport/13644/stable15
[stable15] ignore non existing users when retrieving details of group members
2019-01-24 19:17:22 +01:00
Morris Jobke 07ded47c22
Merge pull request #13794 from nextcloud/backport/13742/stable15
[stable15] Add icon to restore activity
2019-01-24 19:17:01 +01:00
Joas Schilling 4ab1970c43 Make the yellow favorite icon non-monochrome
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-24 13:46:54 +00:00
Joas Schilling d343873e7c Add icon to restore activity
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-24 13:46:53 +00:00
Julius Härtl 15e8a27338 Remove .css fileending from accessibility user css route
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-01-24 13:44:56 +00:00
Arthur Schiwon 922d35e0c3 ignore non existing users when retrieving details of group members
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-01-24 13:26:42 +00:00
Roeland Jago Douma e6863782eb
Merge pull request #13769 from nextcloud/backport/13734/stable15
[stable15] Call proper function when fetching link shares in the breadcrumb view
2019-01-24 08:07:08 +01:00
Nextcloud bot 3079a88f03
[tx-robot] updated from transifex 2019-01-24 01:12:16 +00:00
Julius Härtl f861c84b97 Call proper function when fetching link shares in the breadcrumb view
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-01-23 18:15:45 +00:00
Nextcloud bot 34c1644714
[tx-robot] updated from transifex 2019-01-23 01:12:19 +00:00
Nextcloud bot e1f917fd4c
[tx-robot] updated from transifex 2019-01-22 01:12:37 +00:00
Nextcloud bot c96e47b5ad
[tx-robot] updated from transifex 2019-01-21 01:12:02 +00:00
Nextcloud bot e9fae5e390
[tx-robot] updated from transifex 2019-01-20 01:12:42 +00:00
Nextcloud bot 2b577f5634
[tx-robot] updated from transifex 2019-01-19 01:12:32 +00:00
Nextcloud bot af196c4495
[tx-robot] updated from transifex 2019-01-18 01:14:45 +00:00
Morris Jobke 0917637460
Merge pull request #13636 from nextcloud/backport/13634/stable15
[stable15] update URL for federation
2019-01-17 09:35:03 +01:00
Nextcloud bot 0469bb11c9
[tx-robot] updated from transifex 2019-01-17 01:12:28 +00:00
Jos Poortvliet 8ca06c96a0 update URL for federation 2019-01-16 21:43:03 +00:00
Nextcloud bot 6a44943425
[tx-robot] updated from transifex 2019-01-16 01:12:46 +00:00
Nextcloud bot 08676fd8e6
[tx-robot] updated from transifex 2019-01-15 01:12:27 +00:00
Joas Schilling df2132c0b1 Principals can be principal/user/<name> or principal/<name> from legacy installs
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-14 13:19:48 +00:00