efc030aa25
don't allow to create a federated share if source and target server are the same
2015-12-14 17:16:14 +01:00
843cf906b1
File shares can't have create permissions
...
fixes #21187
2015-12-14 14:03:14 +01:00
3d5a7b307f
Add test case for group share propagation
2015-12-10 13:53:50 +01:00
54dbe5b8d5
Merge pull request #20989 from owncloud/fix_20769
...
Update parent when moving share into recieved share
2015-12-09 13:07:57 +01:00
bc744ff6de
Merge pull request #21038 from owncloud/share-computesharepermissions-notstore
...
Fix (re)share permission checks in a few code paths
2015-12-09 10:04:56 +01:00
dda9525c4b
[tx-robot] updated from transifex
2015-12-09 01:55:14 -05:00
6e4006d139
Add reshare permission checks
...
Added in isSharable() in incoming remote share.
Added in isSharable() in regular incoming share.
Added in FileInfo to make sure the proper attributes are returned to the
clients.
2015-12-08 13:13:26 +01:00
5453daab03
More fixes to the docs
2015-12-08 09:11:50 +01:00
0f1be1b601
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2015-12-07 20:08:20 +00:00
453e1bf66e
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2015-12-07 15:43:36 +00:00
d38949f423
Update parent when moving share into recieved share
...
Fixes #20769
When I receive a share and move a share of myself into that share (which
is allowed currently) I effectively hand over ownership of the files I
move. So we need to update the share I move to have as a parent the
share I move it into. Else our mounting system gets confused.
2015-12-07 16:28:33 +01:00
97f9213da9
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2015-12-07 12:05:27 +00:00
00b592f2a6
Merge pull request #20581 from owncloud/public-page-preview-hidpi-scale
...
Fix hidpi previews on public page
2015-12-07 10:23:58 +01:00
6b4f48e0f3
Merge pull request #20900 from owncloud/share-group-only-with-exact-match
...
Only return the exact match, when it's allowed
2015-12-03 09:21:29 +01:00
df5872ec50
Merge pull request #20719 from owncloud/adding-system-addressbook-of-users
...
Adding system addressbook for users of this instance - a occ command …
2015-12-02 16:17:58 +01:00
372f54075f
Only return the exact match, when it's allowed
2015-12-02 16:01:01 +01:00
d4abbb10d3
Merge pull request #20884 from owncloud/fix_20713
...
Respect disabled incoming federated shares
2015-12-02 10:56:59 +01:00
df6fc6cc70
Add the user's cloud id to the vCard
2015-12-02 09:14:41 +01:00
1e19661daa
[Sharing] Respect disabled incoming federated shares
...
Only fetch the incoming federated shares if incoming shares are actually
enabled.
Fixes #20713
2015-12-02 09:00:21 +01:00
4f4b91a9ec
[tx-robot] updated from transifex
2015-12-02 02:00:28 -05:00
00fcb95d86
Fix the width of the share with input
...
* the ID of this has changed to #shareWith-viewNUMBER and shouldn't
be used in CSS
* now uses the proper classes
2015-11-30 16:46:51 +01:00
fd79511d68
Merge pull request #20688 from owncloud/publiclink-getdownloadurl-webdav
...
Fix public link getDownloadUrl to return Webdav public link
2015-11-30 15:07:36 +01:00
757aa45db7
Adding more DB groups to test suits
...
Adding more DB groups to test suits
2015-11-30 10:55:06 +01:00
3bb6dcea64
Apply DB group annotation ...
2015-11-30 10:55:05 +01:00
39fb320bae
[tx-robot] updated from transifex
2015-11-27 01:55:14 -05:00
dd18ea611b
[tx-robot] updated from transifex
2015-11-26 01:55:22 -05:00
42091cecf9
Fix public link getDownloadUrl to return Webdav public link
...
This is for apps that use getDownloadUrl() to access the Webdav endpoint
for example for streaming.
Also happens when clicking on the download action of a file.
Note that the regular visible download URL is still the same.
2015-11-25 17:39:49 +01:00
9ec2f8886e
Merge pull request #20691 from owncloud/share2.0_di_fixes
...
[Sharing 2.0] di fixes
2015-11-25 15:25:50 +01:00
50f6817ce9
Merge pull request #20439 from owncloud/etag-propagate-in-storage
...
Take submount etag into account for folder etags
2015-11-25 12:49:54 +01:00
4bb346a1e6
Merge pull request #20692 from owncloud/federation_auto_add_servers
...
auto-add ownClouds to the list of trusted servers
2015-11-24 16:19:39 +01:00
6ce6e27560
Merge pull request #20595 from owncloud/fix-double-slashes
...
Avoid double slashes in URL when trying to add an remote share
2015-11-24 16:04:03 +01:00
964fa1fce3
use hooks to auto add server to the list of trusted servers once a federated share was created
2015-11-24 11:34:38 +01:00
8d309767d7
[Sharing 2.0] Use the rootfolder to get the path of a share
...
We need to use the rootfolder here since we also other people than the
shareOwner can request a share.
2015-11-24 10:26:36 +01:00
85976b7293
[Sharing 2.0] Fix phpdoc etc
2015-11-24 10:26:36 +01:00
ab02b5c36e
[Sharing 2.0] Move authentication to the OCS API
2015-11-24 10:26:36 +01:00
a2b8483779
[Sharing 2.0] Default share provider only generic DI
...
No injection of userfolders etc. Only generic DI components
(IRootFolder) etc should be used to make sure we can also run this from
the cli
2015-11-24 10:26:36 +01:00
aeae73b364
[Sharing 2.0] Removed unused DI stuff
...
The share manager etc should not care about filtering stuff. They should
return what is asked for them.
2015-11-24 10:26:36 +01:00
cb69e6c201
[tx-robot] updated from transifex
2015-11-24 01:56:32 -05:00
79bbda994b
Merge pull request #16902 from owncloud/jsocclient
...
Web UI uses Webdav instead of ajax/* calls
2015-11-23 09:38:01 +01:00
57c9aa3ca7
Merge pull request #20558 from owncloud/remove-path-from-shared-with
...
Unset `path` for shared with me
2015-11-23 09:04:52 +01:00
ec3166742b
Properly join path sections
...
This prevents double slashes that can mess up path comparisons in some
cases.
2015-11-22 16:05:51 +01:00
ab1d786d87
Fix port issue - options.host already has the port attached
2015-11-22 16:05:51 +01:00
21da6271a8
Parse share owner from Webdav to display in UI
2015-11-22 16:05:50 +01:00
f20232d4bd
Make public link share page work with Webdav and add operations
...
The public page now uses the public.php/webdav endpoint.
Also enabled more file operations like rename, move, delete and create
folder from the public page, which are now all possible thanks to the
public.php/webdav endpoint.
2015-11-22 16:05:50 +01:00
fa2be0750c
Make files app use Webdav for most operations
2015-11-22 16:05:50 +01:00
a95d4c2b22
update tests
2015-11-19 13:32:04 +01:00
888df3933d
take the etag of child mounts into account for the folder etag
...
this replaces shared etag propagation
2015-11-19 13:32:00 +01:00
5d2e1268cd
Avoid double slashes in URL when trying to add an remote share
...
When being on a link share and clicking "Add to your ownCloud" a double slash might be inserted in the URL if the entered ownCloud host ended with a slash. Results in a server error.
2015-11-18 22:48:35 +01:00
048ad25416
Use proper variable
...
`$shares` is not defined. Introduced with c3e7d324c5
2015-11-18 22:28:48 +01:00
1d82d93baa
Implement getOwner for external share storage
2015-11-18 17:08:02 +01:00
ee87f12c09
Fix hidpi previews on public page
2015-11-18 16:45:19 +01:00
cbd94ce355
Unset `path` for shared with me
...
The original path is not required for a share recipient.
2015-11-17 14:09:29 +01:00
1e9fc33212
[Share2.0] OCS Share API getShare uses new code
2015-11-16 13:32:28 +01:00
5dd59b4bd2
[tx-robot] updated from transifex
2015-11-11 01:55:47 -05:00
20cad09f7f
Add tests for FileInfo owner
2015-11-10 11:06:48 +01:00
0c566698a1
Use the old code for remote shares for now
2015-11-05 15:59:09 +01:00
6624fa212a
The new sharing code now handles deletion
...
OCS -> ShareManager -> DefaultShareProvider
2015-11-05 15:59:09 +01:00
8b5179459a
Prepare OCS Share endpoint
2015-11-05 15:59:09 +01:00
2f4fa5b49c
[tx-robot] updated from transifex
2015-11-05 01:55:14 -05:00
ba02a3771b
Merge pull request #20053 from owncloud/getfileinfo-locking
...
Don't lock if we're only reading cache metadata
2015-11-04 22:40:17 +01:00
7fe047425f
[tx-robot] updated from transifex
2015-11-04 01:55:44 -05:00
0397871f7e
Split checkUpdate
2015-11-03 18:23:22 +01:00
2374a0df5d
[tx-robot] updated from transifex
2015-11-01 01:54:58 -04:00
6911d8f0a4
Merge pull request #20175 from owncloud/login-arrow
...
remove unneeded icons from input fields to not distract from submit button, fix #18940
2015-10-30 15:56:13 +01:00
27db39bd03
Merge pull request #20160 from owncloud/share-allowdeleteinshareoverview
...
Bring back delete permission in share overview
2015-10-30 15:30:05 +01:00
a05ea0fb1e
remove unneeded icons from input fields to not distract from submit button, fix #18940
2015-10-30 11:11:37 +01:00
91b2cdc62b
[tx-robot] updated from transifex
2015-10-30 01:55:52 -04:00
dcfaf3afdc
Bring back delete permission in share overview
2015-10-29 17:56:54 +01:00
774d069ff0
Merge pull request #20122 from owncloud/files-consolidateiconupdate
...
Fix icon update to be more consistent
2015-10-29 15:40:15 +01:00
9c9158e6b7
Fix icon update to be more consistent
...
Makes the details bar show the same icon as in the list.
2015-10-29 12:59:51 +01:00
5bf476efd0
Merge pull request #20079 from owncloud/filelist-invalidpath
...
Fix file list reload callback result
2015-10-29 09:21:30 +01:00
527ef76dd6
[tx-robot] updated from transifex
2015-10-29 01:55:45 -04:00
f24386c491
Fix file list reload callback result
...
All reloadCallback must return either true for success or false in case
of failure / non-existing folder.
Some file lists only have a root folder (favorite, shares), so restrict
the path to that to avoid having a wrong path in the breadcrumbs.
2015-10-27 11:51:54 +01:00
0875a4a18f
[tx-robot] updated from transifex
2015-10-27 01:55:44 -04:00
8f09d5b67c
Update license headers
2015-10-26 14:04:01 +01:00
13e817e901
Throw exception on `getPath` if file does not exist
...
Currently the `getPath` methods returned `NULL` in case when a file with the specified ID does not exist. This however mandates that developers are checking for the `NULL` case and if they do not the door for bugs with all kind of impact is widely opened.
This is especially harmful if used in context with Views where the final result is limited based on the result of `getPath`, if `getPath` returns `NULL` PHP type juggles this to an empty string resulting in all possible kind of bugs.
While one could argue that this is a misusage of the API the fact is that it is very often misused and an exception will trigger an immediate stop of execution as well as log this behaviour and show a pretty error page.
I also adjusted some usages where I believe that we need to catch these errors, in most cases this is though simply an error that should hard-fail.
2015-10-25 17:58:21 +01:00
ba010a5aa4
[tx-robot] updated from transifex
2015-10-24 01:55:42 -04:00
a341e786dd
[tx-robot] updated from transifex
2015-10-23 01:55:06 -04:00
db25f41da8
handle NoUserException in sharing code
...
* setup LDAP users
* share from an LDAP user
* delete that LDAP user
* log in as share recipient
* before: unhandled NoUserException
* after: NoUserEception is logged and share is not shown anymore
2015-10-22 17:04:36 +02:00
74f41349b7
[tx-robot] updated from transifex
2015-10-21 01:56:16 -04:00
480a005b47
fix pagination on public file list
2015-10-20 16:11:10 +02:00
474f34eb6b
Merge pull request #19636 from owncloud/share_expire_backgroun
...
Add backgroundjob to expire link shares
2015-10-20 14:27:15 +02:00
e1c47d6823
use correct class name
2015-10-20 08:18:53 +02:00
ec296b0b7d
Add backgroundjob to expire link shares
...
Simple background job to expire the link shares.
* added unit tests
2015-10-20 08:18:53 +02:00
dfd44942c6
[tx-robot] updated from transifex
2015-10-20 01:55:03 -04:00
2895c91291
Merge pull request #17641 from owncloud/fix_objectstore_rename
...
don't move files in cache twice, fixes renaming for objectstores
2015-10-19 17:18:57 +02:00
8d25528c49
[tx-robot] updated from transifex
2015-10-18 01:55:07 -04:00
0d3d75b3b3
Increase the 2nd digit of shipped apps
2015-10-17 08:47:11 +02:00
c378456137
[tx-robot] updated from transifex
2015-10-17 01:55:34 -04:00
8efd037eb8
Make shared folder size propagation test work with object home storage
2015-10-16 21:41:51 +02:00
e7f75484f8
Fix shared storage tests for non local home storage
2015-10-16 21:41:51 +02:00
0cdd46de60
fix sabre connector tests when using a non local home storage
2015-10-16 21:41:51 +02:00
9d910deef0
Merge pull request #19836 from owncloud/share-fix-spinner-position
...
Fix spinner positions in share tab
2015-10-16 17:17:01 +02:00
90e34e26bd
Fix spinner positions in share tab
...
Also fix missing spinner when removing link share
2015-10-16 15:54:27 +02:00
f2889dc6e4
Consolidate webdav code - move all to one app
2015-10-16 13:17:12 +02:00
7224e99ccd
[tx-robot] updated from transifex
2015-10-16 01:55:03 -04:00
757f320531
Merge pull request #19580 from owncloud/issue-19399-remote-shares-case-sensitivity
...
Make sure that remote shares use the correct uid casing
2015-10-14 12:39:57 +02:00
01cc38018a
Merge pull request #19733 from owncloud/remove-controls-whennotneeded
...
Remove controls for file lists that don't need it
2015-10-14 12:37:55 +02:00
bf722d93df
apply new checkbox style to admin settings
2015-10-14 12:14:49 +02:00
f9dd750ed7
[tx-robot] updated from transifex
2015-10-14 01:55:36 -04:00
ecb10db039
Remove controls for file lists that don't need it
...
Remove controls from sharing overview and favorite file lists which
don't display paths.
2015-10-13 11:36:24 +02:00
1f146d678c
[tx-robot] updated from transifex
2015-10-13 01:55:06 -04:00
e16ac12f5a
[tx-robot] updated from transifex
2015-10-12 01:54:59 -04:00
188acd5e4e
[tx-robot] updated from transifex
2015-10-10 01:55:32 -04:00
8cbf76755e
Merge pull request #19643 from owncloud/public-download-spinner
...
Set download cookie on public download
2015-10-09 14:10:29 +02:00
5cb83937fa
[tx-robot] updated from transifex
2015-10-09 01:55:02 -04:00
17ffa4a244
Merge pull request #19414 from owncloud/swift_primary_storage_tests
...
Swift primary storage tests
2015-10-08 14:08:56 +02:00
e5bbec79a6
Merge pull request #19611 from owncloud/fix-public-scroll
...
Fix scrollbars in public template
2015-10-08 13:01:01 +02:00
ececa90709
Set download cookie on public download
2015-10-08 12:50:56 +02:00
c5649a634f
[tx-robot] updated from transifex
2015-10-08 01:54:58 -04:00
b2872ef759
Merge pull request #19589 from owncloud/shares-external-mount-provider
...
Move the setup of external share mounts to a mountprovider
2015-10-07 17:46:33 +02:00
ccfd052e81
move footer to bottom of public page
2015-10-07 13:03:43 +02:00
cd818e7419
[tx-robot] updated from transifex
2015-10-07 01:55:56 -04:00
e7b2da79ec
fix public empty message
2015-10-06 23:59:58 +02:00
59cf817308
Merge pull request #19511 from owncloud/etag-share-permissions-update
...
Mark shares as dirty when changing permissions
2015-10-06 18:09:12 +02:00
c1a5e96435
fix scrollbars in public template
2015-10-06 16:52:05 +02:00
17756ebf5b
fix phpdoc
2015-10-06 16:37:43 +02:00
d3c1fcf961
Fix getEtag for roots of shared storages
2015-10-06 16:33:37 +02:00
5646e39248
test objectstore with ceph docker
...
use default config for swift primary storage test config
allow testsuite to complete
fix timeout, script cleanup, enable debug for now
use btrfs loopback device, requires privileged container and absolute path
throw exception when storage has problems
debug by echo ...
sleep more, more debug
2015-10-06 16:27:25 +02:00
13dd62f7b0
Make sure that remote shares use the correct uid casing
2015-10-06 15:16:19 +02:00
d546c5bb59
Propagate shares etag when group membership changed
2015-10-06 15:02:22 +02:00
47c71d8e87
use microtime
2015-10-06 13:00:30 +02:00
41f9946272
clear hooks for tests
2015-10-06 11:38:41 +02:00
0817024e6f
Mark shares as dirty when changing permissions
2015-10-06 11:38:41 +02:00
0385a62363
Merge pull request #19597 from owncloud/update-license-headers
...
update licence headers via script
2015-10-06 11:18:35 +02:00
8366ce2767
deduplicate @xenopathic
2015-10-06 09:52:19 +02:00
3ff60cc2e3
[tx-robot] updated from transifex
2015-10-06 01:55:00 -04:00
b945d71384
update licence headers via script
2015-10-05 21:15:52 +02:00
e468b38bd4
sanitize mountpoint
2015-10-05 17:14:39 +02:00
52c8b488cb
fix test
2015-10-05 16:43:10 +02:00
e1c562f66b
extract the mount provider from the manager
2015-10-05 16:39:11 +02:00
a0c9dc2986
register the external share mount provider
2015-10-05 16:19:13 +02:00
76a528e511
Make the external share manager a mount provider
2015-10-05 16:18:14 +02:00
710b7dd81c
Merge pull request #19487 from owncloud/split_share_middleware
...
Split files_sharing middelware
2015-10-05 10:57:11 +02:00
bc593f7921
[tx-robot] updated from transifex
2015-10-05 01:54:55 -04:00
2ffb1c2135
[tx-robot] updated from transifex
2015-10-04 01:55:02 -04:00
e0084059b9
[tx-robot] updated from transifex
2015-10-03 01:56:20 -04:00
4adc78b78b
Fix and extend unit tests
2015-10-02 12:45:52 +02:00
40dd2d9dbe
More fileinfo
2015-10-02 12:45:52 +02:00
eeafccb3a6
Start to show remote shares in shared with you section
2015-10-02 12:45:47 +02:00
ccbdcf0ab3
Merge pull request #19522 from owncloud/activity-395-less-sidebar-text
...
Activity 395 less sidebar text
2015-10-02 12:13:53 +02:00
daf9a63d43
Merge pull request #19386 from owncloud/ocs_shareapi_extenstion
...
OCS endpoint to list remote shares
2015-10-02 12:13:36 +02:00
3d2acb5003
sharingcheckmiddleware now handles externalshares as well
...
Added new annotations for the externalsharescontroller class
* @NoOutgoingFederatedSharingRequired
* @NoIncomingFederatedSharingRequired
By default both are required for all functions in the
externalSharesController.
A proper exception is thrown and then a 405 is returned instead of the
default error page. Since it is only an API endpoint this makes more
sense.
Unit tests added and updated
2015-10-02 12:03:53 +02:00
dc38e674a5
Split files_sharing middelware
...
Since for external shares there is no need for link shares to be enabled
we should check which controller is actually being called.
This makes sure that in all cases we verify that the files_sharing app
is enabled. But only for the share controller (public shares) we check
if the API is enabled and if links are enabled.
TODO: add checks for federated sharing as well
2015-10-02 11:56:11 +02:00
e478d925c3
Fix intendation
2015-10-02 10:01:33 +02:00
17ab8e6c39
Use shorter text on the sidebar for files_sharing activities
2015-10-02 10:01:33 +02:00
c924b6740a
Do not return unneeded info
2015-10-02 08:11:50 +02:00
3b4592718a
[tx-robot] updated from transifex
2015-10-02 01:54:51 -04:00
c3e7d324c5
Extend share info
...
The data from the share_external is not to much. Thus we enrich this
data with info from the filecache.
This allows endpoints using this to actually show usefull information.
The filecache might not be up to date but that is a sacrifice we need to
make in terms of speed. Else the number of remote PROPFINDS grows
lineary with the number of remote shares wich will make this endpoint
practically unusable.
2015-10-02 07:41:57 +02:00
0d3009951f
Made routes remote_shares only again
...
Since we need a unique id to accept/reject shares for now we keep the
pending shares under remote_shares.
* remote_shares/pending lists pending shares
* PUT/DELETE to remote_shares/pending/<ID> will accept/reject the share
2015-10-02 07:40:53 +02:00
Björn Schießle
Roeland Jago Douma
Robin Appelman
Thomas Müller
Jenkins for ownCloud
Vincent Petry
Joas Schilling
Scrutinizer Auto-Fixer
Morris Jobke
blizzz
Lukas Reschke
Jan-Christoph Borchardt
Hendrik Leppelsack
Jörn Friedrich Dreyer
Robin Appelman
Roeland Jago Douma