14136295b7
Cache avatars properly
...
* Set proper caching headers for avatars (15 minutes)
* For our own avatar use some extra logic to invalidate when we update
2016-08-30 09:00:16 +02:00
1c3b1e5797
add stacktrace to query logger
2016-08-24 14:37:15 +02:00
a111181eb3
Validate the operation
2016-08-19 12:23:05 +02:00
a9f36067fd
Fix constant name, copy-pasterino
2016-08-17 10:41:13 +02:00
ce0604bd06
Merge pull request #892 from nextcloud/fix_phpdoc
...
Some scrutinizer phpdoc fixes
2016-08-17 10:38:21 +02:00
0dc22d13a9
Fix IL10N phpdoc
2016-08-16 20:24:50 +02:00
208e551216
check registered sections and settings after an app got updated to garbage collect orphaned classes
2016-08-16 00:56:17 +02:00
9edca39b49
attempt to remove section and settings entries when an app got disabled
2016-08-16 00:56:17 +02:00
8261ccce1b
Merge branch 'master' into implement_712
2016-08-11 19:37:17 +02:00
225eb27bca
Add since tags to class
2016-08-11 19:33:37 +02:00
8f12f5df15
Add missing since annotations
2016-08-11 19:28:24 +02:00
14ddf9d923
rename IAdmin to ISettings, the interface is not bound to a specific settings scope
2016-08-11 14:48:21 +02:00
ba922c9f73
Merge pull request #807 from nextcloud/ocs_dataresponse
...
OCSController requires DataResponse
2016-08-10 22:36:25 +02:00
1eb8b951c2
more admin page splitup improvements
...
* bump version to ensure tables are created
* make updatenotification app use settings api
* change IAdmin::render() to getForm() and change return type from Template to TemplateResponse
* adjust User_LDAP accordingly, as well as built-in forms
* add IDateTimeFormatter to AppFramework/DependencyInjection/DIContainer.php. This is important so that \OC::$server->query() is able to resolve the
constructor parameters. We should ensure that all OCP/* stuff that is available from \OC::$server is available here. Kudos to @LukasReschke
* make sure apps that have settings info in their info.xml are loaded before triggering adding the settings setup method
2016-08-10 15:21:25 +02:00
1f370c97ed
OCSController requires DataResponse
...
The OCS Controller requires a DataResponse object to be returned.
This means that all error handling will have to be done via exceptions
thrown and handling in the middleware.
2016-08-10 12:40:26 +02:00
ceeb44bd04
Initial work on Apps page split:
...
* interfaces for the Admin settings (IAdmin) and section (ISection)
* SettingsManager service
* example setup with LDAP app
2016-08-09 18:05:09 +02:00
a999420c75
get shared storage storage id without setting up the storage
2016-08-09 15:52:13 +02:00
73311091bf
Merge pull request #519 from GitHubUser4234/master
...
New LDAPProvider for user_ldap
2016-07-28 10:14:34 +02:00
bd65a17203
Nextcloud license header for new files
2016-07-28 15:13:00 +08:00
681eebcfe6
Remove php side of check registration
2016-07-27 10:21:26 +02:00
2719dcabed
Merge branch 'master' of https://github.com/nextcloud/server
2016-07-27 15:17:29 +08:00
32fb6beac3
final changes
2016-07-27 15:10:35 +08:00
2f42a3fc31
Add workflowengine
2016-07-26 11:16:34 +02:00
81e103074e
use limit instead of since when listing recent files
2016-07-22 15:20:55 +02:00
e321ecd592
add recent files to node api
2016-07-22 14:39:32 +02:00
02ec8b1726
New LDAPProvider for user_ldap
2016-07-22 16:46:29 +08:00
8c7d7d7746
Merge pull request #507 from nextcloud/run-le-script
...
Update emails and license headers with latest changes
2016-07-21 23:27:15 +02:00
0215b004da
Update with robin
2016-07-21 18:13:58 +02:00
ba87db3fcc
Fix others
2016-07-21 18:13:57 +02:00
e42f2f2650
AppFramework do not get default response
...
The OCSResponse differs from other responses in that it defaults to
XML. However we fell back to json by default.
This makes sure that if nothing is set we don't pass anything.
Which defaults then to the controllers default (which is often 'json')
but in the case of the OCSResponse 'xml'.
2016-07-20 22:05:43 +02:00
020a2a6958
Merge pull request #476 from nextcloud/port-same-site-cookies
...
[master] Port Same-Site Cookies to master
2016-07-20 21:35:02 +02:00
cff5be3d63
Deprecate \OCP\API
2016-07-20 20:03:53 +02:00
ea47974a08
Add OCSMiddleware to catch OCS exceptions
...
* OCSException
* OCSBadRequestException
* OCSForbiddenException
* OCSNotFoundException
2016-07-20 20:03:49 +02:00
a299fa38a9
[master] Port Same-Site Cookies to master
...
Fixes https://github.com/nextcloud/server/issues/50
2016-07-20 18:37:57 +02:00
1264e9644f
Merge pull request #402 from nextcloud/smb-notifications
...
smb update notifications
2016-07-20 16:19:21 +02:00
544c3c1565
Merge pull request #436 from nextcloud/public-regex-to-match-our-clients
...
Copy the regexes to the public interface
2016-07-19 11:35:10 +02:00
0a6d95b126
Merge pull request #394 from nextcloud/tags-for-everything
...
SystemTags for everything not just files
2016-07-19 10:47:12 +02:00
b1d652e8b0
Copy the regexes to the public interface
2016-07-18 15:11:44 +02:00
9795a732ff
Update since version
2016-07-18 10:26:43 +02:00
7c039bcbf6
Allow apps to register SystemTags plugins
2016-07-18 10:26:42 +02:00
d485cfd40d
fix since
2016-07-15 13:58:44 +02:00
2c988ecbf4
Use the themed Defaults everywhere
2016-07-15 09:17:30 +02:00
e1fa314b18
add notify support to smb storage
2016-07-14 14:46:01 +02:00
29eeeb2273
Save the files external mount id in the mount cache table
2016-07-13 16:34:08 +02:00
28d070730d
Fix case with no user
2016-06-14 11:34:41 +02:00
ae3d0d96fe
Optimize isSharingDisabledForuser
2016-06-14 10:17:06 +02:00
52a0c939ab
Merge pull request #24863 from owncloud/propagator-batching
...
Propagator batching for the file scanner
2016-06-10 17:45:52 +02:00
369c3b5d7e
Implement classification migration as repair step
2016-06-09 11:09:14 +02:00
911fd3ead4
Do not allow to store boolean configs, they behave unexpected on postgres
2016-06-06 12:38:20 +02:00
9fb44e34af
add propagator batching
2016-06-02 15:07:47 +02:00
aba539703c
Update license headers
2016-05-26 19:57:24 +02:00
de9b30490e
Move public search namespace to PSR-4
2016-05-24 11:52:44 +02:00
adcf942901
Merge pull request #24750 from owncloud/lenz1111-share_download_range_requests_support
...
Http Range requests support in downloads
2016-05-23 21:01:26 +02:00
87fa86a69a
Merge pull request #24559 from owncloud/2fa
...
two factor auth
2016-05-23 20:50:03 +02:00
6577bbe887
Code style and doc fix
2016-05-23 15:17:00 +02:00
eca57be336
Only recurse into incomplete folders during background scans
2016-05-23 14:40:35 +02:00
dfb4d426c2
Add two factor auth to core
2016-05-23 11:21:10 +02:00
0b831a2bed
Move EntityEvent to PSR-4
2016-05-23 09:06:02 +02:00
c9fda84841
Make the root collection neutral so it does not only work for files
2016-05-23 09:03:48 +02:00
7a6966cdfe
Merge pull request #24732 from owncloud/autoloader_fix
...
Autoloader fix
2016-05-21 19:09:22 +02:00
8646802850
Merge pull request #24696 from owncloud/lock-jobs-while-executing
...
Lock jobs while executing them, to allow multiple executors to run in…
2016-05-21 19:08:15 +02:00
d0a2fa0506
Lock jobs while executing them, to allow multiple executors to run in parallel
2016-05-21 01:59:25 +02:00
7e3ce83526
Add a method to lock a table
2016-05-21 01:59:03 +02:00
9999e05660
Http Range requests support in downloads
...
Http range requests support is required for video preview
2016-05-20 18:16:44 +02:00
8fbb63d316
Some tweaks for systemtagmanager
2016-05-20 17:56:02 +02:00
3cd65fe25d
Add systemtag_group table and get/set methods
...
Added systemtag to group mapping table.
Added methods in ISystemTagManager to get/set the group mappings.
2016-05-20 17:56:02 +02:00
09b3883d9c
Updated canUser* functions in SystemTagManager to accept objects
2016-05-20 17:56:02 +02:00
8343cfb64b
Add interface methods for permission check
...
Instead of checking for admin perm, use interface method
canUserAssignTag and canUserSeeTag to check for permissions.
Allows for more flexible implementation.
2016-05-20 17:56:02 +02:00
edb512bf4d
Move Template to PSR-4
2016-05-20 16:35:07 +02:00
65eae43ab1
Merge pull request #24721 from owncloud/public_psr4
...
Move \OCP to PSR-4
2016-05-19 15:53:03 +02:00
0bbf825f6e
Merge pull request #24722 from owncloud/notification_psr4
...
Move \OCP\Notification to PSR-4
2016-05-19 15:35:45 +02:00
7d2bc47f81
Merge pull request #24724 from owncloud/mail_psr4
...
Move \OCP\Mail to PSR-4
2016-05-19 15:35:09 +02:00
5ba0554974
Merge pull request #24723 from owncloud/migration_psr4
...
Move \OCP\Migration to PSR-4
2016-05-19 15:34:22 +02:00
a4ce528bca
Merge pull request #24720 from owncloud/systemtag_psr4
...
Move \OCP\SystemTag to PSR-4
2016-05-19 15:33:59 +02:00
8425133c7d
Merge pull request #24719 from owncloud/security_psr4
...
Move \OCP\Security to PSR-4
2016-05-19 15:33:05 +02:00
6ace14b6ad
Merge pull request #24718 from owncloud/route_psr4
...
Move \OCP\Route to PSR-4
2016-05-19 10:30:32 +02:00
78732aaf0c
Merge pull request #24717 from owncloud/preview_psr4
...
Move \OCP\Preview to PSR-4
2016-05-19 10:30:21 +02:00
ae7e14b223
Merge pull request #24710 from owncloud/lock_psr4
...
Move \OCP\Lock to PSR-4
2016-05-19 10:28:49 +02:00
d666725fa7
Move \OCP to PSR-4
2016-05-19 09:43:33 +02:00
c05032ff20
Move \OCP\SystemTag to PSR-4
2016-05-18 18:30:49 +02:00
f67f888d50
Move \OCP\Security to PSR-4
2016-05-18 18:28:31 +02:00
2dc8c3a3f2
Move \OCP\Route to PSR-4
2016-05-18 18:23:44 +02:00
dc0e3617dc
Merge pull request #24707 from owncloud/l10n_psr4
...
Move \OCP\L10N to PSR-4
2016-05-18 18:23:44 +02:00
31f6d01606
Move \OCP\Preview to PSR-4
2016-05-18 18:22:34 +02:00
bd27eadf9e
Move \OCP\Notification to PSR-4
2016-05-18 18:21:27 +02:00
1c721771ff
Move \OCP\Migration to PSR-4
2016-05-18 18:19:24 +02:00
babdf8477d
Move \OCP\Mail to PSR-4
2016-05-18 17:42:33 +02:00
12fd87d0a3
Move \OCP\Lock to PSR-4
2016-05-18 17:10:04 +02:00
4a94203492
Merge pull request #24706 from owncloud/http_psr4
...
Move \OCP\Http to PSR-4
2016-05-18 16:50:17 +02:00
40bf0a913f
Move \OCP\L10N to PSR-4
2016-05-18 16:38:44 +02:00
4a53542e45
Move \OCP\Files to PSR-4
2016-05-18 14:35:50 +02:00
1d2c1e60ee
Move \OCP\Http to PSR-4
2016-05-18 09:24:10 +02:00
d5506b605f
Move \OCP\Encryption to PSR-4 ( #24680 )
2016-05-17 23:08:43 +02:00
de5b7609f9
use mount providers to setup home storages ( #24567 )
2016-05-17 21:40:55 +02:00
7dbdf2f7e0
\OCP\DB to PSR-4 ( #24650 )
...
* Move \OCP\DB to PSR-4
* Fix PHP doc
2016-05-17 17:38:25 +02:00
90a290afd8
Move \OCP\Diagnostics to PSR-4 ( #24667 )
2016-05-17 15:53:49 +02:00
499f0e487d
Move \OCP\Authentication to PSR-4 ( #24632 )
2016-05-17 10:29:23 +02:00
cbff3e0de7
Move \OCP\Console to PSR-4 ( #24636 )
2016-05-17 10:28:58 +02:00
15fdd36617
Move \OCP\Contacts to PSR-4 ( #24645 )
2016-05-17 10:22:21 +02:00
5e03e9a843
Merge pull request #24083 from owncloud/fix-race-condition
...
Read only once
2016-05-17 09:03:57 +02:00
56f4c4bed9
Move \OCP\Comments to PSR-4 ( #24565 )
2016-05-12 09:48:11 +02:00
73b8158519
Move \OCP\Command to PSR-4
2016-05-10 20:14:04 +02:00
e74323ca90
Fix phpdoc
2016-05-10 12:43:35 +02:00
b6b35b55c7
Move \OCP\Capabilities to PSR-4
2016-05-09 07:30:56 +02:00
fd371700a2
Move \OCP\BackgroundJob to PSR-4
2016-05-07 12:15:59 +02:00
e47b186d51
Move \OCP\AppFramework to PSR-4
2016-05-06 20:38:34 +02:00
ec8298c493
Move \OCP\App to PSR-4
2016-05-06 13:32:46 +02:00
9185517bf0
Move \OCP\Activity to PSR-4
2016-05-05 20:25:08 +02:00
4b2544925f
Merge pull request #23844 from owncloud/disable-user
...
Add occ commands to enable and disable a user + a disabled user can n…
2016-05-03 15:22:41 +02:00
df2eb96cc4
Merge pull request #24389 from owncloud/login-by-email
...
Allow login by email address
2016-05-03 13:44:38 +02:00
61ce4f4ef3
Add methods to public interface
2016-05-03 10:30:15 +02:00
b84825f030
Merge pull request #24229 from owncloud/session-id-wrapper
...
add ISession::getId() wrapper for session_id
2016-05-02 16:49:38 +02:00
b10dcfc3b7
Fixing local event delivery for calendar events based on the email address
2016-05-02 14:20:59 +02:00
f81b57bc45
Read only once
...
This can lead to race conditions otherwise. Also depracted hasKey
2016-05-02 11:31:57 +02:00
9c9fec36dd
Add occ commands to enable and disable a user + a disabled user can no longer login - fixes #23838
2016-05-02 09:31:22 +02:00
821d8736c8
Adding progress to web upgrade
2016-04-28 13:52:01 +02:00
e93bf80b29
throw SessionNotAvailableException if session_id returns empty string
2016-04-26 14:51:21 +02:00
6d62a74d7e
Merge pull request #24199 from owncloud/ocp-repair
...
Introduce OCP\Migration\IRepairStep and adopt all repair steps to thi…
2016-04-26 08:47:04 +02:00
f6e1b43a38
Merge pull request #22648 from owncloud/propagate-single
...
do propagation in a single query
2016-04-25 23:01:45 +02:00
dbfdc6282a
do propagation in a single query
2016-04-25 16:18:59 +02:00
a18c8a7da0
Fix the syntax and methods in the sample
2016-04-25 16:03:20 +02:00
c7542c02db
Introduce OCP\Migration\IRepairStep and adopt all repair steps to this new interface - refs #24198
2016-04-25 15:01:13 +02:00
0d53e86421
add ISession::getId() wrapper for session_id
2016-04-25 10:36:24 +02:00
4eebccd81f
Fix inconsistent nameing of AppFramework
2016-04-22 16:00:00 +02:00
a061ef75ea
Merge pull request #24127 from owncloud/handle-app-loading-error
...
Handle app loading error
2016-04-20 22:41:02 +02:00
cd01c440a0
Merge pull request #23919 from owncloud/cyclyc-share-dep-example
...
SharedStorage to new sharing code + cleanup
2016-04-20 20:37:27 +02:00
069af51dd0
With PHP7 Throwable is the new base interface for all Exception and Error - we should be capable to log Throwable as well
2016-04-20 17:56:08 +02:00
5b2ef92eb2
Merge pull request #24004 from owncloud/dont-transfer-files-to-not-ready-user
...
Introduce isReadyForUser and verify in file transfer ownership
2016-04-19 15:56:47 +02:00
2f1c62ce0b
Only construct the storage when we start using it
2016-04-19 14:04:00 +02:00
1773dcbef2
Merge pull request #23973 from owncloud/share_move_post_delete_from_group_hook
...
Move post_removeFromGroup to shareManager
2016-04-19 06:59:58 +02:00
8222ad5157
Move logout to controller
...
Testable code. Yay.
2016-04-18 21:21:52 +02:00
50e20e531e
Introduce isReadyForUser and verify in file transfer ownership - fixes #23786
2016-04-15 15:07:40 +02:00
6144ced7a0
Move post_removeFromGroup to shareManager
...
The last sharing hook to be moved over.
* Added unit tests
* Removed old tests that relied on old behaviour
* Removed old hooks.php
2016-04-13 15:00:12 +02:00
495a964ca2
Migrate post_groupDelete hook to share manager ( #23841 )
...
The hook now calls the share manager that will call the responsible
shareProvider to do the proper cleanup.
* Unit tests added
Again nothing should change it is just to cleanup old code
2016-04-12 09:46:25 +02:00
b1a856d7b7
lib: Fix typos (found by codespell)
...
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2016-04-07 19:51:27 +02:00
0de15a86f0
Merge pull request #23773 from owncloud/share_move_delete_user_hook
...
Migrate post_userDelete hook to share manager
2016-04-07 13:01:10 +02:00
64d400b5df
Prevent null to be passed into the closure of callForAllUsers
2016-04-05 10:26:04 +02:00
e0cee43cf0
Migrate post_userDelete hook to share manager
...
This makes the post_userDelete hook call the sharemanager. This will
cleanup to and from this user.
* All shares owned by this user
* All shares with this user (user)
* All custom group shares
* All link share initiated by this user (to avoid invisible link shares)
Unit tests are added for the defaultshare provider as well as the
federated share provider
2016-04-04 14:15:38 +02:00
4887f0f9b5
Add better messages for sometimes obscure exceptions
...
* add better messages for sometimes obscure exceptions
* fix formatting
2016-04-04 10:55:46 +02:00
902abe33f5
Merge pull request #23676 from owncloud/handle-null-return-getAppInfo
...
Properly handle return values of OC_App::getAppInfo()
2016-03-31 22:21:50 +02:00
f5beeec833
Properly handle return values of OC_App::getAppInfo()
...
* fixes #23668
2016-03-30 23:29:26 +02:00
d883b877d1
Move OCP\Share over to PSR-4
...
Touching the code so moving it over to PSR-4
2016-03-30 22:55:03 +02:00
2f4294e781
Add setId and setProviderID to the public interface
...
Fixes #23337
We only allow the id to be set once!
2016-03-30 22:55:03 +02:00
c0858f42aa
Allow the activity app to set the current user when sending emails
2016-03-24 09:36:44 +01:00
640e6351f1
Merge pull request #23485 from owncloud/composer_allow_ocp
...
Allow OCP classes to be PSR-4 as well
2016-03-22 21:28:45 +01:00
195efc12eb
Add config to sharemanager
2016-03-22 17:13:34 +01:00
5b78c604b5
Move IServerContainter to PSR-4
2016-03-22 16:39:19 +01:00
0864851001
Replace unneded OC::needUpgrade with OCP method
2016-03-14 10:10:29 +01:00
b8ce9c5554
Use more generic node instead of File/Folder
...
The phpdoc for the sharing functions was very restrictive. As a
consequence passing node object (for example from the OCS Share API
where we don't really care if it is a file or folder), would actually
be invalid.
With this loser restriction the interfaces become more generic.
2016-03-11 08:51:07 +01:00
e6712c47a6
Fix some scrutinizer warning in the sharing code
...
* Better phpdoc
* Promper use statements
* Unused parameter
2016-03-10 21:35:22 +01:00
02635c6f2f
Add locking to the node api
2016-03-03 13:47:00 +01:00
c353d51810
Remove Scrutinizer Auto Fixer
2016-03-01 17:48:23 +01:00
c430f5ba53
Map Maci
2016-03-01 17:45:05 +01:00
933f60e314
Update author information
...
Probably nice for the people that contributed to 9.0 to see themselves in the AUTHORS file :)
2016-03-01 17:25:15 +01:00
3adb6ae0f5
Merge pull request #22707 from owncloud/use-our-public-api
...
Use IQueryBuilder::PARAM_* instead of \PDO::PARAM_*
2016-03-01 07:24:57 +01:00
a1c02a0567
Fix since version
2016-02-29 11:02:10 +01:00
2a0cda74d4
Use IQueryBuilder::PARAM_* instead of \PDO::PARAM_*
2016-02-29 09:44:40 +01:00
9a0950f10b
Merge pull request #22569 from owncloud/issue-22566-too-much-mapping-entries
...
Allow defining a limit and offset for getObjectIdsForTags
2016-02-23 15:02:08 +01:00
fae6643e6d
Merge pull request #22582 from owncloud/case-insensitive-contact-search
...
Case insensitive contact search
2016-02-23 10:48:38 +01:00
fb8b34bdd0
Allow defining a limit and offset for getObjectIdsForTags
2016-02-23 09:04:15 +01:00
83d5080e78
Merge pull request #22581 from owncloud/fix_interface
...
since 9.0 we have a additional parameter $position used for integrity…
2016-02-22 20:20:33 +01:00
4537eaac41
Add ILIKE support to querybuilder
2016-02-22 19:46:37 +01:00
33ec70d57e
since 9.0 we have a additional parameter $position used for integrity checks
2016-02-22 18:25:01 +01:00
fe08b5e9d9
We should check for exceptions when trying to get the avatar
...
Fixes #22550
* Updated phpdoc of avatatmanager
* Add unit test
2016-02-22 10:14:14 +01:00
8756a22c60
Fix more things
2016-02-19 09:43:11 +01:00
0d0151a3e1
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2016-02-19 09:43:11 +01:00
534071f4b2
set correct http status code
...
Was intended to respond with a 303 (See other) status code instead of 307 (Temporary Redirect).
2016-02-18 11:56:09 +01:00
6bd0d51b2a
More characters are allowed on POSIX systems
2016-02-12 07:49:31 +01:00
8b165c5ed5
No longer evaluate appinfo/version
2016-02-10 17:24:14 +01:00
cf3a8f274f
make it backward compatible to work with signed and un-signed files
2016-02-09 23:43:25 +01:00
29f6f451a9
Merge pull request #22192 from owncloud/fix_19685
...
Only set the default expiration date on share creation
2016-02-09 23:38:00 +01:00
962d0c3290
Merge pull request #22252 from owncloud/consolidate-user-set-quota
...
Consolidate getQuota and setQuota methods in User instance
2016-02-09 22:00:24 +01:00
82a37d41d0
Doc improvements
2016-02-09 17:41:04 +01:00
3a796d1e15
Consolidate getQuota and setQuota methods in User instance
2016-02-09 17:16:43 +01:00
2982017682
Merge pull request #22228 from owncloud/comments-limit-message
...
Limit comment message to 1k chars
2016-02-09 16:35:23 +01:00
bbc86e0756
on DAV throw Bad Request if provided message is too long
2016-02-09 13:59:13 +01:00
426a12baaa
Throw exception
2016-02-09 11:05:29 +01:00
ee65cd0bd8
Only set the default expiration date on share creation
...
Fixes #19685
The default expiration date should only be set when we create a new
share. So if a share is created and the expiration date is unset. And
after that the password is updated the expiration date should remain
unset.
2016-02-09 11:05:14 +01:00
347ad3e223
Limit comment message to 1k chars
2016-02-09 03:14:30 +01:00
cd00751de5
Send events when enabling and disabling of apps
2016-02-09 02:51:12 +01:00
ec399e6bbc
Merge pull request #22200 from owncloud/node-checksum-resolvefileinfo
...
Make sure fileinfo exists when calling getCheckSum in node API
2016-02-08 16:10:31 +01:00
acc7d63a69
Merge pull request #22164 from owncloud/files_external-verify
...
Add occ command to verify storage configurations
2016-02-08 15:21:07 +01:00
1e8e00c541
Add proper throw tags to File
2016-02-08 14:44:26 +01:00
b95e388526
Add occ command to verify storage configurations
2016-02-08 14:07:58 +01:00
a506f9ca3f
Respect not allowing outgoing shares
2016-02-08 11:30:48 +01:00
8486d61764
getSharesBy should also expire link shares
2016-02-06 13:31:54 +01:00
5832178f59
Merge pull request #22139 from owncloud/comments-files-cleanup
...
cleanup jobs for comments and comment read marks
2016-02-06 13:26:00 +01:00
a9015d61a7
Merge pull request #22166 from owncloud/remove-local-folder
...
remove unused Storage->getLocalFolder
2016-02-06 13:21:59 +01:00
065141f6f4
Move casting to IExpressionBuilder
2016-02-05 21:26:30 +01:00
6ccd5ecb07
Merge pull request #22169 from owncloud/cache-interface-fixes
...
Cache interface cleanup/phpdoc
2016-02-05 18:09:19 +01:00
282c1cb24f
remove unused Storage->search
2016-02-05 17:52:37 +01:00
559189cf47
additional phpdoc for search
2016-02-05 17:52:19 +01:00
615f0f5499
add deprecation notice to search methods
2016-02-05 17:46:43 +01:00
fb76d7de69
remove unused Storage->getLocalFolder
2016-02-05 16:48:08 +01:00
e15a120f83
Merge pull request #22152 from owncloud/activities-for-comments
...
Activities for comments
2016-02-05 13:50:38 +01:00
97b907335a
Dispatch an event when a console command is run
2016-02-05 12:24:54 +01:00
e86dcdacc8
Dispatch events when adding, updating and deleting comments
2016-02-05 11:30:53 +01:00
0f22a8db1d
Also add type (file/folder) to IShare object
...
We need this for the hooks :(
2016-02-04 14:28:09 +01:00
fc215d0980
Make the share object lazy
...
Share providers can now just pass in a fileId. And the node will only be
created once needed.
2016-02-04 12:51:23 +01:00
b594aa18ee
Merge pull request #22110 from owncloud/comment-types-always-plural
...
types shall always be plural
2016-02-04 10:55:49 +01:00
9370491822
types shall always be plural
2016-02-03 19:28:15 +01:00
96662c4d0d
[Share 2.0] Fix shareManager
2016-02-03 19:25:29 +01:00
eb904c7aa9
[Share 2.0] Fix defaultshare provider
2016-02-03 19:25:29 +01:00
78be766cf5
[Share 2.0] Use strings for ids
...
* sharedWith
* sharedBy
* shareOwner
Now all set/get strings with the id. (userId, groupId,
federatedsharerId).
This to avoid a huge amount of if statements
2016-02-03 19:25:29 +01:00
ab1c79827e
Merge pull request #22071 from owncloud/cache-split-insert
...
split cache->insert from cache->put
2016-02-03 14:32:28 +01:00
aaf7299d28
Merge pull request #22070 from owncloud/share2_exceptions
...
Add sharing exceptions to OCP
2016-02-03 13:36:14 +01:00
f2bba59b79
split cache->insert from cache->put
2016-02-03 12:55:36 +01:00
2035a179bc
Add store/retrieve checksums
...
* Add extra db column to filecache
* Bump version
* Update filecache code to actually handle checksum
* Webdav code to store/retrieve checksums
2016-02-03 09:03:51 +01:00
4d7130ad31
[Share 2.0] Add exceptions to OCP
2016-02-02 14:07:11 +01:00
ce053b9808
Merge pull request #22013 from owncloud/share2_moveshare
...
[Share 2.0] Allow moving of shares
2016-02-02 13:34:50 +01:00
2d1d89ee29
Merge pull request #22049 from owncloud/issue-22041-activities-for-systemtags
...
Issue 22041 activities for systemtags
2016-02-02 13:08:01 +01:00
2316cb1f8b
[Share 2.0] Allow moving of shares
...
* Only recipient can move a share
* Unit tests
2016-02-02 11:34:52 +01:00
403547f0ea
[Share 2.0] Allow recipient to be passed in to getShareById
...
* This allows us to retrieve usergroup shares for a given id.
If the user deleted a share or moved it this will be a different share
2016-02-02 10:41:57 +01:00
d5126b1ad4
Dispatch events when tags are added/updated/deleted
2016-02-02 09:57:42 +01:00
591613fce2
Dispatch some events when tags are un-/assigned
2016-02-02 09:57:42 +01:00
b4853f3fce
Merge pull request #21967 from owncloud/comments-webdav
...
Comments WebDAV adjustements
2016-02-01 16:17:45 +01:00
32067ac49b
Merge pull request #21989 from owncloud/make-csp-modifiable
...
Add public API to give developers the possibility to adjust the global CSP defaults
2016-02-01 10:10:40 +01:00
a025b2865f
Merge pull request #22022 from owncloud/share_ocs_filter_path_sharedwithme
...
Add path filter to OCS Share API shared_with_me=true
2016-02-01 09:00:31 +01:00
5f4b204a49
Merge pull request #22012 from owncloud/storagenotavailableexception-code
...
Default to STATUS_ERROR in StorageNotAvailableException
2016-02-01 09:00:14 +01:00
67bf225fbe
Merge pull request #21956 from owncloud/cross-cache-move
...
Add fallback moveFromCache implementation
2016-01-29 17:03:16 +01:00
a24e7f6558
Add path filter to OCS Share API ?shared_with_me=true
...
This allows all clients to quickly get the share info for a given path.
Instead of returning everything and filtering it then manually on the
client side.
2016-01-29 15:36:23 +01:00
01cdc70f9c
introduce comments read marke tables, comes with user cleanup after deletion
2016-01-29 13:08:02 +01:00
d2882b9021
Comments WebDAV adjustements
2016-01-29 13:08:02 +01:00
ec3f6549f6
Add fallback moveFromCache implementation
2016-01-29 13:06:59 +01:00
2abb173599
Default to STATUS_ERROR in StorageNotAvailableException
2016-01-29 11:57:25 +00:00
c83b3d6a26
Remove other broken usages in deprecated methods
2016-01-29 08:50:29 +01:00
809ff5ac95
Add public API to give developers the possibility to adjust the global CSP defaults
...
Allows to inject something into the default content policy. This is for
example useful when you're injecting Javascript code into a view belonging
to another controller and cannot modify its Content-Security-Policy itself.
Note that the adjustment is only applied to applications that use AppFramework
controllers.
To use this from your `app.php` use `\OC::$server->getContentSecurityPolicyManager()->addDefaultPolicy($policy)`,
$policy has to be of type `\OCP\AppFramework\Http\ContentSecurityPolicy`.
To test this add something like the following into an `app.php` of any enabled app:
```
$manager = \OC::$server->getContentSecurityPolicyManager();
$policy = new \OCP\AppFramework\Http\ContentSecurityPolicy(false);
$policy->addAllowedFrameDomain('asdf');
$policy->addAllowedScriptDomain('yolo.com');
$policy->allowInlineScript(false);
$manager->addDefaultPolicy($policy);
$policy = new \OCP\AppFramework\Http\ContentSecurityPolicy(false);
$policy->addAllowedFontDomain('yolo.com');
$manager->addDefaultPolicy($policy);
$policy = new \OCP\AppFramework\Http\ContentSecurityPolicy(false);
$policy->addAllowedFrameDomain('banana.com');
$manager->addDefaultPolicy($policy);
```
If you now open the files app the policy should be:
```
Content-Security-Policy:default-src 'none';script-src yolo.com 'self' 'unsafe-eval';style-src 'self' 'unsafe-inline';img-src 'self' data: blob:;font-src yolo.com 'self';connect-src 'self';media-src 'self';frame-src asdf banana.com 'self'
```
2016-01-28 18:36:46 +01:00
ef73aedd7e
Deprecate the method and warn against using it
2016-01-28 15:40:23 +01:00
b7710ab6d7
Merge pull request #21858 from owncloud/getMountsForFileId
...
add IUserMountCache->getMountsForFileId
2016-01-28 11:20:42 +01:00
8d44e537ac
[Share 2.0] Remove setId and setProviderId from the interface
...
Those should only ever be set by the providers
2016-01-28 07:54:16 +01:00
34e912ab6b
[Share 2.0] Fix interfaces and comments
...
* Made comments more clear
* Removed unneeded methods
* IShares shareTime is now a proper DateTime object
* IShares getPath -> getNode & setPath -> setNode
* Fix unit tests
2016-01-28 07:54:09 +01:00
f2e70441e4
[Share 2.0] Add getShareManager to OCP\IServerContainer
2016-01-27 22:04:37 +01:00
357b271cb4
[Share 2.0] Create IManger interface for share manager
2016-01-27 22:04:37 +01:00
185b9c6edd
[Share 2.0] Move IShare to OCP
2016-01-27 22:04:37 +01:00
6682f31074
clean cache interface
2016-01-27 15:51:39 +01:00
644a8ab797
add IUserMountCache->getMountsForFileId
2016-01-27 12:53:44 +01:00
1594371c8c
Merge pull request #21741 from owncloud/l10n-improvements
...
Move methods to the factory that are not related to translating, but to guessing/finding the language
2016-01-27 09:37:00 +01:00
7514695399
Fix Oracle comparisons
2016-01-26 14:56:07 +01:00
90ce876378
Adjust comments to the new constants
2016-01-26 14:56:07 +01:00
6652a0fb6c
Move finding the language files and creating the function out of the object
2016-01-26 14:02:31 +01:00
043625ee52
Move findLanguage() and setLanguageFromRequest() to factory
2016-01-26 14:02:31 +01:00
29a9306429
Move languageExists() to the factory
2016-01-26 14:02:31 +01:00
6aec550d6e
Move findAvailableLanguages() to the factory
2016-01-26 14:02:30 +01:00
2bafb1c649
Merge pull request #21894 from owncloud/refactor-csrf
...
Add new CSRF manager for unit testing purposes
2016-01-26 11:36:56 +01:00
4c9e328211
Merge pull request #21892 from owncloud/issue-21890-parameters
...
Add parameters types to IQueryBuilder
2016-01-25 21:13:41 +01:00
a977465af5
Add new CSRF manager for unit testing purposes
...
This adds a new CSRF manager for unit testing purposes, it's interface is based upon https://github.com/symfony/security-csrf . Due to some of our required custom changes it is however not possible to use the Symfony component directly.
2016-01-25 20:03:40 +01:00
c5046fb2a9
Add parameters to public interface
2016-01-25 17:17:20 +01:00
728caf13f8
Adding support of -1 as size to be passed into get and getFile
2016-01-25 16:54:40 +01:00
75e6734ef4
Remove OC_Helper::imagePath and use the proper public interface
2016-01-24 18:04:20 +01:00
7731b29136
Merge pull request #21719 from owncloud/move-notification-api-to-ocp
...
Move the notification API to public namespace
2016-01-22 16:20:26 +01:00
9b4c9a0357
Merge pull request #18531 from owncloud/ext-user-credentials
...
External storage 'Login credentials' auth mechanism
2016-01-22 13:14:14 +01:00
31c5848e51
Allow automatic injection of the Manager
2016-01-22 11:02:40 +01:00
1410120758
Merge pull request #20768 from owncloud/mount-cache
...
cache mountpoints in the db
2016-01-22 11:01:54 +01:00
9ea7ae6f87
Adjust the since on the interface
2016-01-22 10:51:36 +01:00
ee02165005
Move the notification API to public namespace
2016-01-22 10:32:42 +01:00
75ee5a9e9a
Fix PHPDoc - @changed is no official tag -> use @since
2016-01-22 08:43:05 +01:00
7c7467fe42
Merge pull request #21792 from owncloud/systemtags-managerfactory
...
Allow custom implementation of system tag managers
2016-01-21 12:13:01 +01:00
899f9bd113
Allow custom implementation of system tag managers
...
Added config.php option to replace the default implementation of system
tag manager and system tag object mapper.
Also adjusted the comments manager factory to inject the server container
2016-01-20 16:36:10 +01:00
483c6b68e2
clear mount cache when removing applicables
2016-01-20 16:32:56 +01:00
be380accb9
clear mount cache when deleting user
2016-01-20 16:32:56 +01:00
99415a9f7f
multiple minor fies
2016-01-20 16:32:52 +01:00
cf6ee1c866
cache mountpoints in the db
2016-01-20 16:30:22 +01:00
aeb89947a2
Introduce IUser::setEMailAddress and add hook mechanism
2016-01-20 14:57:20 +01:00
58afddfaa5
allow comparing clob using expressionbuilder->eq if you explicitly say you're comparing strings
2016-01-18 16:03:41 +01:00
da4127d23b
Introduce CredentialsManager for storage of credentials in DB
...
CredentialsManager performs a simple role, of storing and retrieving
encrypted credentials from the database. Credentials are stored by user
ID (which may be null) and credentials identifier. Credentials
themselves may be of any type that can be JSON encoded.
The rationale behind this is to avoid further (mis)use of
oc_preferences, which was being used for all manner of data not related
to user preferences.
2016-01-18 11:10:41 +01:00
88cd615214
Introduce IDBConnection::setValues()
...
setValues() attempts to insert a new row, or failing that, update an
existing row. The ability to set preconditions is also available.
2016-01-18 11:10:41 +01:00
807cf750b3
Merge pull request #21705 from owncloud/improve-background-job-message
...
Improve background job error message
2016-01-15 20:12:26 +01:00
f6c4b10189
Add message key to context of logException
2016-01-15 14:55:30 +01:00
416fb65605
Merge pull request #21717 from owncloud/addpublicgroupinterface
...
allow apps to add an OCP GroupInterface backend
2016-01-15 12:38:18 +01:00
52040a3f23
Merge pull request #20898 from owncloud/cache-interfaces
...
Public Cache interfaces
2016-01-15 12:02:31 +01:00
2ebb5726d7
add TODOs with the actual interface name
2016-01-14 14:34:35 +01:00
64043e9bcc
move methods to correct interface, deprecate private interface
2016-01-14 14:28:03 +01:00
bd77cd98c9
allow apps to add an OCP GroupInterface backend
2016-01-14 13:58:45 +01:00
7530f66f52
remove unneeded public cache methods
2016-01-14 13:01:46 +01:00
0724ac1e5e
split locking related methods to their own interface
2016-01-14 12:54:42 +01:00
3deb3bd163
Add IStorage interface for consistent naming
...
minor phpdoc fixed
2016-01-14 12:54:42 +01:00
dcbeeced3b
add since tags
2016-01-14 12:54:42 +01:00
989995a852
fix phpdoc
2016-01-14 12:54:42 +01:00
a3d50ef49a
add watcher interface
2016-01-14 12:54:42 +01:00
c27894791e
Add updater interface and expose cache interfaces from storage
2016-01-14 12:54:42 +01:00
5fae07f422
add scanner interface
2016-01-14 12:54:42 +01:00
6d321f5f6b
Return a class from cache operations instead of an array
2016-01-14 12:54:42 +01:00
3ab0ccd4a2
add cache entry interface
2016-01-14 12:54:42 +01:00
2dcdc81477
propagator interface
2016-01-14 12:54:42 +01:00
cdc8c40d60
Add public cache interface
2016-01-14 12:54:42 +01:00
c5a200c419
Merge pull request #21653 from owncloud/update-license-headers-2016
...
Update license headers 2016
2016-01-13 08:29:42 +01:00
59e9b93be6
Merge pull request #20948 from owncloud/fed-sync-contacts
...
Syncing system addressbooks across federated ownClouds
2016-01-13 08:27:51 +01:00
682821c71e
Happy new year!
2016-01-12 15:02:18 +01:00
dbddbb634b
Use EventDispatcher to allow additional setup of auth backends - move federation auth to federation app
2016-01-12 14:24:01 +01:00
c15cab7ed6
Allow admins to add system wide root certificates
2016-01-12 12:50:59 +01:00
078cf8ae36
fix identation in public/irequest.php
2016-01-12 08:48:51 +01:00
e01a488b31
Remove generateRandomBytes from OC_Util
2016-01-10 22:07:33 +01:00
0f5132552c
Merge pull request #21292 from owncloud/checkAppEnabled-not-needed-anymore
...
core will handle invalid URLs and redirects properly
2016-01-08 13:36:11 +01:00
34c8249799
Deprecate remaining function and entire class
2016-01-07 21:29:51 +01:00
9bf01283e7
Cleanup router code
...
- Some functions are entirely broken
- PHPDoc etc...
2016-01-07 21:29:51 +01:00
fec41e7539
Move regeneration of session ID into session classes
...
There were code paths that nowadays call ISession::login directly thus bypassing the desired regeneration of the session ID. This moves the session regeneration deeper into the session handling and thus ensures that it is always called. Furthermore, I also added the session regeneration to the remember me cookie plus added some test case expectations for this.
2016-01-04 15:09:01 +01:00
6f00729124
Refactor OC_Util::callCheck
2015-12-22 09:32:14 +01:00
95a255b0d4
Merge pull request #21281 from owncloud/allow-di-for-background-jobs
...
Allow background jobs to be service names for DI
2015-12-18 16:34:42 +01:00
2f98f64241
core will handle invalid URLs and redirects properly
2015-12-18 15:51:03 +01:00
50e8773307
Merge pull request #21280 from owncloud/drop-unused-methods
...
OC_Helper::makeURLAbsolute is not used anymore
2015-12-18 14:49:55 +01:00
a9935bd490
Add methods to interface which have always been required
2015-12-18 14:25:04 +01:00
450e2f3bd3
Move OC_Helper code to OCP\Util for linkToRemote
2015-12-18 12:00:18 +01:00
e42f262d85
properly use OCP\Util instead of OC_Helper
2015-12-18 11:46:21 +01:00
0f836cfe9e
Make sure the interface and the implementation match
2015-12-18 10:04:30 +01:00
9fe3d2f1f8
OC_Helper::linkToRoute is deprecated
...
Replaced all calls to OC_Helper::linkToRoute with
OC::$server->getURLGenerator()->linkToRoute
2015-12-17 18:46:42 +01:00
e3ed42135d
Merge pull request #21240 from owncloud/avatar_speedup
...
Avatar speedup
2015-12-17 14:43:21 +01:00
19eeb23b91
OC_Helper::linkTo is deprecated
...
Replaced with suggested (and calling body of)
2015-12-17 10:53:21 +01:00
d796c43841
[Avatars] Add function to get the Node of the avatar
...
Since we usually just get the avatar and stream the content to the users
there is no need to first create an image in memory.
2015-12-16 20:29:02 +01:00
6317ba8cb4
Merge pull request #21135 from owncloud/add-polyfill
...
Add polyfills for PHP55, PHP56 and PHP70 functionalities
2015-12-11 11:40:51 +01:00
f3360d51c6
Use PHP polyfills
2015-12-11 08:47:36 +01:00
4569d88879
IMemcacheTTL was backported to 8.2.2
...
see #21113
2015-12-10 19:00:07 +01:00
744ef6141b
Merge pull request #21073 from owncloud/memcache-lock-ttl
...
Add ttl for redis based locking
2015-12-10 13:51:01 +01:00
e41f7b005d
add since
2015-12-09 14:45:08 +01:00
0a80bf5573
Add interface for memcache backends that support setting ttl on exisiting keys
2015-12-09 14:39:12 +01:00
249dc4490f
improve PHP doc and remove superflous by reference indicator
2015-12-09 14:34:23 +01:00
dec1f1d24a
anounce CommentsManager getter in public server interface
2015-12-09 14:34:23 +01:00
f9081303b1
fix phpdoc
2015-12-09 14:34:23 +01:00
b44a33f68f
fix php doc
2015-12-09 14:34:23 +01:00
2ce2de0ae5
add icommentsmanger and icomment implementation
...
register CommentsManager service, allow override, document in config.sample.php
don't insert autoincrement ids in tests, because of dislikes from oracle and pgsql
specify timezone in null date
only accepts strings for ID parameter that can be converted to int
replace forgotten hardcoded IDs in tests
react on deleted users
react on file deletion
Postgresql compatibility
lastInsertId needs *PREFIX* with the table name
do not listen for file deletion, because it is not reliable (trashbin, external storages)
add runtime cache for comments
2015-12-09 14:34:23 +01:00
45fe8271ab
Merge pull request #21030 from owncloud/querybuilder-new-features
...
Querybuilder new features
2015-12-08 13:51:45 +01:00
85409b6701
Merge pull request #20786 from owncloud/systemtags-dav
...
DAV endpoint for system tags
2015-12-08 13:51:25 +01:00
9f98849306
Add a method to the get "to use" table and column name
2015-12-08 11:04:28 +01:00
a3391248e4
Add select distinct to the query builder
2015-12-08 09:49:21 +01:00
f2c7acb3c0
Allow getting the last insert id without much hassle
2015-12-08 09:40:20 +01:00
4b293dffe5
Use \OCP\Util::sanitizeHTML instead of \OC_Util::sanitizeHTML
2015-12-08 08:56:47 +01:00
316b907a13
Fixed system tags DAV and API and docs
2015-12-04 17:30:50 +01:00
e6d4496fc2
Remove unused setActiveNavigationEntry of OC_App - it's also in OCP\App
2015-12-04 17:23:51 +01:00
2ceae43989
Merge pull request #20545 from owncloud/scan-storage-in-background-job
...
Move files/ajax/scan.php to background job
2015-12-03 16:53:46 +01:00
9dd11091d4
Fix code from comments
2015-12-03 10:00:11 +01:00
98f5c50aa4
Migrate storate status code to storagenotavailablexception
2015-12-03 09:59:45 +01:00
4ead2bc861
Fix code from PR comments
2015-12-03 09:58:55 +01:00
7cd13f462a
Add new external storage exceptions for different errors
2015-12-03 09:57:59 +01:00
e7239b6553
Merge pull request #20872 from owncloud/systemtags-better-not-found-exception
...
Systemtags better not found exception
2015-12-03 09:26:05 +01:00
dcc7ff09ba
Adding unit test for MailNotifications::sendInternalShareMail()
2015-12-02 21:42:14 +01:00
df5872ec50
Merge pull request #20719 from owncloud/adding-system-addressbook-of-users
...
Adding system addressbook for users of this instance - a occ command …
2015-12-02 16:17:58 +01:00
baecfc4080
Reduce OC_Config usage in lib/
...
* replaced by proper public interfaces
2015-12-02 14:49:40 +01:00
6abc02cb88
Proposal: add enumeration function to IUserManager which simply calls a callbask for each user in all backends
2015-12-02 09:14:41 +01:00
df6fc6cc70
Add the user's cloud id to the vCard
2015-12-02 09:14:41 +01:00
dad6470baa
Add IUser::getAvatarImage() for easy access
2015-12-02 09:14:41 +01:00
1d0c041ac8
Add a method to get the list of tags from the TagNotFound Exception
2015-12-01 14:54:34 +01:00
1761fdd9ee
Fix the docs of the exceptions and remove hardcoded language from the message
2015-12-01 12:32:50 +01:00
08248f66ba
Merge pull request #20650 from owncloud/systemtags-core
...
Implement systemtag managers and mapper
2015-11-30 15:38:43 +01:00
391bc49dab
Move files/ajax/scan.php to background job
...
The background job will now be executed in chunks of 500 users all 10 minutes.
2015-11-28 13:06:53 +01:00
b666367a79
Added system tags data structure and PHP side managers
...
Added SystemTagManager and SystemTagObjectMapper
2015-11-27 17:54:29 +01:00
80c43ffc6c
Merge pull request #20702 from owncloud/move-user-principal-into-subfolder
...
Users are available under it's own principal resource named 'principa…
2015-11-26 16:49:49 +01:00
19d5059109
Merge pull request #20393 from owncloud/querybuilder-select-with-alias
...
Add a method to select a field or value with alias
2015-11-26 16:19:20 +01:00
4d22c75d49
Merge pull request #20562 from owncloud/comments-interfaces
...
public interfaces for Comments
2015-11-26 15:06:35 +01:00
3882cc8ef3
Merge pull request #20744 from owncloud/oc_helper-getMimeType-cleanup
...
Remove last occurences of OC_Helper::getMimeType()
2015-11-26 12:37:25 +01:00
d660c6162f
proper description for IllegalIDChangeException
2015-11-26 12:15:00 +01:00
4fcab98694
Remove unused internal methods
...
* removes OC_Helper::mb_substr_replace and OC_Helper::mb_str_replace
* keeps public interface wrapper working as expected
2015-11-26 10:25:43 +01:00
Roeland Jago Douma
Robin Appelman
Joas Schilling
Roeland Jago Douma
Arthur Schiwon
Lukas Reschke
root
Morris Jobke
root
Robin Appelman
Roeland Jago Douma
Vincent Petry
Thomas Müller
Joas Schilling
Lukas Reschke
Piotr Filiciak
Christoph Wurst
Jörn Friedrich Dreyer
Thomas Müller
Stefan Weil
Joas Schilling
Bernhard Posselt
Bjoern Schiessle
Scrutinizer Auto-Fixer
v1r0x
Björn Schießle
C. Montero Luque
Arthur Schiwon
Robin McCorkell
Jesús Macias