bc56fef619
Merge pull request #13932 from owncloud/revert-sabredav-etag-master
...
Revert "adding OC-ETag header"
2015-02-06 12:05:32 +01:00
4d91fa4c93
Normalize before processing
2015-02-06 15:03:29 +01:00
bd60abbefc
[tx-robot] updated from transifex
2015-02-06 01:57:07 -05:00
8210200770
Revert "adding OC-ETag header"
...
This reverts commit 96a931929e
2015-02-05 20:43:37 +01:00
1448f281b7
for password protected link shares the password is stored in shareWith, so we need to set this manually to null for the hooks
2015-02-05 17:23:59 +01:00
b89ddcfe41
fix license email
2015-02-05 14:09:01 +01:00
fdc64e370c
add a controller and reponse for ocs
2015-02-05 14:02:17 +01:00
adf9a4e4eb
Dont bother updating the cache when working with part files
2015-02-05 13:59:50 +01:00
842d0e227c
Dont update the cache after fopen
2015-02-05 13:47:32 +01:00
4a9c64e96b
Only make sure the cache directory exists when we use it
2015-02-04 16:52:50 +01:00
486f49ed72
Merge pull request #13881 from owncloud/upload_to_root_of_mountpoint
...
detect root of mountpoint also if the trailing slash is missed
2015-02-04 14:44:02 +01:00
21c45925fe
detect root of mountpoint also if the trailing slash is missed
2015-02-04 12:47:04 +01:00
77e9c212ed
[tx-robot] updated from transifex
2015-02-04 01:55:49 -05:00
4df7c0a1ed
drop OC\Preferences
2015-02-04 00:31:09 +01:00
909a53e087
drop OC_Preferences
2015-02-04 00:06:29 +01:00
b168c191bc
Revert "enabled disabled files app in repair step"
...
This reverts commit d70160c607
2015-02-03 17:06:57 +01:00
23c6a0cf99
Merge pull request #13843 from owncloud/fix-files-disabled
...
Fix disabled files app
2015-02-03 16:13:15 +01:00
6f118d7f8d
clear app version cache on upgrade
2015-02-03 15:23:51 +01:00
c644ed89a7
Add a better way to check if an avatar exists for the user
2015-02-03 14:54:06 +01:00
70fd3a267f
Cache app versions
2015-02-03 14:13:44 +01:00
d70160c607
enabled disabled files app in repair step
2015-02-03 14:03:43 +01:00
9e222ec841
Merge pull request #13791 from owncloud/extstorage-fixdavexceptions
...
Fix DAV exceptions, some will still return false now
2015-02-03 13:31:32 +01:00
86935fab17
readd is_file
2015-02-03 10:13:25 +01:00
6aef13fb07
[tx-robot] updated from transifex
2015-02-03 01:54:50 -05:00
a7eedf0149
Disallow disabling of files app
2015-02-03 00:39:01 +01:00
ded8cc47cf
🐫 case
2015-02-02 23:47:59 +01:00
2d8f57a1ea
check if cache files are readable
2015-02-02 23:19:54 +01:00
2bd1c17345
Don't encode url unecessary twice
...
The URL was previously encoded twice which leads to getting redirected to a 404 page when the password has been entered incorrect at least once.
Testplan:
- [ ] Opening `http://localhost/core/index.php?redirect_url=%2Fcore%2Findex.php%2Fsettings%2Fadmin ` redirects to the admin page when providing the correct credentials
- [ ] Opening `http://localhost/core/index.php?redirect_url=%2Fcore%2Findex.php%2Fsettings%2Fadmin ` redirects to the admin page when providing the invalid credentials and then providing valid ones.
- [ ] Logging in as admin then going to the admin page and clearing the cookies and refreshing will show the login and when repeating the above test steps you're redirected correctly.
Fixes https://github.com/owncloud/core/issues/9804
2015-02-02 15:09:59 +01:00
92bc1b44d5
Merge pull request #13822 from owncloud/include-core-version-in-js-version-tag
...
include core version into js/css version tag
2015-02-02 15:02:11 +01:00
a575dcf78f
Use insertIfNotExists() and reload mimetypes after inserting one
2015-02-02 13:20:16 +01:00
24daee836a
include core version into js/css version tag - fixes #13702
2015-02-02 13:02:11 +01:00
1bb8d5978c
Merge pull request #13817 from owncloud/core-apps-dependencies
...
encryption requires openssl and user_ldap requires ldap 🙊
2015-02-02 12:49:45 +01:00
82b271855c
add libs which have no version number
2015-02-02 10:49:46 +01:00
800829d93d
[tx-robot] updated from transifex
2015-02-02 01:54:32 -05:00
a3067b3b9f
[tx-robot] updated from transifex
2015-02-01 01:54:33 -05:00
573aa196d4
Properly show the warning about the missing composer autoloader
2015-01-31 20:48:58 +01:00
c877fbdac8
[tx-robot] updated from transifex
2015-01-31 01:54:39 -05:00
e7900ba255
Merge pull request #13508 from owncloud/failed-delete-cache
...
Dont remove a file from cache if the delete operation failed
2015-01-30 14:08:44 +01:00
5ade2854ee
Fix DAV exceptions, some will still return false now
...
Since the Storage interface isn't ready to work directly with exceptions
like Forbidden and NotFound, the DAV storage has been adapted to still
return false when expected.
2015-01-30 12:02:23 +01:00
f4d20dc1f3
[tx-robot] updated from transifex
2015-01-30 01:55:06 -05:00
790622e9fd
Merge pull request #13772 from owncloud/closecursor-allconfig
...
Close cursor after checking for existing config values
2015-01-29 19:31:21 +01:00
37e8969d34
ignore cursorclosing
2015-01-29 19:16:28 +01:00
b1d8d88df8
Merge pull request #13760 from owncloud/create_enc_key_for_remote_shares
...
make sure that we always create a public share key for remote shares
2015-01-29 17:54:04 +01:00
ce0aa02aac
Dont do a cache rename if we cant delete the source file
2015-01-29 15:52:40 +01:00
2124540d1d
Dont remove a file from cache if the delete operation failed
2015-01-29 15:39:56 +01:00
65ec950b27
Merge pull request #13757 from owncloud/issue/13686-scroll-to-file-when-using-searchotherplaces
...
Scroll to file in folder, when using "search in other places" link
2015-01-29 15:36:25 +01:00
2c1bacadca
Merge pull request #13762 from owncloud/ignore_trailing_slash
...
ignore trailing slash for remote URL
2015-01-29 15:00:44 +01:00
acf0582029
Merge pull request #13752 from owncloud/closecursor1
...
Close cursor early in calculateFolderSize
2015-01-29 14:23:16 +01:00
c78e3c4a7f
make sure that we always create a public share key for remote shares
2015-01-29 14:23:14 +01:00
82de50d5b9
remove trailing slash
2015-01-29 14:03:09 +01:00
05035ef4af
Fix webdav put for single file webdav shares
2015-01-29 12:47:12 +01:00
ddee63fa00
Fix resolving paths for views rooted in a file
2015-01-29 12:47:11 +01:00
54303484eb
Scroll to file in folder, when using "search in other places" link
2015-01-29 12:21:20 +01:00
41382ef7fc
Merge pull request #13667 from owncloud/rename-always-update-cache
...
Update the cache when renaming even if we dont emit hooks
2015-01-28 17:15:11 +01:00
21e3cd38ae
Write the parameter 'logtimezone' into config.php during setup
2015-01-28 13:45:13 +01:00
8c9f1a982c
Update the cache when renaming even if we dont emit hooks
2015-01-28 13:44:39 +01:00
20199dd168
Reference module with `.c`
...
Fixes https://github.com/owncloud/core/issues/13657
2015-01-28 13:15:32 +01:00
55142186de
[tx-robot] updated from transifex
2015-01-28 01:55:53 -05:00
1efb1fee11
Merge pull request #13700 from owncloud/dav-objecttree-required-a-collection
...
let init() take a ICollection or an INode - fixes PHP message
2015-01-28 01:14:47 +01:00
752b94d363
Merge pull request #13717 from owncloud/storage-donotwrapnullstorage
...
Prevent wrapping null storage
2015-01-28 01:00:20 +01:00
87b39e8f03
Merge pull request #13525 from owncloud/s2s-fixscanfileforbrokenstorage
...
Catch storage exception in scanner for remote shares
2015-01-28 00:31:37 +01:00
6d8985b671
Prevent wrapping null storage
...
Can happen when trying to instantiate external storages that have
incomplete config, where the constructor throws an exception (the
exception is caught in createStorage())
2015-01-27 17:40:08 +01:00
3fa6e0f4dc
Merge pull request #13718 from owncloud/use-proper-namespace
...
Use proper namespace
2015-01-27 17:39:35 +01:00
bedf358b40
Use proper namespace
...
IAppManager lives in OCP\App and not in OCP.
Fixes https://github.com/owncloud/core/issues/13710
2015-01-27 17:34:25 +01:00
acec40fe5a
Merge pull request #13561 from owncloud/trash-finaldeletewhencrossstoragefix
...
Call final unlink in trash wrapper's storage
2015-01-27 17:05:38 +01:00
12867b9c78
Fix return type of addStorageWrapper in PHPDoc
2015-01-27 16:41:43 +01:00
4d90fd933f
Merge pull request #13699 from owncloud/check-if-file-exists
...
Use `file_exists` to verify that config file exists
2015-01-27 14:16:40 +01:00
9771ead7dd
Merge pull request #13701 from owncloud/disable-appcode-checker
...
disable the app code checker - some previous shipped apps cannot be inst...
2015-01-27 11:53:03 +01:00
b7cf4d551e
let init() take an INode - fixes PHP message
2015-01-27 11:31:37 +01:00
956de27e94
Merge pull request #13676 from owncloud/fix-node-iface
...
Fix node interface
2015-01-27 09:34:59 +01:00
9a75304b02
disable the app code checker - some previous shipped apps cannot be installed from the appstore now 👊
2015-01-27 09:27:38 +01:00
f248ee013b
Merge pull request #13694 from owncloud/little-bit-more-descriptive-htaccess-error
...
Make error more descriptive
2015-01-27 09:15:57 +01:00
c8f58054b0
[tx-robot] updated from transifex
2015-01-27 01:54:34 -05:00
17f2cfbb9c
Use `file_exists` to verify that config file exists
...
There might be the case that `fopen($file, 'r')` returns false and thus ownCloud might believe that the config file is empty and thus potentially leading to an overwrite of the config file.
This changeset introduces `file_exists` again which was used in ownCloud 5 where no such problems where reported and should not be affected by such problems.
Ref https://github.com/owncloud/core/issues/12785#issuecomment-71548720
2015-01-27 00:50:14 +01:00
d8559dc78f
Make error more descriptive
...
Ref https://github.com/owncloud/core/issues/13693#issuecomment-71546767
2015-01-26 23:00:15 +01:00
5ba19ba7fc
certificate manager should always use a \OC\Files\View otherwise we will get problems for different primary storages
2015-01-26 16:58:52 +01:00
67da1f7e5a
certificate manager only needs the user-id, no need to pass on the complete user object
2015-01-26 16:58:52 +01:00
b8769802df
fix node interface
2015-01-26 15:58:41 +01:00
87ce64c24e
Replace OC_Log::ERROR with OCP\Util::ERROR
2015-01-26 15:51:31 +01:00
f6e644b43f
Catch storage exception in scanner for remote shares
...
Whenever an exception occurs during scan of a remote share, the share is
checked for availability. If the storage is gone, it will be removed
automatically.
Also, getDirectoryContent() will now skip unavailable storages.
2015-01-26 13:59:49 +01:00
5da4071c45
Merge pull request #13621 from owncloud/system-config-multiset
...
Add a method to set/unset multiple config values with one write
2015-01-26 13:36:22 +01:00
9ad9d7bfbb
naming fixes while reviewing
2015-01-26 12:59:25 +01:00
810d5a6a67
[tx-robot] updated from transifex
2015-01-26 01:54:29 -05:00
a698637e91
[tx-robot] updated from transifex
2015-01-25 01:54:38 -05:00
b8e1dd9c87
[tx-robot] updated from transifex
2015-01-24 01:54:51 -05:00
7fbf1a20d7
Updated the media type of some font types
...
TTF and TTF have now the same media type
Official since 2013 and supported by Firefox and Chrome
https://www.iana.org/assignments/media-types/application/font-sfnt
Introducing support for Type1 fonts
2015-01-24 01:49:13 +01:00
f8b1fde2c0
Merge pull request #13626 from owncloud/check-for-hhvm
...
Don't check for `always_populate_raw_post_data` on HHVM
2015-01-23 10:28:47 -05:00
87a1b2bdc4
Preserve mtime when doing cross storage move
2015-01-23 15:11:27 +01:00
8fa3e7a6bf
Do not retrieve shares through group if user has no group
2015-01-23 15:11:06 +01:00
039397bd31
Use setConfigs() instead of calling setConfig() multiple times
2015-01-23 14:52:21 +01:00
30a5758a95
Don't check for `always_populate_raw_post_data` on HHVM
...
HHVM seems to have problems with this at the moment (even setting those values in the php.ini of HHVM doesn't have helped much) and thus the unit test execution failed.
So it's better if we disable this check for now for HHVM.
2015-01-23 13:54:34 +01:00
960ff4f136
Apply wrappers to existing mounts before registering it
2015-01-23 13:48:35 +01:00
5fb8a4715d
removeStorageWrapper to unregister a storage wrapper
2015-01-23 12:20:54 +01:00
c61e9f3912
Add a method to set/unset multiple config values in one call
...
This reduces the number of file writes we do for config.php and therefor
hopefully helps lowering the chances for empty config.php files
2015-01-23 11:00:53 +01:00
7e4afa3f25
Merge pull request #13593 from owncloud/add-check-for-raw-post-data
...
Add check for `HTTP_RAW_POST_DATA` setting for >= 5.6
2015-01-22 23:59:52 +01:00
254a1fa12a
Merge pull request #13314 from owncloud/login-hook-logout
...
Return false if the login is canceled in a hook
2015-01-22 23:34:19 +01:00
5776bfec05
Merge pull request #13449 from owncloud/image_preview_limit
...
add config-option for an image's maximum filesize when generating previews
2015-01-22 23:02:38 +01:00
3af8bde949
add config-option for an image's maximum filesize when generating previews
2015-01-22 20:21:37 +01:00
6b33481652
remove insane debug-log from OC_Image
2015-01-22 20:17:25 +01:00
8f06bf7bc6
Merge pull request #13598 from owncloud/fix-undefined-offset
...
Fix undefined offset 1 for wrong user mail address
2015-01-22 17:16:23 +01:00
6fb553e92c
Do not call wrapStorage if storate with same name added twice
2015-01-22 16:24:24 +01:00
3d42ecea37
Fix undefined offset 1 for wrong user mail address
...
* fixes Undefined offset: 1 at lib/private/mail.php#143
2015-01-22 16:23:50 +01:00
f4a9164660
Merge pull request #13600 from owncloud/server-warning
...
Get rid of log warning when using servercontainer
2015-01-22 16:03:54 +01:00
9df297324f
get rid of log warning when using servercontainer
2015-01-22 15:33:09 +01:00
55c28608c9
translate error messages
2015-01-22 14:52:47 +01:00
8eda661761
Throw an exception when login is canceled by an app
2015-01-22 14:13:17 +01:00
8a9acc5083
Allow custom error messages for the login page
2015-01-22 14:13:02 +01:00
bb80cf4eca
Add check for `HTTP_RAW_POST_DATA` setting for >= 5.6
...
PHP 5.6 otherwise throws notices for perfectly valid code which results in broken endpoints.
Fixes https://github.com/owncloud/core/issues/13592
2015-01-22 13:50:38 +01:00
b5b491d1bb
Merge pull request #13509 from owncloud/share-deletechildrenwhenunsharefromgroup
...
Fix reshare permission change to not impair other deletion code
2015-01-22 10:40:29 +01:00
9f137ac259
Fix reshare permission change to not impair other deletion code
...
A recent change that prevents reshare permission changes to delete group
share children had the side-effect of also preventing group share
children deletion when it needed to be done.
This fix adds an extra flag to isolate the "reshare permission change"
deletion case and keep the other ones as they were before, not only to
fix the regression but also fix other potential regressions in code that
uses this method.
Also updated the comment because now Helper::delete() is no longer
limited to reshares but also applies to group share children.
2015-01-22 10:12:47 +01:00
c13bf8d820
Merge pull request #13552 from owncloud/request-uri-double-slash
...
Remove duplicated slashes from the requested url
2015-01-21 21:56:09 +01:00
d4657aa592
Set the debugoutput channel to error_log instead of echoing it
2015-01-21 15:32:31 +01:00
04075eba6b
Remove duplicated slashes from the requested url
2015-01-21 15:04:18 +01:00
b8ab21d3ad
[tx-robot] updated from transifex
2015-01-21 01:55:15 -05:00
84bb4cc2e9
Merge pull request #13499 from owncloud/issue/13451-redis-json-encode
...
Issue/13451 redis json encode
2015-01-20 14:53:33 +01:00
e25998df0f
Json_(en|de)code values on redis to be able to cache arrays
2015-01-20 10:51:27 +01:00
476579b9c6
Fix WebDAV auth for session authentication only
...
\Sabre\DAV\Auth\Backend\AbstractBasic::authenticate was only calling \OC_Connector_Sabre_Auth::validateUserPass when the response of \Sabre\HTTP\BasicAuth::getUserPass was not null.
However, there is a case where the value can be null and the user could be authenticated anyways: The authentication via ownCloud web-interface and then accessing WebDAV resources. This was not possible anymore with this patch because it never reached the code path in this scenario.
This patchs allows authenticating with a session without isDavAuthenticated value stored (this is for ugly WebDAV clients that send the cookie in any case) and thus the functionality should work again.
To test this go to the admin settings and test if the WebDAV check works fine. Furthermore all the usual stuff (WebDAV / Shibboleth / etc...) needs testing as well.
2015-01-20 10:03:14 +01:00
2ac015256f
[tx-robot] updated from transifex
2015-01-20 01:54:37 -05:00
870bc429b2
Merge pull request #13416 from owncloud/reauthenticate-if-session-differs-from-basic-auth
...
Prioritise Basic Auth header over Cookie
2015-01-19 22:23:02 +01:00
cbffaff7a0
Merge pull request #13480 from owncloud/mysql-autocommit
...
set MySQL autocommit on connection setup
2015-01-19 19:39:26 +01:00
baefefbbc8
set MySQL autocommit on connection setup
2015-01-19 17:20:49 +01:00
ef8d38ca27
Fix chunked query for tags + unit test
2015-01-19 17:05:44 +01:00
730460c9fa
Close session properly
2015-01-19 16:25:44 +01:00
65041440de
check is mimetype is set - fixed #13452
2015-01-19 15:04:53 +01:00
a28d3b594b
Fix exif orientation for flipped images
...
fixes #13363
Links:
* http://www.daveperrett.com/articles/2012/07/28/exif-orientation-handling-is-a-ghetto/
* Example data: https://github.com/recurser/exif-orientation-examples
2015-01-18 23:15:52 +01:00
d2d6472e39
Merge pull request #13423 from owncloud/share-fixfindshareforuserwithmultiplegroups
...
Fix getItemSharedWithUser for groups
2015-01-19 12:34:28 +01:00
4fcfedb03c
Merge pull request #13438 from owncloud/cache-the-array
...
Reuse the array key of mimetypes
2015-01-19 08:40:25 +01:00
309cc9a6ca
Reuse the array key of mimetypes
...
This function is called a lot of times and was really slow before due to not reusing the same array.
Previously when it was called 500'000 times it took about 2seconds, now we're down to 0.2 seconds on my local machine.
Ref https://github.com/owncloud/core/issues/13434
2015-01-18 14:50:34 +01:00
dfbc405a45
Prioritise Basic Auth header over Cookie
...
There are a lot of clients that support multiple WebDAV accounts in the same application. However, they resent all the cookies they received from one of the accounts also to the other one. In the case of ownCloud this means that we will always show the user from the session and not the user that is specified in the basic authentication header.
This patch adds a workaround the following way:
1. If the user authenticates via the Sabre Auth Connector add a hint to the session that this was authorized via Basic Auth (this is to prevent logout CSRF)
2. If the request contains this hint and the username specified in the basic auth header differs from the one in the session relogin the user using basic auth
Fixes https://github.com/owncloud/core/issues/11400 and https://github.com/owncloud/core/issues/13245 and probably some other issues as well.
This requires proper testing also considering LDAP / Shibboleth and whatever instances.
2015-01-17 13:29:07 +01:00
60c4cb1dd6
[tx-robot] updated from transifex
2015-01-17 01:54:40 -05:00
744cf713f7
Merge pull request #13319 from owncloud/replace-line-breaks-in-app-description
...
replace line breaks in the app description by spaces - fixes #13315
2015-01-17 01:03:41 +01:00
2b99fc76ec
Cleanup of PHPDoc return types
2015-01-16 20:30:43 +00:00
40931a8b0d
Fix getItemSharedWithUser for groups
...
Fixed SQL query for whenever a user has more than one group.
Added missing $owner where clause for group lookup.
Added unit tests for the group cases.
2015-01-16 18:11:13 +01:00
0f0204ee35
Merge pull request #13160 from owncloud/extstorage-ocbackendnopartfile
...
Disable part files for OC ext storage backend + s2s backend
2015-01-16 13:38:59 +01:00
696d9dc98e
Merge pull request #13406 from owncloud/fix-php-doc
...
Fix PHPDoc
2015-01-15 20:35:30 -05:00
a1e92d61b3
Fix PHPDoc
2015-01-15 22:50:42 +01:00
051f626617
Merge pull request #13389 from owncloud/issue/13372-failing-oracle-tests-jenkins
...
Mask table and column names with backticks and add lastInsertID() workar...
2015-01-15 22:41:57 +01:00
2248e465af
Remove children from the cache in one query
2015-01-15 17:26:12 +01:00
36ced1f002
Merge pull request #13388 from owncloud/type-hint-url-params
...
Add PHPDoc for `urlParams`
2015-01-15 16:00:48 +01:00
bb0c88a577
always set url parameters when they are available in the app dispatch
...
prefer url parameters passed into the main method. If they are not present, use the containers urlParameters
add space
2015-01-15 15:22:52 +01:00
6769adcd0d
Mask table and column names with backticks and add lastInsertID() workaround
2015-01-15 14:43:06 +01:00
0da08bdb2c
Add PHPDoc for `urlParams`
2015-01-15 14:42:44 +01:00
337c43ce92
Merge pull request #13317 from owncloud/partfile-fileinfo
...
Return valid fileinfo objects for part files
2015-01-14 22:39:19 +01:00
64d7463ca3
Merge pull request #13344 from owncloud/issue/13334-cleanup-tags-repairstep
...
Add a repair step to clean up orphan tags and tag entries
2015-01-14 20:43:23 +01:00
34d6a1596c
Merge pull request #13367 from owncloud/type-hint-server-method-from-request
...
Add PHPDoc for magic property 'server'
2015-01-14 20:23:52 +01:00
04ae8d2ea0
Add PHPDoc for magic property 'server'
2015-01-14 19:36:22 +01:00
455ad005a0
Merge pull request #13350 from owncloud/autoload-translations
...
Autoload app's js translations
2015-01-14 18:12:05 +01:00
a22068cce3
Add a repair step to clean up orphan tags and tag entries
2015-01-14 16:49:25 +01:00
6737dd111d
ignore core
2015-01-14 15:27:37 +01:00
4ec4914bb4
move check into addTranslation method
2015-01-14 14:57:56 +01:00
1cce1f0e6b
dont load core scritps
2015-01-14 14:43:11 +01:00
520d8ec53b
OC_App::parseAppInfo
...
* replace line breaks (on non empty lines) in the app description by spaces
* fixes #13315
* includes unit tests
2015-01-14 13:58:31 +01:00
d6f1ff7993
only load translsations for apps
2015-01-14 13:48:21 +01:00
8cb60b2366
make translation lookup faster (O(n) -> O(1))
2015-01-14 13:39:29 +01:00
717e3acd9b
autoload app's js translations
2015-01-14 13:34:52 +01:00
4b3a3dc0bb
Check new and old ways of required oC version for app compatibility
2015-01-14 13:02:02 +01:00
5745b68fa9
Merge pull request #13311 from owncloud/fix_restore_keys
...
adapt decrypt all to the new folder structure
2015-01-14 11:40:22 +01:00
a2e355a7fe
Use "HTTPOnly" for cookies when logging out
...
This has no other reason than preventing some insane automated scanners from reporting this as security bug (which it obviously isn't as the cookie contains nothing of value)
Thus it generally results in an happier Lukas and hopefully less reports to our support and security mail addresses...
2015-01-14 11:20:53 +01:00
f367bbb49d
[tx-robot] updated from transifex
2015-01-14 01:55:16 -05:00
c8fa85451c
Merge pull request #13320 from owncloud/fix-php-doc-for-files-view
...
Fix annotations in file view
2015-01-13 18:05:00 +01:00
0a400b4577
drop unused parameter
2015-01-13 18:04:20 +01:00
d66facc762
Fix annotations in file view
2015-01-13 14:53:00 +01:00
96dff341e2
Return valid fileinfo objects for part files
2015-01-13 13:59:28 +01:00
7746ac519f
drop dead code - ref #13301
2015-01-13 13:52:25 +01:00
ba8c050d2b
Merge pull request #13217 from owncloud/make-basic-auth-work-again
...
Fix Basic Auth in master for applications
2015-01-13 13:35:54 +01:00
543fa0d45b
Merge pull request #13291 from owncloud/node-searchcommonbasepathfix
...
Fix searchCommon to properly match path name
2015-01-13 13:25:51 +01:00
857695ec87
Return false if the login is canceled in a hook
2015-01-13 13:25:20 +01:00
89f17ef6fe
adapt decrypt all and restore/delete key backups to the new folder structure for encryption key introduced with OC8
2015-01-13 12:45:33 +01:00
a2a7a60293
Merge pull request #13301 from owncloud/drop-etag-message
...
drop useless "!!! No reuse of etag" - fixes #13187
2015-01-13 12:24:24 +01:00
79804166f1
Merge pull request #13305 from owncloud/remove-stray-minus-and-use-json-encode
...
Use json_encode on string
2015-01-13 10:39:14 +00:00
f0ac8a278a
Use json_encode on string
...
It's better to encode the string to prevent possible (yet unknown) bugs in combination with PHP's type juggling.
Previously the boolean statements evaluated to either an empty string (false) or a not empty one (true, then it was 1). Not it always evaluates to false or true.
This also removes a stray - that was not intended there but shouldn't have produced any bugs. Just to increase readability.
Thanks @nickvergessen for spotting.
Addresses https://github.com/owncloud/core/pull/13235/files#r22852319
2015-01-13 11:08:18 +01:00
dc86cbd1e2
Merge pull request #13271 from owncloud/fix-table-prefix-oracle-master
...
Use a special filter expression for Oracle to filter the prefix - fixes ...
2015-01-13 10:31:04 +01:00
9b49b52fc6
drop useless "!!! No reuse of etag" - fixes #13187
2015-01-13 09:54:48 +01:00
7966eee007
Adding repair step to fix missing etags - fixes #12172
2015-01-12 20:20:19 +01:00
fcc3b3d5f7
Fix searchCommon to properly match path name
...
The internal path was matched without the last "/" which caused
"files_trashbin" to also match when the internal path was "files".
This adds the missing slash for the comparison.
2015-01-12 19:33:00 +01:00
1d2bef0a01
Use a special filter expression for Oracle to filter the prefix - fixes #13220
2015-01-12 16:28:11 +01:00
9e550ab844
[tx-robot] updated from transifex
2015-01-12 01:55:52 -05:00
3425c73815
[tx-robot] updated from transifex
2015-01-11 01:54:32 -05:00
c91d47e5b3
Merge pull request #13224 from owncloud/simplify-is-valid-path-and-add-unit-tests
...
Simplify isValidPath and add unit tests
2015-01-10 17:35:40 +01:00
c259733b88
Merge pull request #13223 from owncloud/optimize-normalize-unicode
...
Verify whether value is already normalized
2015-01-10 16:33:54 +01:00
8057bc6646
Merge pull request #13236 from owncloud/use-isset-for-performance
...
Use isset() instead of strlen()
2015-01-10 16:32:50 +01:00
e80ece9a2b
Verify whether value is already normalized
...
Apparently `normalizer_normalize` is not verifying itself whether the string needs to be converted or not. Or does it at least not very performantly.
This simple change leads to a 4% performance gain on the processing of normalizeUnicode. Since this method is called quite often (i.e. for every file path) this has actually a measurable impact. For examples searches are now 200ms faster on my machine. Still not perfect but way to go.
Part of https://github.com/owncloud/core/issues/13221
2015-01-10 12:12:40 +01:00
310424db5d
Use isset() instead of strlen()
...
Isset is a native language construct and thus A LOT faster than using strlen()
On my local machine this leads to a 1s performance gain for about 1 million paths. Considering that this function will be called a lot for every file operation this makes a noticable difference.
2015-01-10 12:06:51 +01:00
7e11ca06f6
Cache results of `normalizePath`
...
`normalizePath` is a rather expensive operation and called multiple times for a single path for every file related operation.
In my development installation with about 9GB of data and 60k files this leads to a performance boost of 24% - in seconds that are 1.86s (!) - for simple searches. With more files the impact will be even more noticeable. Obviously this affects every operation that has in any regard something to do with using OC\Files\Filesystem.
Part of https://github.com/owncloud/core/issues/13221
2015-01-10 11:10:38 +01:00
ae3483299c
Merge pull request #13212 from owncloud/cache-appstore-response
...
Cache responses from the AppStore server
2015-01-10 09:56:00 +01:00
22e5220c1f
[tx-robot] updated from transifex
2015-01-10 01:54:35 -05:00
05615bfd47
Simplify isValidPath and add unit tests
...
The check for invalid paths is actually over-complicated and performed twice resulting in a performance penalty. Additionally, I decided to add unit-tests to that function.
Part of https://github.com/owncloud/core/issues/13221
2015-01-10 00:40:21 +01:00
5f31207e84
Add some more sanity checks for maintenance mode
2015-01-09 21:52:16 +01:00
1c75b73239
Verify authentication before initializing apps and routing
...
The current behaviour of the authenticion logic in base.php prevents REST APIs in ownCloud applications to work.
Because `!self::$CLI` is usually always a true statement the previously above block was entered which returned, thus the authentication logic for this part does not trigger in.
This can be reproduced by installing apps such as the News app and issuing the following command:
`curl -u admin:admin http://localhost/index.php/apps/news/api/v1-2/feeds `
The following parts needs to get throughly tested:
- [ ] OCS
- [ ] remote.php's DAV features
- [ ] Regular login features
This bug affects master and stable7. I'd propose that we merge this for 8.0 since this has the potential to break every component that relies on Basic Auth features. A backport would also be very nice.
Remark to myself: We really need to move out the authentication code for 8.1 out of base.php - I already have a local branch that does that somewhere which I will get in shape for 8.1... - This untested code is a night-mare.
Fixes itself.
2015-01-09 21:07:29 +01:00
b8b4df5425
Cache responses from the AppStore server
...
Otherwise every time the AppStore was opened a lot of connections to the AppStore server were made which resulted in a terrible performance.
This changeset will cache the response for a sensible time so that only the first request will be somewhat slow.
Performance changes:
- Loading a category took previously more than 3 seconds on my machine. Now for every follow-up request it takes less than 200ms, resulting in a performance gain of 1950%
- Loading the category list took previously about 750ms - now it takes 154ms, a total performance gain of 395%
2015-01-09 19:49:59 +01:00
d4355cafc6
Merge pull request #13192 from owncloud/cache_binary_path
...
Use memcache for findBinaryPath
2015-01-09 17:46:36 +01:00
631d6571fd
Merge pull request #13181 from owncloud/filecache-preventleadingslash
...
Trim leading or trailing slashes in file cache paths
2015-01-09 13:54:17 +00:00
800738f51a
Merge pull request #12011 from owncloud/reuse-etag-default
...
Default to reusing etags in the scanner
2015-01-09 14:38:45 +01:00
c291383116
Memcache binary executable searching
...
It's slow, this makes it fast!
2015-01-09 13:18:00 +00:00
17dd5d0816
Add Null memcacher
2015-01-09 13:18:00 +00:00
1f1643b35f
Merge pull request #12995 from owncloud/tbelau666-master
...
Use Doctrines filter by table name
2015-01-09 14:17:14 +01:00
888ce4d4f9
Fix cache jail to not duplicate slashes
2015-01-09 10:18:32 +01:00
d4fc2f555b
[tx-robot] updated from transifex
2015-01-09 01:55:22 -05:00
6c59253978
Merge pull request #13179 from owncloud/fix-fatal-php-error-for-not-existing-files
...
Verify whether type is correct
2015-01-09 02:27:51 +01:00
6a5f12beca
Merge pull request #12988 from owncloud/logfile_download
...
Logfile download
2015-01-09 00:33:22 +01:00
aa821ecc00
Trim leading or trailing slashes in file cache paths
2015-01-08 19:43:02 +01:00
ceaaab6295
Verify whether type is correct
...
`$this->info` can very well contain an empty array or possibly other values. This means that when this code path is called a PHP Fatal error might get thrown which is not what we want.
2015-01-08 18:38:17 +01:00
7fbb7f4dc4
Add version to .htaccess
...
Currently if a user does not replace the .htaccess file with the new update this can lead to serious problems in case Apache is used as webserver.
This commit adds the version to the .htaccess file and the update routine fails in case not the newest version is specified in there. This obviously means that every release has to update the version specified in .htaccess as well. But I see no better solution for it.
Conflicts:
lib/private/updater.php
2015-01-08 12:49:02 +01:00
5f171618fd
remove unused variable and fix undefined variable
2015-01-08 09:46:40 +01:00
296a852063
check for working htaccess will result in a dead lock because the server is blocking the request to itself - fixes #13153
2015-01-08 09:13:18 +01:00
6bda95037f
[tx-robot] updated from transifex
2015-01-08 01:56:00 -05:00
2e57fe93e4
Disable part files for OC ext storage backend + s2s backend
...
When uploading files to an OC ext storage backend or when using server
to server sharing storage, part files aren't needed because the backend
already has its own part files and takes care of the final atomic rename
operation.
This also fixes issues when using two encrypted ownCloud instances where
one mounts the other either as external storage (ownCloud backend) or
through server to server sharing.
2015-01-07 21:21:51 +01:00
bfb6e350d5
Merge pull request #13016 from owncloud/sharing_fixes
...
don't delete share table entries for the unique name if re-share permission was removed
2015-01-07 18:14:53 +01:00
b6f63e9b3d
don't delete share table entries for the unique name if re-share permission was removed
2015-01-07 16:36:13 +01:00
f579f2bd94
add Download logfile button to admin settings
...
add logSettingsController
add download logfile button
move getEntries to LogSettingsController
move set log level to logsettingscontroller.php
add warning if logfile is bigger than 100MB
add unit test for set log level
fix typecasting, add new line at EoF
show log and logfile download only if log_type is set to owncloud
add unit test for getFilenameForDownload
2015-01-07 14:55:53 +01:00
fd57820708
Merge pull request #13132 from aptivate/improve_debug_logging_messages
...
Improve debugging for ServiceUnavailable exceptions
2015-01-07 10:36:27 +01:00
4628e98cfc
Merge pull request #13063 from AdamWill/assets-relocate
...
allow css/js asset directory to be relocated ('assetdirectory')
2015-01-07 09:36:26 +01:00
2daf90dae6
[tx-robot] updated from transifex
2015-01-07 01:55:42 -05:00
a8d82b7091
Merge pull request #13131 from owncloud/db-connect-stacktrace
...
Prevent leaking db connection info in the stacktrace
2015-01-07 01:17:27 +01:00
7528a1a475
Merge pull request #13130 from owncloud/getstoragestats-error-handling
...
Add error handling to getstoragestats.php
2015-01-06 18:35:09 +01:00
402a3ed146
Improve debugging for ServiceUnavailable exceptions
...
I was getting a lot of these in my logs for no apparent reason, and file
uploads were failing:
{"app":"webdav","message":"Sabre\\DAV\\Exception\\ServiceUnavailable: ","level":4,"time":"2015-01-06T15:33:39+00:00"}
In order to debug it, I had to add unique messages to all the places where
this exception was thrown, to identify which one it was, and that made the
logs much more useful:
{"app":"webdav","message":"Sabre\\DAV\\Exception\\ServiceUnavailable: Encryption is disabled","level":4,"time":"2015-01-06T15:36:47+00:00"}
2015-01-06 15:59:38 +00:00
3356308594
Prevent leaking db connection info in the stacktrace
2015-01-06 16:54:41 +01:00
fe4592937a
Merge pull request #12653 from owncloud/full_content_search_results
...
Full content width search results
2015-01-06 16:44:58 +01:00
64e3ebae74
Add error handling to getstoragestats.php
2015-01-06 15:56:06 +01:00
68efeba343
Merge pull request #13125 from owncloud/lower-deprecation-warning-level
...
degraded logging policy for server container in AppFramework
2015-01-06 14:38:50 +01:00
20886d8151
Merge pull request #13116 from owncloud/fix_assets
...
Fix JS asset generation
2015-01-06 14:36:51 +01:00
4ffe7ddb75
degraded logging policy for server container in AppFramework
2015-01-06 13:43:40 +01:00
6a3f69c2d0
[tx-robot] updated from transifex
2015-01-06 01:54:59 -05:00
bb79aac78a
allow css/js asset directory to be relocated ( #13053 )
...
This allows the directory where CSS/JS asset collections are
written to be changed, in case SERVERROOT is not writeable. Note
it does *not* allow the expected URL to be changed: whatever
directory is used, the server must be configured to serve it
at WEBROOT/assets. It may be possible to add another config
parameter to allow the admin to specify a custom asset URL,
but I thought I'd keep the first implementation simple.
2015-01-05 15:24:23 -08:00
c0ad6e818b
Merge pull request #13101 from owncloud/variable-is-undefined-please-use-a-proper-ide-in-the-future-whoever-did-that
...
Fix undefined variable and write unit tests for OC_Principal connector
2015-01-05 20:09:10 +01:00
2c44bc1768
Fix JS asset generation
...
At some point SeparatorFilter should be included upstream
(kriswallsmith/assetic), then lib/private/assetic/separatorfilter.php can be
removed and the `use` in lib/private/templatelayout.php rewritten.
SeparatorFilter inserts a separator between assets, preventing issues when
files are incorrectly terminated. For JS this is a semicolon.
2015-01-05 15:48:04 +00:00
8689605999
Use info instead of warning log level
...
Otherwise the log is flooded as can be seen at https://github.com/owncloud/core/issues/13106
Fixes https://github.com/owncloud/core/issues/13106
2015-01-05 11:18:54 +01:00
0ed00bca43
Use namespace
2015-01-05 09:54:14 +01:00
556c9b6f46
Write unit-tests and use DI
2015-01-05 09:54:12 +01:00
f2ddd565e8
Fix code-style
2015-01-05 09:53:01 +01:00
f2e759b533
Merge pull request #13095 from derkostka/master
...
fix "app":"PHP","message":"Undefined variable: user at/principal.php#66"
2015-01-05 09:47:44 +01:00
8776271103
[tx-robot] updated from transifex
2015-01-05 01:54:36 -05:00
deedfad050
fix "app":"PHP","message":"Undefined variable: user at/principal.php#66"
...
changed variable #user to #name
2015-01-04 17:07:33 +01:00
298eae9c86
Merge pull request #13060 from dratini0/master
...
Fix: X-Accel-Redirect did not support custom data dir and local mounts
2015-01-04 10:09:30 +01:00
84ed1034b4
[tx-robot] updated from transifex
2015-01-04 01:54:53 -05:00
05ffa3ab7a
[tx-robot] updated from transifex
2015-01-03 01:54:29 -05:00
79e790c55d
add SIZE_ALL const
2015-01-02 10:28:42 +01:00
a8edb2124d
fix visibility
2015-01-02 10:28:41 +01:00
606f802b7b
move search results below filelist, show hint when results are off screen, use js plugin mechanism
2015-01-02 10:28:41 +01:00
0e9b05b701
ajax paging, some js cleanups
2015-01-02 10:28:41 +01:00
c738359a11
add paged provider
2015-01-02 10:28:41 +01:00
088323aad5
move code from js.js to search.js in the search app
2015-01-02 10:28:41 +01:00
d3662722f6
new OC.Search, add search result formatters and handlers, use full content width for results
2015-01-02 10:28:41 +01:00
4b357274bb
[tx-robot] updated from transifex
2015-01-02 01:54:28 -05:00
ec6e70889a
[tx-robot] updated from transifex
2015-01-01 01:54:30 -05:00
573be9092d
[tx-robot] updated from transifex
2014-12-31 01:54:33 -05:00
31970ee740
removed a little duplication
2014-12-30 22:36:13 +01:00
f2075f803f
Fix: X-Accel-Redirect did not support custom data dir and local mounts
2014-12-30 22:07:04 +01:00
cd53da43c0
Merge pull request #12854 from owncloud/add-direct-download-link
...
Adding foundation for the direct download url
2014-12-29 18:47:39 +01:00
c8e946f633
[tx-robot] updated from transifex
2014-12-29 01:54:27 -05:00
81243b0f5d
adding getDirectDownload() to Wrapper
2014-12-28 17:17:14 +01:00
5b00bc1d6e
Adding basement for the direct download url
2014-12-28 17:17:14 +01:00
aec79b0c0e
Merge pull request #13043 from owncloud/check-for-hash
...
Check for hash
2014-12-28 14:12:57 +01:00
2711863220
Merge pull request #13035 from owncloud/new_edition_detection
...
Automatically detect the edition based on the enterprise_key app.
2014-12-28 13:36:59 +01:00
222e4a0762
Check for hash
...
See https://github.com/owncloud/core/pull/13042
2014-12-28 13:23:34 +01:00
d2e53d1022
[tx-robot] updated from transifex
2014-12-27 01:54:33 -05:00
0836ce9cd8
[tx-robot] updated from transifex
2014-12-26 01:54:28 -05:00
4a40e5699c
remove Edition
2014-12-25 11:36:41 +01:00
3dea2b95c6
Automatically detect the edition based on the enterprise_key app.
2014-12-25 09:48:15 +01:00
e0fc26a5cb
[tx-robot] updated from transifex
2014-12-25 01:54:29 -05:00
801b9e0494
[tx-robot] updated from transifex
2014-12-24 01:54:33 -05:00
95374e1404
add default for dbtableprefix
2014-12-23 13:32:25 +01:00
f195123765
Intelligent container
...
* resolves dependencies by type hint or variable name
* simpler route.php
* implementation of https://github.com/owncloud/core/issues/12829
Generates and injects parameters automatically. You can now build full classes like
$c->query('MyClassName')
without having to register it as a service. The resolved object's instance will be saved by using registerService. If a constructor parameter is not type hinted, the parameter name will be taken.
Therefore the following two implementations are identical:
class Class1 { function __construct(MyClassName $class)
class Class1 { function __construct($MyClassName)
This makes it possible to also inject primitive values such as strings, arrays etc.
In addition if the query could not be resolved, a `QueryException` is now thrown
Routes can now be returned as an array from `routes.php` and an `appinfo/application.php` is optional
Old commit messages:
make it possible to return the routes instead of having to intialize the application
try to get the controller by convention
add first implementation of automatic resolve
add another test just to be sure
store the resolved object
more tests
add phpdoc to public app.php method
use the same variable for the public app.php method
deprecate old methods and add services for public interfaces
deprecated getServer method
disallow private api injection for apps other than core or settings (settings should be an app goddamnit :D)
register userid because its such an often used variable
fix indention and leading slash
use test namespace
add deprecation reasons, remove private api usage checks and remove deprecation from getServer()
add additional public interfaces
add public interface for rootfolder
fix syntax error
remove deprecation from methods where no alternative is there yet
remove deprecated from method which has no alternative
add timezone public service for #12881
add another deprecation hint
move deprecation into separate branch
remove dead comment
first try to get the namespace from the info.xml, if it does not exist, just uppercase the first letter
also trim the namespace name
add an interface for timefactory
move timefactory to public and add icontrollermethodreflector
keep core interface
fix copyright date in headers
2014-12-23 09:50:42 +01:00
d8f04f5a97
[tx-robot] updated from transifex
2014-12-23 01:55:23 -05:00
dbc465de97
use injected config object and fix typos
2014-12-22 10:55:52 +01:00
de25084def
inject \OCP\IConfig instance in migrator
2014-12-22 10:47:10 +01:00
ad8d55c327
Use Doctrines filter by table name
...
Doctrine's SchemaManager can filter table names by regular expression.
On this way it picks up only ownClouds's tables in a database.
by tbelau666
2014-12-22 10:45:32 +01:00
5d296aa6b1
Merge pull request #12969 from owncloud/clarify-docs
...
Clarify return values
2014-12-22 10:01:39 +01:00
c17b9ec068
Merge pull request #12983 from owncloud/root-iface
...
Add an interface for the root folder so apps have an interface to deal with storage
2014-12-22 09:05:23 +01:00
92c8cd3933
[tx-robot] updated from transifex
2014-12-22 01:54:49 -05:00
8e37214346
add an interface for the root folder so apps have an interface to deal with storage
...
fix comments and newline
add newline
2014-12-21 20:52:34 +01:00
dc12f5d9af
Merge pull request #12978 from owncloud/fix-support-claim
...
Change support message to be more explicit about the enterprise edition
2014-12-21 20:30:43 +01:00
c3544bd27e
Merge pull request #12982 from owncloud/timefac-iface
...
Add an interface for the timefactory class
2014-12-21 20:27:53 +01:00
312891c603
[tx-robot] updated from transifex
2014-12-21 01:54:36 -05:00
ba03b0b843
add an interface for the timefactory class
...
fix indention
2014-12-20 15:53:31 +01:00
5383d83f9e
Change support message to be more explicit about the enterprise edition
2014-12-20 11:57:15 +01:00
5a54ca380d
[tx-robot] updated from transifex
2014-12-20 01:56:24 -05:00
1c22b1f626
Fix Undefined variable: result at tags.php#231
...
Fix app":"PHP","message":"Undefined variable: result at \/var\/www\/owncloud\/lib\/private\/tags.php#231" by moving the function call into the respective loop
Adjust indentation
Do it right - indentation
sorry, this is my first one
2014-12-19 19:44:43 +01:00
8164415b45
Merge pull request #12749 from owncloud/server2server-sharing-ng
...
server to server sharing next generation
2014-12-19 19:04:44 +01:00
ad6814f920
Merge pull request #12101 from owncloud/ldap_split_mapping
...
Ldap split mapping from Access superclass
2014-12-19 18:52:30 +01:00
ec0f80fee9
Split mapping from Access and Helper classes into it's own. Fully test them, too.
...
remove unused methods
split mapping methods off from Access class
fix DB query handling
move 'clear mapping' methods from static helper to new mapping class
add tests
test directly with DB
finishing tests and fix return value from setDNbyUUID
add corresponding class for groups and make abstract test class neutral. helper tests is now obsolete as the tested functions were moved to the new mapper class.
add missing info to PHPDoc
add unmap method
fix namespaces
fix test inheritance
PHPDoc and a small code restructure for scrutinizer, no effective changes
PostgreSQL does not accept LIMIT in DELETE queries
phpdoc fixes, no code changes
2014-12-19 18:26:12 +01:00
24993280ed
Next step in server-to-server sharing next generation, see #12285
...
Beside some small improvements and bug fixes this will probably the final state for OC8.
To test this you need to set up two ownCloud instances. Let's say:
URL: myPC/firstOwnCloud user: user1
URL: myPC/secondOwnCloud user: user2
Now user1 can share a file with user2 by entering the username and the URL to the second ownCloud to the share-drop-down, in this case "user2@myPC/secondOwnCloud".
The next time user2 login he will get a notification that he received a server-to-server share with the option to accept/decline it. If he accept it the share will be mounted. In both cases a event will be send back to user1 and add a notification to the activity stream that the share was accepted/declined.
If user1 decides to unshare the file again from user2 the share will automatically be removed from the second ownCloud server and user2 will see a notification in his activity stream that user1@myPC/firstOwnCloud has unshared the file/folder from him.
2014-12-19 15:20:24 +01:00
f671b232cc
Merge pull request #12923 from owncloud/ultra-slim-version-of-incognito-mode
...
Add ultra-slim hack for incognito mode
2014-12-19 14:54:11 +01:00
dbbf568192
Fix typo
2014-12-19 14:36:00 +01:00
a022e65285
Clarify return values
...
This function returns `null` when no user is logged-in.
2014-12-19 14:17:40 +01:00
2d64797320
Merge pull request #12956 from owncloud/jenkins-user-backend-names
...
[jenkins only] introduce names for user backends - IUserBackend
2014-12-19 13:15:50 +01:00
157ff1219a
Merge pull request #12954 from owncloud/hhvm-apc-clear
...
HHVM: In APC cache clear, only request the cache key in APCIterator.
2014-12-19 10:46:20 +01:00
6b3600d2bf
Merge pull request #12918 from owncloud/use-uid-instead-of-login-name
...
Return UID instead of login name
2014-12-19 10:24:52 +01:00
6da33e1ea7
introduce names for user backends - IUserBackend
...
* LDAP with multiple servers also proved backendName
2014-12-19 10:17:17 +01:00
39d6ddd38a
Merge pull request #12865 from owncloud/files-tags-webdav
...
Returns tags through WebDAV
2014-12-19 09:33:28 +01:00
028b0efd5c
[tx-robot] updated from transifex
2014-12-19 01:56:51 -05:00
0ba5c182f0
HHVM: In APC cache clear, only request the cache key in APCIterator.
...
The default value of the $format parameter of the APCIterator constructur is
APC_ITER_ALL which instructs the iterator to provide all available information
on cache values being iterated over. Only the key value is necessary for
matching and deletion via apc_delete(), though.
This prevents a "Format values FILENAME, DEVICE, INODE, MD5, NUM_HITS, MTIME,
CTIME, DTIME, ATIME, REFCOUNT not supported yet." notice on HHVM.
2014-12-19 03:24:00 +01:00
114a6464e8
Merge pull request #12748 from owncloud/redis_cache
...
Add Redis cache implementation, prefer over memcached, tests & config sample doc
2014-12-19 00:26:25 +01:00
75e8b39826
Merge pull request #12879 from owncloud/mountconfig
...
Add mount specific options
2014-12-18 23:38:14 +01:00
891474b0d6
Merge pull request #12759 from owncloud/core-reduce-js-and-css
...
make sure styles and scripts are only loaded once
2014-12-18 23:18:37 +01:00
609e10238f
Merge pull request #12945 from owncloud/hhvm-image
...
HHVM: Do not call filesize(null), this function expects a string.
2014-12-18 22:20:56 +01:00
3ebb69944b
Do not call filesize(null), this function expects a string.
...
filesize(null) yields an int on HHVM and thus exif_imagetype(null) is called.
2014-12-18 20:57:19 +01:00
85301c8b85
Merge pull request #12940 from drarko/master
...
Fix extra quotes in custom tags in header
2014-12-18 18:44:44 +01:00
6224e29f25
Fix code style issues for tags plugin
2014-12-18 16:43:00 +01:00
faaa1a89cb
Fix extra quotes in custom tags in header
...
Fix #12939
2014-12-18 12:40:08 -03:00
1ef01de402
Merge pull request #12907 from owncloud/delete-invalid-external-share
...
Fix deleting invalid s2s shares
2014-12-18 16:38:13 +01:00
3c67900421
Remove obsolete method
2014-12-18 16:04:36 +01:00
5c6e08213e
[tx-robot] updated from transifex
2014-12-18 01:56:40 -05:00
619dcae7af
Merge pull request #12901 from owncloud/move-ldap-check-to-manager
...
Move the Null-Byte LDAP check to the user manager
2014-12-18 00:28:00 +00:00
d83fdd7f9d
Merge pull request #12913 from owncloud/hhvm-memcached-clear
...
HHVM: Add workaround for missing Memcached::deleteMulti()
2014-12-18 00:27:07 +00:00
232d4385f4
Merge pull request #12917 from owncloud/fix-ocs-12915-api
...
Move basic auth login out of `isLoggedIn`
2014-12-18 00:57:22 +01:00
e3230b5bc2
Add ultra-slim hack for incognito mode
...
As discussed at https://github.com/owncloud/core/pull/12912#issuecomment-67391155
2014-12-17 21:53:43 +01:00
058324b80e
Check basic auth header only for not-logged-in users
2014-12-17 21:42:07 +01:00
3d006207d1
Merge pull request #12892 from owncloud/is-addmin
...
Add isAdmin and isInGroup methods for the group manager
2014-12-17 21:40:26 +01:00
9031d79597
Return UID instead of login name
...
Without this OCS on LDAP is broken for API requests coming via Basic Authentication...
2014-12-17 20:33:22 +01:00
a02b00445e
Store result of authentication
2014-12-17 20:22:51 +01:00
b91a435ed4
Move basic auth login out of `isLoggedIn`
...
Potentially fixes https://github.com/owncloud/core/issues/12915 and opens the door for potential other bugs...
Please test very carefully, this includes:
- Testing from OCS via cURL (as in #12915 )
- Testing from OCS via browser (Open the "Von Dir geteilt" shares overview)
- WebDAV
- CalDAV
- CardDAV
2014-12-17 20:12:14 +01:00
fcf3c5197f
HHVM: Add workaround for missing Memcached::deleteMulti()
2014-12-17 18:10:11 +01:00
6779bf113d
add isAdmin and isInGroup methods for the group manager
2014-12-17 17:41:57 +01:00
236632702c
add a isLoggedIn method to the usersession and deprecate the isLoggedIn method on the api
2014-12-17 17:40:52 +01:00
8c509c3437
HHVM: Call libxml_use_internal_errors() instead of surpressing errors.
...
In contrast to the previous solution, this also works on HHVM.
2014-12-17 17:00:10 +01:00
0b3f0716fc
Returns and update tags through WebDAV PROPFIND and PROPPATCH
...
Added oc:tags and oc:favorites in PROPFIND response.
It is possible to update them with PROPPATCH.
These properties are optional which means they need to be requested
explicitly
2014-12-17 16:50:35 +01:00
9ddd5033d4
Movable mountpoints are always deletable
2014-12-17 16:09:28 +01:00
2eab0f2121
Allow disabling previews per mount
2014-12-17 14:03:50 +01:00
fd85424742
Add getMountPoint to FileInfo
2014-12-17 14:03:50 +01:00
95a145f67f
Load mount specific options from the mount config
2014-12-17 14:03:50 +01:00
f6820406b6
Move the Null-Byte LDAP check to the user manager
...
The existing method is deprecated and just a wrapper around the manager method. Since in the future other code paths might call this function instead we need to perform that check here.
Related to http://owncloud.org/security/advisory/?id=oc-sa-2014-020
2014-12-17 12:47:00 +01:00
77c4c2856a
Merge pull request #12889 from owncloud/deprecation-time
...
Deprecate old and replaced appframework apis
2014-12-17 11:28:01 +01:00
6d80524e67
[tx-robot] updated from transifex
2014-12-17 01:56:41 -05:00
d59c4e832f
first round of deprecation
2014-12-16 19:50:31 +01:00
51a22431ee
load showpassord.js conditionally in the template only if needed
2014-12-16 18:45:37 +01:00
775f6a1354
make sure styles and scripts are only loaded once
2014-12-16 18:26:43 +01:00
26100a6dfb
Move timezone logic out of server.php
2014-12-16 16:16:22 +01:00
5b9c453071
[tx-robot] updated from transifex
2014-12-16 01:55:32 -05:00
be3d4fd303
Merge pull request #12360 from owncloud/files-tags
...
Add favorites to files app
2014-12-15 19:55:18 +01:00
76357af2d5
Merge pull request #11946 from owncloud/load-vendor-from-core-json
...
Implement method that reads vendor libs from core.json
2014-12-15 16:18:38 +01:00
6602d3ac77
Merge pull request #12555 from owncloud/app_specific_search
...
introduce inApps[] filter for search via ajax query
2014-12-15 16:14:40 +01:00
9f30d3529a
Implement method that reads vendor libs from core.json
...
* includes them at the beginning of initTemplate()
2014-12-15 14:30:03 +01:00
d367d1b06a
Merge pull request #12839 from oparoz/ControllerMethodReflector
...
\OCP\AppFramework\Utility\IControllerMethodReflector
2014-12-15 14:20:26 +01:00
be45366013
Merge pull request #12625 from owncloud/app-dependencies-libs-and-commands
...
adding dependencies for command line tools and php libraries
2014-12-15 12:34:46 +01:00
e58b9d3eb7
fixing owncloud version
2014-12-15 12:23:56 +01:00
c6be491a89
Return file info from Node API
2014-12-15 12:10:54 +01:00
b831914aa6
Merge pull request #11991 from owncloud/bower-jquery-ui
...
bower jquery-ui - exported changes to a separate css file
2014-12-15 11:39:31 +01:00
036456fe16
[tx-robot] updated from transifex
2014-12-15 01:54:30 -05:00
469fd3b3a3
Olivier Paroz \OCP\AppFramework\Utility\IControllerMethodReflector
2014-12-14 23:54:31 +01:00
768aea57d3
make regex in controllermethodreflector.php compatible with PCRE 6.x
...
The syntax ?<...> seems to be only supported from PCRE 7.0 on. For
backwards-compability ?P<...> is used.
2014-12-14 10:52:21 +01:00
6ae0217326
[tx-robot] updated from transifex
2014-12-14 01:54:56 -05:00
5b3971f002
Merge pull request #12639 from owncloud/bad_mtime_format
...
Fix formatting of bad dates from external storages
2014-12-13 10:07:10 +01:00
edcd2f2706
bower jquery-ui - exported changes to a separate css file
2014-12-13 09:47:34 +01:00
efb495b09f
Merge pull request #12726 from owncloud/add-filter-for-backend-to-rest-index
...
Add filter for backend to rest index
2014-12-13 08:50:15 +01:00
416e21d902
[tx-robot] updated from transifex
2014-12-13 01:55:24 -05:00
fdbb68a3c3
Return ? if mtime is 0 or -1
...
Tooltip contains 'Unable to determine date'. Fixes #6395
2014-12-12 23:54:18 +00:00
4b57892c4e
Merge pull request #12778 from owncloud/searchbytags2
...
Added searchByTags to view, storage and cache
2014-12-12 14:27:19 +01:00
4f92e4a233
Merge pull request #12808 from owncloud/add-special-parameterlist-to-manager
...
Add special parameterlist to manager
2014-12-12 13:03:26 +01:00
dcb88e395b
rework api of DependencyAnalyzer
2014-12-12 12:34:53 +01:00
b1bef5cc15
Merge pull request #12587 from owncloud/dav-logerrors
...
Log exceptions in DAV storage
2014-12-12 11:58:04 +01:00
7542883bf8
Merge pull request #12807 from owncloud/fix-timespan-language
...
Correctly inject the language into the subcall
2014-12-12 11:57:22 +01:00
3878c3782f
Added searchByTag in cache jail wrapper
2014-12-12 11:48:42 +01:00
15ecb28d50
Make $userId mandatory for searchByTags
...
$userId is now a mandatory parameter for searchByTags.
Also fixed some places in the code where the argument was missing (Node
API and View)
2014-12-12 11:18:35 +01:00
811f9251d6
Correctly inject the language into the subcall
2014-12-12 11:00:07 +01:00
527dd8cdf4
[tx-robot] updated from transifex
2014-12-12 04:19:09 -05:00
e969fe6b12
Merge pull request #12698 from owncloud/handle_readonly_shared_files
...
Handle readonly shared files
2014-12-12 08:34:28 +01:00
68932b30fd
[tx-robot] updated from transifex
2014-12-12 01:55:24 -05:00
c56fa64801
Merge pull request #12786 from owncloud/userfolder-setup
...
Ensure user mountpoints are setup when using getUserFolder
2014-12-11 23:51:49 +01:00
25dde7e93b
Added searchByTags to view, storage and cache
2014-12-11 17:38:50 +01:00
d94c1731d7
check app dependencies on installation as well
2014-12-11 17:02:07 +01:00
6566dc83e7
single dependencies will not be represented as an array + fix unit tests
2014-12-11 15:37:45 +01:00
1b18554aa7
Allow extensions to specify the list of special parameters
2014-12-11 14:56:46 +01:00
802c1b0b3a
Ensure user mountpoints are setup when using getUserFolder
2014-12-11 14:34:30 +01:00
8fd90e04b6
Merge pull request #12781 from owncloud/jenkins-curl-open-basedir
...
[Jenkins only] curl open basedir
2014-12-11 14:15:24 +01:00
cbad5c998b
Correctly fallback to english, if the plural case is not translated
2014-12-11 12:42:21 +01:00
d0716d2c7d
Use public interface
2014-12-11 12:29:58 +01:00
745d8706b9
Add user parameter to tag manager
2014-12-11 12:22:28 +01:00
5a03e0a5cf
adding dependency to owncloud version - with fallback to requiremin and requiremax
2014-12-11 12:02:12 +01:00
ee46548f57
adding dependencies for supported platforms
2014-12-11 12:02:12 +01:00
770f987659
adding supported libraries - including min and max version
2014-12-11 12:02:11 +01:00
08f1db4451
adding dependencies for command line tools
2014-12-11 12:02:11 +01:00
c5e279e416
year go -> year ago
2014-12-11 11:30:00 +01:00
dc506dcfbf
[tx-robot] updated from transifex
2014-12-11 01:55:27 -05:00
9ea205dc3d
Check if open_basedir is set
...
The file:// protocol does not work with curl when an open_basedir is set.
This fixes https://github.com/owncloud/core/issues/12016
2014-12-11 00:09:55 +01:00
d84a1f6f3a
Add IniGetWrapper to public interface
2014-12-11 00:09:55 +01:00
e2c51308df
Merge pull request #12758 from owncloud/fix-config-doc-block
...
Add type of the variables to the docs
2014-12-10 17:22:36 +01:00
80ae311329
Merge pull request #11892 from owncloud/remove_triggerupdate
...
Remove triggerupdate.php & add quiet option for CLI scanner
2014-12-10 16:17:29 +01:00
1d490b559c
introduce inApps[] filter for search via ajax query, make file results show up in files app only
...
use more flexible return type
check array with !empty instead of count
2014-12-10 15:51:59 +01:00
bef7392c4c
Add type of the variables to the docs
2014-12-10 15:18:06 +01:00
3898fbc0d2
Merge pull request #12750 from owncloud/cache-numericstorageidfix
...
Fix numeric storage id for cache wrapper
2014-12-10 15:03:41 +01:00
fd2599cfc2
Merge pull request #12485 from owncloud/jenkins-12383
...
New DateTimeFormatter class for dates in other timezones and languages
2014-12-10 14:48:59 +01:00
ebba54d490
Fix numeric storage id for cache wrapper
2014-12-10 13:05:31 +01:00
363e9667ec
Add Redis cache implementation, prefer over memcached, tests & config sample
2014-12-10 12:24:20 +01:00
5dc6406b70
Add filter for 'backend' to user REST route
...
This adds a "backend" type filter to the index REST route which is a pre-requisite for https://github.com/owncloud/core/issues/12620
For example when calling `index.php/settings/users/users?offset=0&limit=10&gid=&pattern=&backend=OC_User_Database` only users within the backend `OC_User_Database` would be shown. (requires sending a CSRF token as well)
Depends upon https://github.com/owncloud/core/pull/12711
2014-12-10 12:07:34 +01:00
67335ccddf
Require the interface and return a string instead of private classes
2014-12-10 11:58:56 +01:00
4d232e536e
Deprecate Util::formatDate()
...
Make DateTimeFormatter a service and adjust tests that have been inaccurate
2014-12-10 11:58:56 +01:00
5398bbdc00
Merge pull request #12711 from owncloud/add-backend-to-rest-index
...
Expose backend type via REST API
2014-12-10 11:56:45 +01:00
0f17486c1d
make path absolute
2014-12-10 11:04:17 +01:00
ea95bb0189
[tx-robot] updated from transifex
2014-12-10 01:55:34 -05:00
7028c7150d
Merge pull request #12664 from owncloud/fix-12164
...
Use httphelper and cache response even when it is empty
2014-12-10 05:42:08 +01:00
c9fd3c9d29
Inject config
2014-12-10 01:13:38 +03:00
263e008d7b
Merge pull request #12695 from owncloud/db-drop-table
...
Add dropTable to IDBConnection
2014-12-09 18:40:56 +01:00
6984fa8a19
Quote identifiers for oracle
2014-12-09 17:26:53 +01:00
778d8dbafd
Add tableExists to public db api
2014-12-09 17:26:53 +01:00
8af3991d0c
Add dropTable to IDBConnection
2014-12-09 17:26:53 +01:00
d69ea30097
Add a DateTimeFormatter class which allows overwriting the language and timezone
...
Fix #12227
2014-12-09 16:10:24 +01:00
f53f25eafe
Merge pull request #12409 from owncloud/tags-getTagsForObjectIds
...
Add getTagsForObjects in ITags
2014-12-09 13:27:38 +01:00
26861a98c5
Merge pull request #12568 from owncloud/autoload-encryption-classes
...
Fix namespaces of encryption classes and encryption tests
2014-12-09 12:56:57 +01:00
4c13918bd8
Expose backend type via REST API
...
This change will expose the user backend via the REST API which is a pre-requisite for https://github.com/owncloud/core/issues/12620 .
For example:
````json
[{"name":"9707A09E-CA9A-4ABE-A66A-3F632F16C409","displayname":"Document Conversion User Account","groups":[],"subadmin":[],"quota":"default","storageLocation":"\/Users\/lreschke\/Programming\/core\/data\/9707A09E-CA9A-4ABE-A66A-3F632F16C409","lastLogin":0,"backend":"OCA\\user_ldap\\USER_LDAP"},{"name":"ED86733E-745C-4E4D-90CB-278A9737DB3C","displayname":"Hacker","groups":[],"subadmin":[],"quota":"default","storageLocation":"\/Users\/lreschke\/Programming\/core\/data\/ED86733E-745C-4E4D-90CB-278A9737DB3C","lastLogin":0,"backend":"OCA\\user_ldap\\USER_LDAP"},{"name":"71CDF45B-E125-450D-983C-D9192F36EC88","displayname":"admin","groups":[],"subadmin":[],"quota":"default","storageLocation":"\/Users\/lreschke\/Programming\/core\/data\/71CDF45B-E125-450D-983C-D9192F36EC88","lastLogin":0,"backend":"OCA\\user_ldap\\USER_LDAP"},{"name":"admin","displayname":"admin","groups":["admin"],"subadmin":[],"quota":"default","storageLocation":"\/Users\/lreschke\/Programming\/core\/data\/admin","lastLogin":"1418057287","backend":"OC_User_Database"},{"name":"test","displayname":"test","groups":[],"subadmin":[],"quota":"default","storageLocation":"\/Users\/lreschke\/Programming\/core\/data\/test","lastLogin":0,"backend":"OC_User_Database"}]
```
2014-12-09 12:04:19 +01:00
5609d421cd
Merge pull request #12672 from LEDfan/cm-per-unit
...
Fix Contactsmanager permission + unit test
2014-12-09 10:57:22 +01:00
78a307995c
Fix namespace of Files_Encryption outside of the app
2014-12-09 09:47:26 +01:00
c36bac3abd
Merge pull request #12406 from owncloud/drop-getApps-getUsers
...
Config cleanup - OC_Preferences refactoring
2014-12-09 09:36:38 +01:00
25a87d4058
Merge pull request #12577 from owncloud/public-mount-api
...
Add a public api for apps to add mounts
2014-12-08 22:57:33 +01:00
9a7362dd0d
drop unused isDebugMode and setDebugMode of OC_Config
2014-12-08 22:42:44 +01:00
0d4f0ab871
reduce OC_Preferences, OC_Config and \OCP\Config usage
...
* files_encryption
* files_versions
* files_trashbin
* tests
* status.php
* core
* server container
2014-12-08 22:42:37 +01:00
2d5fc9c1a6
Workaround to fix the too early init dilemma
...
* this needs to be properly fixed by a proper organisation of the base.php
* introduced fixDIInit() in AllConfig that moves the injection
of DatabaseConnection to a later point in time
* problems mostly because of the autoconfig setup
2014-12-08 22:33:36 +01:00
af91ee97c9
introduce preCondition for setUserValue to provide atomic check-and-update
2014-12-08 22:33:36 +01:00
f0b10324ca
Refactoring of OC_Preferences to AllConfig
...
* keep old static methods - mapped to new ones and deprecated
* removed deleteApp, getUsers, getApps because they are unused
* make AllConfig unit tests more robust against not cleaned up environments
2014-12-08 22:33:29 +01:00
f164161f69
fix base.php for not installed systems
2014-12-08 22:29:43 +01:00
a9e411e076
migrate \OC\AllConfig to \OCP\IConfig
2014-12-08 22:29:43 +01:00
719008836d
introduce deleteAllUserValues
2014-12-08 22:29:42 +01:00
985b15f770
introduce proper interface for deleteAppValue
2014-12-08 22:29:42 +01:00
b01c59b224
use old methods and redirect in deprecated methods
2014-12-08 22:29:42 +01:00
d6da627eb4
@deprecated messages for \OCP\Config and \OCP\AppConfig
2014-12-08 22:29:42 +01:00
50c2a819a0
Extract interaction with config.php into SystemConfig
...
* introduce SystemConfig to avoid DI circle (used by database connection which is itself needed by AllConfig that itself contains the methods to access the config.php which then would need the database connection - did you get it? ;))
* use DI container and use that method in legacy code paths (for easier refactoring later)
* create and use getSystemConfig instead of query() in DI container
2014-12-08 22:29:42 +01:00
cae600722e
Add getTagsForObjects in ITags
...
Returns the list of tags that are set on the given object ids.
2014-12-08 22:02:00 +01:00
f219f5a7a6
Merge pull request #12618 from owncloud/initial-work-migrate-to-appframework
...
Add REST route for managing groups and users
2014-12-08 21:37:41 +01:00
81d5712419
Fix tests. Add two more test cases
2014-12-08 22:16:47 +03:00
85176ec072
return correct result
2014-12-08 15:25:21 +01:00
1362c0b67a
Merge pull request #12452 from owncloud/server2server-ng-ocs
...
OCS API for server-to-server sharing
2014-12-08 14:12:03 +01:00
fe7d9a7ca0
Add REST route for user & group management
...
First step of a somewhat testable user management. - I know, the JSON returns are in an ugly format but the JS expects it that way. So let's keep it that way until we have time to fix the JS in the future.
2014-12-08 12:11:01 +01:00
2784d580bd
[tx-robot] updated from transifex
2014-12-08 01:54:57 -05:00
7917d3b068
Remove changes which were inadvertently pushed to master
2014-12-08 04:03:02 +01:00
d9c0be8785
Dump Arrays, Objects and Exceptions to the log
...
This is a first draft. It has only been tested with the ownlcloud logger.
Some internal fields are JSON encoded several times which makes it harder to read.
Most of the normalizer is borrowed from Monolog
https://github.com/Seldaek/monolog/blob/master/src/Monolog/Formatter/NormalizerFormatter.php
2014-12-08 03:53:07 +01:00
e4255e9d54
Merge pull request #12644 from owncloud/add-hack-for-config
...
Create config if it does not exists
2014-12-07 22:33:16 +01:00
8ee9ee29ea
[tx-robot] updated from transifex
2014-12-07 01:54:32 -05:00
303fce44f4
Use httphelper and cache response even when it empty
2014-12-06 20:17:47 +03:00
bd520d2e53
Create config if it does not exists
...
The codepath that is executed when executing ownCloud via CLI is different than via browser. Specifically, the config is created by the user session already in `OC_Util::getInstanceId()` by a call to `setValue`. That said, this seems to be quite a bad side-effect, but for the sake of "not breaking whatever might break if we touch this" let's keep it that way for now.
When executing the autoconfig via `php -f index.php` the said session was not setup and thus no `config/config.php` file was created resulting in an installation error.
To reproduce this try to setup ownCloud via `php -f index.php` with and without that patch. (ensure to delete all existing configs before and don't access ownCloud with a browser in the meantime)
Fixes itself.
2014-12-06 14:00:14 +01:00
b412e59c26
Fix permissions
2014-12-06 13:58:10 +01:00
94eb2e782f
[tx-robot] updated from transifex
2014-12-06 01:54:56 -05:00
ddcf2b84ec
Remove checks for safe mode and magic quotes
...
Both are removed from 5.4.0
Safe Mode: http://php.net/manual/en/features.safe-mode.php
> This feature has been DEPRECATED as of PHP 5.3.0 and REMOVED as of PHP 5.4.0.
Magic Quotes: http://php.net/manual/en/security.magicquotes.php
> This feature has been DEPRECATED as of PHP 5.3.0 and REMOVED as of PHP 5.4.0.
2014-12-05 19:14:47 +01:00
5f66cb3250
Merge pull request #12561 from oparoz/vectoricon
...
Improve the bitmap and vector mime icons
2014-12-05 14:51:03 +01:00
4ec1da3014
Merge pull request #12583 from owncloud/trim-port
...
Trim port from domain
2014-12-05 11:27:20 +01:00
4d53f163fd
[tx-robot] updated from transifex
2014-12-05 01:55:52 -05:00
b6975143ff
Merge pull request #12619 from owncloud/use-also-original-hea
...
Merge headers
2014-12-04 16:59:42 +01:00
f4701d7721
Add public api for mount configurations
2014-12-04 16:47:27 +01:00
f3213571bb
Merge pull request #12616 from owncloud/node-fileinfo
...
make \OC\Files\Node\Node implement the FileInfo interface
2014-12-04 16:34:30 +01:00
b8a2fdaa21
Merge pull request #12607 from owncloud/this-is-an-awesome-day
...
PHP 5.4 is now required for master
2014-12-04 10:33:04 -05:00
db9765b4d5
Merge headers
...
Otherwise the headers from `JSONResponse` are gone and the Content-Type of the response would be `text/html` instead of `application/json; charset=utf-8`. This leads to broken scripts since we set the `nosniff` tag, furthermore this is very bad from a security PoV.
2014-12-04 14:45:15 +01:00
e9f0b30023
Merge pull request #12609 from owncloud/remove-53-fixme
...
Remove workaround for 5.3
2014-12-04 14:25:47 +01:00
7ef6df04da
remove triggerupdate, ref #11872
2014-12-04 13:44:30 +01:00
672495a1a3
make \OC\Files\Node\Node implement the FileInfo interface
2014-12-04 13:27:08 +01:00
698ecbf308
OCS API for server-to-server sharing
2014-12-04 13:18:13 +01:00
b55ac514ac
no nested xml tags on dependencies
2014-12-04 11:40:33 +01:00
eb81c52b95
fix an issue where the types tag holds an empty string
2014-12-04 11:40:33 +01:00
b028a6afac
adjust dependency analyzer to use attributes properly
2014-12-04 11:40:33 +01:00
c80ec91f28
switch to different parsing implementation to get xml attributes properly handled
2014-12-04 11:40:33 +01:00
ba52c996cf
adding supported databases
2014-12-04 11:40:33 +01:00
b469e9f6fb
introduce dependency analyzer to take care of app dependencies
...
some more unit tests on xml info parser
2014-12-04 11:40:33 +01:00
40e03ba314
adding default key value pair for 'types'
2014-12-04 11:40:33 +01:00
1354cee18e
translate labels properly
2014-12-04 11:40:33 +01:00
ee1f8b0242
Remove workaround for 5.3
...
Function is natively available with 5.4
2014-12-04 11:17:33 +01:00
1b0bc2e099
PHP 5.4 is now required for master
...
🍻
2014-12-04 10:46:38 +01:00
bc12d28f23
Log exceptions in DAV storage
...
In some cases a "NotFound" might be expected, so just return false as
before. But for other exceptions, the exception is now logged.
2014-12-03 22:20:00 +01:00
b3515a98e9
Add workaround for older instances
...
To be removed with oCAdd workaround for older instances
To be removed with oC99
2014-12-03 21:13:27 +01:00
69f5f6649e
Trim port from domain
...
Depending on the used environment the port might be appended to the host header resulting in an inaccessible instance when initially setting up on a system with a different HTTP or HTTPS port. (for example test:500)
To test this setup ownCloud under a different port with and without this patch. (heads-up: localhost is always white-listed, so use a different domain)
2014-12-03 19:59:50 +01:00
8700ffe698
Merge pull request #12572 from owncloud/issue/12571-disabled-preview-logflood
...
Stop flooding the log, when previews are disabled
2014-12-03 14:51:03 +01:00
7291b915b8
Merge pull request #12553 from owncloud/default-iosid
...
add missing public interface for iOS client app id
2014-12-03 14:05:27 +01:00
69a5a0c1a0
Stop flooding the log, when previews are disabled
2014-12-03 12:52:42 +01:00
2bbb11fb63
Merge pull request #10881 from owncloud/touch-statcache
...
Clear statcache before getting the mtime from local storage backends
2014-12-02 23:29:24 +01:00
5990293331
Improve the bitmap and vector mime icons
...
* Vector files such as Illustrator files currently show the "image"
icon. I propose to add a new type to mimetypeIcon() called
"image/vector" and which would be used by SVG as well
* We can use the current image-svg+xml icon, but would simply rename it
to image-vector
* The black and white "image" icon looks too much like a settings icon.
A simple picture representation pasted over the file icon should work
2014-12-02 21:11:56 +01:00
1bbb18fe87
also clear statcache in mapped local
2014-12-02 16:39:03 +01:00
a16d1a85ef
Merge pull request #11975 from owncloud/Combustible-combustible_dev
...
Check imagecreate*() return before using and use logger in \OC_Image
2014-12-02 16:18:00 +01:00
5b3dbb4ef8
add missing public interface for iOS client app id
2014-12-02 16:10:07 +01:00
db3f7238dd
Clear statcache before getting the mtime from local storage backends
2014-12-02 14:25:49 +01:00
e9029f94cb
Merge pull request #12310 from kampka/master
...
Implement a logger to log to error_log
2014-12-02 09:19:12 +01:00
553ce946d3
Implement a logger to log to error_log
2014-12-01 21:20:57 +01:00
0769556989
Merge pull request #12419 from owncloud/read-only-config
...
Allow read-only configuration
2014-12-01 16:37:29 +01:00
b2175f0e25
Use \OCP\ILogger
2014-12-01 16:21:54 +01:00
fa9b36b726
Added error check to lib/private/image.php
...
This checks that imagecreatetruecolor actually creates an image, rather than returning FALSE.
Without this check, subsequent loop might create billions of ERROR-level log messages.
Signed-off-by: Byron Marohn <combustible@live.com>
2014-12-01 16:20:17 +01:00
8db4dd7585
Merge pull request #12469 from owncloud/issue/12460-port-local-changes2mapped
...
Issue/12460 port local changes2mapped
2014-12-01 10:42:39 +01:00
ffd1fc42e7
Merge pull request #12427 from owncloud/issue/6101-deprecate-namespaced-functions
...
Depcrate namespaced functions, since they can not be autoloaded
2014-12-01 09:38:15 +01:00
6fa748621f
Merge pull request #12398 from oparoz/patch-5
...
You can only change the oritentation of a JPEG
2014-11-30 10:32:51 +01:00
83d097c524
[tx-robot] updated from transifex
2014-11-29 01:54:28 -05:00
ebb243344a
Merge pull request #12499 from owncloud/disableMSSQL
...
Disable MSSQL and OCI for new CE installations
2014-11-28 18:38:34 +01:00
f0e6876f2e
Merge pull request #12488 from owncloud/activity_group_multiple_conditions
...
activitymanager: concatenate queries with 'or'
2014-11-28 17:35:05 +01:00
9a8dc4a832
Disable OCI as it is unsupported by most CE apps
2014-11-28 16:23:03 +01:00
f3e75c085c
Disable MSSQL for new CE installations
...
Since automatic schema migrations are not yet possible let's disable this for now.
2014-11-28 16:08:38 +01:00
219a129cd6
Close cursor after checking for existing config values
2014-11-28 15:33:21 +01:00
bf2c9be066
concatenate queries with 'or'
2014-11-28 14:46:27 +01:00
2c157da1c2
Merge pull request #12486 from owncloud/activity_priorities
...
add activity priorities to core so that other apps can reuse it
2014-11-28 14:40:27 +01:00
b3afc98f82
Merge pull request #12483 from owncloud/issue/6101-preview-providers
...
Issue/6101 Autoload preview providers
2014-11-28 13:43:41 +01:00
00ad7d48c7
add activity priorities to core so that other apps can reuse it
2014-11-28 10:37:16 +01:00
b188710af3
Merge pull request #12472 from owncloud/modifyCookies
...
Add functions to modify cookies to response class
2014-11-28 10:16:22 +01:00
7a9af8c40c
Merge pull request #12443 from owncloud/issue/6101-all-classes-autoloadable
...
Issue/6101 Make all interfaces/classes autoloadable
2014-11-28 09:40:27 +01:00
35ab770b11
Close cursor early in calculateFolderSize
...
This method triggers additional queries in $this->update() so to avoid
potential database locks or delays, we close the cursor as soon as it is not needed any more
2014-11-28 09:35:31 +01:00
99d0e7e92d
Merge pull request #12479 from rclarkson/master
...
Limit blacklist to php files
2014-11-28 09:29:15 +01:00
ec7b55f5be
Split bitmap providers into one per file
2014-11-28 09:28:33 +01:00
3ec42ad598
Split office providers into one class per file
2014-11-28 09:28:30 +01:00
9cb54e3809
Fix intendation and doc blocks of preview providers
2014-11-28 09:28:28 +01:00
96b0328d39
[tx-robot] updated from transifex
2014-11-28 01:55:29 -05:00
0d98329cac
Limit blacklist to php files
...
During performance optimization I have discovered that the installer scans all files for the blacklisted words. This greatly impacts speed on lower end devices such as the raspberry pie. This commit limits it to PHP files which seems to achieve the desired effect.
I have used the --include option to achieve this, see http://stackoverflow.com/questions/1987926/how-do-i-grep-recursively
This contribution is MIT licensed
2014-11-27 20:26:45 +01:00
fca9d32545
Move registration of core preview providers to preview
...
So the class files only have class code and don't execute code
2014-11-27 19:40:23 +01:00
7bbc27708a
Move NaturalSort_DefaultCollator to its own file
2014-11-27 17:47:21 +01:00
7b8824a4e3
Move iHomeStorage to own file
2014-11-27 17:47:20 +01:00
dfde04291e
Move share interfaces to own files so they can be autoloaded
2014-11-27 17:47:19 +01:00
05a069c101
Merge pull request #12426 from owncloud/jail-mask-wrappers
...
Add Jail and PermissionsMask storage wrappers
2014-11-27 16:00:14 +01:00
33b64868d7
Add storage and cache wrappers to apply a permissions mask to a storage
2014-11-27 15:25:57 +01:00
abb6e89c5d
Add storage and cache wrappers to jail a storage to a subfolder
2014-11-27 15:25:53 +01:00
af56429a9a
Merge pull request #12470 from owncloud/jenkins-12447
...
Jenkins 12447
2014-11-27 15:16:14 +01:00
7761f0288e
Also clearstatcache() in MappedLocal before using the stats
...
Local change 283c10f010
2014-11-27 14:59:10 +01:00
50f85bfd1f
Check whether file exists before trying to touch() it
...
Local changes from d069ee8a8b258ad38fd3
2014-11-27 14:59:09 +01:00
c5427da76d
Check return of disk_free_space before returning it
...
Local changes copied from ed8359737125370fcb82
2014-11-27 14:59:08 +01:00
1062f4fe44
Check file existance in MappedLocal in hasUpdated()
...
Only fixed in Local by eeee9eacea
2014-11-27 14:59:07 +01:00
b886d3d645
Make MappedLocal::isLocal() true like for Local
...
Missed in 788c8540aa
2014-11-27 14:59:07 +01:00
e733d32eec
Merge pull request #12462 from owncloud/issue/12460-localstorage-buildpath
...
Introduce buildPath() in Storage\Local to reduce the difference to MappedLocal
2014-11-27 14:57:08 +01:00
e35feadac2
Pass \OC::$WEBROOT to the ctr
2014-11-27 14:50:14 +01:00
fef32e63dd
Remove redundant code
2014-11-27 14:38:38 +01:00
d197f43475
Use server container
2014-11-27 14:36:11 +01:00
048139074d
Add functions to modify cookies to response class
...
Currently there is no AppFramework way to modify cookies, which makes it unusable for quite some use-cases or results in untestable code.
This PR adds some basic functionalities to add and invalidate cookies.
Usage:
```php
$response = new TemplateResponse(...);
$response->addCookie('foo', 'bar');
$response->invalidateCookie('foo');
$response->addCookie('bar', 'foo', new \DateTime('2015-01-01 00:00'));
```
Existing cookies can be accessed with the AppFramework using `$this->request->getCookie($name)`.
2014-11-27 14:19:00 +01:00
0ed86c0993
Move OC_USER_BACKEND_* constants to OC_User_Backend class
2014-11-27 13:47:32 +01:00
24511c6f00
Move OC_GROUP_BACKEND_* constants to OC_Group_Backend class
2014-11-27 13:47:30 +01:00
a2172786a8
Merge pull request #12449 from owncloud/issue/12444-namespace-exceptions
...
Issue/12444 namespace exceptions
2014-11-27 12:14:06 +01:00
f52ba9c73c
Merge pull request #12418 from owncloud/delete_previews
...
delete old previews
2014-11-27 12:09:39 +01:00
4f1bbc4fd5
Remove unused 2nd parameter of buildPath() and rename to getSourcePath()
2014-11-27 11:19:20 +01:00
20237fba47
Introduce getSourcePath() in Storage\Local to reduce the difference to MappedLocal
2014-11-27 11:19:18 +01:00
a74822279c
Merge pull request #12464 from owncloud/cache-available-languages
...
Cache results of available languages
2014-11-27 11:12:18 +01:00
ea3780f911
Replace exception with standard exception
2014-11-27 11:10:05 +01:00
e1f3abf7a5
Correctly namespace and autoload DatabaseException
2014-11-27 11:10:04 +01:00
51190f711d
Merge pull request #12451 from owncloud/issue/6101-remove-gettype-class
...
Move constants from GET_TYPE to OC\Files so they can be autoloaded
2014-11-27 11:03:55 +01:00
b20d698ebd
Cache results of available languages
...
This function is about 8 times calles for every single page call, when caching this variable I was able to gain a small performance improvement from 20,512 µs to 630 µs profiled with xhprof
Surely, this is no gigantic gain but if we would do that for every function out there...
2014-11-27 00:01:55 +01:00
5097d4dc05
remove deprecated \OC:$session
2014-11-26 15:32:47 +01:00
8e28bf012c
Move constants from GET_TYPE to OC\Files so they can be autoloaded
2014-11-26 12:56:54 +01:00
3338eede3c
Correctly namespace DatabaseSetupException
2014-11-26 12:30:07 +01:00
a109f94fee
Depcrate namespaced functions, since they can not be autoloaded
2014-11-26 11:01:24 +01:00
c749570a06
Merge pull request #12411 from owncloud/unknown-command-windows
...
Replace some more "command -v" calls with the Helper method
2014-11-26 10:29:41 +01:00
1da46b1a58
Merge pull request #12438 from owncloud/jenkins-no-new-session-ocs-api
...
because OC_User::login will create a new session we shall only try to lo...
2014-11-26 10:22:16 +01:00
60e4aa120f
Merge pull request #12350 from mprokop/link_expiration
...
fix calculation of expiration date if there is a default expiration date...
2014-11-26 10:19:12 +01:00
320a3c3784
because OC_User::login will create a new session we shall only try to login if user and pass are set
...
ensure to never destroy an existing session
2014-11-26 09:19:10 +01:00
c5fa8f1bdc
Merge pull request #12421 from owncloud/issue/6101-remove-namespace-permission-constants
...
Issue/6101 remove namespace permission constants
2014-11-26 08:31:23 +01:00
e9696a8c9a
Merge pull request #12420 from owncloud/sqlite-wal-2
...
adding new config parameter for sqlite to specify the journal mode
2014-11-26 00:47:22 +01:00
0274dcba57
Replace some more "command -v" calls with the Helper method
2014-11-25 18:10:03 +01:00
2c39aec8cb
Replace deprecated constant with new class constant
2014-11-25 16:30:21 +01:00
a6c088a1ef
adding new config parameter for sqlite to specify the journal mode
2014-11-25 16:29:06 +01:00
711912a7b3
Move namespaced constants to namespaced class
2014-11-25 16:27:27 +01:00
fc116f563f
Allow read-only configuration
...
Workaround required for IIS setups running ownCloud to prevent dataloss.
Long-term solution would be to move some configuration settings to the database
2014-11-25 16:26:47 +01:00
0f18274ca5
Merge pull request #12416 from owncloud/app-info-xml-parser-2
...
App info xml parser 2
2014-11-25 15:56:52 +01:00
1a1b459ae8
delete old previews
2014-11-25 15:42:02 +01:00
5ce34fbaf6
handle invalid xml file
2014-11-25 11:53:28 +01:00
d4f107d4dd
simplify xml parser code
2014-11-25 11:53:28 +01:00
c503ecd544
Introduce app info xml parser including basic unit test - necessary for #10777
2014-11-25 11:53:28 +01:00
93a6cc17a5
The class name is Movie NOT Movies
2014-11-25 11:35:38 +01:00
53b2d85709
Merge pull request #12402 from owncloud/fix-phpdoc
...
Fix PHPDoc and deprecated code
2014-11-25 09:20:36 +01:00
eb1dcb87c1
Merge pull request #12380 from owncloud/remove-oc-migrate
...
Remove OC_Migrate
2014-11-25 00:25:37 +01:00
b947b65e5b
Fix PHPDoc and deprecated code
...
Some PHPDocs were incorrect, also used this opportunity to replace some deprecated functions.
2014-11-24 23:09:49 +01:00
e2a9bd7838
You can only change the oritentation of a JPEG
...
TIFFs also have EXIF headers, but they're not supported by the Image class
PHP doc
http://php.net/manual/en/function.exif-read-data.php
2014-11-24 17:32:53 +01:00
ddacd7f900
Merge pull request #12294 from owncloud/route-postfix
...
Add route postfix to allow url versioning when only the http method changed
2014-11-24 16:32:54 +01:00
168fce0b18
Merge pull request #12303 from owncloud/windows-unknown-command-command
...
Deduplicate findBinaryPath() and do not try "command -v" on windows
2014-11-24 14:03:07 +01:00
1b17429c1d
Merge pull request #12142 from owncloud/DeprecateOldIAPICalls
...
Deprecate older API wrappers and calls
2014-11-24 14:01:49 +01:00
8782b2237c
Merge pull request #12084 from owncloud/sharing_fix_shared_with_info
...
sharing: make sure that we only find the shares from a given owner
2014-11-24 11:44:43 +01:00
216d617938
Remove OC_Migrate
...
This is unused legacy code. Let it die with ~~~honor~~ fire.
Fixes https://github.com/owncloud/core/issues/12346
2014-11-24 10:53:45 +01:00
0edcfc1dc1
[tx-robot] updated from transifex
2014-11-24 01:54:35 -05:00
45d985f2d8
remove ugly hack and don't use OC\Preview\Image for tiffs and svgs
2014-11-23 19:11:03 +01:00
fa3f7ad9e9
[tx-robot] updated from transifex
2014-11-22 01:55:21 -05:00
a7ebfe87c9
also check for the correct owner if it was submitted
2014-11-21 16:17:37 +01:00
397f14ed86
Consolidate if statement, and update unit test
2014-11-21 13:31:56 +01:00
1d4d308a6c
fix calculation of expiration date if there is a default expiration date set (but not forced) and the user does not want the link to expire.
2014-11-21 11:01:39 +01:00
f8421958b3
[tx-robot] updated from transifex
2014-11-21 02:54:26 -05:00
593ef76e36
Revert "drop OC_Preferences::getUsers and getApps"
...
This reverts commit 09fd34eed9
2014-11-20 22:02:26 +01:00
09fd34eed9
drop OC_Preferences::getUsers and getApps
2014-11-20 17:56:05 +01:00
985f8c3f69
Merge pull request #12330 from owncloud/jenkins-eat-that
...
drop dependency of some commands on old config object
2014-11-20 17:11:08 +01:00
7fa4c6d0bc
Merge pull request #12321 from owncloud/checkForXMLWriter
...
Check for XMLWriter class
2014-11-20 17:04:27 +01:00
604bf61e10
Merge pull request #12299 from owncloud/clean-lib-base-config
...
replace all static calls to OC_Config and OC_Preferences to calls to OCP...
2014-11-20 16:24:37 +01:00
713c8e0dac
Merge pull request #12325 from owncloud/removeunneccessarylang
...
cleanup languages. closes #11274
2014-11-20 16:12:49 +01:00
8ae8eb4734
drop dependency of some commands on old config object
2014-11-20 15:03:16 +01:00
cbb9caf030
Merge pull request #12226 from owncloud/remove-phpass
...
Remove phpass and migrate to new Hasher interface
2014-11-20 14:59:59 +01:00
46e6104795
Merge pull request #12297 from owncloud/issue/10991-all-testcase
...
Issue/10991 all testcase
2014-11-20 14:53:18 +01:00
995fe4a176
cleanup languages. closes #11274
2014-11-20 14:46:17 +01:00
9a1673c79d
Check for XMLWriter class
...
This is not installed by default in all cases and will break the DAV features of ownCloud. Lot's of reports such as https://github.com/owncloud/ios-issues/issues/167#issuecomment-63798507
2014-11-20 13:13:14 +01:00
6a08fca363
Merge pull request #12253 from owncloud/port-12154
...
Port 12154
2014-11-20 12:47:27 +01:00
d15f1882f9
Simplify the binary finding code in the movie preview class
2014-11-20 12:41:55 +01:00
64421d76fd
Deduplicate function by moving it to the OC_Helper
2014-11-20 12:37:59 +01:00
fffc5bc002
[tx-robot] updated from transifex
2014-11-20 01:55:06 -05:00
bb540722cd
Use base class to reset the file mapper
2014-11-19 14:52:07 +01:00
980dd4d22a
replace double quotes with single quotes
2014-11-19 13:15:04 +01:00
fef9d4218c
replace all static calls to OC_Config and OC_Preferences to calls to OCP\IConfig
2014-11-19 13:06:22 +01:00
4e90c44301
add postfix
...
add postfix
2014-11-19 12:01:42 +01:00
705976ba0a
[tx-robot] updated from transifex
2014-11-19 01:54:59 -05:00
d40bdfb35e
drop unneeded var_dump - fixes #9997
2014-11-18 22:36:42 +01:00
81d112fb42
Merge pull request #12261 from oparoz/patch-1
...
Replace deprecated switches
2014-11-18 18:59:34 +01:00
106d0f9c75
Merge pull request #12224 from owncloud/fix_12211
...
make sure that we don't find the wrong shares if a user and a group have the same ID
2014-11-18 17:26:02 +01:00
cb118ce371
Replace deprecated switches
...
Warning: -convert-to is deprecated. Use --convert-to instead.
Warning: -outdir is deprecated. Use --outdir instead.
2014-11-18 15:04:01 +01:00
309788003d
Merge pull request #12259 from owncloud/app-enabled-plugin-appmanager
...
Fix type hinting for app manager
2014-11-18 13:56:40 +01:00
8d4e63dd7c
Merge pull request #12242 from owncloud/fix-undefined-size
...
Check if the size field is available
2014-11-18 12:37:16 +01:00
260a084d27
Add repair steps for legacy config files
...
Remove all ports from the trusted domains
Conflicts:
lib/private/repair.php
lib/repair/repairconfig.php
2014-11-18 12:36:03 +01:00
d0a30b0e55
Ignore port for trusted domains
...
This lead to a lot of confusion in the past and did not really offer any value. Let's remove the port check therefore. (it's anyways not really a part of the domain)
Fixes https://github.com/owncloud/core/issues/12150 and https://github.com/owncloud/core/issues/12123 and also a problem reported by @DeepDiver1975.
Conflicts:
lib/private/request.php
2014-11-18 12:36:03 +01:00
0b630a37ab
Fix type hinting for app manager
2014-11-18 12:22:13 +01:00
ea4eedd35a
only users can have a display name different from the id
2014-11-18 11:46:28 +01:00
367468ff1f
make sure that we only find the shares from the correct share type if users and groups with the same ID exists
2014-11-18 11:11:49 +01:00
5192641447
make sure that we don't find the wrong shares if a user and a group have the same ID
2014-11-18 11:03:08 +01:00
36ba935381
Merge pull request #12237 from owncloud/fix-12236
...
Make declaration compatible
2014-11-18 10:30:17 +01:00
944cd327b1
Merge pull request #9962 from owncloud/app-group-enable-remote
...
Fix remote.php routes for apps that are enabled for specific groups
2014-11-18 10:08:20 +01:00
91f7c0af6e
[tx-robot] updated from transifex
2014-11-18 01:54:31 -05:00
6535540dcd
Check if the size field is available
...
In some cases the 'size' field is not available resulting in some PHP errors such as:
```json
{"reqId":"03548fd9e3d3aca15a5796b3b35d7b9d","remoteAddr":"::1","app":"PHP","message":"Undefined index: size at \/Users\/lreschke\/Programming\/core\/lib\/private\/files\/fileinfo.php#125","level":3,"time":"2014-11-17T21:38:57+00:00"}
```
This can be experienced when creating a new empty file and deleting it right away, then when going to the trash bin this error is thrown.
2014-11-17 22:39:40 +01:00
e8f90133e0
Merge pull request #11727 from owncloud/moveCallCheckRegisterToSomeWhereElse
...
Move CSRF check
2014-11-17 18:34:55 +01:00
0b9dffa828
Make declaration compatible
...
Fixes #12236
2014-11-17 18:30:17 +01:00
af7688ec17
Merge pull request #11741 from owncloud/delete_all_children_preview_2
...
delete all children's previews when deleting a folder
2014-11-17 16:45:54 +01:00
146cb920c9
Merge pull request #12218 from owncloud/issue/10991-fixes
...
Issue/10991 Make unit tests pass on windows
2014-11-17 16:44:45 +01:00
7cb12d4bff
Add sabredav plugin to check if a user has access to an app
2014-11-17 15:50:24 +01:00
Thomas Müller
Lukas Reschke
Jenkins for ownCloud
Vincent Petry
Bjoern Schiessle
Bernhard Posselt
Robin Appelman
Björn Schießle
Morris Jobke
Jörn Friedrich Dreyer
Arthur Schiwon
Joas Schilling
Robin Appelman
Martin
Bernhard Posselt
Olivier Paroz
Clark Tomlinson
Georg Ehrke
Robin McCorkell
Frank Karlitschek
Chris Wilson
Adam Williamson
derkostka
dratini0
Frank Karlitschek
tbelau666
Andreas Fischer
drarko
Philipp Knechtges
Victor Dubiniuk
Olivier Paroz
LEDfan
Christian Kampka
Byron Marohn
Richard Clarkson
Miguel Prokop
Volkan Gezer