0d42d996d1
Adjust further columns
...
- calendarsubscriptions.lastmodified -> not null
- external_config.value -> allow null
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-09 12:13:33 +01:00
b9836398cc
Adjust calendars.components to 64 chars
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-09 12:13:33 +01:00
86a3b7e7bf
Merge pull request #24486 from nextcloud/feature/noid/phone-number-validation
...
Phone number validation and search
2020-12-08 17:05:38 +01:00
6a7e849090
php cs fix
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +01:00
b98fbcb774
We can no longe mock multiple interfaces
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +01:00
673beefb41
Fix MoveCalendarTest
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +01:00
7f0b2738bf
Fix notifier test
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +01:00
da9462b482
Make code strict
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +01:00
fc57f60ece
Merge pull request #24358 from nextcloud/dav-storage-copy
...
use storage copy implementation when doing dav copy
2020-12-03 15:03:13 +01:00
32f6bdf067
Merge pull request #24396 from nextcloud/dont-use-system-composer
...
dont use system composer for autoload checker
2020-12-02 16:15:55 +01:00
9be5caa937
Merge pull request #24340 from nextcloud/td/psalm/job_execute
...
Use proper OCP\BackgroundJobs\Job
2020-11-30 10:00:14 +01:00
528516b69f
Merge pull request #23652 from nextcloud/bug/circles-508/circles-public-shares
...
Fix public calendars shared to circles
2020-11-30 09:53:53 +01:00
7956cef622
rebuild autoloader scripts with 2.0.7
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-26 15:49:03 +01:00
35098a9973
A valid user session is required for circles.
...
The circles app depends on a valid userId. A public shared calender might be viewed by guests without a user session. For such requests the principal is null.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-11-26 09:00:09 +01:00
efef6e9b78
Update phpdoc for circleToPrincipal
...
as the QueryException is already catched inside circleToPrincipal.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-11-26 09:00:04 +01:00
6166e1a157
Use proper OCP\BackgroundJobs\Job
...
And typehunt the IJobList
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-25 15:03:06 +01:00
e165dcbe35
Merge pull request #24357 from nextcloud/fix/vcf-export-group-multiline
...
Make sure we add new line between vcf groups exports
2020-11-25 12:24:27 +01:00
81bf307845
[tx-robot] updated from transifex
2020-11-25 02:18:53 +00:00
5ca0de2dee
use storage copy implementation when doing dav copy
...
instead of using the sabredav fallback (which does a read+write stream copy)
this greatly speeds up dav copies
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-24 18:42:05 +01:00
e18899a06d
Make sure we add new line between vcf groups exports
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-11-24 18:33:39 +01:00
ce5e60d4b5
Merge pull request #24108 from csware/apple-unknown-year
...
Use correct year for generated birthdays events
2020-11-17 09:20:59 +01:00
0bed1c2bd0
[tx-robot] updated from transifex
2020-11-16 02:19:21 +00:00
e526e76314
Use correct year for generated birthdays events
...
'X-APPLE-OMIT-YEAR' is not always present, at least iOS 12.4 uses the hard coded date of 1604 (the start of the gregorian calendar) when the year is unknown.
cf. https://forums.bitfire.at/topic/2050/bday-without-year-for-vcard-3-0-if-server-drops-property-x-apple-omit-year and https://gitlab.com/CardBook/CardBook/-/issues/586
Signed-off-by: Sven Strickroth <email@cs-ware.de>
2020-11-13 15:57:12 +01:00
9db321cf11
Merge pull request #24054 from nextcloud/bugfix/noid/calendar-repair-oracle
...
Manually iterate over calendardata when oracle is used
2020-11-11 17:09:28 +01:00
e69655e9a6
Manually iterate over calendardata when oracle is used
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-11 15:08:43 +01:00
0c7bed26e8
Merge pull request #23915 from st3iny/fix/noid/png-icons-in-caldav-reminder-emails
...
Use png icons in caldav reminder emails
2020-11-11 12:45:23 +01:00
264d54b388
Fix CS
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:43:34 +01:00
31e243be74
Fix public calendars as they are stored with null on oracle
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:35:16 +01:00
ecbb066dec
Make sure columns with an empty default are nullable for Oracle
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:35:16 +01:00
609c8a9cf8
Fix "Invalid fetch style: 12" on Oracle
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:35:14 +01:00
f23c2162ad
Merge pull request #23993 from nextcloud/bugfix/noid/close-cursors
...
Don't leave cursors open
2020-11-10 15:15:03 +01:00
10aa22dd45
Merge pull request #23070 from eleith/complex-recurrance-imports
...
handle vcalander documents with multiple VEVENTS not in order
2020-11-10 05:20:56 -08:00
8027dcbc6f
Don't leave cursors open when tests fail
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-09 12:28:17 +01:00
f1c242c71d
Use png icons in caldav reminder emails
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2020-11-07 14:09:22 +01:00
8bd39fccf4
Have the CommentsPropertiesPlugin use the new fancy method
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-04 16:37:42 +01:00
8d02ee9ac7
Merge pull request #21693 from nextcloud/fix/noid/import-certificates-only-by-system
...
Improve CertificateManager to not be user context dependent
2020-11-03 21:48:37 +01:00
a6719390e2
[tx-robot] updated from transifex
2020-11-03 02:19:16 +00:00
dc479aae2d
Improve CertificateManager to not be user context dependent
...
* removes the ability for users to import their own certificates (for external storage)
* reliably returns the same certificate bundles system wide (and not depending on the user context and available sessions)
The user specific certificates were broken in some cases anyways, as they are only loaded if the specific user is logged in and thus causing unexpected behavior for background jobs and other non-user triggered code paths.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 00:13:01 +01:00
3f94c014f0
[tx-robot] updated from transifex
2020-11-02 02:19:04 +00:00
b1620344f3
[tx-robot] updated from transifex
2020-11-01 02:18:23 +00:00
ffda62b421
[tx-robot] updated from transifex
2020-10-31 02:18:47 +00:00
8c1f17383b
resolve review comments
...
update styling for conditionals and simplifying conditional by only
relying on dtstart instead of also counting vevents (since they imply
the same condition, assuming valid events)
Signed-off-by: leith abdulla <online-nextcloud@eleith.com>
2020-10-29 07:31:56 -07:00
a40a307b65
handle vcalander documents with recurrence with exemptions or edits
...
when importing ics files from third party services (ex: google), long
running recurrence vcalander objects can contain numerous vevents
relating to past exemptions or edits.
these objects are handled incorrectly, leading to incorrect first and/or
last occurence dates from being inferred. as a result, a number of
imported events are not rendered in the calendar.
this PR makes use of EventIterator's constructor that takes in an array
of VEVENTS to properly handle these complex cases.
Also of note is that other parameter signatures of EventIterator's constructor,
will be deprecated, according to comments in sabre dav EventIterator.php
Signed-off-by: leith abdulla <online-nextcloud@eleith.com>
2020-10-28 21:07:00 -07:00
c5e0ef1972
Don't overwrite the event if we use it later
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-28 13:24:17 +01:00
510b653330
Merge pull request #23723 from nextcloud/fix/dav_server_auth_init
...
Also run the SabreAuthInitEvent for the main server
2020-10-28 09:08:03 +01:00
e4288529fa
[tx-robot] updated from transifex
2020-10-28 02:18:52 +00:00
46ce7277c7
Also run the SabreAuthInitEvent for the main server
...
else for example trusted servers breaks
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-27 15:23:27 +01:00
ae54ae6c9b
[tx-robot] updated from transifex
2020-10-27 02:18:34 +00:00
9aedda5542
[tx-robot] updated from transifex
2020-10-23 02:18:51 +00:00
8ad1bf69f8
Merge pull request #23497 from nextcloud/bugfix/noid/caldav-timerange-array
...
CalDavBackend: check if timerange is array before accessing
2020-10-19 12:54:14 +02:00
9956d13b90
CalDavBackend: check if timerange is array before accessing
...
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2020-10-16 07:50:36 +02:00
b13d9bcca6
[tx-robot] updated from transifex
2020-10-16 02:18:11 +00:00
55b923e1fd
[tx-robot] updated from transifex
2020-10-13 19:33:40 +00:00
78da9532ba
Merge pull request #23317 from nextcloud/fix/contact-update
...
handle nested properties for contact updates
2020-10-12 21:49:04 +02:00
1b2386d108
handle nested properties, fixes #20544
...
Signed-off-by: call-me-matt <nextcloud@matthiasheinisch.de>
2020-10-12 21:27:38 +02:00
8ae4ff6648
[tx-robot] updated from transifex
2020-10-12 02:18:06 +00:00
d9c3b99907
[tx-robot] updated from transifex
2020-10-11 02:18:42 +00:00
9c21bd22b5
[tx-robot] updated from transifex
2020-10-09 02:18:45 +00:00
51fbcb0801
Use PSR Logger in event dispatcher
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-08 16:52:56 +02:00
ca5e8d2093
Merge pull request #23025 from Iscle/master
...
DirectController: Let users choose the link expiration time
2020-10-06 22:12:22 +02:00
5169976d2b
Merge pull request #23028 from nextcloud/bugfix/noid/array-to-string-conversion-on-event-search
...
Fix array to string conversion on event search
2020-10-05 23:04:48 +02:00
d9015a8c94
Format code to a single space around binary operators
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +02:00
a1faee8a1e
Fix unit tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-05 15:49:00 +02:00
0bca480efd
Merge pull request #22969 from eleith/catch-no-instance-exception
...
broaden exception handling on webcal refresh
2020-10-04 11:14:00 +02:00
0e5d692866
DirectController: Verify that expirationTime is between 0s and 24h
...
Signed-off-by: Iscle <albertiscle9@gmail.com>
2020-10-01 23:48:41 +02:00
aa956ab46e
broaden exception handling on webcal refresh
...
when iterating through a calendar, recurrance events can throw an
exception if no instances of the recurrance are found.
this exception is of class `Exception` but the try/catch clause in the
webcal refresh loop only catches `BadRequest` exception.
this leads to the exception bubbling up and thus other calendar events
do not get processed by the event iterator.
this PR broadens the exception to handle both BadRequest and
NoInstanceFoundException so that the full webcal can be processed, even
if minor hiccups are processing on vobject
Signed-off-by: leith abdulla <online-nextcloud@eleith.com>
2020-09-29 20:47:38 -07:00
4175c3f499
Merge pull request #22983 from nextcloud/bugfix/noid/sync-all-users-to-systemaddressbook
...
Sync all users to the system addresssbook
2020-09-29 09:12:40 +02:00
8383b63b34
[tx-robot] updated from transifex
2020-09-29 02:17:55 +00:00
deddcbd817
Merge pull request #23034 from nextcloud/bugfix/noid/numeric-folders-thorw-on-mark-dirty
...
Fix numeric folders throwing on markDirty
2020-09-25 14:52:46 +02:00
6db5f53bc6
Fix numeric folders throwing on markDirty
...
TypeError: strpos() expects parameter 1 to be string, int given
The problem is that in cacheNode() we strip of any slashes, so
a folder "0/" will be trimmed to "0" and be used as an array key.
Since PHP automatically casts numeric array keys to integers,
you afterwards get $nodePath as int(0). Since it's now a number,
the strpos() function does not accept it anymore. Simply casting
$nodePath to a string again in the foreach solves the issue
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-24 15:02:30 +02:00
fe30bfd232
Update autloader
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-24 14:59:41 +02:00
cea7252874
Fix array to string conversion on event search
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-24 13:52:24 +02:00
260d0dff3b
[tx-robot] updated from transifex
2020-09-24 02:17:48 +00:00
ebd734dc86
DirectController: Let users choose the expiration time
...
Signed-off-by: Iscle <albertiscle9@gmail.com>
2020-09-24 01:27:33 +02:00
8b77aa6b4f
Sync all users to the system addresssbook
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-21 09:01:39 +02:00
bdc60ef9b2
[tx-robot] updated from transifex
2020-09-20 02:17:05 +00:00
48761481eb
Bump versions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-18 09:16:45 +02:00
f3ec3bfa4a
[tx-robot] updated from transifex
2020-09-18 02:16:56 +00:00
1639289b95
Update urls to stackoverflow.com to "HTTPS"
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-09-17 17:38:27 +02:00
99c9423766
Remove @suppress SqlInjectionChecker
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 15:53:56 +02:00
04a3580d19
Remove phan config - was replaced by Psalm
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 14:46:29 +02:00
869f3f5895
[tx-robot] updated from transifex
2020-09-15 10:48:26 +00:00
c1ff011990
Merge pull request #22799 from nextcloud/bugfix/noid/dont-log-microsoft-webdav-client-trying-to-tag
...
Don't log Microsoft WebDAV client trying to tag things
2020-09-14 14:43:54 +02:00
2dbd6424f7
Don't log Microsoft WebDAV client trying to tag things
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-11 11:52:05 +02:00
b5204a78cc
Mitigate encoding issue with user principal uri
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-09-10 16:00:03 +02:00
1dddf6adc7
Properly catch exception from writing to stream when copying a file
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-10 09:03:53 +02:00
1f7f93a695
Update license headers for Nextcloud 20 (again)
...
There are still lots of outdated headers, so time for another round of
updates.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-09-07 14:37:44 +02:00
54438c9d26
Merge pull request #21945 from nextcloud/fix-contact-download-picture
...
Changed Content-Disposition header to download Contact Photo with correct extension
2020-09-07 08:40:23 +02:00
da8cff9061
[tx-robot] updated from transifex
2020-09-07 02:16:39 +00:00
27fbab131c
[tx-robot] updated from transifex
2020-09-06 02:16:52 +00:00
e8a4feb1c6
Change Content-Disposition Header
...
- Make ALLOWED_CONTENT_TYPES public in order to use
- Add $fileName variable which uses "$node->getName()" to get the proper file name and "$file->getMimeType()" along with the ALLOWED_CONTENT_TYPES array in PhotoCache.php to get the proper file extension
- Make "$fileName" the name of the file in the Content-Disposition header when downloading a Contact's photo
- Add filename to the CardDAV integration image export test header
- Change headers in ImageExportPluginTest to reflect changes
Signed-off-by: Jacob Neplokh <me@jacobneplokh.com>
2020-09-05 11:46:25 -07:00
62ab3eb700
[tx-robot] updated from transifex
2020-09-05 02:16:45 +00:00
593d64d935
Merge pull request #17456 from brad2014/feature/brad2014/12391-improve-imip-mail-message-take-2
2020-09-04 19:53:02 +02:00
4cf29e598d
Do not keep the part file if the forbidden exception has retry set to false
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-03 11:00:24 +02:00
442af8c5d5
Minor cleanup: php-cs-fixer, tests, interface consistency
...
IMipPlugin.php Removed blank lines to make php-cs-fixer happy.
Minor cleanup: bugs found by Psalm static checker
IEMailTemplate: The public interface to addBodyListItem also needs to include the new plainIndent parameter.
IMipPlugin: Fixes an undefined variable for events that do not have DTEND. Also use explicit string conversion for parameters and properties in several places.
The new email template adds an additional blank line before "button" links in plain text, so the tests were fixed to include that additional blank line.
Signed-off-by: Brad Rubenstein <brad@wbr.tech>
2020-09-02 17:54:36 +02:00
41d95d9e5a
[tx-robot] updated from transifex
2020-08-30 02:16:07 +00:00
2bc4094deb
[tx-robot] updated from transifex
2020-08-29 02:17:47 +00:00
40e2339151
[tx-robot] updated from transifex
2020-08-28 02:16:21 +00:00
7685d1fc61
Merge pull request #22421 from nextcloud/group-folder-quota-warning
...
show better quota warning for group folders and external storage
2020-08-26 21:15:47 +02:00
06ae93b270
fix tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-08-26 15:46:24 +02:00
Vincent Petry
Joas Schilling
Roeland Jago Douma
Joas Schilling
Morris Jobke
Robin Appelman
Daniel Kesselberg
Christoph Wurst
Nextcloud bot
John Molakvoæ (skjnldsv)
John Molakvoæ
Sven Strickroth
Julius Härtl
eleith
Richard Steinmetz
leith abdulla
Simon Spannagel
call-me-matt
Christoph Wurst
Roeland Jago Douma
Iscle
eleith
J0WI
Georg Ehrke
Jacob Neplokh
Brad Rubenstein