28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
1584c9ae9c
Add visibility to all methods and position of static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
a7c8d26d31
Add visibility to all properties and move static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:48:31 +02:00
1762a409f9
Merge pull request #20422 from nextcloud/techdebt/format-control-structs-classes-methods
...
Format control structures, classes, methods and function
2020-04-10 16:38:23 +02:00
eba3726e1e
Merge pull request #19495 from nextcloud/preview-generate-batch
...
optimize batch generation of previews
2020-04-10 15:57:06 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
8f9bac26f8
fix preview generation tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-10 13:39:45 +02:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
fb64fda4d8
Merge pull request #20385 from nextcloud/skeeable-http-harden
...
harden seekable http stream a bit against failures
2020-04-10 08:34:52 +02:00
008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup
...
Remove all extra whitespace PSR2 does not like
2020-04-09 20:39:37 +02:00
64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords
...
Use php keywords in lowercase
2020-04-09 16:25:14 +02:00
3a415e4139
Remove space between switch case and colon
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:17:53 +02:00
f4c09f299d
Make sure there is exactly one newline after imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:14:31 +02:00
a8a06a82d2
Remove trailing whitespaces from comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:09:23 +02:00
44577e4345
Remove trailing and in between spaces
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
42625a46be
Remove spaces after method or function call
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:05:56 +02:00
60de74ac40
harden seekable http stream a bit against failures
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-09 14:37:01 +02:00
36b3bc8148
Use php keywords in lowercase
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 14:04:56 +02:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
7d386872e5
optimize batch generation of previews
...
by allowing the generation of multiple previews at once we save on having to find, open and decode the max-preview for every preview of the same file
the main use case for this is the preview generator app (pr for that comming next)
in my local testing this saves about 25% of time when using the preview generator app
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-09 12:50:59 +02:00
5cd12cd7c3
allow generating multiple preview sizes for a single file at once
...
this saves having to do some of the overhead multiple times
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-09 12:50:55 +02:00
2a529e453a
Use a blank line after the opening tag
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:50:14 +02:00
41b5e5923a
Use exactly one empty line after the namespace declaration
...
For PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +02:00
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
e9795d01f1
Merge pull request #16035 from nextcloud/share-search-hide-on-match
...
dont show remote and email options if we have an exact match for local user email
2020-04-09 00:08:34 +02:00
85e369cddb
Fix multiline comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +02:00
328fbddc19
Merge pull request #20360 from nextcloud/bugfix/20182/try-to-use-the-displayname-for-file-transfers
...
Try to use the display name of file transfers
2020-04-08 19:36:59 +02:00
ccbf3059ba
Close the streams in `writeStream` even when there is an exception
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-08 16:40:56 +02:00
124b109bc8
Add preview provider for Krita files
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-08 16:31:20 +02:00
a2e671c489
Extract preview from opendocument files
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-08 16:24:10 +02:00
0734582c06
Add abstract class to extract previews from files that are zip archives
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-08 16:24:09 +02:00
01c147a4a5
dont show remote and email options if we have an exact match for local user email
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-08 16:11:09 +02:00
f8a5812f98
Try to use the display name of file transfers
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-08 15:41:20 +02:00
547ba642c6
Merge pull request #18200 from nextcloud/enhancement/psr-logger
...
Add a PSR-3 logger adapter and make it injectable
2020-04-08 11:49:56 +02:00
1e086064f5
Move legacy classes from PSR0 to PSR4
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-07 08:48:00 +02:00
f5919d5b83
Merge pull request #20033 from nextcloud/s3-seekable-stream
...
Enable fseek for files in S3 storage
2020-04-06 21:38:49 +02:00
4a292126e5
Merge pull request #20139 from nextcloud/unify-default-value-for-restricting-user-enumeration-with-settings
...
Unify default value for restricting user enumeration with settings
2020-04-04 10:33:04 +02:00
56aa8fd035
Properly hint exceptions thrown by getUserFolder
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-03 23:06:26 +02:00
e22a28ecc2
update autoloader
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-03 16:27:20 +02:00
a688f47a2f
Merge pull request #19486 from nextcloud/scanner-performance
...
Improve performance of file scanner
2020-04-02 20:40:06 +02:00
bc6a5ef5c4
Merge pull request #19890 from nextcloud/enh/comments-reference-id
...
Add optional comments reference_id
2020-04-02 11:34:21 +02:00
3ba46f3b50
add basic tests for s3 seeking and add some error handling if reopen return the wrong range
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-01 15:23:05 +02:00
7b07e7251c
make seekable s3 stream generic
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-01 15:21:05 +02:00
14401efb0f
Enable fseek for files in S3 storage
...
Signed-off-by: Lukas Stabe <lukas@stabe.de>
2020-04-01 15:21:01 +02:00
c1368b8696
Merge pull request #19781 from nextcloud/quota-include-external-dont-use-current-user
...
Dont always use the current users quota when calculating storage info
2020-04-01 12:24:21 +00:00
d9184584e0
restart transaction when cache insert fails due to duplicate
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-01 14:17:34 +02:00
5199f80196
call cache->insert directly instead of going trough cache->put first when scanning
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-01 14:17:28 +02:00
9c7da26394
dont try to get existing cache data during scanning if we already know its a new file
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-01 14:17:25 +02:00
3fb32f6f3d
reuse known parentId when inserting cache entries in scanner
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-01 14:14:52 +02:00
5439469b68
optimize getMetaData for local storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-01 14:14:48 +02:00
19ca921676
Merge pull request #20241 from nextcloud/fix/license-headers-19
...
Update the license headers for Nextcloud 19
2020-04-01 12:44:21 +02:00
590849e4d7
Merge pull request #19858 from nextcloud/feature/webauthn
...
Add WebAuthn support
2020-03-31 22:55:13 +02:00
53db05a1f6
Start with webauthn
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-03-31 22:17:07 +02:00
f04f34b94b
Make password nullable in LoginData
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-03-31 21:52:01 +02:00
84f3d2ddeb
[POC] Event for failed login attempts
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-03-31 21:41:02 +02:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
60d9384e5e
Optionally write the reference id into the database
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-31 10:51:16 +02:00
a20e81f0f3
Allow to set and get the reference id
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-31 10:51:16 +02:00
720dc4e93d
Add optional column oc_comments.reference_id
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-31 10:51:15 +02:00
58a192f05d
Update util.php
2020-03-28 16:17:21 +01:00
1b4952bfb2
Update Config.php
2020-03-28 16:16:41 +01:00
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
...
Remove unused imports
2020-03-27 17:14:08 +01:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
51d174a40b
Also bail out when the path is actually null
...
Apparently this can happen when a external mount was shared
that is later not available anymore
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-26 13:49:47 +01:00
1b4380aae8
Add a PSR-3 logger adapter and make it injectable
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 10:52:10 +01:00
74936c49ea
Remove unused imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +01:00
23eb0462e5
Use lowercase true, false and null constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 21:53:04 +01:00
ba14c41a1c
Merge pull request #20145 from nextcloud/bugfix/noid/generated-avatars-and-nophoto-cache
...
Fix generated avatars and nophoto cache files
2020-03-25 11:14:13 +01:00
b93e1e300e
Merge pull request #14722 from tacruc/GpgMailerHooks
...
Add Mailer events
2020-03-25 08:10:04 +01:00
b300dc5a50
Merge pull request #19782 from nextcloud/quota-wrapper-include-external
...
Use global used space in quota wrappen when external storage is included
2020-03-24 21:36:01 +01:00
a16aa99586
Added Hook before Message is send
...
Signed-off-by: Arne Hamann <kontakt+github@arne.email>
2020-03-24 20:57:27 +01:00
3b26bfe879
Merge pull request #20127 from nextcloud/bugfix/noid/check-user-on-remote-wipe
...
Check the user on remote wipe
2020-03-24 20:26:52 +01:00
f3a5bd6753
Fix generated avatars and nophoto cache files
...
Since nextcloud/server#19493 newFile() by default does not write the file anymore.
Setting an empty string as content will make it write the file immediate,
without having to call putContent() afterwards.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-24 18:23:38 +01:00
d4f25b01b8
Unify default value for restricting user enumeration with settings
...
If the value was never enabled or disabled, the settings show "Restrict
username enumeration to groups" as disabled. However, in some components
it was enabled by default, which caused an inconsistency in the
behaviour with respect to the settings, for example in the contacts
menu.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-03-24 14:30:59 +01:00
63900d0574
Remove admin_notifications since it is obsolete since Nextcloud 14
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-24 09:18:42 +01:00
6675f9b403
Merge pull request #17684 from mlatief/support-no-proxy
...
Add support for GuzzleHTTP 'no' proxy
2020-03-22 19:38:01 +01:00
8edc824526
Expose enumeration config though share manager
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-20 10:43:56 +01:00
49e7576ae0
Limit enumeration in contacts store
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-20 10:43:56 +01:00
c97ab39acb
Limit user search in Collaborators plugins
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-20 10:43:56 +01:00
0c38569c83
Implement occ command security:bruteforceattemps:reset-for-ip
...
Signed-off-by: Johannes Riedel <joeried@users.noreply.github.com>
2020-03-19 16:20:22 +01:00
dc7913efcd
Fix recursive calls in logging via server methods
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-18 18:59:49 +01:00
ca54813cbb
Merge pull request #19978 from nextcloud/harden/check_for_owner
...
Actually check if the owner is not null
2020-03-18 13:38:35 +01:00
557c4966a0
Merge pull request #19981 from nextcloud/enh/reset_target_if_null_after_share
...
Update the target when it isempty after sharing
2020-03-18 13:36:46 +01:00
b944115a35
Update the target when it isempty after sharing
...
Hooks that listen to it (audit log) benefit from having the target
properly set.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-03-16 13:38:55 +01:00
3443a00621
Actually check if the owner is not null
...
Else this can error out on storages that do not have an owner (e.g.
groupfolders).
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-03-16 13:12:10 +01:00
9935c71ec3
Check the user on remote wipe
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-16 09:29:28 +01:00
c1152af523
Move deprecated aliases over to new registration
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-03-15 15:13:12 +01:00
20f4a8c046
Add a deprecated alias registration to find deprecated usages
...
Fixes #19345
Basically just a stupid wrapper with extra logging. So that we can at
least inform people they are using the wrong methods.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-03-15 15:13:10 +01:00
0ffa598136
Merge pull request #19954 from roscomputing/fix/19941/fix_safari_useragent
...
fix safari useragent for versions with 3 digits
2020-03-15 13:15:40 +01:00
f11dee9bc4
fix safari useragent for versions with 3 digits
...
Signed-off-by: Pavel Krasikov <klonishe@gmail.com>
2020-03-14 16:47:28 +03:00
186c7f1b4b
Handle unset owner in sharing
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-13 17:17:43 +01:00
a54c4b60a8
Merge pull request #19910 from nextcloud/bugfix/noid/invalid-from-mail
...
Do not use the instance name as user part of from mail addresses
2020-03-13 10:17:12 +01:00
b5902b3e1b
Merge pull request #19888 from nextcloud/fix/objectstore_rename_mimetype
...
Get correct mimetype on objectstores
2020-03-12 19:58:16 +01:00
76a706738b
Do not use the instance name as user part of from mail addresses
...
This will cause issues since the theming name can contain characters
that are not allowed in the local part of the mail address (like spaces)
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-12 14:20:03 +01:00
5a574737ad
Only load required scripts on install page
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-11 14:20:30 +01:00
9a35e789b4
Get correct mimetype on objectstores
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-03-11 11:14:12 +01:00
5e4ee4dc59
Merge pull request #19812 from nextcloud/enh/noid/subscription-config
...
Add config flag for subscription and hide server development notice
2020-03-10 19:39:03 +01:00
dbd63222c8
Add system config flag to manually set that a subscription is available
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-10 14:31:27 +01:00
b6245be302
Merge pull request #19746 from nextcloud/locked-exception-forward-existing
...
pass the existing locks info when making locked exception with absolu…
2020-03-09 19:31:45 +01:00
1f7cb027a4
Merge pull request #19820 from nextcloud/fix/mismatching-docblock-return-type
...
Fix mismatching docblock return types
2020-03-09 17:43:17 +01:00
df9e2b828a
Fix mismatching docblock return types
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-06 16:38:25 +01:00
5fc4c91a76
Fix mismatching doc block parameter types
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-06 16:28:42 +01:00
672b7ad1bc
Merge pull request #19743 from nextcloud/cache-updater-storage-mtime-false
...
dont try to update storage mtime if we can't get the mtime
2020-03-05 11:21:58 +01:00
c32750ddd9
Use global used space in quota wrappen when external storage is included
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-04 18:02:50 +01:00
93411a2ea0
Dont always use the current users quota when calculating storage info
...
instead pass the quota as parameter.
Without this fix, when 'quota_include_external_storage' is enabled, the
webui will show the quota configured for the admin for every user
instead of the users quota
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-04 17:20:27 +01:00
fab22ac14c
pass the existing locks info when making locked exception with absolute paths
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-02 19:29:44 +01:00
b54069189c
Merge pull request #19742 from nextcloud/bug/19740/add-msg-for-exception
...
Add message for DoesNotExistException
2020-03-02 16:19:30 +01:00
f972990469
dont try to update storage mtime if we can't get the mtime
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-02 15:57:25 +01:00
5ce9e73bad
Add message for DoesNotExistException
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-03-02 13:24:06 +01:00
98d6415264
Add support for GuzzleHTTP 'no' proxy
...
The custom config allows to setup a proxy URI that is passed to
GuzzleHTTP client as request options. Guzzle has the option to receive
an array of proxies for each URI scheme as well as 'no' key value pair
to provide a list of host names that should not be proxied to.
Guzzle would automatically populate these options with HTTPS_PROXY
and NO_PROXY environment variables. However, when providing a 'proxy'
request option, default values will be overriden and it is required to
explicitly provide the 'no' value if needed.
More info:
http://docs.guzzlephp.org/en/stable/request-options.html#proxy
This commit will add support for a new config 'proxyexclude', which
takes a list of host names to be excluded.
It will also provide 'proxy' request option as an array instead of a
string to Guzzle, and populate 'http' and 'https' URI schemes with
proxy URI, and 'no' with 'proxyexclude' list.
Also, if no 'proxy' is configured, it will leave out 'proxy' request
option, so it won't override Guzzle default values.
Sample config file includes a hint on how to explicitly sync
'proxyexclude' with NO_PROXY, and a note about default values.
Signed-off-by: Mohammed Abdellatif <m.latief@gmail.com>
2020-02-29 19:19:23 +02:00
63608ef461
allow writing content directly when creating new SimpleFile
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-02-28 12:55:22 +01:00
5ca1929e8c
Create SimpleFile only when writing the content
...
instead of first creating an empty file and then writing the content.
This solves the overhead of creating an empty file with the common pattern:
```php
$file = $simpleFilder->newFile('foo.txt');
$file->putContent('bar.txt');
```
roughly halving the number of storage and database operations that need to be done when creating a `SimpleFile`.
This is not automatically done with `File` because that has a more complex api which I'm more hesitant to touch.
Instead the `Folder::newFile` api has been extended to accept the content for the new file.
In my local testing, the overhead of first creating an empty file took about 20% of the time for preview generation
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-02-28 12:55:22 +01:00
f83589f75d
Merge pull request #19670 from nextcloud/techdebt/noid/allow-to-remove-listeners
...
Allow to remove listeners
2020-02-27 13:08:42 +01:00
3ffed42925
Allow to remove listeners
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-27 11:04:23 +01:00
a5a58649b3
Merge pull request #19433 from nextcloud/bugfix/noid/fix-installing-talk
...
Fix installing Talk due to hardcoded route
2020-02-26 00:10:54 +01:00
ab7f6dd3f5
Merge pull request #19528 from nextcloud/bugfix/noid/remove-user-root-from-error-message
...
Strip of users home path from share api message
2020-02-22 21:25:24 +01:00
daf1d74af9
Merge pull request #18227 from nextcloud/bug/17947/set-transaction-isolation-connect
...
Add event subscriber for transaction isolation level
2020-02-21 17:48:39 +01:00
dd9d4696f2
Merge pull request #19412 from nextcloud/fix/19404/make-favorite-public
...
Make TAG_FAVORITE public
2020-02-21 17:47:53 +01:00
9e699a8d21
Add event subscriber for transaction isolation level
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-02-21 09:59:08 +01:00
e97d643969
Strip of users home path from share api message
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-20 14:56:58 +01:00
3894dcb756
Hardcode Talk namespace to fix install due to global route
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-14 12:34:13 +01:00
b1a6f66fd9
when we receive intentional empty whats new info, do not try to show it
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-02-13 22:03:44 +01:00
dc050fb5e5
Allow to overwrite the path on the cache event
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-13 08:38:33 +01:00
1db39e4eb4
Merge pull request #19424 from nextcloud/bugfix/noid/dont-create-invalid-users
...
Don't create invalid users
2020-02-12 20:26:57 +01:00
d06ef07a97
disable timeout on app install via cli
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-02-12 16:52:45 +01:00
6235175b6d
Make TAG_FAVORITE public
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-02-12 15:11:58 +01:00
08cadf8416
Don't create invalid users
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-12 10:55:27 +01:00
c469bc85d5
Allow to serve static mp4 directly
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-02-12 10:36:59 +01:00
54c84b95ac
Allow to serve static webm directly
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-02-12 08:42:34 +01:00
1b07dcf35c
Merge pull request #18904 from nextcloud/enh/noid/flow-logging
...
Log Flow activity
2020-02-10 15:09:51 +01:00
12e1c469cf
Add Argon2id support
...
When available we should use argon2id for hashing.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-02-07 07:52:33 +01:00
3a0bfbd558
Merge pull request #18926 from nextcloud/fix/18689/int-array-access
...
Array access on int will fail on php7.4
2020-02-06 21:31:03 +01:00
3b14cec766
Merge pull request #17075 from nextcloud/enh/samesitecookies
...
Only send samesite cookies
2020-02-06 20:37:45 +01:00
c5c3178422
Merge pull request #19303 from nextcloud/test/debug-install
...
Fix occ maintenance:install database connect failure
2020-02-06 19:36:53 +01:00
2016e57eab
Only send samesite cookies
...
This makes the last remaining two cookies lax. The session cookie
itself. And the session password as well (on php 7.3 that is). Samesite
cookies are the best cookies!
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-02-06 15:24:35 +01:00
fca8f061ab
Split the exception handling so install errors don't log as setup errors
...
More gebuging
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-05 13:55:17 +01:00
ac89b6abe7
Check the new connection on setup like with PostgreSQL and Oracle
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-05 13:55:16 +01:00
0aa216fc48
Only provide the auth method for MySQL 8.0+ to not break MariaDB
...
Provide the auth method for MySQL 8.0+
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-05 13:54:57 +01:00
13cfb352ab
Merge pull request #19165 from Simounet/fix/data-apache-htaccess-typo
...
Fix data Apache2 .htaccess typo
2020-02-05 12:32:05 +01:00
a98f8b51c7
Fix data Apache2 .htaccess typo
...
Signed-off-by: Simounet <contact@simounet.net>
2020-02-05 11:17:58 +01:00
889fbcb006
Merge pull request #19246 from sammo2828/decrypt-all-keep-mtime
...
Keep the modification time during decryptFile
2020-02-04 15:54:58 +01:00
0d651f106c
Allow selecting the hashing algorithm
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-02-03 21:41:17 +01:00
4c7bd11fc8
for the DB ot pick an index specify the object_type
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-02-03 16:17:25 +01:00
1b33116e8f
Merge pull request #19241 from nextcloud/bug/noid/job-catch-throwable
...
Make sure to catch php errors during job execution
2020-02-03 09:54:26 +01:00
bb0c69524b
Keep the modification time during decryptFile
2020-02-01 16:20:33 +11:00
bfaf3fff33
Move Admin Settings also to info.xml
...
More cleanup of the Settings apps. Makes the manager cleaner and a
proper manager.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-31 16:55:17 +01:00
018020108b
Make sure to catch php errors during job execution
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-01-31 16:04:04 +01:00
4765f5b3db
Merge pull request #19215 from nextcloud/bugfix/19146/webcal_not_updated
...
WebcalRefreshJob: Fix reading refresh rate
2020-01-31 08:18:09 +01:00
c9253cce6c
Move personal settings to proper registration
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-30 22:06:28 +01:00
dc1979903e
Move password settings
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-30 14:03:28 +01:00
eda599973d
JobList: Typecast last_run to integer
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-01-30 12:01:02 +01:00
9ed106f69a
Merge pull request #19176 from nextcloud/fix/contacts-menu-mailt-encoding
...
Do not encode contacts menu mailto links
2020-01-30 09:45:13 +01:00
b490c7cab1
Merge pull request #19174 from nextcloud/enh/settings/admin_sectorions_to_proper_app
...
Move admin sections to settings app
2020-01-29 10:10:39 +01:00
c5bc317681
Make sure the default share provider does not execute for other things
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-01-28 16:00:03 +01:00
87ec729f34
Do not encode contacts menu mailto links
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-01-28 14:57:45 +01:00
e008444887
always require a message paramter for data logging
...
also ensure it plays well with current log reader
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-01-28 13:00:13 +01:00
03df1b4c51
Move admin sections to settings app
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-28 12:38:11 +01:00
46aaeb4561
log Flow activity
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-01-28 10:58:57 +01:00
d8e9cefcfe
Move the Personal sections to the settings app
...
There is no need to have weird magic in the manager. This should be
properly registered in the right way. The settings code is messy
anyways. This is a start to make it a tad more clean.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-28 08:45:07 +01:00
55c17a3571
Fix tests after #18745
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-27 20:17:16 +01:00
acc0df1d13
Change avatar placeholder from single letter to 2 letters
...
https://github.com/nextcloud/server/issues/18717
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
2020-01-27 09:42:45 +01:00
5b18f684e7
add hub bundle for easy post-installation
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-01-26 21:23:42 +01:00
30d985b639
Migrate leafo/scssphp to scssphp/scssphp
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-01-23 14:52:16 +01:00
2f27f122e1
Merge pull request #19023 from nextcloud/enh+fix/17131/hasher-config
...
expose Argon2 options (as we did for bcrypt)
2020-01-23 11:47:43 +01:00
96d1640a37
Use strpos to check that @ is the first char
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-01-23 10:25:52 +01:00
f92ba2cebe
ignore values that undershoot the minimum, go with default
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-01-22 16:04:57 +01:00
d445f9b9fe
Fix loaded controller check
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-01-21 16:35:10 +01:00
56c3ba6ac7
use getSystemValueInt
...
Co-Authored-By: kesselb <mail@danielkesselberg.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-01-21 09:04:53 +01:00
d9a7e16a3b
Merge pull request #19017 from nextcloud/bugfix/noid/increase-timeout-for-downloads
...
Increase the timeout for app downloads
2020-01-20 21:40:42 +01:00
171bb98229
expose Argon2 options (as we did for bcrypt)
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-01-20 18:21:50 +01:00
c7e81c2c52
Increase the timeout for app downloads
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-01-20 16:20:09 +01:00
8331d8296b
Make getServerHost more robust to faulty user input
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-01-16 11:26:29 +01:00
9daf35b704
Merge pull request #18892 from nextcloud/fix/17828/smaller_text_previews
...
Proper text previews
2020-01-15 07:24:12 +01:00
17256781a6
Proper text previews
...
Fixes #17828
* Modified the preview provider to provider smaller fonts for the
previes (so it is not so screaming)
* Modified the sidebar to show plain text and markdown files full size.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-01-14 22:38:04 +00:00
47fd6730e0
use `nodeExists` instead of catching exceptions
...
makes the intent of the code more clear imo
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-01-14 11:03:14 +01:00
bda67669bd
Merge pull request #18862 from nextcloud/bugfix/talk-2663/register-with-potentially-updated-namespace
...
Register with potentially updated namespace
2020-01-14 08:37:09 +01:00
e7b308cf0a
Merge pull request #18805 from nextcloud/bugfix/direct-edit-create
...
Check if file already exists during file creation
2020-01-14 08:34:39 +01:00
ab4b9a6df5
CHeck if file already exists during file creation
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-13 18:10:12 +01:00
1bf44e1d97
Merge pull request #18860 from nextcloud/fix/license-headers
...
Fix license headers
2020-01-13 16:47:12 +01:00
df9edf0108
Allow to force register the namespace
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-01-13 15:15:50 +01:00
efcf246f07
Register the namespace after reading the new file
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-01-13 15:15:49 +01:00
6127c288e8
Fix license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-01-13 14:23:49 +01:00
2f89f5fd13
AppFetcher: Distinguish between fileName and endpointName
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-01-09 17:29:00 +01:00
60d4b45e89
Clean up 2FA provider registry when a user is deleted
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-01-08 10:51:44 +01:00
fb6b84b5c9
Accept shares when you open mail
...
Fixes #18380
When you open a direct share to yourself. We should autoaccept the
share.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-06 16:48:21 +01:00
d393b1612b
Modify regex to match some other chromium browsers
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-12-27 17:24:52 +01:00
ac96554aaa
Fix broken upgrade caused by undefined method call
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-12-23 10:41:41 +01:00
323fe46ba1
Merge pull request #18536 from nextcloud/enhancement/preview-center-vertically
...
Also center vertically when cropping previews
2019-12-23 08:36:10 +01:00
e5d77822c8
Merge pull request #18442 from nextcloud/bugfix/noid/broken_appstoreurl_config
...
Restore old behavior allowing to set custom appstore
2019-12-22 20:18:21 +01:00
a5f6ec74ce
Merge pull request #18511 from Al2Klimov/bugfix/movie-getthumbnail
...
Movie#getThumbnail(): compare Movie#generateThumbNail() to null, not false
2019-12-22 20:13:04 +01:00
6df44e407a
Also center vertically when cropping previews
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-12-22 15:07:11 +01:00
f0bef8881d
Restore old behavior allowing to set custom appstore
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-12-22 15:06:31 +01:00
04031f606a
Merge pull request #18478 from nextcloud/fix/direct-editing-invalid-editor-id
...
Do not generate tokens for editor IDs that do not exist
2019-12-22 14:27:28 +01:00
3af63f1593
Merge pull request #18505 from nextcloud/bugfix/18481/avatars-always-return-201-status-code
...
Always set the generated flag to false when an avatar is being set
2019-12-22 14:26:23 +01:00
7cc2143bb3
Movie#getThumbnail(): compare Movie#generateThumbNail() to null, not false
...
Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
2019-12-21 08:55:51 +01:00
e37af2d81c
Always set the generated flag to false when an avatar is being set
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-12-20 15:34:36 +01:00
1b46621cd3
Update license headers for 18
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-20 09:23:25 +01:00
af91efd315
when downloading from web, skip files that are not accessible
...
* avoids a 403, but enables download of resources that are not restricted
* single file downloads still cause 403
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-12-19 13:05:10 +01:00
79eae96f45
use Nodes API for zip streaming
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-12-19 13:05:09 +01:00
9e5d6114d5
Use files node API for single file downloads
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-12-19 13:05:09 +01:00
Christoph Wurst
Christoph Wurst
Roeland Jago Douma
Robin Appelman
blizzz
Julius Härtl
Joas Schilling
Joas Schilling
Lukas Stabe
Roeland Jago Douma
John Molakvoæ
Arne Hamann
Daniel Calviño Sánchez
Johannes Riedel
Pavel Krasikov
Daniel Kesselberg
Mohammed Abdellatif
Simounet
sammo2828
Georg Ehrke
Sergey Shliakhov
John Molakvoæ (skjnldsv)
Alexander A. Klimov